[GitHub] [pulsar] eolivelli commented on pull request #9232: Allow to configure BookKeeper Opportunistic Striping Feature (and all BK client features using bookkeeper_ prefix)

2021-01-24 Thread GitBox
eolivelli commented on pull request #9232: URL: https://github.com/apache/pulsar/pull/9232#issuecomment-766622808 @sijie can you please take another look ? This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] RobertIndie commented on pull request #9244: [Authentication]Add authentication metrics

2021-01-24 Thread GitBox
RobertIndie commented on pull request #9244: URL: https://github.com/apache/pulsar/pull/9244#issuecomment-766608569 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] hangc0276 commented on pull request #9261: remove consumer unnecessary locks

2021-01-24 Thread GitBox
hangc0276 commented on pull request #9261: URL: https://github.com/apache/pulsar/pull/9261#issuecomment-766599202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive

2021-01-24 Thread GitBox
hangc0276 commented on pull request #9295: URL: https://github.com/apache/pulsar/pull/9295#issuecomment-766599303 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] congbobo184 commented on issue #7763: Producers are Failing to Create when Connecting to a "Non-Persistent Partitioned Replicated" Topic

2021-01-24 Thread GitBox
congbobo184 commented on issue #7763: URL: https://github.com/apache/pulsar/issues/7763#issuecomment-766597391 I haven't tested anything wrong with the current master branch. can you provide specific steps to reproduce? (topic name, namespace name, broker version, autoCreateTopicConfig and

[GitHub] [pulsar] saosir removed a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages

2021-01-24 Thread GitBox
saosir removed a comment on pull request #9134: URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766484231 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages

2021-01-24 Thread GitBox
saosir commented on pull request #9134: URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766591621 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] codelipenghui opened a new pull request #9305: Add release note for 2.6.3.

2021-01-24 Thread GitBox
codelipenghui opened a new pull request #9305: URL: https://github.com/apache/pulsar/pull/9305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pulsar] pointearth commented on issue #6930: Pulsar SQL: support user defined indexes

2021-01-24 Thread GitBox
pointearth commented on issue #6930: URL: https://github.com/apache/pulsar/issues/6930#issuecomment-766553311 I think user-defined indexes are very important for Pulsar SQL, it could be able to be the real way that we can use pulsar as a database. I think it will make pulsar more popular.

[GitHub] [pulsar] jerrypeng opened a new pull request #9304: Add additional logging when setting up state table for function instance

2021-01-24 Thread GitBox
jerrypeng opened a new pull request #9304: URL: https://github.com/apache/pulsar/pull/9304 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] RobertIndie commented on pull request #9244: [Authentication]Add authentication metrics

2021-01-24 Thread GitBox
RobertIndie commented on pull request #9244: URL: https://github.com/apache/pulsar/pull/9244#issuecomment-766543129 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] RobertIndie commented on pull request #9253: [Spotbugs] Enable spotbugs in pulsar-metadata

2021-01-24 Thread GitBox
RobertIndie commented on pull request #9253: URL: https://github.com/apache/pulsar/pull/9253#issuecomment-766543023 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar-client-go] flowchartsman edited a comment on issue #434: Regex consumer throws multiple unnecessary errors on topic deletion

2021-01-24 Thread GitBox
flowchartsman edited a comment on issue #434: URL: https://github.com/apache/pulsar-client-go/issues/434#issuecomment-766530582 (See supplementary discussion in #433 / #448) This is an automated message from the Apache Git

[GitHub] [pulsar-client-go] flowchartsman edited a comment on issue #434: Regex consumer throws multiple unnecessary errors on topic deletion

2021-01-24 Thread GitBox
flowchartsman edited a comment on issue #434: URL: https://github.com/apache/pulsar-client-go/issues/434#issuecomment-766530582 (See supplementary discussion in #433 / #448 This is an automated message from the Apache Git S

[GitHub] [pulsar-client-go] flowchartsman commented on issue #434: Regex consumer throws multiple unnecessary errors on topic deletion

2021-01-24 Thread GitBox
flowchartsman commented on issue #434: URL: https://github.com/apache/pulsar-client-go/issues/434#issuecomment-766530582 (See supplementary discussion in #433) This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar-client-go] flowchartsman edited a comment on issue #448: Access to partitionConsumer state not thread-safe.

2021-01-24 Thread GitBox
flowchartsman edited a comment on issue #448: URL: https://github.com/apache/pulsar-client-go/issues/448#issuecomment-766529628 Preliminary testing with `go.uber.org/atomic` indicates that this indeed eliminates the race in the referenced test. ```diff diff --git a/go.mod b/go.mo

[GitHub] [pulsar] codelipenghui commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

2021-01-24 Thread GitBox
codelipenghui commented on a change in pull request #9302: URL: https://github.com/apache/pulsar/pull/9302#discussion_r563455692 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -1826,6 +1826,13 @@ ) private bo

[GitHub] [pulsar-client-go] flowchartsman commented on issue #448: Access to partitionConsumer state not thread-safe.

2021-01-24 Thread GitBox
flowchartsman commented on issue #448: URL: https://github.com/apache/pulsar-client-go/issues/448#issuecomment-766529628 Preliminary testing with `go.uber.org/atomic` indicates that this indeed eliminates the race in the referenced test. ```diff diff --git a/go.mod b/go.mod in

[GitHub] [pulsar] wuYin removed a comment on issue #9297: proxy lookup result still contains unreachable owner broker serviceURL after broker restart and 30s zk session expired

2021-01-24 Thread GitBox
wuYin removed a comment on issue #9297: URL: https://github.com/apache/pulsar/issues/9297#issuecomment-766526568 @zymap thanks for review Actually, I'm not sure this ownership double check PR will solve the flaky Issue I'll add test to simulate flaky case by removing the /loadbalance/

[GitHub] [pulsar] wuYin commented on pull request #9298: [Issue 9297][broker] Try to fix flaky infinite reconnection

2021-01-24 Thread GitBox
wuYin commented on pull request #9298: URL: https://github.com/apache/pulsar/pull/9298#issuecomment-766526674 @zymap thanks for review Actually, I'm not sure this ownership double check PR will solve the flaky Issue I'll add test to simulate flaky case by removing the /loadbalance/dow

[GitHub] [pulsar] wuYin commented on issue #9297: proxy lookup result still contains unreachable owner broker serviceURL after broker restart and 30s zk session expired

2021-01-24 Thread GitBox
wuYin commented on issue #9297: URL: https://github.com/apache/pulsar/issues/9297#issuecomment-766526568 @zymap thanks for review Actually, I'm not sure this ownership double check PR will solve the flaky Issue I'll add test to simulate flaky case by removing the /loadbalance/downBrok

[pulsar-manager] branch master updated: 362 fix retention size label (#372)

2021-01-24 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 9308143 362 fix retention size label

[GitHub] [pulsar-client-go] flowchartsman opened a new issue #448: Access to partitionConsumer state not thread-safe.

2021-01-24 Thread GitBox
flowchartsman opened a new issue #448: URL: https://github.com/apache/pulsar-client-go/issues/448 As part of my testing of the fix for #432, I have discovered a race condition in consumer_partition.go where access to the struct's `state` member is modified concurrently without synchronizat

[GitHub] [pulsar] zymap commented on pull request #9298: [Issue 9297][broker] Try to fix flaky infinite reconnection

2021-01-24 Thread GitBox
zymap commented on pull request #9298: URL: https://github.com/apache/pulsar/pull/9298#issuecomment-766518711 Looks like tests failed by this change: ``` Error: Failures: Error: org.apache.pulsar.broker.namespace.OwnershipCacheTest.testGetOwner(org.apache.pulsar.broker.namespace

[GitHub] [pulsar-client-go] flowchartsman commented on pull request #433: Issue #432 propagate disableForceTopicCreation

2021-01-24 Thread GitBox
flowchartsman commented on pull request #433: URL: https://github.com/apache/pulsar-client-go/pull/433#issuecomment-766518649 This test appears to have exposed a race condition in access to the state of the partition consumer. Output from local testing: ``` WARNING: DATA RACE

[GitHub] [pulsar] zymap commented on pull request #9300: [Pulsar SQL] Fix OffloadPolicies json serialization error in Pulsar SQL

2021-01-24 Thread GitBox
zymap commented on pull request #9300: URL: https://github.com/apache/pulsar/pull/9300#issuecomment-766518015 ``` 01:19:21.875 [main:org.apache.pulsar.tests.integration.topologies.PulsarCluster@438] INFO org.apache.pulsar.tests.integration.topologies.PulsarCluster - [startPrestoWorker

[GitHub] [pulsar] jiazhai commented on issue #7814: Function's context's logger does not log to the log-topic

2021-01-24 Thread GitBox
jiazhai commented on issue #7814: URL: https://github.com/apache/pulsar/issues/7814#issuecomment-766517889 Thanks @freeznet for helping with this issue This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] RobertIndie commented on pull request #9253: [Spotbugs] Enable spotbugs in pulsar-metadata

2021-01-24 Thread GitBox
RobertIndie commented on pull request #9253: URL: https://github.com/apache/pulsar/pull/9253#issuecomment-766514793 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] codelipenghui opened a new pull request #9303: Add 2.6.3 for versions.json and releases.json

2021-01-24 Thread GitBox
codelipenghui opened a new pull request #9303: URL: https://github.com/apache/pulsar/pull/9303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pulsar] Renkai commented on pull request #9096: PIP 76: Streaming Offload(Part I)

2021-01-24 Thread GitBox
Renkai commented on pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#issuecomment-766512419 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] jerrypeng commented on a change in pull request #9275: WIP Enable Function Workers to use exclusive producer to write to internal topics

2021-01-24 Thread GitBox
jerrypeng commented on a change in pull request #9275: URL: https://github.com/apache/pulsar/pull/9275#discussion_r563441667 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java ## @@ -343,4 +349,47 @@ public static boolean i

[GitHub] [pulsar] jerrypeng commented on a change in pull request #9275: WIP Enable Function Workers to use exclusive producer to write to internal topics

2021-01-24 Thread GitBox
jerrypeng commented on a change in pull request #9275: URL: https://github.com/apache/pulsar/pull/9275#discussion_r563441114 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java ## @@ -343,4 +349,47 @@ public static boolean i

[GitHub] [pulsar] Renkai commented on pull request #9096: PIP 76: Streaming Offload(Part I)

2021-01-24 Thread GitBox
Renkai commented on pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#issuecomment-766510403 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-go] flowchartsman commented on pull request #433: Issue #432 propagate disableForceTopicCreation

2021-01-24 Thread GitBox
flowchartsman commented on pull request #433: URL: https://github.com/apache/pulsar-client-go/pull/433#issuecomment-766508804 @merlimat Test committed. Verified working and verified that it fails without ```go disableForceTopicCreation: c.disableForceTopicCreation, ``` --

[GitHub] [pulsar] jiazhai commented on pull request #9299: [fix #7814] fix java function logging appender not added to java function logger

2021-01-24 Thread GitBox
jiazhai commented on pull request #9299: URL: https://github.com/apache/pulsar/pull/9299#issuecomment-766507429 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] codelipenghui commented on pull request #9284: [Pulsar Admin] Expose schema ledger in `topic stats-internal`

2021-01-24 Thread GitBox
codelipenghui commented on pull request #9284: URL: https://github.com/apache/pulsar/pull/9284#issuecomment-766505917 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[pulsar] branch master updated (b4ee611 -> 5c0de17)

2021-01-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b4ee611 Support fetching metadata from entry data in publish callback (#9257) add 5c0de17 [issue #9183] add mi

[GitHub] [pulsar] sijie closed issue #9183: [doc] Kubernetes runtime docs not cover all configs

2021-01-24 Thread GitBox
sijie closed issue #9183: URL: https://github.com/apache/pulsar/issues/9183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] sijie merged pull request #9192: [issue #9183] add missing configs to kubernetes runtime docs

2021-01-24 Thread GitBox
sijie merged pull request #9192: URL: https://github.com/apache/pulsar/pull/9192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie commented on a change in pull request #9246: [fix #8089] expose PulsarAdmin client through Function Context

2021-01-24 Thread GitBox
sijie commented on a change in pull request #9246: URL: https://github.com/apache/pulsar/pull/9246#discussion_r563436302 ## File path: pulsar-functions/api-java/pom.xml ## @@ -49,6 +49,13 @@ compile + + ${project.groupId} + pulsar-client-admin-origi

[pulsar] branch master updated (0e6bbc8 -> b4ee611)

2021-01-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0e6bbc8 [Python] Return MessageId in producer's synchronous send method (#9287) add b4ee611 Support fetching m

[GitHub] [pulsar] sijie merged pull request #9257: Support fetching metadata from entry data in publish callback

2021-01-24 Thread GitBox
sijie merged pull request #9257: URL: https://github.com/apache/pulsar/pull/9257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie commented on pull request #9300: [Pulsar SQL] Fix OffloadPolicies json serialization error in Pulsar SQL

2021-01-24 Thread GitBox
sijie commented on pull request #9300: URL: https://github.com/apache/pulsar/pull/9300#issuecomment-766503478 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[pulsar] branch master updated (47b05c4 -> 0e6bbc8)

2021-01-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 47b05c4 Fix: don't attempt to clean up packages when Source/Sink is builtin (#9289) add 0e6bbc8 [Python] Retur

[GitHub] [pulsar] sijie closed issue #9176: Python Client Producer Synchronous Send Void Return Value

2021-01-24 Thread GitBox
sijie closed issue #9176: URL: https://github.com/apache/pulsar/issues/9176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] sijie merged pull request #9287: [Python] Return MessageId in producer's synchronous send method

2021-01-24 Thread GitBox
sijie merged pull request #9287: URL: https://github.com/apache/pulsar/pull/9287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch master updated (a0cf37b -> 47b05c4)

2021-01-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a0cf37b Support get topic applied policy for MaxProducer (#9293) add 47b05c4 Fix: don't attempt to clean up pac

[GitHub] [pulsar] sijie merged pull request #9289: Fix: don't attempt to clean up packages when Source/Sink is builtin

2021-01-24 Thread GitBox
sijie merged pull request #9289: URL: https://github.com/apache/pulsar/pull/9289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie commented on a change in pull request #9290: Support get topic applied policy for MaxUnackedMessagesPerSubscription

2021-01-24 Thread GitBox
sijie commented on a change in pull request #9290: URL: https://github.com/apache/pulsar/pull/9290#discussion_r563434214 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java ## @@ -2731,7 +2731,7 @@ protected void internalSetMaxUna

[pulsar] branch master updated (37d778b -> a0cf37b)

2021-01-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 37d778b [Transaction] Transaction timeout implementation. (#9229) add a0cf37b Support get topic applied policy

[GitHub] [pulsar] sijie merged pull request #9293: Support get topic applied policy for MaxProducer

2021-01-24 Thread GitBox
sijie merged pull request #9293: URL: https://github.com/apache/pulsar/pull/9293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] hangc0276 closed pull request #9261: remove consumer unnecessary locks

2021-01-24 Thread GitBox
hangc0276 closed pull request #9261: URL: https://github.com/apache/pulsar/pull/9261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] hangc0276 closed pull request #9276: performanceReader add aggregate stats

2021-01-24 Thread GitBox
hangc0276 closed pull request #9276: URL: https://github.com/apache/pulsar/pull/9276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] hangc0276 closed pull request #9295: Performance consumer add batch receive

2021-01-24 Thread GitBox
hangc0276 closed pull request #9295: URL: https://github.com/apache/pulsar/pull/9295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] hangc0276 commented on pull request #9261: remove consumer unnecessary locks

2021-01-24 Thread GitBox
hangc0276 commented on pull request #9261: URL: https://github.com/apache/pulsar/pull/9261#issuecomment-766496055 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on pull request #9295: Performance consumer add batch receive

2021-01-24 Thread GitBox
hangc0276 commented on pull request #9295: URL: https://github.com/apache/pulsar/pull/9295#issuecomment-766495999 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] hangc0276 commented on pull request #9276: performanceReader add aggregate stats

2021-01-24 Thread GitBox
hangc0276 commented on pull request #9276: URL: https://github.com/apache/pulsar/pull/9276#issuecomment-766495986 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] Renkai commented on pull request #9096: PIP 76: Streaming Offload(Part I)

2021-01-24 Thread GitBox
Renkai commented on pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#issuecomment-766495673 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-go] jonyhy96 edited a comment on issue #444: Some error results are commented

2021-01-24 Thread GitBox
jonyhy96 edited a comment on issue #444: URL: https://github.com/apache/pulsar-client-go/issues/444#issuecomment-763335144 /cc @wolfstudy @merlimat This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] jiazhai commented on pull request #9298: [Issue 9297][broker] Try to fix flaky infinite reconnection

2021-01-24 Thread GitBox
jiazhai commented on pull request #9298: URL: https://github.com/apache/pulsar/pull/9298#issuecomment-766489617 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages

2021-01-24 Thread GitBox
saosir commented on pull request #9134: URL: https://github.com/apache/pulsar/pull/9134#issuecomment-766484231 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] congbobo184 commented on pull request #9195: [Transaction] Transaction buffer stable position and lowWaterMark implementation.

2021-01-24 Thread GitBox
congbobo184 commented on pull request #9195: URL: https://github.com/apache/pulsar/pull/9195#issuecomment-766482089 @merlimat https://github.com/apache/pulsar/pull/9229#event-4243190060 have solved this problem. > @congbobo184 @codelipenghui Master seems to still be broken after this

[GitHub] [pulsar] MarvinCai commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

2021-01-24 Thread GitBox
MarvinCai commented on a change in pull request #9302: URL: https://github.com/apache/pulsar/pull/9302#discussion_r563418250 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java ## @@ -764,10 +766,11 @@ default void delete(String topic, bo

[pulsar] branch master updated (60161ed -> 37d778b)

2021-01-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 60161ed Fix peek message metadata broker while enable broker entry metadata. (#9255) add 37d778b [Transactio

[GitHub] [pulsar] codelipenghui merged pull request #9229: [Transaction] Transaction timeout implementation.

2021-01-24 Thread GitBox
codelipenghui merged pull request #9229: URL: https://github.com/apache/pulsar/pull/9229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] MarvinCai commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

2021-01-24 Thread GitBox
MarvinCai commented on a change in pull request #9302: URL: https://github.com/apache/pulsar/pull/9302#discussion_r563416467 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -1826,6 +1826,13 @@ ) private boolea

[GitHub] [pulsar] Renkai commented on pull request #9096: PIP 76: Streaming Offload(Part I)

2021-01-24 Thread GitBox
Renkai commented on pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#issuecomment-766475336 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] RobertIndie commented on pull request #9253: [Spotbugs] Enable spotbugs in pulsar-metadata

2021-01-24 Thread GitBox
RobertIndie commented on pull request #9253: URL: https://github.com/apache/pulsar/pull/9253#issuecomment-766474746 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] RobertIndie commented on pull request #9244: [Authentication]Add authentication metrics

2021-01-24 Thread GitBox
RobertIndie commented on pull request #9244: URL: https://github.com/apache/pulsar/pull/9244#issuecomment-766474716 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] zymap commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

2021-01-24 Thread GitBox
zymap commented on a change in pull request #9302: URL: https://github.com/apache/pulsar/pull/9302#discussion_r563409871 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -1826,6 +1826,13 @@ ) private boolean ex

[GitHub] [pulsar] codelipenghui commented on pull request #9300: [Pulsar SQL] Fix OffloadPolicies json serialization error in Pulsar SQL

2021-01-24 Thread GitBox
codelipenghui commented on pull request #9300: URL: https://github.com/apache/pulsar/pull/9300#issuecomment-766469036 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[pulsar] branch master updated: Fix peek message metadata broker while enable broker entry metadata. (#9255)

2021-01-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 60161ed Fix peek message metadata broker while

[GitHub] [pulsar] codelipenghui merged pull request #9255: Fix peek message metadata broker while enable broker entry metadata.

2021-01-24 Thread GitBox
codelipenghui merged pull request #9255: URL: https://github.com/apache/pulsar/pull/9255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] MarvinCai opened a new pull request #9302: Add subscription backlog size info for topicstats.

2021-01-24 Thread GitBox
MarvinCai opened a new pull request #9302: URL: https://github.com/apache/pulsar/pull/9302 Fixes #9254 ### Motivation Add ability to fetch backlog size for subscription, add flag in topic-stats partitioned-topic-stats for getting backlog size for subscriptions. ### Modifica

[GitHub] [pulsar] merlimat commented on a change in pull request #9292: [pulsar-broker] Support large number of unack message store for cursor recovery

2021-01-24 Thread GitBox
merlimat commented on a change in pull request #9292: URL: https://github.com/apache/pulsar/pull/9292#discussion_r563328917 ## File path: managed-ledger/src/main/proto/MLDataFormats.proto ## @@ -71,6 +71,9 @@ message PositionInfo { // Store which index in the batch messa

[pulsar] branch master updated: Remove Spring repo (#9280)

2021-01-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 93748d7 Remove Spring repo (#9280) 93748d7 is d

[GitHub] [pulsar] merlimat merged pull request #9280: Remove Spring repo

2021-01-24 Thread GitBox
merlimat merged pull request #9280: URL: https://github.com/apache/pulsar/pull/9280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] aryemazouz opened a new issue #9301: MultiTopicsReaderImpl – Start from separate MessageId for each topic/ partition

2021-01-24 Thread GitBox
aryemazouz opened a new issue #9301: URL: https://github.com/apache/pulsar/issues/9301 Currently in ReaderConfigurationData the API allow to ‘setStartMessageId’ only from single message ID and this apply to all consumers in the MultiTopicsReaderImpl. Is it possible to add start mess

[GitHub] [pulsar] gaoran10 commented on pull request #8422: [PIP-71][SQL]Pulsar SQL migrate SchemaHandle to presto decoder

2021-01-24 Thread GitBox
gaoran10 commented on pull request #8422: URL: https://github.com/apache/pulsar/pull/8422#issuecomment-766363539 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] gaoran10 opened a new pull request #9300: [Pulsar SQL] Fix OffloadPolicies json serialization error in Pulsar SQL

2021-01-24 Thread GitBox
gaoran10 opened a new pull request #9300: URL: https://github.com/apache/pulsar/pull/9300 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] Renkai commented on a change in pull request #9096: PIP 76: Streaming Offload(Part I)

2021-01-24 Thread GitBox
Renkai commented on a change in pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#discussion_r563301017 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/StreamingDataBlockHeaderImpl.java ## @@ -0,0 +1,139 @@

[GitHub] [pulsar] Renkai commented on a change in pull request #9096: PIP 76: Streaming Offload(Part I)

2021-01-24 Thread GitBox
Renkai commented on a change in pull request #9096: URL: https://github.com/apache/pulsar/pull/9096#discussion_r563300245 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1685,6 +1685,14 @@ void asyncReadEntries(OpRead

[GitHub] [pulsar] Renkai commented on pull request #9280: Remove Spring repo

2021-01-24 Thread GitBox
Renkai commented on pull request #9280: URL: https://github.com/apache/pulsar/pull/9280#issuecomment-766355932 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] freeznet commented on a change in pull request #9246: [fix #8089] expose PulsarAdmin client through Function Context

2021-01-24 Thread GitBox
freeznet commented on a change in pull request #9246: URL: https://github.com/apache/pulsar/pull/9246#discussion_r563293782 ## File path: pulsar-functions/api-java/pom.xml ## @@ -49,6 +49,13 @@ compile + + ${project.groupId} + pulsar-client-admin-or

[GitHub] [pulsar] freeznet opened a new pull request #9299: [fix #7814] fix java function logging appender not added to java function logger

2021-01-24 Thread GitBox
freeznet opened a new pull request #9299: URL: https://github.com/apache/pulsar/pull/9299 Fixes #7814 ### Motivation `JavaInstanceRunnable` create an instance of logger named `"function-" + instanceConfig.getFunctionDetails().getName()` and pass it to `Function Context`, and

[GitHub] [pulsar] wuYin opened a new pull request #9298: [Issue 9297][broker] Try to fix flaky infinite reconnection

2021-01-24 Thread GitBox
wuYin opened a new pull request #9298: URL: https://github.com/apache/pulsar/pull/9298 Fixes #9297 ### Motivation Try to fix flaky case which broker always returned unreachable address to client. ### Modifications Before broker response lookup result, check the

[GitHub] [pulsar] nodece commented on pull request #9172: Disallow parsing of token with none signature in authenticateToken

2021-01-24 Thread GitBox
nodece commented on pull request #9172: URL: https://github.com/apache/pulsar/pull/9172#issuecomment-766343089 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wuYin opened a new issue #9297: proxy lookup result still contains unreachable owner broker serviceURL after broker restart and 30s zk session expired

2021-01-24 Thread GitBox
wuYin opened a new issue #9297: URL: https://github.com/apache/pulsar/issues/9297 **Describe the bug** - Certain issue After broker restarted with 30s zk session expired, client take 51s, even 1min40s to reconnect successfully, recovery time is a bit long. - Flaky issue

[GitHub] [pulsar] congbobo184 commented on a change in pull request #9284: [Pulsar Admin] Expose schema ledger in `topic stats-internal`

2021-01-24 Thread GitBox
congbobo184 commented on a change in pull request #9284: URL: https://github.com/apache/pulsar/pull/9284#discussion_r563287260 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1774,14 +1776,71 @@ public TopicStat

[GitHub] [pulsar] codelipenghui commented on pull request #9264: Fix BookkeeperSchemaStorage NPE

2021-01-24 Thread GitBox
codelipenghui commented on pull request #9264: URL: https://github.com/apache/pulsar/pull/9264#issuecomment-766311479 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] codelipenghui commented on pull request #9255: Fix peek message metadata broker while enable broker entry metadata.

2021-01-24 Thread GitBox
codelipenghui commented on pull request #9255: URL: https://github.com/apache/pulsar/pull/9255#issuecomment-766311439 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m