[GitHub] [pulsar] zymap opened a new pull request #9715: Master branch rpm package failed to build

2021-02-24 Thread GitBox
zymap opened a new pull request #9715: URL: https://github.com/apache/pulsar/pull/9715 **Motivation** After #9184, we changed the source code directory name and that makes the RPM package build fail. ``` centos-7: Pulling from apachepulsar/pulsar-build Digest: sha256:

[GitHub] [pulsar] sijie commented on pull request #9448: Pulsar IO - KafkaSource - allow to manage Avro Encoded messages

2021-02-24 Thread GitBox
sijie commented on pull request #9448: URL: https://github.com/apache/pulsar/pull/9448#issuecomment-785697728 Apologized for the delay! will review it today or tomorrow. This is an automated message from the Apache Git Servic

[GitHub] [pulsar] eolivelli commented on pull request #9690: [CI][C++] Force CMake to find Python2

2021-02-24 Thread GitBox
eolivelli commented on pull request #9690: URL: https://github.com/apache/pulsar/pull/9690#issuecomment-785696176 @aahmed-se @BewareMyPower @merlimat QA tests passed. Can we merge this patch and push the new image ? Thank you very much ! --

[GitHub] [pulsar] eolivelli commented on pull request #9690: [CI][C++] Force CMake to find Python2

2021-02-24 Thread GitBox
eolivelli commented on pull request #9690: URL: https://github.com/apache/pulsar/pull/9690#issuecomment-785692783 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] eolivelli commented on pull request #9448: Pulsar IO - KafkaSource - allow to manage Avro Encoded messages

2021-02-24 Thread GitBox
eolivelli commented on pull request #9448: URL: https://github.com/apache/pulsar/pull/9448#issuecomment-785692571 @merlimat @rdhabalia @sijie please help me moving forward on this topic This is an automated message fr

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #7251: [pulsar-admin] Fix tenant admin should be able to get tenant-info

2021-02-24 Thread GitBox
Anonymitaet edited a comment on pull request #7251: URL: https://github.com/apache/pulsar/pull/7251#issuecomment-785686582 Hi @rdhabalia docs will be added if this PR is reopened and merged. And you can take [my comments](https://github.com/apache/pulsar/pull/7251#discussion_r551895241) as

[GitHub] [pulsar] Anonymitaet commented on pull request #7251: [pulsar-admin] Fix tenant admin should be able to get tenant-info

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #7251: URL: https://github.com/apache/pulsar/pull/7251#issuecomment-785686582 Hi @rdhabalia docs will be added if this PR is reopened and merged. And you can take my comments as references when you want to add docs. ---

[GitHub] [pulsar] MonicaMagoniCom commented on issue #9699: Key_Shared subcription not working correctly

2021-02-24 Thread GitBox
MonicaMagoniCom commented on issue #9699: URL: https://github.com/apache/pulsar/issues/9699#issuecomment-785686109 @MarvinCai Hi, actually not, we are not creating any new consumer during the peak. That's why I do not expect any reshashing process to be performed. ---

[GitHub] [pulsar] MarvinCai commented on a change in pull request #9665: [MINOR] attempt to fix `ReplicatorTest.testResetCursorNotFail` timeout in github CI

2021-02-24 Thread GitBox
MarvinCai commented on a change in pull request #9665: URL: https://github.com/apache/pulsar/pull/9665#discussion_r582599376 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java ## @@ -517,7 +518,7 @@ public void testResetCursorNotFail

[GitHub] [pulsar] Anonymitaet commented on pull request #8717: Configurable data source for offloaded messages

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #8717: URL: https://github.com/apache/pulsar/pull/8717#issuecomment-785681204 @Renkai many thanks for your docs! While `site2/docs/cookbooks-tiered-storage.md` is deprecated. We will fix it.

[GitHub] [pulsar] eolivelli commented on issue #9711: Creating and modifying authorization policies in not thread safe

2021-02-24 Thread GitBox
eolivelli commented on issue #9711: URL: https://github.com/apache/pulsar/issues/9711#issuecomment-785678831 Good catch @lhotari I believe this is a blocker issue. @wolfstudy @codelipenghui can we fix it for 2.7.1 ? ---

[GitHub] [pulsar] eolivelli commented on issue #9174: Create documentation for bookieID configuration option

2021-02-24 Thread GitBox
eolivelli commented on issue #9174: URL: https://github.com/apache/pulsar/issues/9174#issuecomment-785673107 @Anonymitaet it is working since 2.7.0 I am sorry I don't have much time to write down the docs. But I will very happy to answer to all of your questions and review --

[GitHub] [pulsar] MarvinCai opened a new issue #9714: [Tests] Non-persistent topic is not properly tested.

2021-02-24 Thread GitBox
MarvinCai opened a new issue #9714: URL: https://github.com/apache/pulsar/issues/9714 We have integration test run against non-persistent topics: [NonPersistentTopicMessagingTest](https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integratio

[GitHub] [pulsar] gaoran10 commented on pull request #9631: [Pulsar SQL] Fix Pulsar SQL query bytes schema data error

2021-02-24 Thread GitBox
gaoran10 commented on pull request #9631: URL: https://github.com/apache/pulsar/pull/9631#issuecomment-785670580 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] codelipenghui commented on issue #9585: The consumer doesn't reconnect to the multi partitioned topic after the topic deletion and recreating

2021-02-24 Thread GitBox
codelipenghui commented on issue #9585: URL: https://github.com/apache/pulsar/issues/9585#issuecomment-785670214 @mlyahmed I noticed your PR, seems related to a previous issue https://github.com/apache/pulsar/issues/9173. Currently, if disabled the topic auto-creation, it will avoid creati

[GitHub] [pulsar] codelipenghui commented on issue #9585: The consumer doesn't reconnect to the multi partitioned topic after the topic deletion and recreating

2021-02-24 Thread GitBox
codelipenghui commented on issue #9585: URL: https://github.com/apache/pulsar/issues/9585#issuecomment-785668280 Hi @alexku7 If the topic auto-creation is disabled and we delete the existing topic, the clients should be rejected when they try to connect to a not exist topic. If the consume

[GitHub] [pulsar] MarvinCai opened a new issue #9713: Docker image used for integration test is outdated.

2021-02-24 Thread GitBox
MarvinCai opened a new issue #9713: URL: https://github.com/apache/pulsar/issues/9713 Docker image used for integration test apachepulsar/pulsar-test-latest-version:latest was built 2 years ago, we're not testing against many of our recent changes, we should build and publish test image r

[GitHub] [pulsar] aahmed-se opened a new pull request #9712: [WIP] Add TestNG groups to pulsar-broker

2021-02-24 Thread GitBox
aahmed-se opened a new pull request #9712: URL: https://github.com/apache/pulsar/pull/9712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] murong00 closed pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions

2021-02-24 Thread GitBox
murong00 closed pull request #8342: URL: https://github.com/apache/pulsar/pull/8342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] murong00 commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions

2021-02-24 Thread GitBox
murong00 commented on pull request #8342: URL: https://github.com/apache/pulsar/pull/8342#issuecomment-785664207 @Anonymitaet I will close this pr and submit a new one by taking penghui's advice, I expect it can be applied to 2.7.1 if possible. ---

[GitHub] [pulsar] murong00 removed a comment on issue #8340: [pulsar-testclient]Provide options to specify existing topics when allowAutoTopicCreation is disable and using multiple topics

2021-02-24 Thread GitBox
murong00 removed a comment on issue #8340: URL: https://github.com/apache/pulsar/issues/8340#issuecomment-724532309 @codelipenghui Thanks for pointing this out, however, the user may not have permissions to create new topics and subscriptions. In addtion, if we fix --topic (which is `List`

[GitHub] [pulsar] lhotari commented on pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure

2021-02-24 Thread GitBox
lhotari commented on pull request #9705: URL: https://github.com/apache/pulsar/pull/9705#issuecomment-785659750 @sijie @jiazhai @codelipenghui I hope this fix gets merged asap. This PR fixes a test that is extremely flaky and causes a lot of builds to fail. The test was introduced in #9419

[GitHub] [pulsar] lhotari commented on pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure

2021-02-24 Thread GitBox
lhotari commented on pull request #9705: URL: https://github.com/apache/pulsar/pull/9705#issuecomment-785658065 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] murong00 commented on a change in pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
murong00 commented on a change in pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#discussion_r582578339 ## File path: site2/docs/reference-pulsar-admin.md ## @@ -2451,6 +2451,11 @@ Usage $ pulsar-admin tenants delete tenant-name ``` +Options +|Flag|Descr

[GitHub] [pulsar] michaeljmarshall commented on issue #9710: Broker's ServerCnx Class Logs Excessively at INFO Level

2021-02-24 Thread GitBox
michaeljmarshall commented on issue #9710: URL: https://github.com/apache/pulsar/issues/9710#issuecomment-785652964 I am working on a PR for this issue to demonstrate the proposed changes. I should have it ready to go tomorrow. -

[GitHub] [pulsar] lhotari opened a new issue #9711: Creating and modifying authorization policies in not thread safe

2021-02-24 Thread GitBox
lhotari opened a new issue #9711: URL: https://github.com/apache/pulsar/issues/9711 **Describe the bug** Creating and modifying authorization policies is not thread safe. It leads to unexpected NullPointerExceptions for example and could lead to authorization data corruption.

[GitHub] [pulsar] michaeljmarshall opened a new issue #9710: Broker's ServerCnx Class Logs Excessively at INFO Level

2021-02-24 Thread GitBox
michaeljmarshall opened a new issue #9710: URL: https://github.com/apache/pulsar/issues/9710 **Is your enhancement request related to a problem? Please describe.** I would like to propose turning the log level down from INFO to DEBUG for several of the especially noisy logs in the `org.

[GitHub] [pulsar] lhotari opened a new issue #9709: Flaky-test: AuthorizationTest.simple

2021-02-24 Thread GitBox
lhotari opened a new issue #9709: URL: https://github.com/apache/pulsar/issues/9709 AuthorizationTest is flaky. The simple test method fails sporadically. The assertion error shown in logs is misleading. The assertion error happens as a result of a retry. The actual problem can be fo

[GitHub] [pulsar] zymap commented on pull request #8980: Add equals, hashCode methods to all Authentication implementation class

2021-02-24 Thread GitBox
zymap commented on pull request #8980: URL: https://github.com/apache/pulsar/pull/8980#issuecomment-785643774 ``` Error: Medium: Inconsistent synchronization of org.apache.pulsar.client.impl.auth.AuthenticationAthenz.privateKey; locked 57% of time [org.apache.pulsar.client.impl.auth.Au

[GitHub] [pulsar] MarvinCai commented on pull request #9659: [FlakyTest]Try to fix flaky test ReplicatorTest.testReplicatorOnPartitionedTopic.

2021-02-24 Thread GitBox
MarvinCai commented on pull request #9659: URL: https://github.com/apache/pulsar/pull/9659#issuecomment-785639760 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
Anonymitaet commented on a change in pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#discussion_r582566811 ## File path: site2/docs/reference-pulsar-admin.md ## @@ -2451,6 +2451,11 @@ Usage $ pulsar-admin tenants delete tenant-name ``` +Options +|Flag|De

[GitHub] [pulsar] lhotari commented on pull request #9638: Reduce Pulsar IO Connectors size

2021-02-24 Thread GitBox
lhotari commented on pull request #9638: URL: https://github.com/apache/pulsar/pull/9638#issuecomment-785637817 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] murong00 commented on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
murong00 commented on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-785635939 > @murong00 thanks for your coding work. > > 1. Does this apply to 2.7.1? > 2. Would you like to add docs for this change? @Anonymitaet 1. Applying this to 2.

[GitHub] [pulsar] lhotari commented on pull request #9693: [Tiered storage] Replace usage of shaded Guava Supplier with java.util.function.Supplier

2021-02-24 Thread GitBox
lhotari commented on pull request #9693: URL: https://github.com/apache/pulsar/pull/9693#issuecomment-785634954 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] jadbin commented on issue #6459: Unable to disable logs for python bindings

2021-02-24 Thread GitBox
jadbin commented on issue #6459: URL: https://github.com/apache/pulsar/issues/6459#issuecomment-78565 Emmm, any updates? This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [pulsar] MarvinCai commented on pull request #9659: [FlakyTest]Try to fix flaky test ReplicatorTest.testReplicatorOnPartitionedTopic.

2021-02-24 Thread GitBox
MarvinCai commented on pull request #9659: URL: https://github.com/apache/pulsar/pull/9659#issuecomment-785619821 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] MarvinCai commented on pull request #9659: [FlakyTest]Try to fix flaky test ReplicatorTest.testReplicatorOnPartitionedTopic.

2021-02-24 Thread GitBox
MarvinCai commented on pull request #9659: URL: https://github.com/apache/pulsar/pull/9659#issuecomment-78555 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] MarvinCai commented on issue #9703: non-persistent topics don't seem to work with Key_Shared

2021-02-24 Thread GitBox
MarvinCai commented on issue #9703: URL: https://github.com/apache/pulsar/issues/9703#issuecomment-785559653 @megfigura Hi, I verified the bug is in broker. This is an automated message from the Apache Git Service. To respon

[GitHub] [pulsar] MarvinCai opened a new issue #9708: Flaky-test: PersistentTopicE2ETest.testPayloadCorruptionDetection

2021-02-24 Thread GitBox
MarvinCai opened a new issue #9708: URL: https://github.com/apache/pulsar/issues/9708 https://pipelines.actions.githubusercontent.com/EXIZfX8ixSbQEfqDA00dMJrEtloTMSwjlUs9NqJqrTcJfd7NaR/_apis/pipelines/1/runs/212111/signedlogcontent/3?urlExpires=2021-02-25T03%3A56%3A28.2923858Z&urlSigningMet

[GitHub] [pulsar] congbobo184 removed a comment on pull request #9490: [Transaction] Transaction buffer snapshot implementation.

2021-02-24 Thread GitBox
congbobo184 removed a comment on pull request #9490: URL: https://github.com/apache/pulsar/pull/9490#issuecomment-784833329 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] congbobo184 closed pull request #9490: [Transaction] Transaction buffer snapshot implementation.

2021-02-24 Thread GitBox
congbobo184 closed pull request #9490: URL: https://github.com/apache/pulsar/pull/9490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Anonymitaet commented on pull request #9649: Added metrics for producer throttling

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #9649: URL: https://github.com/apache/pulsar/pull/9649#issuecomment-785556917 @merlimat thanks for your coding work. 1. Does this apply to 2.7.1? 2. Would you like to add docs for this change? -

[GitHub] [pulsar] Anonymitaet commented on pull request #8342: [Issue 8340] [pulsar-testclient] Provide options to specify existing topics and subscriptions

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #8342: URL: https://github.com/apache/pulsar/pull/8342#issuecomment-78022 @murong00 thanks for your coding work. 1. Does this apply to 2.7.1? 2. Would you like to add docs for this change?

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
Anonymitaet edited a comment on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-785553909 @murong00 thanks for your coding work. 1. Does this apply to 2.7.1? 2. Would you like to add docs for this change? --

[GitHub] [pulsar] saosir edited a comment on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages

2021-02-24 Thread GitBox
saosir edited a comment on pull request #9134: URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785554534 > @saosir Looks like the CI failed by this change. Please take a look. Thank you. > > I will push this to the next release. OK, I am looking for time to fix th

[GitHub] [pulsar] saosir commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages

2021-02-24 Thread GitBox
saosir commented on pull request #9134: URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785554534 > @saosir Looks like the CI failed by this change. Please take a look. Thank you. > > I will push this to the next release. OK, I am looking for time to fix this problem.

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
Anonymitaet edited a comment on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-785553909 @murong00 thanks for your coding work. 1. Does this apply to 2.7.1? 2. Would you like to add docs for this change? I'd like to help review. Thanks -

[GitHub] [pulsar] zymap commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-24 Thread GitBox
zymap commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-785554197 ping @sijie. Please take a review. Thanks This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
Anonymitaet edited a comment on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-785553909 @murong00 thanks for your coding work. 1. Would you like to add docs for this change? I'd like to help review. Thanks 2. Does this apply to 2.7.1? -

[GitHub] [pulsar] Anonymitaet commented on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-785553909 @murong00 thanks for your coding work, would you like to add docs for this change? I'd like to help review. Thanks --

[GitHub] [pulsar] Anonymitaet commented on pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#issuecomment-785551821 @yufan022 will this apply to 2.7.1? This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] Anonymitaet opened a new pull request #9707: [Doc] Add descriptions of end-to-end encryption for Python client

2021-02-24 Thread GitBox
Anonymitaet opened a new pull request #9707: URL: https://github.com/apache/pulsar/pull/9707 Add docs for https://github.com/apache/pulsar/pull/9588 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] congbobo184 opened a new pull request #9706: [Pulsar transaction] Transaction coordinator metrics.

2021-02-24 Thread GitBox
congbobo184 opened a new pull request #9706: URL: https://github.com/apache/pulsar/pull/9706 ## Motivation Transaction coordinator metrics add. ## implement ``` /** The transaction coordinatorId. */ private long transactionCoordinatorId; /** The transact

[GitHub] [pulsar] csthomas1 removed a comment on pull request #9349: issue#9345 -- bug fix for RuntimeUtils.getCmd not setting pending-async-requests

2021-02-24 Thread GitBox
csthomas1 removed a comment on pull request #9349: URL: https://github.com/apache/pulsar/pull/9349#issuecomment-785545125 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] csthomas1 commented on pull request #9349: issue#9345 -- bug fix for RuntimeUtils.getCmd not setting pending-async-requests

2021-02-24 Thread GitBox
csthomas1 commented on pull request #9349: URL: https://github.com/apache/pulsar/pull/9349#issuecomment-785545125 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] jianyun8023 commented on pull request #8980: Add equals, hashCode methods to all Authentication implementation class

2021-02-24 Thread GitBox
jianyun8023 commented on pull request #8980: URL: https://github.com/apache/pulsar/pull/8980#issuecomment-785543170 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #9702: [C++] SinglePartition message router is always picking the same partition

2021-02-24 Thread GitBox
BewareMyPower commented on a change in pull request #9702: URL: https://github.com/apache/pulsar/pull/9702#discussion_r582471899 ## File path: pulsar-client-cpp/lib/SinglePartitionMessageRouter.cc ## @@ -18,9 +18,23 @@ */ #include "SinglePartitionMessageRouter.h" +#include

[GitHub] [pulsar] Anonymitaet commented on issue #9174: Create documentation for bookieID configuration option

2021-02-24 Thread GitBox
Anonymitaet commented on issue #9174: URL: https://github.com/apache/pulsar/issues/9174#issuecomment-785540762 @eolivelli does this code change apply to 2.7.1? This is an automated message from the Apache Git Service. To resp

[GitHub] [pulsar] merlimat commented on a change in pull request #9702: [C++] SinglePartition message router is always picking the same partition

2021-02-24 Thread GitBox
merlimat commented on a change in pull request #9702: URL: https://github.com/apache/pulsar/pull/9702#discussion_r582465760 ## File path: pulsar-client-cpp/lib/SinglePartitionMessageRouter.cc ## @@ -18,9 +18,23 @@ */ #include "SinglePartitionMessageRouter.h" +#include +#i

[GitHub] [pulsar] Anonymitaet commented on issue #9216: Support get topic applied policy

2021-02-24 Thread GitBox
Anonymitaet commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-785540215 @315157973 @codelipenghui will these code changes apply to 2.7.1? This is an automated message from the Apache Git

[GitHub] [pulsar] 315157973 opened a new pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure

2021-02-24 Thread GitBox
315157973 opened a new pull request #9705: URL: https://github.com/apache/pulsar/pull/9705 ### Modifications The thread pool is used in the unit test to complete the delay failure, but the time left for the thread pool is only 5ms. The time of thread switching is uncontrollable, so fail

[GitHub] [pulsar] gaoran10 opened a new issue #9704: [Pulsar SQL] Query key-value schema data error

2021-02-24 Thread GitBox
gaoran10 opened a new issue #9704: URL: https://github.com/apache/pulsar/issues/9704 **Describe the bug** If the producer uses the key-value schema in a separate mode and disables the batch feature, the Pulsar SQL will get in trouble. **To Reproduce** 1. produce key-value schem

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Anonymitaet commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582449666 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label: Pu

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Anonymitaet commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582449666 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label: Pu

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Anonymitaet commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582449666 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label: Pu

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Anonymitaet commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582448120 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label: Pu

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Jennifer88huang commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582448147 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label

[GitHub] [pulsar] codelipenghui commented on pull request #9388: [Pulsar sql] Support keyValue Schema add integration test.

2021-02-24 Thread GitBox
codelipenghui commented on pull request #9388: URL: https://github.com/apache/pulsar/pull/9388#issuecomment-785530890 https://github.com/apache/pulsar/pull/9685 is fixing the branch-2.7 This is an automated message from the A

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Anonymitaet commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582446309 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label: Pu

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9692: [Doc] Add Pulsar isolation

2021-02-24 Thread GitBox
Jennifer88huang commented on a change in pull request #9692: URL: https://github.com/apache/pulsar/pull/9692#discussion_r582445396 ## File path: site2/docs/administration-isolation.md ## @@ -0,0 +1,84 @@ +--- +id: administration-isolation +title: Pulsar isolation +sidebar_label

[GitHub] [pulsar] MarvinCai commented on a change in pull request #9659: [FlakyTest]Try to fix flaky test ReplicatorTest.testReplicatorOnPartitionedTopic.

2021-02-24 Thread GitBox
MarvinCai commented on a change in pull request #9659: URL: https://github.com/apache/pulsar/pull/9659#discussion_r582440633 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/BrokerTestUtil.java ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pulsar] golden-yang commented on pull request #9671: [Functions] Abstract repetitive code and add unit tests. #9502

2021-02-24 Thread GitBox
golden-yang commented on pull request #9671: URL: https://github.com/apache/pulsar/pull/9671#issuecomment-785516686 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] zymap commented on pull request #8048: [Issue 7903][proxy]Enable AutoTopicCreationType partitioned through proxy

2021-02-24 Thread GitBox
zymap commented on pull request #8048: URL: https://github.com/apache/pulsar/pull/8048#issuecomment-785516592 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] megfigura commented on issue #9703: non-persistent topics don't seem to work with Key_Shared

2021-02-24 Thread GitBox
megfigura commented on issue #9703: URL: https://github.com/apache/pulsar/issues/9703#issuecomment-785516560 Hi @MarvinCai, thank you! Do you know at this point if the bug is in the broker or the java client? Thanks! This is

[GitHub] [pulsar] zymap commented on pull request #9134: Fix UnAckedMessageTracker timeout send redelivery messages

2021-02-24 Thread GitBox
zymap commented on pull request #9134: URL: https://github.com/apache/pulsar/pull/9134#issuecomment-785515801 @saosir Looks like the CI failed by this change. Please take a look. Thank you. I will push this to the next release. --

[GitHub] [pulsar] zymap commented on pull request #8611: [Issue 8599] Fix DispatchRateLimiter does not take effect

2021-02-24 Thread GitBox
zymap commented on pull request #8611: URL: https://github.com/apache/pulsar/pull/8611#issuecomment-785514585 push this to the next release. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] zymap closed pull request #8565: [pulsar-broker] Fix: Topic dedup policy configuration doesn't support V1 topic-name

2021-02-24 Thread GitBox
zymap closed pull request #8565: URL: https://github.com/apache/pulsar/pull/8565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] zymap commented on pull request #8565: [pulsar-broker] Fix: Topic dedup policy configuration doesn't support V1 topic-name

2021-02-24 Thread GitBox
zymap commented on pull request #8565: URL: https://github.com/apache/pulsar/pull/8565#issuecomment-785514046 Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed. This is an

[GitHub] [pulsar] zymap commented on pull request #8564: [pulsar-broker] Fix topic policy update

2021-02-24 Thread GitBox
zymap commented on pull request #8564: URL: https://github.com/apache/pulsar/pull/8564#issuecomment-785513934 Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed. This is an

[GitHub] [pulsar] zymap closed pull request #8564: [pulsar-broker] Fix topic policy update

2021-02-24 Thread GitBox
zymap closed pull request #8564: URL: https://github.com/apache/pulsar/pull/8564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] zymap closed pull request #8555: [pulsar-broker] support v1 topic dedup admin api

2021-02-24 Thread GitBox
zymap closed pull request #8555: URL: https://github.com/apache/pulsar/pull/8555 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] zymap commented on pull request #8555: [pulsar-broker] support v1 topic dedup admin api

2021-02-24 Thread GitBox
zymap commented on pull request #8555: URL: https://github.com/apache/pulsar/pull/8555#issuecomment-785513731 Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed. This is an

[GitHub] [pulsar] zymap commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle

2021-02-24 Thread GitBox
zymap commented on pull request #8444: URL: https://github.com/apache/pulsar/pull/8444#issuecomment-785513474 Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed. This is an

[GitHub] [pulsar] zymap closed pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle

2021-02-24 Thread GitBox
zymap closed pull request #8444: URL: https://github.com/apache/pulsar/pull/8444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] zymap commented on pull request #7251: [pulsar-admin] Fix tenant admin should be able to get tenant-info

2021-02-24 Thread GitBox
zymap commented on pull request #7251: URL: https://github.com/apache/pulsar/pull/7251#issuecomment-785512425 Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed. This is an

[GitHub] [pulsar] zymap closed pull request #7251: [pulsar-admin] Fix tenant admin should be able to get tenant-info

2021-02-24 Thread GitBox
zymap closed pull request #7251: URL: https://github.com/apache/pulsar/pull/7251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] zymap closed pull request #6648: [pulsar-client] add api to wait for inflight messages while closing producer

2021-02-24 Thread GitBox
zymap closed pull request #6648: URL: https://github.com/apache/pulsar/pull/6648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] zymap commented on pull request #6648: [pulsar-client] add api to wait for inflight messages while closing producer

2021-02-24 Thread GitBox
zymap commented on pull request #6648: URL: https://github.com/apache/pulsar/pull/6648#issuecomment-785511672 Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed. This is an

[GitHub] [pulsar] gaoran10 commented on issue #7407: Support for tombstones (null value in messages) does not work

2021-02-24 Thread GitBox
gaoran10 commented on issue #7407: URL: https://github.com/apache/pulsar/issues/7407#issuecomment-785510836 @fmiguelez Is there any block about this issue? Could you provide more details? This is an automated message from th

[GitHub] [pulsar] gaoran10 edited a comment on issue #7407: Support for tombstones (null value in messages) does not work

2021-02-24 Thread GitBox
gaoran10 edited a comment on issue #7407: URL: https://github.com/apache/pulsar/issues/7407#issuecomment-698094497 @fmiguelez Sorry, late response. 1. `producer.newMessage().key("1").send()` Currently, if we send messages as above the message payload is `ByteBuffer.allocate(0)

[GitHub] [pulsar] gaoran10 edited a comment on issue #7407: Support for tombstones (null value in messages) does not work

2021-02-24 Thread GitBox
gaoran10 edited a comment on issue #7407: URL: https://github.com/apache/pulsar/issues/7407#issuecomment-698094497 @fmiguelez Sorry, late response. 1. `producer.newMessage().key("1").send()` Currently, if we send messages as above the message payload is `ByteBuffer.allocate(0)

[GitHub] [pulsar] gaoran10 edited a comment on issue #7407: Support for tombstones (null value in messages) does not work

2021-02-24 Thread GitBox
gaoran10 edited a comment on issue #7407: URL: https://github.com/apache/pulsar/issues/7407#issuecomment-698094497 @fmiguelez Sorry, late response. 1. `producer.newMessage().key("1").send()` Currently, if we send messages as above the message payload is `ByteBuffer.allocate(0)

[GitHub] [pulsar] gaoran10 edited a comment on issue #7407: Support for tombstones (null value in messages) does not work

2021-02-24 Thread GitBox
gaoran10 edited a comment on issue #7407: URL: https://github.com/apache/pulsar/issues/7407#issuecomment-698094497 @fmiguelez Sorry, late response. 1. `producer.newMessage().key("1").send()` Currently, if we send messages as above the message payload is `ByteBuffer.allocate(0)

[GitHub] [pulsar] Anonymitaet commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state

2021-02-24 Thread GitBox
Anonymitaet commented on pull request #9618: URL: https://github.com/apache/pulsar/pull/9618#issuecomment-785504325 @limingnihao any thoughts? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #9702: [C++] SinglePartition message router is always picking the same partition

2021-02-24 Thread GitBox
BewareMyPower commented on a change in pull request #9702: URL: https://github.com/apache/pulsar/pull/9702#discussion_r582420498 ## File path: pulsar-client-cpp/lib/SinglePartitionMessageRouter.cc ## @@ -18,9 +18,23 @@ */ #include "SinglePartitionMessageRouter.h" +#include

[GitHub] [pulsar] murong00 commented on pull request #9677: [pulsar-broker] Added support to force deleting tenant

2021-02-24 Thread GitBox
murong00 commented on pull request #9677: URL: https://github.com/apache/pulsar/pull/9677#issuecomment-785501060 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] MarvinCai edited a comment on issue #9703: non-persistent topics don't seem to work with Key_Shared

2021-02-24 Thread GitBox
MarvinCai edited a comment on issue #9703: URL: https://github.com/apache/pulsar/issues/9703#issuecomment-785491446 I'm able to reproduce the error, I'll work on the fix. This is an automated message from the Apache Git Servi

[GitHub] [pulsar] congbobo184 removed a comment on pull request #9236: [Transaction] TC end transaction retry.

2021-02-24 Thread GitBox
congbobo184 removed a comment on pull request #9236: URL: https://github.com/apache/pulsar/pull/9236#issuecomment-785049178 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] congbobo184 commented on pull request #9236: [Transaction] TC end transaction retry.

2021-02-24 Thread GitBox
congbobo184 commented on pull request #9236: URL: https://github.com/apache/pulsar/pull/9236#issuecomment-785498879 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] BewareMyPower commented on pull request #9690: [CI][C++] Force CMake to find Python2

2021-02-24 Thread GitBox
BewareMyPower commented on pull request #9690: URL: https://github.com/apache/pulsar/pull/9690#issuecomment-785497136 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

  1   2   3   >