eolivelli commented on a change in pull request #10536:
URL: https://github.com/apache/pulsar/pull/10536#discussion_r629895490
##
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LockManagerImpl.java
##
@@ -115,9 +115,11 @@ private void han
gaoran10 commented on pull request #10535:
URL: https://github.com/apache/pulsar/pull/10535#issuecomment-837948155
Currently, this method is mainly used to get the bucket name of the offload
data. If we use the topic offload configuration instead of the offload context
in the LedgerInfo, t
linlinnn commented on pull request #10530:
URL: https://github.com/apache/pulsar/pull/10530#issuecomment-837938623
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
linlinnn commented on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-837937645
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
linlinnn opened a new issue #10537:
URL: https://github.com/apache/pulsar/issues/10537
**Describe the bug**
flaky test LoadBalancerTest often failed
**Expected behavior**
pass test
**Additional context**
```
Error:
testBrokerRanking(org.apache.pulsar.broker.loadb
eolivelli commented on a change in pull request #10535:
URL: https://github.com/apache/pulsar/pull/10535#discussion_r629876241
##
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java
##
@@ -485,8
linlinnn commented on a change in pull request #10536:
URL: https://github.com/apache/pulsar/pull/10536#discussion_r629875513
##
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LockManagerImpl.java
##
@@ -115,9 +115,11 @@ private void hand
freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629851502
##
File path: pulsar-io/kafka/pom.xml
##
@@ -39,6 +39,12 @@
provided
+
+ ${project.groupId}
+ pulsar-client-original
Revie
freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629870150
##
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##
@@ -1397,9 +1399,14 @@ public OffloadProcess
freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629870150
##
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##
@@ -1397,9 +1399,14 @@ public OffloadProcess
freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629873481
##
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##
@@ -1397,9 +1399,14 @@ public OffloadProcess
freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629870150
##
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##
@@ -1397,9 +1399,14 @@ public OffloadProcess
315157973 commented on a change in pull request #10357:
URL: https://github.com/apache/pulsar/pull/10357#discussion_r629867007
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##
@@ -1058,7 +1058,9 @@ public PulsarClient getReplicat
eolivelli commented on a change in pull request #10530:
URL: https://github.com/apache/pulsar/pull/10530#discussion_r629855168
##
File path:
testmocks/src/main/java/org/apache/zookeeper/MockZooKeeperSession.java
##
@@ -0,0 +1,224 @@
+/**
+ * Licensed to the Apache Software Fou
freeznet commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629851502
##
File path: pulsar-io/kafka/pom.xml
##
@@ -39,6 +39,12 @@
provided
+
+ ${project.groupId}
+ pulsar-client-original
Revie
hangc0276 opened a new pull request #10536:
URL: https://github.com/apache/pulsar/pull/10536
### Motivation
In broker shutting down stage, it throw the following exception.
```
11:31:55.887 [metadata-store-5-1] ERROR
org.apache.pulsar.metadata.impl.AbstractMetadataStore - Failed to
merlimat commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629838287
##
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##
@@ -1397,9 +1399,14 @@ public OffloadProcess
freeznet commented on pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#issuecomment-837768495
@sijie @merlimat @jerrypeng @codelipenghui please help to review this PR if
you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to
chenyg0911 commented on issue #6899:
URL: https://github.com/apache/pulsar/issues/6899#issuecomment-837762450
any roadmap for the feature can support python or go-lang?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
abhilashmandaliya commented on pull request #10527:
URL: https://github.com/apache/pulsar/pull/10527#issuecomment-837759270
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
jerrypeng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 4d2d66d Update "sample" tenant on standalone to stop using old
property/cluster/namespace naming convention. (#1
jerrypeng merged pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
jerrypeng closed issue #9889:
URL: https://github.com/apache/pulsar/issues/9889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
zymap opened a new pull request #10535:
URL: https://github.com/apache/pulsar/pull/10535
---
*Motivation*
We may change the offloaded data location by changing the metadata
of the offloaded topic. So it should be allow to overwrite the driver
config by metadata, and it should
315157973 commented on pull request #10528:
URL: https://github.com/apache/pulsar/pull/10528#issuecomment-837711641
> If all of the callers should from the ProducerImpl object mutex, why not
change to `private synchronized void failPendingMessages`?
Because this object mutex is also
equanz opened a new pull request #10534:
URL: https://github.com/apache/pulsar/pull/10534
Master Issue:
https://github.com/apache/pulsar/wiki/PIP-79%3A-Reduce-redundant-producers-from-partitioned-producer
### Motivation
Please see the PIP document.
This is a part of impleme
linlinnn commented on pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533#issuecomment-837687426
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
linlinnn commented on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-837685940
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hangc0276 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629801530
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
hangc0276 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629801397
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
linlinnn commented on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-837644341
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to annotated tag v0.5.0-candidate-1
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git.
*** WARNING: tag v0.5.0-candidate-1 was modified! ***
from aa1c9a3 (commit)
to c9696c
Author: mmerli
Date: Tue May 11 01:28:57 2021
New Revision: 47617
Log:
Staging artifacts and signature for Pulsar Client Go release 0.5.0-candidate-1
Added:
dev/pulsar/pulsar-client-go/
dev/pulsar/pulsar-client-go/apache-pulsar-client-go-0.5.0-src.tar.gz
(with props)
dev/pulsar/pul
Author: mmerli
Date: Tue May 11 01:27:28 2021
New Revision: 47616
Log:
Update mmerli GPG key
Modified:
dev/pulsar/KEYS
Modified: dev/pulsar/KEYS
==
--- dev/pulsar/KEYS (original)
+++ dev/pulsar/KEYS Tue May 11 01:27:
This is an automated email from the ASF dual-hosted git repository.
hrsakai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git
The following commit(s) were added to refs/heads/master by this push:
new cebbcce Upgrade Athenz version and rem
codelipenghui commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629782655
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static bo
linlinnn removed a comment on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-836318900
> Can you please add a test case?
@eolivelli any suggestion about this, `MockManagedLedger` do nothing.
--
This is an automated message from the Apache Git
dlg99 commented on a change in pull request #10498:
URL: https://github.com/apache/pulsar/pull/10498#discussion_r629744063
##
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/MultiConsumerPulsarSource.java
##
@@ -69,7 +72,20 @@ public void
merlimat opened a new pull request #10533:
URL: https://github.com/apache/pulsar/pull/10533
### Motivation
So far, we have been relying on a wacky approach to gather metrics for
Zookeeper usage. That was done because ZK used not to have a decent set of
exported metrics in server or
KannarFr commented on pull request #8048:
URL: https://github.com/apache/pulsar/pull/8048#issuecomment-837424670
Are these flaky? errors seems not related to PR changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
merlimat opened a new pull request #10532:
URL: https://github.com/apache/pulsar/pull/10532
### Motivation
Converted the NamespaceService to use MetadataStore instead of direct ZK
access.
--
This is an automated message from the Apache Git Service.
To respond to the messag
KannarFr commented on pull request #8048:
URL: https://github.com/apache/pulsar/pull/8048#issuecomment-837345612
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cdbartholomew opened a new pull request #10531:
URL: https://github.com/apache/pulsar/pull/10531
### Motivation
When using the Kubernetes runtime, there is a check that the function name
to ensure that it will create valid Kubernetes objects. It is currently set to
check for the len
linlinnn commented on pull request #10530:
URL: https://github.com/apache/pulsar/pull/10530#issuecomment-836961366
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
315157973 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629479074
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
linlinnn opened a new pull request #10530:
URL: https://github.com/apache/pulsar/pull/10530
fixes #10522
**Motivation**
support mock zookeeper with different session
**Modification**
wrap **MockZookeeper** to support mock zookeeper with different session
--
This is an
MarvinCai commented on a change in pull request #10326:
URL: https://github.com/apache/pulsar/pull/10326#discussion_r629472720
##
File path:
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
##
@@ -2917,4 +2916,59 @@ public void testManaged
eolivelli commented on pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#issuecomment-836852553
an integration test fails consistently. I have to check it out.
moving status to "draft"
--
This is an automated message from the Apache Git Service.
To respond to the me
hangc0276 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629455800
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
hangc0276 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629454124
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
linlinnn commented on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-836778291
@eolivelli I have added unit test, please review again, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
315157973 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629402243
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
315157973 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629400528
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolea
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-836739422
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
t3link commented on issue #10523:
URL: https://github.com/apache/pulsar/issues/10523#issuecomment-836707922
@codelipenghui Thanks! After have a look at
`PersistentStickyKeyDispatcherMultipleConsumers.java`. I think none of the
three selector strategies are suitable for my situation. Cause
linlinnn commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629347344
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##
@@ -168,7 +168,10 @@
}
static boolean
jangwind commented on a change in pull request #10326:
URL: https://github.com/apache/pulsar/pull/10326#discussion_r629345400
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -2156,6 +2157,14 @@ private void
scheduleDe
freeznet commented on pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#issuecomment-836642794
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hangc0276 commented on pull request #10341:
URL: https://github.com/apache/pulsar/pull/10341#issuecomment-836629513
> @hangc0276 Can you address Matteo's comment?
@sijie Ok, i will address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
hangc0276 opened a new pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529
### Motivation
When checking a partitioned topic whether a system topic, it will always be
`false`. The check logic is.
```Java
static boolean isSystemTopic(TopicName topicName) {
abhilashmandaliya commented on pull request #10527:
URL: https://github.com/apache/pulsar/pull/10527#issuecomment-836569004
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
315157973 opened a new pull request #10528:
URL: https://github.com/apache/pulsar/pull/10528
### Motivation
`failPendingMessages()` will traverse the `pendingMessages` queue and this
operation is not atomic.
`failPendingMessages()` should be called from within the `ProducerImpl`
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-836564272
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Author: penghui
Date: Mon May 10 09:44:51 2021
New Revision: 47605
Log:
release 2.7.2
Added:
release/pulsar/pulsar-2.7.2/
- copied from r47604, dev/pulsar/pulsar-2.7.2-candidate-1/
Removed:
dev/pulsar/pulsar-2.7.2-candidate-1/
This is an automated email from the ASF dual-hosted git repository.
eolivelli pushed a change to annotated tag v2.7.2
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
*** WARNING: tag v2.7.2 was modified! ***
from 7bf14b5 (commit)
to 289f894 (tag)
tagging 7bf14b5ac049d
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from d39e5e4 Fix the inconsistency of AdvertisedAddress (#10312)
add 4d2d66d Update "sample" tenant on standalone
lhotari merged pull request #10486:
URL: https://github.com/apache/pulsar/pull/10486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
abhilashmandaliya commented on pull request #10527:
URL: https://github.com/apache/pulsar/pull/10527#issuecomment-836462785
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
congbobo184 edited a comment on pull request #10525:
URL: https://github.com/apache/pulsar/pull/10525#issuecomment-836376781
@eolivelli I have reproduced it. After fix it broker will not log this error
again. Just added the test, please review again. thanks!
--
This is an automated messa
congbobo184 commented on pull request #10525:
URL: https://github.com/apache/pulsar/pull/10525#issuecomment-836376781
@eolivelli I have reproduced it and fix it broker will not log this error
again. Just added the test, please review again. thanks!
--
This is an automated message from th
Hanfee commented on issue #10514:
URL: https://github.com/apache/pulsar/issues/10514#issuecomment-836374584
I replace core-site.xml and hdfs-site.xml resolve this problem, but I find a
new problem
hdfs2 connectors/pulsar-io-hdfs2-2.7.1.nar lack hadoop-lzo-0.4.21U2.jar
```
16:
linlinnn edited a comment on issue #10522:
URL: https://github.com/apache/pulsar/issues/10522#issuecomment-836110170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For que
linlinnn edited a comment on issue #10522:
URL: https://github.com/apache/pulsar/issues/10522#issuecomment-836110170
This issue caused by mockZookeeper, because all brokers share the same
mockZookeeper and same `SessionId`
```java
if (res.getStat().isCreatedBySelf()) { // same `Sessi
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 2953914 Fix log about LeaderElection (#10521)
add d39e5e4 Fix the inconsistency of AdvertisedAddress (#10312)
codelipenghui merged pull request #10312:
URL: https://github.com/apache/pulsar/pull/10312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
linlinnn edited a comment on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-836318900
> Can you please add a test case?
@eolivelli any suggestion about this, `MockManagedLedger` do nothing.
--
This is an automated message from the Apache Git
linlinnn commented on pull request #10520:
URL: https://github.com/apache/pulsar/pull/10520#issuecomment-836318900
> Can you please add a test case?
@eolivelli any suggestion about this, `MockManagedLedger` do nothing.
--
This is an automated message from the Apache Git Service.
To
abhilashmandaliya commented on pull request #10527:
URL: https://github.com/apache/pulsar/pull/10527#issuecomment-836286590
@eolivelli @lhotari PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
abhilashmandaliya opened a new pull request #10527:
URL: https://github.com/apache/pulsar/pull/10527
The do-while loop was executed only once so removed the loop and optimized
an inner for-loop to find binaryValue
### Motivation
IDE warning
### Modifications
Simp
79 matches
Mail list logo
