[GitHub] [pulsar] fantapsody opened a new pull request #10600: [broker] Setup pulsar cluster with MetadataStore

2021-05-15 Thread GitBox
fantapsody opened a new pull request #10600: URL: https://github.com/apache/pulsar/pull/10600 ### Motivation Refactor the pulsar cluster setup command to use the new `MetadataStore` API. ### Modifications - Refactored `PulsarClusterMetadataSetup` command to use the new

[GitHub] [pulsar] eolivelli commented on pull request #10591: Upgrade NodeJs in Pulsar Build image (used by WebSite Builder)

2021-05-15 Thread GitBox
eolivelli commented on pull request #10591: URL: https://github.com/apache/pulsar/pull/10591#issuecomment-841720838 BTW thanks I have restarted the website builder job https://github.com/apache/pulsar/actions/runs/845406786 -- This is an automated message from the Apache Git

[GitHub] [pulsar] eolivelli commented on pull request #10591: Upgrade NodeJs in Pulsar Build image (used by WebSite Builder)

2021-05-15 Thread GitBox
eolivelli commented on pull request #10591: URL: https://github.com/apache/pulsar/pull/10591#issuecomment-841720701 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] eolivelli commented on pull request #10591: Upgrade NodeJs in Pulsar Build image (used by WebSite Builder)

2021-05-15 Thread GitBox
eolivelli commented on pull request #10591: URL: https://github.com/apache/pulsar/pull/10591#issuecomment-841720638 Didn't you merge this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] merlimat commented on pull request #10591: Upgrade NodeJs in Pulsar Build image (used by WebSite Builder)

2021-05-15 Thread GitBox
merlimat commented on pull request #10591: URL: https://github.com/apache/pulsar/pull/10591#issuecomment-841717280 @eolivelli I pushed the new image -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] david-streamlio removed a comment on pull request #10593: [Issue-10109] [admin client] Add --batch-source-config switch to the Pulsar Admin Source API

2021-05-15 Thread GitBox
david-streamlio removed a comment on pull request #10593: URL: https://github.com/apache/pulsar/pull/10593#issuecomment-841701015 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] david-streamlio commented on pull request #10593: [Issue-10109] [admin client] Add --batch-source-config switch to the Pulsar Admin Source API

2021-05-15 Thread GitBox
david-streamlio commented on pull request #10593: URL: https://github.com/apache/pulsar/pull/10593#issuecomment-841708486 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] david-streamlio commented on pull request #10593: [Issue-10109] [admin client] Add --batch-source-config switch to the Pulsar Admin Source API

2021-05-15 Thread GitBox
david-streamlio commented on pull request #10593: URL: https://github.com/apache/pulsar/pull/10593#issuecomment-841701015 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] linlinnn commented on a change in pull request #10599: [Tests] Fix flaky test GracefulExecutorServicesShutdownTest

2021-05-15 Thread GitBox
linlinnn commented on a change in pull request #10599: URL: https://github.com/apache/pulsar/pull/10599#discussion_r632976110 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java ## @@ -120,25 +121,28 @@ public

[GitHub] [pulsar] lhotari commented on a change in pull request #10599: [Tests] Fix flaky test GracefulExecutorServicesShutdownTest

2021-05-15 Thread GitBox
lhotari commented on a change in pull request #10599: URL: https://github.com/apache/pulsar/pull/10599#discussion_r632971688 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java ## @@ -120,25 +121,28 @@ public

[GitHub] [pulsar] merlimat commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source

2021-05-15 Thread GitBox
merlimat commented on pull request #10597: URL: https://github.com/apache/pulsar/pull/10597#issuecomment-841662407 @yangl I think this got broken in #8962. The problem is that the shading profile must not include `pulsar-client-api`. Instead that is meant to be left as an unshaded

[GitHub] [pulsar] linlinnn commented on a change in pull request #10599: [Tests] Fix flaky test GracefulExecutorServicesShutdownTest

2021-05-15 Thread GitBox
linlinnn commented on a change in pull request #10599: URL: https://github.com/apache/pulsar/pull/10599#discussion_r632950133 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java ## @@ -120,25 +121,28 @@ public

[GitHub] [pulsar] linlinnn commented on a change in pull request #10599: [Tests] Fix flaky test GracefulExecutorServicesShutdownTest

2021-05-15 Thread GitBox
linlinnn commented on a change in pull request #10599: URL: https://github.com/apache/pulsar/pull/10599#discussion_r632949407 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java ## @@ -120,25 +121,28 @@ public

[GitHub] [pulsar] lhotari opened a new pull request #10599: [Tests] Fix flaky test GracefulExecutorServicesShutdownTest

2021-05-15 Thread GitBox
lhotari opened a new pull request #10599: URL: https://github.com/apache/pulsar/pull/10599 ### Motivation `GracefulExecutorServicesShutdownTest`'s `shouldTerminateWhenFutureIsCancelled` remains flaky after #10592 . Example failure:

[GitHub] [pulsar] lhotari opened a new pull request #10598: [Broker/Proxy] Update default TLS protocols to TLSv1.3,TLSv1.2

2021-05-15 Thread GitBox
lhotari opened a new pull request #10598: URL: https://github.com/apache/pulsar/pull/10598 Fixes #10335 ### Motivation See #10335. TLSv1.3 support has been introduced in the JDK since [JDK 8 since

[GitHub] [pulsar] sijie commented on pull request #10491: [Functions] Adding “numListenerThreads” configuration parameter in WorkerConfig . #8575

2021-05-15 Thread GitBox
sijie commented on pull request #10491: URL: https://github.com/apache/pulsar/pull/10491#issuecomment-841637543 @jerrypeng Can you review this again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] sijie commented on pull request #10552: get function cluster from broker config when start function worker with broker

2021-05-15 Thread GitBox
sijie commented on pull request #10552: URL: https://github.com/apache/pulsar/pull/10552#issuecomment-841637101 @eolivelli please review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] sijie commented on pull request #10563: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-client-original`

2021-05-15 Thread GitBox
sijie commented on pull request #10563: URL: https://github.com/apache/pulsar/pull/10563#issuecomment-841636946 @merlimat Can you review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] sijie commented on pull request #10591: Upgrade NodeJs in Pulsar Build image (used by WebSite Builder)

2021-05-15 Thread GitBox
sijie commented on pull request #10591: URL: https://github.com/apache/pulsar/pull/10591#issuecomment-841635606 @eolivelli - @codelipenghui can help you push as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] sijie commented on pull request #10564: [Transaction] Fix transaction end op retry problem.

2021-05-15 Thread GitBox
sijie commented on pull request #10564: URL: https://github.com/apache/pulsar/pull/10564#issuecomment-841635328 /pulsarbot run-failure-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch master updated: Fix sink/source exception stats (#10549)

2021-05-15 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5b73495 Fix sink/source exception stats

[GitHub] [pulsar] codelipenghui closed issue #10546: Sink status reports incorrect number of Exceptions

2021-05-15 Thread GitBox
codelipenghui closed issue #10546: URL: https://github.com/apache/pulsar/issues/10546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] codelipenghui merged pull request #10549: [Issue 10546] fix sink/source exception stats

2021-05-15 Thread GitBox
codelipenghui merged pull request #10549: URL: https://github.com/apache/pulsar/pull/10549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [pulsar] sijie commented on a change in pull request #10428: [Issue #10427] Add AvroSchema UUID support fix

2021-05-15 Thread GitBox
sijie commented on a change in pull request #10428: URL: https://github.com/apache/pulsar/pull/10428#discussion_r632925927 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/util/SchemaUtil.java ## @@ -88,8 +90,10 @@ public static Schema

[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841633526 > @Shoothzj thank you for the great work! > > My take on the connectors - I would recommend avoiding adding more connectors to the Pulsar repo. It becomes really hard

[GitHub] [pulsar] sijie commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
sijie commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841631324 @Shoothzj thank you for the great work! My take on the connectors - I would recommend avoiding adding more connectors to the Pulsar repo. It becomes really hard to

[GitHub] [pulsar] eolivelli commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
eolivelli commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841628878 Can you please open a discussion on d...@pulsar.apache.org? That's the place where we discuss about these topics. BTW thanks for this awesome work and for the

[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841626874 > Personally I believe that we can accept this code here and when we will split the repo the code will go into the new repo for connectors. > > That said, it is your

[GitHub] [pulsar] yangl commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source

2021-05-15 Thread GitBox
yangl commented on pull request #10597: URL: https://github.com/apache/pulsar/pull/10597#issuecomment-841623062 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] eolivelli commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
eolivelli commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841622775 Personally I believe that we can accept this code here and when we will split the repo the code will go into the new repo for connectors. That said, it is your

[GitHub] [pulsar] lhotari edited a comment on issue #10524: > I tested `pulsar 2.7.1 docker` on my local machine. Also java client version is `2.7.1`

2021-05-15 Thread GitBox
lhotari edited a comment on issue #10524: URL: https://github.com/apache/pulsar/issues/10524#issuecomment-841620558 Besides adjusting the receiver queue size, can you test if setting `.enableBatching(false)` on the producer makes a difference? If so, the problem might be fixed by #7266

[GitHub] [pulsar] lhotari commented on issue #10524: > I tested `pulsar 2.7.1 docker` on my local machine. Also java client version is `2.7.1`

2021-05-15 Thread GitBox
lhotari commented on issue #10524: URL: https://github.com/apache/pulsar/issues/10524#issuecomment-841620558 Can you test if setting `.enableBatching(false)` on the producer makes a difference? If so, the problem might be fixed by #7266 . -- This is an automated message from the

[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841619991 > Can you please explain better this problem with 'merge policy' ? @codelipenghui told me that the IO part is going to split with Pulsar main Repo, currently it's not