[GitHub] [pulsar-client-go] longtengz commented on issue #452: MetadataError: Consumer not found when instantiating a reader with StartMessageID: pulsar.LatestMessageID()

2021-06-29 Thread GitBox
longtengz commented on issue #452: URL: https://github.com/apache/pulsar-client-go/issues/452#issuecomment-870323570 I have the same error ``` ERRO[0027] [Failed to get last message id from broker] error="server error: MetadataError: Consumer not found" topic="persistent://pu

[GitHub] [pulsar] Jason918 opened a new issue #11143: Flaky-test: [org.apache.pulsar.metadata.ZKSessionTest].[testReacquireLeadershipAfterSessionLost]

2021-06-29 Thread GitBox
Jason918 opened a new issue #11143: URL: https://github.com/apache/pulsar/issues/11143 [org.apache.pulsar.metadata.ZKSessionTest] is flaky. The [testReacquireLeadershipAfterSessionLost] test method fails sporadically. [example failure](url here) https://github.com/apache/puls

[GitHub] [pulsar] hangc0276 opened a new pull request #11144: remove import regex format

2021-06-29 Thread GitBox
hangc0276 opened a new pull request #11144: URL: https://github.com/apache/pulsar/pull/11144 ### Motivation There are too many `import *` in pulsar source code, which is bad import style ### Modification 1. use import specific class instead of `import *` format -- This is an

[GitHub] [pulsar] Jason918 opened a new issue #11145: Flaky-test: [org.apache.pulsar.broker.service.ConsumedLedgersTrimTest].[testConsumedLedgersTrimNoSubscriptions]

2021-06-29 Thread GitBox
Jason918 opened a new issue #11145: URL: https://github.com/apache/pulsar/issues/11145 [org.apache.pulsar.broker.service.ConsumedLedgersTrimTest] is flaky. The [testConsumedLedgersTrimNoSubscriptions] test method fails sporadically. [example failure](url here) https://github.

[GitHub] [pulsar] codelipenghui merged pull request #11131: [Branch-2.7] Add authoritative flag for topic policy to avoid redirect loop

2021-06-29 Thread GitBox
codelipenghui merged pull request #11131: URL: https://github.com/apache/pulsar/pull/11131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] Jason918 commented on pull request #11069: [Issue 11067][pulsar-client] Fix bin/pulsar-client produce not supporting v2 topic name through websocket

2021-06-29 Thread GitBox
Jason918 commented on pull request #11069: URL: https://github.com/apache/pulsar/pull/11069#issuecomment-870347184 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Jason918 commented on pull request #11139: [Issue 10896] add get message id by timestamp

2021-06-29 Thread GitBox
Jason918 commented on pull request #11139: URL: https://github.com/apache/pulsar/pull/11139#issuecomment-870371894 @codelipenghui Hi, can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] Jason918 commented on pull request #11069: [Issue 11067][pulsar-client] Fix bin/pulsar-client produce not supporting v2 topic name through websocket

2021-06-29 Thread GitBox
Jason918 commented on pull request #11069: URL: https://github.com/apache/pulsar/pull/11069#issuecomment-870372075 @codelipenghui Hi, can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] eolivelli commented on a change in pull request #10934: Fixed #fixed incorrect use toString method.

2021-06-29 Thread GitBox
eolivelli commented on a change in pull request #10934: URL: https://github.com/apache/pulsar/pull/10934#discussion_r660381062 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java ## @@ -414,8 +425,9 @@ private int consumeFromWebSocket(S

[GitHub] [pulsar] eolivelli commented on pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-29 Thread GitBox
eolivelli commented on pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#issuecomment-870377744 please @315157973 take another look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] mattisonchao commented on a change in pull request #10934: Fixed #fixed incorrect use toString method.

2021-06-29 Thread GitBox
mattisonchao commented on a change in pull request #10934: URL: https://github.com/apache/pulsar/pull/10934#discussion_r660382733 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java ## @@ -414,8 +425,9 @@ private int consumeFromWebSocke

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11139: [Issue 10896] add get message id by timestamp

2021-06-29 Thread GitBox
codelipenghui commented on a change in pull request #11139: URL: https://github.com/apache/pulsar/pull/11139#discussion_r660397751 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java ## @@ -796,4 +798,55 @@ public void testSetRepl

[GitHub] [pulsar] codelipenghui merged pull request #11144: remove import regex format

2021-06-29 Thread GitBox
codelipenghui merged pull request #11144: URL: https://github.com/apache/pulsar/pull/11144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (e263e09 -> d65a9fa)

2021-06-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e263e09 Fix replay topic policy message not work (#11136) add d65a9fa Remove import regex format (#11144) No

[GitHub] [pulsar] Anonymitaet opened a new pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet opened a new pull request #11146: URL: https://github.com/apache/pulsar/pull/11146 Fix issues discussed in https://github.com/apache/pulsar/pull/11106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pulsar] mipper commented on a change in pull request #11006: Update SQL config to use composed contaiiners

2021-06-29 Thread GitBox
mipper commented on a change in pull request #11006: URL: https://github.com/apache/pulsar/pull/11006#discussion_r660414140 ## File path: docker-compose/kitchen-sink/docker-compose.yml ## @@ -377,6 +377,9 @@ services: zookeeperServers: zk1:2181,zk2:2181,zk3:2181 c

[pulsar-dotpulsar] branch master updated: Fix single partition router test (#78)

2021-06-29 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new acd723d Fix single partition

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11116: [Ledger] Fix ledger rollover scheduled task

2021-06-29 Thread GitBox
gaoran10 commented on a change in pull request #6: URL: https://github.com/apache/pulsar/pull/6#discussion_r660418334 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3361,7 +3359,7 @@ private boolean currentLe

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11116: [Ledger] Fix ledger rollover scheduled task

2021-06-29 Thread GitBox
gaoran10 commented on a change in pull request #6: URL: https://github.com/apache/pulsar/pull/6#discussion_r660418610 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3361,7 +3359,7 @@ private boolean currentLe

[GitHub] [pulsar-client-go] fishpenguin commented on pull request #533: [issue 516]Add lock for compressionProviders to fix data race problem

2021-06-29 Thread GitBox
fishpenguin commented on pull request #533: URL: https://github.com/apache/pulsar-client-go/pull/533#issuecomment-870411938 @dferstay @merlimat please review my code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11116: [Ledger] Fix ledger rollover scheduled task

2021-06-29 Thread GitBox
gaoran10 commented on a change in pull request #6: URL: https://github.com/apache/pulsar/pull/6#discussion_r660420196 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -3929,4 +3918,13 @@ public void clearBacklog

[GitHub] [pulsar] Anonymitaet commented on pull request #11106: [docs] Add docs for topic rate limiting

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11106: URL: https://github.com/apache/pulsar/pull/11106#issuecomment-870415998 Hi @gmethvin thanks for your suggestions. I've submitted a PR (https://github.com/apache/pulsar/pull/11146) to fix the issues you mentioned as below, could you please

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11116: [Ledger] Fix ledger rollover scheduled task

2021-06-29 Thread GitBox
gaoran10 commented on a change in pull request #6: URL: https://github.com/apache/pulsar/pull/6#discussion_r660423705 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -401,8 +401,6 @@ public void operationFailed

[GitHub] [pulsar] codelipenghui commented on pull request #11126: [Transaction] Transaction delete marker monitor.

2021-06-29 Thread GitBox
codelipenghui commented on pull request #11126: URL: https://github.com/apache/pulsar/pull/11126#issuecomment-870416270 @eolivelli > So IIUC we are not going to add an additional ThreadPool, I think we don't need to add an additional thread pool, we just need to add a check w

[GitHub] [pulsar] congbobo184 commented on a change in pull request #11135: [Broker] Fix broker dispatch byte rate limiter.

2021-06-29 Thread GitBox
congbobo184 commented on a change in pull request #11135: URL: https://github.com/apache/pulsar/pull/11135#discussion_r660424152 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/MessageDispatchThrottlingTest.java ## @@ -417,56 +418,45 @@ public void test

[GitHub] [pulsar] Anonymitaet commented on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870418149 @gmethvin @BewareMyPower could you please help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet edited a comment on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870418149 @gmethvin could you please help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar] Anonymitaet commented on pull request #11116: [Ledger] Fix ledger rollover scheduled task

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #6: URL: https://github.com/apache/pulsar/pull/6#issuecomment-870422315 Hi @gaoran10 any feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Anonymitaet commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-870424895 > I updated the versioned docs. @BewareMyPower @Anonymitaet @newur thanks, 2.8.1 doc does not need to be updated? -- This is an automated message from the Apache Gi

[GitHub] [pulsar] MathiasHaudgaard commented on issue #8152: Pulsar Authentication should support rotation of Validation keys e.g. Public keys used in JWT validation

2021-06-29 Thread GitBox
MathiasHaudgaard commented on issue #8152: URL: https://github.com/apache/pulsar/issues/8152#issuecomment-870426648 +1 on this one. @sijie is this being worked on atm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] Anonymitaet merged pull request #10115: [website][pulsar-client]Support auto generate html page for pulsar client cli tool

2021-06-29 Thread GitBox
Anonymitaet merged pull request #10115: URL: https://github.com/apache/pulsar/pull/10115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch master updated (d65a9fa -> efbf9c1)

2021-06-29 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d65a9fa Remove import regex format (#11144) add efbf9c1 [website][pulsar-client]Support auto generate html page

[GitHub] [pulsar] BewareMyPower commented on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
BewareMyPower commented on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870429434 I have another question that may not block the merge this PR. ![image](https://user-images.githubusercontent.com/18204803/123771932-0b6e4180-d8fe-11eb-82ad-e76a4e64

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11141: add parameter to control publish message check policy frequency

2021-06-29 Thread GitBox
Anonymitaet commented on a change in pull request #11141: URL: https://github.com/apache/pulsar/pull/11141#discussion_r660443479 ## File path: conf/broker.conf ## @@ -487,6 +487,10 @@ maxMessagePublishBufferSizeInMB= # Use 0 or negative number to disable the check retentionCh

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11141: add parameter to control publish message check policy frequency

2021-06-29 Thread GitBox
Anonymitaet commented on a change in pull request #11141: URL: https://github.com/apache/pulsar/pull/11141#discussion_r660443479 ## File path: conf/broker.conf ## @@ -487,6 +487,10 @@ maxMessagePublishBufferSizeInMB= # Use 0 or negative number to disable the check retentionCh

[GitHub] [pulsar] Anonymitaet commented on pull request #11137: [docs] backport debezium source docu

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11137: URL: https://github.com/apache/pulsar/pull/11137#issuecomment-870439331 @tuteng the doc has been merged in master, is the doc appropriate to 2.7.0 - 2.8.1 as well? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Anonymitaet commented on pull request #11140: [Branch-2.7] Fix create partitioned topic in replicated namespace

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11140: URL: https://github.com/apache/pulsar/pull/11140#issuecomment-870440014 @gaoran10 does this change affect docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar] gmethvin commented on a change in pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
gmethvin commented on a change in pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#discussion_r660430236 ## File path: site2/docs/admin-api-namespaces.md ## @@ -905,7 +915,7 @@ admin.namespaces().removeDeduplicationSnapshotInterval(namespace) ### Namesp

[GitHub] [pulsar] tuteng commented on pull request #11137: [docs] backport debezium source docu

2021-06-29 Thread GitBox
tuteng commented on pull request #11137: URL: https://github.com/apache/pulsar/pull/11137#issuecomment-870442708 > @tuteng the doc has been merged in master, is the doc appropriate to 2.7.0 - 2.8.1 as well? All document-related updates take effect on the master branch -- This is a

[GitHub] [pulsar] gaoran10 commented on pull request #11116: [Ledger] Fix ledger rollover scheduled task

2021-06-29 Thread GitBox
gaoran10 commented on pull request #6: URL: https://github.com/apache/pulsar/pull/6#issuecomment-870443036 > @gaoran10 does this affect docs? Sorry late response, this is not affect doc. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] gaoran10 commented on pull request #11140: [Branch-2.7] Fix create partitioned topic in replicated namespace

2021-06-29 Thread GitBox
gaoran10 commented on pull request #11140: URL: https://github.com/apache/pulsar/pull/11140#issuecomment-870443993 > @gaoran10 does this change affect docs? This doesn't affect docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11139: [Issue 10896] add get message id by timestamp

2021-06-29 Thread GitBox
Anonymitaet commented on a change in pull request #11139: URL: https://github.com/apache/pulsar/pull/11139#discussion_r660453233 ## File path: site2/docs/admin-api-topics.md ## @@ -538,6 +538,31 @@ admin.topics().getMessageById(topic, ledgerId, entryId); +### Get message

[GitHub] [pulsar] tuteng commented on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
tuteng commented on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870446087 > I have another question that may not block the merge this PR. > > ![image](https://user-images.githubusercontent.com/18204803/123771932-0b6e4180-d8fe-11eb-82ad-e76a4e64a

[GitHub] [pulsar] tuteng edited a comment on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
tuteng edited a comment on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870446087 > I have another question that may not block the merge this PR. > > ![image](https://user-images.githubusercontent.com/18204803/123771932-0b6e4180-d8fe-11eb-82ad-e7

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on a change in pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#discussion_r660470423 ## File path: site2/docs/admin-api-brokers.md ## @@ -4,16 +4,26 @@ title: Managing Brokers sidebar_label: Brokers --- +> **Important** +> +> This

[GitHub] [pulsar] newur commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-29 Thread GitBox
newur commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-870460479 This branch is behind master, so it does not know 2.8.1. I can do a rebase or create a new PR, whatever you would prefer @Anonymitaet -- This is an automated message from the

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on a change in pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#discussion_r660472073 ## File path: site2/docs/admin-api-namespaces.md ## @@ -905,7 +915,7 @@ admin.namespaces().removeDeduplicationSnapshotInterval(namespace) ### Nam

svn commit: r48545 - /release/pulsar/KEYS

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:08:21 2021 New Revision: 48545 Log: Added gpg key for eolivelli Modified: release/pulsar/KEYS Modified: release/pulsar/KEYS == --- release/pulsar/KEYS (original) +++ release/pulsar

svn commit: r48546 - /release/pulsar/pulsar-2.6.3/

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:10:55 2021 New Revision: 48546 Log: Remove old releases - 2.6.3 Removed: release/pulsar/pulsar-2.6.3/

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on a change in pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#discussion_r660474494 ## File path: site2/docs/admin-api-overview.md ## @@ -9,15 +9,26 @@ The Pulsar admin interface enables you to manage all important entities in a Pul

svn commit: r48547 - /release/pulsar/pulsar-2.7.0/

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:11:28 2021 New Revision: 48547 Log: Remove old releases - 2.7.0 Removed: release/pulsar/pulsar-2.7.0/

svn commit: r48548 - /release/pulsar/pulsar-2.7.1/

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:11:46 2021 New Revision: 48548 Log: Remove old releases - 2.7.1 Removed: release/pulsar/pulsar-2.7.1/

svn commit: r48549 - /dev/pulsar/pulsar-2.8.0-candidate-1/

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:12:48 2021 New Revision: 48549 Log: Remove 2.8.0 candidate-1 Removed: dev/pulsar/pulsar-2.8.0-candidate-1/

svn commit: r48550 - /dev/pulsar/pulsar-2.8.0-candidate-2/

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:13:01 2021 New Revision: 48550 Log: Remove 2.8.0 candidate-2 Removed: dev/pulsar/pulsar-2.8.0-candidate-2/

svn commit: r48551 - /release/pulsar/pulsar-2.6.4/

2021-06-29 Thread penghui
Author: penghui Date: Tue Jun 29 10:13:57 2021 New Revision: 48551 Log: Remove old releases - 2.6.4 Removed: release/pulsar/pulsar-2.6.4/

[GitHub] [pulsar] Anonymitaet commented on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870465401 > Please replace HTTP links to HTTPS links. For example, replace http://pulsar.apache.org/tools/pulsar-admin/ to https://pulsar.apache.org/tools/pulsar-admin/ Thanks

[GitHub] [pulsar] newur edited a comment on pull request #10982: [docs] Add MessageListener example in addition to endless while loop

2021-06-29 Thread GitBox
newur edited a comment on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-870460479 This branch is behind master, so it does not know 2.8.1. I can do a rebase or create a new PR, whatever you would prefer @Anonymitaet /update, okay I just did the r

[pulsar-dotpulsar] branch master updated: Make ready for release 1.1.0 and autogenerate consumer/reader name when not set by the user

2021-06-29 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 7e1c9be Make ready for releas

[pulsar-dotpulsar] annotated tag 1.1.0 updated (7e1c9be -> 5c2a8e8)

2021-06-29 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a change to annotated tag 1.1.0 in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git. *** WARNING: tag 1.1.0 was modified! *** from 7e1c9be (commit) to 5c2a8e8 (tag) tagging

[GitHub] [pulsar] Anonymitaet commented on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870483161 > Is it possible to split out the redundant text into another file and include it in all the relevant files? It's not a huge deal but it'd be nice if we didn't have to manu

[GitHub] [pulsar] Anonymitaet commented on pull request #11146: [Doc] Add descriptions for various API docs

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #11146: URL: https://github.com/apache/pulsar/pull/11146#issuecomment-870484037 @gmethvin @BewareMyPower many thanks for your comments. I've incorporated them, PTAL. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] Anonymitaet commented on pull request #10982: [docs] Add MessageListener example in addition to endless while loop

2021-06-29 Thread GitBox
Anonymitaet commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-870486266 @newur thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Anonymitaet merged pull request #10982: [docs] Add MessageListener example in addition to endless while loop

2021-06-29 Thread GitBox
Anonymitaet merged pull request #10982: URL: https://github.com/apache/pulsar/pull/10982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch master updated: [docs] Add MessageListener example in addition to endless while loop (#10982)

2021-06-29 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8d29b5a [docs] Add MessageListener example in ad

[GitHub] [pulsar] HistoryGift opened a new issue #11147: flume io connector can not run normally

2021-06-29 Thread GitBox
HistoryGift opened a new issue #11147: URL: https://github.com/apache/pulsar/issues/11147 **Describe the bug** when flume io connector run , Exception: java.lang.IllegalArgumentException: Source class org.apache.pulsar.io.flume.sink.SourceOfFlume does not implement the correct inter

[GitHub] [pulsar] eolivelli commented on pull request #11135: [Broker] Fix broker dispatch byte rate limiter.

2021-06-29 Thread GitBox
eolivelli commented on pull request #11135: URL: https://github.com/apache/pulsar/pull/11135#issuecomment-870496023 @lhotari PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11085: Support socks5 proxy

2021-06-29 Thread GitBox
codelipenghui commented on a change in pull request #11085: URL: https://github.com/apache/pulsar/pull/11085#discussion_r660528462 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientWithSocks5ProxyTest.java ## @@ -0,0 +1,159 @@ +/** + * Licensed to t

[GitHub] [pulsar] codelipenghui commented on pull request #11085: Support socks5 proxy

2021-06-29 Thread GitBox
codelipenghui commented on pull request #11085: URL: https://github.com/apache/pulsar/pull/11085#issuecomment-870517587 @Anonymitaet I noticed you have added the `component/documentation` tag, we are using this for indicating the PR is only the documentation change? or the PR has documenta

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11085: Support socks5 proxy

2021-06-29 Thread GitBox
Technoboy- commented on a change in pull request #11085: URL: https://github.com/apache/pulsar/pull/11085#discussion_r660549507 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientWithSocks5ProxyTest.java ## @@ -0,0 +1,159 @@ +/** + * Licensed to the

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11085: Support socks5 proxy

2021-06-29 Thread GitBox
Technoboy- commented on a change in pull request #11085: URL: https://github.com/apache/pulsar/pull/11085#discussion_r660550604 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientWithSocks5ProxyTest.java ## @@ -0,0 +1,159 @@ +/** + * Licensed to the

[GitHub] [pulsar] aerfalwl commented on issue #5283: JAAS login in broker failed

2021-06-29 Thread GitBox
aerfalwl commented on issue #5283: URL: https://github.com/apache/pulsar/issues/5283#issuecomment-870549559 how did you solve this problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar] codelipenghui merged pull request #11118: [ Tests ] Fixed Wrong TimeUnit

2021-06-29 Thread GitBox
codelipenghui merged pull request #8: URL: https://github.com/apache/pulsar/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (8d29b5a -> c307cc1)

2021-06-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8d29b5a [docs] Add MessageListener example in addition to endless while loop (#10982) add c307cc1 [ Tests ]

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter

2021-06-29 Thread GitBox
codelipenghui commented on a change in pull request #1: URL: https://github.com/apache/pulsar/pull/1#discussion_r660563575 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ResponseHandlerFilterTest.java ## @@ -0,0 +1,130 @@ +/** + * Licensed to th

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11128: [ Tests ] Add new test for MaxRequestSizeFilter

2021-06-29 Thread GitBox
codelipenghui commented on a change in pull request #11128: URL: https://github.com/apache/pulsar/pull/11128#discussion_r660563867 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/MaxRequestSizeFilterTest.java ## @@ -0,0 +1,105 @@ +/** + * Licensed to the

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11111: [ Tests ] Add new unit test for ReponseHandlerFilter

2021-06-29 Thread GitBox
mattisonchao commented on a change in pull request #1: URL: https://github.com/apache/pulsar/pull/1#discussion_r660564083 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ResponseHandlerFilterTest.java ## @@ -0,0 +1,130 @@ +/** + * Licensed to the

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11133: [ Tests ] Add new test for ProcessHandlerFilter

2021-06-29 Thread GitBox
codelipenghui commented on a change in pull request #11133: URL: https://github.com/apache/pulsar/pull/11133#discussion_r660564833 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/web/ProcessHandlerFilterTest.java ## @@ -0,0 +1,86 @@ +/** + * Licensed to the

[GitHub] [pulsar] codelipenghui commented on pull request #11117: [ Tests ] Fixed flaky test createResourceGroup

2021-06-29 Thread GitBox
codelipenghui commented on pull request #7: URL: https://github.com/apache/pulsar/pull/7#issuecomment-870561249 @mattisonchao If the tests failed frequently, I'm not sure if increase the timeout to 30s can fix the problem. Because 10s looks enough for the HTTP request since we do n

[GitHub] [pulsar] codelipenghui merged pull request #11110: Fix GetListInBundle return all Topics in bundle

2021-06-29 Thread GitBox
codelipenghui merged pull request #0: URL: https://github.com/apache/pulsar/pull/0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (c307cc1 -> a6ab3af)

2021-06-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c307cc1 [ Tests ] Fixed Wrong TimeUnit (#8) add a6ab3af Fix GetListInBundle return all Topics in bundle (

[GitHub] [pulsar] codelipenghui merged pull request #11094: [Issue 10579] Fix inputs to return a list of topic

2021-06-29 Thread GitBox
codelipenghui merged pull request #11094: URL: https://github.com/apache/pulsar/pull/11094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui closed issue #10579: Sinks API endpoint `getSinkInfo` does not properly return a list of topic inputs

2021-06-29 Thread GitBox
codelipenghui closed issue #10579: URL: https://github.com/apache/pulsar/issues/10579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated: [Issue 10579] Fix inputs to return a list of topic (#11094)

2021-06-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0ee3956 [Issue 10579] Fix inputs to return a l

[GitHub] [pulsar] suiyuzeng opened a new pull request #11148: Increase the rate of topic creation

2021-06-29 Thread GitBox
suiyuzeng opened a new pull request #11148: URL: https://github.com/apache/pulsar/pull/11148 ### Motivation The count of topic created in 1 second is less than 200, when the topic count of the namespace is about 200,000. ### Modifications The reason is that the time cost of top

[GitHub] [pulsar] Technoboy- opened a new issue #11149: Flaky-test: [LoadBalancerTest].[testBrokerRanking]

2021-06-29 Thread GitBox
Technoboy- opened a new issue #11149: URL: https://github.com/apache/pulsar/issues/11149 [LoadBalancerTest] is flaky. The [testBrokerRanking] test method fails sporadically. ``` Error: Tests run: 15, Failures: 1, Errors: 0, Skipped: 14, Time elapsed: 16.427 s <<< FAILURE! - in o

[GitHub] [pulsar] Jason918 commented on a change in pull request #11139: [Issue 10896] add get message id by timestamp

2021-06-29 Thread GitBox
Jason918 commented on a change in pull request #11139: URL: https://github.com/apache/pulsar/pull/11139#discussion_r660581016 ## File path: site2/docs/admin-api-topics.md ## @@ -538,6 +538,31 @@ admin.topics().getMessageById(topic, ledgerId, entryId); +### Get message ID

[GitHub] [pulsar] HistoryGift commented on issue #11147: flume io connector can not run normally

2021-06-29 Thread GitBox
HistoryGift commented on issue #11147: URL: https://github.com/apache/pulsar/issues/11147#issuecomment-870571748 I download and copy pulsar-flume-io.jar to lib,I get a new issue "JavaInstanceRunnable - Encountered exception in sink write: java.lang.NullPointerException: null" Ex

[GitHub] [pulsar] codelipenghui merged pull request #11121: fix the timestamp description for resetCursor

2021-06-29 Thread GitBox
codelipenghui merged pull request #11121: URL: https://github.com/apache/pulsar/pull/11121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (0ee3956 -> a48b725)

2021-06-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0ee3956 [Issue 10579] Fix inputs to return a list of topic (#11094) add a48b725 Fix the timestamp description

[GitHub] [pulsar] Jason918 commented on a change in pull request #11139: [Issue 10896] add get message id by timestamp

2021-06-29 Thread GitBox
Jason918 commented on a change in pull request #11139: URL: https://github.com/apache/pulsar/pull/11139#discussion_r660593334 ## File path: site2/docs/admin-api-topics.md ## @@ -538,6 +538,31 @@ admin.topics().getMessageById(topic, ledgerId, entryId); +### Get message ID

[GitHub] [pulsar] newur edited a comment on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-29 Thread GitBox
newur edited a comment on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-869893130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pulsar] congbobo184 commented on a change in pull request #11126: [Transaction] Transaction delete marker monitor.

2021-06-29 Thread GitBox
congbobo184 commented on a change in pull request #11126: URL: https://github.com/apache/pulsar/pull/11126#discussion_r659904127 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -390,16 +391,7 @@ public voi

[GitHub] [pulsar] wuchenxi123 commented on pull request #11112: pulsar-function:Preload and release of external resources

2021-06-29 Thread GitBox
wuchenxi123 commented on pull request #2: URL: https://github.com/apache/pulsar/pull/2#issuecomment-869770568 > You may misunderstand my comment. > > > IMO it's not a good practice to just use Exception as the checked exception but not the subclass of Exception. > > I

[GitHub] [pulsar] 315157973 commented on pull request #11110: Fix GetListInBundle return all Topics in bundle

2021-06-29 Thread GitBox
315157973 commented on pull request #0: URL: https://github.com/apache/pulsar/pull/0#issuecomment-869743386 > @315157973 does this affect docs? Does not affect the docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] newur commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-29 Thread GitBox
newur commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-869893130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [pulsar] wuchenxi123 commented on a change in pull request #11112: pulsar-function:Preload and release of external resources

2021-06-29 Thread GitBox
wuchenxi123 commented on a change in pull request #2: URL: https://github.com/apache/pulsar/pull/2#discussion_r659874295 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java ## @@ -160,7 +179,22 @@ private void pr

[GitHub] [pulsar] codelipenghui closed issue #11124: Flaky-test: [TopicFromMessageTest].[testMultiTopicConsumerBatchShortName]

2021-06-29 Thread GitBox
codelipenghui closed issue #11124: URL: https://github.com/apache/pulsar/issues/11124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] codelipenghui commented on pull request #11125: Fix Flaky-test: [TopicFromMessageTest].[testMultiTopicConsumerBatchShortName

2021-06-29 Thread GitBox
codelipenghui commented on pull request #11125: URL: https://github.com/apache/pulsar/pull/11125#issuecomment-869730196 ``` Error: Tests run: 15, Failures: 1, Errors: 0, Skipped: 14, Time elapsed: 16.427 s <<< FAILURE! - in org.apache.pulsar.broker.loadbalance.LoadBalancerTest Error:

[GitHub] [pulsar-client-go] wolfstudy closed issue #554: When using TopicsPattern mode to subscribe, there will be a 403 error

2021-06-29 Thread GitBox
wolfstudy closed issue #554: URL: https://github.com/apache/pulsar-client-go/issues/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [pulsar] nlu90 commented on pull request #11056: [pulsar-io] pass pulsar client via context to connector

2021-06-29 Thread GitBox
nlu90 commented on pull request #11056: URL: https://github.com/apache/pulsar/pull/11056#issuecomment-869996839 Hi, seems the CI check failed for some weird reason. Can anyone re-run all the test? -- This is an automated message from the Apache Git Service. To respond to the messa

  1   2   3   >