[GitHub] [pulsar] Technoboy- commented on issue #11008: Java client: consumer listener does not respect receiver queue size

2021-07-23 Thread GitBox
Technoboy- commented on issue #11008: URL: https://github.com/apache/pulsar/issues/11008#issuecomment-885990153 I will try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codelipenghui commented on pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

2021-07-23 Thread GitBox
codelipenghui commented on pull request #11443: URL: https://github.com/apache/pulsar/pull/11443#issuecomment-885984006 @Jason918 Please check the checkstyle issue ``` Error: src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java:[111,44] (whitespace)

[GitHub] [pulsar] equanz commented on pull request #11382: [broker] Fixed Replicated Subscription isn't replicate new subscription when remote producer is closed

2021-07-23 Thread GitBox
equanz commented on pull request #11382: URL: https://github.com/apache/pulsar/pull/11382#issuecomment-885976835 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] jerrypeng commented on pull request #11401: [pulsar-function] Stop calling the deprated method Thread.stop when stopping the function thread in ThreadRuntime.

2021-07-23 Thread GitBox
jerrypeng commented on pull request #11401: URL: https://github.com/apache/pulsar/pull/11401#issuecomment-885967481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[pulsar] branch master updated (2511133 -> b567ecd)

2021-07-23 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2511133 [Elasticsearch-sink] support multi Elasticsearch hosts (#10973) add b567ecd Fix issue in CLI when

[GitHub] [pulsar] jerrypeng merged pull request #11378: Fix issue in CLI when validating batch source config

2021-07-23 Thread GitBox
jerrypeng merged pull request #11378: URL: https://github.com/apache/pulsar/pull/11378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11450: [PIP-82] Fix attach ResourceGroup to Namespace REST api

2021-07-23 Thread GitBox
ravi-vaidyanathan commented on pull request #11450: URL: https://github.com/apache/pulsar/pull/11450#issuecomment-885964722 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] nlu90 opened a new pull request #11451: update doc

2021-07-23 Thread GitBox
nlu90 opened a new pull request #11451: URL: https://github.com/apache/pulsar/pull/11451 ### Motivation Update documentation for recent changes in: #11399 and #11251 @Anonymitaet Please help take a look. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] bharanic-dev commented on pull request #11450: [PIP-82] Fix attach ResourceGroup to Namespace REST api

2021-07-23 Thread GitBox
bharanic-dev commented on pull request #11450: URL: https://github.com/apache/pulsar/pull/11450#issuecomment-885953625 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] equanz commented on pull request #11382: [broker] Fixed Replicated Subscription isn't replicate new subscription when remote producer is closed

2021-07-23 Thread GitBox
equanz commented on pull request #11382: URL: https://github.com/apache/pulsar/pull/11382#issuecomment-885952619 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11450: [PIP-82] Fix attach ResourceGroup to Namespace REST api

2021-07-23 Thread GitBox
ravi-vaidyanathan commented on pull request #11450: URL: https://github.com/apache/pulsar/pull/11450#issuecomment-885948000 @jerrypeng please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] ravi-vaidyanathan opened a new pull request #11450: [PIP-82] Fix attach ResourceGroup to Namespace REST api

2021-07-23 Thread GitBox
ravi-vaidyanathan opened a new pull request #11450: URL: https://github.com/apache/pulsar/pull/11450 The REST api to attach a ResourceGroup to namespace takes the name of ResourceGroup in the body of the HTTP request. Since it is a simple string we should modify the REST api to

[GitHub] [pulsar] dlg99 commented on pull request #11154: Fixing Debezium integration tests

2021-07-23 Thread GitBox
dlg99 commented on pull request #11154: URL: https://github.com/apache/pulsar/pull/11154#issuecomment-885935383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] nlu90 edited a comment on pull request #11154: Fixing Debezium integration tests

2021-07-23 Thread GitBox
nlu90 edited a comment on pull request #11154: URL: https://github.com/apache/pulsar/pull/11154#issuecomment-885933848 I pushed a fix for the debezium connector in #11435 And the integration test passed on my local laptop: ``` ➜ sn-pulsar git:(neng/kafka-source-async-ack) ✗

[GitHub] [pulsar] nlu90 commented on pull request #11154: Fixing Debezium integration tests

2021-07-23 Thread GitBox
nlu90 commented on pull request #11154: URL: https://github.com/apache/pulsar/pull/11154#issuecomment-885933848 I pushed a fix for the debezium connector in #11435 And the integration test passed on my local laptop: ➜ sn-pulsar git:(neng/kafka-source-async-ack) ✗ mvn test -f

[GitHub] [pulsar] sijie commented on pull request #11399: [pulsar function] add instanceId and fqn into log message properties

2021-07-23 Thread GitBox
sijie commented on pull request #11399: URL: https://github.com/apache/pulsar/pull/11399#issuecomment-885916501 @nlu90 you might need to rebase to the latest master to include CI fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar] branch master updated (a60c189 -> 2511133)

2021-07-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a60c189 [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when

[GitHub] [pulsar] sijie merged pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts

2021-07-23 Thread GitBox
sijie merged pull request #10973: URL: https://github.com/apache/pulsar/pull/10973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie commented on pull request #11119: Fix MsgDropRate missing from NonPersistentTopics stats output.

2021-07-23 Thread GitBox
sijie commented on pull request #9: URL: https://github.com/apache/pulsar/pull/9#issuecomment-885911304 @codelipenghui Can you review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] sijie commented on pull request #11326: [website][pulsar]: auto generate docs for pulsar subcommand: functions-worker

2021-07-23 Thread GitBox
sijie commented on pull request #11326: URL: https://github.com/apache/pulsar/pull/11326#issuecomment-885909788 @urfreespace Can you rebase to the latest master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar] branch master updated (8b1d937 -> a60c189)

2021-07-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8b1d937 swap getTopicReference(topic).isPresent() with serviceUnit.includes(topicName) to reduce calling

[GitHub] [pulsar] sijie commented on pull request #11328: [website][pulsar]: auto generate docs for pulsar subcommand: delete-cluster-metadata

2021-07-23 Thread GitBox
sijie commented on pull request #11328: URL: https://github.com/apache/pulsar/pull/11328#issuecomment-885909651 @urfreespace Can you rebase it to the latest master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] sijie closed issue #11339: Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscriptions are created

2021-07-23 Thread GitBox
sijie closed issue #11339: URL: https://github.com/apache/pulsar/issues/11339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie merged pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscriptions are created

2021-07-23 Thread GitBox
sijie merged pull request #11355: URL: https://github.com/apache/pulsar/pull/11355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (5819242 -> 8b1d937)

2021-07-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5819242 Reduce the probability of cache inconsistencies (#11423) add 8b1d937 swap

[GitHub] [pulsar] sijie merged pull request #11405: Swap getTopicReference(topic) with serviceUnit.includes to reduce calling getTopicReference

2021-07-23 Thread GitBox
sijie merged pull request #11405: URL: https://github.com/apache/pulsar/pull/11405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (cba4ea9 -> 5819242)

2021-07-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cba4ea9 Update Minikube link (#11439) add 5819242 Reduce the probability of cache inconsistencies (#11423) No

[pulsar] branch master updated (b3892ee -> cba4ea9)

2021-07-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b3892ee make KafkaSourceRecord ack() async to avoid deadlock (#11435) add cba4ea9 Update Minikube link

[GitHub] [pulsar] sijie merged pull request #11423: Reduce the probability of cache inconsistencies

2021-07-23 Thread GitBox
sijie merged pull request #11423: URL: https://github.com/apache/pulsar/pull/11423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie merged pull request #11439: [Docs] Update Minikube link

2021-07-23 Thread GitBox
sijie merged pull request #11439: URL: https://github.com/apache/pulsar/pull/11439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie commented on pull request #11154: Fixing Debezium integration tests

2021-07-23 Thread GitBox
sijie commented on pull request #11154: URL: https://github.com/apache/pulsar/pull/11154#issuecomment-885904531 I think the agreement is to let Neng work on a proper fix based on Andrey's PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] david-streamlio opened a new issue #11449: Python client documentation is incorrect

2021-07-23 Thread GitBox
david-streamlio opened a new issue #11449: URL: https://github.com/apache/pulsar/issues/11449 **Describe the bug** In the latest [documentation](https://pulsar.apache.org/docs/en/client-libraries-python/) on the Python client library, the installation instructions for the optional

[GitHub] [pulsar] david-streamlio opened a new issue #11448: Delayed message delivery doesn't work in Python.

2021-07-23 Thread GitBox
david-streamlio opened a new issue #11448: URL: https://github.com/apache/pulsar/issues/11448 **Describe the bug** Messages sent using the Python client, 2.6.3 that specify a value in the deliver_after parameter are delivered immediately to any attached consumer. **To Reproduce**

[GitHub] [pulsar] sanjivr commented on pull request #11447: [python] Support CryptoKeyReader for Reader API in python clients

2021-07-23 Thread GitBox
sanjivr commented on pull request #11447: URL: https://github.com/apache/pulsar/pull/11447#issuecomment-885892965 @rdhabalia - Can you take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] sanjivr opened a new pull request #11447: [python] Support CryptoKeyReader for Reader API in python clients

2021-07-23 Thread GitBox
sanjivr opened a new pull request #11447: URL: https://github.com/apache/pulsar/pull/11447 ### Motivation The Reader API in the python client does not support reading an encrypted message. This PR adds the same and leverages existing C++ Reader API which supports the same.

[pulsar] branch master updated: make KafkaSourceRecord ack() async to avoid deadlock (#11435)

2021-07-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b3892ee make KafkaSourceRecord ack() async to

[GitHub] [pulsar] sijie merged pull request #11435: [pulsar io] make KafkaSourceRecord ack() non-blocking to avoid deadlock

2021-07-23 Thread GitBox
sijie merged pull request #11435: URL: https://github.com/apache/pulsar/pull/11435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nlu90 commented on pull request #11399: [pulsar function] add instanceId and fqn into log message properties

2021-07-23 Thread GitBox
nlu90 commented on pull request #11399: URL: https://github.com/apache/pulsar/pull/11399#issuecomment-885876176 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] lhotari commented on a change in pull request #11446: [issue #13351] Solving precise rate limiting does not takes effect

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11446: URL: https://github.com/apache/pulsar/pull/11446#discussion_r675753931 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -257,14 +267,14 @@ public synchronized TimeUnit

[GitHub] [pulsar] nlu90 commented on pull request #11401: [pulsar-function] Stop calling the deprated method Thread.stop when stopping the function thread in ThreadRuntime.

2021-07-23 Thread GitBox
nlu90 commented on pull request #11401: URL: https://github.com/apache/pulsar/pull/11401#issuecomment-885837919 @jerrypeng Your suggested changes are safer, may be we can add the changes in this PR? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675786359 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -203,7 +203,7 @@ public synchronized boolean

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675785986 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -203,7 +203,7 @@ public synchronized boolean

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675777849 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -63,6 +63,13 @@ public boolean

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675763675 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterDisable.java ## @@ -59,7 +59,7 @@ public void

[GitHub] [pulsar] lhotari commented on a change in pull request #11446: [issue #13351] Solving precise rate limiting does not takes effect

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11446: URL: https://github.com/apache/pulsar/pull/11446#discussion_r675753931 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -257,14 +267,14 @@ public synchronized TimeUnit

[GitHub] [pulsar] nlu90 commented on pull request #11435: make KafkaSourceRecord ack() non-blocking to avoid deadlock

2021-07-23 Thread GitBox
nlu90 commented on pull request #11435: URL: https://github.com/apache/pulsar/pull/11435#issuecomment-885811144 And Here's the integration test result run on my local laptop: ``` [INFO] [INFO] Reactor Summary

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675748625 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -63,6 +63,13 @@ public boolean

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675747760 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -63,6 +63,13 @@ public boolean

[GitHub] [pulsar] lhotari commented on a change in pull request #11446: [issue #13351] Solving precise rate limiting does not takes effect

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11446: URL: https://github.com/apache/pulsar/pull/11446#discussion_r675741825 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -257,14 +267,14 @@ public synchronized TimeUnit

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675740688 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -29,17 +30,20 @@ protected volatile

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675737658 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -63,6 +67,14 @@ public boolean

[GitHub] [pulsar] danielsinai opened a new pull request #11446: [issue #13351] Solving precise rate limiting does not takes effect

2021-07-23 Thread GitBox
danielsinai opened a new pull request #11446: URL: https://github.com/apache/pulsar/pull/11446 ## Master Issue: #11351 ### Motivation This PR is fixing the 1,2 problems as described in #11351. There was a bigger Pull request that I published #11352, but I closed it in

[GitHub] [pulsar] rvashishth opened a new issue #11445: deduplication is not working as expected

2021-07-23 Thread GitBox
rvashishth opened a new issue #11445: URL: https://github.com/apache/pulsar/issues/11445 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Create pulsar cluster with version 2.7.1 2. enabled topic

[GitHub] [pulsar] danielsinai commented on pull request #11352: [ISSUE #11351] separate Rate Limiter Implementation to LeakyBucket and FixedWindow

2021-07-23 Thread GitBox
danielsinai commented on pull request #11352: URL: https://github.com/apache/pulsar/pull/11352#issuecomment-885717939 @lhotari Ok I understand that this is a big change. I will close this PR and open a new one that includes a patch for the current solution like have been done in the

[GitHub] [pulsar] danielsinai closed pull request #11352: [ISSUE #11351] separate Rate Limiter Implementation to LeakyBucket and FixedWindow

2021-07-23 Thread GitBox
danielsinai closed pull request #11352: URL: https://github.com/apache/pulsar/pull/11352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675639916 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -203,7 +203,7 @@ public synchronized boolean

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675639007 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterDisable.java ## @@ -59,7 +59,7 @@ public void

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675638792 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -29,17 +30,20 @@ protected volatile

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675624248 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterDisable.java ## @@ -59,7 +59,7 @@ public void

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675629177 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java ## @@ -203,7 +203,7 @@ public synchronized boolean

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675623617 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -29,17 +30,20 @@ protected volatile

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675624248 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterDisable.java ## @@ -59,7 +59,7 @@ public void

[GitHub] [pulsar] ronfarkash commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
ronfarkash commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675623617 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -29,17 +30,20 @@ protected volatile

[GitHub] [pulsar] lhotari commented on pull request #11352: [ISSUE #11351] separate Rate Limiter Implementation to LeakyBucket and FixedWindow

2021-07-23 Thread GitBox
lhotari commented on pull request #11352: URL: https://github.com/apache/pulsar/pull/11352#issuecomment-885665292 @danielsinai I think there's a good intent in this PR, but currently it doesn't provide much value. The high level problem of the changes is that it adds more

[GitHub] [pulsar] lhotari commented on a change in pull request #11372: [Issue #11351] Parallel Precise Publish Rate Limiting Fix

2021-07-23 Thread GitBox
lhotari commented on a change in pull request #11372: URL: https://github.com/apache/pulsar/pull/11372#discussion_r675571542 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PrecisPublishLimiter.java ## @@ -29,17 +30,20 @@ protected volatile

[GitHub] [pulsar] sbourkeostk opened a new issue #11444: Provide DLQ capibilities for Sinks

2021-07-23 Thread GitBox
sbourkeostk opened a new issue #11444: URL: https://github.com/apache/pulsar/issues/11444 Currently Sinks do not have DLQ capabilities. There are many cases for which this would be useful. Eg. the message is not suitable for the sink destination. Functions already have this

[GitHub] [pulsar] bry00 commented on issue #4271: Pulsar Avro Schema Enum improvement request

2021-07-23 Thread GitBox
bry00 commented on issue #4271: URL: https://github.com/apache/pulsar/issues/4271#issuecomment-885642406 > the problem here is that `MyEnum` is really of Python type `Enum`. That enum might be defined elsewhere in the application (or might be coming from a library), therefore we cannot

[GitHub] [pulsar] lhotari commented on pull request #10384: [Broker] Fix set-publish-rate when using preciseTopicPublishRateLimiterEnable=true

2021-07-23 Thread GitBox
lhotari commented on pull request #10384: URL: https://github.com/apache/pulsar/pull/10384#issuecomment-885639211 @sijie @aloyszhang @codelipenghui I have rebased the changes. Please review this PR and #11442 . There are other PRs #11352 and #11372 that depend on these changes so it

[GitHub] [pulsar] Jason918 opened a new pull request #11443: [Issue 11440]. Add complete metadata for admin.topics().examineMessages

2021-07-23 Thread GitBox
Jason918 opened a new pull request #11443: URL: https://github.com/apache/pulsar/pull/11443 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #11440 ### Motivation see issue 11440 ### Modifications Add all the other non-empty meta

[GitHub] [pulsar] lhotari commented on pull request #10384: [Broker] Fix set-publish-rate when using preciseTopicPublishRateLimiterEnable=true

2021-07-23 Thread GitBox
lhotari commented on pull request #10384: URL: https://github.com/apache/pulsar/pull/10384#issuecomment-885635317 > * at the time of configuration change, if the connection was in a state where the 'read is disabled' (because of a previous rate limit), should the RateLimiter call

[GitHub] [pulsar] ericsyh commented on issue #11436: [Question][Protocol Handler] Does single broker node support multi msg protocols in config?

2021-07-23 Thread GitBox
ericsyh commented on issue #11436: URL: https://github.com/apache/pulsar/issues/11436#issuecomment-885634534 @codelipenghui got it, many thanks. Maybe we can add this sample to [broker.conf](https://github.com/apache/pulsar/blob/master/conf/broker.conf) and

[GitHub] [pulsar] lhotari commented on pull request #10384: [Broker] Fix set-publish-rate when using preciseTopicPublishRateLimiterEnable=true

2021-07-23 Thread GitBox
lhotari commented on pull request #10384: URL: https://github.com/apache/pulsar/pull/10384#issuecomment-885632744 I have reduced the scope of this PR to cover the issues with `set-publish-rate`, including the resource leak with executors -- This is an automated message from the Apache

[GitHub] [pulsar] lhotari commented on pull request #10384: [Broker] Fix various issues when using preciseTopicPublishRateLimiterEnable=true

2021-07-23 Thread GitBox
lhotari commented on pull request #10384: URL: https://github.com/apache/pulsar/pull/10384#issuecomment-885626912 #11442 was split from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] lhotari opened a new pull request #11442: [Broker] Fix producing messages when preciseTopicPublishRateLimiterEnable=true

2021-07-23 Thread GitBox
lhotari opened a new pull request #11442: URL: https://github.com/apache/pulsar/pull/11442 Fixes #10603 ### Motivation See #10603 ### Modifications - modify PublishRateLimiterDisable to always return true from `tryAcquire` method -- This is an automated

[GitHub] [pulsar] codelipenghui commented on pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
codelipenghui commented on pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#issuecomment-885618936 @eolivelli Thanks for the review. Could you please help take a look again? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] codelipenghui edited a comment on issue #11436: [Question][Protocol Handler] Does single broker node support multi msg protocols in config?

2021-07-23 Thread GitBox
codelipenghui edited a comment on issue #11436: URL: https://github.com/apache/pulsar/issues/11436#issuecomment-885613607 @ericsyh You can just set the `messagingProtocols=kafka,mqtt` and copy the kop and mop Nar package to the protocolHandlerDirectory -- This is an automated message

[GitHub] [pulsar] codelipenghui commented on issue #11436: [Question][Protocol Handler] Does single broker node support multi msg protocols in config?

2021-07-23 Thread GitBox
codelipenghui commented on issue #11436: URL: https://github.com/apache/pulsar/issues/11436#issuecomment-885613607 You can just set the `messagingProtocols=kafka,mqtt` and copy the kop and mop Nar package to the protocolHandlerDirectory -- This is an automated message from the Apache

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675525996 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -53,23 +61,26 @@ private

[GitHub] [pulsar] codelipenghui commented on pull request #11423: Reduce the probability of cache inconsistencies

2021-07-23 Thread GitBox
codelipenghui commented on pull request #11423: URL: https://github.com/apache/pulsar/pull/11423#issuecomment-885601001 @freeznet @nlu90 Please help review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] eolivelli commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
eolivelli commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675519608 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -53,23 +61,26 @@ private static

[pulsar] branch master updated (083bb62 -> 216623d)

2021-07-23 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 083bb62 Remove duplicate check for replicationClusterSet (#11429) add 216623d Add error log for schema admin

[GitHub] [pulsar] codelipenghui merged pull request #11427: add error log for schema admin operation

2021-07-23 Thread GitBox
codelipenghui merged pull request #11427: URL: https://github.com/apache/pulsar/pull/11427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (62b5dfb -> 083bb62)

2021-07-23 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 62b5dfb [Broker] Add multi roles support for authorization (#11341) add 083bb62 Remove duplicate check for

[GitHub] [pulsar] codelipenghui merged pull request #11429: Remove duplicate check for replicationClusterSet

2021-07-23 Thread GitBox
codelipenghui merged pull request #11429: URL: https://github.com/apache/pulsar/pull/11429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui opened a new pull request #11441: [PIP-88] Replicate schemas across clusters

2021-07-23 Thread GitBox
codelipenghui opened a new pull request #11441: URL: https://github.com/apache/pulsar/pull/11441 ### Motivation Here is the proposal: https://github.com/apache/pulsar/wiki/PIP-88%3A-Replicate-schemas-across-multiple For the implementation, we just need to set the correct

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675513538 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -53,23 +61,26 @@ private

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675509442 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -53,23 +61,26 @@ private

[GitHub] [pulsar] eolivelli commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
eolivelli commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675480274 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -53,23 +61,26 @@ private static

[GitHub] [pulsar] codelipenghui commented on pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
codelipenghui commented on pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#issuecomment-885530258 I think we can implement the `waitForCoordinatorToBeAvailable` first and then merge this PR. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675440976 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -139,4 +141,22 @@ protected void

[GitHub] [pulsar] eolivelli commented on pull request #11422: Allow to config Sasl configs in Kafka sink.

2021-07-23 Thread GitBox
eolivelli commented on pull request #11422: URL: https://github.com/apache/pulsar/pull/11422#issuecomment-885518065 for the tests simple unit tests around `KafkaAbstractSink#open()` is enough. We do not need integration tests (they will be very heavyweight) -- This is an automated

[GitHub] [pulsar] wangjialing218 commented on a change in pull request #11427: add error log for schema admin operation

2021-07-23 Thread GitBox
wangjialing218 commented on a change in pull request #11427: URL: https://github.com/apache/pulsar/pull/11427#discussion_r675419118 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -294,4 +302,6 @@ private void

[GitHub] [pulsar] 315157973 commented on pull request #11405: Swap getTopicReference(topic) with serviceUnit.includes to reduce calling getTopicReference

2021-07-23 Thread GitBox
315157973 commented on pull request #11405: URL: https://github.com/apache/pulsar/pull/11405#issuecomment-885505465 @Technoboy- Please try rebase the master branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Jason918 commented on issue #11440: Incomplete metadata in MessageImpl return by admin.topics().examineMessage()

2021-07-23 Thread GitBox
Jason918 commented on issue #11440: URL: https://github.com/apache/pulsar/issues/11440#issuecomment-885500977 I would like to submit PR to fix this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Jason918 opened a new issue #11440: Incomplete metadata in MessageImpl return by admin.topics().examineMessage()

2021-07-23 Thread GitBox
Jason918 opened a new issue #11440: URL: https://github.com/apache/pulsar/issues/11440 **Is your enhancement request related to a problem? Please describe.** We can get MessageImpl object using `org.apache.pulsar.client.admin.Topics#examineMessage`, but it has Incomplete metadata ,

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675396949 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -139,4 +141,22 @@ protected void

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675396949 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -139,4 +141,22 @@ protected void

[GitHub] [pulsar] eolivelli commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
eolivelli commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675393136 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -139,4 +141,22 @@ protected void cleanup()

[GitHub] [pulsar] eolivelli commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
eolivelli commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675392680 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -139,4 +141,22 @@ protected void cleanup()

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11438: Add getTxnID method in Transaction.java

2021-07-23 Thread GitBox
liangyepianzhou commented on a change in pull request #11438: URL: https://github.com/apache/pulsar/pull/11438#discussion_r675388105 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java ## @@ -139,4 +141,22 @@ protected void

  1   2   >