[GitHub] [pulsar] eolivelli commented on a change in pull request #11497: Use equals instead of == to compare strings (#11462)

2021-08-09 Thread GitBox
eolivelli commented on a change in pull request #11497: URL: https://github.com/apache/pulsar/pull/11497#discussion_r685711727 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarColumnMetadata.java ## @@ -187,7 +188,7 @@ public boolean

[GitHub] [pulsar-client-go] leizhiyuan commented on a change in pull request #586: [issue 585] retryRouter should Nack this message if error is not nil

2021-08-09 Thread GitBox
leizhiyuan commented on a change in pull request #586: URL: https://github.com/apache/pulsar-client-go/pull/586#discussion_r685711383 ## File path: pulsar/retry_router.go ## @@ -87,10 +87,15 @@ func (r *retryRouter) run() { producer := r.getProducer()

[GitHub] [pulsar] eolivelli commented on a change in pull request #11606: Fix race condition in concurrent schema deletion

2021-08-09 Thread GitBox
eolivelli commented on a change in pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#discussion_r685710425 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ## @@ -372,6 +374,21 @@ public String

[GitHub] [pulsar] eolivelli commented on a change in pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-09 Thread GitBox
eolivelli commented on a change in pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#discussion_r685707535 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java ## @@ -94,6 +94,53 @@ public void

[GitHub] [pulsar] Anonymitaet commented on pull request #11609: [Java Client] Switch from pretty print to compact print for configs

2021-08-09 Thread GitBox
Anonymitaet commented on pull request #11609: URL: https://github.com/apache/pulsar/pull/11609#issuecomment-895741065 @michaeljmarshall thanks for your contribution. What does `N/A`mean? No need doc? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Anonymitaet commented on pull request #11615: Fix schema-understand doc.

2021-08-09 Thread GitBox
Anonymitaet commented on pull request #11615: URL: https://github.com/apache/pulsar/pull/11615#issuecomment-895740330 Thanks for your contribution. Does this affect only master or other versioned docs? If latter, could you please help update all affected versions? Thanks -- This is

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685698910 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685698547 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following

[GitHub] [pulsar] gaozhangmin closed issue #11616: Failed to fence subscription

2021-08-09 Thread GitBox
gaozhangmin closed issue #11616: URL: https://github.com/apache/pulsar/issues/11616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685698036 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685697353 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685697220 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685696243 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -16,11 +48,45 @@ The configuration of the ElasticSearch sink connector has the following

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11602: Add Docs for the new ElasticSearch sink features

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11602: URL: https://github.com/apache/pulsar/pull/11602#discussion_r685695819 ## File path: site2/docs/io-elasticsearch-sink.md ## @@ -6,6 +6,38 @@ sidebar_label: ElasticSearch sink connector The ElasticSearch sink

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #586: [issue 585] retryRouter should Nack this message if error is not nil

2021-08-09 Thread GitBox
merlimat commented on a change in pull request #586: URL: https://github.com/apache/pulsar-client-go/pull/586#discussion_r685695372 ## File path: pulsar/retry_router.go ## @@ -87,10 +87,15 @@ func (r *retryRouter) run() { producer := r.getProducer()

[GitHub] [pulsar-client-go] equanz commented on a change in pull request #581: Fix data race issue in ServiceNameResolver

2021-08-09 Thread GitBox
equanz commented on a change in pull request #581: URL: https://github.com/apache/pulsar-client-go/pull/581#discussion_r685692859 ## File path: pulsar/internal/service_name_resolver.go ## @@ -98,8 +106,9 @@ func (r *pulsarServiceNameResolver) UpdateServiceURL(u *url.URL)

[GitHub] [pulsar] merlimat commented on a change in pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-09 Thread GitBox
merlimat commented on a change in pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#discussion_r685690801 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -898,6 +898,12 @@ public void

[GitHub] [pulsar] merlimat commented on a change in pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-09 Thread GitBox
merlimat commented on a change in pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#discussion_r68568 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -898,6 +898,12 @@ public void

[GitHub] [pulsar] BewareMyPower commented on pull request #11615: Fix schema-understand doc.

2021-08-09 Thread GitBox
BewareMyPower commented on pull request #11615: URL: https://github.com/apache/pulsar/pull/11615#issuecomment-895726524 OK, I also just found the original doc PR is a little confused because it contains both the schema definition part and protobuf native schema part. -- This is an

[GitHub] [pulsar] congbobo184 commented on pull request #11615: Fix schema-understand doc.

2021-08-09 Thread GitBox
congbobo184 commented on pull request #11615: URL: https://github.com/apache/pulsar/pull/11615#issuecomment-895725607 @BewareMyPower hi, I think this example is used to explain struct schema. Both avro and protobuf are good, what do you think? -- This is an automated message from the

[GitHub] [pulsar] aloyszhang commented on pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-09 Thread GitBox
aloyszhang commented on pull request #11613: URL: https://github.com/apache/pulsar/pull/11613#issuecomment-895722412 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] merlimat commented on pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

2021-08-09 Thread GitBox
merlimat commented on pull request #11601: URL: https://github.com/apache/pulsar/pull/11601#issuecomment-895719653 @lhotari @bharanic-dev #11198 should be ready to go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] gaozhangmin opened a new issue #11616: Failed to fence subscription

2021-08-09 Thread GitBox
gaozhangmin opened a new issue #11616: URL: https://github.com/apache/pulsar/issues/11616 ``` 23:44:10.613 [BookKeeperClientWorker-OrderedExecutor-16-0] WARN org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null][x-partition-2] Failed to reset cursor on subscription

[GitHub] [pulsar] congbobo184 opened a new pull request #11615: Fix schema-understand doc.

2021-08-09 Thread GitBox
congbobo184 opened a new pull request #11615: URL: https://github.com/apache/pulsar/pull/11615 now complex type example are not right, so fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] wuzhanpeng commented on pull request #11606: Fix race condition in concurrent schema deletion

2021-08-09 Thread GitBox
wuzhanpeng commented on pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#issuecomment-895704819 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] 315157973 opened a new pull request #11614: Fix subscribeRateLimiter cannot be disabled

2021-08-09 Thread GitBox
315157973 opened a new pull request #11614: URL: https://github.com/apache/pulsar/pull/11614 ### Motivation SubscribeRateLimiter cannot be disabled now. When there are many subscriptions, it will cause some memory leaks.

[GitHub] [pulsar-client-go] leizhiyuan opened a new pull request #586: fix:retryRouter should Nack this message if error is not nil

2021-08-09 Thread GitBox
leizhiyuan opened a new pull request #586: URL: https://github.com/apache/pulsar-client-go/pull/586 Fixes #585 ### Motivation Nack this message if error is not nil ### Modifications Nack this message if error is not nil ### Verifying this change

[GitHub] [pulsar-client-go] leizhiyuan opened a new issue #585: retryRouter should Nack this message if error is not nil

2021-08-09 Thread GitBox
leizhiyuan opened a new issue #585: URL: https://github.com/apache/pulsar-client-go/issues/585 Expected behavior retryRouter should Nack this message if error is not nil Actual behavior retryRouter ack the message Steps to reproduce How can

[GitHub] [pulsar] hangc0276 commented on pull request #10775: Run code to respond to auth challenge in a different thread in the pulsar client

2021-08-09 Thread GitBox
hangc0276 commented on pull request #10775: URL: https://github.com/apache/pulsar/pull/10775#issuecomment-895698153 @jerrypeng I have moved this one to release/2.8.2. Feel free to move it back it need to release at 2.8.1 -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] hangc0276 commented on pull request #9298: [Issue 9297][broker] Try to fix flaky infinite reconnection

2021-08-09 Thread GitBox
hangc0276 commented on pull request #9298: URL: https://github.com/apache/pulsar/pull/9298#issuecomment-895697754 @wuYin Could you please help check the failed tests and the conflicts? I have moved it to tag release/2.8.2, if the test passed and conflict addressed, we can move it back

[GitHub] [pulsar] Anonymitaet commented on pull request #11540: Update concepts-transactions.md

2021-08-09 Thread GitBox
Anonymitaet commented on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-895689737 > Thanks for your contribution. Does this affect only master or other versioned docs? > If latter, could you please help update all affected versions? Thanks

[GitHub] [pulsar-client-go] freeznet commented on a change in pull request #582: add epoch to handle create producer timeout

2021-08-09 Thread GitBox
freeznet commented on a change in pull request #582: URL: https://github.com/apache/pulsar-client-go/pull/582#discussion_r685650492 ## File path: pulsar/producer_partition.go ## @@ -298,7 +305,9 @@ func (p *partitionProducer) reconnectToBroker() { d :=

[GitHub] [pulsar-client-go] freeznet opened a new issue #584: Duplicate producer when create producer timeout

2021-08-09 Thread GitBox
freeznet opened a new issue #584: URL: https://github.com/apache/pulsar-client-go/issues/584 When the broker or zookeeper is temporary offline, which will cause the producer timeout and re-connect to the broker. But if the broker has already done the previous create producer request, the

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11598: [Blog] Add 2.7.3 announcement blog

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11598: URL: https://github.com/apache/pulsar/pull/11598#discussion_r685646495 ## File path: site2/website/blog/2021-08-xx-Apache-Pulsar-2-7-3.md ## @@ -0,0 +1,139 @@ +--- +author: Bo Cong, Anonymitaet +title: Apache Pulsar

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11598: [Blog] Add 2.7.3 announcement blog

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11598: URL: https://github.com/apache/pulsar/pull/11598#discussion_r685645782 ## File path: site2/website/blog/2021-08-xx-Apache-Pulsar-2-7-3.md ## @@ -0,0 +1,139 @@ +--- +author: Bo Cong, Anonymitaet +title: Apache Pulsar

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11598: [Blog] Add 2.7.3 announcement blog

2021-08-09 Thread GitBox
Anonymitaet commented on a change in pull request #11598: URL: https://github.com/apache/pulsar/pull/11598#discussion_r685644324 ## File path: site2/website/blog/2021-08-xx-Apache-Pulsar-2-7-3.md ## @@ -0,0 +1,139 @@ +--- +author: Bo Cong, Anonymitaet +title: Apache Pulsar

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #11598: [Blog] Add 2.7.3 announcement blog

2021-08-09 Thread GitBox
Jennifer88huang commented on a change in pull request #11598: URL: https://github.com/apache/pulsar/pull/11598#discussion_r685641953 ## File path: site2/website/blog/2021-08-xx-Apache-Pulsar-2-7-3.md ## @@ -0,0 +1,139 @@ +--- +author: Bo Cong, Anonymitaet +title: Apache Pulsar

[GitHub] [pulsar] Anonymitaet commented on pull request #11570: [Issue 11496][C++] Allow partitioned producers to start lazily

2021-08-09 Thread GitBox
Anonymitaet commented on pull request #11570: URL: https://github.com/apache/pulsar/pull/11570#issuecomment-895676879 @Vanlightly how about adding your changes [here](https://pulsar.apache.org/docs/en/next/client-libraries-cpp/)? -- This is an automated message from the Apache Git

[pulsar] branch master updated (f81824d -> b7e027b)

2021-08-09 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f81824d Added test for bundles cache invalidation (#11408) add b7e027b Fix: Cast exception occurs if

[GitHub] [pulsar] aloyszhang opened a new pull request #11613: avoid non-durable subscription misuse an existed durable subscription

2021-08-09 Thread GitBox
aloyszhang opened a new pull request #11613: URL: https://github.com/apache/pulsar/pull/11613 Fixes #11612 ### Motivation As described in #11612 , if a reader (or non durable subscription) use the same subscription name with an existed durable subscription, the reader will

[GitHub] [pulsar] jerrypeng merged pull request #11611: Fix: Cast exception occurs if function/source/sink type is ByteBuffer

2021-08-09 Thread GitBox
jerrypeng merged pull request #11611: URL: https://github.com/apache/pulsar/pull/11611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] aloyszhang opened a new issue #11612: reader can misuse an exist durable subscription

2021-08-09 Thread GitBox
aloyszhang opened a new issue #11612: URL: https://github.com/apache/pulsar/issues/11612 **Describe the bug** In our product environment, sometimes set `startMessageId` for a reader(created by flink source) has no effect. After troubleshoot, we found the root cause is the reader

[GitHub] [pulsar-client-go] k-pisey commented on issue #583: Reader can not read next coming messages when start with LatestMessageID

2021-08-09 Thread GitBox
k-pisey commented on issue #583: URL: https://github.com/apache/pulsar-client-go/issues/583#issuecomment-895667112 Publishing and reading messages happen in a single program attached above, reader was created before producer therefore there is a subscription associated with the given

[GitHub] [pulsar] wuzhanpeng commented on pull request #11606: Fix race condition in concurrent schema deletion

2021-08-09 Thread GitBox
wuzhanpeng commented on pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#issuecomment-895666932 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (cdcb86b -> f81824d)

2021-08-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cdcb86b [docs]Update deploy-bare-metal.md (#11452) add f81824d Added test for bundles cache invalidation

[GitHub] [pulsar] merlimat merged pull request #11408: Added test for bundles cache invalidation

2021-08-09 Thread GitBox
merlimat merged pull request #11408: URL: https://github.com/apache/pulsar/pull/11408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: [docs]Update deploy-bare-metal.md (#11452)

2021-08-09 Thread hjf
This is an automated email from the ASF dual-hosted git repository. hjf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cdcb86b [docs]Update deploy-bare-metal.md

[GitHub] [pulsar] Jennifer88huang merged pull request #11452: [docs]Update deploy-bare-metal.md

2021-08-09 Thread GitBox
Jennifer88huang merged pull request #11452: URL: https://github.com/apache/pulsar/pull/11452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] LeBW commented on a change in pull request #11553: Exposing the broker entry metadata to client

2021-08-09 Thread GitBox
LeBW commented on a change in pull request #11553: URL: https://github.com/apache/pulsar/pull/11553#discussion_r685620695 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ## @@ -663,6 +664,22 @@ public void release() { } }

[GitHub] [pulsar] Technoboy- commented on pull request #11564: [WIP]Add compacted topic metrics for TopicStats in CLI

2021-08-09 Thread GitBox
Technoboy- commented on pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#issuecomment-895654595 > I suggested a few changes and asked some questions about design. I think the `Sum` class needs tests before this can be merged. Thanks for reviewing. Yesterday, we

[GitHub] [pulsar] aloyszhang commented on a change in pull request #11553: Exposing the broker entry metadata to client

2021-08-09 Thread GitBox
aloyszhang commented on a change in pull request #11553: URL: https://github.com/apache/pulsar/pull/11553#discussion_r685619101 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ## @@ -663,6 +664,22 @@ public void release() { }

[GitHub] [pulsar] aloyszhang commented on a change in pull request #11553: Exposing the broker entry metadata to client

2021-08-09 Thread GitBox
aloyszhang commented on a change in pull request #11553: URL: https://github.com/apache/pulsar/pull/11553#discussion_r685619101 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ## @@ -663,6 +664,22 @@ public void release() { }

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11500: Add metrics for writing or reading size of cursor

2021-08-09 Thread GitBox
Technoboy- commented on a change in pull request #11500: URL: https://github.com/apache/pulsar/pull/11500#discussion_r685617759 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java ## @@ -70,4 +70,33 @@ */ long

[GitHub] [pulsar] jerrypeng opened a new pull request #11611: Fix: Cast exception occurs if function/source/sink type is ByteBuffer

2021-08-09 Thread GitBox
jerrypeng opened a new pull request #11611: URL: https://github.com/apache/pulsar/pull/11611 ### Motivation If a Pulsar Function/Source/Sink is of type ByteBuffer, an cast exception will occur: ``` 6:44:00.226 INFO [external-repl-prop/io/PulsarSink-test-0]

[GitHub] [pulsar] jerrypeng closed pull request #11610: Fix sink byte buffer

2021-08-09 Thread GitBox
jerrypeng closed pull request #11610: URL: https://github.com/apache/pulsar/pull/11610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] jerrypeng opened a new pull request #11610: Fix sink byte buffer

2021-08-09 Thread GitBox
jerrypeng opened a new pull request #11610: URL: https://github.com/apache/pulsar/pull/11610 ### Motivation If a Pulsar Function/Source/Sink is of type ByteBuffer, an cast exception will occur: ``` 6:44:00.226 INFO [external-repl-prop/io/PulsarSink-test-0]

[GitHub] [pulsar] bharanic-dev commented on issue #11521: NPE in managed ledger on read failed

2021-08-09 Thread GitBox
bharanic-dev commented on issue #11521: URL: https://github.com/apache/pulsar/issues/11521#issuecomment-895616878 @lhotari thank you for pointing to #11387 . I looked through the changes and it appears that changes in #11387 try to serialize accesses to entries. I am not sure if that will

[pulsar] branch master updated (6a25286 -> 8bc87a1)

2021-08-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6a25286 Fix null MessageId may be passed to its compareTo() method (#11607) add 8bc87a1 [Issue-11449] [docs]

[GitHub] [pulsar] merlimat closed issue #11449: Python client documentation is incorrect

2021-08-09 Thread GitBox
merlimat closed issue #11449: URL: https://github.com/apache/pulsar/issues/11449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat merged pull request #11589: [Issue-11449] [docs] Updated Python installation steps for Mac

2021-08-09 Thread GitBox
merlimat merged pull request #11589: URL: https://github.com/apache/pulsar/pull/11589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie commented on pull request #11468: [Function worker] Load ServiceConfiguration from file, not from Worke…

2021-08-09 Thread GitBox
sijie commented on pull request #11468: URL: https://github.com/apache/pulsar/pull/11468#issuecomment-895570433 First of all, this ticket should be marked as `doc-required` as it introduces a different behavior to load customized settings. Secondly, the worker is designed to load

[GitHub] [pulsar-client-go] cckellogg closed issue #580: Datarace in partitionConsumer

2021-08-09 Thread GitBox
cckellogg closed issue #580: URL: https://github.com/apache/pulsar-client-go/issues/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] cckellogg commented on issue #583: Reader can not read next coming messages when start with LatestMessageID

2021-08-09 Thread GitBox
cckellogg commented on issue #583: URL: https://github.com/apache/pulsar-client-go/issues/583#issuecomment-895568802 How are you publishing messages? Do you have retention configured for the topic or a subscription associated with it? The default behavior is to discard messages on a

[GitHub] [pulsar] michaeljmarshall opened a new pull request #11609: [Java Client] Switch from pretty print to compact print for configs

2021-08-09 Thread GitBox
michaeljmarshall opened a new pull request #11609: URL: https://github.com/apache/pulsar/pull/11609 ### Motivation When running the `ProducerStatsRecorderImpl` and `ConsumerStatsRecorderImpl`, there are several log lines that print configuration in pretty print formatting. This

[GitHub] [pulsar] HugoPelletier commented on a change in pull request #11595: [Python Schema] Fix redefined `Record` or `Enum` in Python schema

2021-08-09 Thread GitBox
HugoPelletier commented on a change in pull request #11595: URL: https://github.com/apache/pulsar/pull/11595#discussion_r685474487 ## File path: pulsar-client-cpp/python/pulsar/schema/definition.py ## @@ -393,6 +413,9 @@ def python_type(self): return list def

[pulsar] branch master updated: Fix null MessageId may be passed to its compareTo() method (#11607)

2021-08-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6a25286 Fix null MessageId may be passed to

[GitHub] [pulsar] merlimat merged pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
merlimat merged pull request #11607: URL: https://github.com/apache/pulsar/pull/11607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat closed issue #11604: Got exception java.lang.UnsupportedOperationException: MessageId is null。Using Reader

2021-08-09 Thread GitBox
merlimat closed issue #11604: URL: https://github.com/apache/pulsar/issues/11604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

2021-08-09 Thread GitBox
lhotari commented on pull request #11601: URL: https://github.com/apache/pulsar/pull/11601#issuecomment-895486708 the changes don't remove the flakiness. The problem occured in the most recent build: ``` Error: Tests run: 24, Failures: 6, Errors: 0, Skipped: 18, Time elapsed:

[GitHub] [pulsar] kuskmen opened a new issue #11608: Geo Replication Topic Policy

2021-08-09 Thread GitBox
kuskmen opened a new issue #11608: URL: https://github.com/apache/pulsar/issues/11608 **Is your feature request related to a problem? Please describe.** This feature request is not related to any problem, at least not that I am familiar with. **Describe the solution you'd like**

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #560: Encryption support producer

2021-08-09 Thread GitBox
cckellogg commented on a change in pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#discussion_r685401565 ## File path: pulsar/internal/crypto/producer_encryptor.go ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #582: add epoch to handle create producer timeout

2021-08-09 Thread GitBox
cckellogg commented on a change in pull request #582: URL: https://github.com/apache/pulsar-client-go/pull/582#discussion_r685396014 ## File path: pulsar/producer_partition.go ## @@ -298,7 +305,9 @@ func (p *partitionProducer) reconnectToBroker() { d :=

[GitHub] [pulsar] lhotari commented on pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

2021-08-09 Thread GitBox
lhotari commented on pull request #11601: URL: https://github.com/apache/pulsar/pull/11601#issuecomment-895408890 @bharanic-dev Thanks for the providing the details of the work that has been going on behind the scenes to fix the root cause. -- This is an automated message from the

[GitHub] [pulsar] bharanic-dev commented on pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

2021-08-09 Thread GitBox
bharanic-dev commented on pull request #11601: URL: https://github.com/apache/pulsar/pull/11601#issuecomment-895404010 @lhotari thank you for making the changes. The changes look good to me in general and I think they are in the right direction. But I am not sure it explains the failure

[GitHub] [pulsar] michaeljmarshall commented on pull request #11468: [Function worker] Load ServiceConfiguration from file, not from Worke…

2021-08-09 Thread GitBox
michaeljmarshall commented on pull request #11468: URL: https://github.com/apache/pulsar/pull/11468#issuecomment-895400420 @jerrypeng @srkukarni @freeznet @nlu90 - PTAL. This change lets users configure function workers with custom configs that are not members of the `WorkerConfig` class.

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11500: Add metrics for writing or reading size of cursor

2021-08-09 Thread GitBox
michaeljmarshall commented on a change in pull request #11500: URL: https://github.com/apache/pulsar/pull/11500#discussion_r685373234 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java ## @@ -70,4 +70,33 @@ */ long

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-09 Thread GitBox
michaeljmarshall commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r685363477 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,78 @@ +/** + * Licensed to the

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-09 Thread GitBox
michaeljmarshall commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r685346289 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1809,9 +1811,25 @@ public

[pulsar] branch master updated (a6e66dd -> fcd3336)

2021-08-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a6e66dd [Transaction] Fix transaction buffer client handle endTxn op when topic or sub have been deleted. (#11304)

[GitHub] [pulsar] merlimat merged pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage

2021-08-09 Thread GitBox
merlimat merged pull request #11599: URL: https://github.com/apache/pulsar/pull/11599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (1e9f0cd -> a6e66dd)

2021-08-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1e9f0cd [docs] [issue 8640] Update helm chart link (#11587) add a6e66dd [Transaction] Fix transaction buffer

[GitHub] [pulsar] codelipenghui merged pull request #11304: [Transaction] Fix transaction buffer client handle endTxn op when topic or sub have been deleted.

2021-08-09 Thread GitBox
codelipenghui merged pull request #11304: URL: https://github.com/apache/pulsar/pull/11304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nishantvas commented on issue #6220: Python Client for Windows

2021-08-09 Thread GitBox
nishantvas commented on issue #6220: URL: https://github.com/apache/pulsar/issues/6220#issuecomment-895303090 Similarly, I've noticed that installing pulsar-client on WSL also doesn't work -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] leizhiyuan commented on pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
leizhiyuan commented on pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#issuecomment-895224778 ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] leizhiyuan commented on a change in pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
leizhiyuan commented on a change in pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#discussion_r685191270 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java ## @@ -115,10 +115,11 @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11553: Exposing the broker entry metadata to client

2021-08-09 Thread GitBox
codelipenghui commented on a change in pull request #11553: URL: https://github.com/apache/pulsar/pull/11553#discussion_r685177525 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -186,6 +186,7 @@ private boolean

[GitHub] [pulsar] BewareMyPower commented on pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
BewareMyPower commented on pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#issuecomment-895206201 @leizhiyuan > if you changed lastCumulativeAck.messageId to null, messageIdOfLastAck also will be null. I think not. They both reference to the same

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
BewareMyPower commented on a change in pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#discussion_r685168151 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java ## @@ -115,10 +115,11 @@

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
gaozhangmin commented on a change in pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#discussion_r685166407 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java ## @@ -115,10 +115,11 @@

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
BewareMyPower commented on a change in pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#discussion_r685165830 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java ## @@ -115,10 +115,11 @@

[GitHub] [pulsar] leizhiyuan commented on a change in pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
leizhiyuan commented on a change in pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#discussion_r685164858 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java ## @@ -115,10 +115,11 @@

[GitHub] [pulsar] BewareMyPower commented on pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
BewareMyPower commented on pull request #11607: URL: https://github.com/apache/pulsar/pull/11607#issuecomment-895193377 @leizhiyuan Please also take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] BewareMyPower opened a new pull request #11607: Fix null MessageId may be passed to its compareTo() method

2021-08-09 Thread GitBox
BewareMyPower opened a new pull request #11607: URL: https://github.com/apache/pulsar/pull/11607 Fixes #11604 ### Motivation There's a chance that null `MessageId` might be passed to its `compareTo()` method. Even if #10586 added the null check, it's still not thread safe

[GitHub] [pulsar] wuzhanpeng opened a new pull request #11606: Fix race condition in concurrent schema deletion

2021-08-09 Thread GitBox
wuzhanpeng opened a new pull request #11606: URL: https://github.com/apache/pulsar/pull/11606 This PR may fixed #11605 ### Motivation Concurrently deleting topics with the same schema may cause race condition in broker side. If we do not handle these scenarios correctly we

[GitHub] [pulsar] wuzhanpeng opened a new issue #11605: Race condition in concurrent schema deletion

2021-08-09 Thread GitBox
wuzhanpeng opened a new issue #11605: URL: https://github.com/apache/pulsar/issues/11605 **Describe the bug** In some scenarios, we deleted topics concurrently, which may trigger some race condition in deleting the same topic schema. For example, in

[GitHub] [pulsar] leizhiyuan edited a comment on issue #11604: Got exception java.lang.UnsupportedOperationException: MessageId is null。Using Reader

2021-08-09 Thread GitBox
leizhiyuan edited a comment on issue #11604: URL: https://github.com/apache/pulsar/issues/11604#issuecomment-895182485 ![image](https://user-images.githubusercontent.com/2684384/128705973-f4ef264f-ff43-4b46-a2b4-672d3f1b2147.png) maybe there is a concurrent bug。 ```

[GitHub] [pulsar] leizhiyuan commented on issue #11604: Got exception java.lang.UnsupportedOperationException: MessageId is null。Using Reader

2021-08-09 Thread GitBox
leizhiyuan commented on issue #11604: URL: https://github.com/apache/pulsar/issues/11604#issuecomment-895182485 ![image](https://user-images.githubusercontent.com/2684384/128705973-f4ef264f-ff43-4b46-a2b4-672d3f1b2147.png) maybe there is a concurrent bug。 ``` if

[GitHub] [pulsar] gaozhangmin commented on issue #11604: Got exception java.lang.UnsupportedOperationException: MessageId is null。Using Reader

2021-08-09 Thread GitBox
gaozhangmin commented on issue #11604: URL: https://github.com/apache/pulsar/issues/11604#issuecomment-895180330 > which version do you use? 2.8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Vanlightly edited a comment on pull request #11570: [Issue 11496][C++] Allow partitioned producers to start lazily

2021-08-09 Thread GitBox
Vanlightly edited a comment on pull request #11570: URL: https://github.com/apache/pulsar/pull/11570#issuecomment-895179545 I realised that I had not included the extra config in the `__init__.py` so will add that to this PR. @Anonymitaet Beyond the doxygen and pdoc generated docs,

[GitHub] [pulsar] Vanlightly commented on pull request #11570: [Issue 11496][C++] Allow partitioned producers to start lazily

2021-08-09 Thread GitBox
Vanlightly commented on pull request #11570: URL: https://github.com/apache/pulsar/pull/11570#issuecomment-895179545 I realised that I had not included the extra config in the __init__.py so will add that to this PR. @Anonymitaet Beyond the doxygen and pdoc generated docs, is it

  1   2   >