[GitHub] [pulsar] codelipenghui commented on pull request #11655: Check null or empty instead of catch NPE

codelipenghui commented on pull request #11655: URL: https://github.com/apache/pulsar/pull/11655#issuecomment-899007228 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] lhotari commented on issue #11637: [Broker] Failed to process metadata store notification

lhotari commented on issue #11637: URL: https://github.com/apache/pulsar/issues/11637#issuecomment-899016978 This problem seems to be fixed by #11656 . @Technoboy- can you confirm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

codelipenghui commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689089771 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBean.java ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache So

[GitHub] [pulsar] codelipenghui merged pull request #11641: Update client-libraries-websocket.md

codelipenghui merged pull request #11641: URL: https://github.com/apache/pulsar/pull/11641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui merged pull request #11642: Update client-libraries-websocket.md

codelipenghui merged pull request #11642: URL: https://github.com/apache/pulsar/pull/11642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (50e6b3e -> c600197)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 50e6b3e [Flaky test] Fix ManagedLedgerTest.testLedgerReachMaximumRolloverTime (#11670) (#11670) add c600197

[pulsar] branch master updated (c600197 -> 452bed8)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c600197 Update client-libraries-websocket.md (#11641) add 452bed8 Update client-libraries-websocket.md (#1164

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689102490 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBean.java ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689111490 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache S

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689111684 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache S

[GitHub] [pulsar] vsly-ru edited a comment on issue #6995: Decouple original topic and compacted topic retention policies

vsly-ru edited a comment on issue #6995: URL: https://github.com/apache/pulsar/issues/6995#issuecomment-894788124 @lukestephenson Did you find a way of achieving this? I'm facing the same problem, but seems like Pulsar still can't be configured such a way, that a compacted topic becomes

[GitHub] [pulsar] vsly-ru commented on issue #6995: Decouple original topic and compacted topic retention policies

vsly-ru commented on issue #6995: URL: https://github.com/apache/pulsar/issues/6995#issuecomment-899094102 @lukestephenson luckily we have only one producer per compacted topic at a time. In case of multiple producers you indeed need some kind of lock or service time to perform the migr

[GitHub] [pulsar] Anonymitaet commented on pull request #11540: Update concepts-transactions.md

Anonymitaet commented on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-899140539 @wongxingjun any feedback on this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11671: [server] Allow broker to start with default backlogquota in bytes

Anonymitaet commented on a change in pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#discussion_r689174175 ## File path: site2/docs/reference-configuration.md ## @@ -175,7 +175,7 @@ Pulsar brokers are responsible for handling incoming messages from produc

[GitHub] [pulsar] Anonymitaet commented on pull request #11671: [server] Allow broker to start with default backlogquota in bytes

Anonymitaet commented on pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#issuecomment-899143053 @rdhabalia Thanks for your contribution. If your PR contains doc updates, please label it with `doc`, thanks. -- This is an automated message from the Apache Git Serv

[GitHub] [pulsar] Anonymitaet commented on pull request #11666: [pulsar-admin] allow create functions with package URL

Anonymitaet commented on pull request #11666: URL: https://github.com/apache/pulsar/pull/11666#issuecomment-899143799 @freeznet thanks for your contribution! When can we start updating docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #11667: [docs] [ISSUE 11625] Update the intro of Messaging doc

Huanli-Meng commented on a change in pull request #11667: URL: https://github.com/apache/pulsar/pull/11667#discussion_r689174704 ## File path: site2/docs/concepts-messaging.md ## @@ -65,11 +67,11 @@ You can have different types of access modes on topics for producers. > **N

[GitHub] [pulsar] freeznet commented on pull request #11666: [pulsar-admin] allow create functions with package URL

freeznet commented on pull request #11666: URL: https://github.com/apache/pulsar/pull/11666#issuecomment-899147681 @Anonymitaet thanks, we can start the doc once this PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pulsar] hangc0276 closed issue #11662: Flaky-test: PersistentTopicsTest.testSetReplicatedSubscriptionStatus on branch-2.8

hangc0276 closed issue #11662: URL: https://github.com/apache/pulsar/issues/11662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pulsar] hangc0276 commented on issue #11662: Flaky-test: PersistentTopicsTest.testSetReplicatedSubscriptionStatus on branch-2.8

hangc0276 commented on issue #11662: URL: https://github.com/apache/pulsar/issues/11662#issuecomment-899151105 Addressed by #11661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar] wongxingjun opened a new pull request #11673: Update concepts-transactions.md

wongxingjun opened a new pull request #11673: URL: https://github.com/apache/pulsar/pull/11673 fix 2 typos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar] wongxingjun opened a new pull request #11674: Update concepts-transactions.md

wongxingjun opened a new pull request #11674: URL: https://github.com/apache/pulsar/pull/11674 fix 2 typos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar] wongxingjun commented on pull request #11540: Update concepts-transactions.md

wongxingjun commented on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-899163922 > @wongxingjun any feedback on this? Thanks Same problem exists in both branch 2.7 and 2.8 and I fixed it in 2 new pull requests. -- This is an automated message f

[GitHub] [pulsar] merlimat merged pull request #11672: If a topic has compaction policies configured, we must ensure the subscription is always pre-created

merlimat merged pull request #11672: URL: https://github.com/apache/pulsar/pull/11672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] codelipenghui merged pull request #11655: Check null or empty instead of catch NPE

codelipenghui merged pull request #11655: URL: https://github.com/apache/pulsar/pull/11655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated: If a topic has compaction policies configured, we must ensure the subscription is always pre-created (#11672)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 25b9785 If a topic has compaction policies conf

[GitHub] [pulsar] wongxingjun edited a comment on pull request #11540: Update concepts-transactions.md

wongxingjun edited a comment on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-899163922 > @wongxingjun any feedback on this? Thanks Same problem exists in both branch 2.7 and 2.8 and I fixed it in 2 new pull requests #11673 and #11674. -- This

[GitHub] [pulsar] codelipenghui merged pull request #11650: [Broker Interceptor] Fix Pulsar didn't respond error messages when throw InterceptException

codelipenghui merged pull request #11650: URL: https://github.com/apache/pulsar/pull/11650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui closed issue #11649: [Broker Interceptor] Pulsar didn't respond error messages when throw InterceptException

codelipenghui closed issue #11649: URL: https://github.com/apache/pulsar/issues/11649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated (25b9785 -> e505018)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 25b9785 If a topic has compaction policies configured, we must ensure the subscription is always pre-created (#116

[GitHub] [pulsar] codelipenghui merged pull request #11570: [Issue 11496][C++] Allow partitioned producers to start lazily

codelipenghui merged pull request #11570: URL: https://github.com/apache/pulsar/pull/11570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui closed issue #11496: Reduce producer lookups and connections in partitioned producers

codelipenghui closed issue #11496: URL: https://github.com/apache/pulsar/issues/11496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated (e505018 -> 4793ff7)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e505018 Check null or empty instead of catch NPE (#11655) (#11655) add 4793ff7 [Broker Interceptor] Fix Pulsa

[pulsar] branch master updated (4793ff7 -> 9577b84)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4793ff7 [Broker Interceptor] Fix Pulsar didn't respond error messages when throw InterceptException (#11650)

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11517: [Issue 11412] Add shutdownGracefully for ManagedLedgerFactoryImpl

codelipenghui commented on a change in pull request #11517: URL: https://github.com/apache/pulsar/pull/11517#discussion_r689199271 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java ## @@ -472,8 +485,107 @@ void close(Ma

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #560: Encryption support producer

GPrabhudas commented on a change in pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#discussion_r689229207 ## File path: pulsar/producer_partition.go ## @@ -781,6 +821,17 @@ func (p *partitionProducer) internalClose(req *closeProducer) { p.ba

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #560: Encryption support producer

GPrabhudas commented on a change in pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#discussion_r689229234 ## File path: pulsar/producer_partition.go ## @@ -126,6 +129,29 @@ func newPartitionProducer(client *client, topic string, options *ProducerOpt

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #560: Encryption support producer

GPrabhudas commented on a change in pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#discussion_r689229889 ## File path: pulsar/internal/crypto/producer_encryptor.go ## @@ -0,0 +1,72 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #560: Encryption support producer

GPrabhudas commented on a change in pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#discussion_r689231734 ## File path: pulsar/internal/commands.go ## @@ -221,9 +222,21 @@ func serializeBatch(wb Buffer, cmdSend *pb.BaseCommand, msgMet

[GitHub] [pulsar] hepyu commented on issue #9491: failed to delete topic with HTTP 500 Internal Server Error

hepyu commented on issue #9491: URL: https://github.com/apache/pulsar/issues/9491#issuecomment-899240488 > Did this make it into 2.8.0? I am experiencing what looks like the same issue on that version. same question on same version：2.7.0。 -- This is an automated message from the A

[GitHub] [pulsar] eolivelli commented on a change in pull request #11666: [pulsar-admin] allow create functions with package URL

eolivelli commented on a change in pull request #11666: URL: https://github.com/apache/pulsar/pull/11666#discussion_r689277408 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/functions/Utils.java ## @@ -34,7 +36,9 @@ public static boolean isFunctionPa

[GitHub] [pulsar] wolfstudy opened a new pull request #11675: Replace bookkeper with bookkeeper in bin/bookkeeper

wolfstudy opened a new pull request #11675: URL: https://github.com/apache/pulsar/pull/11675 Signed-off-by: xiaolongran ### Motivation  ### Mo

[GitHub] [pulsar] Anonymitaet commented on pull request #11540: Update concepts-transactions.md

Anonymitaet commented on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-899267940 @wongxingjun all your PRs submit same doc changes for the same doc version, please update versioned docs here (https://github.com/apache/pulsar/tree/master/site2/website/ve

[GitHub] [pulsar] eolivelli commented on pull request #10918: [Build] Fix java-test-functions dependencies and packaging

eolivelli commented on pull request #10918: URL: https://github.com/apache/pulsar/pull/10918#issuecomment-899268506 @lhotari you want to try to rebase this patch to latest master ? we committed the changes to DefaultImplementation about loading Pulsar Client Impl (mostly) without reflect

[GitHub] [pulsar] lhotari commented on pull request #10918: [Build] Fix java-test-functions dependencies and packaging

lhotari commented on pull request #10918: URL: https://github.com/apache/pulsar/pull/10918#issuecomment-899269946 @eolivelli I rebased this PR. Let's see what the test results are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git