[GitHub] [pulsar] BewareMyPower commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
BewareMyPower commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914972162 BTW, here is my demo implementation in https://github.com/BewareMyPower/pulsar/tree/bewaremypower/payload-converter (will be deleted after pushing the final implementation). T

[GitHub] [pulsar] BewareMyPower edited a comment on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
BewareMyPower edited a comment on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914970028 @wangjialing218 The conversion is unavoidable. We have to sacrifice either producer or consumer side. But before this proposal, if we're going to support both Kafka and

[GitHub] [pulsar] nicoloboschi commented on a change in pull request #11947: fix-npe-ZkBookieRackAffinityMapping

2021-09-07 Thread GitBox
nicoloboschi commented on a change in pull request #11947: URL: https://github.com/apache/pulsar/pull/11947#discussion_r704105273 ## File path: pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkBookieRackAffinityMapping.java ## @@ -123,18 +126,20 @@ private vo

[GitHub] [pulsar] BewareMyPower commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
BewareMyPower commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914970028 @wangjialing218 The conversion is unavoidable. We have to sacrifice either producer or consumer side. But before this proposal, if we're going to support both Kafka and Pulsar

[pulsar] branch branch-2.8 updated: Bump version to 2.8.2-SNAPSHOT (#11949)

2021-09-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new ffbb658 Bump version to 2.8.2-SNAPSHOT

[GitHub] [pulsar] lhotari merged pull request #11949: [Branch-2.8]Bump version to 2.8.2-SNAPSHOT

2021-09-07 Thread GitBox
lhotari merged pull request #11949: URL: https://github.com/apache/pulsar/pull/11949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] wangjialing218 commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
wangjialing218 commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914962880 If I use kafka client to produce messages and pulsar client to consume messages, the performace of message publish could be improve but performace of message dispatch may be

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
GPrabhudas commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r704085300 ## File path: pulsar/consumer_partition.go ## @@ -479,7 +505,49 @@ func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, he

[GitHub] [pulsar] BewareMyPower commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
BewareMyPower commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914950524 > I would add some "init(ServerConfiguration configuration)" method and a close() method, in order to let it be configurable and to let it release resources. Thanks for

[pulsar] branch master updated (2858ed0 -> 06b84e5)

2021-09-07 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2858ed0 [C++] Handle error when shutting down client after forks (#11954) add 06b84e5 Add issue template f

[GitHub] [pulsar] eolivelli commented on pull request #11961: Add issue template for PIP

2021-09-07 Thread GitBox
eolivelli commented on pull request #11961: URL: https://github.com/apache/pulsar/pull/11961#issuecomment-914949591 @BewareMyPower thank you. merged. We can iterate and enhance the template. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] eolivelli merged pull request #11961: Add issue template for PIP

2021-09-07 Thread GitBox
eolivelli merged pull request #11961: URL: https://github.com/apache/pulsar/pull/11961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] BewareMyPower commented on pull request #11961: Add issue template for PIP

2021-09-07 Thread GitBox
BewareMyPower commented on pull request #11961: URL: https://github.com/apache/pulsar/pull/11961#issuecomment-914948074 @eolivelli I just copied the template from the original email. ([PROPOSAL] Defining a clearer process for PIP proposals) -- This is an automated message from the Apache

[GitHub] [pulsar] BewareMyPower commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
BewareMyPower commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914947340 Protocol handler can be used for the publish side. For example in KoP, if messages were produced from Pulsar producer, when KoP read entries from BK, it converts the messa

[GitHub] [pulsar] eolivelli commented on pull request #11948: Make Dispatcher pluggable

2021-09-07 Thread GitBox
eolivelli commented on pull request #11948: URL: https://github.com/apache/pulsar/pull/11948#issuecomment-914946506 I am commenting on the ML -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] eolivelli commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
eolivelli commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914944145 I would add some "init(ServerConfiguration configuration)" method and a close() method, in order to let it be configurable and to let it release resources. -- This is an automa

[GitHub] [pulsar] eolivelli commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
eolivelli commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914943889 we should define some constraints on what the Converter can do with the input ByteBuf. Should it keep the reader/writer indexes ? what about refcount ? can the Converter modify

[GitHub] [pulsar] eolivelli commented on issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
eolivelli commented on issue #11962: URL: https://github.com/apache/pulsar/issues/11962#issuecomment-914943326 do we need do add a Converter on the Publish side ? IIUC this Converter is for the Consumer -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
GPrabhudas commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r704071172 ## File path: pulsar/internal/crypto/decryptor.go ## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar] 315157973 commented on pull request #11948: Make Dispatcher pluggable

2021-09-07 Thread GitBox
315157973 commented on pull request #11948: URL: https://github.com/apache/pulsar/pull/11948#issuecomment-914940390 Hello, @eolivelli. I opened a Proposal in dev. I'd like to hear your opinion. If you agree, can you reply +1 for me? Thank you very much. -- This is an automated mess

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
GPrabhudas commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r704068602 ## File path: pulsar/consumer_partition.go ## @@ -479,7 +505,49 @@ func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, he

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
GPrabhudas commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r704064820 ## File path: pulsar/consumer_partition.go ## @@ -479,7 +505,49 @@ func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, he

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
GPrabhudas commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r704064533 ## File path: pulsar/consumer_partition.go ## @@ -479,7 +505,49 @@ func (pc *partitionConsumer) MessageReceived(response *pb.CommandMessage, he

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
GPrabhudas commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r704064204 ## File path: pulsar/impl_message.go ## @@ -215,6 +233,7 @@ type message struct { replicatedFrom string redeliveryCount

[GitHub] [pulsar] BewareMyPower opened a new issue #11962: PIP 94: Message converter at broker level

2021-09-07 Thread GitBox
BewareMyPower opened a new issue #11962: URL: https://github.com/apache/pulsar/issues/11962 ## Motivation The initial motivation was from Kafka's protocol handler, i.e. KoP (https://github.com/streamnative/kop). KoP allows Kafka producer to configure entry format to `kafka`, which m

[GitHub] [pulsar] BewareMyPower opened a new pull request #11961: Add issue template for PIP

2021-09-07 Thread GitBox
BewareMyPower opened a new pull request #11961: URL: https://github.com/apache/pulsar/pull/11961 ### Motivation See discussion in http://mail-archives.apache.org/mod_mbox/pulsar-dev/202109.mbox/%3C66DB34FA-AA47-455B-BEBD-C5A1864F94C2%40streamnative.io%3E. (I didn't find the original

[GitHub] [pulsar] BewareMyPower commented on pull request #11960: [PIP-63] Readonly-Topic-Ownership-Support

2021-09-07 Thread GitBox
BewareMyPower commented on pull request #11960: URL: https://github.com/apache/pulsar/pull/11960#issuecomment-914908483 You can apply following diff to fix C++ client build failure. ```diff diff --git a/pulsar-client-cpp/lib/Commands.cc b/pulsar-client-cpp/lib/Commands.cc index

[GitHub] [pulsar] codelipenghui commented on pull request #11948: Make Dispatcher pluggable

2021-09-07 Thread GitBox
codelipenghui commented on pull request #11948: URL: https://github.com/apache/pulsar/pull/11948#issuecomment-914892921 Thanks @315157973 for bringing up it, we have a conversation before in the email list but the previous proposal is for broker side message filters, does not have any conc

[GitHub] [pulsar] Jason918 opened a new pull request #11960: [PIP-63] Readonly-Topic-Ownership-Support

2021-09-07 Thread GitBox
Jason918 opened a new pull request #11960: URL: https://github.com/apache/pulsar/pull/11960 Implementation of [PIP-63](https://github.com/apache/pulsar/wiki/PIP-63%3A-Readonly-Topic-Ownership-Support) ### Motivation See [PIP-63](https://github.com/apache/pulsa

[GitHub] [pulsar] urfreespace commented on pull request #11959: [website][upgrade]feat: docs migration - pulsar io

2021-09-07 Thread GitBox
urfreespace commented on pull request #11959: URL: https://github.com/apache/pulsar/pull/11959#issuecomment-914874859 @tuteng @Anonymitaet PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] urfreespace opened a new pull request #11959: [website][upgrade]feat: docs migration - pulsar io

2021-09-07 Thread GitBox
urfreespace opened a new pull request #11959: URL: https://github.com/apache/pulsar/pull/11959 Master Issue: https://github.com/apache/pulsar/issues/11766 ### Motivation website upgrade ### Modifications [Click to Preview](https://deploy-preview-18--p

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup

2021-09-07 Thread GitBox
ravi-vaidyanathan commented on pull request #11957: URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914861962 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup

2021-09-07 Thread GitBox
ravi-vaidyanathan commented on pull request #11957: URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914820313 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] gaozhangmin commented on pull request #11893: Admin cli support terminate a partitioned topic

2021-09-07 Thread GitBox
gaozhangmin commented on pull request #11893: URL: https://github.com/apache/pulsar/pull/11893#issuecomment-914815150 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pulsar] branch master updated: [C++] Handle error when shutting down client after forks (#11954)

2021-09-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2858ed0 [C++] Handle error when shutting down c

[GitHub] [pulsar] merlimat closed issue #11953: C++ client (via Python bindings) `abort`s and hangs in child processes and is generally not `fork`-safe

2021-09-07 Thread GitBox
merlimat closed issue #11953: URL: https://github.com/apache/pulsar/issues/11953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] merlimat merged pull request #11954: [C++] Handle error when shutting down client after forks

2021-09-07 Thread GitBox
merlimat merged pull request #11954: URL: https://github.com/apache/pulsar/pull/11954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated (e4a9f66 -> c11ac89)

2021-09-07 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e4a9f66 [C++] Fixed attempting to connect to multiple IP addresses (#11958) add c11ac89 [Python] Expose Client.s

[GitHub] [pulsar] BewareMyPower merged pull request #11955: [Python] Expose Client.shutdown() method

2021-09-07 Thread GitBox
BewareMyPower merged pull request #11955: URL: https://github.com/apache/pulsar/pull/11955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] BewareMyPower commented on pull request #11955: [Python] Expose Client.shutdown() method

2021-09-07 Thread GitBox
BewareMyPower commented on pull request #11955: URL: https://github.com/apache/pulsar/pull/11955#issuecomment-914787605 @Anonymitaet The docs have been added inside the code (`shutdown`), the associated docs will be generated like https://pulsar.apache.org/api/python/2.8.0-SNAPSHOT/#pulsar

[GitHub] [pulsar] BewareMyPower commented on pull request #11956: [Python] Fixed CMake check to find Python headers and libs

2021-09-07 Thread GitBox
BewareMyPower commented on pull request #11956: URL: https://github.com/apache/pulsar/pull/11956#issuecomment-914771845 `FindPython` was firstly introduced from 3.12, see https://cmake.org/cmake/help/latest/module/FindPython.html#module:FindPython. But the minimum version of CMake is only

[pulsar] branch master updated (cfdfd4e -> e4a9f66)

2021-09-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cfdfd4e [website][upgrade]feat: pulsar functions docs migratin for version next/2.8.0/2.7.3 (#11938) add e4a9f

[GitHub] [pulsar] merlimat closed issue #11950: On master, connection attempts from the C++/Python client on "localhost" do not fall back from IPv6 to IPv4

2021-09-07 Thread GitBox
merlimat closed issue #11950: URL: https://github.com/apache/pulsar/issues/11950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] merlimat merged pull request #11958: [C++] Fixed attempting to connect to multiple IP addresses

2021-09-07 Thread GitBox
merlimat merged pull request #11958: URL: https://github.com/apache/pulsar/pull/11958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch branch-2.7 updated: [Branch-2.7][Build] Fix docker image install python3.7-dev problem (#11943)

2021-09-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 9064963 [Branch-2.7][Build] Fix docker

[GitHub] [pulsar] codelipenghui merged pull request #11943: [Branch-2.7][Build] Fix docker image install python3.7-dev problem

2021-09-07 Thread GitBox
codelipenghui merged pull request #11943: URL: https://github.com/apache/pulsar/pull/11943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup

2021-09-07 Thread GitBox
ravi-vaidyanathan commented on pull request #11957: URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914680790 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] Anonymitaet commented on pull request #11955: [Python] Expose Client.shutdown() method

2021-09-07 Thread GitBox
Anonymitaet commented on pull request #11955: URL: https://github.com/apache/pulsar/pull/11955#issuecomment-914680342 @merlimat do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pulsar] branch master updated (693bf9d -> cfdfd4e)

2021-09-07 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 693bf9d [PIP-82] [pulsar-broker] Misc fixes: (#11918) add cfdfd4e [website][upgrade]feat: pulsar functions docs

[GitHub] [pulsar] Anonymitaet merged pull request #11938: [website][upgrade]feat: pulsar functions docs migratin for version next/2.8.0/2.7.3

2021-09-07 Thread GitBox
Anonymitaet merged pull request #11938: URL: https://github.com/apache/pulsar/pull/11938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup

2021-09-07 Thread GitBox
ravi-vaidyanathan commented on pull request #11957: URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914649916 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] michaeljmarshall commented on pull request #11951: Fixing permissions of docker images scripts

2021-09-07 Thread GitBox
michaeljmarshall commented on pull request #11951: URL: https://github.com/apache/pulsar/pull/11951#issuecomment-914646154 @MMirelli - can you help me understand why this change is necessary? In the 2.8.0 image, permissions look correct, and I am not finding any changes that should have in

[GitHub] [pulsar] EronWright edited a comment on issue #10951: Function worker uses raw webService Port against adverisedListener and advertisedAddress

2021-09-07 Thread GitBox
EronWright edited a comment on issue #10951: URL: https://github.com/apache/pulsar/issues/10951#issuecomment-914630297 I believe that the root cause is that Pulsar is erroneously using the configured `advertisedListeners` to formulate the web service endpoint in some cases. A reasonable f

[GitHub] [pulsar] EronWright commented on issue #10951: Function worker uses raw webService Port against adverisedListener and advertisedAddress

2021-09-07 Thread GitBox
EronWright commented on issue #10951: URL: https://github.com/apache/pulsar/issues/10951#issuecomment-914630297 I believe that the root cause is that Pulsar is erroneously using the configured `advertisedListeners` to formulate the web service endpoint in some cases. A reasonable fix woul

[pulsar] branch master updated (d494c43 -> 693bf9d)

2021-09-07 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d494c43 [Issue 11936] forget to call SendCallback on producer close (#11939) add 693bf9d [PIP-82] [pulsar-

[GitHub] [pulsar] merlimat opened a new pull request #11958: [C++] Fixed attempting to connect to multiple IP addresses

2021-09-07 Thread GitBox
merlimat opened a new pull request #11958: URL: https://github.com/apache/pulsar/pull/11958 ### Motivation Fix #11950 In #11557 there was a fix to advance the DNS resolver result iterator before attempting to reconnect to the subsequent IP results. The problem was that

[GitHub] [pulsar] jerrypeng merged pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:

2021-09-07 Thread GitBox
jerrypeng merged pull request #11918: URL: https://github.com/apache/pulsar/pull/11918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup

2021-09-07 Thread GitBox
ravi-vaidyanathan commented on pull request #11957: URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914618283 @jerrypeng @cckellogg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] ravi-vaidyanathan opened a new pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup

2021-09-07 Thread GitBox
ravi-vaidyanathan opened a new pull request #11957: URL: https://github.com/apache/pulsar/pull/11957 ### Motivation Fix a few small issues found during testing and code inspection. ### Modifications *Added missing check for permissions for certain ResourceGro

[GitHub] [pulsar] Lakshmi-Balu edited a comment on pull request #11763: [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics

2021-09-07 Thread GitBox
Lakshmi-Balu edited a comment on pull request #11763: URL: https://github.com/apache/pulsar/pull/11763#issuecomment-914610082 > The place we need to add documentation about this new flag is here: > > https://github.com/apache/pulsar/blob/master/site2/docs/admin-api-topics.md#lookup-o

[GitHub] [pulsar] Lakshmi-Balu commented on pull request #11763: [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics

2021-09-07 Thread GitBox
Lakshmi-Balu commented on pull request #11763: URL: https://github.com/apache/pulsar/pull/11763#issuecomment-914610082 > The place we need to add documentation about this new flag is here: > > https://github.com/apache/pulsar/blob/master/site2/docs/admin-api-topics.md#lookup-of-topic

[GitHub] [pulsar] Lakshmi-Balu commented on a change in pull request #11763: [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics

2021-09-07 Thread GitBox
Lakshmi-Balu commented on a change in pull request #11763: URL: https://github.com/apache/pulsar/pull/11763#discussion_r703786991 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -345,12 +349,30 @@ void run() throws PulsarAdminEx

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #612: Encryption support ext consumer

2021-09-07 Thread GitBox
cckellogg commented on a change in pull request #612: URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r703778525 ## File path: pulsar/internal/crypto/decryptor.go ## @@ -0,0 +1,28 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar] Lakshmi-Balu commented on pull request #11763: [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics

2021-09-07 Thread GitBox
Lakshmi-Balu commented on pull request #11763: URL: https://github.com/apache/pulsar/pull/11763#issuecomment-914581729 > @Lakshmi-Balu can you write a more comprehensive test for this? That include mock returns for a topic lookup and making sure the returned/printed output is correct. >

[GitHub] [pulsar] Lakshmi-Balu commented on a change in pull request #11763: [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics

2021-09-07 Thread GitBox
Lakshmi-Balu commented on a change in pull request #11763: URL: https://github.com/apache/pulsar/pull/11763#discussion_r703786991 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -345,12 +349,30 @@ void run() throws PulsarAdminEx

[GitHub] [pulsar] kaushik-develop commented on pull request #11918: [PIP-82] [pulsar-broker] Misc fixes:

2021-09-07 Thread GitBox
kaushik-develop commented on pull request #11918: URL: https://github.com/apache/pulsar/pull/11918#issuecomment-914578488 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] lordcheng10 commented on issue #11866: Attempting to delete a namespace immediately after deleting all topics in that namespace raises `org.apache.zookeeper.KeeperException$NotEmptyE

2021-09-07 Thread GitBox
lordcheng10 commented on issue #11866: URL: https://github.com/apache/pulsar/issues/11866#issuecomment-914577800 Can I take this up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] zbentley commented on issue #11953: C++ client (via Python bindings) `abort`s and hangs in child processes and is generally not `fork`-safe

2021-09-07 Thread GitBox
zbentley commented on issue #11953: URL: https://github.com/apache/pulsar/issues/11953#issuecomment-914572210 As a workaround, an `atfork` handler can be registered that intentionally swallows the error that occurs on shutdown. An example demonstrating this is here (the weakref parts

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11931: [pulsar-client]Add a optional params scope for pulsar oauth2 client

2021-09-07 Thread GitBox
michaeljmarshall commented on a change in pull request #11931: URL: https://github.com/apache/pulsar/pull/11931#discussion_r703759687 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/oauth2/protocol/TokenClient.java ## @@ -44,7 +45,7 @@ protect

[GitHub] [pulsar] merlimat opened a new pull request #11956: [Python] Fixed CMake check to find Python headers and libs

2021-09-07 Thread GitBox
merlimat opened a new pull request #11956: URL: https://github.com/apache/pulsar/pull/11956 ### Motivation The recommended way to find Python headers and libs for CMake is: ``` find_package(Python REQUIRED Development) ``` This will ensure we're finding the correct ver

[GitHub] [pulsar] merlimat opened a new pull request #11955: [Python] Expose Client.shutdown() method

2021-09-07 Thread GitBox
merlimat opened a new pull request #11955: URL: https://github.com/apache/pulsar/pull/11955 ### Motivation Similar to what we expose in Java and C++ client, we should expose the quick `shutdown()` method on the Python client. -- This is an automated message from the Apache Git Ser

[GitHub] [pulsar] merlimat opened a new pull request #11954: [C++] Handle error when shutting down client after forks

2021-09-07 Thread GitBox
merlimat opened a new pull request #11954: URL: https://github.com/apache/pulsar/pull/11954 ### Motivation After a `fork()` call, the threads are not getting ported to the child process (at least not most of them). When we're shutting down the pulsar client, we should handle the exc

[GitHub] [pulsar] zbentley opened a new issue #11953: C++ client (via Python bindings) `abort`s and hangs in child processes and is generally not `fork`-safe

2021-09-07 Thread GitBox
zbentley opened a new issue #11953: URL: https://github.com/apache/pulsar/issues/11953 **Describe the bug** If I `fork()` with a connected Pulsar C++ client instance, the child process ends up having a few issues: - On garbage collection of the client instance in the child process, `a

[GitHub] [pulsar] zwalsh-toast commented on issue #11846: [Java client] Allow consumer to be created in a paused state

2021-09-07 Thread GitBox
zwalsh-toast commented on issue #11846: URL: https://github.com/apache/pulsar/issues/11846#issuecomment-914474050 > @zwalsh-toast Are you interested in contributing the feature in Pulsar? Sounds good if we have an option to control the message flow when creating a consumer. Hi @code

[GitHub] [pulsar] lhotari commented on pull request #11937: Avoid to infinitely split bundle

2021-09-07 Thread GitBox
lhotari commented on pull request #11937: URL: https://github.com/apache/pulsar/pull/11937#issuecomment-914438457 Good catch @Shoothzj ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[pulsar] branch master updated: [Issue 11936] forget to call SendCallback on producer close (#11939)

2021-09-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d494c43 [Issue 11936] forget to call SendCallba

[GitHub] [pulsar] merlimat closed issue #11936: Forget to call Sendcallback on a branch of closeAsync

2021-09-07 Thread GitBox
merlimat closed issue #11936: URL: https://github.com/apache/pulsar/issues/11936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] merlimat merged pull request #11939: [Issue 11936] forget to call SendCallback on producer close

2021-09-07 Thread GitBox
merlimat merged pull request #11939: URL: https://github.com/apache/pulsar/pull/11939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated: Update committers in the team page (#11946)

2021-09-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e0700ab Update committers in the team page (#11

[GitHub] [pulsar] merlimat merged pull request #11946: Add new committers to the team page

2021-09-07 Thread GitBox
merlimat merged pull request #11946: URL: https://github.com/apache/pulsar/pull/11946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] bharanic-dev commented on pull request #11916: [PIP-82] [pulsar-broker] Miscellaneous bug fixes in resource group rate limiter.

2021-09-07 Thread GitBox
bharanic-dev commented on pull request #11916: URL: https://github.com/apache/pulsar/pull/11916#issuecomment-914414563 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] merlimat opened a new pull request #11952: Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace

2021-09-07 Thread GitBox
merlimat opened a new pull request #11952: URL: https://github.com/apache/pulsar/pull/11952 ### Motivation `ReplicatorTest.testRemoveClusterFromNamespace()` is flaky because it's trying to do: 1. Use `r4` as an alias cluster for `r3` 2. Create a topic with replication to

[GitHub] [pulsar] dlg99 commented on pull request #11520: Debezium Oracle Source

2021-09-07 Thread GitBox
dlg99 commented on pull request #11520: URL: https://github.com/apache/pulsar/pull/11520#issuecomment-914413612 ping @sijie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] MMirelli opened a new pull request #11951: Fixing permissions of docker images scripts

2021-09-07 Thread GitBox
MMirelli opened a new pull request #11951: URL: https://github.com/apache/pulsar/pull/11951 ### Motivation Deploying pulsar on kubernetes from a docker image leads to a failure deploying the cluster. This is due to insufficient permissions assigned to python scripts in `/docker/puls

[GitHub] [pulsar] zbentley opened a new issue #11950: On master, connection attempts from the C++/Python client on "localhost" do not fall back from IPv6 to IPv4

2021-09-07 Thread GitBox
zbentley opened a new issue #11950: URL: https://github.com/apache/pulsar/issues/11950 **Describe the bug** If I run Pulsar listening on 127.0.0.1:6650 and attempt to connect to `pulsar://localhost:6650` via the C++ client (Python bindings) I am unable to connect. If I change the connec

[GitHub] [pulsar] hangc0276 opened a new pull request #11949: [Branch-2.8]Bump version to 2.8.2-SNAPSHOT

2021-09-07 Thread GitBox
hangc0276 opened a new pull request #11949: URL: https://github.com/apache/pulsar/pull/11949 ### Motivation Pulsar 2.8.1 has been released, bump branch-2.8 version to `2.8.2-SNAPSHOT` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

svn commit: r49801 - /dev/pulsar/pulsar-2.8.1-candidate-3/ /release/pulsar/pulsar-2.8.1/

2021-09-07 Thread chenhang
Author: chenhang Date: Tue Sep 7 13:32:15 2021 New Revision: 49801 Log: release 2.8.1 Added: release/pulsar/pulsar-2.8.1/ - copied from r49800, dev/pulsar/pulsar-2.8.1-candidate-3/ Removed: dev/pulsar/pulsar-2.8.1-candidate-3/

[GitHub] [pulsar] tuteng commented on a change in pull request #11931: [pulsar-client]Add a optional params scope for pulsar oauth2 client

2021-09-07 Thread GitBox
tuteng commented on a change in pull request #11931: URL: https://github.com/apache/pulsar/pull/11931#discussion_r703511128 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/auth/oauth2/AuthenticationOAuth2Test.java ## @@ -86,6 +86,7 @@ public void testCo

[pulsar] annotated tag v2.8.1 updated (09a6b58 -> 1dc615a)

2021-09-07 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a change to annotated tag v2.8.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git. *** WARNING: tag v2.8.1 was modified! *** from 09a6b58 (commit) to 1dc615a (tag) tagging 09a6b588fe7df6

[GitHub] [pulsar] 315157973 opened a new pull request #11948: Make Dispatcher pluggable

2021-09-07 Thread GitBox
315157973 opened a new pull request #11948: URL: https://github.com/apache/pulsar/pull/11948 ### Motivation A long time ago, someone raised a PR, hoping to implement tag messages through filters. The final result of the discussion is that it can be provided in a plug-in manner. h

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

2021-09-07 Thread GitBox
tomscut commented on pull request #11935: URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914258022 > lgtm. Thanks for you quick reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

2021-09-07 Thread GitBox
tomscut commented on pull request #11935: URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914257153 > Please include the timezone also. > > Rather than a custom format, you can use the log4j2 builtin format. > %d{ISO8601_OFFSET_DATE_TIME_HHMM} I added timezone

[GitHub] [pulsar-client-go] EAHITechnology commented on issue #608: Default redelivery interval of unacked messages

2021-09-07 Thread GitBox
EAHITechnology commented on issue #608: URL: https://github.com/apache/pulsar-client-go/issues/608#issuecomment-914238582 I am developing this feature @shubjain26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] tomscut commented on pull request #11935: Update the default log pattern

2021-09-07 Thread GitBox
tomscut commented on pull request #11935: URL: https://github.com/apache/pulsar/pull/11935#issuecomment-914217530 > Please include the timezone also. > > Rather than a custom format, you can use the log4j2 builtin format. > %d{ISO8601_OFFSET_DATE_TIME_HHMM} Thanks @ivankelly

[GitHub] [pulsar] gaozhangmin commented on pull request #11893: Admin cli support terminate a partitioned topic

2021-09-07 Thread GitBox
gaozhangmin commented on pull request #11893: URL: https://github.com/apache/pulsar/pull/11893#issuecomment-914214016 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] yuruguo commented on pull request #11946: Add new committers to the team page

2021-09-07 Thread GitBox
yuruguo commented on pull request #11946: URL: https://github.com/apache/pulsar/pull/11946#issuecomment-914213507 PTAL @Anonymitaet @Huanli-Meng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] gaozhangmin commented on pull request #11947: fix-npe-ZkBookieRackAffinityMapping

2021-09-07 Thread GitBox
gaozhangmin commented on pull request #11947: URL: https://github.com/apache/pulsar/pull/11947#issuecomment-914202621 @hanbo1990 @BewareMyPower PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] gaozhangmin opened a new pull request #11947: fix-npe-ZkBookieRackAffinityMapping

2021-09-07 Thread GitBox
gaozhangmin opened a new pull request #11947: URL: https://github.com/apache/pulsar/pull/11947 ### Motivation NPE when `ZkBookieRackAffinityMapping` ``` 17:24:03.724 [main-SendThread(bigdata-pulsar-bookie004.ys:2181)] INFO org.apache.zookeeper.ClientCnxn - Session establis

[GitHub] [pulsar] yuruguo opened a new pull request #11946: Add new committers to the team page

2021-09-07 Thread GitBox
yuruguo opened a new pull request #11946: URL: https://github.com/apache/pulsar/pull/11946 Add new committers to the team page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pulsar] liangyuanpeng edited a comment on pull request #8434: Enable pulsar function to send message to external pulsar cluster

2021-09-07 Thread GitBox
liangyuanpeng edited a comment on pull request #8434: URL: https://github.com/apache/pulsar/pull/8434#issuecomment-914194353 This PR revert by https://github.com/apache/pulsar/pull/10843 , So you cant not found some code or param like `--external-pulsars`. -- This is an automated messag

  1   2   >