[GitHub] [pulsar] zymap commented on a change in pull request #12123: Fix the potential race condition in the BlobStore readhandler

2021-09-24 Thread GitBox
zymap commented on a change in pull request #12123: URL: https://github.com/apache/pulsar/pull/12123#discussion_r715999390 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java ## @@ -94,56 +104,7

[GitHub] [pulsar] zymap commented on a change in pull request #12123: Fix the potential race condition in the BlobStore readhandler

2021-09-24 Thread GitBox
zymap commented on a change in pull request #12123: URL: https://github.com/apache/pulsar/pull/12123#discussion_r715998203 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedInputStreamImpl.java ## @@ -115,7 +115,

[GitHub] [pulsar] zymap commented on a change in pull request #12123: Fix the potential race condition in the BlobStore readhandler

2021-09-24 Thread GitBox
zymap commented on a change in pull request #12123: URL: https://github.com/apache/pulsar/pull/12123#discussion_r715997737 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedInputStreamImpl.java ## @@ -115,7 +115,

[GitHub] [pulsar] zymap commented on a change in pull request #12123: Fix the potential race condition in the BlobStore readhandler

2021-09-24 Thread GitBox
zymap commented on a change in pull request #12123: URL: https://github.com/apache/pulsar/pull/12123#discussion_r715997462 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java ## @@ -94,56 +104,7

[GitHub] [pulsar] zymap commented on a change in pull request #12123: Fix the potential race condition in the BlobStore readhandler

2021-09-24 Thread GitBox
zymap commented on a change in pull request #12123: URL: https://github.com/apache/pulsar/pull/12123#discussion_r715997136 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java ## @@ -94,56 +104,7

[pulsar] branch branch-2.8 updated: [Python Schema] Support setting namespace for python schema (#12175)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new e5a5498 [Python Schema] Support settin

[GitHub] [pulsar] yuruguo opened a new pull request #12187: [testclient] Make --payload-file take effect in PerformanceClient

2021-09-24 Thread GitBox
yuruguo opened a new pull request #12187: URL: https://github.com/apache/pulsar/pull/12187 ### Motivation The option `--payload-file` is just defined but does not work in PerformanceClient, this PR supports to use payload from a file instead of empty buffer. ### Modifications

[pulsar] branch master updated: PIP-45: Only run ZKSessionWatcher when MetadataStoreExtended is required (#12150)

2021-09-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e6781d8 PIP-45: Only run ZKSessionWatcher when

[GitHub] [pulsar] merlimat merged pull request #12150: PIP-45: Only run ZKSessionWatcher when MetadataStoreExtended is required

2021-09-24 Thread GitBox
merlimat merged pull request #12150: URL: https://github.com/apache/pulsar/pull/12150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] BewareMyPower commented on issue #12087: PIP 96: Payload converter for Pulsar client

2021-09-24 Thread GitBox
BewareMyPower commented on issue #12087: URL: https://github.com/apache/pulsar/issues/12087#issuecomment-927003655 I have simplified this design and update the description, PTAL again. @eolivelli Some changes: 1. Rename `MessageContext` to `EntryContext` to avoid misunderstanding

[GitHub] [pulsar] yuruguo commented on a change in pull request #12020: [testclient] Make option -time take effect in PerformanceClient

2021-09-24 Thread GitBox
yuruguo commented on a change in pull request #12020: URL: https://github.com/apache/pulsar/pull/12020#discussion_r715982722 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java ## @@ -244,10 +242,19 @@ public void runPerfo

[GitHub] [pulsar] Technoboy- commented on pull request #12112: [Cherry-pick] Pass client builder to debezium database history

2021-09-24 Thread GitBox
Technoboy- commented on pull request #12112: URL: https://github.com/apache/pulsar/pull/12112#issuecomment-927000391 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (3b76784 -> f0d8fb0)

2021-09-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3b76784 [Issue 1240][C++] Support setting ConsumerEventListener in pulsar cpp client (#12118) add f0d8fb0 [Py

[GitHub] [pulsar] Shoothzj commented on pull request #12170: [pulsar-java-client] Auto-recovery after exception like out of direct memory

2021-09-24 Thread GitBox
Shoothzj commented on pull request #12170: URL: https://github.com/apache/pulsar/pull/12170#issuecomment-926997686 > But here it swallows the exception and returns false. What would happen if new messages arrived? new messages will start a new journey, it can be add success if memory

[GitHub] [pulsar] merlimat merged pull request #12175: [Python Schema] Support setting namespace for python schema

2021-09-24 Thread GitBox
merlimat merged pull request #12175: URL: https://github.com/apache/pulsar/pull/12175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] Technoboy- commented on pull request #12112: [Cherry-pick] Pass client builder to debezium database history

2021-09-24 Thread GitBox
Technoboy- commented on pull request #12112: URL: https://github.com/apache/pulsar/pull/12112#issuecomment-926996844 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] BewareMyPower commented on pull request #12170: [pulsar-java-client] Auto-recovery after exception like out of direct memory

2021-09-24 Thread GitBox
BewareMyPower commented on pull request #12170: URL: https://github.com/apache/pulsar/pull/12170#issuecomment-926995617 But here it swallows the exception and returns false. What would happen if new messages arrived? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] danielorf opened a new pull request #12186: (Fixes #12182) Replaced urlencoded OAuth2 creds with Basic header

2021-09-24 Thread GitBox
danielorf opened a new pull request #12186: URL: https://github.com/apache/pulsar/pull/12186 Fixes #12182 ### Motivation Token request should use Basic auth instead of urlencoded credentials ### Modifications Replaced the URLEncoded OAuth2 creds with the `Auth

[GitHub] [pulsar] glcrazier opened a new issue #12185: ratePeriodInSecond in DispatchRate should be non-positive

2021-09-24 Thread GitBox
glcrazier opened a new issue #12185: URL: https://github.com/apache/pulsar/issues/12185 **Is your enhancement request related to a problem? Please describe.** If set ratePeriodInSecond of DispatchRate as 0 when setting namespace policy, the admin api indicates success. However, successiv

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12175: [Python Schema] Support setting namespace for python schema

2021-09-24 Thread GitBox
gaoran10 commented on a change in pull request #12175: URL: https://github.com/apache/pulsar/pull/12175#discussion_r715968205 ## File path: pulsar-client-cpp/python/pulsar/schema/definition.py ## @@ -57,6 +57,8 @@ def _get_fields(cls, dct): class Record(with_metaclass(Record

[GitHub] [pulsar] Shoothzj commented on pull request #12170: [pulsar-java-client] Auto-recovery after exception like out of direct memory

2021-09-24 Thread GitBox
Shoothzj commented on pull request #12170: URL: https://github.com/apache/pulsar/pull/12170#issuecomment-926970610 > Could you explain why `clear()` could fix the memory exhausted problem? > > Generally, for OOM issues, I suggest a fail fast solution. Otherwise, there might be a memo

[GitHub] [pulsar] merlimat opened a new pull request #12184: PIP-45: Handle session events and invalidations from single thread

2021-09-24 Thread GitBox
merlimat opened a new pull request #12184: URL: https://github.com/apache/pulsar/pull/12184 ### Motivation When we receive session events from the MetadataStoreExtended implementation, we need to process them from a single thread to ensure that the locks and leader revalidations are

[GitHub] [pulsar] merlimat opened a new pull request #12183: PIP-45: If they're connecting to same service, share local & config MetadataStores

2021-09-24 Thread GitBox
merlimat opened a new pull request #12183: URL: https://github.com/apache/pulsar/pull/12183 ### Motivation If the local and configurationStore are pointing to the same metadata store service, we can use a single instance. -- This is an automated message from the Apache Git Service

[GitHub] [pulsar] danielorf opened a new issue #12182: [OAuth2.0] Token request should use Basic auth instead of urlencoded credentials

2021-09-24 Thread GitBox
danielorf opened a new issue #12182: URL: https://github.com/apache/pulsar/issues/12182 **Describe the bug** The OAuth2 token request should use Basic auth instead of urlencoded credentials. [RFC 6749 section 2.3.1](https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1) (The OAut

[GitHub] [pulsar] aahmed-se opened a new pull request #12181: [Draft] Limit the semaphore count of the pulsar producer to prevent overflow

2021-09-24 Thread GitBox
aahmed-se opened a new pull request #12181: URL: https://github.com/apache/pulsar/pull/12181 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] kaushik-develop commented on pull request #12178: Support for draining workers

2021-09-24 Thread GitBox
kaushik-develop commented on pull request #12178: URL: https://github.com/apache/pulsar/pull/12178#issuecomment-926939451 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] michaeljmarshall commented on pull request #12180: [Docs][LoadBalancing] Add/Improve Javadocs for LoadSheddingStrategy impls

2021-09-24 Thread GitBox
michaeljmarshall commented on pull request #12180: URL: https://github.com/apache/pulsar/pull/12180#issuecomment-926932504 @hangc0276 - PTAL, since you were the original author of the `ThresholdShedder`. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12180: [Docs][LoadBalancing] Add/Improve Javadocs for LoadSheddingStrategy impls

2021-09-24 Thread GitBox
michaeljmarshall opened a new pull request #12180: URL: https://github.com/apache/pulsar/pull/12180 ### Motivation I recently researched the implementations of the `LoadSheddingStrategy` interface. I thought the Javadocs could be improved to make it easier for users/developers to be

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715749203 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,361 @@ +/

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12179: Fix some typos in documentation and code comments

2021-09-24 Thread GitBox
michaeljmarshall opened a new pull request #12179: URL: https://github.com/apache/pulsar/pull/12179 ### Motivation Fix some typos, some incorrect white spacing, and some pluralization. ### Verifying this change This change is a trivial rework / code cleanup without any t

[GitHub] [pulsar] frankjkelly commented on issue #12026: Allow us to easily get a mapping of topics to brokers

2021-09-24 Thread GitBox
frankjkelly commented on issue #12026: URL: https://github.com/apache/pulsar/issues/12026#issuecomment-926883435 It would be nice if maybe the `pulsar-admin` supported this when we call `topic stats` or `topic stats-internal`? -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] sijie commented on pull request #12137: [Broker] Change the default number of namespace bundles to 32

2021-09-24 Thread GitBox
sijie commented on pull request #12137: URL: https://github.com/apache/pulsar/pull/12137#issuecomment-926870223 Should this be considered for a PIP since we are changing a default value that can potentially impact users that would create a lot of namespaces? -- This is an automated messa

[GitHub] [pulsar] kaushik-develop opened a new pull request #12178: Support for draining workers

2021-09-24 Thread GitBox
kaushik-develop opened a new pull request #12178: URL: https://github.com/apache/pulsar/pull/12178 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue

[GitHub] [pulsar] merlimat commented on a change in pull request #12175: [Python Schema] Support setting namespace for python schema

2021-09-24 Thread GitBox
merlimat commented on a change in pull request #12175: URL: https://github.com/apache/pulsar/pull/12175#discussion_r715797668 ## File path: pulsar-client-cpp/python/pulsar/schema/definition.py ## @@ -101,15 +103,23 @@ def schema(cls): @classmethod def schema_info(cl

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11285: broker gc log

2021-09-24 Thread GitBox
michaeljmarshall commented on a change in pull request #11285: URL: https://github.com/apache/pulsar/pull/11285#discussion_r715810211 ## File path: conf/bkenv.sh ## @@ -30,16 +30,26 @@ BOOKIE_CONF=${BOOKIE_CONF:-"$BK_HOME/conf/bookkeeper.conf"} # BOOKIE_LOG_CONF= # Logs loc

[GitHub] [pulsar] vvijayv opened a new issue #12177: Helm installation fails

2021-09-24 Thread GitBox
vvijayv opened a new issue #12177: URL: https://github.com/apache/pulsar/issues/12177 **Describe the bug** The Pulsar Helm installation to EKS fails with the below message. `Error: INSTALLATION FAILED: failed to create resource: ConfigMap in version "v1" cannot be handled as a ConfigM

[GitHub] [pulsar] michaeljmarshall commented on pull request #12137: [Broker] Change the default number of namespace bundles to 32

2021-09-24 Thread GitBox
michaeljmarshall commented on pull request #12137: URL: https://github.com/apache/pulsar/pull/12137#issuecomment-926818757 Note also that the `LoadManager` implementation (and in the case the `LoadManager` is the `ModularLoadManagerWrapper`, the `LoadSheddingStrategy` implementation) will

[GitHub] [pulsar] michaeljmarshall commented on pull request #12176: Update PIP GitHub Issue Template

2021-09-24 Thread GitBox
michaeljmarshall commented on pull request #12176: URL: https://github.com/apache/pulsar/pull/12176#issuecomment-926814534 The primary discussion for this PR is on the mailing list here: https://lists.apache.org/thread.html/ra0155c8d385fe74038a49ffc00899f1f67bb8cf39f24e24664ec3092%40%3Cdev.

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715788433 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,361 @@ +/

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715787755 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,361 @@ +/

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715785333 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,372 @@ +/

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715785333 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,372 @@ +/

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12176: Update PIP GitHub Issue Template

2021-09-24 Thread GitBox
michaeljmarshall opened a new pull request #12176: URL: https://github.com/apache/pulsar/pull/12176 ### Motivation As discussed on the [dev mailing list](https://lists.apache.org/thread.html/ra0155c8d385fe74038a49ffc00899f1f67bb8cf39f24e24664ec3092%40%3Cdev.pulsar.apache.org%3E), th

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715742548 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,361 @@ +/

[GitHub] [pulsar] BewareMyPower commented on pull request #12170: [pulsar-java-client] Auto-recovery after exception like out of direct memory

2021-09-24 Thread GitBox
BewareMyPower commented on pull request #12170: URL: https://github.com/apache/pulsar/pull/12170#issuecomment-926750840 Could you explain why `clear()` could fix the memory exhausted problem? Generally, for OOM issues, I suggest a fail fast solution. Otherwise, there might be a memor

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12170: [pulsar-java-client] Auto-recovery after exception like out of direct memory

2021-09-24 Thread GitBox
BewareMyPower commented on a change in pull request #12170: URL: https://github.com/apache/pulsar/pull/12170#discussion_r715735285 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java ## @@ -66,18 +66,24 @@ public boolean add(M

[GitHub] [pulsar] EronWright commented on a change in pull request #11794: OIDC feature for oAuth flow

2021-09-24 Thread GitBox
EronWright commented on a change in pull request #11794: URL: https://github.com/apache/pulsar/pull/11794#discussion_r715734178 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTokenOIDC.java ## @@ -0,0 +1,372 @@ +/

[GitHub] [pulsar] gaoran10 opened a new pull request #12175: [Python Schema] Support setting namespace for python schema

2021-09-24 Thread GitBox
gaoran10 opened a new pull request #12175: URL: https://github.com/apache/pulsar/pull/12175 ### Motivation Currently, the python schema didn't support setting namespace in the schema definition. ### Modifications Support setting namespace in the python schema definition

[GitHub] [pulsar] merlimat commented on a change in pull request #12168: fix logger number not correct in tests

2021-09-24 Thread GitBox
merlimat commented on a change in pull request #12168: URL: https://github.com/apache/pulsar/pull/12168#discussion_r715706532 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java ## @@ -924,7 +924,7 @@ public void validatePoliciesReadOn

[GitHub] [pulsar] merlimat commented on pull request #12137: [Broker] Change the default number of namespace bundles to 32

2021-09-24 Thread GitBox
merlimat commented on pull request #12137: URL: https://github.com/apache/pulsar/pull/12137#issuecomment-926713000 > I now checked with pulsar-admin namespaces bundles public/default and there's 44 for public/default in this perf testing environment. Yes, they should be getting spli

[pulsar] branch master updated: [Issue 1240][C++] Support setting ConsumerEventListener in pulsar cpp client (#12118)

2021-09-24 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3b76784 [Issue 1240][C++] Support setting Consu

[GitHub] [pulsar] merlimat closed issue #1240: Implement ActiveConsumerListener for pulsar cpp client

2021-09-24 Thread GitBox
merlimat closed issue #1240: URL: https://github.com/apache/pulsar/issues/1240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [pulsar] merlimat merged pull request #12118: [Issue 1240][C++] Support setting ConsumerEventListener in pulsar cpp client

2021-09-24 Thread GitBox
merlimat merged pull request #12118: URL: https://github.com/apache/pulsar/pull/12118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log

2021-09-24 Thread GitBox
gaozhangmin commented on pull request #11285: URL: https://github.com/apache/pulsar/pull/11285#issuecomment-926695912 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] hangc0276 commented on a change in pull request #12173: Adding Multi-tiered storage key to broker.conf

2021-09-24 Thread GitBox
hangc0276 commented on a change in pull request #12173: URL: https://github.com/apache/pulsar/pull/12173#discussion_r715661461 ## File path: conf/broker.conf ## @@ -1261,6 +1261,9 @@ gcsManagedLedgerOffloadReadBufferSizeInBytes=1048576 # For more details, see the "Service Acco

[GitHub] [pulsar] gaozhangmin commented on pull request #10853: [Issue #9488][add admin api getBacklogSize]

2021-09-24 Thread GitBox
gaozhangmin commented on pull request #10853: URL: https://github.com/apache/pulsar/pull/10853#issuecomment-926670909 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] hangc0276 commented on a change in pull request #12123: Fix the potential race condition in the BlobStore readhandler

2021-09-24 Thread GitBox
hangc0276 commented on a change in pull request #12123: URL: https://github.com/apache/pulsar/pull/12123#discussion_r715613361 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java ## @@ -94,56 +1

[GitHub] [pulsar] Technoboy- commented on pull request #12136: Support for setting geo-replication clusters on topic level

2021-09-24 Thread GitBox
Technoboy- commented on pull request #12136: URL: https://github.com/apache/pulsar/pull/12136#issuecomment-926644470 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] golden-yang opened a new issue #12174: [Pulsar IO]Support JDBC-Source for data sync, when Debezium does not meet the demand

2021-09-24 Thread GitBox
golden-yang opened a new issue #12174: URL: https://github.com/apache/pulsar/issues/12174 In [issue#2442](https://github.com/apache/pulsar/issues/2442), Pulsar IO already support JDBC-sink and debezium-source. In some simple scenarios, I expect a more direct way to synchronize data,

[GitHub] [pulsar] gaozhangmin commented on pull request #10853: [Issue #9488][add admin api getBacklogSize]

2021-09-24 Thread GitBox
gaozhangmin commented on pull request #10853: URL: https://github.com/apache/pulsar/pull/10853#issuecomment-926635209 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] VadimMolodyh commented on issue #12115: "Clusters can not be empty" error on tenant creation when authentication is enabled

2021-09-24 Thread GitBox
VadimMolodyh commented on issue #12115: URL: https://github.com/apache/pulsar/issues/12115#issuecomment-926633797 @Shoothzj, thanks a lot! I tried these parameters but for some reason they it did not work on 2.7.x but it does work on 2.8.0 and 2.8.1. So, this means that JWT token authent

[GitHub] [pulsar] MMirelli opened a new pull request #12173: Adding Multi-tiered storage key to broker.conf

2021-09-24 Thread GitBox
MMirelli opened a new pull request #12173: URL: https://github.com/apache/pulsar/pull/12173 ### Motivation The helm deployment of pulsar with azure Multi Tiered Offloading enabled would fail, as [`broker.conf`](https://github.com/apache/pulsar/blob/master/conf/broker.conf)

[pulsar] branch master updated (4aae519 -> 7d4d8cc)

2021-09-24 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4aae519 [pulsar-client] Make it possible to disable poolMessages (#12108) add 7d4d8cc Fix deadLetterPolicy

[GitHub] [pulsar] hangc0276 closed issue #11652: deadLetterPolicy is not working with key shared subscription

2021-09-24 Thread GitBox
hangc0276 closed issue #11652: URL: https://github.com/apache/pulsar/issues/11652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [pulsar] hangc0276 merged pull request #12148: Fix deadLetterPolicy is not working with key shared subscription under partitioned topic

2021-09-24 Thread GitBox
hangc0276 merged pull request #12148: URL: https://github.com/apache/pulsar/pull/12148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] codelipenghui commented on pull request #12045: Optimize the memory usage of Cache Eviction

2021-09-24 Thread GitBox
codelipenghui commented on pull request #12045: URL: https://github.com/apache/pulsar/pull/12045#issuecomment-926607334 @merlimat Please help review the PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] wenbingshen edited a comment on issue #12169: [BUG] Questions about pulsar broker direct OOM

2021-09-24 Thread GitBox
wenbingshen edited a comment on issue #12169: URL: https://github.com/apache/pulsar/issues/12169#issuecomment-926602296 > @wenbingshen Do you have a chance to test with 2.8.1 ? That contains quite a few fixes, just to see if there's a difference. > > > producerRate: 88000 >

[GitHub] [pulsar] wenbingshen commented on issue #12169: [BUG] Questions about pulsar broker direct OOM

2021-09-24 Thread GitBox
wenbingshen commented on issue #12169: URL: https://github.com/apache/pulsar/issues/12169#issuecomment-926602296 > @wenbingshen Do you have a chance to test with 2.8.1 ? That contains quite a few fixes, just to see if there's a difference. > > > producerRate: 88000 > > I a

[GitHub] [pulsar] eolivelli commented on issue #10937: Incompatible BouncyCastle FIPS changes in bookkeeper 4.14

2021-09-24 Thread GitBox
eolivelli commented on issue #10937: URL: https://github.com/apache/pulsar/issues/10937#issuecomment-926598889 @codelipenghui can you please open a new ticket ? this ticket is bound to 2.8.1 release it is awkward to see this re-opened, as 2.8.1 has been released. I believe it wi

[GitHub] [pulsar] lhotari commented on issue #12169: [BUG] Questions about pulsar broker direct OOM

2021-09-24 Thread GitBox
lhotari commented on issue #12169: URL: https://github.com/apache/pulsar/issues/12169#issuecomment-926592230 @wenbingshen Do you have a chance to test with 2.8.1 ? That contains quite a few fixes, just to see if there's a difference. > producerRate: 88000 I assume you are

[GitHub] [pulsar] eolivelli commented on a change in pull request #12020: [testclient] Make option -time take effect in PerformanceClient

2021-09-24 Thread GitBox
eolivelli commented on a change in pull request #12020: URL: https://github.com/apache/pulsar/pull/12020#discussion_r715574615 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java ## @@ -244,10 +242,19 @@ public void runPer

[GitHub] [pulsar] yuruguo commented on a change in pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function

2021-09-24 Thread GitBox
yuruguo commented on a change in pull request #12128: URL: https://github.com/apache/pulsar/pull/12128#discussion_r714379146 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@ -271,7 +271,7 @@ void processArguments() throws Exce

[GitHub] [pulsar] eolivelli commented on a change in pull request #12025: violation of isolation when using bookie affinity group

2021-09-24 Thread GitBox
eolivelli commented on a change in pull request #12025: URL: https://github.com/apache/pulsar/pull/12025#discussion_r715564984 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -1336,22 +1339,54 @@ public void openLedgerFailed(

[GitHub] [pulsar] wenbingshen commented on issue #12169: [BUG] Questions about pulsar broker direct OOM

2021-09-24 Thread GitBox
wenbingshen commented on issue #12169: URL: https://github.com/apache/pulsar/issues/12169#issuecomment-926578428 ping @merlimat @codelipenghui @lhotari PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pulsar] 315157973 commented on a change in pull request #12025: violation of isolation when using bookie affinity group

2021-09-24 Thread GitBox
315157973 commented on a change in pull request #12025: URL: https://github.com/apache/pulsar/pull/12025#discussion_r715559815 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -1336,22 +1339,54 @@ public void openLedgerFailed(

[GitHub] [pulsar] 315157973 commented on pull request #12045: Optimize the memory usage of Cache Eviction

2021-09-24 Thread GitBox
315157973 commented on pull request #12045: URL: https://github.com/apache/pulsar/pull/12045#issuecomment-926574931 @codelipenghui PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] lordcheng10 closed pull request #12172: use asyncCloseCursorLedger to replace the code in the operationComple…

2021-09-24 Thread GitBox
lordcheng10 closed pull request #12172: URL: https://github.com/apache/pulsar/pull/12172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] yuruguo removed a comment on pull request #12084: [testclient] Add total messages when periodic printing throughput

2021-09-24 Thread GitBox
yuruguo removed a comment on pull request #12084: URL: https://github.com/apache/pulsar/pull/12084#issuecomment-925430986 @merlimat @lhotari @codelipenghui @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] yuruguo removed a comment on pull request #12020: [testclient] Make option -time take effect in PerformanceClient

2021-09-24 Thread GitBox
yuruguo removed a comment on pull request #12020: URL: https://github.com/apache/pulsar/pull/12020#issuecomment-924888500 PTAL @merlimat @lhotari @eolivelli @codelipenghui @congbobo184 @zymap -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] yuruguo commented on pull request #12020: [testclient] Make option -time take effect in PerformanceClient

2021-09-24 Thread GitBox
yuruguo commented on pull request #12020: URL: https://github.com/apache/pulsar/pull/12020#issuecomment-926539032 > The patch makes sense to me. > > But please address the suggestions Thanks for your reply, I have updated according to the suggestions, please take a look again.

[GitHub] [pulsar] RobertIndie opened a new pull request #12171: [WIP][Client] Return the message ID of the first chunk when sending chunked messages

2021-09-24 Thread GitBox
RobertIndie opened a new pull request #12171: URL: https://github.com/apache/pulsar/pull/12171 ### Motivation Currently, when we send chunked messages, the producer returns the message-id of the last chunk. This can cause some problems. For example, when we use this message-id to se

[pulsar] branch master updated (bfa4258 -> 4aae519)

2021-09-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bfa4258 Fix several typos in load balancing code (#12167) add 4aae519 [pulsar-client] Make it possible to dis

[GitHub] [pulsar] lhotari merged pull request #12108: [pulsar-client] Make it possible to disable poolMessages

2021-09-24 Thread GitBox
lhotari merged pull request #12108: URL: https://github.com/apache/pulsar/pull/12108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] yuruguo removed a comment on pull request #12108: [pulsar-client] Make it possible to disable poolMessages

2021-09-24 Thread GitBox
yuruguo removed a comment on pull request #12108: URL: https://github.com/apache/pulsar/pull/12108#issuecomment-926380276 > +1 Thanks for you time! If there is no problem, could you merge it to `master`? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] RobertIndie commented on pull request #12152: [Doc] Add doc for tokenSettingPrefix

2021-09-24 Thread GitBox
RobertIndie commented on pull request #12152: URL: https://github.com/apache/pulsar/pull/12152#issuecomment-926520457 @Huanli-Meng @Anonymitaet There is no need to update the previous release doc. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar] yuruguo edited a comment on pull request #11980: [website] Update cli-tools document

2021-09-24 Thread GitBox
yuruguo edited a comment on pull request #11980: URL: https://github.com/apache/pulsar/pull/11980#issuecomment-926517357 I have updated the remaining part of `cli-tools` document (from `2.3.x` to `2.6.x`), so far all versions of `cli-tools` document have been updated, although this is a re

[GitHub] [pulsar] yuruguo commented on pull request #11980: [website] Update cli-tools document

2021-09-24 Thread GitBox
yuruguo commented on pull request #11980: URL: https://github.com/apache/pulsar/pull/11980#issuecomment-926517357 I have updated the remaining part of `cli-tools` document (from `2.3.x` to `2.6.x`), so far all versions of `cli-tools` document have been updated, although this is a relativel

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11980: [website] Update cli-tools document

2021-09-24 Thread GitBox
Anonymitaet commented on a change in pull request #11980: URL: https://github.com/apache/pulsar/pull/11980#discussion_r715492933 ## File path: site2/docs/performance-pulsar-perf.md ## @@ -109,22 +123,34 @@ The following table lists configuration options available for the `puls

[GitHub] [pulsar] Anonymitaet commented on pull request #12152: [Doc] Add doc for tokenSettingPrefix

2021-09-24 Thread GitBox
Anonymitaet commented on pull request #12152: URL: https://github.com/apache/pulsar/pull/12152#issuecomment-926509704 Thanks for your contribution. Does this affect only master or other versioned docs? If latter, could you please help update [all affected versions](https://github.com/a

[pulsar] branch branch-2.8 updated: [Functions] reorganize the context hierarchy for functions (#10631) (#12117)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new e2a0866 [Functions] reorganize the con

[GitHub] [pulsar] codelipenghui merged pull request #12117: [Cherry-pick] [Functions] reorganize the context hierarchy for functions (#10631)

2021-09-24 Thread GitBox
codelipenghui merged pull request #12117: URL: https://github.com/apache/pulsar/pull/12117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch branch-2.8 updated: [Cherry-pick #11597] Use get instead of join to avoid getting stuck (#12110)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 5de46f9 [Cherry-pick #11597] Use get i

[GitHub] [pulsar] codelipenghui merged pull request #12110: [Cherry-pick] Use get instead of join to avoid getting stuck

2021-09-24 Thread GitBox
codelipenghui merged pull request #12110: URL: https://github.com/apache/pulsar/pull/12110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch branch-2.8 updated: [Cherry-pick #11614] Fix subscribeRateLimiter cannot be disabled (#12109)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new bad7120 [Cherry-pick #11614] Fix subsc

[GitHub] [pulsar] codelipenghui merged pull request #12109: [Cherry-pick] Fix subscribeRateLimiter cannot be disabled

2021-09-24 Thread GitBox
codelipenghui merged pull request #12109: URL: https://github.com/apache/pulsar/pull/12109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] 06/06: Return the last position of the compacted data while the original data been deleted. (#12161)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit b3e7be9447a24b46f765bb1d0b2debe9a7349d1a Author: lipenghui AuthorDate: Fri Sep 24 16:40:55 2021 +0800 Return t

[pulsar] 05/06: [pulsar-functions-go] support set subscription position (#11990)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d5d40a2068485c341a72f223e7f1db76d1bedd30 Author: Rui Fu AuthorDate: Fri Sep 24 10:27:40 2021 +0800 [pulsar-fun

[pulsar] 04/06: use correct line separator instead of \n (#12143)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit bff59fd9b11deb7b8604486fda46ea2a04ff0b4f Author: Shoothzj AuthorDate: Thu Sep 23 12:43:44 2021 +0800 use corre

[pulsar] 03/06: [Client] Fix ConcurrentModificationException in sendAsync (#11884)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 9ccfe96bae46fa4cc17130c0a2038b3b57c0cb59 Author: Lari Hotari AuthorDate: Tue Sep 21 12:39:04 2021 +0300 [Clien

[pulsar] 02/06: [pulsar-perf] Make it possible to disable poolMessages (#12090)

2021-09-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 1b4b71b07564b2dd68f83e675b7c5fdd5ba4dbbe Author: Lari Hotari AuthorDate: Mon Sep 20 19:52:45 2021 +0300 [pulsa

  1   2   >