gaozhangmin commented on pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#issuecomment-927506073
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
cckellogg commented on pull request #619:
URL: https://github.com/apache/pulsar-client-go/pull/619#issuecomment-927498037
LGTM any idea why CI is failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cckellogg commented on pull request #620:
URL: https://github.com/apache/pulsar-client-go/pull/620#issuecomment-927495983
LGTM any idea on why the CI is failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bookjiang commented on a change in pull request #12096:
URL: https://github.com/apache/pulsar/pull/12096#discussion_r716332657
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -3964,5 +3966,19 @@ private void
updateLas
lordcheng10 removed a comment on pull request #12113:
URL: https://github.com/apache/pulsar/pull/12113#issuecomment-927233753
@codelipenghui @lhotari @merlimat @BewareMyPower - PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lordcheng10 commented on pull request #12113:
URL: https://github.com/apache/pulsar/pull/12113#issuecomment-927485031
> > It almost seems to me that this method should have been used to close
the cursor ledger here:
> >
https://github.com/apache/pulsar/blob/0a1ae983ebb9fb049bbf34bfa3fe5
lordcheng10 edited a comment on pull request #12113:
URL: https://github.com/apache/pulsar/pull/12113#issuecomment-927233753
@codelipenghui @lhotari @merlimat @BewareMyPower - PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
lordcheng10 edited a comment on pull request #12113:
URL: https://github.com/apache/pulsar/pull/12113#issuecomment-927233753
@codelipenghui @lhotari @merlimat - PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
congbobo184 commented on pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#issuecomment-927459448
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
gaozhangmin commented on pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#issuecomment-927458427
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
BewareMyPower edited a comment on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927451267
> The flushing on close was already the pre-existing behavior
@merlimat I'm afraid not, in current `ProducerImpl#closeAsync`, before
sending `CommandClose`,
BewareMyPower commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927451267
> The flushing on close was already the pre-existing behavior
@merlimat I'm afraid not, in current `ProducerImpl#closeAsync`, before
sending `CommandClose`, produce
hellomyboy commented on issue #12185:
URL: https://github.com/apache/pulsar/issues/12185#issuecomment-927445920
/assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
88070173 closed pull request #11174:
URL: https://github.com/apache/pulsar/pull/11174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
wuzhanpeng commented on pull request #12202:
URL: https://github.com/apache/pulsar/pull/12202#issuecomment-927439394
@merlimat @sijie @eolivelli Could you help to check this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Technoboy- opened a new pull request #12203:
URL: https://github.com/apache/pulsar/pull/12203
Fix #10937.
## Documentation
Add a test, no need to update doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
baomingyu commented on pull request #11965:
URL: https://github.com/apache/pulsar/pull/11965#issuecomment-927433708
> @baomingyu Thanks for your contribution. For this PR, do we need to update
docs?
>
> (The [PR template contains info about
doc](https://github.com/apache/pulsar/blob
Anonymitaet commented on pull request #10817:
URL: https://github.com/apache/pulsar/pull/10817#issuecomment-927431752
Hi @mipper any progress on this PR? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Anonymitaet edited a comment on pull request #10817:
URL: https://github.com/apache/pulsar/pull/10817#issuecomment-904292822
Thanks for your suggestions! @BewareMyPower @jianyun8023
@mipper would you like to update docs based on our comments and add
explanations for subscription mod
Anonymitaet commented on pull request #11174:
URL: https://github.com/apache/pulsar/pull/11174#issuecomment-927410423
Hi @88070173 any progress for the code and doc? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
yuruguo removed a comment on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-927205251
PTAL @merlimat @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927395986
@merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please
yuruguo removed a comment on pull request #12084:
URL: https://github.com/apache/pulsar/pull/12084#issuecomment-927310461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yuruguo commented on pull request #12084:
URL: https://github.com/apache/pulsar/pull/12084#issuecomment-927395645
@merlimat @lhotari @codelipenghui @BewareMyPower @hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
danielorf commented on pull request #12186:
URL: https://github.com/apache/pulsar/pull/12186#issuecomment-927339629
Can someone with access to CI restart the pipeline? It appears that one of
the jobs was canceled (but the rest passed).
--
This is an automated message from the Apache Git
Shoothzj commented on pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200#issuecomment-927329633
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
lordcheng10 edited a comment on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927322511
Thank you for your attention！
For similar producer close logic, we can refer to Kafka's processing:
add 55e304b Fixed counter base path getting deleted (#
lordcheng10 edited a comment on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927322511
Thank you for your attention！
For similar producer close logic, we can refer to Kafka's processing:
 close, though I
would not characterize it as "data lost" since the send futures will not be
successful.
We sho
BewareMyPower commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927315037
IMO it's the right behavior. `close` or `closeAsync` should not be
responsible to flush the internal messages.
--
This is an automated message from the Apache Git Servi
yuruguo commented on pull request #12084:
URL: https://github.com/apache/pulsar/pull/12084#issuecomment-927310461
@codelipenghui PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
merlimat commented on a change in pull request #12193:
URL: https://github.com/apache/pulsar/pull/12193#discussion_r716207869
##
File path:
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/CounterTest.java
##
@@ -51,4 +51,40 @@ public void basicTest(String provider, Su
Shoothzj commented on pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200#issuecomment-927304776
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
wuzhanpeng opened a new pull request #12202:
URL: https://github.com/apache/pulsar/pull/12202
### Motivation
In our production environment, when the broker receives a large number of
`PRODUCER` requests in a short period of time, we have observed that the broker
will have a loop wai
codelipenghui commented on pull request #12170:
URL: https://github.com/apache/pulsar/pull/12170#issuecomment-927300448
> Currently, if BatchMessageContainerImpl's add method throw an Exception
while adding the first messages.
I mean you have mentioned will get an exception from the
Shoothzj commented on pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200#issuecomment-927299511
@eolivelli, @codelipenghui, @BewareMyPower, @sijie, @hangc0276, @merlimat -
PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the mess
Shoothzj commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927299435
LGTM @eolivelli, @codelipenghui, @BewareMyPower, @sijie, @hangc0276,
@merlimat - PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
Shoothzj commented on pull request #12170:
URL: https://github.com/apache/pulsar/pull/12170#issuecomment-927298733
> Do you have details about the exception?
Yes, OutOfDirectMemoryError
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
gaozhangmin commented on a change in pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#discussion_r716197064
##
File path: bin/pulsar
##
@@ -287,6 +288,9 @@
PULSAR_LOG_APPENDER=${PULSAR_LOG_APPENDER:-"RoutingAppender"}
PULSAR_LOG_ROOT_LEVEL=${PULSAR_LOG_RO
lordcheng10 commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927297330
> I mean that when the `flushAsync` future complete, then do the logic. So
the `closeAsync` method will not block
@Shoothzj As we just discussed, I replaced flush wit
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 1e133e9 [website] Update cli-tools document (#11980)
add a69611c fix logger number not correct in tests (#121
codelipenghui merged pull request #12168:
URL: https://github.com/apache/pulsar/pull/12168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
kellyfj opened a new issue #12201:
URL: https://github.com/apache/pulsar/issues/12201
Please answer the following questions before submitting your doc issue.
Thanks!
# What issue do you find in Pulsar docs?
It's hard to tell when Configuration parameters were introduced
htt
Shoothzj opened a new pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200
### Motivation
When the client jvm direct memory is full, we don't want pulsar client to
use heap memory which may lead to a Heap OutOfMemoryError. In this scene, we
want the client allocate memo
yuruguo edited a comment on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-927279528
> Thanks for your contribution. Does this affect only master or other
versioned docs?
> If latter, could you please help update [all affected
versions](https://github
liangyepianzhou removed a comment on pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#issuecomment-927265990
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
liangyepianzhou commented on pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#issuecomment-927285006
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10 @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
yuruguo edited a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-927204910
PTAL @merlimat @lhotari @eolivelli @gaoran10 @MarvinCai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
yuruguo removed a comment on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-927279612
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-927279612
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
yuruguo commented on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-927279528
> Thanks for your contribution. Does this affect only master or other
versioned docs?
> If latter, could you please help update [all affected
versions](https://github.com/ap
Anonymitaet commented on pull request #11526:
URL: https://github.com/apache/pulsar/pull/11526#issuecomment-927279380
Hi @vsly-ru can you take a look at our comments and make changes? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Anonymitaet commented on pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#issuecomment-927279177
Hi @tomiamao, any progress for the code and doc? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Anonymitaet commented on pull request #11878:
URL: https://github.com/apache/pulsar/pull/11878#issuecomment-927278170
Hi @tuteng Could you please help review this PR from the technical
perspective? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the mess
Anonymitaet merged pull request #11980:
URL: https://github.com/apache/pulsar/pull/11980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
Anonymitaet commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-927275582
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
asagjj opened a new issue #12199:
URL: https://github.com/apache/pulsar/issues/12199
Similiar as ISSUE-5650.
Expected behavior
when use bin/pulsar shell, like generate public key or token, we should can
excute it in any dirs and specify a relative path.
Actual behavi
lordcheng10 edited a comment on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927269367
> I mean that when the `flushAsync` future complete, then do the logic. So
the `closeAsync` method will not block
You are right, I will try to modify it
--
lordcheng10 commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927269367
> I mean that when the `flushAsync` future complete, then do the logic. So
the `closeAsync` method will not block
You are correct, I will try to modify it
--
This
liangyepianzhou commented on pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#issuecomment-927265990
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Shoothzj commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927265508
I mean that when the `flushAsync` future complete, then do the logic. So the
`closeAsync` method will not block
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 71b825a Revert "[Doc] Add doc for tokenSettingPr
Anonymitaet commented on pull request #12152:
URL: https://github.com/apache/pulsar/pull/12152#issuecomment-927265309
@RobertIndie please add docs for 2.8.1 as well, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Anonymitaet merged pull request #12198:
URL: https://github.com/apache/pulsar/pull/12198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
Anonymitaet opened a new pull request #12198:
URL: https://github.com/apache/pulsar/pull/12198
Reverts apache/pulsar#12152 since code
(https://github.com/apache/pulsar/pull/12132) is not merged
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a commit to branch revert-12152-fix-jwt-prefix-doc
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 2f962518413344c7175c77ba9ddc336e28875c21
Author: Anonymitaet <50226895+anonymit...@users.noreply.
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a change to branch revert-12152-fix-jwt-prefix-doc
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
at 2f96251 Revert "[Doc] Add doc for tokenSettingPrefix (#12152)"
This branch includes the fol
nodece commented on pull request #12155:
URL: https://github.com/apache/pulsar/pull/12155#issuecomment-927257993
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927253526
> @lordcheng10 Thanks for your contribution. For this PR, do we need to
update docs?
>
> (The [PR template contains info about
doc](https://github.com/apache/pulsar/
lordcheng10 closed issue #12139:
URL: https://github.com/apache/pulsar/issues/12139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
lordcheng10 edited a comment on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927248432
> flushAsync
Thank you for your attention! The cleanup logic can only be done after the
flush is completed. If the flushAsync method is used instead of the flu
liangyepianzhou commented on a change in pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#discussion_r716157771
##
File path:
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java
##
@@ -340,9 +344,123 @@ public static void
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 2c2922d Ensure the ownership cache lock expiring triggers an unload
(#12194)
add 4ad9694 [Doc] Add doc for tok
Anonymitaet merged pull request #12152:
URL: https://github.com/apache/pulsar/pull/12152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
Anonymitaet commented on a change in pull request #12178:
URL: https://github.com/apache/pulsar/pull/12178#discussion_r716156705
##
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
##
@@ -71,7 +75,7 @@
* The scheduler
lordcheng10 edited a comment on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927248432
> flushAsync
Thank you for your attention! I understand that the original close cleanup
logic needs to be completed after the flush is completed. If the flushA
lordcheng10 commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927248432
> flushAsync
Thank you for your attention! My understanding is that the original close
cleanup logic can only be done after the flush is completed. If the flushAsync
Anonymitaet commented on a change in pull request #12180:
URL: https://github.com/apache/pulsar/pull/12180#discussion_r716156123
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java
##
@@ -35,6 +35,18 @@
import org.slf4j.Lo
gaozhangmin edited a comment on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-927221731
test failed reason: Unrecognized option:
-Xlog:gc:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M
I cannot figure out why.
--
This is an au
Anonymitaet commented on pull request #12181:
URL: https://github.com/apache/pulsar/pull/12181#issuecomment-927247949
@aahmed-se Thanks for your contribution. For this PR, do we need to update
docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/mas
Anonymitaet commented on a change in pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#discussion_r716155333
##
File path: site2/docs/reference-cli-tools.md
##
@@ -525,6 +525,9 @@ Options
|`-m`, `--num-messages`|Number of messages to publish in total. If th
Anonymitaet commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-927247233
@lordcheng10 Thanks for your contribution. For this PR, do we need to update
docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/m
Shoothzj commented on pull request #12170:
URL: https://github.com/apache/pulsar/pull/12170#issuecomment-927247097
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
wangjialing218 commented on issue #12040:
URL: https://github.com/apache/pulsar/issues/12040#issuecomment-927246673
> Please take a look at the linked PR. My expectation is that the KOP
handler obtain its server ports using:
>
> ```
> List bindAddresses =
BindAddressValidator.val
100 matches
Mail list logo
