wolfstudy commented on pull request #552:
URL: https://github.com/apache/pulsar-client-go/pull/552#issuecomment-941971670
> > ping @cckellogg @GPrabhudas What is the latest status here?
>
> @wolfstudy We can close this PR as all of its sub PRs are merged into
master. #555 base interf
wolfstudy closed pull request #552:
URL: https://github.com/apache/pulsar-client-go/pull/552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
wolfstudy merged pull request #637:
URL: https://github.com/apache/pulsar-client-go/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 4e55be0 Fix minor api issue and comments
gaozhangmin opened a new issue #12342:
URL: https://github.com/apache/pulsar/issues/12342
it's not easy to reproduce
--
This is an automated message from the Apache Git S
wangjialing218 commented on pull request #11325:
URL: https://github.com/apache/pulsar/pull/11325#issuecomment-941940123
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
BewareMyPower opened a new pull request #12341:
URL: https://github.com/apache/pulsar/pull/12341
Fixes #12334
### Motivation
When C++ client sends a HTTP request for the access token from a OAuth 2.0
server, the content type is JSON, which is incorrect and might not work in so
This is an automated email from the ASF dual-hosted git repository.
guangning pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.8 by this push:
new 522af14 [C++] Handle OAuth 2.0 excep
tomscut edited a comment on issue #12333:
URL: https://github.com/apache/pulsar/issues/12333#issuecomment-941895520
@eolivelli @nicoloboschi @lordcheng10
I found that the internal execution time was greater than the default 10s.
When updating the code from
```
Awaitility.await(
tomscut commented on issue #12333:
URL: https://github.com/apache/pulsar/issues/12333#issuecomment-941895520
@eolivelli @nicoloboschi @lordcheng10
I found that the internal execution time was greater than the default 10s.
When updating the code from
```
Awaitility.await().until
Jason918 commented on pull request #12308:
URL: https://github.com/apache/pulsar/pull/12308#issuecomment-941895514
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Anonymitaet commented on a change in pull request #12336:
URL: https://github.com/apache/pulsar/pull/12336#discussion_r727671191
##
File path: site2/docs/performance-pulsar-perf.md
##
@@ -8,149 +8,168 @@ The Pulsar Perf is a built-in performance test tool for
Apache Pulsar. Yo
This is an automated email from the ASF dual-hosted git repository.
yong pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.8 by this push:
new b1d4fe7 Fix the potential race condition
Anonymitaet edited a comment on pull request #11526:
URL: https://github.com/apache/pulsar/pull/11526#issuecomment-941873733
@sijia-w I've confirmed w/ eng, now could you please help open another PR
and update all versioned docs (from 2.2.0 to master) based on our comments?
Thanks
--
Th
Anonymitaet commented on pull request #11526:
URL: https://github.com/apache/pulsar/pull/11526#issuecomment-941873733
@sijia-w I've confirmed w/ eng, could you please help open another PR and
update all versioned docs (from 2.2.0 to master) based on our comments? Thanks
--
This is an aut
Anonymitaet commented on a change in pull request #11526:
URL: https://github.com/apache/pulsar/pull/11526#discussion_r727663303
##
File path: site2/docs/client-libraries-node.md
##
@@ -137,7 +137,7 @@ Pulsar Node.js producers have the following methods
available:
| Paramet
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 7273ffe feat(cli): add restart command to pulsar-daemon (#12279)
add 06b68bb [C++] Handle OAuth 2.0 exceptional c
BewareMyPower closed issue #12324:
URL: https://github.com/apache/pulsar/issues/12324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
BewareMyPower merged pull request #12335:
URL: https://github.com/apache/pulsar/pull/12335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
lordcheng10 commented on issue #12317:
URL: https://github.com/apache/pulsar/issues/12317#issuecomment-941871714
> Hi @lordcheng10 , may I ask which version of your code is? I did not
reproduce this problem in the latest code. In addition, the number of lines of
code is inconsistent from t
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 7273ffe feat(cli): add restart command to pulsar-d
BewareMyPower merged pull request #12279:
URL: https://github.com/apache/pulsar/pull/12279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
yuruguo removed a comment on pull request #12296:
URL: https://github.com/apache/pulsar/pull/12296#issuecomment-941854966
@merlimat @eolivelli @congbobo184 @BewareMyPower @hangc0276 Please take a
look for this PR.
And If there is no problem, can you merge to the master branch?
--
This
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 5f00b87 Make AuthenticationTokenTest to run on windows (#12329)
add 753e153 [client-tools] Remove redundant initi
BewareMyPower merged pull request #12296:
URL: https://github.com/apache/pulsar/pull/12296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
codelipenghui commented on pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200#issuecomment-941861763
@eolivelli Please help review PR again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Huanli-Meng commented on a change in pull request #12336:
URL: https://github.com/apache/pulsar/pull/12336#discussion_r727649275
##
File path: site2/docs/performance-pulsar-perf.md
##
@@ -8,149 +8,168 @@ The Pulsar Perf is a built-in performance test tool for
Apache Pulsar. Yo
yuruguo removed a comment on pull request #12300:
URL: https://github.com/apache/pulsar/pull/12300#issuecomment-939581738
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @315157973 @hangc0276
@gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respon
yuruguo commented on pull request #12300:
URL: https://github.com/apache/pulsar/pull/12300#issuecomment-941857190
@merlimat @aahmed-se @eolivelli @k2la @codelipenghui @gaoran10 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yuruguo commented on pull request #12300:
URL: https://github.com/apache/pulsar/pull/12300#issuecomment-941856164
> @yuruguo should we add the `version` flag to the code files in
`https://github.com/apache/pulsar/tree/master/pulsar-testclient/src`? Example:
https://github.com/apache/pulsar
MarvinCai commented on pull request #12326:
URL: https://github.com/apache/pulsar/pull/12326#issuecomment-941855629
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MarvinCai commented on pull request #12270:
URL: https://github.com/apache/pulsar/pull/12270#issuecomment-941855525
@eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
MarvinCai commented on a change in pull request #12270:
URL: https://github.com/apache/pulsar/pull/12270#discussion_r727648797
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PersistentOfflineTopicStats.java
##
@@ -55,8 +55,8 @@
public Per
yuruguo commented on pull request #12296:
URL: https://github.com/apache/pulsar/pull/12296#issuecomment-941854966
@merlimat @eolivelli @congbobo184 @BewareMyPower @hangc0276 Please take a
look for this PR.
And If there is no problem, can you merge to the master branch?
--
This is an a
yuruguo removed a comment on pull request #12296:
URL: https://github.com/apache/pulsar/pull/12296#issuecomment-940839365
@eolivelli @hangc0276 @BewareMyPower Please take a look for this PR.
And If there is no problem, can you merge to the `master` branch?
--
This is an automated mess
MarvinCai commented on a change in pull request #12270:
URL: https://github.com/apache/pulsar/pull/12270#discussion_r727647934
##
File path: pulsar-common/pom.xml
##
@@ -196,6 +196,24 @@
+
+ org.gaul
+ modernizer-maven-plugin
Review comment:
sure
yuruguo removed a comment on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-940628727
@merlimat @lhotari @eolivelli @315157973 @BewareMyPower @hangc0276 @gaoran10
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the messa
yuruguo commented on pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#issuecomment-941851435
@merlimat @lhotari @eolivelli @315157973 @BewareMyPower @hangc0276 @gaoran10
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
yuruguo removed a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-940630480
@merlimat @k2la @massakam @codelipenghui @jiazhai @congbobo184 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
yuruguo commented on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-941848988
@merlimat @k2la @codelipenghui @jiazhai @congbobo184 @hangc0276 @gaoran10
PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Jason918 commented on pull request #12308:
URL: https://github.com/apache/pulsar/pull/12308#issuecomment-941848226
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
yuruguo commented on pull request #12322:
URL: https://github.com/apache/pulsar/pull/12322#issuecomment-941847248
> @yuruguo the doc is automatically generated with the code file, so I label
this PR w/ `doc`.
Okay :)
[12242](https://github.com/apache/pulsar/pull/12242) is similar
lordcheng10 edited a comment on issue #12333:
URL: https://github.com/apache/pulsar/issues/12333#issuecomment-941838115
I also encountered it, and in my PR, CI was triggered several times and
failed in this method。
--
This is an automated message from the Apache Git Service.
To respond t
lordcheng10 commented on issue #12333:
URL: https://github.com/apache/pulsar/issues/12333#issuecomment-941838115
I also encountered it, and in my PR, CI was triggered several times and
failed in this method.
--
This is an automated message from the Apache Git Service.
To respond to the m
This is an automated email from the ASF dual-hosted git repository.
xyz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from f283030 [offload] fix FileSystemManagedLedgerOffloader can not
cleanup outdated ledger data (#12309)
add 5f00b87
BewareMyPower merged pull request #12329:
URL: https://github.com/apache/pulsar/pull/12329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
merlimat commented on a change in pull request #12340:
URL: https://github.com/apache/pulsar/pull/12340#discussion_r727633231
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
##
@@ -65,13 +65,11 @@ public BacklogQuota getDefau
BewareMyPower commented on a change in pull request #12335:
URL: https://github.com/apache/pulsar/pull/12335#discussion_r727630186
##
File path: pulsar-client-cpp/lib/Commands.cc
##
@@ -228,13 +228,18 @@ SharedBuffer Commands::newConnect(const
AuthenticationPtr& authentication
wangjialing218 commented on pull request #11325:
URL: https://github.com/apache/pulsar/pull/11325#issuecomment-941818419
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
chenhang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 61d3723 [Doc]--Update contents for Pulsar adaptor for Apache Spark
(#12338)
add f283030 [offload] fix FileS
hangc0276 merged pull request #12309:
URL: https://github.com/apache/pulsar/pull/12309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
lordcheng10 commented on pull request #12332:
URL: https://github.com/apache/pulsar/pull/12332#issuecomment-941810822
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dlg99 commented on pull request #12256:
URL: https://github.com/apache/pulsar/pull/12256#issuecomment-941810115
@Anonymitaet I updated the doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dlg99 commented on a change in pull request #12256:
URL: https://github.com/apache/pulsar/pull/12256#discussion_r727618739
##
File path: site2/docs/io-debezium-source.md
##
@@ -535,6 +535,72 @@ configs:
For the full list of configuration properties supported by Debezium, see
hangc0276 commented on a change in pull request #12340:
URL: https://github.com/apache/pulsar/pull/12340#discussion_r727618229
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -411,7 +396,7 @@ protected void checkTopicFenced()
codelipenghui commented on a change in pull request #12340:
URL: https://github.com/apache/pulsar/pull/12340#discussion_r727615842
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -114,17 +114,11 @@ public AbstractTopic(String
dlg99 commented on a change in pull request #12256:
URL: https://github.com/apache/pulsar/pull/12256#discussion_r727618235
##
File path: site2/docs/io-connectors.md
##
@@ -52,6 +52,15 @@ Pulsar has various source connectors, which are sorted
alphabetically as below.
* [Exampl
dlg99 commented on a change in pull request #12256:
URL: https://github.com/apache/pulsar/pull/12256#discussion_r727617347
##
File path: site2/docs/io-debezium-source.md
##
@@ -535,6 +535,72 @@ configs:
For the full list of configuration properties supported by Debezium, see
Anonymitaet commented on pull request #12195:
URL: https://github.com/apache/pulsar/pull/12195#issuecomment-941805193
@lordcheng10 feel free to ping me if you need a doc review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Anonymitaet commented on a change in pull request #12256:
URL: https://github.com/apache/pulsar/pull/12256#discussion_r727615308
##
File path: site2/docs/io-debezium-source.md
##
@@ -535,6 +535,72 @@ configs:
For the full list of configuration properties supported by Debeziu
Anonymitaet commented on pull request #12258:
URL: https://github.com/apache/pulsar/pull/12258#issuecomment-941801029
@rdhabalia Thanks for your contribution. For this PR, do we need to update
docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/mas
Anonymitaet commented on pull request #12294:
URL: https://github.com/apache/pulsar/pull/12294#issuecomment-941800409
@rdhabalia feel free to ping me if you need a doc review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Anonymitaet commented on pull request #12298:
URL: https://github.com/apache/pulsar/pull/12298#issuecomment-941800104
@ciaocloud Thanks for your contribution. For this PR, do we need to update
docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/mas
codelipenghui commented on pull request #12339:
URL: https://github.com/apache/pulsar/pull/12339#issuecomment-941800067
@michaeljmarshall Please help review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Anonymitaet commented on pull request #12300:
URL: https://github.com/apache/pulsar/pull/12300#issuecomment-941799926
@yuruguo should we add the `version` flag to the code files in
`https://github.com/apache/pulsar/tree/master/pulsar-testclient/src`? Example:
https://github.com/apache/puls
yuruguo commented on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-941799068
> @yuruguo done
thx :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Anonymitaet commented on pull request #12302:
URL: https://github.com/apache/pulsar/pull/12302#issuecomment-941798235
@gaozhangmin feel free to ping me if you need a doc review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
beyondyinjl2 commented on pull request #12331:
URL: https://github.com/apache/pulsar/pull/12331#issuecomment-941797851
@Anonymitaet Mainly, when the sending and subscribing topics on the mop side
will judge the permissions, this method is needed. The document is explained in
the mop. This
Anonymitaet commented on pull request #12322:
URL: https://github.com/apache/pulsar/pull/12322#issuecomment-941796459
@yuruguo the doc is automatically generated with the code file, so I label
this PR w/ `doc`.
--
This is an automated message from the Apache Git Service.
To respond to th
Anonymitaet commented on pull request #12331:
URL: https://github.com/apache/pulsar/pull/12331#issuecomment-941795514
@beyondyinjl2 Thanks for your contribution. For this PR, do we need to
update docs?
(The [PR template contains info about
doc](https://github.com/apache/pulsar/blob/
Anonymitaet commented on pull request #12187:
URL: https://github.com/apache/pulsar/pull/12187#issuecomment-941793697
@yuruguo done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
merlimat opened a new pull request #12340:
URL: https://github.com/apache/pulsar/pull/12340
### Motivation
This is a port to branch 2.7 of the fixes done in #12339. It's not a
straight cherry-pick since the code has changed a lot since then, though the
same problem of blocking calls
Shoothzj commented on pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200#issuecomment-941748101
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alexsapps commented on issue #12053:
URL: https://github.com/apache/pulsar/issues/12053#issuecomment-941729849
Hi @Huanli-Meng Let me know if you have advice where to get more information
on retry topics :)
--
This is an automated message from the Apache Git Service.
To respond to the me
merlimat commented on a change in pull request #12339:
URL: https://github.com/apache/pulsar/pull/12339#discussion_r727559908
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
##
@@ -322,48 +324,42 @@ publi
addisonj commented on pull request #12072:
URL: https://github.com/apache/pulsar/pull/12072#issuecomment-941638303
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
michaeljmarshall commented on a change in pull request #12339:
URL: https://github.com/apache/pulsar/pull/12339#discussion_r727528015
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##
@@ -209,18 +196,12 @@ protected boolean isCons
EronWright removed a comment on pull request #12079:
URL: https://github.com/apache/pulsar/pull/12079#issuecomment-922118269
@rdhabalia would appreciate your feedback, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
merlimat commented on a change in pull request #12339:
URL: https://github.com/apache/pulsar/pull/12339#discussion_r727515017
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
##
@@ -322,48 +324,42 @@ publi
michaeljmarshall commented on pull request #12123:
URL: https://github.com/apache/pulsar/pull/12123#issuecomment-941568227
@codelipenghui and @zymap - sorry for my delayed review. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
michaeljmarshall commented on a change in pull request #12302:
URL: https://github.com/apache/pulsar/pull/12302#discussion_r727500737
##
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##
@@ -778,6 +778,14 @@ void run() throws PulsarAdmi
sijia-w commented on pull request #11526:
URL: https://github.com/apache/pulsar/pull/11526#issuecomment-941527075
@Anonymitaet Shall I create a new pr after @vsly-ru replies to this message?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message
EronWright commented on pull request #12072:
URL: https://github.com/apache/pulsar/pull/12072#issuecomment-941523076
This is ready to merge. The test failure seems unrelated:
```
Error:
org.apache.pulsar.broker.admin.TopicPoliciesTest.testDisableSubscribeRate(org.apache.pulsar.broke
cckellogg commented on a change in pull request #12339:
URL: https://github.com/apache/pulsar/pull/12339#discussion_r727442559
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java
##
@@ -322,48 +324,42 @@ publ
merlimat opened a new pull request #12339:
URL: https://github.com/apache/pulsar/pull/12339
### Motivation
We have several places that are accessing the namespace policies in a
synchronous way from the critical IO threads of the broker. These accesses are
almost always non-blocking
EronWright commented on issue #12334:
URL: https://github.com/apache/pulsar/issues/12334#issuecomment-941257804
Good job in diagnosing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 61d3723 [Doc]--Update contents for Pulsar adapt
merlimat merged pull request #12338:
URL: https://github.com/apache/pulsar/pull/12338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
lordcheng10 commented on pull request #12332:
URL: https://github.com/apache/pulsar/pull/12332#issuecomment-941205497
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
merlimat commented on a change in pull request #12335:
URL: https://github.com/apache/pulsar/pull/12335#discussion_r727337086
##
File path: pulsar-client-cpp/lib/Commands.cc
##
@@ -228,13 +228,18 @@ SharedBuffer Commands::newConnect(const
AuthenticationPtr& authentication, con
nlu90 commented on pull request #12338:
URL: https://github.com/apache/pulsar/pull/12338#issuecomment-941184771
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
315157973 commented on issue #12269:
URL: https://github.com/apache/pulsar/issues/12269#issuecomment-941159597
> What happens if I subscribe from two different consumer with different
subscriptProperties ?
`subscriptionProperties` is immutable. Attempts to modify will return an
exc
eolivelli commented on issue #12269:
URL: https://github.com/apache/pulsar/issues/12269#issuecomment-941155886
What happens if I subscribe from two different consumer with different
subscriptProperties ?
--
This is an automated message from the Apache Git Service.
To respond to the messa
eolivelli commented on issue #12269:
URL: https://github.com/apache/pulsar/issues/12269#issuecomment-941155122
I would change 'subscriptProperties' to 'subscriptionProperties'
Apart from this LGTM
--
This is an automated message from the Apache Git Service.
To respond to the messag
eolivelli commented on pull request #12306:
URL: https://github.com/apache/pulsar/pull/12306#issuecomment-941129822
@dlg99 @lhotari is it possible to make this new CI job not "required" to
merge the PRs ?
--
This is an automated message from the Apache Git Service.
To respond to the mess
liangyepianzhou commented on pull request #12219:
URL: https://github.com/apache/pulsar/pull/12219#issuecomment-941123562
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo edited a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-924599172
> LGTM.
> Why are the two judgment conditions not merged together?
>
> ```
> if (testTime > 0 && System.nanoTime() > testEndTime)
> ```
In fact, th
315157973 commented on issue #12269:
URL: https://github.com/apache/pulsar/issues/12269#issuecomment-941086295
@eolivelli PTAL, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Shoothzj commented on pull request #12200:
URL: https://github.com/apache/pulsar/pull/12200#issuecomment-941070911
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
eolivelli commented on pull request #12056:
URL: https://github.com/apache/pulsar/pull/12056#issuecomment-941067555
CI error is related to this patch
please fix
```
testMalformed(org.apache.pulsar.broker.validator.BindAddressValidatorTest)
Time elapsed: 0.033 s <<< FAILUR
1 - 100 of 160 matches
Mail list logo
