[GitHub] [pulsar] lordcheng10 commented on pull request #12527: The count of topics on the bundle is less than 2,skip split

2021-10-29 Thread GitBox
lordcheng10 commented on pull request #12527: URL: https://github.com/apache/pulsar/pull/12527#issuecomment-955160220 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] dhinesherode91 commented on issue #8429: Cannot parse schema

2021-10-29 Thread GitBox
dhinesherode91 commented on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-955159405 @congbobo184 The issue is not yet resolved. We are using Pulsar 2.7.1. Both broker and Pulsar client are using the same version. Our consumer is subscribed to a single topic on

[GitHub] [pulsar] timmyyuan edited a comment on pull request #12543: [branch-2.8] Remove pulsar-dashboard from the publish process of pulsar images

2021-10-29 Thread GitBox
timmyyuan edited a comment on pull request #12543: URL: https://github.com/apache/pulsar/pull/12543#issuecomment-955150544 I find pulsar-standalone also depends on pulsar-dashboard, should we remove pulsar-standalone in this branch? @hangc0276 @merlimat -- This is an automated message f

[GitHub] [pulsar] timmyyuan commented on pull request #12543: [branch-2.8] Remove pulsar-dashboard from the publish process of pulsar images

2021-10-29 Thread GitBox
timmyyuan commented on pull request #12543: URL: https://github.com/apache/pulsar/pull/12543#issuecomment-955150544 I find pulsar-standalone also depends on pulsar-dashboard, should we also remove pulsar-standalone in this branch? @hangc0276 @merlimat -- This is an automated message fro

[GitHub] [pulsar] timmyyuan opened a new pull request #12543: [branch-2.8] Remove pulsar-dashboard from the publish process of pulsar images

2021-10-29 Thread GitBox
timmyyuan opened a new pull request #12543: URL: https://github.com/apache/pulsar/pull/12543 ### Motivation Remove pulsar-dashboard image from the publish process of pulsar images since it had been removed from branch-2.8. See also https://github.com/apache/pulsar/pull/112

[GitHub] [pulsar] lordcheng10 commented on pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-29 Thread GitBox
lordcheng10 commented on pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#issuecomment-955139404 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] tomscut commented on a change in pull request #12531: Optimize resourcegroup test, make test separately and readable

2021-10-29 Thread GitBox
tomscut commented on a change in pull request #12531: URL: https://github.com/apache/pulsar/pull/12531#discussion_r739603404 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ResourceGroup.java ## @@ -20,7 +20,8 @@ import lombok.Data

[GitHub] [pulsar] lordcheng10 closed pull request #12332: Flaky-test:PulsarServiceTest.testAppliedAdvertised

2021-10-29 Thread GitBox
lordcheng10 closed pull request #12332: URL: https://github.com/apache/pulsar/pull/12332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] lordcheng10 commented on pull request #12430: remove unused filed

2021-10-29 Thread GitBox
lordcheng10 commented on pull request #12430: URL: https://github.com/apache/pulsar/pull/12430#issuecomment-955139193 @eolivelli PTAL ,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 removed a comment on pull request #12430: remove unused filed

2021-10-29 Thread GitBox
lordcheng10 removed a comment on pull request #12430: URL: https://github.com/apache/pulsar/pull/12430#issuecomment-949769327 > I would prefer to drop the `authenticateOriginalAuthData` field. it is useless and we are using memory for something that is to be used only during connection set

[GitHub] [pulsar] lordcheng10 commented on pull request #12527: The count of topics on the bundle is less than 2,skip split

2021-10-29 Thread GitBox
lordcheng10 commented on pull request #12527: URL: https://github.com/apache/pulsar/pull/12527#issuecomment-955139044 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #12527: The count of topics on the bundle is less than 2,skip split

2021-10-29 Thread GitBox
lordcheng10 edited a comment on pull request #12527: URL: https://github.com/apache/pulsar/pull/12527#issuecomment-954605560 > Can this topics equal to zero? Topic and bundle are mapped through hash, so I understand that there may be no topic in a bundle -- This is an automate

[GitHub] [pulsar] github-actions[bot] commented on pull request #12542: [docs] Fix doc for pulsar-admin bookies cmd

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12542: URL: https://github.com/apache/pulsar/pull/12542#issuecomment-955134706 @tomscut:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] tomscut opened a new pull request #12542: [docs] Fix doc for pulsar-admin bookies cmd

2021-10-29 Thread GitBox
tomscut opened a new pull request #12542: URL: https://github.com/apache/pulsar/pull/12542 ### Motivation *Fix doc for pulsar-admin bookies command.* ### Modifications *Fix doc for pulsar-admin bookies command.* ### Does this pull request potentially affect on

[GitHub] [pulsar] Jason918 commented on a change in pull request #12536: [pulsar-broker] Broker extensions to allow operators of enterprise wide cluster better control and flexibility

2021-10-29 Thread GitBox
Jason918 commented on a change in pull request #12536: URL: https://github.com/apache/pulsar/pull/12536#discussion_r739596906 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -1008,6 +1008,11 @@ ) private boole

[GitHub] [pulsar] github-actions[bot] commented on pull request #12541: [pulsar-broker] Add git branch information for PulsarVersion

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12541: URL: https://github.com/apache/pulsar/pull/12541#issuecomment-955125606 @tomscut:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] tomscut opened a new pull request #12541: [pulsar-broker] Add git branch information for PulsarVersion

2021-10-29 Thread GitBox
tomscut opened a new pull request #12541: URL: https://github.com/apache/pulsar/pull/12541 ### Motivation *To make it easier to trace the code, we can print git branch information when the broker starts.* ### Modifications *Add a method PulsarVersion#getGitBranch, a

[pulsar] branch branch-2.7 updated: Remove pulsar-dashboard from the publish process since its image already was removed from branch-2.7 (#12534)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 81fe6b6 Remove pulsar-dashboard from th

[pulsar] branch master updated: Websocket should pass the encryption context to the consumers (#12539)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d20efe5 Websocket should pass the encryption co

[GitHub] [pulsar] merlimat merged pull request #12534: [Branch-2.7]Remove pulsar-dashboard from the publish process of images

2021-10-29 Thread GitBox
merlimat merged pull request #12534: URL: https://github.com/apache/pulsar/pull/12534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat merged pull request #12539: Websocket should pass the encryption context to the consumers

2021-10-29 Thread GitBox
merlimat merged pull request #12539: URL: https://github.com/apache/pulsar/pull/12539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat closed issue #10021: Websocket Encryption

2021-10-29 Thread GitBox
merlimat closed issue #10021: URL: https://github.com/apache/pulsar/issues/10021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[pulsar] branch master updated: [Python Client] Python client support using custom Avro schema definition (#12516)

2021-10-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 85575f4 [Python Client] Python client support

[GitHub] [pulsar] codelipenghui merged pull request #12516: [Python Client] Python client support using custom Avro schema definition

2021-10-29 Thread GitBox
codelipenghui merged pull request #12516: URL: https://github.com/apache/pulsar/pull/12516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] merlimat opened a new pull request #12540: Fixed flaky test in LocalMemoryMetadataStoreTest

2021-10-29 Thread GitBox
merlimat opened a new pull request #12540: URL: https://github.com/apache/pulsar/pull/12540 ### Motivation A recently added test has been failing on and off based on a cache invalidation race condition: ``` Error: testSharedInstance(org.apache.pulsar.metadata.LocalMemoryM

[pulsar] branch master updated: [Modernizer]Add Maven Modernizer plugin in pulsar-common module and fix violation. (#12270)

2021-10-29 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 56fee92 [Modernizer]Add Maven Modernizer plugi

[GitHub] [pulsar] codelipenghui merged pull request #12270: [Modernizer]Add Maven Modernizer plugin in pulsar-common module and fix violation.

2021-10-29 Thread GitBox
codelipenghui merged pull request #12270: URL: https://github.com/apache/pulsar/pull/12270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] merlimat opened a new pull request #12539: Websocket should pass the encryption context to the consumers

2021-10-29 Thread GitBox
merlimat opened a new pull request #12539: URL: https://github.com/apache/pulsar/pull/12539 ### Motivation Fix: #10021 #11197 Websocket service should provide the encryption context to its consumers, so that they can perform manual decryption of the message payloads. An

[GitHub] [pulsar] michaeljmarshall edited a comment on pull request #12103: Fixed used after recycle issue in OpAddEntry

2021-10-29 Thread GitBox
michaeljmarshall edited a comment on pull request #12103: URL: https://github.com/apache/pulsar/pull/12103#issuecomment-955067842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pulsar] michaeljmarshall commented on pull request #12103: Fixed used after recycle issue in OpAddEntry

2021-10-29 Thread GitBox
michaeljmarshall commented on pull request #12103: URL: https://github.com/apache/pulsar/pull/12103#issuecomment-955067842 @merlimat - I just ran into this NPE running 2.8.0. I am investigating a report of messages persisted out of order. Do you think this NPE could lead to such behavior?

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12425: Apache Pulsar 2.9.0 release notes

2021-10-29 Thread GitBox
michaeljmarshall commented on a change in pull request #12425: URL: https://github.com/apache/pulsar/pull/12425#discussion_r739465614 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,439 @@ ## Apache Pulsar Release Notes +### 2.9.0 — 2021-06-12 + +### News and n

[GitHub] [pulsar] github-actions[bot] commented on pull request #12536: [pulsar-broker] Broker extensions to allow operators of enterprise wide cluster better control and flexibility

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12536: URL: https://github.com/apache/pulsar/pull/12536#issuecomment-954973757 @madhavan-narayanan:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar] branch master updated: [Website] Remove timestamp from generated Javadoc HTML files (#12538)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0b34e03 [Website] Remove timestamp from generat

[GitHub] [pulsar] michaeljmarshall commented on pull request #12302: reset-cursor support earliest or latest

2021-10-29 Thread GitBox
michaeljmarshall commented on pull request #12302: URL: https://github.com/apache/pulsar/pull/12302#issuecomment-954968999 @k2la or @BewareMyPower - are you able to merge this PR? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] merlimat merged pull request #12538: [Website] Remove timestamp from generated Javadoc HTML files

2021-10-29 Thread GitBox
merlimat merged pull request #12538: URL: https://github.com/apache/pulsar/pull/12538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch branch-2.8 updated: Fix the batch message ack for WebSocket proxy. (#12530)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new aa09ac4 Fix the batch message ack for W

[pulsar] 02/02: Fix the batch message ack for WebSocket proxy. (#12530)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 08d24455a5899145dde3d8438e2760b3959515b9 Author: lipenghui AuthorDate: Sat Oct 30 01:53:27 2021 +0800 Fix the b

[pulsar] 01/02: Add debug log for WebSocket. (#12458)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit fe4bc9af39022cab75fb1677eff231285c6ad5fa Author: lipenghui AuthorDate: Fri Oct 22 14:57:05 2021 +0800 Add debug

[pulsar] branch branch-2.9 updated (c7157da -> 08d2445)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c7157da Release 2.9.0 new fe4bc9a Add debug log for WebSocket. (#12458) new 08d2445 Fix the batch me

[pulsar] branch master updated (52dffda -> dfe0247)

2021-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 52dffda [website][upgrade]feat: docs migration - version-2.7.2 Pulsar IO (#12394) add dfe0247 Fix the batch m

[GitHub] [pulsar] merlimat merged pull request #12530: Fix the batch message ack for WebSocket proxy.

2021-10-29 Thread GitBox
merlimat merged pull request #12530: URL: https://github.com/apache/pulsar/pull/12530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat commented on issue #12537: The .get directory takes up 1.42G of disk space

2021-10-29 Thread GitBox
merlimat commented on issue #12537: URL: https://github.com/apache/pulsar/issues/12537#issuecomment-954859813 Thanks @brucelwl for bringing this up. Most of the space is actually kept for the `asf-site` branch where we have automated updates for the website. Part of the issue is rel

[GitHub] [pulsar] zbentley edited a comment on issue #12293: ERROR: Could not find a version that satisfies the requirement pulsar-client==2.8.1

2021-10-29 Thread GitBox
zbentley edited a comment on issue #12293: URL: https://github.com/apache/pulsar/issues/12293#issuecomment-954837437 This is also affecting my users. When possible, please either: - Publish binary releases for the Python client on all currently supported versions of Python (severa

[GitHub] [pulsar] zbentley commented on issue #12293: ERROR: Could not find a version that satisfies the requirement pulsar-client==2.8.1

2021-10-29 Thread GitBox
zbentley commented on issue #12293: URL: https://github.com/apache/pulsar/issues/12293#issuecomment-954837437 This is also affecting my users. When possible, please either: - Publish binary releases for the Python client on all currently supported versions of Python (several are m

[GitHub] [pulsar] merlimat opened a new pull request #12538: [Website] Remove timestamp from generated Javadoc HTML files

2021-10-29 Thread GitBox
merlimat opened a new pull request #12538: URL: https://github.com/apache/pulsar/pull/12538 ### Motivation Each time the the website build runs, we're generating a big commit in the `asf-site` branch in this repo where each HTML file for Javadoc has 2 lines changed where the timesta

[GitHub] [pulsar] nodece commented on issue #12529: How to use custom ports when installing pulsar?

2021-10-29 Thread GitBox
nodece commented on issue #12529: URL: https://github.com/apache/pulsar/issues/12529#issuecomment-954815464 It is works: ```shell $ docker run -it \ -p 6650:6650 \ -p 8080:8080 \ --mount source=pulsardata,target=/pulsar/data \ --mount source=pulsarconf,target=/pulsa

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #651: fix issue 650,different handle sequence value

2021-10-29 Thread GitBox
cckellogg commented on a change in pull request #651: URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r739268503 ## File path: pulsar/producer_partition.go ## @@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendRece

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #651: fix issue 650,different handle sequence value

2021-10-29 Thread GitBox
cckellogg commented on a change in pull request #651: URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r739268503 ## File path: pulsar/producer_partition.go ## @@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendRece

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #651: fix issue 650,different handle sequence value

2021-10-29 Thread GitBox
cckellogg commented on a change in pull request #651: URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r739268503 ## File path: pulsar/producer_partition.go ## @@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendRece

[GitHub] [pulsar] yuruguo removed a comment on pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-10-29 Thread GitBox
yuruguo removed a comment on pull request #12535: URL: https://github.com/apache/pulsar/pull/12535#issuecomment-954764518 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-10-29 Thread GitBox
yuruguo commented on pull request #12535: URL: https://github.com/apache/pulsar/pull/12535#issuecomment-954764518 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] brucelwl opened a new issue #12537: The .get directory takes up 1.42G of disk space

2021-10-29 Thread GitBox
brucelwl opened a new issue #12537: URL: https://github.com/apache/pulsar/issues/12537 After downloading the source code from GitHub, the ``.git`` directory took up ``1.42G`` of disk space ![image](https://user-images.githubusercontent.com/13413715/139439408-1d352537-01f7-4175-bcaf-

[GitHub] [pulsar] github-actions[bot] commented on pull request #12536: [pulsar-broker] Broker extensions to allow operators of enterprise wide cluster better control and flexibility

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12536: URL: https://github.com/apache/pulsar/pull/12536#issuecomment-954719223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] github-actions[bot] commented on pull request #12536: [pulsar-broker]

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12536: URL: https://github.com/apache/pulsar/pull/12536#issuecomment-954716943 @madhavan-narayanan:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] madhavan-narayanan opened a new pull request #12536: [pulsar-broker]

2021-10-29 Thread GitBox
madhavan-narayanan opened a new pull request #12536: URL: https://github.com/apache/pulsar/pull/12536 ### Motivation Operators of enterprise Pulsar cluster(s) would need the flexibility and control to intercept broker events (including ledger writes/reads) for template valid

[GitHub] [pulsar] github-actions[bot] commented on pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12535: URL: https://github.com/apache/pulsar/pull/12535#issuecomment-954709656 @yuruguo:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo opened a new pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-10-29 Thread GitBox
yuruguo opened a new pull request #12535: URL: https://github.com/apache/pulsar/pull/12535 ### Motivation Add `--all` option to get all version schema of topic when we use CLI `./bin/pulsar-admin schemas get tenant/ns/tp` ### Documentation - [x] `no-need-doc`

[GitHub] [pulsar] timmyyuan opened a new pull request #12534: Remove pulsar-dashboard from the publish process of images

2021-10-29 Thread GitBox
timmyyuan opened a new pull request #12534: URL: https://github.com/apache/pulsar/pull/12534 ### Motivation Remove pulsar-dashboard from the publish process of images, since its image have been removed from branch-2.7 ### Documentation Check the box

[GitHub] [pulsar] Shoothzj commented on pull request #12531: Optimize resourcegroup test, make test separately and readable

2021-10-29 Thread GitBox
Shoothzj commented on pull request #12531: URL: https://github.com/apache/pulsar/pull/12531#issuecomment-954669748 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] TiBarification commented on issue #9731: Pulsar C++ Client Library not working on Alpine Linux

2021-10-29 Thread GitBox
TiBarification commented on issue #9731: URL: https://github.com/apache/pulsar/issues/9731#issuecomment-954661493 > `docker/alpine/Dockerfile` fails to build > > ``` > > [10/11] RUN pip3 install wheel twine: > #13 0.904 Collecting wheel > #13 0.930 Downloading wheel-0.36.2

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #12527: The count of topics on the bundle is less than 2,skip split

2021-10-29 Thread GitBox
lordcheng10 edited a comment on pull request #12527: URL: https://github.com/apache/pulsar/pull/12527#issuecomment-954605560 > Can this topics equal to zero? Topic and bundle are mapped through hash, so I understand that there may be no topic in a bundle @Shoothzj -- This is a

[GitHub] [pulsar] lordcheng10 commented on pull request #12527: The count of topics on the bundle is less than 2,skip split

2021-10-29 Thread GitBox
lordcheng10 commented on pull request #12527: URL: https://github.com/apache/pulsar/pull/12527#issuecomment-954605560 > Can this topics equal to zero? Topic and bundle are mapped through hash, so I understand that there may be no topic in a bundle -- This is an automated message f

[GitHub] [pulsar] sijia-w commented on pull request #10817: [docs] Incorrect use of subscription mode versus type

2021-10-29 Thread GitBox
sijia-w commented on pull request #10817: URL: https://github.com/apache/pulsar/pull/10817#issuecomment-954581052 @Anonymitaet Sure. Will do. @BewareMyPower Regarding subscription mode, do we want to have a bit more detailed info? or [here](https://github.com/apache/pulsar/pull/10817#issue

[GitHub] [pulsar] hepyu opened a new issue #12533: bookie entry的p999写入时间达到5秒可能是什么原因?

2021-10-29 Thread GitBox
hepyu opened a new issue #12533: URL: https://github.com/apache/pulsar/issues/12533 前提:3台8c16g的pulsar集群 现象&问题:一个节点的entry的写入P999达到5秒,且持续至少30秒。而其他两个节点的写入是正常的,有可能是什么原因呢? ![image](https://user-images.githubusercontent.com/3917749/139403345-40bae858-fef9-4a8e-a662-57f11d47996f.png)

[GitHub] [pulsar] sijia-w commented on pull request #12532: [DOCS] Update the description

2021-10-29 Thread GitBox
sijia-w commented on pull request #12532: URL: https://github.com/apache/pulsar/pull/12532#issuecomment-954508766 @congbobo184 @Anonymitaet Please help review the changes. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on pull request #12532: [DOCS] Update the description

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12532: URL: https://github.com/apache/pulsar/pull/12532#issuecomment-954508428 @sijia-w:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] sijia-w opened a new pull request #12532: [DOCS] Update the description

2021-10-29 Thread GitBox
sijia-w opened a new pull request #12532: URL: https://github.com/apache/pulsar/pull/12532 This pr aims at fixing #https://github.com/apache/pulsar/pull/10475. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] sijia-w commented on pull request #10475: [Documentation] Improve transaction-api.md

2021-10-29 Thread GitBox
sijia-w commented on pull request #10475: URL: https://github.com/apache/pulsar/pull/10475#issuecomment-954499989 @congbobo184 Sure. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] github-actions[bot] commented on pull request #12531: Optimize resourcegroup test, make test separately and readable

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12531: URL: https://github.com/apache/pulsar/pull/12531#issuecomment-954494832 @Shoothzj:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar] github-actions[bot] commented on pull request #12531: Optimize resourcegroup test, make test separately and readable

2021-10-29 Thread GitBox
github-actions[bot] commented on pull request #12531: URL: https://github.com/apache/pulsar/pull/12531#issuecomment-954494712 @Shoothzj:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/

[GitHub] [pulsar] Shoothzj opened a new pull request #12531: Optimize resourcegroup test, make test separately and readable

2021-10-29 Thread GitBox
Shoothzj opened a new pull request #12531: URL: https://github.com/apache/pulsar/pull/12531 ### Motivation I'm working on #12499, need to modify the corresponding tests. But currently, these test files are hard to read. - Some unused method - lowercase ClassName and typos - Test

[GitHub] [pulsar] Shoothzj commented on pull request #12527: The count of topics on the bundle is less than 2,skip split

2021-10-29 Thread GitBox
Shoothzj commented on pull request #12527: URL: https://github.com/apache/pulsar/pull/12527#issuecomment-954493180 Can this topics equal to zero? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui opened a new pull request #12530: Fix the batch message ack for WebSocket proxy.

2021-10-29 Thread GitBox
codelipenghui opened a new pull request #12530: URL: https://github.com/apache/pulsar/pull/12530 The WebSocket proxy uses the consumer instance to process the message acknowledgment. But for the batch message acknowledgment, the batch message instance that deserialized from WebSocket pr