[GitHub] [pulsar] 315157973 commented on pull request #12581: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
315157973 commented on pull request #12581: URL: https://github.com/apache/pulsar/pull/12581#issuecomment-957146006 > Sorry, the [PR](https://github.com/apache/pulsar/pull/12315/files#diff-c349b18c29ddc6c10d7665a454c001515325943ea1f3315d07b3155f50b1ccafL337) I submitted has covered this pr

[GitHub] [pulsar] Jason918 commented on pull request #12496: [Issue #12495] Fix the serialization time attribute is not allowed to be empty by default

2021-11-01 Thread GitBox
Jason918 commented on pull request #12496: URL: https://github.com/apache/pulsar/pull/12496#issuecomment-957132999 > > > > Great doc and user can define the custom `Serialization` following your doc if they have special requirements. But I am wondering if changing the default setup would b

[GitHub] [pulsar] Raven888888 commented on issue #12455: PulsarClientException$BrokerMetadataException error reoccurs in release 2.8.1

2021-11-01 Thread GitBox
Raven88 commented on issue #12455: URL: https://github.com/apache/pulsar/issues/12455#issuecomment-957132532 Nope @BewareMyPower . That issue only happens in pulsar + kop 2.7.0, and it is due to how kop handles offset calculation as you mentioned. Once upgraded to 2.8.1, I have not see

[GitHub] [pulsar] wolfstudy commented on pull request #12566: Add negative ack redelivery backoff.

2021-11-01 Thread GitBox
wolfstudy commented on pull request #12566: URL: https://github.com/apache/pulsar/pull/12566#issuecomment-957128639 ping @codelipenghui PTAL again, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Jason918 commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

2021-11-01 Thread GitBox
Jason918 commented on pull request #12582: URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957125141 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Anonymitaet commented on pull request #10817: [docs] Incorrect use of subscription mode versus type

2021-11-01 Thread GitBox
Anonymitaet commented on pull request #10817: URL: https://github.com/apache/pulsar/pull/10817#issuecomment-957115133 Fixed in https://github.com/apache/pulsar/pull/12548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[pulsar] branch master updated (74dd9b9 -> e5380b3)

2021-11-01 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 74dd9b9 Fix the reader skips compacted data which original ledger been removed (#12522) add e5380b3 correction

[GitHub] [pulsar] Anonymitaet merged pull request #12548: [DOCS] [ISSUE 10817] A correction of "subscription type"

2021-11-01 Thread GitBox
Anonymitaet merged pull request #12548: URL: https://github.com/apache/pulsar/pull/12548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] BewareMyPower commented on issue #12455: PulsarClientException$BrokerMetadataException error reoccurs in release 2.8.1

2021-11-01 Thread GitBox
BewareMyPower commented on issue #12455: URL: https://github.com/apache/pulsar/issues/12455#issuecomment-957104519 > upgrading from pulsar 2.7.0 to 2.8.1 Is it the similar issue like https://github.com/streamnative/kop/issues/765? -- This is an automated message from the Apache Git

[GitHub] [pulsar] thomasleplus commented on pull request #12581: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
thomasleplus commented on pull request #12581: URL: https://github.com/apache/pulsar/pull/12581#issuecomment-957103665 > Sorry, the [PR](https://github.com/apache/pulsar/pull/12315/files#diff-c349b18c29ddc6c10d7665a454c001515325943ea1f3315d07b3155f50b1ccafL337) I submitted has covered thi

[GitHub] [pulsar] Raven888888 commented on issue #12455: PulsarClientException$BrokerMetadataException error reoccurs in release 2.8.1

2021-11-01 Thread GitBox
Raven88 commented on issue #12455: URL: https://github.com/apache/pulsar/issues/12455#issuecomment-957103372 KoP: 2.8.1.4 I faced this issue after upgrading from pulsar 2.7.0 to 2.8.1. Will try to reproduce when I have the capacity. -- This is an automated message from the Apache

[GitHub] [pulsar] yuruguo commented on pull request #12512: [pulsar-admin] Check backlog quota policy for namespace

2021-11-01 Thread GitBox
yuruguo commented on pull request #12512: URL: https://github.com/apache/pulsar/pull/12512#issuecomment-957102513 Please take a look again, thanks :) @eolivelli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] yuruguo commented on pull request #12581: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
yuruguo commented on pull request #12581: URL: https://github.com/apache/pulsar/pull/12581#issuecomment-957101294 Sorry, the [PR](https://github.com/apache/pulsar/pull/12315/files#diff-c349b18c29ddc6c10d7665a454c001515325943ea1f3315d07b3155f50b1ccafL337) I submitted has covered this probl

[GitHub] [pulsar] Technoboy- opened a new pull request #12583: [pulsar-broker] Cleanup already deleted namespace topics.

2021-11-01 Thread GitBox
Technoboy- opened a new pull request #12583: URL: https://github.com/apache/pulsar/pull/12583 ### Motivation We are having frequent issues when user removes cluster from the global namespace where broker from removed-cluster fails to unload topic and namespace bundle still loaded with t

[pulsar] branch master updated: Fix the reader skips compacted data which original ledger been removed (#12522)

2021-11-01 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 74dd9b9 Fix the reader skips compacted data whi

[GitHub] [pulsar] merlimat merged pull request #12522: Fix the reader skips compacted data which original ledger been removed

2021-11-01 Thread GitBox
merlimat merged pull request #12522: URL: https://github.com/apache/pulsar/pull/12522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] github-actions[bot] commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12582: URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957091503 @Jason918:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar] Jason918 opened a new pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

2021-11-01 Thread GitBox
Jason918 opened a new pull request #12582: URL: https://github.com/apache/pulsar/pull/12582 ### Motivation The log of `org.apache.pulsar.broker.namespace.NamespaceService#checkHeartbeatNamespace` and `org.apache.pulsar.broker.namespace.NamespaceService#checkHeartbeatNamesp

[GitHub] [pulsar] BewareMyPower commented on issue #12455: PulsarClientException$BrokerMetadataException error reoccurs in release 2.8.1

2021-11-01 Thread GitBox
BewareMyPower commented on issue #12455: URL: https://github.com/apache/pulsar/issues/12455#issuecomment-957086696 Could you provide your KoP version? And can you reproduce it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Raven888888 commented on issue #12465: Pulsar SQL NullPointerException when select a row produced by go client with schema

2021-11-01 Thread GitBox
Raven88 commented on issue #12465: URL: https://github.com/apache/pulsar/issues/12465#issuecomment-957084389 Related issue: #12284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[pulsar] branch master updated (409239c -> df6d5f5)

2021-11-01 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 409239c [ML] Add OpAddEntry to pendingAddEntries after the state check (#12570) add df6d5f5 [DOCS] Update the

[GitHub] [pulsar] Anonymitaet merged pull request #12532: [DOCS] Update the description

2021-11-01 Thread GitBox
Anonymitaet merged pull request #12532: URL: https://github.com/apache/pulsar/pull/12532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] Raven888888 commented on issue #12568: KOP getOffsetOfPosition failed ( Invalid unknonwn tag type: 6 )

2021-11-01 Thread GitBox
Raven88 commented on issue #12568: URL: https://github.com/apache/pulsar/issues/12568#issuecomment-957083303 Possibly same Invalid unknonwn tag type: 6 error in #12455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[pulsar] branch master updated (a95a382 -> 409239c)

2021-11-01 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a95a382 Cancel scheduled tasks when deleting ManagedLedgerImpl (#12565) add 409239c [ML] Add OpAddEntry to pe

[GitHub] [pulsar] github-actions[bot] commented on pull request #12581: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12581: URL: https://github.com/apache/pulsar/pull/12581#issuecomment-957081310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] merlimat merged pull request #12570: [ML] Add OpAddEntry to pendingAddEntries after the state check

2021-11-01 Thread GitBox
merlimat merged pull request #12570: URL: https://github.com/apache/pulsar/pull/12570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
thomasleplus commented on pull request #12082: URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957079068 Sure, here you go: #12581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] BewareMyPower commented on issue #12568: KOP getOffsetOfPosition failed ( Invalid unknonwn tag type: 6 )

2021-11-01 Thread GitBox
BewareMyPower commented on issue #12568: URL: https://github.com/apache/pulsar/issues/12568#issuecomment-957079024 > > potential retries in managed ledger. > > what is the exact behaviour here? See #12018 and `ManagedLedgerImpl#updateLedgersIdsComplete`. But I'm not sure wheth

[GitHub] [pulsar] github-actions[bot] commented on pull request #12581: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12581: URL: https://github.com/apache/pulsar/pull/12581#issuecomment-957078631 @thomasleplus:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/b

[GitHub] [pulsar] thomasleplus opened a new pull request #12581: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
thomasleplus opened a new pull request #12581: URL: https://github.com/apache/pulsar/pull/12581 This line was actually assigning the method argument to itself instead of setting the static field of the same name. ### Motivation Fix a simple mistake. ### Modification

[GitHub] [pulsar] aloyszhang commented on issue #12568: KOP getOffsetOfPosition failed ( Invalid unknonwn tag type: 6 )

2021-11-01 Thread GitBox
aloyszhang commented on issue #12568: URL: https://github.com/apache/pulsar/issues/12568#issuecomment-957076384 > potential retries in managed ledger. what is the exact behaviour here? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
315157973 commented on pull request #12082: URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957075256 > > @thomasleplus Sorry, I closed this PR by mistake, could you please open it again? > > GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their

[GitHub] [pulsar] thomasleplus commented on pull request #12082: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
thomasleplus commented on pull request #12082: URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957072441 > @thomasleplus Sorry, I closed this PR by mistake, could you please open it again? GitHub doesn't let me because I've deleted my fork repo. My bad. Maybe their su

[GitHub] [pulsar-client-go] wolfstudy commented on issue #652: Fix Godoc

2021-11-01 Thread GitBox
wolfstudy commented on issue #652: URL: https://github.com/apache/pulsar-client-go/issues/652#issuecomment-957058144 Thanks @flowchartsman and sounds good, If you are interested, welcome to send a pr to fix this problem. -- This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar-client-go] wolfstudy opened a new issue #658: Support nack backoff policy for Go SDK

2021-11-01 Thread GitBox
wolfstudy opened a new issue #658: URL: https://github.com/apache/pulsar-client-go/issues/658 In [PIP-106](https://github.com/apache/pulsar/issues/12379), we introduce the nack backoff policy and the java impl refer to https://github.com/apache/pulsar/pull/12566. In Go SDK, we need

[GitHub] [pulsar-client-go] wolfstudy edited a comment on issue #657: Consumer need to support commulated ack type to reducer 'acknowledgment holes'

2021-11-01 Thread GitBox
wolfstudy edited a comment on issue #657: URL: https://github.com/apache/pulsar-client-go/issues/657#issuecomment-957054628 @baomingyu Commulated ack does not actually bring much performance improvement, but will increase the complexity of the current Go SDK implementation. Therefore, we

[GitHub] [pulsar-client-go] wolfstudy commented on issue #657: Consumer need to support commulated ack type to reducer 'acknowledgment holes'

2021-11-01 Thread GitBox
wolfstudy commented on issue #657: URL: https://github.com/apache/pulsar-client-go/issues/657#issuecomment-957054628 @baomingyu Batch ack does not actually bring much performance improvement, but will increase the complexity of the current Go SDK implementation. Therefore, we deliberately

[GitHub] [pulsar] 315157973 commented on pull request #12233: [Python] Allow required=False default=None setting on fields

2021-11-01 Thread GitBox
315157973 commented on pull request #12233: URL: https://github.com/apache/pulsar/pull/12233#issuecomment-957054506 @merlimat PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar] 315157973 commented on pull request #12173: Adding Multi-tiered storage key to broker.conf

2021-11-01 Thread GitBox
315157973 commented on pull request #12173: URL: https://github.com/apache/pulsar/pull/12173#issuecomment-957054298 @MMirelli Hello, It looks like your branch has been deleted and CI cannot be completed -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] 315157973 commented on pull request #12082: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
315157973 commented on pull request #12082: URL: https://github.com/apache/pulsar/pull/12082#issuecomment-957051186 @thomasleplus Sorry, I closed this PR by mistake, could you please open it again? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar] 315157973 closed pull request #12082: PulsarAdmin: Fix last exit code storage

2021-11-01 Thread GitBox
315157973 closed pull request #12082: URL: https://github.com/apache/pulsar/pull/12082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] BewareMyPower commented on issue #12564: C + + client supports class programming

2021-11-01 Thread GitBox
BewareMyPower commented on issue #12564: URL: https://github.com/apache/pulsar/issues/12564#issuecomment-957046945 > the client and producer of C + + client do not support defining variables as class members Why not? Please paste the compilation error. I guess it's because `Client`

[GitHub] [pulsar] github-actions[bot] commented on pull request #12580: [website][upgrade]feat: docs migration - 2.7.1 / helm

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12580: URL: https://github.com/apache/pulsar/pull/12580#issuecomment-957039412 @urfreespace:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] urfreespace opened a new pull request #12580: [website][upgrade]feat: docs migration - 2.7.1 / helm

2021-11-01 Thread GitBox
urfreespace opened a new pull request #12580: URL: https://github.com/apache/pulsar/pull/12580 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] github-actions[bot] commented on pull request #12579: [website][upgrade]feat: docs migration - 2.7.1 / transaction

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12579: URL: https://github.com/apache/pulsar/pull/12579#issuecomment-957039041 @urfreespace:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] urfreespace opened a new pull request #12579: [website][upgrade]feat: docs migration - 2.7.1 / transaction

2021-11-01 Thread GitBox
urfreespace opened a new pull request #12579: URL: https://github.com/apache/pulsar/pull/12579 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] BewareMyPower commented on issue #12568: KOP getOffsetOfPosition failed ( Invalid unknonwn tag type: 6 )

2021-11-01 Thread GitBox
BewareMyPower commented on issue #12568: URL: https://github.com/apache/pulsar/issues/12568#issuecomment-957038666 Please also take a look when you have time. @Demogorgon314 @aloyszhang I think it's likely to be caused by the failure of `PersistentTopic#publishMessage` and potential

[GitHub] [pulsar] github-actions[bot] commented on pull request #12578: [website][upgrade]feat: docs migration - 2.7.1 / tiered-storage

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12578: URL: https://github.com/apache/pulsar/pull/12578#issuecomment-957038663 @urfreespace:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] urfreespace opened a new pull request #12578: [website][upgrade]feat: docs migration - 2.7.1 / tiered-storage

2021-11-01 Thread GitBox
urfreespace opened a new pull request #12578: URL: https://github.com/apache/pulsar/pull/12578 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] github-actions[bot] commented on pull request #12577: [website][upgrade]feat: docs migration - 2.7.1 / sql

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12577: URL: https://github.com/apache/pulsar/pull/12577#issuecomment-957037973 @urfreespace:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] urfreespace opened a new pull request #12577: [website][upgrade]feat: docs migration - 2.7.1 / sql

2021-11-01 Thread GitBox
urfreespace opened a new pull request #12577: URL: https://github.com/apache/pulsar/pull/12577 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] mingyifei commented on pull request #12496: [Issue #12495] Fix the serialization time attribute is not allowed to be empty by default

2021-11-01 Thread GitBox
mingyifei commented on pull request #12496: URL: https://github.com/apache/pulsar/pull/12496#issuecomment-957037486 > > > Great doc and user can define the custom `Serialization` following your doc if they have special requirements. But I am wondering if changing the default setup would br

[GitHub] [pulsar] github-actions[bot] commented on pull request #12576: [website][upgrade]feat: docs migration - 2.7.1 / io

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12576: URL: https://github.com/apache/pulsar/pull/12576#issuecomment-957037253 @urfreespace:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] urfreespace opened a new pull request #12576: [website][upgrade]feat: docs migration - 2.7.1 / io

2021-11-01 Thread GitBox
urfreespace opened a new pull request #12576: URL: https://github.com/apache/pulsar/pull/12576 Signed-off-by: LiLi *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to

[GitHub] [pulsar] BewareMyPower commented on issue #12568: KOP getOffsetOfPosition failed ( Invalid unknonwn tag type: 6 )

2021-11-01 Thread GitBox
BewareMyPower commented on issue #12568: URL: https://github.com/apache/pulsar/issues/12568#issuecomment-957036674 > 使用Kafka的API去获取Topic每个分区的消息first offset and last offset (handleListOffsetRequest getOffsetOfPosition) Please paste your code. Another question is, did you stop s

[GitHub] [pulsar] github-actions[bot] commented on pull request #12575: Feature/website next 20211102 4

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12575: URL: https://github.com/apache/pulsar/pull/12575#issuecomment-957034900 @urfreespace:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] urfreespace closed pull request #12575: Feature/website next 20211102 4

2021-11-01 Thread GitBox
urfreespace closed pull request #12575: URL: https://github.com/apache/pulsar/pull/12575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] urfreespace opened a new pull request #12575: Feature/website next 20211102 4

2021-11-01 Thread GitBox
urfreespace opened a new pull request #12575: URL: https://github.com/apache/pulsar/pull/12575 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] Jason918 commented on pull request #12496: [Issue #12495] Fix the serialization time attribute is not allowed to be empty by default

2021-11-01 Thread GitBox
Jason918 commented on pull request #12496: URL: https://github.com/apache/pulsar/pull/12496#issuecomment-957029321 > > Great doc and user can define the custom `Serialization` following your doc if they have special requirements. But I am wondering if changing the default setup would bring

[GitHub] [pulsar] liangyepianzhou commented on pull request #12521: [Transaction]Txn client check timeout

2021-11-01 Thread GitBox
liangyepianzhou commented on pull request #12521: URL: https://github.com/apache/pulsar/pull/12521#issuecomment-957022093 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-client-go] baomingyu commented on a change in pull request #651: fix issue 650,different handle sequence value

2021-11-01 Thread GitBox
baomingyu commented on a change in pull request #651: URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r740654111 ## File path: pulsar/producer_partition.go ## @@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendRece

[GitHub] [pulsar] yuruguo commented on pull request #12412: [pulsar-admin] Check validity of --actions for topic and namespace

2021-11-01 Thread GitBox
yuruguo commented on pull request #12412: URL: https://github.com/apache/pulsar/pull/12412#issuecomment-957006721 @merlimat @codelipenghui ptal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] yuruguo removed a comment on pull request #12412: [pulsar-admin] Check validity of --actions for topic and namespace

2021-11-01 Thread GitBox
yuruguo removed a comment on pull request #12412: URL: https://github.com/apache/pulsar/pull/12412#issuecomment-955836129 @aahmed-se @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] tomscut commented on pull request #12542: [docs] Fix doc for pulsar-admin bookies cmd

2021-11-01 Thread GitBox
tomscut commented on pull request #12542: URL: https://github.com/apache/pulsar/pull/12542#issuecomment-956948703 Hi @eolivelli @hangc0276 @codelipenghui , PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] tomscut commented on pull request #12544: Fix typo for LoadManagerShared#filterAntiAffinityGroupOwnedBrokers

2021-11-01 Thread GitBox
tomscut commented on pull request #12544: URL: https://github.com/apache/pulsar/pull/12544#issuecomment-956946062 Hi @eolivelli @codelipenghui @hangc0276 , PTAL. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] tomscut commented on pull request #12541: [pulsar-broker] Add git branch information for PulsarVersion

2021-11-01 Thread GitBox
tomscut commented on pull request #12541: URL: https://github.com/apache/pulsar/pull/12541#issuecomment-956940823 Hi @eolivelli @codelipenghui , could you please take a look. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] zbentley commented on issue #12556: Permanent namespace corruption after attempting to delete a namespace shortly after it was created and after all contained topics were deleted; br

2021-11-01 Thread GitBox
zbentley commented on issue #12556: URL: https://github.com/apache/pulsar/issues/12556#issuecomment-956856959 > If that induces a permanent inconsistency state, it's a bug that absolutely needs to get fixed. This specific issue is a permanent inconsistency. The others usually go away

[GitHub] [pulsar] branhoff edited a comment on issue #10596: Python client: broken/missing Avro schema support

2021-11-01 Thread GitBox
branhoff edited a comment on issue #10596: URL: https://github.com/apache/pulsar/issues/10596#issuecomment-956769752 Separate tickets filed for remaining issues: No support for `default` values: https://github.com/apache/pulsar/issues/12571 No support for `doc` attribute: https://

[GitHub] [pulsar] branhoff edited a comment on issue #10596: Python client: broken/missing Avro schema support

2021-11-01 Thread GitBox
branhoff edited a comment on issue #10596: URL: https://github.com/apache/pulsar/issues/10596#issuecomment-956769752 Separate tickets filed for remaining issues: No support for `default` values: https://github.com/apache/pulsar/issues/12571 No support for `doc` attribute: https://

[GitHub] [pulsar] branhoff commented on issue #10596: Python client: broken/missing Avro schema support

2021-11-01 Thread GitBox
branhoff commented on issue #10596: URL: https://github.com/apache/pulsar/issues/10596#issuecomment-956769752 Separate tickets filed for remaining issues: https://github.com/apache/pulsar/issues/12571 https://github.com/apache/pulsar/issues/12572 https://github.com/apache/pulsar

[GitHub] [pulsar] branhoff opened a new issue #12574: Python client: Ordering bug when generating schema definition that makes schema incompatible with topic's registered schema

2021-11-01 Thread GitBox
branhoff opened a new issue #12574: URL: https://github.com/apache/pulsar/issues/12574 **Describe the bug** When generating a schema definition with the same fields as a topic's registered schema, if the the generated schema is in a different order than the registered schema, will be la

[GitHub] [pulsar] branhoff opened a new issue #12573: Python client: No support for the namespace attribute

2021-11-01 Thread GitBox
branhoff opened a new issue #12573: URL: https://github.com/apache/pulsar/issues/12573 **Describe the bug** No support for `namespace` attribute **To Reproduce** Steps to reproduce the behavior: 1. Go to https://github.com/ta1meng/pulsar-python-avro-schema-examples 2.

[GitHub] [pulsar] branhoff opened a new issue #12572: Python client: No support for doc attribute

2021-11-01 Thread GitBox
branhoff opened a new issue #12572: URL: https://github.com/apache/pulsar/issues/12572 **Describe the bug** No support for `doc` attribute **To Reproduce** Steps to reproduce the behavior: 1. Go to https://github.com/ta1meng/pulsar-python-avro-schema-examples 2. Read t

[GitHub] [pulsar] branhoff opened a new issue #12571: Python client: No support for default values

2021-11-01 Thread GitBox
branhoff opened a new issue #12571: URL: https://github.com/apache/pulsar/issues/12571 **Describe the bug** No support for `default` values. **To Reproduce** Steps to reproduce the behavior: 1. Go to https://github.com/ta1meng/pulsar-python-avro-schema-examples 2. Read

[GitHub] [pulsar] github-actions[bot] commented on pull request #12570: [ML] Add OpAddEntry to pendingAddEntries after the state check

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12570: URL: https://github.com/apache/pulsar/pull/12570#issuecomment-956631839 @lhotari:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] github-actions[bot] commented on pull request #12570: [ML] Add OpAddEntry to pendingAddEntries after the state check

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12570: URL: https://github.com/apache/pulsar/pull/12570#issuecomment-956630095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lhotari opened a new pull request #12570: [ML] Add OpAddEntry to pendingAddEntries after the state check

2021-11-01 Thread GitBox
lhotari opened a new pull request #12570: URL: https://github.com/apache/pulsar/pull/12570 ### Motivation - when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately. ### Mod

[GitHub] [pulsar] eolivelli commented on a change in pull request #12569: [pulsar-perf] Write histogram files for consume command

2021-11-01 Thread GitBox
eolivelli commented on a change in pull request #12569: URL: https://github.com/apache/pulsar/pull/12569#discussion_r740534659 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java ## @@ -407,6 +410,16 @@ public static void main(St

[GitHub] [pulsar] eolivelli commented on issue #12508: [Java client] Deadlock in Message.getValue() if executed inside a Pulsar async callback, due to blocking download of the Schema

2021-11-01 Thread GitBox
eolivelli commented on issue #12508: URL: https://github.com/apache/pulsar/issues/12508#issuecomment-956587870 I will send a PR with the perfect implementation, maybe we will need a PIP as I will have to introduce some methods in the Schema API in order to execute the (async) prefetch ope

[GitHub] [pulsar] branhoff edited a comment on issue #10596: Python client: broken/missing Avro schema support

2021-11-01 Thread GitBox
branhoff edited a comment on issue #10596: URL: https://github.com/apache/pulsar/issues/10596#issuecomment-947972294 UPDATE ON BUG STATUS AFTER TESTING AGAINST PULSAR 2.7.2 and Pulsar 2.8.1: The documented [example](https://pulsar.apache.org/docs/fr/client-libraries-python/#complex-t

[GitHub] [pulsar] merlimat commented on issue #12556: Permanent namespace corruption after attempting to delete a namespace shortly after it was created and after all contained topics were deleted; br

2021-11-01 Thread GitBox
merlimat commented on issue #12556: URL: https://github.com/apache/pulsar/issues/12556#issuecomment-956498841 > The condition that caused these issues to occur appears to be interaction with various pulsar entities (e.g. creating/deleting things in the management API, or attempting to

[pulsar] branch master updated: Cancel scheduled tasks when deleting ManagedLedgerImpl (#12565)

2021-11-01 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a95a382 Cancel scheduled tasks when deleting Ma

[GitHub] [pulsar] merlimat merged pull request #12565: [broker] Cancel scheduled tasks when deleting ManagedLedgerImpl

2021-11-01 Thread GitBox
merlimat merged pull request #12565: URL: https://github.com/apache/pulsar/pull/12565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #651: fix issue 650,different handle sequence value

2021-11-01 Thread GitBox
cckellogg commented on a change in pull request #651: URL: https://github.com/apache/pulsar-client-go/pull/651#discussion_r740362853 ## File path: pulsar/producer_partition.go ## @@ -784,57 +784,57 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendRece

[GitHub] [pulsar] merlimat commented on a change in pull request #12569: [pulsar-perf] Write histogram files for consume command

2021-11-01 Thread GitBox
merlimat commented on a change in pull request #12569: URL: https://github.com/apache/pulsar/pull/12569#discussion_r740347475 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java ## @@ -407,6 +410,16 @@ public static void main(Str

[GitHub] [pulsar] mfleming commented on a change in pull request #12569: [pulsar-perf] Write histogram files for consume command

2021-11-01 Thread GitBox
mfleming commented on a change in pull request #12569: URL: https://github.com/apache/pulsar/pull/12569#discussion_r740341085 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java ## @@ -407,6 +410,16 @@ public static void main(Str

[GitHub] [pulsar] merlimat commented on a change in pull request #12569: [pulsar-perf] Write histogram files for consume command

2021-11-01 Thread GitBox
merlimat commented on a change in pull request #12569: URL: https://github.com/apache/pulsar/pull/12569#discussion_r740319567 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java ## @@ -407,6 +410,16 @@ public static void main(Str

[GitHub] [pulsar] merlimat commented on issue #12508: [Java client] Deadlock in Message.getValue() if executed inside a Pulsar async callback, due to blocking download of the Schema

2021-11-01 Thread GitBox
merlimat commented on issue #12508: URL: https://github.com/apache/pulsar/issues/12508#issuecomment-956342726 > But we should this to some longer term solutions because in theory we should not make any blocking call in getValue(), because reactive/non blocking frameworks may observe this u

[GitHub] [pulsar] github-actions[bot] commented on pull request #12569: [pulsar-perf] Write histogram files for consume command

2021-11-01 Thread GitBox
github-actions[bot] commented on pull request #12569: URL: https://github.com/apache/pulsar/pull/12569#issuecomment-956342038 @mfleming:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar] mfleming opened a new pull request #12569: [pulsar-perf] Write histogram files for consume command

2021-11-01 Thread GitBox
mfleming opened a new pull request #12569: URL: https://github.com/apache/pulsar/pull/12569 ### Motivation The `consume` command for `pulsar-perf` doesn't generate histogram file (`.hgrm` files) like its counterpart `produce` which makes it more difficult to automate col

[pulsar] branch master updated: Optimize Tests (#12560)

2021-11-01 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cb703ca Optimize Tests (#12560) cb703ca is desc

[GitHub] [pulsar] merlimat merged pull request #12560: [Transaction]Optimize the tests extends from TransactionTestBase

2021-11-01 Thread GitBox
merlimat merged pull request #12560: URL: https://github.com/apache/pulsar/pull/12560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] xiaotongwang1 opened a new issue #12568: KOP getOffsetOfPosition failed ( Invalid unknonwn tag type: 6 )

2021-11-01 Thread GitBox
xiaotongwang1 opened a new issue #12568: URL: https://github.com/apache/pulsar/issues/12568 **KOP :** 2021-11-01 23:00:47.810 [BookKeeperClientWorker-OrderedExecutor-4-0] ERROR i.s.pulsar.handlers.kop.KafkaRequestHandler - [PersistentTopic{topic=persistent://WiseCloudDMQService/WiseClou

[GitHub] [pulsar] Raven888888 commented on issue #12284: Pulsar SQL BufferUnderflowException after upgrading from 2.7.0 to 2.8.1

2021-11-01 Thread GitBox
Raven88 commented on issue #12284: URL: https://github.com/apache/pulsar/issues/12284#issuecomment-956307372 I have broker enabled with websocket service. ```webSocketServiceEnabled=true``` I am using python client WS [example](https://pulsar.apache.org/docs/en/client-librarie

[GitHub] [pulsar] gaoran10 commented on issue #12284: Pulsar SQL BufferUnderflowException after upgrading from 2.7.0 to 2.8.1

2021-11-01 Thread GitBox
gaoran10 commented on issue #12284: URL: https://github.com/apache/pulsar/issues/12284#issuecomment-956289288 It seems that the schema version of the message is null, which language client do messages come from? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] RobertIndie commented on a change in pull request #12132: [Broker] Fix prefix setting in JWT authn and avoid multi calls for the getProperty

2021-11-01 Thread GitBox
RobertIndie commented on a change in pull request #12132: URL: https://github.com/apache/pulsar/pull/12132#discussion_r740209089 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -54,7 +54,7 @@

[GitHub] [pulsar] RobertIndie commented on a change in pull request #12132: [Broker] Fix prefix setting in JWT authn and avoid multi calls for the getProperty

2021-11-01 Thread GitBox
RobertIndie commented on a change in pull request #12132: URL: https://github.com/apache/pulsar/pull/12132#discussion_r740209089 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -54,7 +54,7 @@

[pulsar] branch master updated (abf7114 -> a6960cd)

2021-11-01 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from abf7114 Miss put the SSL_TRUSTSTORE_LOCATION_CONFIG to SSL_TRUSTSTORE_PASSWORD in kafka sink (#12545) add a69

[GitHub] [pulsar] codelipenghui merged pull request #12531: Optimize resourcegroup test, make test separately and readable

2021-11-01 Thread GitBox
codelipenghui merged pull request #12531: URL: https://github.com/apache/pulsar/pull/12531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated: Miss put the SSL_TRUSTSTORE_LOCATION_CONFIG to SSL_TRUSTSTORE_PASSWORD in kafka sink (#12545)

2021-11-01 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new abf7114 Miss put the SSL_TRUSTSTORE_LOCATION_C

  1   2   >