Anonymitaet commented on issue #12637:
URL: https://github.com/apache/pulsar/issues/12637#issuecomment-962896130
@codelipenghui thanks for reminding me, I've corrected the URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Anonymitaet opened a new issue #12661:
URL: https://github.com/apache/pulsar/issues/12661
Design proposal, solution, implementation progress, and all details are
available
[here](https://docs.google.com/document/d/1O19v1znrNkoahFpsr8puVQ_20jDQfUjC2eRxdFOL91U/edit).
--
This is an automat
codelipenghui commented on pull request #12439:
URL: https://github.com/apache/pulsar/pull/12439#issuecomment-962891234
@jadireddi Could you please rebase your branch? #12270 already introduced
`maven-modernizer-plugin.version` in the pom.xml.
--
This is an automated message from the Ap
liangyepianzhou removed a comment on pull request #12636:
URL: https://github.com/apache/pulsar/pull/12636#issuecomment-962404540
There is a problem here:
When a NonRecoverableLedgerException appears, do we need to move the cusor
in the FillEntryQueueCallback of TransactionBufferd or dir
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from e476735 [Authorization] Support GET_METADATA topic op after enable
auth (#12656)
add 9b69069 [Modernizer] Ap
codelipenghui merged pull request #12657:
URL: https://github.com/apache/pulsar/pull/12657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
codelipenghui commented on a change in pull request #12658:
URL: https://github.com/apache/pulsar/pull/12658#discussion_r744466377
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PolicyHierarchyValue.java
##
@@ -0,0 +1,76 @@
+/**
+ * Licensed t
wolfstudy commented on pull request #12660:
URL: https://github.com/apache/pulsar/pull/12660#issuecomment-962884129
cc @Anonymitaet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
wolfstudy opened a new pull request #12660:
URL: https://github.com/apache/pulsar/pull/12660
Signed-off-by: xiaolongran
### Motivation
In https://github.com/apache/pulsar/pull/12566, we impl the
`NegativeAckRedeliveryBackoff` and the pr will add docs for this.
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new e476735 [Authorization] Support GET_METADATA t
codelipenghui merged pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
massakam commented on a change in pull request #12401:
URL: https://github.com/apache/pulsar/pull/12401#discussion_r77195
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownTest.java
##
@@ -152,7 +153,8 @@ public void
massakam commented on a change in pull request #12401:
URL: https://github.com/apache/pulsar/pull/12401#discussion_r744416170
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java
##
@@ -2231,4 +2232,170 @@ public void testFailedUpdatePart
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 213f14c Fix StringIndexOutOfBoundsException in
massakam commented on a change in pull request #12401:
URL: https://github.com/apache/pulsar/pull/12401#discussion_r744409675
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java
##
@@ -2231,4 +2232,170 @@ public void testFailedUpdatePart
merlimat merged pull request #12659:
URL: https://github.com/apache/pulsar/pull/12659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
wolfstudy merged pull request #661:
URL: https://github.com/apache/pulsar-client-go/pull/661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new fe3b7c4 remove unused dependency (#661)
wolfstudy merged pull request #660:
URL: https://github.com/apache/pulsar-client-go/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
This is an automated email from the ASF dual-hosted git repository.
rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 567263f Support nack backoff policy for
zymap commented on a change in pull request #660:
URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r742825857
##
File path: pulsar/consumer_regex.go
##
@@ -183,6 +183,22 @@ func (c *regexConsumer) AckID(msgID MessageID) {
}
func (c *regexConsumer) Nack(ms
congbobo184 commented on pull request #11933:
URL: https://github.com/apache/pulsar/pull/11933#issuecomment-962788146
@eolivelli please review again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
315157973 commented on pull request #12517:
URL: https://github.com/apache/pulsar/pull/12517#issuecomment-962787072
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
congbobo184 commented on a change in pull request #12521:
URL: https://github.com/apache/pulsar/pull/12521#discussion_r744378008
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
##
@@ -757,12 +758,31 @@ public void produceAnd
nodece commented on pull request #12625:
URL: https://github.com/apache/pulsar/pull/12625#issuecomment-962756843
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
punish-yh closed pull request #12639:
URL: https://github.com/apache/pulsar/pull/12639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
MarvinCai commented on pull request #12657:
URL: https://github.com/apache/pulsar/pull/12657#issuecomment-962753054
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962739386
@hangc0276 @gaoran10 please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
codelipenghui commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r743374976
##
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##
@@ -856,8 +858,13 @@ default void delete(String
yuruguo removed a comment on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962293794
@hangc0276 @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yuruguo commented on pull request #12315:
URL: https://github.com/apache/pulsar/pull/12315#issuecomment-962739386
@hangc0276 @gaoran10 please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jason918 commented on pull request #12659:
URL: https://github.com/apache/pulsar/pull/12659#issuecomment-962739144
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962701662
@merlimat @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962701662
@merlimat @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962695425
> @yuruguo Could you please help add a test? The change looks good to me.
Okay :)
Done, PTAL
--
This is an automated message from the Apache Git Service.
To respond
yuruguo commented on a change in pull request #12535:
URL: https://github.com/apache/pulsar/pull/12535#discussion_r744287470
##
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
##
@@ -51,13 +52,24 @@ public CmdSchemas(Supplier admin) {
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962586654
@lhotari @codelipenghui @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gaoran10 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r744285199
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -1141,6 +1143,48 @@ public long getEstimated
gaoran10 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r744280486
##
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##
@@ -856,8 +858,13 @@ default void delete(String topic
gaoran10 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277998
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -1141,6 +1144,53 @@ public long getEstimated
gaoran10 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277998
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -1141,6 +1144,53 @@ public long getEstimated
gaoran10 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277998
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -1141,6 +1144,53 @@ public long getEstimated
gaoran10 commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r744277301
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##
@@ -1141,6 +1144,53 @@ public long getEstimated
Jason918 opened a new pull request #12659:
URL: https://github.com/apache/pulsar/pull/12659
### Motivation
The `NamespaceResources#pathIsFromNamespace` throws
StringIndexOutOfBoundsException when path is "/admin/policies".
PS. It happens in some test case, I am not sure
Jason918 opened a new pull request #12658:
URL: https://github.com/apache/pulsar/pull/12658
### Motivation
Currently, `AbstractTopic#maxSubscriptionsPerTopic` stores the value of
namespace level policy, but we have broker level setting in
`org.apache.pulsar.broker.ServiceCon
MarvinCai opened a new pull request #12657:
URL: https://github.com/apache/pulsar/pull/12657
Master Issue: #12271
### Motivation
Apply Maven Modernizer plugin to enforce we move away from legacy APIs.
### Modifications
Add Maven Modernizer plugin in pulsar-broker-common m
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit b8ea17a07a8161990e79598debddaf1cc65d502b
Author: ran
AuthorDate: Sun Nov 7 21:24:33 2021 +0800
[Python Schema]
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a change to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 52764ce revert the wrong modification in
org.apache.pulsar.broker.namespace.OwnershipCache#checkOwnership (#12
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 4e4f49d283b83e7310e909a2d9c5d960793486b1
Author: Thomas Leplus
AuthorDate: Fri Nov 5 20:11:19 2021 -0700
Pulsa
codelipenghui commented on a change in pull request #12641:
URL: https://github.com/apache/pulsar/pull/12641#discussion_r744258801
##
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdProduce.java
##
@@ -107,6 +107,9 @@
description =
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 40356eb [broker] remove useless method
"Pers
codelipenghui merged pull request #12655:
URL: https://github.com/apache/pulsar/pull/12655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new e7389ed [Python Schema] Python schema support
codelipenghui merged pull request #12642:
URL: https://github.com/apache/pulsar/pull/12642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
Jason918 commented on a change in pull request #12654:
URL: https://github.com/apache/pulsar/pull/12654#discussion_r744246481
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##
@@ -474,7 +475,13 @@ public voi
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962591280
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962591280
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
yuruguo removed a comment on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962584862
@lhotari @eolivelli @codelipenghui @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962586654
@lhotari @codelipenghui @gaoran10 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656#issuecomment-962584862
@lhotari @eolivelli @codelipenghui @freeznet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
yuruguo opened a new pull request #12656:
URL: https://github.com/apache/pulsar/pull/12656
### Motivation
Currently, we can get the internal stats of a topic through
`bin/pulsar-admin topics stats-internal tn1/ns1/tp1` and also get ledger
metadata by specifying flag `--metadata`.
eolivelli commented on a change in pull request #12654:
URL: https://github.com/apache/pulsar/pull/12654#discussion_r744232276
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##
@@ -474,7 +475,13 @@ public vo
github-actions[bot] commented on pull request #12655:
URL: https://github.com/apache/pulsar/pull/12655#issuecomment-962581860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jason918 opened a new pull request #12655:
URL: https://github.com/apache/pulsar/pull/12655
### Motivation
Method `PersistentTopic#getPersistentTopic` is totally useless and is not
called anywhere.
I don't see any chance it could be used.
### Modifications
Jason918 opened a new pull request #12654:
URL: https://github.com/apache/pulsar/pull/12654
### Motivation
Remove unused listeners if it have no listeners, avoid the map
(`SystemTopicBasedTopicPoliciesService#listeners`) from keep growing.
### Modification
yuruguo commented on a change in pull request #12535:
URL: https://github.com/apache/pulsar/pull/12535#discussion_r744219865
##
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
##
@@ -51,13 +52,24 @@ public CmdSchemas(Supplier admin) {
66 matches
Mail list logo