[GitHub] [pulsar] congbobo184 closed issue #12671: Flaky-test: TransactionTest.testMaxReadPositionForNormalPublish

2021-11-18 Thread GitBox
congbobo184 closed issue #12671: URL: https://github.com/apache/pulsar/issues/12671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pulsar] congbobo184 merged pull request #12681: [Transaction] Fix transaction flaky test testMaxReadPositionForNormal…

2021-11-18 Thread GitBox
congbobo184 merged pull request #12681: URL: https://github.com/apache/pulsar/pull/12681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch master updated (fc8d50e -> afa472e)

2021-11-18 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fc8d50e The problem of two exception handling (#12744) add afa472e [Transaction] Fix transaction flaky test t

[GitHub] [pulsar] codelipenghui merged pull request #12836: JavaInstanceTest should be AssertEquals

2021-11-18 Thread GitBox
codelipenghui merged pull request #12836: URL: https://github.com/apache/pulsar/pull/12836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (afa472e -> 4a4c1de)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from afa472e [Transaction] Fix transaction flaky test testMaxReadPositionForNormalPublish (#12681) add 4a4c1de Ja

[GitHub] [pulsar] codelipenghui merged pull request #12840: Add error log when new jetty client exception

2021-11-18 Thread GitBox
codelipenghui merged pull request #12840: URL: https://github.com/apache/pulsar/pull/12840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (4a4c1de -> c18063f)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4a4c1de JavaInstanceTest should be AssertEquals (#12836) add c18063f Add error log when new jetty client (#12

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12786: [Issue 12757][broker] add broker config isAllowAutoUpdateSchema

2021-11-18 Thread GitBox
codelipenghui commented on a change in pull request #12786: URL: https://github.com/apache/pulsar/pull/12786#discussion_r751997217 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -573,6 +573,14 @@ ) private in

[GitHub] [pulsar] aerfalwl opened a new issue #12868: java.lang.IllegalArgumentException: Malformed Kerberos name: broker/http://x...@krb5.com

2021-11-18 Thread GitBox
aerfalwl opened a new issue #12868: URL: https://github.com/apache/pulsar/issues/12868 **Describe the bug** 1. The version of puslar cluster is 2.7.0. 2. Cluster uses kerberos for authentication. 3. When use tools pulsar-admin to list topics under public/default, pulsar-admin show

[GitHub] [pulsar] eolivelli commented on pull request #12145: [pulsar-io] pass client builder if no service url provided to debezium connector

2021-11-18 Thread GitBox
eolivelli commented on pull request #12145: URL: https://github.com/apache/pulsar/pull/12145#issuecomment-972649450 @nicoloboschi PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] Anonymitaet commented on pull request #12691: Update io-debug.md

2021-11-18 Thread GitBox
Anonymitaet commented on pull request #12691: URL: https://github.com/apache/pulsar/pull/12691#issuecomment-972650707 Hi @junqingzh any progress? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] eolivelli merged pull request #12846: [Broker] Fix producer getting incorrectly removed from topic's produc…

2021-11-18 Thread GitBox
eolivelli merged pull request #12846: URL: https://github.com/apache/pulsar/pull/12846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pulsar] branch master updated: [Broker] Fix producer getting incorrectly removed from topic's producers map (#12846)

2021-11-18 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e33687d [Broker] Fix producer getting incorr

[GitHub] [pulsar] Anonymitaet merged pull request #12432: Update deploy-bare-metal.md

2021-11-18 Thread GitBox
Anonymitaet merged pull request #12432: URL: https://github.com/apache/pulsar/pull/12432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch master updated: Update deploy-bare-metal.md (#12432)

2021-11-18 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5c12be7 Update deploy-bare-metal.md (#12432) 5c1

[GitHub] [pulsar] Anonymitaet closed pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters

2021-11-18 Thread GitBox
Anonymitaet closed pull request #11537: URL: https://github.com/apache/pulsar/pull/11537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] 315157973 opened a new pull request #12869: [PIP-105] Part-1 Support add subscription properties

2021-11-18 Thread GitBox
315157973 opened a new pull request #12869: URL: https://github.com/apache/pulsar/pull/12869 ### Motivation See https://github.com/apache/pulsar/issues/12269 I divided this PIP into two parts, the first part supports setting properties for subscriptions The second part will sup

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12786: [Issue 12757][broker] add broker config isAllowAutoUpdateSchema

2021-11-18 Thread GitBox
codelipenghui commented on a change in pull request #12786: URL: https://github.com/apache/pulsar/pull/12786#discussion_r752033446 ## File path: conf/broker.conf ## @@ -270,6 +270,10 @@ brokerMaxConnections=0 # The maximum number of connections per IP. If it exceeds, new conne

[GitHub] [pulsar] storm-5 commented on issue #12832: go client: message ID serialization / deserialization, then AckID failed

2021-11-18 Thread GitBox
storm-5 commented on issue #12832: URL: https://github.com/apache/pulsar/issues/12832#issuecomment-972675070 > could you provide the go code to test this issue? here is. I have wipe the sensitive info. ```go package main import ( "context" "fmt"

[GitHub] [pulsar] storm-5 edited a comment on issue #12832: go client: message ID serialization / deserialization, then AckID failed

2021-11-18 Thread GitBox
storm-5 edited a comment on issue #12832: URL: https://github.com/apache/pulsar/issues/12832#issuecomment-972675070 > could you provide the go code to test this issue? here is. I have wipe the sensitive info. ```go package main import ( "context" "

[pulsar] branch branch-2.8 updated (a94dbe6 -> fdcf5a4)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a94dbe6 [pulsar-admin] Perfect judgment conditions of pulsar-admin (#12315) new 97c79e2 Enable CLI to pu

[pulsar] 01/12: Enable CLI to publish non-batched messages (#12641)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 97c79e20be5e291d6de03daecd2507d96e0b27f9 Author: Masahiro Sakamoto AuthorDate: Mon Nov 8 20:19:02 2021 +0900 E

[pulsar] 03/12: [Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf (#12666)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5e2657a8d68d9614579f533eb3c179edb612baf9 Author: Lari Hotari AuthorDate: Wed Nov 10 06:03:06 2021 +0200 [Confi

[pulsar] 04/12: [pulsar-admin] Print topic internal info as formatted json (#12709)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 985ef03c4df6c680874835130121e9e33ba1beba Author: Ruguo Yu AuthorDate: Wed Nov 10 16:24:49 2021 +0800 [pulsar-a

[pulsar] 06/12: Even if always compatible is set, Consumers cannot be created (#12721)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0d2022dea5db7fa9057a769dcaacfd904c337b43 Author: feynmanlin AuthorDate: Fri Nov 12 13:43:50 2021 +0800 Even if

[pulsar] 07/12: [Authorization] Support UNSUBSCRIBE namespace op after enable auth (#12742)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 2ab4decdce95c2aa1b9d233608027b35c7c69da8 Author: Ruguo Yu AuthorDate: Fri Nov 12 10:29:56 2021 +0800 [Authoriz

[pulsar] 09/12: [Java Client] Let producer reconnect for state RegisteringSchema (#12781)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d09854f868eb28067da8ed62b14df7f013b8ba32 Author: Michael Marshall AuthorDate: Mon Nov 15 01:39:45 2021 -0600 [

[pulsar] 11/12: Fix TopicPoliciesCacheNotInitException issue. (#12773)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 00161516c25fa5646cd9007d5232c80e5c058b51 Author: Jiwei Guo AuthorDate: Thu Nov 18 13:44:42 2021 +0800 Fix Topi

[pulsar] 02/12: [Authorization] Support GET_METADATA topic op after enable auth (#12656)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 74c91a30224cc25c20054e1f679b3e2667238891 Author: Ruguo Yu AuthorDate: Mon Nov 8 15:21:43 2021 +0800 [Authoriza

[pulsar] 05/12: [Managed Ledger] Fix the incorrect total size when BrokerEntryMetadata is enabled (#12714)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 3c9894d53c0198b5738597ddc2c9db2356c950c9 Author: Yunze Xu AuthorDate: Thu Nov 11 17:46:55 2021 +0800 [Managed

[pulsar] 08/12: [Issue 12723] Fix race condition in PersistentTopic#addReplicationCluster (#12729)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 230e1ac9f97e292a01766766705d531f3eb8bf34 Author: JiangHaiting AuthorDate: Mon Nov 15 08:52:31 2021 +0800 [Issu

[pulsar] 10/12: [Pulsar SQL] Handle message null schema version in PulsarRecordCursor (#12809)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit c43d1da5cc28377a331403a5ccb7dc34f59fe13f Author: ran AuthorDate: Tue Nov 16 13:16:58 2021 +0800 [Pulsar SQL] H

[pulsar] 12/12: Fix cherry-pick issue

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit fdcf5a4da7a21863e19068c90e8000b6e8fd74a0 Author: penghui AuthorDate: Thu Nov 18 17:29:46 2021 +0800 Fix cherry

[GitHub] [pulsar] liangyepianzhou commented on pull request #12705: [Transaction]stop TC replaying with exception

2021-11-18 Thread GitBox
liangyepianzhou commented on pull request #12705: URL: https://github.com/apache/pulsar/pull/12705#issuecomment-972699327 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] gaozhangmin commented on issue #12759: [bug](indeviduallyDeleteMessage): slow rate consumer but ack in order will get indeviduallyDeleteMessage

2021-11-18 Thread GitBox
gaozhangmin commented on issue #12759: URL: https://github.com/apache/pulsar/issues/12759#issuecomment-972727778 The further entry ack was acked in method `filterEntriesForConsumer` ![image](https://user-images.githubusercontent.com/9278488/142396263-e4c2d067-3323-4ea6-9f44-43231b07d4

[GitHub] [pulsar] suiyuzeng opened a new pull request #12870: replace deprecated function of TopicPoliciesTest

2021-11-18 Thread GitBox
suiyuzeng opened a new pull request #12870: URL: https://github.com/apache/pulsar/pull/12870 ### Motivation replace deprecated function of TopicPoliciesTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] github-actions[bot] commented on pull request #12870: replace deprecated function of TopicPoliciesTest

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #12870: URL: https://github.com/apache/pulsar/pull/12870#issuecomment-972754898 @suiyuzeng:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob

[GitHub] [pulsar] casuallc opened a new pull request #12871: Fix spelling error and useless code.

2021-11-18 Thread GitBox
casuallc opened a new pull request #12871: URL: https://github.com/apache/pulsar/pull/12871 ### Motivation Fix spelling error and useless code. ### Modifications ### Verifying this change ### Does this pull request potentially affect one of the following p

[GitHub] [pulsar] RobertIndie opened a new pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

2021-11-18 Thread GitBox
RobertIndie opened a new pull request #12872: URL: https://github.com/apache/pulsar/pull/12872 Fixes #9441 ### Motivation Currently, if we need to specify the messageID when creating a subscription through the REST API, we cannot use `latest` and `earliest` to specify the

[GitHub] [pulsar] Jason918 commented on pull request #12786: [Issue 12757][broker] add broker config isAllowAutoUpdateSchema

2021-11-18 Thread GitBox
Jason918 commented on pull request #12786: URL: https://github.com/apache/pulsar/pull/12786#issuecomment-972785430 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] RobertIndie commented on a change in pull request #12871: Fix spelling error and useless code.

2021-11-18 Thread GitBox
RobertIndie commented on a change in pull request #12871: URL: https://github.com/apache/pulsar/pull/12871#discussion_r752159272 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1989,7 +1989,7 @@ protected void handleTcClientCon

[GitHub] [pulsar] liangyepianzhou commented on pull request #12521: [Transaction]Txn client check timeout

2021-11-18 Thread GitBox
liangyepianzhou commented on pull request #12521: URL: https://github.com/apache/pulsar/pull/12521#issuecomment-972793794 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Jason918 commented on a change in pull request #12753: [Issue 12726][broker] Fix deadlock in metadata-store callback thread

2021-11-18 Thread GitBox
Jason918 commented on a change in pull request #12753: URL: https://github.com/apache/pulsar/pull/12753#discussion_r752174496 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -3088,8 +3088,13 @@ public void onUpda

[GitHub] [pulsar] codelipenghui merged pull request #12786: [Issue 12757][broker] add broker config isAllowAutoUpdateSchema

2021-11-18 Thread GitBox
codelipenghui merged pull request #12786: URL: https://github.com/apache/pulsar/pull/12786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui closed issue #12757: Support enable or disable schema upload at the broker level

2021-11-18 Thread GitBox
codelipenghui closed issue #12757: URL: https://github.com/apache/pulsar/issues/12757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated (5c12be7 -> fa7be23)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5c12be7 Update deploy-bare-metal.md (#12432) add fa7be23 [Issue 12757][broker] add broker config isAllowAuto

[GitHub] [pulsar] Jason918 commented on pull request #12753: [Issue 12726][broker] Fix deadlock in metadata-store callback thread

2021-11-18 Thread GitBox
Jason918 commented on pull request #12753: URL: https://github.com/apache/pulsar/pull/12753#issuecomment-972844759 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] RobertIndie commented on pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

2021-11-18 Thread GitBox
RobertIndie commented on pull request #12872: URL: https://github.com/apache/pulsar/pull/12872#issuecomment-972845834 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[pulsar] branch branch-2.8 updated: [Issue 12757][broker] add broker config isAllowAutoUpdateSchema (#12786)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 8b62272 [Issue 12757][broker] add brok

[GitHub] [pulsar] Technoboy- opened a new pull request #12873: Remove readerCaches and close reader when exception occurs in SystemTopicBasedTopicPoliciesService

2021-11-18 Thread GitBox
Technoboy- opened a new pull request #12873: URL: https://github.com/apache/pulsar/pull/12873 ## Motivation This is related to #12773. As @codelipenghui has commented to remove the readerCaches and close reader. But due to some reasons, that pr forget to do that. -- This is an au

[GitHub] [pulsar] github-actions[bot] commented on pull request #12873: Remove readerCaches and close reader when exception occurs in SystemTopicBasedTopicPoliciesService

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #12873: URL: https://github.com/apache/pulsar/pull/12873#issuecomment-972869112 @Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blo

[GitHub] [pulsar] Jason918 opened a new pull request #12874: [broker] Optimize blocking backlogQuotaCheck to non-blocking in ServerCnx#handleProducer

2021-11-18 Thread GitBox
Jason918 opened a new pull request #12874: URL: https://github.com/apache/pulsar/pull/12874 ### Motivation Currently, when broker receive "Producer" command, it will check the topic if "isBacklogQuotaExceeded". While in `PersistentTopic#isBacklogQuotaExceeded`, `isTimeBacklogExce

[GitHub] [pulsar] YanshuoH commented on issue #12716: Broker OOM and memory leak, possibly due to ledger loss

2021-11-18 Thread GitBox
YanshuoH commented on issue #12716: URL: https://github.com/apache/pulsar/issues/12716#issuecomment-972876710 After some JVM investigation, I've used `jcmd -dump:format=b,file=dump.bin 1`. Found something interesting in the `dominant_tree` (using MAT): https://user-images.githubuserconte

[GitHub] [pulsar] YanshuoH commented on issue #12716: Broker OOM and memory leak, possibly due to ledger loss

2021-11-18 Thread GitBox
YanshuoH commented on issue #12716: URL: https://github.com/apache/pulsar/issues/12716#issuecomment-972880510 And finally after correctly turning on the leak detection, So we can see where the leak comes from. The leak log is quite long, click details to reveal it.

[GitHub] [pulsar] YanshuoH edited a comment on issue #12716: Broker OOM and memory leak, possibly due to ledger loss

2021-11-18 Thread GitBox
YanshuoH edited a comment on issue #12716: URL: https://github.com/apache/pulsar/issues/12716#issuecomment-972880510 And finally after correctly turning on the leak detection, So we can see where the leak comes from. The leak log is quite long, click details to reveal it.

[GitHub] [pulsar] Jason918 commented on pull request #12753: [Issue 12726][broker] Fix deadlock in metadata-store callback thread

2021-11-18 Thread GitBox
Jason918 commented on pull request #12753: URL: https://github.com/apache/pulsar/pull/12753#issuecomment-972901742 @315157973 Fixed the previous bug. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] eolivelli commented on pull request #12855: Docs: Pulsar standalone does not work on Windows, remove from docs, also suggest to use JDK11

2021-11-18 Thread GitBox
eolivelli commented on pull request #12855: URL: https://github.com/apache/pulsar/pull/12855#issuecomment-972917305 `Do we need to apply these changes to the previous version doc of pulsar, which also does not seem to support the Windows system.` We could but it is not a big deal.

[GitHub] [pulsar] Jason918 commented on issue #11426: Flaky-test: KeySharedSubscriptionTest.testRemoveFirstConsumer

2021-11-18 Thread GitBox
Jason918 commented on issue #11426: URL: https://github.com/apache/pulsar/issues/11426#issuecomment-972917578 I have located this issue, and the test case is actually ok, but it caused by a race condition in `PersistentDispatcherMultipleConsumers`, which indeed would causing the unordered

[GitHub] [pulsar] Jason918 edited a comment on issue #11426: Flaky-test: KeySharedSubscriptionTest.testRemoveFirstConsumer

2021-11-18 Thread GitBox
Jason918 edited a comment on issue #11426: URL: https://github.com/apache/pulsar/issues/11426#issuecomment-972917578 I have located this issue, and the test case is actually ok, but it caused by a race condition in `PersistentDispatcherMultipleConsumers`, which indeed would causing the un

[GitHub] [pulsar] Jason918 commented on pull request #12776: [metadata] Add RocksdbMetadataStore

2021-11-18 Thread GitBox
Jason918 commented on pull request #12776: URL: https://github.com/apache/pulsar/pull/12776#issuecomment-972919853 @eolivelli Any suggestions about this work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pulsar] aloyszhang closed pull request #12823: modify log level for disconnction

2021-11-18 Thread GitBox
aloyszhang closed pull request #12823: URL: https://github.com/apache/pulsar/pull/12823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [pulsar] aloyszhang commented on a change in pull request #12823: modify log level for disconnction

2021-11-18 Thread GitBox
aloyszhang commented on a change in pull request #12823: URL: https://github.com/apache/pulsar/pull/12823#discussion_r752342705 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@ -253,7 +253,7 @@ protected ByteBuf newConnectCommand() t

[GitHub] [pulsar] yuruguo opened a new pull request #12875: [website] Correct the display of reader configuration

2021-11-18 Thread GitBox
yuruguo opened a new pull request #12875: URL: https://github.com/apache/pulsar/pull/12875 ### Motivation The `reader` configuration is incorrectly displayed as [below](https://pulsar.apache.org/docs/en/client-libraries-java/#configure-reader): ![image](https://user-images.githubuser

[GitHub] [pulsar] github-actions[bot] commented on pull request #12875: [website] Correct the display of reader configuration

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #12875: URL: https://github.com/apache/pulsar/pull/12875#issuecomment-972997290 @yuruguo:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] yuruguo commented on pull request #12875: [website] Correct the display of reader configuration

2021-11-18 Thread GitBox
yuruguo commented on pull request #12875: URL: https://github.com/apache/pulsar/pull/12875#issuecomment-972997607 @Anonymitaet @Huanli-Meng PTAL, THX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] github-actions[bot] commented on pull request #12875: [website] Correct the display of reader configuration

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #12875: URL: https://github.com/apache/pulsar/pull/12875#issuecomment-972998118 @yuruguo:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo removed a comment on pull request #12875: [website] Correct the display of reader configuration

2021-11-18 Thread GitBox
yuruguo removed a comment on pull request #12875: URL: https://github.com/apache/pulsar/pull/12875#issuecomment-972997607 @Anonymitaet @Huanli-Meng PTAL, THX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pulsar] yuruguo commented on pull request #12875: [website] Correct the display of reader configuration

2021-11-18 Thread GitBox
yuruguo commented on pull request #12875: URL: https://github.com/apache/pulsar/pull/12875#issuecomment-972998818 @Anonymitaet @Huanli-Meng PTAL, THX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] zeo1995 opened a new pull request #12876: [website][upgrade]feat: website upgrade / docs migration - 2.6.2 / Pulsar Functions/Pulsar IO/Pulsar SQL

2021-11-18 Thread GitBox
zeo1995 opened a new pull request #12876: URL: https://github.com/apache/pulsar/pull/12876 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] yuruguo commented on pull request #12850: [Authorization] Support GET_BACKLOG_SIZE topic op after enable auth

2021-11-18 Thread GitBox
yuruguo commented on pull request #12850: URL: https://github.com/apache/pulsar/pull/12850#issuecomment-973013562 @eolivelli @codelipenghui @315157973 @freeznet PTAL, THX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar] github-actions[bot] commented on pull request #12876: [website][upgrade]feat: website upgrade / docs migration - 2.6.2 / Pulsar Functions/Pulsar IO/Pulsar SQL

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #12876: URL: https://github.com/apache/pulsar/pull/12876#issuecomment-973013625 @zeo1995:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] yuruguo removed a comment on pull request #12850: [Authorization] Support GET_BACKLOG_SIZE topic op after enable auth

2021-11-18 Thread GitBox
yuruguo removed a comment on pull request #12850: URL: https://github.com/apache/pulsar/pull/12850#issuecomment-971291830 @merlimat @codelipenghui @hangc0276 @freeznet PTAL, THX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pulsar] github-actions[bot] commented on pull request #12876: [website][upgrade]feat: website upgrade / docs migration - 2.6.2 / Pulsar Functions/Pulsar IO/Pulsar SQL

2021-11-18 Thread GitBox
github-actions[bot] commented on pull request #12876: URL: https://github.com/apache/pulsar/pull/12876#issuecomment-973014129 @zeo1995:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] zeo1995 opened a new pull request #12877: [website][upgrade]feat: website upgrade / docs migration - 2.6.2 / Kubernetes (Helm)/Deployment/Administration

2021-11-18 Thread GitBox
zeo1995 opened a new pull request #12877: URL: https://github.com/apache/pulsar/pull/12877 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] zeo1995 opened a new pull request #12878: [website][upgrade]feat: website upgrade / docs migration - 2.6.2 / Security/Performance/Client Libraries/Admin API

2021-11-18 Thread GitBox
zeo1995 opened a new pull request #12878: URL: https://github.com/apache/pulsar/pull/12878 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] zeo1995 opened a new pull request #12879: [website][upgrade]feat: website upgrade / docs migration - 2.6.2 /Adaptors/ Cookbooks/Development/Reference

2021-11-18 Thread GitBox
zeo1995 opened a new pull request #12879: URL: https://github.com/apache/pulsar/pull/12879 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] flowchartsman commented on pull request #12013: [Issue 9772][Go Functions]Allow User Metrics

2021-11-18 Thread GitBox
flowchartsman commented on pull request #12013: URL: https://github.com/apache/pulsar/pull/12013#issuecomment-973047607 Cool! Is anything further from me required to get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar-client-go] flowchartsman commented on issue #468: Add Support for NonDurable subscriptions

2021-11-18 Thread GitBox
flowchartsman commented on issue #468: URL: https://github.com/apache/pulsar-client-go/issues/468#issuecomment-973057844 Feature parity alone is not a compelling reason for me, since it duplicates functionality. Re-reading your use-case, it seems that you might even benefit more from a tr

[GitHub] [pulsar] kaja78 opened a new issue #12880: KafkaConnectSink effectively ignores topic name from sink configuration file

2021-11-18 Thread GitBox
kaja78 opened a new issue #12880: URL: https://github.com/apache/pulsar/issues/12880 **Describe the bug** The topic configuration property of PulsarKafkaConnectSinkConfig is not passed to Kafka sink. Instead of it, the original Pulsar topic name is passed. In the KafkaConnectSink.

[GitHub] [pulsar] lhotari commented on pull request #12744: The problem of two exception handling

2021-11-18 Thread GitBox
lhotari commented on pull request #12744: URL: https://github.com/apache/pulsar/pull/12744#issuecomment-973089095 @merlimat Are you ok with this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] lhotari commented on pull request #12744: The problem of two exception handling

2021-11-18 Thread GitBox
lhotari commented on pull request #12744: URL: https://github.com/apache/pulsar/pull/12744#issuecomment-973104508 @congbobo184 This PR was reviewed and merged only by you. On the other hand, our contributing guidelines state that each PR must be approved by at least 2 Pulsar committers.

[pulsar] 01/01: Revert "The problem of two exception handling (#12744)"

2021-11-18 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch revert-12744-handle_exception_double in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 11d9f365a8165cd74dd6123faf0e4d14579e25f1 Author: Lari Hotari AuthorDate: Thu Nov 18 19:40

[pulsar] branch revert-12744-handle_exception_double created (now 11d9f36)

2021-11-18 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch revert-12744-handle_exception_double in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 11d9f36 Revert "The problem of two exception handling (#12744)" This branch includes

[GitHub] [pulsar] merlimat commented on pull request #12744: The problem of two exception handling

2021-11-18 Thread GitBox
merlimat commented on pull request #12744: URL: https://github.com/apache/pulsar/pull/12744#issuecomment-973114794 @liangyepianzhou @congbobo184 I think the PR solves the problem but it has a regression. The `exceptionally()` clause is also use to catch exceptions that are being th

[GitHub] [pulsar] nlu90 commented on pull request #12013: [Issue 9772][Go Functions]Allow User Metrics

2021-11-18 Thread GitBox
nlu90 commented on pull request #12013: URL: https://github.com/apache/pulsar/pull/12013#issuecomment-973155128 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #12471: Optimize ThresholdShedder strategy: the low-load Broker cannot be fully utilized

2021-11-18 Thread GitBox
lordcheng10 commented on pull request #12471: URL: https://github.com/apache/pulsar/pull/12471#issuecomment-973196953 In order to facilitate understanding, I have shown the code ideas in the form of diagrams. PTAL,thanks! @hangc0276 @michaeljmarshall ![image](https://user-images.github

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12471: Optimize ThresholdShedder strategy: the low-load Broker cannot be fully utilized

2021-11-18 Thread GitBox
michaeljmarshall commented on a change in pull request #12471: URL: https://github.com/apache/pulsar/pull/12471#discussion_r752585894 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java ## @@ -74,19 +77,56 @@ r

[GitHub] [pulsar] jerrypeng merged pull request #11763: [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics

2021-11-18 Thread GitBox
jerrypeng merged pull request #11763: URL: https://github.com/apache/pulsar/pull/11763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] michaeljmarshall commented on pull request #12471: Optimize ThresholdShedder strategy: the low-load Broker cannot be fully utilized

2021-11-18 Thread GitBox
michaeljmarshall commented on pull request #12471: URL: https://github.com/apache/pulsar/pull/12471#issuecomment-973218773 @lordcheng10 - instead of writing a diagram, I think it would be more productive to write tests that show how it will work and will also serve to verify your algorithm

[pulsar] branch master updated (fa7be23 -> 60bda08)

2021-11-18 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fa7be23 [Issue 12757][broker] add broker config isAllowAutoUpdateSchema (#12786) add 60bda08 [Pulsar-clien

[GitHub] [pulsar] dlg99 commented on pull request #12859: Don't create AvroData for each KafkaSourceRecord

2021-11-18 Thread GitBox
dlg99 commented on pull request #12859: URL: https://github.com/apache/pulsar/pull/12859#issuecomment-973228643 another problem with AvroData creation is that it logs ``` INFO org.apache.pulsar.kafka.shade.io.confluent.connect.avro.AvroDataConfig - AvroDataConfig values:

[GitHub] [pulsar] rdhabalia commented on pull request #12471: Optimize ThresholdShedder strategy: the low-load Broker cannot be fully utilized

2021-11-18 Thread GitBox
rdhabalia commented on pull request #12471: URL: https://github.com/apache/pulsar/pull/12471#issuecomment-973235424 this solution would not work in heterogeneous hardware and not correct to make it default behavior. I have done some work to address this issue and need to complete the PR.

[GitHub] [pulsar] rdhabalia commented on pull request #12471: Optimize ThresholdShedder strategy: the low-load Broker cannot be fully utilized

2021-11-18 Thread GitBox
rdhabalia commented on pull request #12471: URL: https://github.com/apache/pulsar/pull/12471#issuecomment-973238703 also , don't change the existing implementation because there are two different approaches for load balancer a. utilize brokers fully b. distribute load uniformly across brok

[GitHub] [pulsar] nlu90 commented on a change in pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

2021-11-18 Thread GitBox
nlu90 commented on a change in pull request #12872: URL: https://github.com/apache/pulsar/pull/12872#discussion_r752681524 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java ## @@ -45,6 +45,18 @@ private MessageIdImpl() { this(-

[GitHub] [pulsar] codelipenghui merged pull request #12873: Remove readerCaches and close reader when exception occurs in SystemTopicBasedTopicPoliciesService

2021-11-18 Thread GitBox
codelipenghui merged pull request #12873: URL: https://github.com/apache/pulsar/pull/12873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (60bda08 -> bcc219b)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 60bda08 [Pulsar-client] Allow us to easily get a mapping of brokers to partitioned topics (#11763) add bcc219

[pulsar] branch branch-2.8 updated: Remove readerCaches and close reader when exception occurs in SystemTopicBasedTopicPoliciesService. (#12873)

2021-11-18 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 183734a Remove readerCaches and close

[GitHub] [pulsar] dlg99 commented on issue #12880: KafkaConnectSink effectively ignores topic name from sink configuration file

2021-11-18 Thread GitBox
dlg99 commented on issue #12880: URL: https://github.com/apache/pulsar/issues/12880#issuecomment-973459152 @kaja78 I don't think using `final String topic = topicName;` is a good idea. IIRC sink can use multiple input topics (via `--inputs`) and we'd want to route them to appropriate des

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

2021-11-18 Thread GitBox
codelipenghui commented on a change in pull request #12872: URL: https://github.com/apache/pulsar/pull/12872#discussion_r752770279 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java ## @@ -1318,9 +1318,9 @@ public void createSubsc

[GitHub] [pulsar] casuallc commented on a change in pull request #12871: Fix spelling error and useless code.

2021-11-18 Thread GitBox
casuallc commented on a change in pull request #12871: URL: https://github.com/apache/pulsar/pull/12871#discussion_r752776064 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1989,7 +1989,7 @@ protected void handleTcClientConnec

  1   2   >