[GitHub] [pulsar-client-go] stormeyes opened a new issue #675: should change dgrijalva/jwt-go to golang-jwt/jwt in oauth2/go.mod

2021-11-30 Thread GitBox
stormeyes opened a new issue #675: URL: https://github.com/apache/pulsar-client-go/issues/675 **Is your feature request related to a problem? Please describe.** The oauth2/go.mod require github.com/form3tech-oss/jwt-go v3.2.3+incompatible should update to community maintained version: g

[pulsar] branch master updated (6e3b736 -> b0e954b)

2021-11-30 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6e3b736 Integration tests for function-worker rebalance and drain operations. (#13058) add b0e954b Suggest to

[GitHub] [pulsar] Anonymitaet merged pull request #13039: Suggest to use tlsPort instead of deprecated TlsEnable

2021-11-30 Thread GitBox
Anonymitaet merged pull request #13039: URL: https://github.com/apache/pulsar/pull/13039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13044: [Doc] add tips for Pulsar tools

2021-11-30 Thread GitBox
Anonymitaet commented on a change in pull request #13044: URL: https://github.com/apache/pulsar/pull/13044#discussion_r759916930 ## File path: site2/docs/reference-cli-tools.md ## @@ -15,8 +15,12 @@ All Pulsar command-line tools can be run from the `bin` directory of your [ins

[GitHub] [pulsar] Jason918 commented on pull request #12993: Do not reuse the Failed OpAddEntry object which lead bundle unloading timeout.

2021-11-30 Thread GitBox
Jason918 commented on pull request #12993: URL: https://github.com/apache/pulsar/pull/12993#issuecomment-983360429 > @codelipenghui what's the relationship between this and #12396 . Does this mean we don't need it anymore? NO relationship. It's OpReadEntry in #12396. -- This i

[GitHub] [pulsar] Jason918 commented on pull request #13000: [broker] Optimize TopicPolicy#deduplicationEnabled with HierarchyTopicPolicies

2021-11-30 Thread GitBox
Jason918 commented on pull request #13000: URL: https://github.com/apache/pulsar/pull/13000#issuecomment-983356981 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Jason918 commented on a change in pull request #12396: Fix NPE when create OpEntry

2021-11-30 Thread GitBox
Jason918 commented on a change in pull request #12396: URL: https://github.com/apache/pulsar/pull/12396#discussion_r759910077 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java ## @@ -58,6 +57,11 @@ public static OpReadEntry create(M

[GitHub] [pulsar] hepyu commented on issue #12800: 40个分区的topic消息严重不均衡下个别partition无法被consumer消费

2021-11-30 Thread GitBox
hepyu commented on issue #12800: URL: https://github.com/apache/pulsar/issues/12800#issuecomment-983348068 > 我们使用pulsar 2.8.1版本,在broker.conf中使用key_shared一致性哈希,没有再出现接收不到消息的问题。 subscriptionKeySharedUseConsistentHashing=true 其实这个issue最后查明也不是说”收不到消息“,是因为大量堆积后push大量推,把服务的pulsar-client的无界

[GitHub] [pulsar] eolivelli commented on issue #13056: Provide Docker Image for Pulsar 2.9.0

2021-11-30 Thread GitBox
eolivelli commented on issue #13056: URL: https://github.com/apache/pulsar/issues/13056#issuecomment-983337782 The image should be available now. Please note that we found a regression in 2.9 after closing the VOTE. You can use 2.9 for testing the new features but I would wait 2.9.

[GitHub] [pulsar] aerfalwl opened a new issue #13060: ERROR Failed to evaluate client token: javax.security.sasl.SaslException: Final handshake step failed

2021-11-30 Thread GitBox
aerfalwl opened a new issue #13060: URL: https://github.com/apache/pulsar/issues/13060 **Describe the bug** 1. The version of puslar cluster is 2.7.0. 2. Cluster uses kerberos for authentication. 3. When use tools pulsar-admin to list topics under public/default, pulsar-admin shows

[GitHub] [pulsar] pgandhap edited a comment on issue #12987: Unable to create a JDBC sink

2021-11-30 Thread GitBox
pgandhap edited a comment on issue #12987: URL: https://github.com/apache/pulsar/issues/12987#issuecomment-983327657 Previously pulsar-postgres-jdbc-sink.yaml is in my local machine not in docker container , but i am trying to run this command to create sink . That's why i am getting this

[pulsar] branch master updated (aa992e8 -> 6e3b736)

2021-11-30 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from aa992e8 fix(functions): missing runtime set in GoInstanceConfig (#13031) add 6e3b736 Integration tests for

[GitHub] [pulsar] pgandhap edited a comment on issue #12987: Unable to create a JDBC sink

2021-11-30 Thread GitBox
pgandhap edited a comment on issue #12987: URL: https://github.com/apache/pulsar/issues/12987#issuecomment-983327657 Previously pulsar-postgres-jdbc-sink.yaml is in my local machine not in docker container , but i am trying to run this command to create sink . That's why i am getting this

[GitHub] [pulsar] jerrypeng merged pull request #13058: Integration tests for function-worker rebalance and drain operations.

2021-11-30 Thread GitBox
jerrypeng merged pull request #13058: URL: https://github.com/apache/pulsar/pull/13058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] pgandhap commented on issue #12987: Unable to create a JDBC sink

2021-11-30 Thread GitBox
pgandhap commented on issue #12987: URL: https://github.com/apache/pulsar/issues/12987#issuecomment-983327657 I got the solution . Previously pulsar-postgres-jdbc-sink.yaml is in my local machine not in docker container , but i am trying to run this command to create sink . That's why i am

[GitHub] [pulsar] pgandhap edited a comment on issue #12960: Unable to configure a JDBC Sink

2021-11-30 Thread GitBox
pgandhap edited a comment on issue #12960: URL: https://github.com/apache/pulsar/issues/12960#issuecomment-983326276 I got the solution . Previously avro-schema file is in my local machine not in docker container , but i am trying to run this command to upload schema to a topic . That's wh

[GitHub] [pulsar] pgandhap commented on issue #12960: Unable to configure a JDBC Sink

2021-11-30 Thread GitBox
pgandhap commented on issue #12960: URL: https://github.com/apache/pulsar/issues/12960#issuecomment-983326276 I got the solution . Previously avro-schema file is in local machine not in docker container , but i am trying to run this command to upload schema to a topic . That's why i am get

[GitHub] [pulsar] jerrypeng commented on a change in pull request #13058: Integration tests for function-worker rebalance and drain operations.

2021-11-30 Thread GitBox
jerrypeng commented on a change in pull request #13058: URL: https://github.com/apache/pulsar/pull/13058#discussion_r759882873 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/java/PulsarWorkerRebalanceDrainTest.java ## @@ -0,0 +1,393

[GitHub] [pulsar] yuruguo commented on a change in pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-30 Thread GitBox
yuruguo commented on a change in pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#discussion_r759881444 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java ## @@ -342,6 +342,19 @@ public void setNamespaceReplication

[GitHub] [pulsar] yuruguo commented on a change in pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-30 Thread GitBox
yuruguo commented on a change in pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#discussion_r748993292 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java ## @@ -271,6 +272,18 @@ public void setNamespaceReplication

[GitHub] [pulsar] mattisonchao edited a comment on issue #12969: `AutoConsume` should support protobuf schema

2021-11-30 Thread GitBox
mattisonchao edited a comment on issue #12969: URL: https://github.com/apache/pulsar/issues/12969#issuecomment-983308709 @freeznet According to this description of pip, we seem to be unable to support AutoConsume protobuf. https://docs.google.com/document/d/1XR_MNOuSXyig-CKs

[GitHub] [pulsar] mattisonchao commented on issue #12969: `AutoConsume` should support protobuf schema

2021-11-30 Thread GitBox
mattisonchao commented on issue #12969: URL: https://github.com/apache/pulsar/issues/12969#issuecomment-983308709 According to this description of pip, we seem to be unable to support AutoConsume protobuf. https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IXvFwziBRdSoS3oEUiLF

[GitHub] [pulsar] nlu90 opened a new pull request #13059: pulsar admin exposes secret for source and sink

2021-11-30 Thread GitBox
nlu90 opened a new pull request #13059: URL: https://github.com/apache/pulsar/pull/13059 ### Motivation Follow-up fix of #12950 for #12834 It turns out the Source and Sink doesn't inherit from Function cmd, so we need to add the api separately. ### Modifications add

[pulsar] branch master updated (7d4ab2e -> aa992e8)

2021-11-30 Thread rfu
This is an automated email from the ASF dual-hosted git repository. rfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7d4ab2e [pulsar-admin] Add get-replicated-subscription-status command for topic (#12891) add aa992e8 fix(functio

[GitHub] [pulsar] freeznet merged pull request #13031: fix(functions): missing runtime set in GoInstanceConfig

2021-11-30 Thread GitBox
freeznet merged pull request #13031: URL: https://github.com/apache/pulsar/pull/13031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] freeznet closed issue #12477: [bug](function-go-runtime): The runtime of instance-conf is incorrect

2021-11-30 Thread GitBox
freeznet closed issue #12477: URL: https://github.com/apache/pulsar/issues/12477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] jcQuartic commented on issue #7663: doc for deploying python functions with custom dependencies not explained in 2.6.0

2021-11-30 Thread GitBox
jcQuartic commented on issue #7663: URL: https://github.com/apache/pulsar/issues/7663#issuecomment-983296155 @sijie Hi bud, is that possible to use TensorFlow as a custom dependency for the pulsar function? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] rdhabalia commented on pull request #12902: [pulsar-broker] add uniform load shedder strategy to distribute traffic uniformly across brokers

2021-11-30 Thread GitBox
rdhabalia commented on pull request #12902: URL: https://github.com/apache/pulsar/pull/12902#issuecomment-983294427 @Anonymitaet I still see blocker for this PR. Please avoid creating blocker for DOC. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Anonymitaet commented on pull request #12902: [pulsar-broker] add uniform load shedder strategy to distribute traffic uniformly across brokers

2021-11-30 Thread GitBox
Anonymitaet commented on pull request #12902: URL: https://github.com/apache/pulsar/pull/12902#issuecomment-983292308 @rdhabalia yes, it makes sense. Separate doc PR is more convenient for cutting a release (cherry-pick changes) as well. -- This is an automated message from the Apache G

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12993: Do not reuse the Failed OpAddEntry object which lead bundle unloading timeout.

2021-11-30 Thread GitBox
codelipenghui commented on a change in pull request #12993: URL: https://github.com/apache/pulsar/pull/12993#discussion_r759850606 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1678,7 +1678,6 @@ public ManagedLedger

svn commit: r51152 [2/2] - in /dev/pulsar/pulsar-2.8.2-candidate-1: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

2021-11-30 Thread linlin
Propchange: dev/pulsar/pulsar-2.8.2-candidate-1/connectors/pulsar-io-elastic-search-2.8.2.nar -- svn:mime-type = application/octet-stream Added: dev/pulsar/pulsar-2.8.2-candidate-1/connectors/pulsar-io-elastic-search

svn commit: r51152 [1/2] - in /dev/pulsar/pulsar-2.8.2-candidate-1: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

2021-11-30 Thread linlin
Author: linlin Date: Wed Dec 1 04:03:42 2021 New Revision: 51152 Log: Staging artifacts and signature for Pulsar release 2.8.2 Added: dev/pulsar/pulsar-2.8.2-candidate-1/ dev/pulsar/pulsar-2.8.2-candidate-1/DEB/ dev/pulsar/pulsar-2.8.2-candidate-1/DEB/Packages.gz (with props) d

[GitHub] [pulsar] rdhabalia commented on pull request #12902: [pulsar-broker] add uniform load shedder strategy to distribute traffic uniformly across brokers

2021-11-30 Thread GitBox
rdhabalia commented on pull request #12902: URL: https://github.com/apache/pulsar/pull/12902#issuecomment-983258115 @Anonymitaet sure, I agree. let me create a separate PR with detailed info because we still have to add support of namespace isolation. so, can we unblock this PR and merge i

[GitHub] [pulsar] mattisonchao removed a comment on issue #12969: `AutoConsume` should support protobuf schema

2021-11-30 Thread GitBox
mattisonchao removed a comment on issue #12969: URL: https://github.com/apache/pulsar/issues/12969#issuecomment-983252467 @freeznet According to this description of pip, we seem to be unable to support AutoConsume protobuf. https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IX

[GitHub] [pulsar] mattisonchao commented on issue #12969: `AutoConsume` should support protobuf schema

2021-11-30 Thread GitBox
mattisonchao commented on issue #12969: URL: https://github.com/apache/pulsar/issues/12969#issuecomment-983252467 @freeznet According to this description of pip, we seem to be unable to support AutoConsume protobuf. https://docs.google.com/document/d/1XR_MNOuSXyig-CKsdVhr6IXvFwziBRd

[GitHub] [pulsar] mattisonchao removed a comment on issue #12969: `AutoConsume` should support protobuf schema

2021-11-30 Thread GitBox
mattisonchao removed a comment on issue #12969: URL: https://github.com/apache/pulsar/issues/12969#issuecomment-983240676 maybe we can not support this feature ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pulsar] mattisonchao commented on issue #12969: `AutoConsume` should support protobuf schema

2021-11-30 Thread GitBox
mattisonchao commented on issue #12969: URL: https://github.com/apache/pulsar/issues/12969#issuecomment-983240676 maybe we can not support this feature ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #13044: [Doc] add tips for Pulsar tools

2021-11-30 Thread GitBox
Huanli-Meng commented on a change in pull request #13044: URL: https://github.com/apache/pulsar/pull/13044#discussion_r759816995 ## File path: site2/docs/reference-cli-tools.md ## @@ -15,8 +15,12 @@ All Pulsar command-line tools can be run from the `bin` directory of your [ins

[GitHub] [pulsar] nodece commented on issue #12962: Java client consumer acknowledge issue. It should work for both of the cases

2021-11-30 Thread GitBox
nodece commented on issue #12962: URL: https://github.com/apache/pulsar/issues/12962#issuecomment-983235065 @xqianwang Could you try the code of https://github.com/apache/pulsar/pull/12994, I fix the `acknowledge()`, but I'm not sure whether to fix your problem. -- This is an automated

[GitHub] [pulsar] Anonymitaet commented on pull request #12902: [pulsar-broker] add uniform load shedder strategy to distribute traffic uniformly across brokers

2021-11-30 Thread GitBox
Anonymitaet commented on pull request #12902: URL: https://github.com/apache/pulsar/pull/12902#issuecomment-983228833 > @Anonymitaet > > Please don't block the PR due to the documentation format. yes, I agree, the better format helps but the reorganization of the content can be h

[GitHub] [pulsar] Jason918 commented on a change in pull request #12930: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock

2021-11-30 Thread GitBox
Jason918 commented on a change in pull request #12930: URL: https://github.com/apache/pulsar/pull/12930#discussion_r759807860 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1434,7 +1434,7 @@ protected void interna

[GitHub] [pulsar] Jason918 commented on a change in pull request #12930: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock

2021-11-30 Thread GitBox
Jason918 commented on a change in pull request #12930: URL: https://github.com/apache/pulsar/pull/12930#discussion_r759807194 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1434,7 +1434,7 @@ protected void interna

[GitHub] [pulsar] MarvinCai commented on pull request #13047: [Doc] add explanations for time-based backlog quota

2021-11-30 Thread GitBox
MarvinCai commented on pull request #13047: URL: https://github.com/apache/pulsar/pull/13047#issuecomment-983208851 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (d34379f -> 7d4ab2e)

2021-11-30 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d34379f [Broker] Consider topics in pulsar/system namespace as system topics (#13050) add 7d4ab2e [pulsar-ad

[GitHub] [pulsar] codelipenghui merged pull request #12891: [pulsar-admin] Add get-replicated-subscription-status command for topic

2021-11-30 Thread GitBox
codelipenghui merged pull request #12891: URL: https://github.com/apache/pulsar/pull/12891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated (4563b9e -> d34379f)

2021-11-30 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4563b9e Fix typo: correct sizeUint to sizeUnit (#13040) add d34379f [Broker] Consider topics in pulsar/system

[GitHub] [pulsar] codelipenghui merged pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

2021-11-30 Thread GitBox
codelipenghui merged pull request #13050: URL: https://github.com/apache/pulsar/pull/13050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12403: [PIP 107][Client] Introduce chunk message ID

2021-11-30 Thread GitBox
codelipenghui commented on a change in pull request #12403: URL: https://github.com/apache/pulsar/pull/12403#discussion_r759775652 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -61,6 +61,9 @@ message MessageIdData { optional int32 batch_index = 4 [defaul

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12403: [PIP 107][Client] Introduce chunk message ID

2021-11-30 Thread GitBox
codelipenghui commented on a change in pull request #12403: URL: https://github.com/apache/pulsar/pull/12403#discussion_r759774021 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -1206,6 +1206,24 @@ void messageReceived(MessageId

[GitHub] [pulsar] yuruguo removed a comment on pull request #13040: fixtypo: Correct sizeUint to sizeUnit

2021-11-30 Thread GitBox
yuruguo removed a comment on pull request #13040: URL: https://github.com/apache/pulsar/pull/13040#issuecomment-982579389 @BewareMyPower @Technoboy- PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[pulsar] branch master updated (2b939b7 -> 4563b9e)

2021-11-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2b939b7 fix-12894 (#12896) add 4563b9e Fix typo: correct sizeUint to sizeUnit (#13040) No new revisions were

[GitHub] [pulsar] merlimat merged pull request #13040: fixtypo: Correct sizeUint to sizeUnit

2021-11-30 Thread GitBox
merlimat merged pull request #13040: URL: https://github.com/apache/pulsar/pull/13040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #12930: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock

2021-11-30 Thread GitBox
bharanic-dev commented on a change in pull request #12930: URL: https://github.com/apache/pulsar/pull/12930#discussion_r759750975 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1434,7 +1434,7 @@ protected void int

[GitHub] [pulsar] yuruguo commented on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-30 Thread GitBox
yuruguo commented on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-983122405 @eolivelli @codelipenghui @315157973 can you help review this pr again? I have addressed all comments :) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] yuruguo removed a comment on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-30 Thread GitBox
yuruguo removed a comment on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-982193504 @eolivelli @codelipenghui @315157973 can you help review this pr again? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] yuruguo commented on pull request #12983: [pulsar-admin] Add remove-subscription-types-enabled command for topic

2021-11-30 Thread GitBox
yuruguo commented on pull request #12983: URL: https://github.com/apache/pulsar/pull/12983#issuecomment-983114774 > I am approving this patch. > > thank you @yuruguo for checking about my comments. > > I believe we have to follow up and fix potential local cache consistency pr

[GitHub] [pulsar] merlimat commented on a change in pull request #13043: Transparent batching of ZK operations

2021-11-30 Thread GitBox
merlimat commented on a change in pull request #13043: URL: https://github.com/apache/pulsar/pull/13043#discussion_r759683779 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java ## @@ -128,105 +143,229 @@ protected void receivedSess

[GitHub] [pulsar] lhotari commented on a change in pull request #13043: Transparent batching of ZK operations

2021-11-30 Thread GitBox
lhotari commented on a change in pull request #13043: URL: https://github.com/apache/pulsar/pull/13043#discussion_r759679497 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java ## @@ -128,105 +143,229 @@ protected void receivedSessi

[GitHub] [pulsar] lhotari commented on pull request #13043: Transparent batching of ZK operations

2021-11-30 Thread GitBox
lhotari commented on pull request #13043: URL: https://github.com/apache/pulsar/pull/13043#issuecomment-983040195 Awesome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lhotari commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

2021-11-30 Thread GitBox
lhotari commented on pull request #13050: URL: https://github.com/apache/pulsar/pull/13050#issuecomment-983023068 @codelipenghui Would you mind taking a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch master updated (4672024 -> 2b939b7)

2021-11-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4672024 Don't attempt to delete pending ack store unless transactions are enabled (#13041) add 2b939b7 fix-1

[GitHub] [pulsar] lhotari closed issue #12894: ContentDeserializationException and warning logs in metadata store.

2021-11-30 Thread GitBox
lhotari closed issue #12894: URL: https://github.com/apache/pulsar/issues/12894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [pulsar] lhotari merged pull request #12896: [Issue 12894] Only refresh metadata if path is already in cache after write.

2021-11-30 Thread GitBox
lhotari merged pull request #12896: URL: https://github.com/apache/pulsar/pull/12896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] rdhabalia commented on pull request #12902: [pulsar-broker] add uniform load shedder strategy to distribute traffic uniformly across brokers

2021-11-30 Thread GitBox
rdhabalia commented on pull request #12902: URL: https://github.com/apache/pulsar/pull/12902#issuecomment-982991782 @Anonymitaet fixed typo about `loadBalancerMsgRateDifferenceShedderThreshold` config based on your feedback in the [doc](https://docs.google.com/document/d/1kZvYreXMFPXBUtU5

[GitHub] [pulsar] rdhabalia commented on pull request #12902: [pulsar-broker] add uniform load shedder strategy to distribute traffic uniformly across brokers

2021-11-30 Thread GitBox
rdhabalia commented on pull request #12902: URL: https://github.com/apache/pulsar/pull/12902#issuecomment-982989328 @codelipenghui > I think we'd better use the batch rate instead of the msg rate? LoadBalancer only captures `MsgRate` and not batch msg, and that's because bat

[GitHub] [pulsar] rdhabalia commented on a change in pull request #12403: [PIP 107][Client] Introduce chunk message ID

2021-11-30 Thread GitBox
rdhabalia commented on a change in pull request #12403: URL: https://github.com/apache/pulsar/pull/12403#discussion_r759618530 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -1206,6 +1206,24 @@ void messageReceived(MessageIdData

[GitHub] [pulsar] merlimat commented on a change in pull request #13057: [Producer] Change the time units from ns to ms

2021-11-30 Thread GitBox
merlimat commented on a change in pull request #13057: URL: https://github.com/apache/pulsar/pull/13057#discussion_r759579222 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java ## @@ -1223,13 +1223,13 @@ void sendComplete(final Exception

[GitHub] [pulsar] merlimat commented on a change in pull request #13043: Transparent batching of ZK operations

2021-11-30 Thread GitBox
merlimat commented on a change in pull request #13043: URL: https://github.com/apache/pulsar/pull/13043#discussion_r759577391 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataBenchmark.java ## @@ -0,0 +1,155 @@ +/** + * Licensed to the Apache Soft

[GitHub] [pulsar] xqianwang commented on issue #12962: Java client consumer acknowledge issue. It should work for both of the cases

2021-11-30 Thread GitBox
xqianwang commented on issue #12962: URL: https://github.com/apache/pulsar/issues/12962#issuecomment-982914340 Hi @nodece , just simply try `consumer.acknowledge(MessageId.fromByteArrayWithTopic( message.getMessageId().toByteArray(), consumer.getTopic()))` instead of `consumer.ackno

[GitHub] [pulsar] github-actions[bot] commented on pull request #13058: Integration tests for function-worker rebalance and drain operations.

2021-11-30 Thread GitBox
github-actions[bot] commented on pull request #13058: URL: https://github.com/apache/pulsar/pull/13058#issuecomment-982874849 @kaushik-develop:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsa

[GitHub] [pulsar] kaushik-develop opened a new pull request #13058: Integration tests for function-worker rebalance and drain operations.

2021-11-30 Thread GitBox
kaushik-develop opened a new pull request #13058: URL: https://github.com/apache/pulsar/pull/13058 ### Motivation Integration tests for function-worker rebalance and drain operations. ### Modifications Added integration tests for function-worker rebalance and

[pulsar] branch master updated: Don't attempt to delete pending ack store unless transactions are enabled (#13041)

2021-11-30 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4672024 Don't attempt to delete pending ack

[GitHub] [pulsar] eolivelli merged pull request #13041: [Broker] Don't attempt to delete pending ack store unless transactions are enabled

2021-11-30 Thread GitBox
eolivelli merged pull request #13041: URL: https://github.com/apache/pulsar/pull/13041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] eolivelli commented on a change in pull request #13043: Transparent batching of ZK operations

2021-11-30 Thread GitBox
eolivelli commented on a change in pull request #13043: URL: https://github.com/apache/pulsar/pull/13043#discussion_r759499060 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java ## @@ -128,105 +143,227 @@ protected void receivedSes

[GitHub] [pulsar] hangc0276 commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-30 Thread GitBox
hangc0276 commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r759339065 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/SubscriptionStats.java ## @@ -49,6 +49,9 @@ /** Size o

[GitHub] [pulsar] freeznet commented on pull request #13031: fix(functions): missing runtime set in GoInstanceConfig

2021-11-30 Thread GitBox
freeznet commented on pull request #13031: URL: https://github.com/apache/pulsar/pull/13031#issuecomment-982641233 @nlu90 please help to review this PR when you have time, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pulsar] ericsyh commented on pull request #13031: fix(functions): missing runtime set in GoInstanceConfig

2021-11-30 Thread GitBox
ericsyh commented on pull request #13031: URL: https://github.com/apache/pulsar/pull/13031#issuecomment-982626442 @freeznet PTAL, after several tries the CI checks pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] oscerd commented on issue #13056: Provide Docker Image for Pulsar 2.9.0

2021-11-30 Thread GitBox
oscerd commented on issue #13056: URL: https://github.com/apache/pulsar/issues/13056#issuecomment-982624906 Thanks, sorry for the noise, I thought the release was completed and there was just the image missing. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] eolivelli commented on issue #13056: Provide Docker Image for Pulsar 2.9.0

2021-11-30 Thread GitBox
eolivelli commented on issue #13056: URL: https://github.com/apache/pulsar/issues/13056#issuecomment-982623761 Hello, I am the release manager for Pulsar 2.9.0. I am still in the middle of the "release" procedure. We still miss some other pieces, like the website update.

[GitHub] [pulsar] eolivelli closed issue #13056: Provide Docker Image for Pulsar 2.9.0

2021-11-30 Thread GitBox
eolivelli closed issue #13056: URL: https://github.com/apache/pulsar/issues/13056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pulsar] branch master updated (73ef162 -> 724523f)

2021-11-30 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 73ef162 Fix Issue #12885, Unordered consuming case in Key_Shared subscription (#12890) add 724523f [Perf]

[GitHub] [pulsar] eolivelli merged pull request #13045: [Cleanup] Evaluate the current protocol version once

2021-11-30 Thread GitBox
eolivelli merged pull request #13045: URL: https://github.com/apache/pulsar/pull/13045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] tomscut opened a new pull request #13057: [Producer] Change the time units from ns to ms

2021-11-30 Thread GitBox
tomscut opened a new pull request #13057: URL: https://github.com/apache/pulsar/pull/13057 ### Motivation *The time unit in this exception message is ns, which is not very readable. We can change it from ns to ms.* ``` org.apache.pulsar.client.api.PulsarClientException$Time

[GitHub] [pulsar] github-actions[bot] commented on pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-11-30 Thread GitBox
github-actions[bot] commented on pull request #13055: URL: https://github.com/apache/pulsar/pull/13055#issuecomment-982602549 @aloyszhang:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] oscerd opened a new issue #13056: Provide Docker Image for Pulsar 2.9.0

2021-11-30 Thread GitBox
oscerd opened a new issue #13056: URL: https://github.com/apache/pulsar/issues/13056 **Describe the bug** Just noticed Pulsar 2.9.0 has been released but the related docker image doesn't. This is probably more a task than a bug, but just wanted to report it. -- This is an a

[GitHub] [pulsar] github-actions[bot] commented on pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-11-30 Thread GitBox
github-actions[bot] commented on pull request #13055: URL: https://github.com/apache/pulsar/pull/13055#issuecomment-982602342 @aloyszhang:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blo

[GitHub] [pulsar] aloyszhang opened a new pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-11-30 Thread GitBox
aloyszhang opened a new pull request #13055: URL: https://github.com/apache/pulsar/pull/13055 Fixes #13028 ### Motivation For now, the result of the `lookup` command for a topic not existing by the rest API will return a brokerUrl. This pull request resolves this proble

[pulsar] branch master updated: Fix Issue #12885, Unordered consuming case in Key_Shared subscription (#12890)

2021-11-30 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 73ef162 Fix Issue #12885, Unordered consuming

[GitHub] [pulsar] codelipenghui closed issue #12885: [Bug] Unordered consuming case in Key_Shared subscription

2021-11-30 Thread GitBox
codelipenghui closed issue #12885: URL: https://github.com/apache/pulsar/issues/12885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] codelipenghui merged pull request #12890: [Issue 12885]Fix unordered consuming case in Key_Shared subscription.

2021-11-30 Thread GitBox
codelipenghui merged pull request #12890: URL: https://github.com/apache/pulsar/pull/12890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[pulsar] branch master updated: [broker]Optimize topicMaxMessageSize with topic local cache. (#12830)

2021-11-30 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1b20a97 [broker]Optimize topicMaxMessageSize w

[GitHub] [pulsar] codelipenghui merged pull request #12830: [broker]Optimize topicMaxMessageSize with topic local cache.

2021-11-30 Thread GitBox
codelipenghui merged pull request #12830: URL: https://github.com/apache/pulsar/pull/12830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] aloyszhang closed pull request #12041: make partitioned-lookup result more readable

2021-11-30 Thread GitBox
aloyszhang closed pull request #12041: URL: https://github.com/apache/pulsar/pull/12041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [pulsar] yuruguo commented on pull request #13040: fixtypo: Correct sizeUint to sizeUnit

2021-11-30 Thread GitBox
yuruguo commented on pull request #13040: URL: https://github.com/apache/pulsar/pull/13040#issuecomment-982579389 @BewareMyPower @Technoboy- PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] eolivelli commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

2021-11-30 Thread GitBox
eolivelli commented on pull request #13050: URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982550699 Thank you @lhotari for your pointer. I see that PIP-39 is still in "draft" status. @sijie or @codelipenghui do you mind marking as Accepted and cleaning up the Wik

[GitHub] [pulsar] github-actions[bot] commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

2021-11-30 Thread GitBox
github-actions[bot] commented on pull request #13050: URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982549501 @lhotari:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] lhotari commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

2021-11-30 Thread GitBox
lhotari commented on pull request #13050: URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982547709 > what it is a "System topic" ? @eolivelli The concept was introduced by #4955 / [PIP-39](https://github.com/apache/pulsar/wiki/PIP-39%3A-Namespace-Change-Events). --

[GitHub] [pulsar] Anonymitaet opened a new issue #13054: [Doc] how to migrate data between environments (eg. copy data to a new AWS region or K8S namespace)

2021-11-30 Thread GitBox
Anonymitaet opened a new issue #13054: URL: https://github.com/apache/pulsar/issues/13054 Context: https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1629221522272000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] Anonymitaet opened a new issue #13053: [Doc] add docs for backlog retention

2021-11-30 Thread GitBox
Anonymitaet opened a new issue #13053: URL: https://github.com/apache/pulsar/issues/13053 Context: https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1631170767222600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] eolivelli commented on pull request #13050: [Broker] Consider topics in pulsar/system namespace as system topics

2021-11-30 Thread GitBox
eolivelli commented on pull request #13050: URL: https://github.com/apache/pulsar/pull/13050#issuecomment-982538014 @lhotari what it is a "System topic" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   >