[GitHub] [pulsar] gaozhangmin commented on a change in pull request #12957: fix pr #12378

2021-12-06 Thread GitBox
gaozhangmin commented on a change in pull request #12957: URL: https://github.com/apache/pulsar/pull/12957#discussion_r763722847 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java ## @@ -212,16 +212,18 @@ public

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #12957: fix pr #12378

2021-12-06 Thread GitBox
gaozhangmin commented on a change in pull request #12957: URL: https://github.com/apache/pulsar/pull/12957#discussion_r763720206 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java ## @@ -212,16 +212,18 @@ public

[GitHub] [pulsar] liangyepianzhou removed a comment on pull request #12521: [Transaction]Txn client check timeout

2021-12-06 Thread GitBox
liangyepianzhou removed a comment on pull request #12521: URL: https://github.com/apache/pulsar/pull/12521#issuecomment-964655264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] aloyszhang commented on a change in pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-12-06 Thread GitBox
aloyszhang commented on a change in pull request #13055: URL: https://github.com/apache/pulsar/pull/13055#discussion_r763718139 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java ## @@ -80,55 +80,63 @@ protected void

[GitHub] [pulsar] congbobo184 commented on a change in pull request #12957: fix pr #12378

2021-12-06 Thread GitBox
congbobo184 commented on a change in pull request #12957: URL: https://github.com/apache/pulsar/pull/12957#discussion_r763717783 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java ## @@ -212,16 +212,18 @@ public

[GitHub] [pulsar] congbobo184 commented on a change in pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-12-06 Thread GitBox
congbobo184 commented on a change in pull request #13055: URL: https://github.com/apache/pulsar/pull/13055#discussion_r763712330 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java ## @@ -80,55 +80,63 @@ protected void

[pulsar] branch master updated (3732b6f -> 5ec8b86)

2021-12-06 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3732b6f [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / cookbooks/development/reference

[GitHub] [pulsar] eolivelli merged pull request #13155: Fix initialisation of autorecovery pod

2021-12-06 Thread GitBox
eolivelli merged pull request #13155: URL: https://github.com/apache/pulsar/pull/13155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wuzhanpeng opened a new pull request #13166: refine cursor last active

2021-12-06 Thread GitBox
wuzhanpeng opened a new pull request #13166: URL: https://github.com/apache/pulsar/pull/13166 Resolves #13165 ### Documentation Need to update docs? - [x] `no-need-doc` Just a little function supplement, no need to update the document -- This is an

[GitHub] [pulsar] wuzhanpeng opened a new issue #13165: refine cursor last active

2021-12-06 Thread GitBox
wuzhanpeng opened a new issue #13165: URL: https://github.com/apache/pulsar/issues/13165 **Is your enhancement request related to a problem? Please describe.** We found that after turning on the automatic cleanup for inactive subscriptions, if only resetting a sub without continuous

[GitHub] [pulsar] yuruguo commented on a change in pull request #13138: [Broker] Remove tenant permission verification when list partitioned-topic

2021-12-06 Thread GitBox
yuruguo commented on a change in pull request #13138: URL: https://github.com/apache/pulsar/pull/13138#discussion_r762769228 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java ## @@ -427,6 +435,8 @@ public void

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987634230 @eolivelli @codelipenghui @hangc0276 @gaoran10 Would you help review this PR? thx! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] mattisonchao edited a comment on issue #13154: Consumer subscription type - behavior not working properly

2021-12-06 Thread GitBox
mattisonchao edited a comment on issue #13154: URL: https://github.com/apache/pulsar/issues/13154#issuecomment-987632582 i want to work on it. i will try to reproduce it first. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] mattisonchao commented on issue #13154: Consumer subscription type - behavior not working properly

2021-12-06 Thread GitBox
mattisonchao commented on issue #13154: URL: https://github.com/apache/pulsar/issues/13154#issuecomment-987632582 i will work on it. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #13163: [ Java Client ] fix method will be called two times.

2021-12-06 Thread GitBox
mattisonchao commented on pull request #13163: URL: https://github.com/apache/pulsar/pull/13163#issuecomment-987631748 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] mattisonchao commented on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
mattisonchao commented on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987631632 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] 315157973 commented on pull request #13159: fix flaky test for BrokerServiceLookupTest.testModularLoadManagerSplitBundle

2021-12-06 Thread GitBox
315157973 commented on pull request #13159: URL: https://github.com/apache/pulsar/pull/13159#issuecomment-987626504 @Shoothzj Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] mattisonchao commented on pull request #13163: [ Java Client ] fix method will be called two times.

2021-12-06 Thread GitBox
mattisonchao commented on pull request #13163: URL: https://github.com/apache/pulsar/pull/13163#issuecomment-987626047 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] mattisonchao edited a comment on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
mattisonchao edited a comment on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987624748 > > @freeznet PTAL :) > > > I once wanted to use Avro, but I got some problems when deserializing, I think something might be missing. > > Maybe we

[GitHub] [pulsar] mattisonchao commented on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
mattisonchao commented on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987624748 > > @freeznet PTAL :) > > > I once wanted to use Avro, but I got some problems when deserializing, I think something might be missing. > > Maybe we should

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987624154 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987624154 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] github-actions[bot] commented on pull request #13164: fix:remove the loadbalance/bundle-data node

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #13164: URL: https://github.com/apache/pulsar/pull/13164#issuecomment-987621643 @leizhiyuan:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch branch-2.7 updated: Allow to configure schema compatibility policy for system topics (#12598)

2021-12-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new de57f98 Allow to configure schema

[GitHub] [pulsar] github-actions[bot] commented on pull request #13164: fix:remove the loadbalance/bundle-data node

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #13164: URL: https://github.com/apache/pulsar/pull/13164#issuecomment-987612872 @leizhiyuan:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] leizhiyuan opened a new pull request #13164: fix:remove the loadbalance/bundle-data node

2021-12-06 Thread GitBox
leizhiyuan opened a new pull request #13164: URL: https://github.com/apache/pulsar/pull/13164 Fixes #13162 ### Motivation fix: remove the loadbalance/bundle-data node, when deleting namespace. it will cause zk node leak, fix #13162 ### Modifications

[GitHub] [pulsar] mattisonchao removed a comment on pull request #13163: [ Java Client ] fix method will be called two times.

2021-12-06 Thread GitBox
mattisonchao removed a comment on pull request #13163: URL: https://github.com/apache/pulsar/pull/13163#issuecomment-987610102 [x]no-need-doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #13163: [ Java Client ] fix method will be called two times.

2021-12-06 Thread GitBox
mattisonchao commented on pull request #13163: URL: https://github.com/apache/pulsar/pull/13163#issuecomment-987610102 [x]no-need-doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] github-actions[bot] commented on pull request #13163: [ Java Client ] fix method will be called two times.

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #13163: URL: https://github.com/apache/pulsar/pull/13163#issuecomment-987609860 @mattisonchao:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] mattisonchao opened a new pull request #13163: [ Java Client ] fix method will be called two times.

2021-12-06 Thread GitBox
mattisonchao opened a new pull request #13163: URL: https://github.com/apache/pulsar/pull/13163 - fix ``MultiVersionGenericProtobufNativeReader`` method will be called two times. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987606683 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987606683 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] leizhiyuan opened a new issue #13162: bundle-data do not be deleted when delete namespace

2021-12-06 Thread GitBox
leizhiyuan opened a new issue #13162: URL: https://github.com/apache/pulsar/issues/13162 **Describe the bug** when namespace deleted, the /loadbalance/bundle-data/{tenant}/{namespace} should be deleted this will cause zk node leak **To Reproduce** Steps to reproduce the

[GitHub] [pulsar] frankxieke commented on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
frankxieke commented on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987604676 > @freeznet PTAL :) > I once wanted to use Avro, but I got some problems when deserializing, I think something might be missing. Maybe we should follow

[GitHub] [pulsar] lordcheng10 commented on pull request #13080: [pulsar-broker] support broker isolation for uniform load shedder strategy

2021-12-06 Thread GitBox
lordcheng10 commented on pull request #13080: URL: https://github.com/apache/pulsar/pull/13080#issuecomment-987598236 When the traffic to be unloaded is too small, there is no need to unload at this time to avoid unnecessary unload:https://github.com/apache/pulsar/pull/13140 -- This

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987592604 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987592604 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] michaeljmarshall opened a new pull request #13161: [Java Client] Send CloseProducer on timeout

2021-12-06 Thread GitBox
michaeljmarshall opened a new pull request #13161: URL: https://github.com/apache/pulsar/pull/13161 ### Motivation When producer creation times out, send the `CloseProducer` before sending a command to recreate the `Producer`. This ensures a better time to recovery. This

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987582464 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987582464 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] zymap commented on a change in pull request #13118: [DOCS] Update the Package Management page

2021-12-06 Thread GitBox
zymap commented on a change in pull request #13118: URL: https://github.com/apache/pulsar/pull/13118#discussion_r763635054 ## File path: site2/docs/admin-api-packages.md ## @@ -84,22 +96,25 @@ bin/pulsar-admin packages upload functions://public/default/example@v0.1 --path

[pulsar] branch master updated (98e4ffd -> 3732b6f)

2021-12-06 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 98e4ffd [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / client/admin api/adaptors (#13145)

[GitHub] [pulsar] Anonymitaet merged pull request #13146: [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / cookbooks/development/reference

2021-12-06 Thread GitBox
Anonymitaet merged pull request #13146: URL: https://github.com/apache/pulsar/pull/13146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #13145: [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / client/admin api/adaptors

2021-12-06 Thread GitBox
Anonymitaet merged pull request #13145: URL: https://github.com/apache/pulsar/pull/13145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #13144: [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / deployment/administration/security

2021-12-06 Thread GitBox
Anonymitaet merged pull request #13144: URL: https://github.com/apache/pulsar/pull/13144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao commented on a change in pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
mattisonchao commented on a change in pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#discussion_r763629980 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/MultiVersionGenericProtobufReader.java ## @@ -0,0 +1,90 @@

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987570232 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] mattisonchao commented on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
mattisonchao commented on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987570488 > I think PROTOBUF schema is also baesd on avro. Why not `GenericProtobufSchema` inheritage `GenericSchemaImpl` just like `GenericAvroSchema` and `GenericJsonSchema`. I

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987569933 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987570232 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987569933 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Anonymitaet merged pull request #13143: [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / functions/io/sql

2021-12-06 Thread GitBox
Anonymitaet merged pull request #13143: URL: https://github.com/apache/pulsar/pull/13143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #13142: [website][upgrade]feat: website upgrade / docs migration - 2.4.1 / get started/concepts/schema

2021-12-06 Thread GitBox
Anonymitaet merged pull request #13142: URL: https://github.com/apache/pulsar/pull/13142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987560978 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987560978 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987557386 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987557386 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar-client-node] branch master updated: fix: use pause and resume api to ensure orderly init listener->consumer (#182) (#183)

2021-12-06 Thread nkurihar
This is an automated email from the ASF dual-hosted git repository. nkurihar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/master by this push: new 661e965 fix: use pause and

[GitHub] [pulsar] Anonymitaet commented on pull request #13150: Fix yaml/json configuration examples in io-cdc-debezium

2021-12-06 Thread GitBox
Anonymitaet commented on pull request #13150: URL: https://github.com/apache/pulsar/pull/13150#issuecomment-987551516 @RobertIndie can you review this PR from the technical perspective? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987548978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987549247 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987548978 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] nlu90 opened a new issue #13160: [admin] enhance rest api to help calculate the ending MessageID with a starting MessageID and an offset number

2021-12-06 Thread GitBox
nlu90 opened a new issue #13160: URL: https://github.com/apache/pulsar/issues/13160 **Is your feature request related to a problem? Please describe.** Data processing framework sometimes need to limit the # of messages read from one read iteration, and this requires knowing the ending

[GitHub] [pulsar] github-actions[bot] commented on pull request #13159: fix flaky test for BrokerServiceLookupTest.testModularLoadManagerSplitBundle

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #13159: URL: https://github.com/apache/pulsar/pull/13159#issuecomment-987536434 @wuzhanpeng:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] wuzhanpeng opened a new pull request #13159: fix flaky test for BrokerServiceLookupTest.testModularLoadManagerSplitBundle

2021-12-06 Thread GitBox
wuzhanpeng opened a new pull request #13159: URL: https://github.com/apache/pulsar/pull/13159 Fixed #13102 It is invalid to set the `loadBalancerNamespaceBundleMaxTopics=1` after the initialization is completed, and the condition of `stats.topics = 2 > maxBundleTopics =

[GitHub] [pulsar] github-actions[bot] commented on pull request #13159: fix flaky test for BrokerServiceLookupTest.testModularLoadManagerSplitBundle

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #13159: URL: https://github.com/apache/pulsar/pull/13159#issuecomment-987534808 @wuzhanpeng:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987531379 > If all consume roles could modify the namespace level subscription-related policies, do it may cause some confusion? In fact, this problem still exists if the tenant

[GitHub] [pulsar] wang-yeliang opened a new issue #13158: [DISCUSS] proposal: APISIX support Pulsar service plugin

2021-12-06 Thread GitBox
wang-yeliang opened a new issue #13158: URL: https://github.com/apache/pulsar/issues/13158 Hi, community, My name is Yeliang Wang, and I am Apache APISIX Committer. At present, Apache APISIX supports Kafka in real-time log processing

[GitHub] [pulsar] gaoran10 commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
gaoran10 commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987512290 If all consume roles could modify the namespace level subscription-related policies, do it may cause some confusion? -- This is an automated message from the Apache Git

[GitHub] [pulsar] frankxieke commented on a change in pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
frankxieke commented on a change in pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#discussion_r763578352 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/MultiVersionGenericProtobufReader.java ## @@ -0,0 +1,90 @@

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987502487 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] MarvinCai edited a comment on pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-12-06 Thread GitBox
MarvinCai edited a comment on pull request #13055: URL: https://github.com/apache/pulsar/pull/13055#issuecomment-987506003 > @aloyszhang It will be a breaking change if users use HTTP lookup of the client and enable topic auto-creation I don't think this will actually break an

[GitHub] [pulsar] MarvinCai commented on pull request #13055: fix wrong result for looking up a non-exist topic by rest api

2021-12-06 Thread GitBox
MarvinCai commented on pull request #13055: URL: https://github.com/apache/pulsar/pull/13055#issuecomment-987506003 > @aloyszhang It will be a breaking change if users use HTTP lookup of the client and enable topic auto-creation I don't think this will actually break an application,

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-987502487 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] frankxieke commented on a change in pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
frankxieke commented on a change in pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#discussion_r762682345 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AutoConsumeSchema.java ## @@ -177,6 +178,8 @@ public void

[GitHub] [pulsar] frankxieke removed a comment on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
frankxieke removed a comment on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987500768 I think PROTOBUF schema is also baesd on avro. Why not `GenericProtobufSchema` inheritage `GenericSchemaImpl` just like `GenericAvroSchema` and

[GitHub] [pulsar] frankxieke commented on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
frankxieke commented on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987500768 I think PROTOBUF schema is also baesd on avro. Why not `GenericProtobufSchema` inheritage `GenericSchemaImpl` just like `GenericAvroSchema` and `GenericJsonSchema`. I

[GitHub] [pulsar] frankxieke commented on pull request #13094: [ Client ] Support Protobuf ``AutoSchema``

2021-12-06 Thread GitBox
frankxieke commented on pull request #13094: URL: https://github.com/apache/pulsar/pull/13094#issuecomment-987500462 I think PROTOBUF schema is also baesd on avro. Why not `GenericProtobufSchema` inheritage `GenericSchemaImpl` just like `GenericAvroSchema` and `GenericJsonSchema`. I

[GitHub] [pulsar] Jason918 commented on pull request #13147: [Issue 12958] Use payload size for isExceedMaximumMessageSize

2021-12-06 Thread GitBox
Jason918 commented on pull request #13147: URL: https://github.com/apache/pulsar/pull/13147#issuecomment-987495153 > It seems that you want to compute the real message payload size, but if the message is a batch message, even we skip the batch message metadata, the rest part will also

[pulsar] branch master updated (b05d50d -> 47e4f38)

2021-12-06 Thread sunfangbin
This is an automated email from the ASF dual-hosted git repository. sunfangbin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b05d50d fix: release note anchor jumper (#13114) add 47e4f38 [Sink] fix updateSink and getSinkInfo miss

[GitHub] [pulsar] murong00 merged pull request #12450: [Sink] fix updateSink and getSinkInfo miss to handle cleanupSubscription

2021-12-06 Thread GitBox
murong00 merged pull request #12450: URL: https://github.com/apache/pulsar/pull/12450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (5b0214a -> b05d50d)

2021-12-06 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5b0214a [Issue 12929] [pulsar-metadata] Fix metadata store deadlock (#12930) add b05d50d fix: release note

[GitHub] [pulsar] Anonymitaet merged pull request #13114: [website]fix: release note anchor jumper

2021-12-06 Thread GitBox
Anonymitaet merged pull request #13114: URL: https://github.com/apache/pulsar/pull/13114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo opened a new pull request #13157: [Authorization] Converge perm to operate subscription conf of namespace

2021-12-06 Thread GitBox
yuruguo opened a new pull request #13157: URL: https://github.com/apache/pulsar/pull/13157 ### Motivation Currently, only `super-user` or `tenant-administrator` can `set`/`get`/`remove` the subscription configuration of the namespace. In fact, this authorization can be further

[GitHub] [pulsar] yuruguo removed a comment on pull request #13138: [Broker] Remove tenant permission verification when list partitioned-topic

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13138: URL: https://github.com/apache/pulsar/pull/13138#issuecomment-987425838 @michaeljmarshall @freeznet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] yuruguo commented on pull request #13138: [Broker] Remove tenant permission verification when list partitioned-topic

2021-12-06 Thread GitBox
yuruguo commented on pull request #13138: URL: https://github.com/apache/pulsar/pull/13138#issuecomment-987425838 @michaeljmarshall @freeznet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #13130: [Issue 13129] [pulsar-metadata] Add watchdog thread in metadata store and track long running tasks.

2021-12-06 Thread GitBox
bharanic-dev commented on a change in pull request #13130: URL: https://github.com/apache/pulsar/pull/13130#discussion_r763507842 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java ## @@ -317,7 +346,33 @@ public void

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #13130: [Issue 13129] [pulsar-metadata] Add watchdog thread in metadata store and track long running tasks.

2021-12-06 Thread GitBox
bharanic-dev commented on a change in pull request #13130: URL: https://github.com/apache/pulsar/pull/13130#discussion_r763194732 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java ## @@ -317,7 +346,33 @@ public void

[GitHub] [pulsar] bharanic-dev commented on pull request #13124: [Metadata] Log thread dump when Zookeeper session expires to help detect possible deadlocks

2021-12-06 Thread GitBox
bharanic-dev commented on pull request #13124: URL: https://github.com/apache/pulsar/pull/13124#issuecomment-987387572 @lhotari LGTM. I think this will help with https://github.com/apache/pulsar/pull/13130 as well. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #13130: [Issue 13129] [pulsar-metadata] Add watchdog thread in metadata store and track long running tasks.

2021-12-06 Thread GitBox
bharanic-dev commented on a change in pull request #13130: URL: https://github.com/apache/pulsar/pull/13130#discussion_r763507842 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java ## @@ -317,7 +346,33 @@ public void

[GitHub] [pulsar] amadav opened a new issue #13156: [python-client] Support KeySharedPolicy in consumer configuration

2021-12-06 Thread GitBox
amadav opened a new issue #13156: URL: https://github.com/apache/pulsar/issues/13156 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] Support for auto-hash and sticky-hash

[pulsar] branch master updated: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock (#12930)

2021-12-06 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5b0214a [Issue 12929] [pulsar-metadata] Fix

[GitHub] [pulsar] jerrypeng merged pull request #12930: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock

2021-12-06 Thread GitBox
jerrypeng merged pull request #12930: URL: https://github.com/apache/pulsar/pull/12930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] jerrypeng closed issue #12929: Deadlock in internalDeleteSubscription in metadata-store callback thread

2021-12-06 Thread GitBox
jerrypeng closed issue #12929: URL: https://github.com/apache/pulsar/issues/12929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo removed a comment on pull request #13090: [Authorization] Optimize the logic of allowing namespace operation

2021-12-06 Thread GitBox
yuruguo removed a comment on pull request #13090: URL: https://github.com/apache/pulsar/pull/13090#issuecomment-986239637 @eolivelli @michaeljmarshall ptal again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo commented on pull request #13090: [Authorization] Optimize the logic of allowing namespace operation

2021-12-06 Thread GitBox
yuruguo commented on pull request #13090: URL: https://github.com/apache/pulsar/pull/13090#issuecomment-987263389 > @yuruguo - unfortunately, my PR #13133 created merge conflicts for this PR, so you'll need to rebase. > > Based on looking at this PR and at #6428, I think there are a

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #13130: [Issue 13129] [pulsar-metadata] Add watchdog thread in metadata store and track long running tasks.

2021-12-06 Thread GitBox
bharanic-dev commented on a change in pull request #13130: URL: https://github.com/apache/pulsar/pull/13130#discussion_r763194732 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java ## @@ -317,7 +346,33 @@ public void

[GitHub] [pulsar] bharanic-dev commented on pull request #12930: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock

2021-12-06 Thread GitBox
bharanic-dev commented on pull request #12930: URL: https://github.com/apache/pulsar/pull/12930#issuecomment-987149372 @pkumar-singh, please see: https://github.com/apache/pulsar/pull/12930#discussion_r758845818 the callback executor is single-threaded. Let's say there is some

[GitHub] [pulsar] pkumar-singh commented on pull request #12930: [Issue 12929] [pulsar-metadata] Fix metadata store deadlock

2021-12-06 Thread GitBox
pkumar-singh commented on pull request #12930: URL: https://github.com/apache/pulsar/pull/12930#issuecomment-987139546 @bharanic-dev Why using async version of thenAccept would solve a deadlock? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lhotari commented on issue #12552: MaxRedirectException occurs when attempting to delete a subscription that was recently created and then had its topic destroyed

2021-12-06 Thread GitBox
lhotari commented on issue #12552: URL: https://github.com/apache/pulsar/issues/12552#issuecomment-987132001 > Should I file another bug? Or is that now expected behavior? @zbentley Yes, please file another issue. -- This is an automated message from the Apache Git

  1   2   >