[GitHub] [pulsar] wuzhanpeng commented on pull request #13208: fix shedding heartbeat ns

2021-12-10 Thread GitBox
wuzhanpeng commented on pull request #13208: URL: https://github.com/apache/pulsar/pull/13208#issuecomment-991510868 I think the proposal of `getBundleDataForLoadShedding` is great, it can effectively reduce the redundancy of the code, I have made changes, @Jason918 @hangc0276 can take a l

[GitHub] [pulsar] merlimat commented on a change in pull request #13236: [C++] Add Wireshark cmake and fix build with latest Wireshark

2021-12-10 Thread GitBox
merlimat commented on a change in pull request #13236: URL: https://github.com/apache/pulsar/pull/13236#discussion_r767104183 ## File path: pulsar-client-cpp/CMakeLists.txt ## @@ -58,6 +58,9 @@ MESSAGE(STATUS "BUILD_TESTS: " ${BUILD_TESTS}) option(BUILD_PYTHON_WRAPPER "Build

[pulsar] branch master updated (6d9d24d -> bd68b6f)

2021-12-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6d9d24d Use current resourceUsage value as historyUsage when leader change in ThresholdShedder (#13136) add bd

[GitHub] [pulsar] merlimat merged pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.

2021-12-10 Thread GitBox
merlimat merged pull request #13203: URL: https://github.com/apache/pulsar/pull/13203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat closed issue #12554: Attempting to delete a topic which has recently been created sometimes fails with a 500 error, with an internal broker error of "Maximum redirect reache

2021-12-10 Thread GitBox
merlimat closed issue #12554: URL: https://github.com/apache/pulsar/issues/12554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] merlimat commented on pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
merlimat commented on pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#issuecomment-991506253 > do we need a PIP here ? it is a big feature If you discount the license files, it's 1 single file containing an implementation which is not enabled by default and whic

[GitHub] [pulsar] merlimat commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
merlimat commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r767103805 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[pulsar] branch branch-2.7 updated: Remove RateLimiter constructors and replace with builder usage (#11599)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 0c48d23 Remove RateLimiter construct

[GitHub] [pulsar] michaeljmarshall commented on pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #11599: URL: https://github.com/apache/pulsar/pull/11599#issuecomment-991505534 Cherry picked to `branch-2.7` because one of the lines it removes is longer than 120 characters. Now `branch-2.7` passes checkstyle. -- This is an automated message

[GitHub] [pulsar] eolivelli commented on pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
eolivelli commented on pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#issuecomment-991498781 do we need a PIP here ? it is a big feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] eolivelli commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-10 Thread GitBox
eolivelli commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r767102340 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1997,7 +1997,31 @@ private boolean checkTransactionEn

[GitHub] [pulsar] yuruguo removed a comment on pull request #13237: [Broker] Modify return result of NamespacesBase#internalGetPublishRate

2021-12-10 Thread GitBox
yuruguo removed a comment on pull request #13237: URL: https://github.com/apache/pulsar/pull/13237#issuecomment-991490945 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13237: [Broker] Modify return result of NamespacesBase#internalGetPublishRate

2021-12-10 Thread GitBox
yuruguo commented on pull request #13237: URL: https://github.com/apache/pulsar/pull/13237#issuecomment-991490945 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] michaeljmarshall commented on pull request #11912: Forbid to read other topic's data in managedLedger layer

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #11912: URL: https://github.com/apache/pulsar/pull/11912#issuecomment-991480744 Note that this commit is not cherry picked to `branch-2.7` because the same changes are merged here https://github.com/apache/pulsar/pull/11913. -- This is an automa

[GitHub] [pulsar] yuruguo opened a new pull request #13237: [Broker] Modify return result of NamespacesBase#internalGetPublishRate

2021-12-10 Thread GitBox
yuruguo opened a new pull request #13237: URL: https://github.com/apache/pulsar/pull/13237 ### Motivation It should return `null` instead of `RestException` in method `NamespacesBase#internalGetPublishRate`, because `null` means that the `publish-rate` is not configured. It is the sa

[GitHub] [pulsar] Jason918 commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
Jason918 commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r767089475 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[pulsar] branch master updated: Use current resourceUsage value as historyUsage when leader change in ThresholdShedder (#13136)

2021-12-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6d9d24d Use current resourceUsage value as his

[GitHub] [pulsar] codelipenghui merged pull request #13136: Use current resourceUsage value as historyUsage when leader change in ThresholdShedder

2021-12-10 Thread GitBox
codelipenghui merged pull request #13136: URL: https://github.com/apache/pulsar/pull/13136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui closed issue #13119: Load balance shedding not in time with the strategy of ThresholdShedder

2021-12-10 Thread GitBox
codelipenghui closed issue #13119: URL: https://github.com/apache/pulsar/issues/13119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] Demogorgon314 opened a new pull request #13236: [C++] Add Wireshark cmake and fix build with latest Wireshark

2021-12-10 Thread GitBox
Demogorgon314 opened a new pull request #13236: URL: https://github.com/apache/pulsar/pull/13236 ### Motivation The Pulsar Wireshark dissector doesn't have a CMake file to build it, and in the latest Wireshark, the dissector API has changed. This PR is the minimizes support of Wireshark

[GitHub] [pulsar-client-go] longtengz commented on issue #681: DisableBatching still go thru the batching logic and AUTO_CONSUME can not consume with correct schema type

2021-12-10 Thread GitBox
longtengz commented on issue #681: URL: https://github.com/apache/pulsar-client-go/issues/681#issuecomment-991433969 That seems very confusing to me. If batch is disabled, why using a batchBuilder? From the comments in the code, I assume there's a difference in the format of batch message

[GitHub] [pulsar] hangc0276 commented on issue #13148: Cluster switching failed for producers

2021-12-10 Thread GitBox
hangc0276 commented on issue #13148: URL: https://github.com/apache/pulsar/issues/13148#issuecomment-991425783 We are designing a proposal for auto switch cluster service provider when one cluster is failed. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-10 Thread GitBox
liangyepianzhou commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r767078065 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java ## @@ -294,7 +340,27 @@ public void ha

[GitHub] [pulsar] merlimat commented on a change in pull request #13230: feat(docs): add more limitations for replicated subscriptions

2021-12-10 Thread GitBox
merlimat commented on a change in pull request #13230: URL: https://github.com/apache/pulsar/pull/13230#discussion_r767069070 ## File path: site2/docs/administration-geo.md ## @@ -214,4 +214,5 @@ Consumer consumer = client.newConsumer(Schema.STRING) ### Limitations -When

[GitHub] [pulsar] congbobo184 commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-10 Thread GitBox
congbobo184 commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r766675485 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java ## @@ -158,6 +178,12 @@ public void connect

[GitHub] [pulsar] github-actions[bot] commented on pull request #13234: [Transaction] Fix generate transactionId some comments

2021-12-10 Thread GitBox
github-actions[bot] commented on pull request #13234: URL: https://github.com/apache/pulsar/pull/13234#issuecomment-991400652 @congbobo184:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] 01/02: [pulsar-client] Process partitioned-topic messages on different listener-threads (#10017)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 2dd6b0722cc07fb3aa8c0ce428f013e52c38a669 Author: Rajan Dhabalia AuthorDate: Wed Mar 24 07:32:54 2021 -0700 [

[pulsar] 02/02: Fix Consumer listener does not respect receiver queue size (#11455)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 949a1eb628b08345bf51df8424e869640ef1f7dd Author: GuoJiwei AuthorDate: Fri Aug 6 16:06:18 2021 +0800 Fix Cons

[pulsar] branch branch-2.7 updated (deb9b0b -> 949a1eb)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from deb9b0b [broker] fix `GetTopicsOfNamespace` with binary lookup service not check auth (#11172) new 2dd6

[GitHub] [pulsar] michaeljmarshall commented on pull request #10017: [pulsar-client] Process partitioned-topic messages on different listener-threads

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #10017: URL: https://github.com/apache/pulsar/pull/10017#issuecomment-991370606 Cherry picking this to branch-2.7 because https://github.com/apache/pulsar/pull/11455 relies on part of it, and it simplifies the conflict resolution for the other com

[pulsar] branch branch-2.7 updated: [broker] fix `GetTopicsOfNamespace` with binary lookup service not check auth (#11172)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new deb9b0b [broker] fix `GetTopicsOfNam

[pulsar] branch branch-2.7 updated: PLSR-1470: Only auth _errors_ should log at error level (#9325)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 8e97d58 PLSR-1470: Only auth _errors

[GitHub] [pulsar-client-go] zzzming edited a comment on issue #681: DisableBatching still go thru the batching logic and AUTO_CONSUME can not consume with correct schema type

2021-12-10 Thread GitBox
zzzming edited a comment on issue #681: URL: https://github.com/apache/pulsar-client-go/issues/681#issuecomment-991325782 @longtengz Messages flushed by the BatchBuilder's through internalFlushCurrentBatch(). Even if the batch is disabled, the message still needs to be added to a batchBui

[GitHub] [pulsar-client-go] zzzming commented on pull request #678: [Issue 513] Correct apparent logic error in batchContainer's hasSpace() method

2021-12-10 Thread GitBox
zzzming commented on pull request #678: URL: https://github.com/apache/pulsar-client-go/pull/678#issuecomment-991337168 We should use this ``` bc.numMessages+1 <= bc.maxMessages ``` Because this will accommodate an individual message when batch is disabled. Currently this

[GitHub] [pulsar-client-go] zzzming commented on issue #681: DisableBatching still go thru the batching logic and AUTO_CONSUME can not consume with correct schema type

2021-12-10 Thread GitBox
zzzming commented on issue #681: URL: https://github.com/apache/pulsar-client-go/issues/681#issuecomment-991325782 @longtengz Messages flushed by the BatchBuilder's through internalFlushCurrentBatch(). Even if the batch is disabled, the message still needs to be added to a batchBuilder. W

[GitHub] [pulsar] michaeljmarshall commented on pull request #10775: Run code to respond to auth challenge in a different thread in the pulsar client

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #10775: URL: https://github.com/apache/pulsar/pull/10775#issuecomment-991325796 Removing `release/2.7.4` label, as this PR will not make the release. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[pulsar] 02/02: [Broker] Fix set-publish-rate when using preciseTopicPublishRateLimiterEnable=true (#10384)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit bdc62ecac2a96b5ff657b5e70c306df81e3fe93d Author: Lari Hotari AuthorDate: Tue Aug 3 19:14:26 2021 +0300 [Brok

[pulsar] 01/02: [Issue #11351] Parallel Precise Publish Rate Limiting Fix (#11372)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 46af23e3fb54675764f14153bb52303649b5b8c2 Author: Ron Farkash AuthorDate: Thu Jul 29 18:22:27 2021 +0300 [Iss

[pulsar] branch branch-2.7 updated (bc887d8 -> bdc62ec)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bc887d8 [issue #13351] Solving precise rate limiting does not takes effect (#11446) new 46af23e [Issue

[pulsar] branch branch-2.7 updated: [issue #13351] Solving precise rate limiting does not takes effect (#11446)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new bc887d8 [issue #13351] Solving preci

[pulsar] branch branch-2.7 updated: [Issue 8599] Fix DispatchRateLimiter does not take effect (#8611)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 0df22ad [Issue 8599] Fix DispatchRat

[GitHub] [pulsar] michaeljmarshall commented on issue #9940: Messages can get consumed out of order with key_shared subscriptions and small receiverQueueSize

2021-12-10 Thread GitBox
michaeljmarshall commented on issue #9940: URL: https://github.com/apache/pulsar/issues/9940#issuecomment-991191332 @fransguelinckx - can you confirm that this is still an issue? I am releasing 2.7.4 now, so I am going to remove the label. I believe there were some recent fixes to the key_

[GitHub] [pulsar] michaeljmarshall commented on issue #9697: Java Client: NullPointerException with GenericRecord.getField() on a sub-record

2021-12-10 Thread GitBox
michaeljmarshall commented on issue #9697: URL: https://github.com/apache/pulsar/issues/9697#issuecomment-991188550 @epsteina16 - can you confirm whether or not this bug is still present in recent releases of Pulsar? We are releasing 2.7.4 now, so I am going to remove this label. However,

[GitHub] [pulsar] michaeljmarshall commented on pull request #9219: support unackMessages stats for cumulative ack

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #9219: URL: https://github.com/apache/pulsar/pull/9219#issuecomment-991183171 @ltamber - do you plan on completing the work for this PR? There are conflicts right now. As such, I am going to remove the 2.7.4 label. I added the 2.10 milestone. If/w

[GitHub] [pulsar] michaeljmarshall commented on issue #9084: Improve handling of S3 offloading configuration in other regions

2021-12-10 Thread GitBox
michaeljmarshall commented on issue #9084: URL: https://github.com/apache/pulsar/issues/9084#issuecomment-991181693 Removing the release label. We need a PR to have a release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] michaeljmarshall commented on issue #8419: multiple pulsarAdmin.topics().grantPermission calls created excessive transactions on the zookeepers

2021-12-10 Thread GitBox
michaeljmarshall commented on issue #8419: URL: https://github.com/apache/pulsar/issues/8419#issuecomment-991179307 Since we don't have a PR for this, I am going to remove the 2.7.4 label. We should still try to fix it, of course, but there is no target release if we don't have a commit.

[GitHub] [pulsar] michaeljmarshall commented on issue #7804: ConcurrentModificationException occurs when dispatch message to consumers

2021-12-10 Thread GitBox
michaeljmarshall commented on issue #7804: URL: https://github.com/apache/pulsar/issues/7804#issuecomment-991178015 @codelipenghui - removing the 2.7.4 label. I'm not sure that we'll do a 2.7.5 release. We'll determine which branches to cherry pick to when this is completed/merged. -- T

[GitHub] [pulsar] loganloganlogan opened a new issue #13235: PIP 113: Update Pulsar Website Design & Content

2021-12-10 Thread GitBox
loganloganlogan opened a new issue #13235: URL: https://github.com/apache/pulsar/issues/13235 ## Motivation and Goal Several ML threads indicated that the Pulsar site underrepresented the technology and community. Our goal is to make the Pulsar website the premier destination for end us

[GitHub] [pulsar] michaeljmarshall commented on pull request #13215: [branch-2.7] Upgrade netty to 4.1.68.Final

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #13215: URL: https://github.com/apache/pulsar/pull/13215#issuecomment-991173029 @eolivelli let me know over slack that these tests are very flaky. I am going to keep retriggering the builds a little bit more before I dig into the tests any more.

[GitHub] [pulsar] lhotari closed pull request #13122: Trigger a build for branch-2.8 to see if the build passes

2021-12-10 Thread GitBox
lhotari closed pull request #13122: URL: https://github.com/apache/pulsar/pull/13122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] lhotari closed issue #13232: [security vulnerability] Remote code injection in Log4j

2021-12-10 Thread GitBox
lhotari closed issue #13232: URL: https://github.com/apache/pulsar/issues/13232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [pulsar] lhotari commented on issue #13232: [security vulnerability] Remote code injection in Log4j

2021-12-10 Thread GitBox
lhotari commented on issue #13232: URL: https://github.com/apache/pulsar/issues/13232#issuecomment-991166440 Addressed by #13226 I have posted information about Log4Shell mitigations for existing Pulsar releases on the mailing list: https://lists.apache.org/thread/pf8wfzt09c2dv4z29

[GitHub] [pulsar] lhotari closed pull request #13231: [Issue 13232]Remote code injection in Log4j: Avoid a remote code execution vulnerability via the ldap JNDI parser.

2021-12-10 Thread GitBox
lhotari closed pull request #13231: URL: https://github.com/apache/pulsar/pull/13231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] lhotari commented on pull request #13231: [Issue 13232]Remote code injection in Log4j: Avoid a remote code execution vulnerability via the ldap JNDI parser.

2021-12-10 Thread GitBox
lhotari commented on pull request #13231: URL: https://github.com/apache/pulsar/pull/13231#issuecomment-991165677 The system property workaround is useful for existing versions. I have posted information about a mitigation for Log4Shell on the mailing list: https://lists.apache.org/thre

[pulsar] branch master updated (f0da648 -> 50be3f8)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f0da648 [Issue 11846][Java client] Create a consumer in the paused state (#11974) add 50be3f8 Apache Pulsa

[GitHub] [pulsar] michaeljmarshall merged pull request #12425: Apache Pulsar 2.9.0 release notes

2021-12-10 Thread GitBox
michaeljmarshall merged pull request #12425: URL: https://github.com/apache/pulsar/pull/12425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [pulsar] michaeljmarshall commented on pull request #12425: Apache Pulsar 2.9.0 release notes

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #12425: URL: https://github.com/apache/pulsar/pull/12425#issuecomment-991152165 Merging now. If anyone would like to adjust the notes, please submit a PR. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12425: Apache Pulsar 2.9.0 release notes

2021-12-10 Thread GitBox
michaeljmarshall commented on a change in pull request #12425: URL: https://github.com/apache/pulsar/pull/12425#discussion_r766845688 ## File path: site2/website/release-notes.md ## @@ -1,8 +1,107 @@ ## Apache Pulsar Release Notes -### 2.8.1 +### 2.9.0 + 2021-11-25 +##

[GitHub] [pulsar] michaeljmarshall commented on pull request #13215: [branch-2.7] Upgrade netty to 4.1.68.Final

2021-12-10 Thread GitBox
michaeljmarshall commented on pull request #13215: URL: https://github.com/apache/pulsar/pull/13215#issuecomment-991132520 I'm looking into why these tests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch asf-site updated: Publish new charts to https://pulsar.apache.org/charts/

2021-12-10 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 41e3872 Publish new charts to https://pulsar

[pulsar-helm-chart] branch master updated (a16c6bb -> b4b2fa7)

2021-12-10 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git. from a16c6bb Make k8s probe timeoutSeconds configurable and set default to 5s for k8s 1.20+ compatibility (#

[pulsar-helm-chart] tag pulsar-2.7.6 created (now b4b2fa7)

2021-12-10 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to tag pulsar-2.7.6 in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git. at b4b2fa7 (commit) No new revisions were added by this update.

[GitHub] [pulsar] kellyfj commented on pull request #13215: [branch-2.7] Upgrade netty to 4.1.68.Final

2021-12-10 Thread GitBox
kellyfj commented on pull request #13215: URL: https://github.com/apache/pulsar/pull/13215#issuecomment-991117829 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] merlimat commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
merlimat commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r766806671 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[pulsar] branch master updated (0ce155e -> f0da648)

2021-12-10 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0ce155e Fix MessagePayloadContextImpl not recycled (#13233) add f0da648 [Issue 11846][Java client] Create a

[GitHub] [pulsar] merlimat commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
merlimat commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r766804617 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[pulsar] branch master updated (e8444d2 -> 0ce155e)

2021-12-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e8444d2 Add basic DOAP file for Pulsar (#11864) add 0ce155e Fix MessagePayloadContextImpl not recycled (#13233

[GitHub] [pulsar] merlimat commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-10 Thread GitBox
merlimat commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r766803140 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] michaeljmarshall merged pull request #11974: [Issue 11846][Java client] Create a consumer in the paused state

2021-12-10 Thread GitBox
michaeljmarshall merged pull request #11974: URL: https://github.com/apache/pulsar/pull/11974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [pulsar] michaeljmarshall closed issue #11846: [Java client] Allow consumer to be created in a paused state

2021-12-10 Thread GitBox
michaeljmarshall closed issue #11846: URL: https://github.com/apache/pulsar/issues/11846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] merlimat merged pull request #13233: [Client] Fix memory leak when message payload processor is configured

2021-12-10 Thread GitBox
merlimat merged pull request #13233: URL: https://github.com/apache/pulsar/pull/13233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch master updated: Add basic DOAP file for Pulsar (#11864)

2021-12-10 Thread wave
This is an automated email from the ASF dual-hosted git repository. wave pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e8444d2 Add basic DOAP file for Pulsar (#11864) e

[GitHub] [pulsar] dave2wave merged pull request #11864: Add basic DOAP file for Pulsar

2021-12-10 Thread GitBox
dave2wave merged pull request #11864: URL: https://github.com/apache/pulsar/pull/11864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] eolivelli commented on pull request #12425: Apache Pulsar 2.9.0 release notes

2021-12-10 Thread GitBox
eolivelli commented on pull request #12425: URL: https://github.com/apache/pulsar/pull/12425#issuecomment-991027151 @Anonymitaet I have removed the misc section, moving more PRs to other sections. I have fixed all the titles of the PRs I believe that this patch is in good shape an

[GitHub] [pulsar] murong00 commented on pull request #13218: [Issue 13217][pulsar-package-management] Fix the filesystem storage failure

2021-12-10 Thread GitBox
murong00 commented on pull request #13218: URL: https://github.com/apache/pulsar/pull/13218#issuecomment-991003608 ping @zymap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pulsar] kellyfj commented on pull request #13215: [branch-2.7] Upgrade netty to 4.1.68.Final

2021-12-10 Thread GitBox
kellyfj commented on pull request #13215: URL: https://github.com/apache/pulsar/pull/13215#issuecomment-990986509 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] jonaskint commented on issue #13232: [security vulnerability] Remote code injection in Log4j

2021-12-10 Thread GitBox
jonaskint commented on issue #13232: URL: https://github.com/apache/pulsar/issues/13232#issuecomment-990957483 > already fixed: #13226 Any idea when the actual tags will be released? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] murong00 commented on pull request #13218: [Issue 13217][pulsar-package-management] Fix the filesystem storage failure

2021-12-10 Thread GitBox
murong00 commented on pull request #13218: URL: https://github.com/apache/pulsar/pull/13218#issuecomment-990926318 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[pulsar-adapters] branch master updated: Upgrade Log4J2 to 2.15.0 to mitigate CVE-2021-44228 (#30)

2021-12-10 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-adapters.git The following commit(s) were added to refs/heads/master by this push: new ef29667 Upgrade Log4J2 to 2.15.0 to

[GitHub] [pulsar] YouJiacheng edited a comment on issue #13232: [security vulnerability] Remote code injection in Log4j

2021-12-10 Thread GitBox
YouJiacheng edited a comment on issue #13232: URL: https://github.com/apache/pulsar/issues/13232#issuecomment-990893143 already fixed: https://github.com/apache/pulsar/pull/13226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] YouJiacheng edited a comment on issue #13232: [security vulnerability] Remote code injection in Log4j

2021-12-10 Thread GitBox
YouJiacheng edited a comment on issue #13232: URL: https://github.com/apache/pulsar/issues/13232#issuecomment-990893143 already fix: https://github.com/apache/pulsar/pull/13226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pulsar] YouJiacheng commented on issue #13232: [security vulnerability] Remote code injection in Log4j

2021-12-10 Thread GitBox
YouJiacheng commented on issue #13232: URL: https://github.com/apache/pulsar/issues/13232#issuecomment-990893143 already fix: https://github.com/apache/pulsar/commit/b136a734eecf5719780f5dc4c97e7a7c395af3d6 > -- This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] congbobo184 commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-10 Thread GitBox
congbobo184 commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r766602200 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java ## @@ -432,38 +705,43 @@ private void onRes

[GitHub] [pulsar] YouJiacheng commented on issue #13175: [Pulsar-Reader] Support setting specified end MessageID or publish time.

2021-12-10 Thread GitBox
YouJiacheng commented on issue #13175: URL: https://github.com/apache/pulsar/issues/13175#issuecomment-990887983 You can just wrap(use inheritance) reader class to implement this feature. No need to modify pulsar. And your wrapped API will handle this check, you don't need repeat code for

[GitHub] [pulsar] github-actions[bot] commented on pull request #13234: [Transaction] Fix generate transactionId some comments

2021-12-10 Thread GitBox
github-actions[bot] commented on pull request #13234: URL: https://github.com/apache/pulsar/pull/13234#issuecomment-990886104 @congbobo184:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/bl

[GitHub] [pulsar] congbobo184 commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-10 Thread GitBox
congbobo184 commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r766570924 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java ## @@ -206,8 +228,23 @@ void handleNewTxnRe

[GitHub] [pulsar] congbobo184 opened a new pull request #13234: [Transaction] Fix generate transactionId some comment.

2021-12-10 Thread GitBox
congbobo184 opened a new pull request #13234: URL: https://github.com/apache/pulsar/pull/13234 link #13209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13118: [DOCS] Update the Package Management page

2021-12-10 Thread GitBox
Anonymitaet commented on a change in pull request #13118: URL: https://github.com/apache/pulsar/pull/13118#discussion_r766571137 ## File path: site2/docs/admin-api-packages.md ## @@ -109,142 +124,168 @@ bin/pulsar-admin packages download functions://public/default/example@v0.1

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13118: [DOCS] Update the Package Management page

2021-12-10 Thread GitBox
Anonymitaet commented on a change in pull request #13118: URL: https://github.com/apache/pulsar/pull/13118#discussion_r766522806 ## File path: site2/docs/admin-api-packages.md ## @@ -4,77 +4,57 @@ title: Manage packages sidebar_label: Packages --- -> **Important** -> -> Thi

[GitHub] [pulsar] lhotari commented on pull request #13226: Bump log4j to 2.15.0

2021-12-10 Thread GitBox
lhotari commented on pull request #13226: URL: https://github.com/apache/pulsar/pull/13226#issuecomment-990830116 > [CVE-2021-44228](https://github.com/advisories/GHSA-jfh8-c2jp-5v3q) is triggered if user provided input is passed to Logger's debug/info/warn/error method directly. It doesn'

[GitHub] [pulsar] hangc0276 commented on issue #13175: [Pulsar-Reader] Support setting specified end MessageID or publish time.

2021-12-10 Thread GitBox
hangc0276 commented on issue #13175: URL: https://github.com/apache/pulsar/issues/13175#issuecomment-990812067 @merlimat We can just check the MessageId or publish time when received the message. I wonder do we really need this feature? It may makes pulsar more complex. -- This is an au

[GitHub] [pulsar] BewareMyPower commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured

2021-12-10 Thread GitBox
BewareMyPower commented on pull request #13233: URL: https://github.com/apache/pulsar/pull/13233#issuecomment-990809417 @codelipenghui I think the behavior depends on the implementation of Netty recycler. BTW, I have sent [an email](https://lists.apache.org/thread/9jmytp51f2o4gp9w2v

[GitHub] [pulsar] hangc0276 commented on issue #13178: Producer publishMessage uses a wrong sequence id?

2021-12-10 Thread GitBox
hangc0276 commented on issue #13178: URL: https://github.com/apache/pulsar/issues/13178#issuecomment-990808467 @leizhiyuan Would you please write a test the confirm the problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] codelipenghui commented on pull request #13208: fix shedding heartbeat ns

2021-12-10 Thread GitBox
codelipenghui commented on pull request #13208: URL: https://github.com/apache/pulsar/pull/13208#issuecomment-990805723 > And there is another special namespace "SLA_NAMESPACE", do we need to avoid this LoadShedding too? Yes, we should also filter out the SLA_NAMESPACE, but not requi

[pulsar] branch master updated (00127bcc -> 355135c)

2021-12-10 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 00127bcc [ Java Client ] fix parseProtobufSchema method will be called two times (#13163) add 355135c Fix log

[GitHub] [pulsar] codelipenghui merged pull request #13123: Fix log problem in ThreadRuntime, make it's member final

2021-12-10 Thread GitBox
codelipenghui merged pull request #13123: URL: https://github.com/apache/pulsar/pull/13123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui merged pull request #13163: [ Java Client ] fix parseProtobufSchema method will be called two times.

2021-12-10 Thread GitBox
codelipenghui merged pull request #13163: URL: https://github.com/apache/pulsar/pull/13163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] github-actions[bot] commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured

2021-12-10 Thread GitBox
github-actions[bot] commented on pull request #13233: URL: https://github.com/apache/pulsar/pull/13233#issuecomment-990795686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar-client-go] longtengz commented on issue #680: Pulsar sql EOF exception when using go client to send empty payload

2021-12-10 Thread GitBox
longtengz commented on issue #680: URL: https://github.com/apache/pulsar-client-go/issues/680#issuecomment-990795713 The thing is I used go client to produce messages in any shape or form (e.g. only nil out one nullable field), and none of them came back successfully in pulsar sql. But th

[GitHub] [pulsar] hangc0276 commented on issue #13219: BKNoSuchLedgerExistsException occurred during offload and the ledger is missing in tiered storage

2021-12-10 Thread GitBox
hangc0276 commented on issue #13219: URL: https://github.com/apache/pulsar/issues/13219#issuecomment-990795572 The ledger 33033 has been deleted by retention during offloading, so it is the expected behavior. -- This is an automated message from the Apache Git Service. To respond to the

  1   2   >