[pulsar] 02/02: Add maven.restlet.org repository (#13248)

2021-12-15 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.6 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 50c5dfe94dc1df362adfc1954e41f388f5630cf2 Author: lipenghui AuthorDate: Sun Dec 12 22:42:39 2021 +0800 Add mave

[pulsar] 01/02: Bump log4j to 2.16.0 (#13277)

2021-12-15 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.6 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0de7dd667c119e70e4aea615eedb5e07f14bd958 Author: Michael Marshall AuthorDate: Tue Dec 14 00:53:52 2021 -0600 B

[pulsar] branch branch-2.6 updated (f7c6bdb -> 50c5dfe)

2021-12-15 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.6 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f7c6bdb Bump log4j to 2.15.0 (#13226) new 0de7dd6 Bump log4j to 2.16.0 (#13277) new 50c5dfe Add mav

svn commit: r51494 - /dev/pulsar/pulsar-2.8.2-candidate-1/

2021-12-15 Thread linlin
Author: linlin Date: Thu Dec 16 07:55:38 2021 New Revision: 51494 Log: Remove pulsar-2.8.2-candidate-1 Removed: dev/pulsar/pulsar-2.8.2-candidate-1/

[GitHub] [pulsar] Anonymitaet commented on pull request #13311: [website][upgrade]feat: website upgrade / docs migration - 2.2.1 / deploy/io/sql

2021-12-15 Thread GitBox
Anonymitaet commented on pull request #13311: URL: https://github.com/apache/pulsar/pull/13311#issuecomment-995523597 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #13204: support limit message size produced by protocol handlers by maxMessag…

2021-12-15 Thread GitBox
gaozhangmin commented on a change in pull request #13204: URL: https://github.com/apache/pulsar/pull/13204#discussion_r770292596 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -219,6 +208,7 @@ protected MutableLong initialValue(

[GitHub] [pulsar] Jason918 commented on a change in pull request #13297: Add schema compatibility strategy on topic level

2021-12-15 Thread GitBox
Jason918 commented on a change in pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#discussion_r770284194 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java ## @@ -3693,4 +3694,47 @@ void setSubscriptionTypesEnabl

[pulsar] branch master updated (d7eea00 -> 1eb9226)

2021-12-15 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d7eea00 Remove deprecated Mockito api use (#13329) add 1eb9226 [website][upgrade]feat: website upgrade / docs m

[GitHub] [pulsar] Anonymitaet merged pull request #13310: [website][upgrade]feat: website upgrade / docs migration - 2.2.1 / started/functions/concepts

2021-12-15 Thread GitBox
Anonymitaet merged pull request #13310: URL: https://github.com/apache/pulsar/pull/13310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] Haaroon commented on issue #13301: File Connector repeats reading the same file if not deleted

2021-12-15 Thread GitBox
Haaroon commented on issue #13301: URL: https://github.com/apache/pulsar/issues/13301#issuecomment-995513022 Well no it's a bug, not feature. How ridiculous. It shouldn't be like this. You cannot expect the user to want to delete their files. It should just skip files already processed.

[GitHub] [pulsar] hpvd edited a comment on pull request #13316: PIP-121: Pulsar cluster level auto failover [WIP]

2021-12-15 Thread GitBox
hpvd edited a comment on pull request #13316: URL: https://github.com/apache/pulsar/pull/13316#issuecomment-995509184 > As you mentioned, we use geo-replication to support cluster failover, that means there might be have more than two cluster. In the implementation, we only can configure t

[GitHub] [pulsar] hpvd edited a comment on pull request #13316: PIP-121: Pulsar cluster level auto failover [WIP]

2021-12-15 Thread GitBox
hpvd edited a comment on pull request #13316: URL: https://github.com/apache/pulsar/pull/13316#issuecomment-995509184 > As you mentioned, we use geo-replication to support cluster failover, that means there might be have more than two cluster. In the implementation, we only can configure t

[GitHub] [pulsar] hpvd edited a comment on pull request #13316: PIP-121: Pulsar cluster level auto failover [WIP]

2021-12-15 Thread GitBox
hpvd edited a comment on pull request #13316: URL: https://github.com/apache/pulsar/pull/13316#issuecomment-995509184 > As you mentioned, we use geo-replication to support cluster failover, that means there might be have more than two cluster. In the implementation, we only can configure t

[GitHub] [pulsar] hpvd commented on pull request #13316: PIP-121: Pulsar cluster level auto failover [WIP]

2021-12-15 Thread GitBox
hpvd commented on pull request #13316: URL: https://github.com/apache/pulsar/pull/13316#issuecomment-995509184 > As you mentioned, we use geo-replication to support cluster failover, that means there might be have more than two cluster. In the implementation, we only can configure two clus

[GitHub] [pulsar] wangjialing218 commented on a change in pull request #13204: support limit message size produced by protocol handlers by maxMessag…

2021-12-15 Thread GitBox
wangjialing218 commented on a change in pull request #13204: URL: https://github.com/apache/pulsar/pull/13204#discussion_r770279321 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -219,6 +208,7 @@ protected MutableLong initialVal

[GitHub] [pulsar] wangjialing218 commented on a change in pull request #13204: support limit message size produced by protocol handlers by maxMessag…

2021-12-15 Thread GitBox
wangjialing218 commented on a change in pull request #13204: URL: https://github.com/apache/pulsar/pull/13204#discussion_r770273783 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2274,6 +2289,21 @@ private void updateManage

[GitHub] [pulsar] Jason918 commented on a change in pull request #13204: support limit message size produced by protocol handlers by maxMessag…

2021-12-15 Thread GitBox
Jason918 commented on a change in pull request #13204: URL: https://github.com/apache/pulsar/pull/13204#discussion_r770265023 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2274,6 +2289,26 @@ private void updateManagedLedge

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #13336: [Doc] add explanations for broker entry metadata

2021-12-15 Thread GitBox
BewareMyPower commented on a change in pull request #13336: URL: https://github.com/apache/pulsar/pull/13336#discussion_r770267038 ## File path: site2/docs/reference-configuration.md ## @@ -354,6 +354,8 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size i

[GitHub] [pulsar] 315157973 opened a new pull request #13353: Fix incompatibility of BacklogQuota (#13291)

2021-12-15 Thread GitBox
315157973 opened a new pull request #13353: URL: https://github.com/apache/pulsar/pull/13353 ### Motivation cherry-pick pr #13291 # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/util/ObjectMapperFactoryTest.java # pulsar-metadata/src/test/java

[GitHub] [pulsar] Shoothzj opened a new pull request #13354: [security] Allow to config web server's cipher and protocols

2021-12-15 Thread GitBox
Shoothzj opened a new pull request #13354: URL: https://github.com/apache/pulsar/pull/13354 ### Motivation For the security, people want to config the support `ciphers` and `protocols` ### Modifications - Allow the broker and proxy config web server's `ciphers` and `protocols`

[GitHub] [pulsar] github-actions[bot] commented on pull request #13352: PIP-119: Enable consistent hashing by default on KeyShared subscriptions dispatcher

2021-12-15 Thread GitBox
github-actions[bot] commented on pull request #13352: URL: https://github.com/apache/pulsar/pull/13352#issuecomment-995491502 @HQebupt:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] HQebupt opened a new pull request #13352: PIP-119: Enable consistent hashing by default on KeyShared subscriptions dispatcher

2021-12-15 Thread GitBox
HQebupt opened a new pull request #13352: URL: https://github.com/apache/pulsar/pull/13352 implement #13305 ### Motivation See #13305 ### Modifications Change `subscriptionKeySharedUseConsistentHashing ` default value from **false** to **true** in the ` broker.conf `.

[GitHub] [pulsar] Shoothzj commented on pull request #13351: Replace serveral deprecated api usages

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13351: URL: https://github.com/apache/pulsar/pull/13351#issuecomment-995475778 @codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] HQebupt commented on pull request #13341: PIP-118: reconnect broker when ZooKeeper session expires

2021-12-15 Thread GitBox
HQebupt commented on pull request #13341: URL: https://github.com/apache/pulsar/pull/13341#issuecomment-995471208 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] mattisonchao commented on issue #13283: websocket when ssl tsl is enabled, error reported: Error during handshake

2021-12-15 Thread GitBox
mattisonchao commented on issue #13283: URL: https://github.com/apache/pulsar/issues/13283#issuecomment-995469802 > Same problem in #12303 ? @casuallc Maybe we need to clearly explain in the document. what do you think about it ? -- This is an automated message from the Ap

[GitHub] [pulsar] mattisonchao removed a comment on issue #13283: websocket when ssl tsl is enabled, error reported: Error during handshake

2021-12-15 Thread GitBox
mattisonchao removed a comment on issue #13283: URL: https://github.com/apache/pulsar/issues/13283#issuecomment-995355060 @hangc0276 I think i can help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-ganyu commented on a change in pull request #13350: Fix maven.restlet.org repository does not download jar packages

2021-12-15 Thread GitBox
github-ganyu commented on a change in pull request #13350: URL: https://github.com/apache/pulsar/pull/13350#discussion_r770247381 ## File path: pom.xml ## @@ -2341,9 +2341,8 @@ flexible messaging model and an intuitive client API. - maven.restlet.org -

[GitHub] [pulsar] tongsucn commented on pull request #13293: [Issue 13285][pulsar-client] Optimize MessageBuilder and SharedBuffer to avoid unnecessary memory copy.

2021-12-15 Thread GitBox
tongsucn commented on pull request #13293: URL: https://github.com/apache/pulsar/pull/13293#issuecomment-995465472 > @tongsucn You should either rebase or merge with master as there were some merge conflicts that make the checkstyle to fail. It's already fixed in latest master. @mer

[GitHub] [pulsar] gaozhangmin commented on issue #13347: Support user defined and pluggable consumer selector

2021-12-15 Thread GitBox
gaozhangmin commented on issue #13347: URL: https://github.com/apache/pulsar/issues/13347#issuecomment-995460957 I can help implement it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar] Shoothzj opened a new pull request #13351: Replace serveral deprecated api usages

2021-12-15 Thread GitBox
Shoothzj opened a new pull request #13351: URL: https://github.com/apache/pulsar/pull/13351 ### Modifications Replace serveral deprecated api usages ### Documentation Check the box below and label this PR (if you have committer privilege). Need to update docs?

[GitHub] [pulsar] HQebupt commented on pull request #13344: PIP-120 : Enable client memory limit controller by default

2021-12-15 Thread GitBox
HQebupt commented on pull request #13344: URL: https://github.com/apache/pulsar/pull/13344#issuecomment-995440175 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] HQebupt commented on pull request #13341: PIP-118: reconnect broker when ZooKeeper session expires

2021-12-15 Thread GitBox
HQebupt commented on pull request #13341: URL: https://github.com/apache/pulsar/pull/13341#issuecomment-995440035 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] rdhabalia commented on a change in pull request #13196: [pulsar-broker] clean up active consumer on already closed connection

2021-12-15 Thread GitBox
rdhabalia commented on a change in pull request #13196: URL: https://github.com/apache/pulsar/pull/13196#discussion_r770224974 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -804,6 +804,16 @@ protected void hand

[GitHub] [pulsar] rdhabalia commented on a change in pull request #13196: [pulsar-broker] clean up active consumer on already closed connection

2021-12-15 Thread GitBox
rdhabalia commented on a change in pull request #13196: URL: https://github.com/apache/pulsar/pull/13196#discussion_r770224974 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -804,6 +804,16 @@ protected void hand

[GitHub] [pulsar] ericsyh commented on a change in pull request #13295: fix(docs): update links in isolation docs

2021-12-15 Thread GitBox
ericsyh commented on a change in pull request #13295: URL: https://github.com/apache/pulsar/pull/13295#discussion_r770222961 ## File path: site2/docs/administration-isolation.md ## @@ -22,7 +22,7 @@ You can set a namespace isolation policy for a cluster using one of the follow

[GitHub] [pulsar] nodece commented on pull request #13297: Add schema compatibility strategy on topic level

2021-12-15 Thread GitBox
nodece commented on pull request #13297: URL: https://github.com/apache/pulsar/pull/13297#issuecomment-995422216 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] liangyepianzhou commented on pull request #13348: [Transaction] Do not abort when commit a problematic txn, but throw an exception

2021-12-15 Thread GitBox
liangyepianzhou commented on pull request #13348: URL: https://github.com/apache/pulsar/pull/13348#issuecomment-995422101 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-995419920 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-995419920 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13350: Fix maven.restlet.org repository does not download jar packages

2021-12-15 Thread GitBox
Demogorgon314 commented on a change in pull request #13350: URL: https://github.com/apache/pulsar/pull/13350#discussion_r770208572 ## File path: pom.xml ## @@ -2341,9 +2341,8 @@ flexible messaging model and an intuitive client API. - maven.restlet.org

[GitHub] [pulsar] github-ganyu commented on a change in pull request #13350: Fix maven.restlet.org repository does not download jar packages

2021-12-15 Thread GitBox
github-ganyu commented on a change in pull request #13350: URL: https://github.com/apache/pulsar/pull/13350#discussion_r770206042 ## File path: pom.xml ## @@ -2341,9 +2341,8 @@ flexible messaging model and an intuitive client API. - maven.restlet.org -

[GitHub] [pulsar] HQebupt commented on pull request #13341: PIP-118: reconnect broker when ZooKeeper session expires

2021-12-15 Thread GitBox
HQebupt commented on pull request #13341: URL: https://github.com/apache/pulsar/pull/13341#issuecomment-995416184 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] HQebupt edited a comment on pull request #13344: PIP-120 : Enable client memory limit controller by default

2021-12-15 Thread GitBox
HQebupt edited a comment on pull request #13344: URL: https://github.com/apache/pulsar/pull/13344#issuecomment-995415760 > @HQebupt:Thanks for your contribution. For this PR, do we need to update docs? > (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/ma

[GitHub] [pulsar] HQebupt commented on pull request #13344: PIP-120 : Enable client memory limit controller by default

2021-12-15 Thread GitBox
HQebupt commented on pull request #13344: URL: https://github.com/apache/pulsar/pull/13344#issuecomment-995415760 > @HQebupt:Thanks for your contribution. For this PR, do we need to update docs? > (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.g

[GitHub] [pulsar] HQebupt commented on pull request #13344: PIP-120 : Enable client memory limit controller by default

2021-12-15 Thread GitBox
HQebupt commented on pull request #13344: URL: https://github.com/apache/pulsar/pull/13344#issuecomment-995415605 > the test `org.apache.pulsar.client.impl.ProducerBuilderImplTest#testProducerBuilderImplWhenMaxPendingMessagesAcrossPartitionsPropertyIsInvalid` need to be modified too

[GitHub] [pulsar] HQebupt commented on a change in pull request #13344: PIP-120 : Enable client memory limit controller by default

2021-12-15 Thread GitBox
HQebupt commented on a change in pull request #13344: URL: https://github.com/apache/pulsar/pull/13344#discussion_r770205313 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java ## @@ -172,7 +172,7 @@ * the client application. U

[GitHub] [pulsar] github-actions[bot] commented on pull request #13350: Fix maven.restlet.org repository does not download jar packages

2021-12-15 Thread GitBox
github-actions[bot] commented on pull request #13350: URL: https://github.com/apache/pulsar/pull/13350#issuecomment-995408340 @github-ganyu:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/b

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13350: Fix maven.restlet.org repository does not download jar packages

2021-12-15 Thread GitBox
Demogorgon314 commented on a change in pull request #13350: URL: https://github.com/apache/pulsar/pull/13350#discussion_r770199008 ## File path: pom.xml ## @@ -2341,9 +2341,8 @@ flexible messaging model and an intuitive client API. - maven.restlet.org

[GitHub] [pulsar] github-ganyu opened a new pull request #13350: Fix maven.restlet.org repository does not download jar packages

2021-12-15 Thread GitBox
github-ganyu opened a new pull request #13350: URL: https://github.com/apache/pulsar/pull/13350 I couldn't download the JAR package when using maven.restlet.org, when I look at https://mvnrepository.com/artifact/org.restlet.jee/org.restlet/2.4.3 to see hints: this artifact is located

[GitHub] [pulsar] gaozhangmin commented on issue #13347: Support user defined and pluggable consumer selector

2021-12-15 Thread GitBox
gaozhangmin commented on issue #13347: URL: https://github.com/apache/pulsar/issues/13347#issuecomment-995399633 Consumer selector is only used in Key_Shared mode. Right? May be we can implement it like `MessageRouter`. -- This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] liangyepianzhou closed pull request #13331: [Transaction]Allow commit when commiting

2021-12-15 Thread GitBox
liangyepianzhou closed pull request #13331: URL: https://github.com/apache/pulsar/pull/13331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [pulsar] Demogorgon314 opened a new pull request #13349: [C++] Add clang-format check for Pulsar Wireshark dissector

2021-12-15 Thread GitBox
Demogorgon314 opened a new pull request #13349: URL: https://github.com/apache/pulsar/pull/13349 ### Motivation Currently, the Pulsar Wireshark dissector code doesn't format with clang style, we should add clang-format to format it. ### Modifications Add clang-format to

[GitHub] [pulsar] casuallc commented on issue #13283: websocket when ssl tsl is enabled, error reported: Error during handshake

2021-12-15 Thread GitBox
casuallc commented on issue #13283: URL: https://github.com/apache/pulsar/issues/13283#issuecomment-995391206 Websocket server is a proxy :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pulsar] casuallc commented on issue #13283: websocket when ssl tsl is enabled, error reported: Error during handshake

2021-12-15 Thread GitBox
casuallc commented on issue #13283: URL: https://github.com/apache/pulsar/issues/13283#issuecomment-995390788 Same problem in #12303 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] liangyepianzhou opened a new pull request #13348: [Transaction] Do not abort when commit a problematic txn, instead of throwing exception

2021-12-15 Thread GitBox
liangyepianzhou opened a new pull request #13348: URL: https://github.com/apache/pulsar/pull/13348 ### Motivation We should no abort the txn when user commit the txn which has oprations failed. ### Modification Throw an exception when commit a problematic Txn ### Verifying t

[GitHub] [pulsar] yuruguo commented on a change in pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo commented on a change in pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#discussion_r770186142 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java ## @@ -122,7 +122,7 @@ @Path("/{property}/{cluster}/{na

[GitHub] [pulsar] zymap commented on a change in pull request #13316: PIP-121: Pulsar cluster level auto failover [WIP]

2021-12-15 Thread GitBox
zymap commented on a change in pull request #13316: URL: https://github.com/apache/pulsar/pull/13316#discussion_r770172945 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/AutoClusterFailover.java ## @@ -0,0 +1,234 @@ +/** + * Licensed to the Apache Soft

[GitHub] [pulsar] casuallc commented on issue #13301: File Connector repeats reading the same file if not deleted

2021-12-15 Thread GitBox
casuallc commented on issue #13301: URL: https://github.com/apache/pulsar/issues/13301#issuecomment-995386264 It's a feature. ``` /** * If true, the file is not deleted after it has been processed and * causes the file to be picked up continually. */ private Boolean

[GitHub] [pulsar] HQebupt commented on pull request #13341: PIP-118: reconnect broker when ZooKeeper session expires

2021-12-15 Thread GitBox
HQebupt commented on pull request #13341: URL: https://github.com/apache/pulsar/pull/13341#issuecomment-995380896 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13336: [Doc] add explanations for broker entry metadata

2021-12-15 Thread GitBox
Anonymitaet commented on a change in pull request #13336: URL: https://github.com/apache/pulsar/pull/13336#discussion_r770174526 ## File path: site2/docs/developing-binary-protocol.md ## @@ -63,6 +63,14 @@ It is created by the broker when the message arrived at the broker and

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13336: [Doc] add explanations for broker entry metadata

2021-12-15 Thread GitBox
Anonymitaet commented on a change in pull request #13336: URL: https://github.com/apache/pulsar/pull/13336#discussion_r770174148 ## File path: site2/docs/developing-binary-protocol.md ## @@ -63,6 +63,14 @@ It is created by the broker when the message arrived at the broker and

[GitHub] [pulsar] liangyepianzhou commented on pull request #13327: [Transaction] Delete the redundant code

2021-12-15 Thread GitBox
liangyepianzhou commented on pull request #13327: URL: https://github.com/apache/pulsar/pull/13327#issuecomment-995373317 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch master updated (acb7aa1 -> d7eea00)

2021-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from acb7aa1 Fix in Apple Silicon macOS the clang-format cannot find (#1) add d7eea00 Remove deprecated Mockit

[pulsar] branch master updated (cba8800 -> acb7aa1)

2021-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cba8800 Enable CheckStyle Plugin in Pulsar proxy (#13343) add acb7aa1 Fix in Apple Silicon macOS the clang-for

[GitHub] [pulsar] merlimat edited a comment on pull request #13293: [Issue 13285][pulsar-client] Optimize MessageBuilder and SharedBuffer to avoid unnecessary memory copy.

2021-12-15 Thread GitBox
merlimat edited a comment on pull request #13293: URL: https://github.com/apache/pulsar/pull/13293#issuecomment-995371966 @tongsucn You should either rebase or merge with master as there were some merge conflicts that make the checkstyle to fail. It's already fixed in latest master. --

[GitHub] [pulsar] merlimat commented on pull request #13293: [Issue 13285][pulsar-client] Optimize MessageBuilder and SharedBuffer to avoid unnecessary memory copy.

2021-12-15 Thread GitBox
merlimat commented on pull request #13293: URL: https://github.com/apache/pulsar/pull/13293#issuecomment-995371966 @tongsucn You either rebase or merge with master as there were some merge conflicts that make the checkstyle to fail. It's already fixed in latest master. -- This is an auto

[GitHub] [pulsar] merlimat merged pull request #13329: Remove deprecated Mockito api use

2021-12-15 Thread GitBox
merlimat merged pull request #13329: URL: https://github.com/apache/pulsar/pull/13329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat merged pull request #13333: [C++] Fix in Apple Silicon macOS the clang-format cannot find

2021-12-15 Thread GitBox
merlimat merged pull request #1: URL: https://github.com/apache/pulsar/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] casuallc commented on issue #13046: Operation failed on schema upload to a topic while configuring a jdbc sink

2021-12-15 Thread GitBox
casuallc commented on issue #13046: URL: https://github.com/apache/pulsar/issues/13046#issuecomment-995370378 You can not change schema type of a topic. Recreate topic and try again. :) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] isminex opened a new issue #13347: Support user defined and pluggable consumer selector

2021-12-15 Thread GitBox
isminex opened a new issue #13347: URL: https://github.com/apache/pulsar/issues/13347 **Is your enhancement request related to a problem? Please describe.** When we try to Introduce pulsar to our existing system, compatibility is our first consideration. Firstly, our production system us

[GitHub] [pulsar] mattisonchao commented on issue #13346: PIP-123: Introduce Pulsar metadata CLI tool

2021-12-15 Thread GitBox
mattisonchao commented on issue #13346: URL: https://github.com/apache/pulsar/issues/13346#issuecomment-995360618 I think it's will be very useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] Shoothzj commented on pull request #13329: Remove deprecated Mockito api use

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13329: URL: https://github.com/apache/pulsar/pull/13329#issuecomment-995356383 @codelipenghui @lhotari @michaeljmarshall @merlimat @eolivelli @315157973 PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] mattisonchao edited a comment on issue #13283: websocket when ssl tsl is enabled, error reported: Error during handshake

2021-12-15 Thread GitBox
mattisonchao edited a comment on issue #13283: URL: https://github.com/apache/pulsar/issues/13283#issuecomment-995355060 @hangc0276 I think i can help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] mattisonchao commented on issue #13283: websocket when ssl tsl is enabled, error reported: Error during handshake

2021-12-15 Thread GitBox
mattisonchao commented on issue #13283: URL: https://github.com/apache/pulsar/issues/13283#issuecomment-995355060 I think i can help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #13336: [Doc] add explanations for broker entry metadata

2021-12-15 Thread GitBox
Huanli-Meng commented on a change in pull request #13336: URL: https://github.com/apache/pulsar/pull/13336#discussion_r770154039 ## File path: site2/docs/developing-binary-protocol.md ## @@ -63,6 +63,14 @@ It is created by the broker when the message arrived at the broker and

[GitHub] [pulsar] tomscut commented on a change in pull request #13057: [Producer] Change the time units from ns to ms

2021-12-15 Thread GitBox
tomscut commented on a change in pull request #13057: URL: https://github.com/apache/pulsar/pull/13057#discussion_r770147945 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java ## @@ -1173,7 +1173,7 @@ static OpSendMsg create(MessageImpl m

[GitHub] [pulsar] Shoothzj removed a comment on pull request #13329: Remove deprecated Mockito api use

2021-12-15 Thread GitBox
Shoothzj removed a comment on pull request #13329: URL: https://github.com/apache/pulsar/pull/13329#issuecomment-995299795 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Shoothzj commented on pull request #13329: Remove deprecated Mockito api use

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13329: URL: https://github.com/apache/pulsar/pull/13329#issuecomment-995335454 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Shoothzj commented on pull request #13339: [Issue 10816][Proxy] Refresh client auth token

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13339: URL: https://github.com/apache/pulsar/pull/13339#issuecomment-995332646 @kkkoder I have done in #13343, could you please pull master code, and undo the format, thanks :) -- This is an automated message from the Apache Git Service. To respond to

[pulsar] branch master updated: Enable CheckStyle Plugin in Pulsar proxy (#13343)

2021-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cba8800 Enable CheckStyle Plugin in Pulsar prox

[GitHub] [pulsar] merlimat merged pull request #13343: Enable CheckStyle Plugin in Pulsar proxy

2021-12-15 Thread GitBox
merlimat merged pull request #13343: URL: https://github.com/apache/pulsar/pull/13343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat commented on a change in pull request #12838: Initial commit for TableView

2021-12-15 Thread GitBox
merlimat commented on a change in pull request #12838: URL: https://github.com/apache/pulsar/pull/12838#discussion_r770139817 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java ## @@ -0,0 +1,271 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pulsar] Shoothzj commented on a change in pull request #13336: [Doc] add explanations for broker entry metadata

2021-12-15 Thread GitBox
Shoothzj commented on a change in pull request #13336: URL: https://github.com/apache/pulsar/pull/13336#discussion_r770139434 ## File path: site2/docs/developing-binary-protocol.md ## @@ -63,6 +63,14 @@ It is created by the broker when the message arrived at the broker and pas

[GitHub] [pulsar] nlu90 commented on a change in pull request #12838: Initial commit for TableView

2021-12-15 Thread GitBox
nlu90 commented on a change in pull request #12838: URL: https://github.com/apache/pulsar/pull/12838#discussion_r770139258 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java ## @@ -0,0 +1,271 @@ +/** + * Licensed to the Apache Software F

[GitHub] [pulsar] Shoothzj commented on pull request #13344: PIP-120 : Enable client memory limit controller by default

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13344: URL: https://github.com/apache/pulsar/pull/13344#issuecomment-995325474 the test `org.apache.pulsar.client.impl.ProducerBuilderImplTest#testProducerBuilderImplWhenMaxPendingMessagesAcrossPartitionsPropertyIsInvalid` need to be modified too -- T

[GitHub] [pulsar] dave2wave closed pull request #3267: Support set publish time on broker side

2021-12-15 Thread GitBox
dave2wave closed pull request #3267: URL: https://github.com/apache/pulsar/pull/3267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] Demogorgon314 commented on pull request #13333: [C++] Fix in Apple Silicon macOS the clang-format cannot find

2021-12-15 Thread GitBox
Demogorgon314 commented on pull request #1: URL: https://github.com/apache/pulsar/pull/1#issuecomment-995317105 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Shoothzj commented on pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13345: URL: https://github.com/apache/pulsar/pull/13345#issuecomment-995301307 @codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Shoothzj commented on pull request #13343: Enable CheckStyle Plugin in Pulsar proxy

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13343: URL: https://github.com/apache/pulsar/pull/13343#issuecomment-995301275 @codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Shoothzj removed a comment on pull request #13329: Remove deprecated Mockito api use

2021-12-15 Thread GitBox
Shoothzj removed a comment on pull request #13329: URL: https://github.com/apache/pulsar/pull/13329#issuecomment-994941335 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Shoothzj commented on pull request #13329: Remove deprecated Mockito api use

2021-12-15 Thread GitBox
Shoothzj commented on pull request #13329: URL: https://github.com/apache/pulsar/pull/13329#issuecomment-995299795 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] yuruguo removed a comment on pull request #12242: [pulsar-admin] Add --update-mode to optimize topic rate policy

2021-12-15 Thread GitBox
yuruguo removed a comment on pull request #12242: URL: https://github.com/apache/pulsar/pull/12242#issuecomment-995234802 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo removed a comment on pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo removed a comment on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-995249812 @merlimat @eolivelli @codelipenghui @hangc0276 ptal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] yuruguo commented on pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo commented on pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#issuecomment-995249812 @merlimat @eolivelli @codelipenghui @hangc0276 ptal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo commented on pull request #12242: [pulsar-admin] Add --update-mode to optimize topic rate policy

2021-12-15 Thread GitBox
yuruguo commented on pull request #12242: URL: https://github.com/apache/pulsar/pull/12242#issuecomment-995234802 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] yuruguo commented on a change in pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo commented on a change in pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#discussion_r770052795 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java ## @@ -122,7 +122,7 @@ @Path("/{property}/{cluster}/{na

[GitHub] [pulsar] yuruguo commented on a change in pull request #13157: [Authorization] Converge authz of ns policies from super-user to tenant-administrator

2021-12-15 Thread GitBox
yuruguo commented on a change in pull request #13157: URL: https://github.com/apache/pulsar/pull/13157#discussion_r770052795 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java ## @@ -122,7 +122,7 @@ @Path("/{property}/{cluster}/{na

[pulsar] branch branch-2.8 updated: [security] Upgrade Netty to 4.1.72 - CVE-2021-43797 (#13328)

2021-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 3b44d67 [security] Upgrade Netty to 4.1

[pulsar] branch branch-2.9 updated: [security] Upgrade Netty to 4.1.72 - CVE-2021-43797 (#13328)

2021-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new f52ac04 [security] Upgrade Netty to 4.1

[pulsar] branch master updated (3faaf6f -> 6e206f5)

2021-12-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3faaf6f Add new Pulsar adopted users (#13326) add 6e206f5 [security] Upgrade Netty to 4.1.72 - CVE-2021-43797

  1   2   3   >