[GitHub] [pulsar] Anonymitaet commented on pull request #14577: [Doc] add explanations for Java client library

2022-03-07 Thread GitBox
Anonymitaet commented on pull request #14577: URL: https://github.com/apache/pulsar/pull/14577#issuecomment-1061504536 @BewareMyPower @RobertIndie many thanks for your guidance! I've incorporated your comments. PTAL. (@BewareMyPower I only add explanations for the 1st "shade dependen

[GitHub] [pulsar] gaozhangmin commented on pull request #14595: Fix potential npe bug of #14384

2022-03-07 Thread GitBox
gaozhangmin commented on pull request #14595: URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061504085 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] gaozhangmin commented on pull request #14595: Fix potential npe bug of #14384

2022-03-07 Thread GitBox
gaozhangmin commented on pull request #14595: URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061501152 > @gaozhangmin Please add some tests to cover this change. The tests were already covered by `BookKeeperPackagesStorageTest.java`. But need to change `zookeeperServe

[pulsar] branch master updated (a98b982 -> 3c5698a)

2022-03-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a98b982 [tests] Pulsar IO - Elasticsearch - reduce elastic container memory usage (#14580) add 3c5698a [OWAS

[GitHub] [pulsar] lhotari merged pull request #14593: [OWASP] Update mariadb-jdbc dependency and add suppression rule

2022-03-07 Thread GitBox
lhotari merged pull request #14593: URL: https://github.com/apache/pulsar/pull/14593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] urfreespace opened a new pull request #14597: fix: [doc] Invalid code tab markdown for zh-CN translation

2022-03-07 Thread GitBox
urfreespace opened a new pull request #14597: URL: https://github.com/apache/pulsar/pull/14597 Signed-off-by: LiLi *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes [#](https://github.com/apache/pulsar/issues/14596) *(or if this PR is one task of

[GitHub] [pulsar] lhotari closed pull request #14511: [IO] Upgrade mariadb jdbc driver version to address vulnerabilities

2022-03-07 Thread GitBox
lhotari closed pull request #14511: URL: https://github.com/apache/pulsar/pull/14511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] lhotari commented on pull request #14511: [IO] Upgrade mariadb jdbc driver version to address vulnerabilities

2022-03-07 Thread GitBox
lhotari commented on pull request #14511: URL: https://github.com/apache/pulsar/pull/14511#issuecomment-1061498556 closing this since #14593 resolves the OWASP dependency check false alarm. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] urfreespace opened a new issue #14596: [Doc] Invalid code tab markdown for zh-CN translation

2022-03-07 Thread GitBox
urfreespace opened a new issue #14596: URL: https://github.com/apache/pulsar/issues/14596 ### What issue do you find in Pulsar docs? ![image](https://user-images.githubusercontent.com/76024046/157190364-fdbc2bc0-f24e-48f1-b876-dcc9e09054ce.png) ### What is your suggestion?

[GitHub] [pulsar] daniwb closed issue #14567: Retention Policy is resetted when restarting Pulsar-Broker in a Cluster

2022-03-07 Thread GitBox
daniwb closed issue #14567: URL: https://github.com/apache/pulsar/issues/14567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [pulsar] daniwb commented on issue #14567: Retention Policy is resetted when restarting Pulsar-Broker in a Cluster

2022-03-07 Thread GitBox
daniwb commented on issue #14567: URL: https://github.com/apache/pulsar/issues/14567#issuecomment-1061495964 Thanks for your help! I found out, it was **KoP (Kafka on Pulsar)**. In the logs I can see, that after Kafka on Pulsar starts, it sends the Query to change the default. @eo

[GitHub] [pulsar] lhotari commented on pull request #14595: Fix potential npe bug of #14384

2022-03-07 Thread GitBox
lhotari commented on pull request #14595: URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061483640 @gaozhangmin Please add some tests to cover this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar] lhotari edited a comment on issue #14436: [Proto] java.lang.IllegalStateException: Some required fields are missing

2022-03-07 Thread GitBox
lhotari edited a comment on issue #14436: URL: https://github.com/apache/pulsar/issues/14436#issuecomment-1061478053 @congbobo184 Thank you. Based on this experiment we cannot determine the issue, but since disabling Netty Recycler has an impact, there's a possibility that recycling instan

[GitHub] [pulsar] lhotari commented on issue #14436: [Proto] java.lang.IllegalStateException: Some required fields are missing

2022-03-07 Thread GitBox
lhotari commented on issue #14436: URL: https://github.com/apache/pulsar/issues/14436#issuecomment-1061478053 @congbobo184 Thank you. Based on this experiment we cannot determine the issue, but since disabling Netty Recycler has an impact, there's a possibility that recycling instances is

[GitHub] [pulsar] congbobo184 commented on issue #14436: [Proto] java.lang.IllegalStateException: Some required fields are missing

2022-03-07 Thread GitBox
congbobo184 commented on issue #14436: URL: https://github.com/apache/pulsar/issues/14436#issuecomment-1061477069 Hi @lhotari , I start up standalone with -Dio.netty.recycler.maxCapacity=0 -Dio.netty.recycler.maxCapacityPerThread=0 the problem seem not reproduce, I don’t know is it becau

[GitHub] [pulsar] lhotari commented on pull request #14579: Update Kotlib Lib to 1.6.10, to address https://nvd.nist.gov/vuln/detail/CVE-2022-24329

2022-03-07 Thread GitBox
lhotari commented on pull request #14579: URL: https://github.com/apache/pulsar/pull/14579#issuecomment-1061472543 The main concern is possible breaking changes. Kotlin stdlib was introduced in #13065 . It's a transitive dependency of OkHttp3 / Okio libraries. Has anyone checked Kotl

[pulsar] branch master updated: [tests] Pulsar IO - Elasticsearch - reduce elastic container memory usage (#14580)

2022-03-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a98b982 [tests] Pulsar IO - Elasticsearch - re

[GitHub] [pulsar] lhotari merged pull request #14580: [tests] Pulsar IO - Elasticsearch - reduce elastic container memory usage

2022-03-07 Thread GitBox
lhotari merged pull request #14580: URL: https://github.com/apache/pulsar/pull/14580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] nodece commented on a change in pull request #14511: [IO] Upgrade mariadb jdbc driver version to address vulnerabilities

2022-03-07 Thread GitBox
nodece commented on a change in pull request #14511: URL: https://github.com/apache/pulsar/pull/14511#discussion_r821363469 ## File path: pom.xml ## @@ -152,7 +152,7 @@ flexible messaging model and an intuitive client API. 8.0.11 42.2.25 0.3.2 -2.6.0 +3.

[GitHub] [pulsar] lhotari commented on a change in pull request #14511: [IO] Upgrade mariadb jdbc driver version to address vulnerabilities

2022-03-07 Thread GitBox
lhotari commented on a change in pull request #14511: URL: https://github.com/apache/pulsar/pull/14511#discussion_r821359861 ## File path: pom.xml ## @@ -152,7 +152,7 @@ flexible messaging model and an intuitive client API. 8.0.11 42.2.25 0.3.2 -2.6.0 +3

[GitHub] [pulsar] AnonHxy commented on pull request #14594: [Broker] tidy up code about dispatchRate

2022-03-07 Thread GitBox
AnonHxy commented on pull request #14594: URL: https://github.com/apache/pulsar/pull/14594#issuecomment-1061449445 Add the UT `org.apache.pulsar.broker.service.BrokerDispatchRateLimiterTest` to test `BROKER` type `DispatchRateLimiter` @gaoran10 -- This is an automated message from the

[GitHub] [pulsar] ericsyh commented on pull request #14590: fix(docs): add missing config in debezium mysql source

2022-03-07 Thread GitBox
ericsyh commented on pull request #14590: URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061438778 @gaoran10 @nodece Pulsar and debezium-mysql uses `2.8.1`, the ERROR from functions is like below: ``` 13:59:00.824 [public/default/debezium-mysql-source-0] ERROR org.ap

[GitHub] [pulsar] github-actions[bot] commented on pull request #14595: Fix potential npe bug of #14384

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #14595: URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061428453 @gaozhangmin:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] github-actions[bot] commented on pull request #14595: Fix potential npe bug of #14384

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #14595: URL: https://github.com/apache/pulsar/pull/14595#issuecomment-1061428391 @gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/b

[GitHub] [pulsar] gaozhangmin opened a new pull request #14595: Fix potential npe bug of #14384

2022-03-07 Thread GitBox
gaozhangmin opened a new pull request #14595: URL: https://github.com/apache/pulsar/pull/14595 ### Motivation Fix potential np bug ### Modifications Fix potential np bug ### Documentation Check the box below or label this PR directly (if you hav

[GitHub] [pulsar] lhotari commented on pull request #13563: [Improvement] Recycler should use io.netty.recycler.maxCapacityPerThread instead of io.netty.recycler.maxCapacity.default as maxCapacityPerT

2022-03-07 Thread GitBox
lhotari commented on pull request #13563: URL: https://github.com/apache/pulsar/pull/13563#issuecomment-1061422621 > LGTM. > > @HQebupt - thanks for the reference. Do you know which versions of Pulsar need this patch? @michaeljmarshall This applies to all Pulsar versions since

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14587: [C++] Handle exception in creating socket when fd limit is reached

2022-03-07 Thread GitBox
BewareMyPower commented on a change in pull request #14587: URL: https://github.com/apache/pulsar/pull/14587#discussion_r821332735 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -173,12 +172,20 @@ ClientConnection::ClientConnection(const std::string& logicalAddr

[GitHub] [pulsar] lhotari closed pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

2022-03-07 Thread GitBox
lhotari closed pull request #14576: URL: https://github.com/apache/pulsar/pull/14576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] sourabhaggrawal commented on issue #14533: stats-internal throws 500 with message No such ledger exists on Metadata Server

2022-03-07 Thread GitBox
sourabhaggrawal commented on issue #14533: URL: https://github.com/apache/pulsar/issues/14533#issuecomment-1061419398 Later upgrading to 2.8.2 I deleted 2 ledgers of a topic for which consumer was stuck and not able to read message from it because of the same MissingLogFileException crash.

[GitHub] [pulsar] lhotari commented on pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

2022-03-07 Thread GitBox
lhotari commented on pull request #14576: URL: https://github.com/apache/pulsar/pull/14576#issuecomment-1061419453 > @lhotari - this appears to conflict with #13563. Can you take a look to see how we can/should integrate the two PRs? Thanks. Thanks for letting me know. Yes, that PR c

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14587: [C++] Handle exception in creating socket when fd limit is reached

2022-03-07 Thread GitBox
BewareMyPower commented on a change in pull request #14587: URL: https://github.com/apache/pulsar/pull/14587#discussion_r821331929 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -173,12 +172,20 @@ ClientConnection::ClientConnection(const std::string& logicalAddr

[GitHub] [pulsar] sourabhaggrawal commented on issue #14533: stats-internal throws 500 with message No such ledger exists on Metadata Server

2022-03-07 Thread GitBox
sourabhaggrawal commented on issue #14533: URL: https://github.com/apache/pulsar/issues/14533#issuecomment-1061416214 Hi @codelipenghui , MissingLogFileException is occuring since the time I tried to upgrade to 2.8.2 and then reverted back to 2.5.2. -- This is an automated message from

[GitHub] [pulsar] codelipenghui commented on pull request #14503: [Broker] Fixed wrong behaviour caused by not cleaning up topic policy service state.

2022-03-07 Thread GitBox
codelipenghui commented on pull request #14503: URL: https://github.com/apache/pulsar/pull/14503#issuecomment-1061411129 > As @mattisonchao is on holiday this week, how about merging this first and adding test later? Works for me, @JipeiWang could you please help create an issue for

[GitHub] [pulsar] Technoboy- edited a comment on pull request #14503: [Broker] Fixed wrong behaviour caused by not cleaning up topic policy service state.

2022-03-07 Thread GitBox
Technoboy- edited a comment on pull request #14503: URL: https://github.com/apache/pulsar/pull/14503#issuecomment-1061409837 > As @mattisonchao is on holiday this week, how about merging this first and adding test later? @lhotari @Jason918 @codelipenghui -- This is an automat

[GitHub] [pulsar] Technoboy- commented on pull request #14503: [Broker] Fixed wrong behaviour caused by not cleaning up topic policy service state.

2022-03-07 Thread GitBox
Technoboy- commented on pull request #14503: URL: https://github.com/apache/pulsar/pull/14503#issuecomment-1061409837 > As @mattisonchao is on holiday this week, how about merging this first and add test later? @lhotari @Jason918 @codelipenghui -- This is an automated message

[pulsar] branch branch-2.9 updated: [pulsar-io] throw exceptions when kafka offset backing store failed to start (#14491)

2022-03-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new f41ba12 [pulsar-io] throw exceptions w

[pulsar] branch master updated (791853f -> 95c1581)

2022-03-07 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 791853f [PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side. (#14

[GitHub] [pulsar] BewareMyPower merged pull request #14554: [C++] Fix wrong unit of Access Token Response's `expires_in` field

2022-03-07 Thread GitBox
BewareMyPower merged pull request #14554: URL: https://github.com/apache/pulsar/pull/14554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] gaoran10 commented on pull request #14594: [Broker] tidy up code about dispatchRate

2022-03-07 Thread GitBox
gaoran10 commented on pull request #14594: URL: https://github.com/apache/pulsar/pull/14594#issuecomment-1061395385 LGTM, could you check if there is any exsiting test to cover this logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] gaoran10 commented on pull request #14590: fix(docs): add missing config in debezium mysql source

2022-03-07 Thread GitBox
gaoran10 commented on pull request #14590: URL: https://github.com/apache/pulsar/pull/14590#issuecomment-1061384940 Could you provide the error logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] wenbingshen commented on issue #14559: Ignoring flow control message when resetCursorInProgress=TRUE

2022-03-07 Thread GitBox
wenbingshen commented on issue #14559: URL: https://github.com/apache/pulsar/issues/14559#issuecomment-1061383201 > Looks like a similar problem that https://github.com/apache/pulsar/wiki/PIP-84-:-Pulsar-client:-Redeliver-command-add-epoch want to resolve. Thanks for your reply. It

[GitHub] [pulsar] nodece commented on pull request #14593: [OWASP] Update mariadb-jdbc dependency and add suppression rule

2022-03-07 Thread GitBox
nodece commented on pull request #14593: URL: https://github.com/apache/pulsar/pull/14593#issuecomment-1061383158 This PR duplication with https://github.com/apache/pulsar/pull/14511. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] AnonHxy opened a new pull request #14594: [Broker] tidy up code about dispatchRate

2022-03-07 Thread GitBox
AnonHxy opened a new pull request #14594: URL: https://github.com/apache/pulsar/pull/14594 ### Motivation * Tidy up code about dispatchRate. * No need `getTopicPolicyDispatchRate` or `getPoliciesDispatchRateAsync` when update broker type dispatch rate ### Modifications

[GitHub] [pulsar] XuanYang-cn closed issue #13852: Writing local data to ZooKeeper because maximum change 33235.83459104782% exceeded threshold 10%

2022-03-07 Thread GitBox
XuanYang-cn closed issue #13852: URL: https://github.com/apache/pulsar/issues/13852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pulsar] JoeCqupt commented on pull request #14586: improve FieldParser converters

2022-03-07 Thread GitBox
JoeCqupt commented on pull request #14586: URL: https://github.com/apache/pulsar/pull/14586#issuecomment-1061379878 @Jason918 @eolivelli @merlimat PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] github-actions[bot] commented on pull request #14586: improve FieldParser converters

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #14586: URL: https://github.com/apache/pulsar/pull/14586#issuecomment-1061378349 @JoeCqupt:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] nodece commented on a change in pull request #14511: [IO] Upgrade mariadb jdbc driver version to address vulnerabilities

2022-03-07 Thread GitBox
nodece commented on a change in pull request #14511: URL: https://github.com/apache/pulsar/pull/14511#discussion_r821298757 ## File path: pom.xml ## @@ -152,7 +152,7 @@ flexible messaging model and an intuitive client API. 8.0.11 42.2.25 0.3.2 -2.6.0 +3.

[GitHub] [pulsar] nodece commented on pull request #14511: [IO] Upgrade mariadb jdbc driver version to address vulnerabilities

2022-03-07 Thread GitBox
nodece commented on pull request #14511: URL: https://github.com/apache/pulsar/pull/14511#issuecomment-1061376288 Any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[pulsar-client-go] branch branch-0.8.1 created (now c1e3a58)

2022-03-07 Thread rfu
This is an automated email from the ASF dual-hosted git repository. rfu pushed a change to branch branch-0.8.1 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. at c1e3a58 Upgrade prometheus client to 1.11.1 (#738) No new revisions were added by this update.

[pulsar-client-go] annotated tag v0.8.1-candidate-1 updated (c1e3a58 -> 85349d6)

2022-03-07 Thread rfu
This is an automated email from the ASF dual-hosted git repository. rfu pushed a change to annotated tag v0.8.1-candidate-1 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. *** WARNING: tag v0.8.1-candidate-1 was modified! *** from c1e3a58 (commit) to 85349d6

[GitHub] [pulsar-client-go] freeznet opened a new pull request #742: add 0.8.1 changelog

2022-03-07 Thread GitBox
freeznet opened a new pull request #742: URL: https://github.com/apache/pulsar-client-go/pull/742 ### Motivation Add 0.8.1 changelog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

svn commit: r52915 - in /dev/pulsar/pulsar-client-go-0.8.1-candidate-1: ./ apache-pulsar-client-go-0.8.1-src.tar.gz apache-pulsar-client-go-0.8.1-src.tar.gz.asc apache-pulsar-client-go-0.8.1-src.tar.g

2022-03-07 Thread rfu
Author: rfu Date: Tue Mar 8 03:23:45 2022 New Revision: 52915 Log: Staging artifacts and signature for Pulsar Client Go release 0.8.1-candidate-1 Added: dev/pulsar/pulsar-client-go-0.8.1-candidate-1/ dev/pulsar/pulsar-client-go-0.8.1-candidate-1/apache-pulsar-client-go-0.8.1-src.tar.gz

[pulsar-client-go] branch branch-0.8.1 created (now 5daa17b)

2022-03-07 Thread rfu
This is an automated email from the ASF dual-hosted git repository. rfu pushed a change to branch branch-0.8.1 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. at 5daa17b Markdown error fix (#722) No new revisions were added by this update.

[pulsar] branch master updated (32c3cd1 -> 791853f)

2022-03-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 32c3cd1 [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi (#14508) add 791853f [PIP-132] Include message hea

[GitHub] [pulsar] ericsyh commented on a change in pull request #14590: fix(docs): add missing config in debezium mysql source

2022-03-07 Thread GitBox
ericsyh commented on a change in pull request #14590: URL: https://github.com/apache/pulsar/pull/14590#discussion_r821286426 ## File path: site2/docs/io-cdc-debezium.md ## @@ -92,7 +92,7 @@ You can use one of the following methods to create a configuration file. datab

[GitHub] [pulsar] nodece commented on pull request #14593: [Dependencies] Update mariadb-jdbc

2022-03-07 Thread GitBox
nodece commented on pull request #14593: URL: https://github.com/apache/pulsar/pull/14593#issuecomment-1061361794 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] BewareMyPower commented on pull request #14585: Issue 14583: [python client]: Improve garbage collection of producer/consumer/reader objects

2022-03-07 Thread GitBox
BewareMyPower commented on pull request #14585: URL: https://github.com/apache/pulsar/pull/14585#issuecomment-1061361600 Could you fix the license check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] nodece commented on a change in pull request #14590: fix(docs): add missing config in debezium mysql source

2022-03-07 Thread GitBox
nodece commented on a change in pull request #14590: URL: https://github.com/apache/pulsar/pull/14590#discussion_r821281445 ## File path: site2/docs/io-cdc-debezium.md ## @@ -92,7 +92,7 @@ You can use one of the following methods to create a configuration file. databa

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14587: [C++] Handle exception in creating socket when fd limit is reached

2022-03-07 Thread GitBox
BewareMyPower commented on a change in pull request #14587: URL: https://github.com/apache/pulsar/pull/14587#discussion_r821280374 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -173,12 +172,20 @@ ClientConnection::ClientConnection(const std::string& logicalAddr

[GitHub] [pulsar] codelipenghui merged pull request #14007: [PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side.

2022-03-07 Thread GitBox
codelipenghui merged pull request #14007: URL: https://github.com/apache/pulsar/pull/14007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] RobertIndie commented on a change in pull request #14577: [Doc] add explanations for Java client library

2022-03-07 Thread GitBox
RobertIndie commented on a change in pull request #14577: URL: https://github.com/apache/pulsar/pull/14577#discussion_r821280107 ## File path: site2/docs/client-libraries-java.md ## @@ -22,6 +22,11 @@ This document focuses only on the client API for producing and consuming mes

[GitHub] [pulsar] nodece opened a new pull request #14593: [Dependencies] Update mariadb-jdbc

2022-03-07 Thread GitBox
nodece opened a new pull request #14593: URL: https://github.com/apache/pulsar/pull/14593 Signed-off-by: Zixuan Liu ### Motivation Fix `OWASP Dependency Check / owasp-dep-check` CI: ``` Error: Failed to execute goal org.owasp:dependency-check-maven:6.1.6:aggregate (def

svn commit: r52914 - /dev/pulsar/KEYS

2022-03-07 Thread rfu
Author: rfu Date: Tue Mar 8 02:47:04 2022 New Revision: 52914 Log: Added gpg key for rfu Modified: dev/pulsar/KEYS Modified: dev/pulsar/KEYS == --- dev/pulsar/KEYS (original) +++ dev/pulsar/KEYS Tue Mar 8 02:47:04

[GitHub] [pulsar] JackrayWang commented on issue #14592: es sink start error

2022-03-07 Thread GitBox
JackrayWang commented on issue #14592: URL: https://github.com/apache/pulsar/issues/14592#issuecomment-1061348244 function log is as follows. ``` No such ledger exists on Metadata Server - ledger=239 - operation=Failed to open ledger","reqId":2327396040063173539, "remote":"192.

[GitHub] [pulsar] JackrayWang commented on issue #14592: es sink start error

2022-03-07 Thread GitBox
JackrayWang commented on issue #14592: URL: https://github.com/apache/pulsar/issues/14592#issuecomment-1061342389 error log is as follows. ``` ERROR org.apache.pulsar.functions.runtime.process.ProcessRuntime - Extracted Process death exception java.lang.RuntimeException:

[GitHub] [pulsar] JackrayWang opened a new issue #14592: es sink start error

2022-03-07 Thread GitBox
JackrayWang opened a new issue #14592: URL: https://github.com/apache/pulsar/issues/14592 ## create es sink ```shell /opt/apache-pulsar-2.9.1/bin/pulsar-admin sinks create \ --archive /root/pulsar-io-elastic-search-2.9.1.nar \ --tenant public\ --namespace

[GitHub] [pulsar] JackrayWang commented on issue #14578: add new node for broker error

2022-03-07 Thread GitBox
JackrayWang commented on issue #14578: URL: https://github.com/apache/pulsar/issues/14578#issuecomment-1061340875 bookkeeper and zk is normal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] JackrayWang edited a comment on issue #14578: add new node for broker error

2022-03-07 Thread GitBox
JackrayWang edited a comment on issue #14578: URL: https://github.com/apache/pulsar/issues/14578#issuecomment-1061335952 This node could connect to zk,the log is as follows。 zk ``` [zk: localhost:2181(CONNECTED) 1] ls / [admin, bookies, counters, ledgers, loadbalance, man

[GitHub] [pulsar] Jason918 commented on pull request #14007: [PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side.

2022-03-07 Thread GitBox
Jason918 commented on pull request #14007: URL: https://github.com/apache/pulsar/pull/14007#issuecomment-1061336432 @RobertIndie PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] JackrayWang commented on issue #14578: add new node for broker error

2022-03-07 Thread GitBox
JackrayWang commented on issue #14578: URL: https://github.com/apache/pulsar/issues/14578#issuecomment-1061335952 This node could connect to zk,the log is as follows。 zk ``` [zk: localhost:2181(CONNECTED) 1] ls / [admin, bookies, counters, ledgers, loadbalance, managed-le

[GitHub] [pulsar] JackrayWang commented on issue #14575: broker restart failed

2022-03-07 Thread GitBox
JackrayWang commented on issue #14575: URL: https://github.com/apache/pulsar/issues/14575#issuecomment-1061333950 cluster @codelipenghui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] Steve0x2a opened a new issue #14591: Cannot open token authentication

2022-03-07 Thread GitBox
Steve0x2a opened a new issue #14591: URL: https://github.com/apache/pulsar/issues/14591 **Describe the bug** Cannot open token authentication. **To Reproduce** Steps to reproduce the behavior: 1. download pulsar 2.9.1 in release 2. edit `conf/standalone.conf` ```conf

[GitHub] [pulsar] github-actions[bot] commented on issue #14132: Failed to get Manifest for - pulsar-client-2.9.1.jar

2022-03-07 Thread GitBox
github-actions[bot] commented on issue #14132: URL: https://github.com/apache/pulsar/issues/14132#issuecomment-1061325643 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Technoboy- commented on a change in pull request #14570: Fix update replication cluster but not update replicator.

2022-03-07 Thread GitBox
Technoboy- commented on a change in pull request #14570: URL: https://github.com/apache/pulsar/pull/14570#discussion_r821252352 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -611,28 +610,13 @@ private boolean h

[GitHub] [pulsar] liudezhi2098 commented on pull request #14498: [DOC]optimization concepts-messaging retry letter topic

2022-03-07 Thread GitBox
liudezhi2098 commented on pull request #14498: URL: https://github.com/apache/pulsar/pull/14498#issuecomment-1061298211 > yes, I will update documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] ericsyh opened a new pull request #14590: fix(docs): add missing config in debezium mysql source

2022-03-07 Thread GitBox
ericsyh opened a new pull request #14590: URL: https://github.com/apache/pulsar/pull/14590 Signed-off-by: Eric Shen ### Motivation The YAML sample of debezium mysql source missing a config of `pulsar.service.url` on [io-debezium-source](https://pulsar.apache.org/docs

[GitHub] [pulsar] dlg99 opened a new pull request #14589: Sink does not crash/restart after an error on write.

2022-03-07 Thread GitBox
dlg99 opened a new pull request #14589: URL: https://github.com/apache/pulsar/pull/14589 ### Motivation The sink does not crash (thus leaves no chance for auto restart in k8s) if the connector throws exception on write. Specific case was caused by ElasticSearch connector; teh es c

[GitHub] [pulsar] rdhabalia commented on pull request #12235: [pulsar-broker] PIP-100 Support pluggable topic factory

2022-03-07 Thread GitBox
rdhabalia commented on pull request #12235: URL: https://github.com/apache/pulsar/pull/12235#issuecomment-1061207164 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pulsar-client-go] ZiyaoWei opened a new pull request #741: Add schema support to Reader

2022-03-07 Thread GitBox
ZiyaoWei opened a new pull request #741: URL: https://github.com/apache/pulsar-client-go/pull/741 Master Issue: #344 ### Motivation #368 adds support for schemas in consumer and producer, but didn't add the corresponding option to reader. This fixes that. ### Modificati

[GitHub] [pulsar] zbentley opened a new issue #14588: Pulsar Python client leaks filehandles after destruction if a consumer is created on a partitioned topic

2022-03-07 Thread GitBox
zbentley opened a new issue #14588: URL: https://github.com/apache/pulsar/issues/14588 **Describe the bug** In Python, I have to reconnect Client objects a lot. Usually due to bugs. `client.close` and `client.shutdown` are sufficient to disconnect a client object. However, a disconnecte

[GitHub] [pulsar] dave2wave commented on pull request #13025: Fix usage of PULSAR_EXTRA_OPTS/BOOKIE_EXTRA_OPTS in startup scripts

2022-03-07 Thread GitBox
dave2wave commented on pull request #13025: URL: https://github.com/apache/pulsar/pull/13025#issuecomment-1061136760 Please make sure this change is referenced in the 2.10 release notes as it is a breaking change for OpenMessaging/Benchmarks (at least for me) -- This is an automated mess

[GitHub] [pulsar] github-actions[bot] commented on pull request #14587: [C++] Handle exception in creating socket when fd limit is reached

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #14587: URL: https://github.com/apache/pulsar/pull/14587#issuecomment-1061108480 @merlimat:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob

[GitHub] [pulsar] merlimat opened a new pull request #14587: [C++] Handle exception in creating socket when fd limit is reached

2022-03-07 Thread GitBox
merlimat opened a new pull request #14587: URL: https://github.com/apache/pulsar/pull/14587 ### Motivation Fix #14582 Asio socket creation throws a C++ exception if it fails to create the native socket resource. We need to handle and close the connection. -- This is an auto

[GitHub] [pulsar] michaeljmarshall commented on pull request #14340: [LoadBalance] Optimize find nics process.

2022-03-07 Thread GitBox
michaeljmarshall commented on pull request #14340: URL: https://github.com/apache/pulsar/pull/14340#issuecomment-1061050339 @BewareMyPower - it might be helpful to cherry pick to active branches. In #14537, there was a discussion about failing fast, instead of constantly logging this error

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14551: [Doc] deprecate DC/OS content for versioned docs

2022-03-07 Thread GitBox
michaeljmarshall commented on a change in pull request #14551: URL: https://github.com/apache/pulsar/pull/14551#discussion_r821021539 ## File path: site2/website-next/docs/deploy-dcos.md ## @@ -6,7 +6,7 @@ sidebar_label: "DC/OS" :::tip -To enable all built-in [Pulsar IO](i

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14551: [Doc] deprecate DC/OS content for versioned docs

2022-03-07 Thread GitBox
michaeljmarshall commented on a change in pull request #14551: URL: https://github.com/apache/pulsar/pull/14551#discussion_r821018933 ## File path: site2/docs/getting-started-standalone.md ## @@ -106,7 +106,7 @@ pulsar-io-aerospike-{{pulsar:version}}.nar > **Note** > * If y

[GitHub] [pulsar] nicoloboschi commented on pull request #14580: [tests] Pulsar IO - Elasticsearch - reduce elastic container memory usage

2022-03-07 Thread GitBox
nicoloboschi commented on pull request #14580: URL: https://github.com/apache/pulsar/pull/14580#issuecomment-1061002876 good question @michaeljmarshall. it's a good idea to cherry-pick it to all the active branches -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pulsar] michaeljmarshall commented on pull request #14576: Remove invalid Netty system property io.netty.recycler.maxCapacity.default which was renamed in 2014

2022-03-07 Thread GitBox
michaeljmarshall commented on pull request #14576: URL: https://github.com/apache/pulsar/pull/14576#issuecomment-1060994439 @lhotari - this appears to conflict with https://github.com/apache/pulsar/pull/13563. Can you take a look to see how we can/should integrate the two PRs? Thanks. --

[GitHub] [pulsar] github-actions[bot] commented on pull request #14586: improve FieldParser converters

2022-03-07 Thread GitBox
github-actions[bot] commented on pull request #14586: URL: https://github.com/apache/pulsar/pull/14586#issuecomment-1060992649 @JoeCqupt:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob

[GitHub] [pulsar] JoeCqupt opened a new pull request #14586: improve FieldParser converters

2022-03-07 Thread GitBox
JoeCqupt opened a new pull request #14586: URL: https://github.com/apache/pulsar/pull/14586 ### Motivation improve FieldParser converters, let them keep the same code style ### Modifications update FieldParser converters ### Verifying this change -

[GitHub] [pulsar] michaeljmarshall commented on pull request #14580: [tests] Pulsar IO - Elasticsearch - reduce elastic container memory usage

2022-03-07 Thread GitBox
michaeljmarshall commented on pull request #14580: URL: https://github.com/apache/pulsar/pull/14580#issuecomment-1060990735 @nicoloboschi - did you identify any previous branches that will need this commit? -- This is an automated message from the Apache Git Service. To respond to the me

[pulsar] 02/02: [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi (#14508)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0f72a4ff1f21ecf9815290a78be2ab2ea48cecc7 Author: Nicolò Boschi AuthorDate: Mon Mar 7 18:00:57 2022 +0100 [fl

[pulsar] 01/02: Flaky Tests: AdminApiSchemaTest#testSchemaInfoApi (#12461)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit c773179dcd5a16edd95714c3aa5a6c19eaa394fe Author: Nicolò Boschi AuthorDate: Thu Nov 11 18:16:49 2021 +0100 Fl

[pulsar] branch branch-2.8 updated (8edfdb5 -> 0f72a4f)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8edfdb5 [branch-2.8] [flaky tests] Fix flaky test ReplicatorTest.testRemoveClusterFromNamespace (#14535)

[pulsar] branch branch-2.10 updated: [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi (#14508)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new db3f2c2 [flaky-tests] AdminApiSche

[pulsar] 02/02: [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi (#14508)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 597005bb6626d9980286e2f992cdbba83cf9081a Author: Nicolò Boschi AuthorDate: Mon Mar 7 18:00:57 2022 +0100 [fl

[pulsar] 01/02: Flaky Tests: AdminApiSchemaTest#testSchemaInfoApi (#12461)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 24198121bc2949fbe121f4acdb65b7e0eeaabee1 Author: Nicolò Boschi AuthorDate: Thu Nov 11 18:16:49 2021 +0100 Fl

[pulsar] branch branch-2.9 updated (065ccd4 -> 597005b)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 065ccd4 [owasp] suppress false positive Avro CVE-2021-43045 (#13764) new 2419812 Flaky Tests: AdminApiS

[pulsar] branch master updated (f80e2cc -> 32c3cd1)

2022-03-07 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f80e2cc fix: NamespacesTest execution order (#14552) add 32c3cd1 [flaky-tests] AdminApiSchemaTest#testSchem

[GitHub] [pulsar] michaeljmarshall merged pull request #14508: [flaky-tests] AdminApiSchemaTest#testSchemaInfoApi

2022-03-07 Thread GitBox
michaeljmarshall merged pull request #14508: URL: https://github.com/apache/pulsar/pull/14508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

  1   2   >