[GitHub] [pulsar] lhotari commented on a diff in pull request #16033: [fix][client]Fix miss flushing ack request when invoking pendingIndividualBatchAck

2022-06-14 Thread GitBox
lhotari commented on code in PR #16033: URL: https://github.com/apache/pulsar/pull/16033#discussion_r896447899 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java: ## @@ -312,15 +312,9 @@ private CompletableFuture doIndivid

[GitHub] [pulsar] Technoboy- commented on issue #16029: Help!We have some questions about flink-connector-pulsar.

2022-06-14 Thread GitBox
Technoboy- commented on issue #16029: URL: https://github.com/apache/pulsar/issues/16029#issuecomment-1154804229 Hi @xyhmnb We have fixed a bug that may cause the reader not ack the message (#12853). The root cause is that: when ack, PersistentAcknowledgmentsGroupingTracker#`lastCumulat

[GitHub] [pulsar] Anonymitaet commented on pull request #15535: [improve][doc] added instructions about how to run ci from fork

2022-06-14 Thread GitBox
Anonymitaet commented on PR #15535: URL: https://github.com/apache/pulsar/pull/15535#issuecomment-1154811152 > > @heesung-sn @Anonymitaet It looks like these instructions have been dropped and aren't on the new website. Would it be possible to get the content to the new website too? >

[GitHub] [pulsar] momo-jun commented on issue #15904: [Doc] Load Balancer - Broker overload thresholds does not apply to some Shedding algorithms

2022-06-14 Thread GitBox
momo-jun commented on issue #15904: URL: https://github.com/apache/pulsar/issues/15904#issuecomment-1154811761 @frankjkelly thanks for reporting this issue. As confirmed by @Demogorgon314, `loadBalancerBrokerOverloadedThresholdPercentage` applies to the `OverloadShedder` shedding alg

[GitHub] [pulsar] momo-jun opened a new pull request, #16048: [fix][doc] Add an import statement to the Java code sample for Oauth2

2022-06-14 Thread GitBox
momo-jun opened a new pull request, #16048: URL: https://github.com/apache/pulsar/pull/16048 ### Modifications 1. Add an import statement to the Java code sample for Oauth2. 2. Correct the system topic name `__transaction_log_${tc_id}` added in #14795. The preview looks

[GitHub] [pulsar] lhotari opened a new pull request, #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
lhotari opened a new pull request, #16049: URL: https://github.com/apache/pulsar/pull/16049 ### Motivation - heap is an ArrayList which isn't thread safe and it's currently accessed concurrently. This could lead to thread safety issues. Here's an example: (stacktraces are [fr

[GitHub] [pulsar] momo-jun commented on pull request #16048: [fix][doc] Add an import statement to the Java code sample for Oauth2

2022-06-14 Thread GitBox
momo-jun commented on PR #16048: URL: https://github.com/apache/pulsar/pull/16048#issuecomment-1154822392 Ping @nodece to review item1; ping @Technoboy- to review item2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] lhotari commented on pull request #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
lhotari commented on PR #16049: URL: https://github.com/apache/pulsar/pull/16049#issuecomment-1154826487 The thread safety issue was introduced in #12045 . A similar pattern was used in #14985 changes. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] lhotari commented on pull request #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
lhotari commented on PR #16049: URL: https://github.com/apache/pulsar/pull/16049#issuecomment-1154827633 There's a chance that this fix causes a performance regression. If that's the case, we would have to revisit the solution for tracking the slowest positions. -- This is an automated

[GitHub] [pulsar] eolivelli merged pull request #16047: [broker] Make invalid namespace and topic name logs more descriptive

2022-06-14 Thread GitBox
eolivelli merged PR #16047: URL: https://github.com/apache/pulsar/pull/16047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar] branch master updated (0a58f58fed7 -> ba82cc528bb)

2022-06-14 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 0a58f58fed7 [fix][env] Support the java version like 'XX-internal' in env file (#16008) add ba82cc528bb [brok

[GitHub] [pulsar] momo-jun commented on issue #16036: [Doc] Some reference links are 404

2022-06-14 Thread GitBox
momo-jun commented on issue #16036: URL: https://github.com/apache/pulsar/issues/16036#issuecomment-1154828305 Ping @urfreespace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pulsar] codelipenghui commented on pull request #14920: [fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-``

2022-06-14 Thread GitBox
codelipenghui commented on PR #14920: URL: https://github.com/apache/pulsar/pull/14920#issuecomment-1154835594 @mattisonchao It might introduce a breaking change for DLQ, please help check the topic auto-creation with partitioned topic can work with DLQ with this change. -- This is an au

[GitHub] [pulsar] leizhiyuan opened a new issue, #16050: when ServerCnx has no consumers and producers, recycle the connection

2022-06-14 Thread GitBox
leizhiyuan opened a new issue, #16050: URL: https://github.com/apache/pulsar/issues/16050 **Is your feature request related to a problem? Please describe.** now, we sometimes meet this issue our users use an old version of the client, for example, backlog exceeded. the c

[GitHub] [pulsar] Sherlock113 opened a new pull request, #16051: [Improve][Doc] Add explanation about the Helm release script

2022-06-14 Thread GitBox
Sherlock113 opened a new pull request, #16051: URL: https://github.com/apache/pulsar/pull/16051 ### Motivation and Modifications Add more explanation about how to use the script to create relevant secrets for Pulsar if using the Helm chart to install it. ### Documentation

[GitHub] [pulsar] eolivelli commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
eolivelli commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896487789 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionCommon.java: ## @@ -120,8 +121,20 @@ public static Class[] getFunctionTypes(Class us

[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #15979: [fix][broker] fix DEFAULT_NAR_EXTRACTION_DIR cause NoClassDefFoundError

2022-06-14 Thread GitBox
Nicklee007 commented on code in PR #15979: URL: https://github.com/apache/pulsar/pull/15979#discussion_r896507302 ## bin/pulsar: ## @@ -290,6 +290,9 @@ if [[ -z "$IS_JAVA_8" ]]; then OPTS="$OPTS --add-opens java.base/sun.net=ALL-UNNAMED --add-opens java.management/sun.manage

[GitHub] [pulsar] Anonymitaet commented on issue #16046: The new Docbot spams PRs with multiple comments

2022-06-14 Thread GitBox
Anonymitaet commented on issue #16046: URL: https://github.com/apache/pulsar/issues/16046#issuecomment-1154857034 @lhotari thanks for your guidance and resource! @maxsxu is fixing this issue and will keep you updated. -- This is an automated message from the Apache Git Service. To respon

[pulsar-manager] branch master updated: Move version to 0.3.0 (#455)

2022-06-14 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 91e2a1f Move version to 0.3.0 (#455)

[GitHub] [pulsar] nodece commented on a diff in pull request #15568: [PIP-150][improve][broker] Support read the message of startMessageId position on the broker side

2022-06-14 Thread GitBox
nodece commented on code in PR #15568: URL: https://github.com/apache/pulsar/pull/15568#discussion_r896513355 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -939,7 +953,7 @@ public void operationComplete() { curs

[GitHub] [pulsar] AlphaWang opened a new issue, #16052: [Doc]

2022-06-14 Thread GitBox
AlphaWang opened a new issue, #16052: URL: https://github.com/apache/pulsar/issues/16052 ### What issue do you find in Pulsar docs? The [README.md](https://github.com/apache/pulsar/blob/master/README.md#configure-java-version-for-maven-in-intellij) explains how to configure JDK versi

[GitHub] [pulsar] nodece commented on a diff in pull request #15568: [PIP-150][improve][broker] Support read the message of startMessageId position on the broker side

2022-06-14 Thread GitBox
nodece commented on code in PR #15568: URL: https://github.com/apache/pulsar/pull/15568#discussion_r896513355 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -939,7 +953,7 @@ public void operationComplete() { curs

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896514640 ## tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/java/PulsarFunctionsJavaTest.java: ## @@ -166,7 +166,7 @@ public void testSlidingCountW

[GitHub] [pulsar] nodece commented on a diff in pull request #15568: [PIP-150][improve][broker] Support read the message of startMessageId position on the broker side

2022-06-14 Thread GitBox
nodece commented on code in PR #15568: URL: https://github.com/apache/pulsar/pull/15568#discussion_r896515237 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -878,61 +884,64 @@ private CompletableFuture getDurableSubscripti

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896517241 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionCommon.java: ## @@ -120,8 +121,20 @@ public static Class[] getFunctionTypes(Class user

[GitHub] [pulsar] AlphaWang commented on issue #16052: [Doc] The JDK version in README.md is not consistent

2022-06-14 Thread GitBox
AlphaWang commented on issue #16052: URL: https://github.com/apache/pulsar/issues/16052#issuecomment-1154868000 Please help check if this PR looks good https://github.com/apache/pulsar/pull/16053 -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] AlphaWang opened a new pull request, #16053: [fix][doc] make the JDK version consistent in readme.md

2022-06-14 Thread GitBox
AlphaWang opened a new pull request, #16053: URL: https://github.com/apache/pulsar/pull/16053 Fixes #16052 ### Motivation The [README.md](https://github.com/apache/pulsar/blob/master/README.md#configure-java-version-for-maven-in-intellij) explains how to configure JDK version for

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896520082 ## pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/utils/FunctionRecord.java: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pulsar] nodece commented on a diff in pull request #15568: [PIP-150][improve][broker] Support read the message of startMessageId position on the broker side

2022-06-14 Thread GitBox
nodece commented on code in PR #15568: URL: https://github.com/apache/pulsar/pull/15568#discussion_r896520651 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorImpl.java: ## @@ -48,39 +46,46 @@ public class NonDurableCursorImpl extends ManagedCur

[GitHub] [pulsar] mattisonchao commented on pull request #14920: [fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-``

2022-06-14 Thread GitBox
mattisonchao commented on PR #14920: URL: https://github.com/apache/pulsar/pull/14920#issuecomment-1154872905 Yes, We have to revert this PR and start a discussion in the mail list to find another graceful method. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] lhotari commented on pull request #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
lhotari commented on PR #16049: URL: https://github.com/apache/pulsar/pull/16049#issuecomment-1154880849 When evaluating the #12045 and #14985 changes, it seems that the solution breaks broker caching. I'll create an issue for tracking this. -- This is an automated mes

[GitHub] [pulsar] lhotari opened a new issue, #16054: Broker cache eviction evicts entries that haven't been read by active consumers

2022-06-14 Thread GitBox
lhotari opened a new issue, #16054: URL: https://github.com/apache/pulsar/issues/16054 **Describe the bug** #12045 changed cache eviction. The problem is that cache eviction is done to the position whatever happens to be the first cursor in the "heap" list in ManagedCursorContainer.

[GitHub] [pulsar] lhotari commented on pull request #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
lhotari commented on PR #16049: URL: https://github.com/apache/pulsar/pull/16049#issuecomment-1154895104 The issue about the broker cache regression is #16054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar] xyhmnb commented on issue #16029: Help!We have some questions about flink-connector-pulsar.

2022-06-14 Thread GitBox
xyhmnb commented on issue #16029: URL: https://github.com/apache/pulsar/issues/16029#issuecomment-1154898070 @Technoboy- sure~ ,but I always use this 1.15.0 version. These problems still exist. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] lhotari commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers

2022-06-14 Thread GitBox
lhotari commented on issue #16054: URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1154898378 @315157973 @lordcheng10 @merlimat @codelipenghui What's your thoughts on this issue? I wonder if the need for #14985 was caused by the regression described in this issue?

[GitHub] [pulsar] Anonymitaet opened a new pull request, #16055: [feat][workflow] add links of doc contribution guides to readme

2022-06-14 Thread GitBox
Anonymitaet opened a new pull request, #16055: URL: https://github.com/apache/pulsar/pull/16055 Original text `[README](site2/README.md).` is invalid. Replace it with some continuously updated resources. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] Anonymitaet commented on pull request #16055: [feat][workflow] add links of doc contribution guides to readme

2022-06-14 Thread GitBox
Anonymitaet commented on PR #16055: URL: https://github.com/apache/pulsar/pull/16055#issuecomment-1154900367 @Sherlock113 @momo-jun PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] 315157973 commented on pull request #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
315157973 commented on PR #16049: URL: https://github.com/apache/pulsar/pull/16049#issuecomment-1154902012 The previous PR is used to solve the memory problem caused by frequent traversal. I don't think add a read lock for cache evictions have any impact on the Broker's read and write p

[GitHub] [pulsar] Sherlock113 commented on pull request #16055: [feat][workflow] add links of doc contribution guides to readme

2022-06-14 Thread GitBox
Sherlock113 commented on PR #16055: URL: https://github.com/apache/pulsar/pull/16055#issuecomment-1154906542 /lgtm Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lhotari commented on issue #15954: PIP-174: Provide new implementation for broker dispatch cache

2022-06-14 Thread GitBox
lhotari commented on issue #15954: URL: https://github.com/apache/pulsar/issues/15954#issuecomment-1154907054 btw. The current broker cache seems to be broken. That happened in 2.8.2 / 2.9.0 . I have created an issue #16054 . -- This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: [improve][broker] Avoid reconnection when a partitioned topic was created concurrently (#16043)

2022-06-14 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2a7a8555c0b [improve][broker] Avoid reconnection wh

[GitHub] [pulsar] BewareMyPower merged pull request #16043: [improve][broker] Avoid reconnection when a partitioned topic was created concurrently

2022-06-14 Thread GitBox
BewareMyPower merged PR #16043: URL: https://github.com/apache/pulsar/pull/16043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] lhotari commented on issue #16054: Broker cache eviction evicts entries that haven't been read by active consumers

2022-06-14 Thread GitBox
lhotari commented on issue #16054: URL: https://github.com/apache/pulsar/issues/16054#issuecomment-1154928287 @315157973 @lordcheng10 I'll work on a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] frankjkelly commented on issue #15904: [Doc] Load Balancer - Broker overload thresholds does not apply to some Shedding algorithms

2022-06-14 Thread GitBox
frankjkelly commented on issue #15904: URL: https://github.com/apache/pulsar/issues/15904#issuecomment-1154929210 Great - thank you @momo-jun - will the PR be linked in here when submitted? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] Anonymitaet commented on issue #16038: [feat][workflow] add interactive features to bot

2022-06-14 Thread GitBox
Anonymitaet commented on issue #16038: URL: https://github.com/apache/pulsar/issues/16038#issuecomment-1154929711 > We could also reduce manual work by changing the workflow. Do we have documentation explaining why we still need this repo? > > > Some doc changes are applicable to mult

[GitHub] [pulsar] Anonymitaet commented on issue #16038: [feat][workflow] add interactive features to bot

2022-06-14 Thread GitBox
Anonymitaet commented on issue #16038: URL: https://github.com/apache/pulsar/issues/16038#issuecomment-1154932649 > > We want to cherry-pick only documentation PRs (not code PRs) to reduce manual maintenance work. > > That can be solved outside a docbot. There are security considerati

[GitHub] [pulsar] Choqs opened a new issue, #16056: [Bug][Python Client] _check_record_or_field exception throw another exception

2022-06-14 Thread GitBox
Choqs opened a new issue, #16056: URL: https://github.com/apache/pulsar/issues/16056 ### Describe the bug Using python pulsar-client, instantiating a schema with an array of a wrong type, leads exception to throw another exception. This make it harder to debug and understand what is

[pulsar] branch branch-2.10 updated: [fix][broker]Fix topic-level replicator rate limiter not init (#15825)

2022-06-14 Thread jianghaiting
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new a29feca574d [fix][broker]Fix top

[GitHub] [pulsar] Jason918 closed pull request #16034: [fix][broker]Fix replic topic rate limter for branch210

2022-06-14 Thread GitBox
Jason918 closed pull request #16034: [fix][broker]Fix replic topic rate limter for branch210 URL: https://github.com/apache/pulsar/pull/16034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] Jason918 commented on pull request #16034: [fix][broker]Fix replic topic rate limter for branch210

2022-06-14 Thread GitBox
Jason918 commented on PR #16034: URL: https://github.com/apache/pulsar/pull/16034#issuecomment-1154939376 Already cherry-picked to branch 2.10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] momo-jun commented on issue #15904: [Doc] Load Balancer - Broker overload thresholds does not apply to some Shedding algorithms

2022-06-14 Thread GitBox
momo-jun commented on issue #15904: URL: https://github.com/apache/pulsar/issues/15904#issuecomment-1154945336 > Great - thank you @momo-jun - will the PR be linked in here when submitted? Yes, you will be notified. -- This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] poorbarcode commented on issue #15134: Remove useless code to reduce confusion

2022-06-14 Thread GitBox
poorbarcode commented on issue #15134: URL: https://github.com/apache/pulsar/issues/15134#issuecomment-1154970872 It has been fixed at https://github.com/apache/pulsar/pull/15877, so close this pull request. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] poorbarcode closed issue #15134: Remove useless code to reduce confusion

2022-06-14 Thread GitBox
poorbarcode closed issue #15134: Remove useless code to reduce confusion URL: https://github.com/apache/pulsar/issues/15134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [pulsar] poorbarcode closed issue #15050: Broker registered the same consumers

2022-06-14 Thread GitBox
poorbarcode closed issue #15050: Broker registered the same consumers URL: https://github.com/apache/pulsar/issues/15050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar] poorbarcode commented on issue #15050: Broker registered the same consumers

2022-06-14 Thread GitBox
poorbarcode commented on issue #15050: URL: https://github.com/apache/pulsar/issues/15050#issuecomment-1154971688 fixed by #15051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[pulsar-dotpulsar] branch master updated: Adding compression tests both for runtime and testing

2022-06-14 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 94daac3 Adding compression te

[GitHub] [pulsar] nodece commented on pull request #16016: [fix][broker] Fix token expiration

2022-06-14 Thread GitBox
nodece commented on PR #16016: URL: https://github.com/apache/pulsar/pull/16016#issuecomment-1154993985 @codelipenghui The authenticate logic has been update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar] nodece commented on a diff in pull request #16016: [fix][broker] Fix token expiration

2022-06-14 Thread GitBox
nodece commented on code in PR #16016: URL: https://github.com/apache/pulsar/pull/16016#discussion_r896641140 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/TokenExpirationProduceConsumerTest.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software Founda

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896644084 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionCommon.java: ## @@ -120,8 +121,20 @@ public static Class[] getFunctionTypes(Class user

[GitHub] [pulsar] Technoboy- closed issue #15205: Pulsar should support cluster metadata store with etcd backend with SSL(https://...)

2022-06-14 Thread GitBox
Technoboy- closed issue #15205: Pulsar should support cluster metadata store with etcd backend with SSL(https://...) URL: https://github.com/apache/pulsar/issues/15205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pulsar] Technoboy- merged pull request #15270: [improve][metadata] Add tls config for etcd client

2022-06-14 Thread GitBox
Technoboy- merged PR #15270: URL: https://github.com/apache/pulsar/pull/15270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

[pulsar] branch master updated: [improve][metadata] Add tls config for etcd client (#15270)

2022-06-14 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e0c4099893a [improve][metadata] Add tls confi

[GitHub] [pulsar] Technoboy- merged pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-06-14 Thread GitBox
Technoboy- merged PR #14702: URL: https://github.com/apache/pulsar/pull/14702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

[pulsar] branch master updated: [PulsarAdmin] add get active brokers api without cluster name (#14702)

2022-06-14 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 72dfcc628da [PulsarAdmin] add get active brok

[pulsar-site] branch main updated (b8a85e151f6 -> 72e4308b631)

2022-06-14 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from b8a85e151f6 fix: remove redundant code of build workflow add b1821ec8298 [feat][workflow] add links of doc cont

[pulsar-site] 01/01: [feat][workflow] add links of doc contribution guides to Pulsar contribution page

2022-06-14 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 72e4308b63132e4fb4fcc009a64e8b5378f522d7 Merge: b8a85e151f6 c8407e27ec8 Author: Anonymitaet <50226895+anonymit...@users

[GitHub] [pulsar] nahguam opened a new pull request, #16057: [improve][docs] Improve examples and language

2022-06-14 Thread GitBox
nahguam opened a new pull request, #16057: URL: https://github.com/apache/pulsar/pull/16057 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] Nicklee007 commented on pull request #15979: [fix][broker] fix DEFAULT_NAR_EXTRACTION_DIR cause NoClassDefFoundError

2022-06-14 Thread GitBox
Nicklee007 commented on PR #15979: URL: https://github.com/apache/pulsar/pull/15979#issuecomment-1155058064 > I support the change, as far as we don't change the behaviour at least for this release. @eolivelli Could you help me add some label to mark the feature will add in the foll

[GitHub] [pulsar] eolivelli commented on pull request #15979: [fix][broker] fix DEFAULT_NAR_EXTRACTION_DIR cause NoClassDefFoundError

2022-06-14 Thread GitBox
eolivelli commented on PR #15979: URL: https://github.com/apache/pulsar/pull/15979#issuecomment-1155071695 > Could you help me add some label to mark the feature will add in the follow release, Thx! There is actually now way to express that. You can create a new issue to change th

[GitHub] [pulsar] momo-jun commented on pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

2022-06-14 Thread GitBox
momo-jun commented on PR #15790: URL: https://github.com/apache/pulsar/pull/15790#issuecomment-1155086830 Ping @Anonymitaet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[pulsar-dotpulsar] branch master updated: Implemented support for ZstdSharp.Port

2022-06-14 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 0c34db7 Implemented support f

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#72dfcc6)

2022-06-14 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 6edab6866df Docs sync done from apache/pulsar(#

[pulsar] branch master updated: [ML] Fix thread safety issues in ManagedCursorContainer related to "heap" field access (#16049)

2022-06-14 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ec9676f6431 [ML] Fix thread safety issues in

[GitHub] [pulsar] eolivelli merged pull request #16049: [ML] Fix thread safety issues in accessing ManagedCursorContainer.heap ArrayList

2022-06-14 Thread GitBox
eolivelli merged PR #16049: URL: https://github.com/apache/pulsar/pull/16049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar] Anonymitaet merged pull request #16055: [feat][workflow] add links of doc contribution guides to readme

2022-06-14 Thread GitBox
Anonymitaet merged PR #16055: URL: https://github.com/apache/pulsar/pull/16055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[pulsar] branch master updated: [feat][workflow] add links of doc contribution guides to readme (#16055)

2022-06-14 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d98fce3d8ae [feat][workflow] add links of doc con

[GitHub] [pulsar] lhotari commented on a diff in pull request #16045: [fix][proxy] Use correct channel for HAProxyMessage dest address

2022-06-14 Thread GitBox
lhotari commented on code in PR #16045: URL: https://github.com/apache/pulsar/pull/16045#discussion_r896777535 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java: ## @@ -233,7 +233,7 @@ private void writeHAProxyMessage() { InetS

[GitHub] [pulsar] lordcheng10 commented on pull request #15184: [fix][broker] fix npe when doCacheEviction

2022-06-14 Thread GitBox
lordcheng10 commented on PR #15184: URL: https://github.com/apache/pulsar/pull/15184#issuecomment-1155145303 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] cbornet commented on pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on PR #16041: URL: https://github.com/apache/pulsar/pull/16041#issuecomment-1155196275 > Is this change ABI compatible so that existing user created Pulsar Functions implementations can be run without recompiling when upgrading to a version that includes this change?

[pulsar-dotpulsar] branch master updated: Make ready for release 2.4.0

2022-06-14 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 55745be Make ready for releas

[pulsar-dotpulsar] annotated tag 2.4.0 updated (55745be -> 01bac38)

2022-06-14 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a change to annotated tag 2.4.0 in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git *** WARNING: tag 2.4.0 was modified! *** from 55745be (commit) to 01bac38 (tag) tagging 5

[GitHub] [pulsar] coderzc opened a new issue, #16058: PIP-177: Add the classLoader field for SchemaDefinition

2022-06-14 Thread GitBox
coderzc opened a new issue, #16058: URL: https://github.com/apache/pulsar/issues/16058 ## Motivation Now, don‘t register logical type conversions when use `SchemaDefinition.builder().withJsonDef()` to create the schema, beacase it without classLoader param. See: https://githu

[GitHub] [pulsar] coderzc commented on a diff in pull request #15915: [fix][client] Add classLoader field for `SchemaDefinition`

2022-06-14 Thread GitBox
coderzc commented on code in PR #15915: URL: https://github.com/apache/pulsar/pull/15915#discussion_r896854052 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaDefinitionBuilder.java: ## @@ -80,6 +80,15 @@ */ SchemaDefinitionBuilder withPoj

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896875138 ## tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/java/PulsarFunctionsJavaTest.java: ## @@ -166,7 +166,7 @@ public void testSlidingCountW

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896875504 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionCommon.java: ## @@ -120,8 +121,20 @@ public static Class[] getFunctionTypes(Class user

[GitHub] [pulsar] cbornet commented on a diff in pull request #16041: [improve][function] Support Record as Function output type

2022-06-14 Thread GitBox
cbornet commented on code in PR #16041: URL: https://github.com/apache/pulsar/pull/16041#discussion_r896900334 ## pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/utils/FunctionRecord.java: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pulsar] HQebupt opened a new pull request, #16059: [improve][broker] add switch for enable/disable distribute bundles evenly in LoadManager

2022-06-14 Thread GitBox
HQebupt opened a new pull request, #16059: URL: https://github.com/apache/pulsar/pull/16059 ### Motivation When we use `ModualLoadManager` as `LoadManager` in the pulsar cluster, and the load balancer shedding strategy is `ThresholdShedder`, we found that the unloaded bundles might be lo

[GitHub] [pulsar] maxsxu opened a new pull request, #16060: [fix][workflow] Support concurrency group in docbot

2022-06-14 Thread GitBox
maxsxu opened a new pull request, #16060: URL: https://github.com/apache/pulsar/pull/16060 Fixes #16046 ### Motivation Multiple workflows can be running concurrently while `labeled` event triggered instantly after `opened` event before the docbot workflow is running. Thi

[GitHub] [pulsar] lhotari commented on pull request #16060: [fix][workflow] Support concurrency group in docbot

2022-06-14 Thread GitBox
lhotari commented on PR #16060: URL: https://github.com/apache/pulsar/pull/16060#issuecomment-1155359543 btw. please also change `uses: apache/pulsar-test-infra/docbot@master` to `uses: ./docbot` . That should be done since the `apache/pulsar-test-infra` is already checked out -- This is

[GitHub] [pulsar] maxsxu commented on pull request #16060: [fix][workflow] Support concurrency group in docbot

2022-06-14 Thread GitBox
maxsxu commented on PR #16060: URL: https://github.com/apache/pulsar/pull/16060#issuecomment-1155383609 > btw. please also change `uses: apache/pulsar-test-infra/docbot@master` to `uses: ./docbot` . That should be done since the `apache/pulsar-test-infra` is already checked out. > >

[GitHub] [pulsar] lhotari commented on pull request #16060: [fix][workflow] Support concurrency group in docbot

2022-06-14 Thread GitBox
lhotari commented on PR #16060: URL: https://github.com/apache/pulsar/pull/16060#issuecomment-1155386922 > Just a detail: If we address it in the same PR, should we change the PR title? yes that makes sense. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16045: [fix][proxy] Use correct channel for HAProxyMessage dest address

2022-06-14 Thread GitBox
michaeljmarshall commented on code in PR #16045: URL: https://github.com/apache/pulsar/pull/16045#discussion_r897012262 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java: ## @@ -233,7 +233,7 @@ private void writeHAProxyMessage() {

[GitHub] [pulsar] lhotari commented on a diff in pull request #16060: [fix][workflow] Support concurrency group and reusable workflow files in docbot

2022-06-14 Thread GitBox
lhotari commented on code in PR #16060: URL: https://github.com/apache/pulsar/pull/16060#discussion_r897017544 ## .github/workflows/ci-documentbot.yml: ## @@ -27,6 +27,10 @@ on: - labeled - unlabeled +concurrency: + group: ${{ github.workflow }}-${{ github.ref }

[GitHub] [pulsar] maxsxu commented on a diff in pull request #16060: [fix][workflow] Support concurrency group and reusable workflow files in docbot

2022-06-14 Thread GitBox
maxsxu commented on code in PR #16060: URL: https://github.com/apache/pulsar/pull/16060#discussion_r897022716 ## .github/workflows/ci-documentbot.yml: ## @@ -27,6 +27,10 @@ on: - labeled - unlabeled +concurrency: + group: ${{ github.workflow }}-${{ github.ref }}

[GitHub] [pulsar] BewareMyPower opened a new pull request, #16061: [feature][broker] PIP 37: Support chunking with Shared subscription

2022-06-14 Thread GitBox
BewareMyPower opened a new pull request, #16061: URL: https://github.com/apache/pulsar/pull/16061 ### Motivation This is the first part to support chunking with Shared subscription. Instead of adopting the solutions from the original proposal, this PR uses a more simple way: 1

[GitHub] [pulsar] coderzc commented on pull request #15678: [improve][proxy] Support zero-copy of NIC to NIC on Proxy

2022-06-14 Thread GitBox
coderzc commented on PR #15678: URL: https://github.com/apache/pulsar/pull/15678#issuecomment-1155399119 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lhotari commented on a diff in pull request #16060: [fix][workflow] Support concurrency group and reusable workflow files in docbot

2022-06-14 Thread GitBox
lhotari commented on code in PR #16060: URL: https://github.com/apache/pulsar/pull/16060#discussion_r897036383 ## .github/workflows/ci-documentbot.yml: ## @@ -27,6 +27,10 @@ on: - labeled - unlabeled +concurrency: + group: ${{ github.workflow }}-${{ github.ref }

[GitHub] [pulsar] BewareMyPower commented on pull request #16061: [feature][broker] PIP 37: Support chunking with Shared subscription

2022-06-14 Thread GitBox
BewareMyPower commented on PR #16061: URL: https://github.com/apache/pulsar/pull/16061#issuecomment-1155425301 https://lists.apache.org/thread/c7qo8x2fr52s0o0lgs5k53nrhq23r6qs Though I've planned to write a proposal before, I'm still wondering if this PR needs a proposal. The support for ch

[GitHub] [pulsar] andrasbeni opened a new pull request, #16062: [feat][broker] PIP-145: Notifications for faster topic discovery

2022-06-14 Thread GitBox
andrasbeni opened a new pull request, #16062: URL: https://github.com/apache/pulsar/pull/16062 Fixes #14505 ### Motivation When using a pattern-based subscription, clients poll for new topics that match the pattern. It can happen frequently that the first messages produced

[GitHub] [pulsar] coderzc commented on pull request #15678: [improve][proxy] Support zero-copy of NIC to NIC on Proxy

2022-06-14 Thread GitBox
coderzc commented on PR #15678: URL: https://github.com/apache/pulsar/pull/15678#issuecomment-1155489591 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   >