[GitHub] [pulsar] danpi commented on pull request #16565: [fix][function] Fixed error when user starts with the pulsar functions local runner

2022-07-13 Thread GitBox
danpi commented on PR #16565: URL: https://github.com/apache/pulsar/pull/16565#issuecomment-1184061182 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar] Shoothzj commented on pull request #16591: Bump prometheus client version from 0.15.0 to 0.16.0

2022-07-13 Thread GitBox
Shoothzj commented on PR #16591: URL: https://github.com/apache/pulsar/pull/16591#issuecomment-1184059825 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] Anonymitaet commented on issue #15892: [improve][doc] highlight important notice

2022-07-13 Thread GitBox
Anonymitaet commented on issue #15892: URL: https://github.com/apache/pulsar/issues/15892#issuecomment-1184056142 @hpa16 assigned. Feel free to ping me to merge your PR after all checks pass. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] Nicklee007 commented on pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-07-13 Thread GitBox
Nicklee007 commented on PR #15474: URL: https://github.com/apache/pulsar/pull/15474#issuecomment-1184053259 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] Nicklee007 commented on pull request #16573: [fix][broker]fix the zero value as denominator cause ArithmeticException when selectBroker use LeastResourceUsageWithWeight

2022-07-13 Thread GitBox
Nicklee007 commented on PR #16573: URL: https://github.com/apache/pulsar/pull/16573#issuecomment-1184052928 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] Nicklee007 commented on pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

2022-07-13 Thread GitBox
Nicklee007 commented on PR #16325: URL: https://github.com/apache/pulsar/pull/16325#issuecomment-1184051643 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] gaozhangmin commented on pull request #16562: [fix][flaky-test] testSplitBundleForMultiTimes

2022-07-13 Thread GitBox
gaozhangmin commented on PR #16562: URL: https://github.com/apache/pulsar/pull/16562#issuecomment-1184050711 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] gaozhangmin commented on pull request #16411: [improve][broker] Make splitNamespaceBundle and getTopicHashPositions async

2022-07-13 Thread GitBox
gaozhangmin commented on PR #16411: URL: https://github.com/apache/pulsar/pull/16411#issuecomment-1184050521 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] github-actions[bot] commented on pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16590: URL: https://github.com/apache/pulsar/pull/16590#issuecomment-1184045130 @horizonzy Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-

[GitHub] [pulsar] Shoothzj commented on pull request #16581: Rename Pulsar txn metrics to specify OpenMetrics

2022-07-13 Thread GitBox
Shoothzj commented on PR #16581: URL: https://github.com/apache/pulsar/pull/16581#issuecomment-1184039004 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] danpi commented on pull request #16565: [fix][function] Fixed error when user starts with the pulsar functions local runner

2022-07-13 Thread GitBox
danpi commented on PR #16565: URL: https://github.com/apache/pulsar/pull/16565#issuecomment-1184037556 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar] Shoothzj commented on pull request #16591: Bump prometheus client version from 0.15.0 to 0.16.0

2022-07-13 Thread GitBox
Shoothzj commented on PR #16591: URL: https://github.com/apache/pulsar/pull/16591#issuecomment-1184037173 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#596fc3c)

2022-07-13 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new f6b9a7db61e Docs sync done from apache/pulsar(#

[GitHub] [pulsar] HQebupt commented on pull request #16546: [fix][broker]stage 1: check the cursor status when handling flowPermits

2022-07-13 Thread GitBox
HQebupt commented on PR #16546: URL: https://github.com/apache/pulsar/pull/16546#issuecomment-1184028499 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] HQebupt commented on pull request #16572: [improve][doc]add more explanation for retention configuration

2022-07-13 Thread GitBox
HQebupt commented on PR #16572: URL: https://github.com/apache/pulsar/pull/16572#issuecomment-1184028358 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] AnonHxy commented on pull request #16594: [fix][client]Fix newLookup TooManyRequestsException message

2022-07-13 Thread GitBox
AnonHxy commented on PR #16594: URL: https://github.com/apache/pulsar/pull/16594#issuecomment-1184014343 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] AnonHxy opened a new issue, #16595: Flaky-test: org.apache.pulsar.client.impl.PatternTopicsConsumerImplTest.testAutoSubscribePatternConsumer

2022-07-13 Thread GitBox
AnonHxy opened a new issue, #16595: URL: https://github.com/apache/pulsar/issues/16595 org.apache.pulsar.client.impl.PatternTopicsConsumerImplTest.testAutoSubscribePatternConsumer is flaky. It fails sporadically. [example failure](https://github.com/apache/pulsar/runs/7333593643

[GitHub] [pulsar] truong-hua closed issue #15696: Java pulsar function can not subscribe to a non-defined schema topic

2022-07-13 Thread GitBox
truong-hua closed issue #15696: Java pulsar function can not subscribe to a non-defined schema topic URL: https://github.com/apache/pulsar/issues/15696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] truong-hua commented on issue #15696: Java pulsar function can not subscribe to a non-defined schema topic

2022-07-13 Thread GitBox
truong-hua commented on issue #15696: URL: https://github.com/apache/pulsar/issues/15696#issuecomment-1183997396 Sorry, this is my mistake, just define `Function`worker and it can consume any schema. If possible, it should be clearly describe in the document. -- This is an automated mess

[GitHub] [pulsar] michaeljmarshall commented on pull request #16513: [fix][java-client] Make DeadLetterPolicy deserializable

2022-07-13 Thread GitBox
michaeljmarshall commented on PR #16513: URL: https://github.com/apache/pulsar/pull/16513#issuecomment-1183993650 Thanks @coderzc! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] hpa16 commented on issue #15892: [improve][doc] highlight important notice

2022-07-13 Thread GitBox
hpa16 commented on issue #15892: URL: https://github.com/apache/pulsar/issues/15892#issuecomment-1183981552 @Anonymitaet I have updated the PR. Can you please assign this issue to me and merge the PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] AnonHxy opened a new pull request, #16594: [fix][client]Fix newLookup TooManyRequestsException message

2022-07-13 Thread GitBox
AnonHxy opened a new pull request, #16594: URL: https://github.com/apache/pulsar/pull/16594 ### Motivation * Fix `org.apache.pulsar.client.impl.ClientCnx#newLookup` throw `TooManyRequestsException` message ### Modifications * Changing `pendingLookupRequestSemaphore.avail

[GitHub] [pulsar] horizonzy commented on a diff in pull request #16590: [WIP][PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
horizonzy commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r920717343 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/LedgerDeletionSystemTopicClient.java: ## @@ -0,0 +1,220 @@ +/** + * Licensed to the Apache Software F

[GitHub] [pulsar] github-actions[bot] commented on pull request #16565: [fix][function] Fixed error when user starts with the pulsar functions local runner

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16565: URL: https://github.com/apache/pulsar/pull/16565#issuecomment-1183955093 @danpi Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7

[GitHub] [pulsar] github-actions[bot] commented on pull request #16590: [WIP][PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16590: URL: https://github.com/apache/pulsar/pull/16590#issuecomment-1183954132 @horizonzy Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-

[GitHub] [pulsar] danpi commented on pull request #16565: [fix][function] Fixed error when user starts with the pulsar functions local runner

2022-07-13 Thread GitBox
danpi commented on PR #16565: URL: https://github.com/apache/pulsar/pull/16565#issuecomment-1183954066 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar-client-go] ne1llee opened a new issue, #807: How to change the BatchingMaxSize of DLQ

2022-07-13 Thread GitBox
ne1llee opened a new issue, #807: URL: https://github.com/apache/pulsar-client-go/issues/807 The default BatchingMaxSize is 128K, and messages that exceed this size cannot be put into DLQ。 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] gaozhangmin opened a new pull request, #16593: [fix][flaky-test] testEnsureNotBlockOnThePendingQueue

2022-07-13 Thread GitBox
gaozhangmin opened a new pull request, #16593: URL: https://github.com/apache/pulsar/pull/16593 ### Motivation Fixes flaky-test : https://github.com/apache/pulsar/runs/7332920657?check_suite_focus=true ``` Error: testEnsureNotBlockOnThePendingQueue(org.apache.pulsar.client.impl.Pr

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920720839 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] congbobo184 opened a new pull request, #16592: [fix][flaky-test] fix cumulative ack test after abort redeliver messa…

2022-07-13 Thread GitBox
congbobo184 opened a new pull request, #16592: URL: https://github.com/apache/pulsar/pull/16592 ### Motivation since https://github.com/apache/pulsar/pull/14371 merged, when the client abort txn with cumulative ack, We need to the redeliver message manually ### Modifications cha

[GitHub] [pulsar] horizonzy commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
horizonzy commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r920717343 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/LedgerDeletionSystemTopicClient.java: ## @@ -0,0 +1,220 @@ +/** + * Licensed to the Apache Software F

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
gaozhangmin commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r920716462 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/LedgerDeletionSystemTopicClient.java: ## @@ -0,0 +1,220 @@ +/** + * Licensed to the Apache Software

[GitHub] [pulsar] github-actions[bot] commented on pull request #16591: Bump prometheus client version from 0.15.0 to 0.16.0

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16591: URL: https://github.com/apache/pulsar/pull/16591#issuecomment-1183940571 @Shoothzj Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r

[GitHub] [pulsar] Nicklee007 commented on pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

2022-07-13 Thread GitBox
Nicklee007 commented on PR #16325: URL: https://github.com/apache/pulsar/pull/16325#issuecomment-1183938722 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] Shoothzj opened a new pull request, #16591: Bump prometheus client version from 0.15.0 to 0.16.0

2022-07-13 Thread GitBox
Shoothzj opened a new pull request, #16591: URL: https://github.com/apache/pulsar/pull/16591 ### Motivation prometheus client 0.16.0 contains some approvements that we can benefit from. Thanks for @dave2wave @michaeljmarshall the reminder and pointing out. > [ENHANCEMENT] Reduce t

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920711045 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920709368 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920708314 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[pulsar] branch master updated: [improve][test] Improve the TransactionTest to reduce the execution time (#16580)

2022-07-13 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 596fc3cd6b0 [improve][test] Improve the Transac

[GitHub] [pulsar] codelipenghui merged pull request #16580: [improve][test] Improve the TransactionTest to reduce the execution time

2022-07-13 Thread GitBox
codelipenghui merged PR #16580: URL: https://github.com/apache/pulsar/pull/16580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] Shoothzj commented on pull request #13785: Bump prometheus client version from 0.5.0 to 0.15.0

2022-07-13 Thread GitBox
Shoothzj commented on PR #13785: URL: https://github.com/apache/pulsar/pull/13785#issuecomment-1183926688 @dave2wave @michaeljmarshall Thanks, I will follow up on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar] lordcheng10 commented on pull request #16557: [improve][broker]Add new split algorithm: Split algorithm based on flow or qps

2022-07-13 Thread GitBox
lordcheng10 commented on PR #16557: URL: https://github.com/apache/pulsar/pull/16557#issuecomment-1183926343 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] michaeljmarshall commented on pull request #13785: Bump prometheus client version from 0.5.0 to 0.15.0

2022-07-13 Thread GitBox
michaeljmarshall commented on PR #13785: URL: https://github.com/apache/pulsar/pull/13785#issuecomment-1183926148 @dave2wave - thanks for sharing. Based on two of the enhancements, we should probably upgrade before cutting the 2.11 branch. -- This is an automated message from the Apache G

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920705224 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920704296 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920704007 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] Nicklee007 commented on pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

2022-07-13 Thread GitBox
Nicklee007 commented on PR #16325: URL: https://github.com/apache/pulsar/pull/16325#issuecomment-1183924610 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920703931 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar-client-go] Gleiphir2769 commented on pull request #806: [issue 447] double check message size when client enable compress

2022-07-13 Thread GitBox
Gleiphir2769 commented on PR #806: URL: https://github.com/apache/pulsar-client-go/pull/806#issuecomment-1183924276 Hello, I think this problem may be resolved in #805 . https://github.com/apache/pulsar-client-go/pull/805/files#diff-8adb09af2175be5751840343e14df2220a2154ca4bc8de21157ed112

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920703508 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920703380 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920703285 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920703167 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack

2022-07-13 Thread GitBox
poorbarcode commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920702783 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,483 @@ +/** + * Licensed to

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending a

2022-07-13 Thread GitBox
codelipenghui commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920702565 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,489 @@ +/** + * Licensed t

[GitHub] [pulsar] Nicklee007 commented on pull request #16573: [fix][broker]fix the zero value as denominator cause ArithmeticException when selectBroker use LeastResourceUsageWithWeight

2022-07-13 Thread GitBox
Nicklee007 commented on PR #16573: URL: https://github.com/apache/pulsar/pull/16573#issuecomment-1183922602 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] lordcheng10 commented on pull request #16557: [improve][broker]Add new split algorithm: Split algorithm based on flow or qps

2022-07-13 Thread GitBox
lordcheng10 commented on PR #16557: URL: https://github.com/apache/pulsar/pull/16557#issuecomment-1183922536 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar-helm-chart] branch master updated: scripts: provide an error if the namespace was not created (#276)

2022-07-13 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new a2d3f3e scripts: provide an error

[GitHub] [pulsar] HQebupt commented on pull request #16546: [fix][broker]stage 1: check the cursor status when handling flowPermits

2022-07-13 Thread GitBox
HQebupt commented on PR #16546: URL: https://github.com/apache/pulsar/pull/16546#issuecomment-1183917962 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16428: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending a

2022-07-13 Thread GitBox
codelipenghui commented on code in PR #16428: URL: https://github.com/apache/pulsar/pull/16428#discussion_r920698758 ## pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriter.java: ## @@ -0,0 +1,453 @@ +/** + * Licensed t

[GitHub] [pulsar] nodece commented on a diff in pull request #16568: [improve][client] Add original principal and authentication data support

2022-07-13 Thread GitBox
nodece commented on code in PR #16568: URL: https://github.com/apache/pulsar/pull/16568#discussion_r920698629 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java: ## @@ -566,4 +566,20 @@ ClientBuilder authentication(String authPluginClassName, Map

[GitHub] [pulsar] HQebupt commented on pull request #16572: [improve][doc]add more explanation for retention configuration

2022-07-13 Thread GitBox
HQebupt commented on PR #16572: URL: https://github.com/apache/pulsar/pull/16572#issuecomment-1183917704 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] nodece commented on issue #16582: Test: mockito broken

2022-07-13 Thread GitBox
nodece commented on issue #16582: URL: https://github.com/apache/pulsar/issues/16582#issuecomment-1183916773 @nicoloboschi Thanks for your fix, I need some tim to test this, if there no problem, I'll close this issue. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] horizonzy closed pull request #15834: [WIP] introduce two phase deletion protocol.

2022-07-13 Thread GitBox
horizonzy closed pull request #15834: [WIP] introduce two phase deletion protocol. URL: https://github.com/apache/pulsar/pull/15834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16342: [proxy] Do not preserve host when forwarding admin requests.

2022-07-13 Thread GitBox
michaeljmarshall commented on code in PR #16342: URL: https://github.com/apache/pulsar/pull/16342#discussion_r920691749 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java: ## @@ -267,7 +267,6 @@ public static void addWebServerHandlers(WebServer

[GitHub] [pulsar] github-actions[bot] commented on issue #15902: [PIP] PIP-173 : Create a built-in Function implementing the most common basic transformations

2022-07-13 Thread GitBox
github-actions[bot] commented on issue #15902: URL: https://github.com/apache/pulsar/issues/15902#issuecomment-1183906374 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on pull request #15834: [WIP] introduce two phase deletion protocol.

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #15834: URL: https://github.com/apache/pulsar/pull/15834#issuecomment-1183906423 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar] github-actions[bot] commented on pull request #15998: [doc] Add a step about JDK17 configuration to the Pulsar SQL document

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #15998: URL: https://github.com/apache/pulsar/pull/15998#issuecomment-1183906342 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar] github-actions[bot] commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16018: URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1183906309 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar] github-actions[bot] commented on issue #16037: FlinkPulsarSink EXACTLY_ONCE issue

2022-07-13 Thread GitBox
github-actions[bot] commented on issue #16037: URL: https://github.com/apache/pulsar/issues/16037#issuecomment-1183906267 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on pull request #16025: [storage][broker][monitoring][cleanup] reimplement ledger cache metrics by Prometheus

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16025: URL: https://github.com/apache/pulsar/pull/16025#issuecomment-1183906285 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar] github-actions[bot] commented on pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16590: URL: https://github.com/apache/pulsar/pull/16590#issuecomment-1183905605 @horizonzy Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-

[GitHub] [pulsar] horizonzy opened a new pull request, #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-07-13 Thread GitBox
horizonzy opened a new pull request, #16590: URL: https://github.com/apache/pulsar/pull/16590 Original issue: #13238 PIP Issue: #16569 ### Motivation In current ledger deletion, we divided it into two separate steps. It happens in ManagedLedger and ManagedCursor. Remove a

[GitHub] [pulsar] Nicklee007 commented on pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

2022-07-13 Thread GitBox
Nicklee007 commented on PR #15474: URL: https://github.com/apache/pulsar/pull/15474#issuecomment-1183903387 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] Nicklee007 commented on pull request #16573: [fix][broker]fix the zero value as denominator cause ArithmeticException when selectBroker use LeastResourceUsageWithWeight

2022-07-13 Thread GitBox
Nicklee007 commented on PR #16573: URL: https://github.com/apache/pulsar/pull/16573#issuecomment-1183900643 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] Anonymitaet closed issue #16585: [Doc] Manage Schema - Upload a Schema - Example 1 is incorrect

2022-07-13 Thread GitBox
Anonymitaet closed issue #16585: [Doc] Manage Schema - Upload a Schema - Example 1 is incorrect URL: https://github.com/apache/pulsar/issues/16585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet merged pull request #16501: [fix][io-quickstart][docs] Corrected split sentence in tip

2022-07-13 Thread GitBox
Anonymitaet merged PR #16501: URL: https://github.com/apache/pulsar/pull/16501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[pulsar] branch master updated: [Doc] schema-manage example 1 fix

2022-07-13 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bb63136963f [Doc] schema-manage example 1 fix bb6

[GitHub] [pulsar] Anonymitaet merged pull request #16586: [Doc] schema-manage example 1 fix

2022-07-13 Thread GitBox
Anonymitaet merged PR #16586: URL: https://github.com/apache/pulsar/pull/16586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[pulsar] branch master updated: [fix][io-quickstart][docs] Corrected split sentence in tip (#16501)

2022-07-13 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d8463f78425 [fix][io-quickstart][docs] Corrected

[GitHub] [pulsar] Anonymitaet commented on pull request #16575: [improve][doc] Highlight important tips

2022-07-13 Thread GitBox
Anonymitaet commented on PR #16575: URL: https://github.com/apache/pulsar/pull/16575#issuecomment-1183859492 > Hi @Anonymitaet, I see that the Connector Admin CLI page has an Important tag nested under a Note. Would you like me to convert that to a Tip too? Attaching a screenshot > >

[pulsar] branch master updated: [fix][doc] fix client-libraries table style (#16522)

2022-07-13 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e406e583ea4 [fix][doc] fix client-libraries table

[GitHub] [pulsar] Anonymitaet merged pull request #16522: [fix][doc] fix client-libraries table style

2022-07-13 Thread GitBox
Anonymitaet merged PR #16522: URL: https://github.com/apache/pulsar/pull/16522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[GitHub] [pulsar] codelipenghui opened a new issue, #16589: Flaky-test: TransactionEndToEndWithoutBatchIndexAckTest.txnAckTestBatchAndCumulativeSub

2022-07-13 Thread GitBox
codelipenghui opened a new issue, #16589: URL: https://github.com/apache/pulsar/issues/16589 [example failure](https://github.com/apache/pulsar/runs/7327040379?check_suite_focus=true) ``` Error: Tests run: 43, Failures: 1, Errors: 0, Skipped: 28, Time elapsed: 141.1 s <<< FAILURE

[GitHub] [pulsar] codelipenghui commented on issue #16483: Flaky-test: PulsarFunctionTlsTest.tearDown

2022-07-13 Thread GitBox
codelipenghui commented on issue #16483: URL: https://github.com/apache/pulsar/issues/16483#issuecomment-1183809238 It happened again, it looks like #16473 has not fixed the issue yet. https://github.com/apache/pulsar/runs/7327039857?check_suite_focus=true -- This is an automated me

[GitHub] [pulsar] mans2singh commented on pull request #16501: [fix][io-quickstart][docs] Corrected split sentence in tip

2022-07-13 Thread GitBox
mans2singh commented on PR #16501: URL: https://github.com/apache/pulsar/pull/16501#issuecomment-1183809019 Hi @Anonymitaet - I've resolved the conflicts with the main branch. Please let me know if there is anything else required. Thanks again for your time. -- This is a

[GitHub] [pulsar] rillo-carrillo opened a new issue, #16588: Pulsar Audit - Question

2022-07-13 Thread GitBox
rillo-carrillo opened a new issue, #16588: URL: https://github.com/apache/pulsar/issues/16588 Need to know if there is a way to know which user with what role executed a REST API call to Pulsar Broker for Audit purposes. I have look throughout documentation but was not able to find it

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#e409249)

2022-07-13 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 3f464080031 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] michaeljmarshall commented on issue #16587: Broker Cache Allocations Metrics Always 0

2022-07-13 Thread GitBox
michaeljmarshall commented on issue #16587: URL: https://github.com/apache/pulsar/issues/16587#issuecomment-1183732378 These are 0 because `managedLedgerCacheCopyEntries` is `false` in the broker.conf. I wonder if it is worth not exposing allocator metrics when that value is false? Closing

[GitHub] [pulsar] michaeljmarshall closed issue #16587: Broker Cache Allocations Metrics Always 0

2022-07-13 Thread GitBox
michaeljmarshall closed issue #16587: Broker Cache Allocations Metrics Always 0 URL: https://github.com/apache/pulsar/issues/16587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pulsar] michaeljmarshall opened a new issue, #16587: Broker Cache Allocations Metrics Always 0

2022-07-13 Thread GitBox
michaeljmarshall opened a new issue, #16587: URL: https://github.com/apache/pulsar/issues/16587 **Describe the bug** The `allocator-stats` for the broker's entry cache appear to be broken because they are always 0, even when the cache is in use. **To Reproduce** Steps to reprodu

[GitHub] [pulsar] github-actions[bot] commented on pull request #16586: [Doc] schema-manage example 1 fix

2022-07-13 Thread GitBox
github-actions[bot] commented on PR #16586: URL: https://github.com/apache/pulsar/pull/16586#issuecomment-1183723097 @mfortman11 Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2

[GitHub] [pulsar] mfortman11 opened a new pull request, #16586: [Doc] schema-manage example 1 fix

2022-07-13 Thread GitBox
mfortman11 opened a new pull request, #16586: URL: https://github.com/apache/pulsar/pull/16586 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] mfortman11 opened a new issue, #16585: [Doc] Manage Schema - Upload a Schema - Example 1 is incorrect

2022-07-13 Thread GitBox
mfortman11 opened a new issue, #16585: URL: https://github.com/apache/pulsar/issues/16585 ### What issue do you find in Pulsar docs? On [https://pulsar.apache.org/docs/schema-manage/#upload-a-schema](https://pulsar.apache.org/docs/schema-manage/#upload-a-schema) in Example 1 there ar

[GitHub] [pulsar] michaeljmarshall commented on issue #16584: Add Broker Cache Entry Eviction Rate Metric

2022-07-13 Thread GitBox
michaeljmarshall commented on issue #16584: URL: https://github.com/apache/pulsar/issues/16584#issuecomment-1183695208 @lhotari - I think additional metrics like the one described above could help make an issue like https://github.com/apache/pulsar/issues/16054 easier to observe. -- This

[GitHub] [pulsar] michaeljmarshall opened a new issue, #16584: Add Broker Cache Entry Eviction Rate Metric

2022-07-13 Thread GitBox
michaeljmarshall opened a new issue, #16584: URL: https://github.com/apache/pulsar/issues/16584 **Is your enhancement request related to a problem? Please describe.** The current broker cache eviction metric, `pulsar_ml_cache_evictions`, measures when the cache's [hasSpaceInCache]( ht

[GitHub] [pulsar] pgier opened a new pull request, #16583: [site] remove unnecessary option from helm install

2022-07-13 Thread GitBox
pgier opened a new pull request, #16583: URL: https://github.com/apache/pulsar/pull/16583 The helm option `--set initialize=true` is no longer needed. See: https://github.com/apache/pulsar-helm-chart/pull/138 Signed-off-by: Paul Gier ### Motivation Minor simplificatio

[pulsar] branch master updated: [fix][doc] Fix wording in Tiered Storage (#16579)

2022-07-13 Thread wave
This is an automated email from the ASF dual-hosted git repository. wave pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e4092498cc0 [fix][doc] Fix wording in Tiered Stora

[GitHub] [pulsar] dave2wave merged pull request #16579: [fix][doc] Fix wording in Tiered Storage

2022-07-13 Thread GitBox
dave2wave merged PR #16579: URL: https://github.com/apache/pulsar/pull/16579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar-client-go] branch master updated: [issue #752] replace go-rate rate limiter with a buffered channel implementation (#799)

2022-07-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 6a8e7f3 [issue #752] replace go-rate

  1   2   3   >