[GitHub] [pulsar] tisonkun commented on a diff in pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata

2022-08-16 Thread GitBox
tisonkun commented on code in PR #17077: URL: https://github.com/apache/pulsar/pull/17077#discussion_r947514100 ## pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java: ## @@ -434,10 +438,13 @@ public void close() { } } - -private void startBoo

[GitHub] [pulsar] AnonHxy commented on pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
AnonHxy commented on PR #17084: URL: https://github.com/apache/pulsar/pull/17084#issuecomment-1217532087 LGTM with minor comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
AnonHxy commented on code in PR #17084: URL: https://github.com/apache/pulsar/pull/17084#discussion_r947512126 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java: ## @@ -2153,4 +2167,139 @@ public void testHandleAuthResponseWithoutClientVersion()

[GitHub] [pulsar] nodece commented on pull request #17077: [Improve][Standalone] Standalone Add param of --metadata-url for runing with metadata

2022-08-16 Thread GitBox
nodece commented on PR #17077: URL: https://github.com/apache/pulsar/pull/17077#issuecomment-1217518887 I think @liangyuanpeng wants to use other metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] HQebupt commented on a diff in pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
HQebupt commented on code in PR #17084: URL: https://github.com/apache/pulsar/pull/17084#discussion_r947491894 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java: ## @@ -2153,4 +2167,157 @@ public void testHandleAuthResponseWithoutClientVersion()

[GitHub] [pulsar] polyzos opened a new issue, #17133: [Doc] Fix the RabbitMQ connector docs

2022-08-16 Thread GitBox
polyzos opened a new issue, #17133: URL: https://github.com/apache/pulsar/issues/17133 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? inaccurate

[GitHub] [pulsar] HQebupt commented on pull request #16756: [fix][broker]optimize the shutdown sequence of broker service when it close

2022-08-16 Thread GitBox
HQebupt commented on PR #16756: URL: https://github.com/apache/pulsar/pull/16756#issuecomment-1217501280 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#5354153)

2022-08-16 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 7d24def29fb Docs sync done from apache/pulsar(#

[GitHub] [pulsar] zbentley commented on a diff in pull request #16535: [fix] [python client] Better Python garbage collection management for C++-owned objects

2022-08-16 Thread GitBox
zbentley commented on code in PR #16535: URL: https://github.com/apache/pulsar/pull/16535#discussion_r947479658 ## pulsar-client-cpp/lib/checksum/crc32c_arm.h: ## @@ -37,11 +37,11 @@ #define crc32c_u16(crc, v) __crc32ch(crc, v) #define crc32c_u32(crc, v) __crc32cw(crc, v) #de

[GitHub] [pulsar] aloyszhang commented on pull request #17122: [proxy] remove useless code

2022-08-16 Thread GitBox
aloyszhang commented on PR #17122: URL: https://github.com/apache/pulsar/pull/17122#issuecomment-1217493569 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
AnonHxy commented on code in PR #17084: URL: https://github.com/apache/pulsar/pull/17084#discussion_r947461907 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java: ## @@ -2153,4 +2167,157 @@ public void testHandleAuthResponseWithoutClientVersion()

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
AnonHxy commented on code in PR #17084: URL: https://github.com/apache/pulsar/pull/17084#discussion_r947463138 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java: ## @@ -2153,4 +2167,157 @@ public void testHandleAuthResponseWithoutClientVersion()

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17125: [improve][client c++] Support KeyValue Schema.

2022-08-16 Thread GitBox
BewareMyPower commented on code in PR #17125: URL: https://github.com/apache/pulsar/pull/17125#discussion_r947437276 ## pulsar-client-cpp/tests/MessageTest.cc: ## @@ -99,3 +99,24 @@ TEST(MessageTest, testMessageBuilder) { ASSERT_EQ(msg.getData(), originalAddress);

[GitHub] [pulsar] codelipenghui opened a new issue, #17132: [test] Integration test coverage

2022-08-16 Thread GitBox
codelipenghui opened a new issue, #17132: URL: https://github.com/apache/pulsar/issues/17132 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation Improve integration test coverage

[GitHub] [pulsar] codelipenghui commented on issue #16578: Flaky-test: PulsarSinkE2ETest.testPulsarSinkDLQ

2022-08-16 Thread GitBox
codelipenghui commented on issue #16578: URL: https://github.com/apache/pulsar/issues/16578#issuecomment-1217432017 Another one https://github.com/apache/pulsar/runs/7870706984?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar] codelipenghui opened a new issue, #17131: Flaky-test: TopicTerminationTest.testTerminateWhilePublishing

2022-08-16 Thread GitBox
codelipenghui opened a new issue, #17131: URL: https://github.com/apache/pulsar/issues/17131 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pu

[GitHub] [pulsar] momo-jun opened a new pull request, #17130: [fix][doc] Sync recent changes on versioned docs

2022-08-16 Thread GitBox
momo-jun opened a new pull request, #17130: URL: https://github.com/apache/pulsar/pull/17130 ### Modifications * Sync recent doc changes to 2.8.x/2.9.x/2.10.x docs during the switchover time window of https://github.com/apache/pulsar/pull/17074. * #17030 * #17039 * #

[GitHub] [pulsar] nodece opened a new pull request, #17129: [improve][docker] Switch to Temurin JDK

2022-08-16 Thread GitBox
nodece opened a new pull request, #17129: URL: https://github.com/apache/pulsar/pull/17129 Signed-off-by: Zixuan Liu ### Motivation I noticed we are using OpenJDK in our Docker image, I suggest that we switch to the Temurin JDK, because our CI runs on the Temurin JDK, we need

[GitHub] [pulsar] HQebupt commented on pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
HQebupt commented on PR #17084: URL: https://github.com/apache/pulsar/pull/17084#issuecomment-1217410565 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] RobertIndie opened a new pull request, #17128: [feature][python] PIP 37: Add chunking support for python client

2022-08-16 Thread GitBox
RobertIndie opened a new pull request, #17128: URL: https://github.com/apache/pulsar/pull/17128 ### Motivation This is the python client feature catch up for [PIP 37](https://github.com/apache/pulsar/wiki/PIP-37%3A-Large-message-size-handling-in-Pulsar) ### Modification

[GitHub] [pulsar] HQebupt commented on pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
HQebupt commented on PR #17084: URL: https://github.com/apache/pulsar/pull/17084#issuecomment-1217397460 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] SignorMercurio commented on pull request #15775: [fix][Admin CLI docs] Sync the description and default value of `--processing-guarantees`

2022-08-16 Thread GitBox
SignorMercurio commented on PR #15775: URL: https://github.com/apache/pulsar/pull/15775#issuecomment-1217397167 @momo-jun Of course yes. Note that there's a leading whitespace in `" #Java, Python, Go"`. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] HQebupt commented on pull request #16756: [fix][broker]optimize the shutdown sequence of broker service when it close

2022-08-16 Thread GitBox
HQebupt commented on PR #16756: URL: https://github.com/apache/pulsar/pull/16756#issuecomment-1217395702 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] momo-jun commented on pull request #15775: [fix][Admin CLI docs] Sync the description and default value of `--processing-guarantees`

2022-08-16 Thread GitBox
momo-jun commented on PR #15775: URL: https://github.com/apache/pulsar/pull/15775#issuecomment-1217395786 @SignorMercurio - just a double-check to resolve the conflict. Can I keep my changes and append the line298 `+ " #Java, Python, Go"` you added in #16853? https://user-images.githubuse

[GitHub] [pulsar] tjiuming commented on a diff in pull request #17041: [monitoring][broker][metadata] add metadata store metrics

2022-08-16 Thread GitBox
tjiuming commented on code in PR #17041: URL: https://github.com/apache/pulsar/pull/17041#discussion_r947395766 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/stats/MetadataStoreStats.java: ## @@ -24,41 +24,42 @@ public final class MetadataStoreStats impleme

[GitHub] [pulsar] tisonkun commented on issue #16613: [improve][client] Optimize Third-Party Client Matrix Page

2022-08-16 Thread GitBox
tisonkun commented on issue #16613: URL: https://github.com/apache/pulsar/issues/16613#issuecomment-1217387683 This issue can be closed by https://github.com/apache/pulsar/pull/17010. For further improvement, I notice that @momo-jun create a draft proposal #17098 which can supersede t

[GitHub] [pulsar] github-actions[bot] commented on issue #16416: The pulsar-admin doesn't set SNI properly when `tlsEnableHostnameVerification` is `false`

2022-08-16 Thread GitBox
github-actions[bot] commented on issue #16416: URL: https://github.com/apache/pulsar/issues/16416#issuecomment-1217383026 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #16613: [improve][client] Optimize Third-Party Client Matrix Page

2022-08-16 Thread GitBox
github-actions[bot] commented on issue #16613: URL: https://github.com/apache/pulsar/issues/16613#issuecomment-1217382798 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on pull request #16623: rename pulsar env variables for pulsar tools

2022-08-16 Thread GitBox
github-actions[bot] commented on PR #16623: URL: https://github.com/apache/pulsar/pull/16623#issuecomment-1217382756 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar] github-actions[bot] commented on issue #16631: create function with restful API,which has the error "415 Unsupported Media Type"

2022-08-16 Thread GitBox
github-actions[bot] commented on issue #16631: URL: https://github.com/apache/pulsar/issues/16631#issuecomment-1217382716 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] poorbarcode commented on pull request #17116: [fix][flaky-test]ConsumedLedgersTrimTest

2022-08-16 Thread GitBox
poorbarcode commented on PR #17116: URL: https://github.com/apache/pulsar/pull/17116#issuecomment-1217382100 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[pulsar] 02/03: [fix][broker] Fix calculate avg message per entry (#17046)

2022-08-16 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 72810a08cce89c07b61d134a287d2a32b31ff7ad Author: Cong Zhao AuthorDate: Wed Aug 17 09:02:35 2022 +0800 [fix]

[pulsar] 03/03: [imp][managed-ledger] Optimize filterReadEntries usage of Entry interface ledger (#17108)

2022-08-16 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5fbc911ae380c6126e4d0150357d58315c09c20e Author: Michael Marshall AuthorDate: Tue Aug 16 13:47:00 2022 -0500

[pulsar] branch branch-2.11 updated (28f53b0214c -> 5fbc911ae38)

2022-08-16 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 28f53b0214c fix: bundle-data metadata leak because of bundlestats was not clean (#17095) new 7b871fd6a3c

[pulsar] 01/03: [fix][flaky-test]LedgerOffloaderMetricsTest (#17106)

2022-08-16 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 7b871fd6a3c3c32ccdbefbb01b160eb645ce0919 Author: fengyubiao AuthorDate: Wed Aug 17 09:47:34 2022 +0800 [fix

[GitHub] [pulsar] HQebupt commented on pull request #16756: [fix][broker]optimize the shutdown sequence of broker service when it close

2022-08-16 Thread GitBox
HQebupt commented on PR #16756: URL: https://github.com/apache/pulsar/pull/16756#issuecomment-1217374906 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] HQebupt commented on pull request #17084: [improve][broker]add ServerCnx state check before server handle request

2022-08-16 Thread GitBox
HQebupt commented on PR #17084: URL: https://github.com/apache/pulsar/pull/17084#issuecomment-1217374291 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] Technoboy- opened a new issue, #17127: Flaky-test: ClientCnxRequestTimeoutQueueTest. setupClientCnx

2022-08-16 Thread GitBox
Technoboy- opened a new issue, #17127: URL: https://github.com/apache/pulsar/issues/17127 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsa

[GitHub] [pulsar] Technoboy- opened a new issue, #17126: Flaky-test: RGUsageMTAggrWaitForAllMsgsTest.testMTProduceConsumeRGUsageNonPersistentTopicNamesSameTenant

2022-08-16 Thread GitBox
Technoboy- opened a new issue, #17126: URL: https://github.com/apache/pulsar/issues/17126 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsa

[GitHub] [pulsar] poorbarcode commented on pull request #17116: [fix][flaky-test]ConsumedLedgersTrimTest

2022-08-16 Thread GitBox
poorbarcode commented on PR #17116: URL: https://github.com/apache/pulsar/pull/17116#issuecomment-1217367836 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[pulsar] branch master updated: [fix][flaky-test]LedgerOffloaderMetricsTest (#17106)

2022-08-16 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 535415302ef [fix][flaky-test]LedgerOffloaderMet

[GitHub] [pulsar] codelipenghui closed issue #16858: Flaky-test: LedgerOffloaderMetricsTest.cleanup

2022-08-16 Thread GitBox
codelipenghui closed issue #16858: Flaky-test: LedgerOffloaderMetricsTest.cleanup URL: https://github.com/apache/pulsar/issues/16858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pulsar] codelipenghui merged pull request #17106: [fix][flaky-test]LedgerOffloaderMetricsTest

2022-08-16 Thread GitBox
codelipenghui merged PR #17106: URL: https://github.com/apache/pulsar/pull/17106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] tisonkun commented on a diff in pull request #16993: [cleanup][broker] Add Maven Modernizer plugin in pulsar-broker and fix violation in `test: broker/admin`

2022-08-16 Thread GitBox
tisonkun commented on code in PR #16993: URL: https://github.com/apache/pulsar/pull/16993#discussion_r947376228 ## pulsar-broker/pom.xml: ## @@ -425,6 +425,25 @@ + +org.gaul +modernizer-maven-plugin + + false Review Comment:

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16843: [improve][doc] Add more concepts/tasks for bookie isolation

2022-08-16 Thread GitBox
momo-jun commented on code in PR #16843: URL: https://github.com/apache/pulsar/pull/16843#discussion_r947375066 ## site2/docs/administration-isolation-bookie.md: ## @@ -10,24 +10,230 @@ import TabItem from '@theme/TabItem'; -A namespace can be isolated into user-define

[GitHub] [pulsar] momo-jun commented on a diff in pull request #16843: [improve][doc] Add more concepts/tasks for bookie isolation

2022-08-16 Thread GitBox
momo-jun commented on code in PR #16843: URL: https://github.com/apache/pulsar/pull/16843#discussion_r947374994 ## site2/docs/administration-isolation-bookie.md: ## @@ -10,24 +10,230 @@ import TabItem from '@theme/TabItem'; -A namespace can be isolated into user-define

[GitHub] [pulsar] codelipenghui commented on pull request #17049: [fix][broker] Fix schema does not replicate successfully

2022-08-16 Thread GitBox
codelipenghui commented on PR #17049: URL: https://github.com/apache/pulsar/pull/17049#issuecomment-1217358836 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] shibd opened a new pull request, #17125: [improve][client c++] Support KeyValue Schema.

2022-08-16 Thread GitBox
shibd opened a new pull request, #17125: URL: https://github.com/apache/pulsar/pull/17125 ### Motivation C++ client Support KeyValue Schema. ### Modifications - A new constructor is added in `SchemaInfo` to combine key and value schemas. - Add a new `KeyValue` class,

[GitHub] [pulsar] MarvinCai commented on a diff in pull request #16993: [cleanup][broker] Add Maven Modernizer plugin in pulsar-broker and fix violation in `test: broker/admin`

2022-08-16 Thread GitBox
MarvinCai commented on code in PR #16993: URL: https://github.com/apache/pulsar/pull/16993#discussion_r947368626 ## pulsar-broker/pom.xml: ## @@ -425,6 +425,25 @@ + +org.gaul +modernizer-maven-plugin + + false Review Comment:

[GitHub] [pulsar] poorbarcode commented on pull request #17116: [fix][flaky-test]ConsumedLedgersTrimTest

2022-08-16 Thread GitBox
poorbarcode commented on PR #17116: URL: https://github.com/apache/pulsar/pull/17116#issuecomment-1217347494 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] poorbarcode commented on pull request #17059: [test][broker]auto relealse connection when use proxy

2022-08-16 Thread GitBox
poorbarcode commented on PR #17059: URL: https://github.com/apache/pulsar/pull/17059#issuecomment-1217347387 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] poorbarcode commented on pull request #17106: [fix][flaky-test]LedgerOffloaderMetricsTest

2022-08-16 Thread GitBox
poorbarcode commented on PR #17106: URL: https://github.com/apache/pulsar/pull/17106#issuecomment-1217347118 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[pulsar] branch master updated: [fix][broker] Fix calculate avg message per entry (#17046)

2022-08-16 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2c2b75edf3c [fix][broker] Fix calculate avg mes

[GitHub] [pulsar] codelipenghui merged pull request #17046: [fix][broker] Fix calculate avg message per entry

2022-08-16 Thread GitBox
codelipenghui merged PR #17046: URL: https://github.com/apache/pulsar/pull/17046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16843: [improve][doc] Add more concepts/tasks for bookie isolation

2022-08-16 Thread GitBox
Anonymitaet commented on code in PR #16843: URL: https://github.com/apache/pulsar/pull/16843#discussion_r947344330 ## site2/docs/administration-isolation-bookie.md: ## @@ -10,24 +10,230 @@ import TabItem from '@theme/TabItem'; -A namespace can be isolated into user-def

[pulsar-site] branch main updated (aa9e358ce1a -> 1207da6f281)

2022-08-16 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from aa9e358ce1a Docs sync done from apache/pulsar(#7ec1d54) new 6d12b818e12 fix: remove exec command in pulsar-con

[GitHub] [pulsar] leizhiyuan commented on issue #17115: [Bug] the retention policies of health topic

2022-08-16 Thread GitBox
leizhiyuan commented on issue #17115: URL: https://github.com/apache/pulsar/issues/17115#issuecomment-1217304112 see https://lists.apache.org/thread/c4b262w1o5g0l34dxtb3pqvt17w8tg8q -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] leizhiyuan closed issue #17087: [Bug] when delete namespace bundle-data in metastore was not deleted

2022-08-16 Thread GitBox
leizhiyuan closed issue #17087: [Bug] when delete namespace bundle-data in metastore was not deleted URL: https://github.com/apache/pulsar/issues/17087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#7ec1d54)

2022-08-16 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new aa9e358ce1a Docs sync done from apache/pulsar(#

[GitHub] [pulsar-client-go] tisonkun commented on pull request #802: [oauth2] Remove oauth2 go.mod and go.sum

2022-08-16 Thread GitBox
tisonkun commented on PR #802: URL: https://github.com/apache/pulsar-client-go/pull/802#issuecomment-1217262908 @pgier I read your comment now. And it seems my statement above holds: > As long as the whole codebase is small and it isn't polluted in the linking stage, it's fine. --

[GitHub] [pulsar] eolivelli commented on pull request #17118: [fix][functions] Make mandatory to provide a schema in Context::newOutputRecordBuilder

2022-08-16 Thread GitBox
eolivelli commented on PR #17118: URL: https://github.com/apache/pulsar/pull/17118#issuecomment-1217162313 /pulsar-bot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[pulsar] branch master updated: [imp][managed-ledger] Optimize filterReadEntries usage of Entry interface ledger (#17108)

2022-08-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7ec1d543280 [imp][managed-ledger] Optimize filte

[GitHub] [pulsar] merlimat merged pull request #17108: [imp][managed-ledger] Optimize getting ledger and entry id from entry

2022-08-16 Thread GitBox
merlimat merged PR #17108: URL: https://github.com/apache/pulsar/pull/17108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#4d7b1ac)

2022-08-16 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 2cc1a0238b3 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] michaeljmarshall commented on issue #15985: Add getLastMessageId feature to Python Client

2022-08-16 Thread GitBox
michaeljmarshall commented on issue #15985: URL: https://github.com/apache/pulsar/issues/15985#issuecomment-1216946011 Fixed in https://github.com/apache/pulsar/pull/16182 and https://github.com/apache/pulsar/pull/16255 -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] michaeljmarshall closed issue #15985: Add getLastMessageId feature to Python Client

2022-08-16 Thread GitBox
michaeljmarshall closed issue #15985: Add getLastMessageId feature to Python Client URL: https://github.com/apache/pulsar/issues/15985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [pulsar] lhotari commented on issue #11351: Fix precise publish rate limiting

2022-08-16 Thread GitBox
lhotari commented on issue #11351: URL: https://github.com/apache/pulsar/issues/11351#issuecomment-1216914500 This issue was fixed by #11446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] lhotari closed issue #11351: Fix precise publish rate limiting

2022-08-16 Thread GitBox
lhotari closed issue #11351: Fix precise publish rate limiting URL: https://github.com/apache/pulsar/issues/11351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [pulsar] marksilcox commented on pull request #15558: [fix][broker][functions-worker] Ensure prometheus metrics are grouped by type (#8407, #13865)

2022-08-16 Thread GitBox
marksilcox commented on PR #15558: URL: https://github.com/apache/pulsar/pull/15558#issuecomment-1216874652 @asafm Not sure I will have the bandwidth to look at `FunctionsStatsGenerator` anytime soon -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar] horizonzy commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
horizonzy commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r947003851 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/deletion/LedgerDeletionService.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pulsar] horizonzy commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
horizonzy commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r947003565 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -1079,6 +1080,34 @@ public void deleteTopic( }); }

[GitHub] [pulsar] codelipenghui commented on pull request #17049: [fix][broker] Fix schema does not replicate successfully

2022-08-16 Thread GitBox
codelipenghui commented on PR #17049: URL: https://github.com/apache/pulsar/pull/17049#issuecomment-1216870713 There should be another issue related to this part https://github.com/apache/pulsar/blob/9f40cc1d1104900c450a599676ca446b1f096a00/pulsar-broker/src/main/java/org/apache/pulsa

[GitHub] [pulsar] horizonzy commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
horizonzy commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r94760 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -2570,70 +2651,107 @@ void internalTrimLedgers(boolean isTruncate, C

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17049: [fix][broker] Fix schema does not replicate successfully

2022-08-16 Thread GitBox
codelipenghui commented on code in PR #17049: URL: https://github.com/apache/pulsar/pull/17049#discussion_r946998918 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java: ## @@ -1412,22 +1424,16 @@ public void testReplicatorWithFailedAck() throws

[GitHub] [pulsar] heesung-sn commented on pull request #16832: [feature][broker] Support cgroup v2 by using `jdk.internal.platform.Metrics` in Pulsar Loadbalancer

2022-08-16 Thread GitBox
heesung-sn commented on PR #16832: URL: https://github.com/apache/pulsar/pull/16832#issuecomment-1216854483 > @heesung-sn What do you think? According to this article, https://developers.redhat.com/articles/2022/04/19/java-17-whats-new-openjdks-container-awareness#rece

[GitHub] [pulsar] nodece opened a new pull request, #17124: [improve][test] Verify original auth data on proxy

2022-08-16 Thread GitBox
nodece opened a new pull request, #17124: URL: https://github.com/apache/pulsar/pull/17124 Signed-off-by: Zixuan Liu ### Motivation Add a test to verify the original auth data on the proxy. ### Documentation Check the box below or label this PR directly. Ne

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #17123: [fix][broker] Pass subscriptionName to auth service

2022-08-16 Thread GitBox
michaeljmarshall opened a new pull request, #17123: URL: https://github.com/apache/pulsar/pull/17123 ### Motivation Pass subscription name to the auth service. ### Modifications * Update several methods that need to pass subscription name. ### Verifying this change

[GitHub] [pulsar] eolivelli commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
eolivelli commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r946919802 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -1079,6 +1080,34 @@ public void deleteTopic( }); }

[GitHub] [pulsar] codelipenghui commented on issue #16770: Flaky-test: PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest.testRelativeMessageRateLimitingThrottling

2022-08-16 Thread GitBox
codelipenghui commented on issue #16770: URL: https://github.com/apache/pulsar/issues/16770#issuecomment-1216788418 Another one: https://github.com/apache/pulsar/runs/7859284770?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-go] severinson opened a new pull request, #829: Enable seeking individual topic partitions

2022-08-16 Thread GitBox
severinson opened a new pull request, #829: URL: https://github.com/apache/pulsar-client-go/pull/829 Currently, seeking on a consumer with a KeyShared subscription fails. This PR removes an unnecessary check to seek the underlying partitionConsumer responsible for the topic. -- This is a

[GitHub] [pulsar] eolivelli commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
eolivelli commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r946912131 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/deletion/LedgerDeletionService.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pulsar] aloyszhang opened a new pull request, #17122: [proxy] remove useless code

2022-08-16 Thread GitBox
aloyszhang opened a new pull request, #17122: URL: https://github.com/apache/pulsar/pull/17122 ### Motivation Minor update for proxy `metadataStoreUrl` configuration ### Modifications remove useless code ### Documentation - [ ] `doc-not-needed` (

[GitHub] [pulsar] alpreu opened a new issue, #17121: [Bug][pulsar-client-admin-api] Topics.getInternalInfo() throws 500 instead of 404 if topic does not exist

2022-08-16 Thread GitBox
alpreu opened a new issue, #17121: URL: https://github.com/apache/pulsar/issues/17121 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version macOS, master branch, commit bc68f02a

[GitHub] [pulsar] HQebupt commented on pull request #16756: [fix][broker]optimize the shutdown sequence of broker service when it close

2022-08-16 Thread GitBox
HQebupt commented on PR #16756: URL: https://github.com/apache/pulsar/pull/16756#issuecomment-1216761089 > > > If the EventLoop is closed first, the client reconnection will fail. > > > > > > The reconnection won't retry to other brokers? @Technoboy- > > Bundle is not unload

[GitHub] [pulsar] HQebupt commented on a diff in pull request #16756: [fix][broker]optimize the shutdown sequence of broker service when it close

2022-08-16 Thread GitBox
HQebupt commented on code in PR #16756: URL: https://github.com/apache/pulsar/pull/16756#discussion_r946890686 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -731,6 +731,13 @@ public CompletableFuture closeAndRemoveReplicationClient(St

[pulsar] branch branch-2.10 updated: [improve][proxy] Consolidate Netty channel flushes to mitigate syscall overhead (#16372)

2022-08-16 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new ba15416c126 [improve][proxy] Consol

[GitHub] [pulsar] github-actions[bot] commented on pull request #17118: [fix][functions] Make mandatory to provide a schema in Context::newOutputRecordBuilder

2022-08-16 Thread GitBox
github-actions[bot] commented on PR #17118: URL: https://github.com/apache/pulsar/pull/17118#issuecomment-1216687198 @cbornet Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-

[GitHub] [pulsar] poorbarcode commented on issue #17111: Flaky-test: AdminApi2Test.testDeleteNamespace

2022-08-16 Thread GitBox
poorbarcode commented on issue #17111: URL: https://github.com/apache/pulsar/issues/17111#issuecomment-1216678124 assign to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pulsar] coderzc commented on a diff in pull request #17092: [improve][broker]: DelayedDeliveryTracker init and addMessage

2022-08-16 Thread GitBox
coderzc commented on code in PR #17092: URL: https://github.com/apache/pulsar/pull/17092#discussion_r946806761 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java: ## @@ -99,7 +100,7 @@ private long getCutoffTime() { }

[GitHub] [pulsar] codelipenghui opened a new issue, #17120: Flaky-test: ResourceGroupUsageAggregationTest.testProduceConsumeUsageOnRG

2022-08-16 Thread GitBox
codelipenghui opened a new issue, #17120: URL: https://github.com/apache/pulsar/issues/17120 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pu

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15955: PIP-174: New managed ledger entry cache implementation

2022-08-16 Thread GitBox
Technoboy- commented on code in PR #15955: URL: https://github.com/apache/pulsar/pull/15955#discussion_r946799085 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/SharedCacheSegmentBufferCopy.java: ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Softw

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15955: PIP-174: New managed ledger entry cache implementation

2022-08-16 Thread GitBox
Technoboy- commented on code in PR #15955: URL: https://github.com/apache/pulsar/pull/15955#discussion_r946798736 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/SharedCacheSegmentBufferRefCount.java: ## @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache S

[GitHub] [pulsar] codelipenghui commented on issue #16516: Flaky-test: BrokerInterceptorTest.testProducerCreation

2022-08-16 Thread GitBox
codelipenghui commented on issue #16516: URL: https://github.com/apache/pulsar/issues/16516#issuecomment-1216656084 Another one: https://github.com/apache/pulsar/runs/7850960846?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Anonymitaet opened a new issue, #17119: [Doc] add explanations of "topics can be compacted on topic level automatically"

2022-08-16 Thread GitBox
Anonymitaet opened a new issue, #17119: URL: https://github.com/apache/pulsar/issues/17119 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? Alexand

[GitHub] [pulsar] codelipenghui commented on issue #15764: Flaky-test: ConnectionTimeoutTest.testLowTimeout

2022-08-16 Thread GitBox
codelipenghui commented on issue #15764: URL: https://github.com/apache/pulsar/issues/15764#issuecomment-1216651802 The issue doesn't fix yet, https://github.com/apache/pulsar/runs/7856446588?check_suite_focus=true ``` Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Tim

[GitHub] [pulsar] michaeljmarshall opened a new issue, #15764: Flaky-test: ConnectionTimeoutTest.testLowTimeout

2022-08-16 Thread GitBox
michaeljmarshall opened a new issue, #15764: URL: https://github.com/apache/pulsar/issues/15764 ConnectionTimeoutTest.testLowTimeout is flaky. It fails sporadically. https://github.com/apache/pulsar/runs/6582172714 ``` Error: testLowTimeout(org.apache.pulsar.client.impl.C

[GitHub] [pulsar] codelipenghui commented on issue #16516: Flaky-test: BrokerInterceptorTest.testProducerCreation

2022-08-16 Thread GitBox
codelipenghui commented on issue #16516: URL: https://github.com/apache/pulsar/issues/16516#issuecomment-1216649215 #16742 doesn't fix the issue yet, https://github.com/apache/pulsar/runs/7856446693?check_suite_focus=true ``` Error: Tests run: 18, Failures: 3, Errors: 0, Skipped

[GitHub] [pulsar] codelipenghui opened a new issue, #16516: Flaky-test: BrokerInterceptorTest.testProducerCreation

2022-08-16 Thread GitBox
codelipenghui opened a new issue, #16516: URL: https://github.com/apache/pulsar/issues/16516 [example failure](https://github.com/apache/pulsar/runs/7274700601?check_suite_focus=true) ``` Error: Tests run: 18, Failures: 3, Errors: 0, Skipped: 9, Time elapsed: 128.822 s <<< FAILUR

[GitHub] [pulsar] codelipenghui commented on issue #16795: Flaky-test: SimpleProducerConsumerTest.testSharedSamePriorityConsumer

2022-08-16 Thread GitBox
codelipenghui commented on issue #16795: URL: https://github.com/apache/pulsar/issues/16795#issuecomment-1216645459 Another one: https://github.com/apache/pulsar/runs/7856447331?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] cbornet opened a new pull request, #17118: [fix][functions] Make mandatory to provide a schema in Context::newOutputRecordBuilder

2022-08-16 Thread GitBox
cbornet opened a new pull request, #17118: URL: https://github.com/apache/pulsar/pull/17118 Fixes #17114 ### Modifications Change `newOutputRecordBuilder` to `newOutputRecordBuilder(Schema schema)` ### Verifying this change - [ ] Make sure that the change passes th

  1   2   >