BewareMyPower commented on PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#issuecomment-1221246386
Just a suggestion. You can ran the unit tests locally before pushing more
commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
shibd commented on PR #17125:
URL: https://github.com/apache/pulsar/pull/17125#issuecomment-1221244223
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch asf-site-next
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/asf-site-next by this push:
new c70fff0d3bf Updated site at r
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 981df9f14f8 Docs sync done from apache/pulsar(#
shibd commented on PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#issuecomment-1221230639
@BewareMyPower Thank you very much for your meticulous review, all the
suggestions have been fixed, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #16452:
URL: https://github.com/apache/pulsar/pull/16452#issuecomment-1221209479
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
github-actions[bot] commented on issue #16708:
URL: https://github.com/apache/pulsar/issues/16708#issuecomment-1221209419
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] commented on issue #16695:
URL: https://github.com/apache/pulsar/issues/16695#issuecomment-1221209423
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] commented on issue #16709:
URL: https://github.com/apache/pulsar/issues/16709#issuecomment-1221209410
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
youzipi commented on PR #17172:
URL: https://github.com/apache/pulsar/pull/17172#issuecomment-1221208962
@tisonkun @MarvinCai @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mattisonchao commented on code in PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#discussion_r950629777
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStreamingDispatcherMultipleConsumers.java:
##
@@ -155,6 +155,11 @@ protected v
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch asf-site-next
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/asf-site-next by this push:
new a1bd0cb3b48 Updated site at r
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new f5f5e021461 Docs sync done from apache/pulsar(#
coderzc commented on code in PR #17092:
URL: https://github.com/apache/pulsar/pull/17092#discussion_r950585748
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##
@@ -99,7 +100,7 @@ private long getCutoffTime() {
}
eolivelli commented on code in PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#discussion_r950563314
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStreamingDispatcherMultipleConsumers.java:
##
@@ -155,6 +155,11 @@ protected void
yangou opened a new issue, #17190:
URL: https://github.com/apache/pulsar/issues/17190
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Version
2.7
### Minimal reproduce step
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1d6824cdbed [chore][test] Check LineLength only
merlimat merged PR #17168:
URL: https://github.com/apache/pulsar/pull/17168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.a
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch asf-site-next
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/asf-site-next by this push:
new 18a564ecb25 Updated site at r
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new d9ecbbb233c Docs sync done from apache/pulsar(#
eolivelli opened a new pull request, #17189:
URL: https://github.com/apache/pulsar/pull/17189
### Motivation
Pulsar-perf does not add eventTime on messages.
It would help to add the eventTime when you have a consumer application that
uses that field.
### Modifications
gaozhangmin commented on PR #17180:
URL: https://github.com/apache/pulsar/pull/17180#issuecomment-1220856640
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
gaozhangmin commented on PR #17170:
URL: https://github.com/apache/pulsar/pull/17170#issuecomment-1220856489
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
AnonHxy commented on PR #16605:
URL: https://github.com/apache/pulsar/pull/16605#issuecomment-1220846562
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tisonkun commented on PR #17168:
URL: https://github.com/apache/pulsar/pull/17168#issuecomment-1220820821
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
shibd opened a new issue, #17188:
URL: https://github.com/apache/pulsar/issues/17188
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Motivation
[PIP 132 Include message header size when
BewareMyPower commented on issue #17097:
URL: https://github.com/apache/pulsar/issues/17097#issuecomment-1220811980
Could you generate the core file (assuming the name is `core`) and just run
`gdb python core`?
In addition, could you share your Python script with the correct indent so
tisonkun commented on PR #17148:
URL: https://github.com/apache/pulsar/pull/17148#issuecomment-1220807436
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mattisonchao commented on PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#issuecomment-1220772938
I think we may check the relative logic, to avoid another problem. Because I
think this kind of logic is **very** important.
--
This is an automated message from the Apache Git Se
nicoloboschi commented on PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#issuecomment-1220769937
@mattisonchao nice catch!! you're right, that is the missing check
That also explains why only the streaming test fails.
Thanks, I've updated the pull with your suggestion
tisonkun commented on PR #17168:
URL: https://github.com/apache/pulsar/pull/17168#issuecomment-1220752853
cc @eolivelli @codelipenghui @RobertIndie I hope this patch is ready for
merge now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mattisonchao commented on PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#issuecomment-1220745626
Hi, @nicoloboschi
>3.a In the next read cycle (readMoreEntries) the replay read is triggered
asynchronously.
3.b At the same time a consumer is ready to receive a new message
youzipi commented on PR #17172:
URL: https://github.com/apache/pulsar/pull/17172#issuecomment-1220697696
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
zhangmingao pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.11 by this push:
new 8764e374829 [Branch-2.11][test] C
gaozhangmin merged PR #17187:
URL: https://github.com/apache/pulsar/pull/17187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsa
gaozhangmin opened a new pull request, #17187:
URL: https://github.com/apache/pulsar/pull/17187
### Motivation
Cherry-pick #17177 to branch-2.11
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc
This is an automated email from the ASF dual-hosted git repository.
zhangmingao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new fed6279343a [fix][test] Fix build error (#1
gaozhangmin merged PR #17177:
URL: https://github.com/apache/pulsar/pull/17177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsa
gaozhangmin commented on PR #17177:
URL: https://github.com/apache/pulsar/pull/17177#issuecomment-1220603828
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 8564060aa13 Docs sync done from apache/pulsar(#
Demogorgon314 opened a new issue, #17186:
URL: https://github.com/apache/pulsar/issues/17186
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Motivation
There are some cases in which it
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950085106
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -160,7 +183,7 @@ void
MultiTopicsConsumerImpl::subscribeTopicPartitions(const Result result,
nicoloboschi opened a new pull request, #17185:
URL: https://github.com/apache/pulsar/pull/17185
Fixes #17179
### Motivation
`user.home` property is not set in all the environments.
### Modifications
* If user.home is empty or equals to "?" now we use the current dir
shibd opened a new issue, #17184:
URL: https://github.com/apache/pulsar/issues/17184
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Motivation
Batch index acknowledgment can improve in
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950068520
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -363,13 +401,12 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback
callback) {
auto sel
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950064781
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -125,33 +144,37 @@ Future
MultiTopicsConsumerImpl::subscribeOneTopicAsync(const s
}
// sub
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950061016
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -125,33 +144,37 @@ Future
MultiTopicsConsumerImpl::subscribeOneTopicAsync(const s
}
// sub
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950054182
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -712,3 +746,79 @@ uint64_t
MultiTopicsConsumerImpl::getNumberOfConnectedConsumer() {
});
ret
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950051258
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -712,3 +746,79 @@ uint64_t
MultiTopicsConsumerImpl::getNumberOfConnectedConsumer() {
});
ret
BewareMyPower commented on code in PR #16969:
URL: https://github.com/apache/pulsar/pull/16969#discussion_r950047034
##
pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc:
##
@@ -52,6 +53,24 @@
MultiTopicsConsumerImpl::MultiTopicsConsumerImpl(ClientImplPtr client, const std
JavaXiaoJun closed issue #16103: Issue of pulsar client under multi-topic
consumption : org.apache.pulsar.client.api.PulsarClientException$LookupException
URL: https://github.com/apache/pulsar/issues/16103
--
This is an automated message from the Apache Git Service.
To respond to the message,
BewareMyPower commented on code in PR #16943:
URL: https://github.com/apache/pulsar/pull/16943#discussion_r950028292
##
pulsar-client-cpp/tests/ConsumerTest.cc:
##
@@ -763,4 +763,36 @@ TEST(ConsumerTest, testPartitionsWithCloseUnblock) {
thread.join();
}
+TEST(ConsumerTe
shibd opened a new issue, #17183:
URL: https://github.com/apache/pulsar/issues/17183
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Motivation
[PIP 130: Apply redelivery backoff policy
nicoloboschi commented on PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#issuecomment-1220465436
Thanks for the reviews @codelipenghui and @mattisonchao.
I did additional testing and I still think this solution is correct.
Basically the case I'm seeing is the following:
BewareMyPower commented on code in PR #16943:
URL: https://github.com/apache/pulsar/pull/16943#discussion_r950002769
##
pulsar-client-cpp/lib/ConsumerImpl.cc:
##
@@ -1326,8 +1336,26 @@ void
ConsumerImpl::getLastMessageIdAsync(BrokerGetLastMessageIdCallback callback
codelipenghui commented on issue #17120:
URL: https://github.com/apache/pulsar/issues/17120#issuecomment-1220442325
@YczYanchengzhe it's the flaky test, not able to reproduce stability. From
the CI, you can get detailed logs.
--
This is an automated message from the Apache Git Service.
To
codelipenghui commented on PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#issuecomment-1220436886
Thanks @mattisonchao
I think we should point out the race condition or revert
`dispatcherDispatchMessagesInSubscriptionThread` in the 2.11.0 release. It will
be a potential
yapxue opened a new pull request, #17182:
URL: https://github.com/apache/pulsar/pull/17182
### Motivation
*consumer client has method pause(), but consumer is not really paused.
paused consumer only stop send flow permit request to broker but broker still
can push
tisonkun commented on issue #12944:
URL: https://github.com/apache/pulsar/issues/12944#issuecomment-1220428355
It seems all the issues are included in
https://github.com/apache/pulsar/issues/12944#issuecomment-1103444708. I'll try
it out.
--
This is an automated message from the Apache G
codelipenghui merged PR #17176:
URL: https://github.com/apache/pulsar/pull/17176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pul
codelipenghui merged PR #17157:
URL: https://github.com/apache/pulsar/pull/17157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pul
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 3ecf34abf99 Move Pulsar release related docs to
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new de6948ca7de [fix][flaky-test]AdminApi2Test.test
codelipenghui closed issue #17111: Flaky-test: AdminApi2Test.testDeleteNamespace
URL: https://github.com/apache/pulsar/issues/17111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
tisonkun commented on PR #17168:
URL: https://github.com/apache/pulsar/pull/17168#issuecomment-1220411585
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
BewareMyPower commented on PR #16535:
URL: https://github.com/apache/pulsar/pull/16535#issuecomment-1220405364
Could you fix this test?
```
==
FAIL: test_async_func_with_custom_logger (__main__.CustomLoggingTest)
shibd opened a new issue, #17181:
URL: https://github.com/apache/pulsar/issues/17181
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Motivation
[PIP-106](https://github.com/apache/puls
cbornet commented on code in PR #16816:
URL: https://github.com/apache/pulsar/pull/16816#discussion_r949932680
##
site2/docs/functions-develop-api.md:
##
@@ -102,6 +102,39 @@ public class ExclamationFunction implements
Function {
For more details, see [code
example](https:/
github-actions[bot] commented on PR #17180:
URL: https://github.com/apache/pulsar/pull/17180#issuecomment-1220380281
@gaozhangmin Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label
Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t
gaozhangmin opened a new pull request, #17180:
URL: https://github.com/apache/pulsar/pull/17180
### Motivation
Fix flaky test `testBacklogNoDelayedForPartitionedTopic`
```
Error:
testBacklogNoDelayedForPartitionedTopic(org.apache.pulsar.broker.admin.AdminApi2Test)
Time elaps
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r949916285
##
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##
@@ -1310,4 +1312,17 @@ private void parseFullyQualifiedFunctionName(String
fqfn,
cbornet commented on code in PR #16822:
URL: https://github.com/apache/pulsar/pull/16822#discussion_r949912400
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Worker.java:
##
@@ -115,6 +116,21 @@ public List getConnectorsList()
throws IOException {
ret
momo-jun commented on issue #16637:
URL: https://github.com/apache/pulsar/issues/16637#issuecomment-1220369466
@tisonkun Thanks for the finding. Maybe we can add a tip/note to notify
users to instantiate the version number. Any better ideas?
The doc files with this issue include:
*
eolivelli opened a new issue, #17179:
URL: https://github.com/apache/pulsar/issues/17179
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Version
2.11-SNAPSHOT
### Minimal reprodu
tisonkun commented on issue #16637:
URL: https://github.com/apache/pulsar/issues/16637#issuecomment-1220357108
https://user-images.githubusercontent.com/18818196/185569364-96c07f2f-1eb5-4b01-bd36-8d691d4267fd.png";>
One more fake: all these links to maven central are broken links due t
nodece opened a new pull request, #17178:
URL: https://github.com/apache/pulsar/pull/17178
Signed-off-by: Zixuan Liu
### Motivation
The security-jwt documentation shouldn't include the tls settings.
### Documentation
Check the box below or label this PR directly.
tisonkun commented on issue #16637:
URL: https://github.com/apache/pulsar/issues/16637#issuecomment-1220349317
Now we encounter a new issue that the version number is `2.10.x` so all the
placeholder `@pulsar:version_number@` becomes `2.10.x`. It will generate some
fake info:
https://
github-actions[bot] commented on PR #13359:
URL: https://github.com/apache/pulsar/pull/13359#issuecomment-1220346043
@Anonymitaet Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label
Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t
eolivelli commented on code in PR #16816:
URL: https://github.com/apache/pulsar/pull/16816#discussion_r949882483
##
site2/docs/functions-develop-api.md:
##
@@ -102,6 +102,39 @@ public class ExclamationFunction implements
Function {
For more details, see [code
example](https
gaozhangmin commented on PR #17177:
URL: https://github.com/apache/pulsar/pull/17177#issuecomment-1220325713
> Details
@codelipenghui Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codelipenghui commented on PR #17177:
URL: https://github.com/apache/pulsar/pull/17177#issuecomment-1220322312
I think it is related to https://github.com/apache/pulsar/pull/17142? If
yes, we should cherry-pick it one to branch-2.11
--
This is an automated message from the Apache Git Serv
81 matches
Mail list logo
