[GitHub] [pulsar] coderzc closed pull request #17611: [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load/recover) - part2

2022-09-19 Thread GitBox
coderzc closed pull request #17611: [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load/recover) - part2 URL: https://github.com/apache/pulsar/pull/17611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] lwclover opened a new issue, #17731: [Bug] Cannot get replicatedFrom in EntryFilter

2022-09-19 Thread GitBox
lwclover opened a new issue, #17731: URL: https://github.com/apache/pulsar/issues/17731 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version linux cenos pulsar version 2.10.1

[GitHub] [pulsar] Technoboy- commented on pull request #15956: [fix][admin] Fix producer/consume permission can’t get schema

2022-09-19 Thread GitBox
Technoboy- commented on PR #15956: URL: https://github.com/apache/pulsar/pull/15956#issuecomment-1251914400 > This PR also needs to cherry-pick to branch-2.9. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar] Technoboy- opened a new pull request, #17730: [branch-2.9][cherry-pick] Fix producer/consume permission can’t get schema.

2022-09-19 Thread GitBox
Technoboy- opened a new pull request, #17730: URL: https://github.com/apache/pulsar/pull/17730 Cherry-pick #15956. ### Motivation Currently, we need admin permissions to operate the schema API. This is because the admin permission was defined when the schema API was first added. S

[GitHub] [pulsar] tisonkun commented on pull request #17718: [improve][txn] reduce unnecessary nested futures

2022-09-19 Thread GitBox
tisonkun commented on PR #17718: URL: https://github.com/apache/pulsar/pull/17718#issuecomment-1251904103 @congbobo184 Thanks for your explanation. ```java var f0 = new CompletableFuture(); var f1 = f0.thenCompose((e) -> CompletableFuture.completedFuture(null));

[GitHub] [pulsar] tisonkun closed pull request #17718: [improve][txn] reduce unnecessary nested futures

2022-09-19 Thread GitBox
tisonkun closed pull request #17718: [improve][txn] reduce unnecessary nested futures URL: https://github.com/apache/pulsar/pull/17718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #17526: [fix][broker]Consumer can't consume messages because there has two sames topics in one broker

2022-09-19 Thread GitBox
poorbarcode commented on code in PR #17526: URL: https://github.com/apache/pulsar/pull/17526#discussion_r974938813 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2006,15 +2006,45 @@ public AuthorizationService getAuthorizationService()

[GitHub] [pulsar] Jason918 closed pull request #17390: [fix][dependency] Add OWASP suppression for openstack-keystone-2.5.0

2022-09-19 Thread GitBox
Jason918 closed pull request #17390: [fix][dependency] Add OWASP suppression for openstack-keystone-2.5.0 URL: https://github.com/apache/pulsar/pull/17390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] Jason918 commented on pull request #17390: [fix][dependency] Add OWASP suppression for openstack-keystone-2.5.0

2022-09-19 Thread GitBox
Jason918 commented on PR #17390: URL: https://github.com/apache/pulsar/pull/17390#issuecomment-1251899927 It's duplicated with #17458. Already fixed. Close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] Jason918 commented on pull request #17390: [fix][dependency] Add OWASP suppression for openstack-keystone-2.5.0

2022-09-19 Thread GitBox
Jason918 commented on PR #17390: URL: https://github.com/apache/pulsar/pull/17390#issuecomment-1251897836 @yaalsn Please rebase this PR to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#3d35448)

2022-09-19 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 11caad3de44 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-19 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1251891718 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] aloyszhang commented on pull request #17722: support setting bundle number for default namespace when set up cluster

2022-09-19 Thread GitBox
aloyszhang commented on PR #17722: URL: https://github.com/apache/pulsar/pull/17722#issuecomment-1251889213 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] momo-jun commented on issue #16911: [Doc] wrong pip in 2.10.0 release notes

2022-09-19 Thread GitBox
momo-jun commented on issue #16911: URL: https://github.com/apache/pulsar/issues/16911#issuecomment-1251863253 Closed the issue since it hasn't been planned yet at this moment. Feel free to reopen it when it's relevant. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] momo-jun closed issue #16911: [Doc] wrong pip in 2.10.0 release notes

2022-09-19 Thread GitBox
momo-jun closed issue #16911: [Doc] wrong pip in 2.10.0 release notes URL: https://github.com/apache/pulsar/issues/16911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar] momo-jun commented on issue #14967: [Doc] Create documentation about Monitoring of Tiered Storage

2022-09-19 Thread GitBox
momo-jun commented on issue #14967: URL: https://github.com/apache/pulsar/issues/14967#issuecomment-1251862619 Hi @eolivelli Noticed you have labeled the relevant PR https://github.com/apache/pulsar/pull/14930 as `doc-complete` while the other PR https://github.com/apache/pulsar/pull/14966

[GitHub] [pulsar] momo-jun commented on issue #12201: Document when Pulsar configuration settings or changes were introduced

2022-09-19 Thread GitBox
momo-jun commented on issue #12201: URL: https://github.com/apache/pulsar/issues/12201#issuecomment-1251857008 Closed the issue since it hasn't been planned yet at this moment. Feel free to reopen it when it's relevant. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] momo-jun closed issue #12201: Document when Pulsar configuration settings or changes were introduced

2022-09-19 Thread GitBox
momo-jun closed issue #12201: Document when Pulsar configuration settings or changes were introduced URL: https://github.com/apache/pulsar/issues/12201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-19 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1251855931 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] momo-jun closed issue #8569: [document] How to deploy Pulsar SQL on docker/k8s

2022-09-19 Thread GitBox
momo-jun closed issue #8569: [document] How to deploy Pulsar SQL on docker/k8s URL: https://github.com/apache/pulsar/issues/8569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] momo-jun commented on issue #8569: [document] How to deploy Pulsar SQL on docker/k8s

2022-09-19 Thread GitBox
momo-jun commented on issue #8569: URL: https://github.com/apache/pulsar/issues/8569#issuecomment-1251854271 Closed the issue since it hasn't been planned yet at this moment. Feel free to reopen it when it's relevant. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] momo-jun commented on issue #9008: [Doc] Full scale example

2022-09-19 Thread GitBox
momo-jun commented on issue #9008: URL: https://github.com/apache/pulsar/issues/9008#issuecomment-1251854021 Closed the issue since it hasn't been planned yet at this moment. Feel free to reopen it when it's relevant. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] momo-jun closed issue #9008: [Doc] Full scale example

2022-09-19 Thread GitBox
momo-jun closed issue #9008: [Doc] Full scale example URL: https://github.com/apache/pulsar/issues/9008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: [improve][doc] Improve the information architecture of the security chapter (#17615)

2022-09-19 Thread junma
This is an automated email from the ASF dual-hosted git repository. junma pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3d3544879fa [improve][doc] Improve the informatio

[GitHub] [pulsar] momo-jun closed issue #17561: [Doc] Authentication documentation mismatch / outdated

2022-09-19 Thread GitBox
momo-jun closed issue #17561: [Doc] Authentication documentation mismatch / outdated URL: https://github.com/apache/pulsar/issues/17561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar] momo-jun merged pull request #17615: [improve][doc] Improve the information architecture of the security chapter

2022-09-19 Thread GitBox
momo-jun merged PR #17615: URL: https://github.com/apache/pulsar/pull/17615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar] lhotari commented on pull request #17380: [fix][flaky-test]CompactedTopicTest.testReadCompleteMessagesDuringTopicUnloading

2022-09-19 Thread GitBox
lhotari commented on PR #17380: URL: https://github.com/apache/pulsar/pull/17380#issuecomment-1251849521 Thank you @poorbarcode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[pulsar] branch master updated (26204503494 -> 4af8bf0969c)

2022-09-19 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 26204503494 [fix][schema]ledger handle leak when update schema (#17283) add 4af8bf0969c [fix][flaky-test]Compac

[GitHub] [pulsar] lhotari merged pull request #17380: [fix][flaky-test]CompactedTopicTest.testReadCompleteMessagesDuringTopicUnloading

2022-09-19 Thread GitBox
lhotari merged PR #17380: URL: https://github.com/apache/pulsar/pull/17380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[GitHub] [pulsar] nodece opened a new pull request, #17729: [fix][broker] Fix create ns

2022-09-19 Thread GitBox
nodece opened a new pull request, #17729: URL: https://github.com/apache/pulsar/pull/17729 ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options

[GitHub] [pulsar] lhotari commented on pull request #17718: [improve][txn] reduce unnecessary nested futures

2022-09-19 Thread GitBox
lhotari commented on PR #17718: URL: https://github.com/apache/pulsar/pull/17718#issuecomment-1251827913 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] lhotari commented on issue #15913: Flaky-test: GeoReplicationTest.testTopicReplication

2022-09-19 Thread GitBox
lhotari commented on issue #15913: URL: https://github.com/apache/pulsar/issues/15913#issuecomment-1251824736 another one: https://github.com/apache/pulsar/actions/runs/3086967858/jobs/4991995273#step:12:15153 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] lhotari commented on pull request #17727: [fix][io] Upgrade hadoop client to 3.3.3 and 2.10.2

2022-09-19 Thread GitBox
lhotari commented on PR #17727: URL: https://github.com/apache/pulsar/pull/17727#issuecomment-1251822205 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] heesung-sn opened a new pull request, #17728: [fix][tableview] fixed ack failure in ReaderImpl due to null messageId

2022-09-19 Thread GitBox
heesung-sn opened a new pull request, #17728: URL: https://github.com/apache/pulsar/pull/17728 Fixes # Master Issue: # ### Motivation https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/imp

[GitHub] [pulsar] codelipenghui closed pull request #17721: [cleanup][broker]remove unnecessary variable in MLTransactionMetadataStoreProvider

2022-09-19 Thread GitBox
codelipenghui closed pull request #17721: [cleanup][broker]remove unnecessary variable in MLTransactionMetadataStoreProvider URL: https://github.com/apache/pulsar/pull/17721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-site] Sherlock113 opened a new pull request, #216: Update Pulsar featured event for Pulsar Summit Asia 2022

2022-09-19 Thread GitBox
Sherlock113 opened a new pull request, #216: URL: https://github.com/apache/pulsar-site/pull/216 Update the featured event for Pulsar Summit Asia 2022. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar-client-go] nodece commented on pull request #812: [Issue 489] TLS fix for certificate that does not include IP SANS, save hostname before switching to physical addr

2022-09-19 Thread GitBox
nodece commented on PR #812: URL: https://github.com/apache/pulsar-client-go/pull/812#issuecomment-1251801124 Ping @merlimat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar-client-go] nodece commented on pull request #812: [Issue 489] TLS fix for certificate that does not include IP SANS, save hostname before switching to physical addr

2022-09-19 Thread GitBox
nodece commented on PR #812: URL: https://github.com/apache/pulsar-client-go/pull/812#issuecomment-1251801030 Fix https://github.com/apache/pulsar-client-go/issues/489. This is a good idea, you can also set `AllowInsecureConnection: true`. -- This is an automated message from th

[GitHub] [pulsar] Jason918 commented on pull request #15033: [improvement][client-java] Avoid too large memory preallocation for batch message.

2022-09-19 Thread GitBox
Jason918 commented on PR #15033: URL: https://github.com/apache/pulsar/pull/15033#issuecomment-1251789057 @AnonHxy Can we do a quick test to validate this? Focus on the case with large number of messages in one batch. -- This is an automated message from the Apache Git Service. To respond

[pulsar] branch master updated: [fix][schema]ledger handle leak when update schema (#17283)

2022-09-19 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 26204503494 [fix][schema]ledger handle leak when

[GitHub] [pulsar] congbobo184 merged pull request #17283: [fix][schema]ledger handle leak when update schema

2022-09-19 Thread GitBox
congbobo184 merged PR #17283: URL: https://github.com/apache/pulsar/pull/17283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[GitHub] [pulsar] poorbarcode closed pull request #17701: [improve][txn]PIP-160 make txn components supports buffered writer metrics

2022-09-19 Thread GitBox
poorbarcode closed pull request #17701: [improve][txn]PIP-160 make txn components supports buffered writer metrics URL: https://github.com/apache/pulsar/pull/17701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-19 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1251780100 CI PR: https://github.com/lordcheng10/pulsar/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] lordcheng10 commented on pull request #17726: Fix metric messagesConsumedCounter calculation error

2022-09-19 Thread GitBox
lordcheng10 commented on PR #17726: URL: https://github.com/apache/pulsar/pull/17726#issuecomment-1251779479 CI PR: https://github.com/lordcheng10/pulsar/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] aloyszhang commented on pull request #17722: support setting bundle number for default namespace when set up cluster

2022-09-19 Thread GitBox
aloyszhang commented on PR #17722: URL: https://github.com/apache/pulsar/pull/17722#issuecomment-1251778827 checks in fork repo : https://github.com/aloyszhang/pulsar/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar-client-go] nodece commented on pull request #828: [Issue 827][bugfix] fix error delay of default backoff policy

2022-09-19 Thread GitBox
nodece commented on PR #828: URL: https://github.com/apache/pulsar-client-go/pull/828#issuecomment-1251775620 Closed by #834. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar-client-go] nodece closed pull request #828: [Issue 827][bugfix] fix error delay of default backoff policy

2022-09-19 Thread GitBox
nodece closed pull request #828: [Issue 827][bugfix] fix error delay of default backoff policy URL: https://github.com/apache/pulsar-client-go/pull/828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] tisonkun commented on issue #17688: [Doc] Broken links in `io-connectors` page for versions prior to 2.4.2

2022-09-19 Thread GitBox
tisonkun commented on issue #17688: URL: https://github.com/apache/pulsar/issues/17688#issuecomment-1251769583 @Anonymitaet It's not about the domain `pulsar.staged.apache.org`, but the artifacts... If you take a look at an ancient trino version, you will find that the style changes

[GitHub] [pulsar] Anonymitaet commented on issue #17688: [Doc] Broken links in `io-connectors` page for versions prior to 2.4.2

2022-09-19 Thread GitBox
Anonymitaet commented on issue #17688: URL: https://github.com/apache/pulsar/issues/17688#issuecomment-1251768137 @tisonkun thanks! I think we do not want users to know pulsar.staged.apache.org. Reasons: 1. For users: they might be confused about why there are 2 Pulsar websites

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #17526: [fix][broker]Consumer can't consume messages because there has two sames topics in one broker

2022-09-19 Thread GitBox
Technoboy- commented on code in PR #17526: URL: https://github.com/apache/pulsar/pull/17526#discussion_r974835112 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2006,15 +2006,45 @@ public AuthorizationService getAuthorizationService()

[GitHub] [pulsar-site] tisonkun commented on pull request #215: remove old site files

2022-09-19 Thread GitBox
tisonkun commented on PR #215: URL: https://github.com/apache/pulsar-site/pull/215#issuecomment-1251767185 FYI - * Remove `site2/website/*` * Remove `.github/workflows/ci-pulsar-website-build.yaml`. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] lordcheng10 opened a new pull request, #17726: Fix metric messagesConsumedCounter calculation error

2022-09-19 Thread GitBox
lordcheng10 opened a new pull request, #17726: URL: https://github.com/apache/pulsar/pull/17726 ### Motivation Fix metric messagesConsumedCounter calculation error. In the ManagedCursorImpl#setAcknowledgedPosition method, we will calculate skippedEntries based on newMarkDeletePosition

[GitHub] [pulsar] lordcheng10 closed pull request #17725: [fix][broker]Fix metric messagesConsumedCounter calculation error

2022-09-19 Thread GitBox
lordcheng10 closed pull request #17725: [fix][broker]Fix metric messagesConsumedCounter calculation error URL: https://github.com/apache/pulsar/pull/17725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar-site] tisonkun opened a new pull request, #215: remove old site files

2022-09-19 Thread GitBox
tisonkun opened a new pull request, #215: URL: https://github.com/apache/pulsar-site/pull/215 These files haven't been changed for months. And I believe further development will happen on the `next` site. Still, we can always bring these files back on demand from VCS and the pulsar.s

[GitHub] [pulsar] kingdom998 commented on issue #16631: create function with restful API,which has the error "415 Unsupported Media Type"

2022-09-19 Thread GitBox
kingdom998 commented on issue #16631: URL: https://github.com/apache/pulsar/issues/16631#issuecomment-1251762501 > Hello, someone can help me to solve the problem? you can use curl like below ``` curl --location --request POST 'http://127.0.0.1:8080/admin/v3/functions/sample/ns

[GitHub] [pulsar] AnonHxy commented on pull request #15033: [improvement][client-java] Avoid too large memory preallocation for batch message.

2022-09-19 Thread GitBox
AnonHxy commented on PR #15033: URL: https://github.com/apache/pulsar/pull/15033#issuecomment-1251762196 Hi @merlimat , `compositeBuffer` will not lead to memory copies until the `componentCount` reached the `maxNumComponents`, which default value is 16. If we want to avoid any mem

[GitHub] [pulsar] lordcheng10 opened a new pull request, #17725: Fix metric messagesConsumedCounter calculation error

2022-09-19 Thread GitBox
lordcheng10 opened a new pull request, #17725: URL: https://github.com/apache/pulsar/pull/17725 ### Motivation Fix metric messagesConsumedCounter calculation error. In the ManagedCursorImpl#setAcknowledgedPosition method, we will calculate skippedEntries based on newMarkDeletePosition

[GitHub] [pulsar] tisonkun commented on issue #17688: [Doc] Broken links in `io-connectors` page for versions prior to 2.4.2

2022-09-19 Thread GitBox
tisonkun commented on issue #17688: URL: https://github.com/apache/pulsar/issues/17688#issuecomment-1251757321 @Anonymitaet if we can redirect docs of old versions, said before 2.7.0, to pulsar.staged.apache.org and keep them work as is, it will help to focus on current versions instead of

[GitHub] [pulsar] tisonkun commented on pull request #17718: [improve][txn] reduce unnecessary nested futures

2022-09-19 Thread GitBox
tisonkun commented on PR #17718: URL: https://github.com/apache/pulsar/pull/17718#issuecomment-1251753729 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] aloyszhang commented on a diff in pull request #17722: support setting bundle number for default namespace when set up cluster

2022-09-19 Thread GitBox
aloyszhang commented on code in PR #17722: URL: https://github.com/apache/pulsar/pull/17722#discussion_r974821681 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/zookeeper/ClusterMetadataSetupTest.java: ## @@ -86,6 +88,32 @@ public void testReSetupClusterMetadata() throw

[GitHub] [pulsar] codelipenghui closed pull request #17717: [fix][client] Unwrap completion exception for Lookup Services

2022-09-19 Thread GitBox
codelipenghui closed pull request #17717: [fix][client] Unwrap completion exception for Lookup Services URL: https://github.com/apache/pulsar/pull/17717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Anonymitaet commented on pull request #17218: [BLOG] Add the Pulsar Summit Asia 2022 CFP blog

2022-09-19 Thread GitBox
Anonymitaet commented on PR #17218: URL: https://github.com/apache/pulsar/pull/17218#issuecomment-1251744826 @Sherlock113 This PR can be merged after all required check passes. https://user-images.githubusercontent.com/50226895/191150310-68eae205-198f-4519-95e2-7602677038de.png";> --

[GitHub] [pulsar] kingdom998 commented on issue #5312: Function REST API documentation is insufficient for Create POST action

2022-09-19 Thread GitBox
kingdom998 commented on issue #5312: URL: https://github.com/apache/pulsar/issues/5312#issuecomment-1251743455 > I solved it with curl expression below in my env. curl --location --request POST 'http://127.0.0.1:8080/admin/v3/functions/sample/ns1/toupper' \ --header 'Content-Dispos

[pulsar] branch master updated: docs: replace reference-configuration page with an external link (#17699)

2022-09-19 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bf6e815767c docs: replace reference-configuratio

[GitHub] [pulsar-site] urfreespace merged pull request #210: Remove redudant docs and move configuration intro to /reference

2022-09-19 Thread GitBox
urfreespace merged PR #210: URL: https://github.com/apache/pulsar-site/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[GitHub] [pulsar] urfreespace merged pull request #17699: [fix][doc] Replace reference-configuration page with an external link

2022-09-19 Thread GitBox
urfreespace merged PR #17699: URL: https://github.com/apache/pulsar/pull/17699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[pulsar-site] branch asf-site-next updated: Updated site at revision a8b99a89

2022-09-19 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch asf-site-next in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/asf-site-next by this push: new 11e74813cbf Updated site at r

[GitHub] [pulsar] zymap commented on a diff in pull request #17398: [feat][tiered-storage] ADD offload_time_threshold policy

2022-09-19 Thread GitBox
zymap commented on code in PR #17398: URL: https://github.com/apache/pulsar/pull/17398#discussion_r974793855 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/OffloadPrefixTest.java: ## @@ -739,14 +740,23 @@ private static byte[] buildEntry(int size, String pat

[GitHub] [pulsar] poorbarcode opened a new pull request, #17283: [fix][schema]ledger handle leak when update schema

2022-09-19 Thread GitBox
poorbarcode opened a new pull request, #17283: URL: https://github.com/apache/pulsar/pull/17283 ### Motivation in the schema update, will create a `ledgerHandle` and write data to BK, after that `ledgerHandle` is no longer useful and no other object holds references to it. `ledgerHan

[GitHub] [pulsar] codelipenghui closed pull request #17283: [fix][schema]ledger handle leak when update schema

2022-09-19 Thread GitBox
codelipenghui closed pull request #17283: [fix][schema]ledger handle leak when update schema URL: https://github.com/apache/pulsar/pull/17283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] codelipenghui closed pull request #17526: [fix][broker]Consumer can't consume messages because there has two sames topics in one broker

2022-09-19 Thread GitBox
codelipenghui closed pull request #17526: [fix][broker]Consumer can't consume messages because there has two sames topics in one broker URL: https://github.com/apache/pulsar/pull/17526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #16917: [improve][txn][PIP-196]Segmented transaction buffer snapshot configuration

2022-09-19 Thread GitBox
liangyepianzhou opened a new pull request, #16917: URL: https://github.com/apache/pulsar/pull/16917 Master Issue: https://github.com/apache/pulsar/issues/16913 ### Motivation 1. Add configurations. 2. Implement system topic client for snapshot topic and index topic. 3. Implement A

[GitHub] [pulsar] codelipenghui closed pull request #16917: [improve][txn][PIP-196]Segmented transaction buffer snapshot configuration

2022-09-19 Thread GitBox
codelipenghui closed pull request #16917: [improve][txn][PIP-196]Segmented transaction buffer snapshot configuration URL: https://github.com/apache/pulsar/pull/16917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] codelipenghui commented on pull request #16917: [improve][txn][PIP-196]Segmented transaction buffer snapshot configuration

2022-09-19 Thread GitBox
codelipenghui commented on PR #16917: URL: https://github.com/apache/pulsar/pull/16917#issuecomment-1251712532 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17700: [fix][metadata] Cleanup state when lock revalidation gets `LockBusyException`

2022-09-19 Thread GitBox
mattisonchao commented on code in PR #17700: URL: https://github.com/apache/pulsar/pull/17700#discussion_r974780117 ## pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LockManagerTest.java: ## @@ -293,4 +296,55 @@ public void revalidateLockOnDifferentSession(String prov

[GitHub] [pulsar] codelipenghui commented on pull request #17283: [fix][schema]ledger handle leak when update schema

2022-09-19 Thread GitBox
codelipenghui commented on PR #17283: URL: https://github.com/apache/pulsar/pull/17283#issuecomment-1251696751 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17700: [fix][metadata] Cleanup state when lock revalidation gets `LockBusyException`

2022-09-19 Thread GitBox
mattisonchao commented on code in PR #17700: URL: https://github.com/apache/pulsar/pull/17700#discussion_r974780117 ## pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LockManagerTest.java: ## @@ -293,4 +296,55 @@ public void revalidateLockOnDifferentSession(String prov

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#9f9922a)

2022-09-19 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new a8b99a89733 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] merlimat commented on a diff in pull request #17722: support setting bundle number for default namespace when set up cluster

2022-09-19 Thread GitBox
merlimat commented on code in PR #17722: URL: https://github.com/apache/pulsar/pull/17722#discussion_r974764210 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/zookeeper/ClusterMetadataSetupTest.java: ## @@ -86,6 +88,32 @@ public void testReSetupClusterMetadata() throws

[GitHub] [pulsar] merlimat opened a new issue, #17724: PIP-XYZ:

2022-09-19 Thread GitBox
merlimat opened a new issue, #17724: URL: https://github.com/apache/pulsar/issues/17724 ### Motivation Pulsar C++ code base is in the same main repository for the Pulsar project. While the decision was the right one at the time, there is a considerable overhead in keeping t

[GitHub] [pulsar] syhily commented on a diff in pull request #17718: [improve][txn] reduce unnecessary nested futures

2022-09-19 Thread GitBox
syhily commented on code in PR #17718: URL: https://github.com/apache/pulsar/pull/17718#discussion_r974760724 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java: ## @@ -133,15 +133,9 @@ public CompletableFuture registerAckedTopic(String

[GitHub] [pulsar] syhily commented on a diff in pull request #17718: [improve][txn] reduce unnecessary nested futures

2022-09-19 Thread GitBox
syhily commented on code in PR #17718: URL: https://github.com/apache/pulsar/pull/17718#discussion_r974760724 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java: ## @@ -133,15 +133,9 @@ public CompletableFuture registerAckedTopic(String

[pulsar] branch master updated: [fix][CI] Fix issues with approval solution for GitHub Actions (#17723)

2022-09-19 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9f9922af0a0 [fix][CI] Fix issues with approval

[GitHub] [pulsar] lhotari merged pull request #17723: [fix][CI] Fix issues with approval solution for GitHub Actions

2022-09-19 Thread GitBox
lhotari merged PR #17723: URL: https://github.com/apache/pulsar/pull/17723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[GitHub] [pulsar] merlimat commented on pull request #15033: [improvement][client-java] Avoid too large memory preallocation for batch message.

2022-09-19 Thread GitBox
merlimat commented on PR #15033: URL: https://github.com/apache/pulsar/pull/15033#issuecomment-1251465417 @tjiuming @Jason918 @AnonHxy > Allocate small memory for batch message first, and let it grow(with no memory resizes and memory copies). How can you say there are no memor

[pulsar] branch master updated (8bc02aa9829 -> 36e368120e0)

2022-09-19 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 8bc02aa9829 [fix][broker] Fix if dynamicConfig item in ZK do not exist in broker cause NPE (#17705) add 36e36812

[GitHub] [pulsar] merlimat merged pull request #17709: [improve][ci] docbot comment only for open PRs

2022-09-19 Thread GitBox
merlimat merged PR #17709: URL: https://github.com/apache/pulsar/pull/17709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar] lhotari commented on pull request #17723: [fix][CI] Fix issues with approval solution for GitHub Actions

2022-09-19 Thread GitBox
lhotari commented on PR #17723: URL: https://github.com/apache/pulsar/pull/17723#issuecomment-1251443056 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] lhotari commented on pull request #17723: [fix][CI] Fix issues with approval solution for GitHub Actions

2022-09-19 Thread GitBox
lhotari commented on PR #17723: URL: https://github.com/apache/pulsar/pull/17723#issuecomment-1251410577 https://github.com/apache/pulsar/actions/runs/3084722603/jobs/4987198213#step:5:9 demonstrates that these changes are able to retrieve the approval status: ``` Review decision for

[GitHub] [pulsar] lhotari opened a new pull request, #17723: [fix][CI] Fix issues with approval solution for GitHub Actions

2022-09-19 Thread GitBox
lhotari opened a new pull request, #17723: URL: https://github.com/apache/pulsar/pull/17723 ### Motivation - The approval solution doesn't work as expected by approving the PR or by adding the ready-to-test label and adding a comment "/pulsarbot rerun-failure-checks". ### Modi

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#8bc02aa)

2022-09-19 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 5022bccb702 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] zbentley commented on issue #16013: Pulsar Standalone Docker image does not work.

2022-09-19 Thread GitBox
zbentley commented on issue #16013: URL: https://github.com/apache/pulsar/issues/16013#issuecomment-1251313425 Any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] aloyszhang opened a new pull request, #17722: support setting bundle number for default namespace when set up cluster

2022-09-19 Thread GitBox
aloyszhang opened a new pull request, #17722: URL: https://github.com/apache/pulsar/pull/17722 ### Motivation In the actual production environment, users may only use one default namespace (public/default). The number of bundles in this namespace is a default value of 16. 1.

[GitHub] [pulsar] lhotari closed pull request #17716: [fix][security] Upgrade reload4j in file-system offloader

2022-09-19 Thread GitBox
lhotari closed pull request #17716: [fix][security] Upgrade reload4j in file-system offloader URL: https://github.com/apache/pulsar/pull/17716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar] poorbarcode closed pull request #17443: [fix][client]Duplicate messages when use MultiTopicsConsumerImpl

2022-09-19 Thread GitBox
poorbarcode closed pull request #17443: [fix][client]Duplicate messages when use MultiTopicsConsumerImpl URL: https://github.com/apache/pulsar/pull/17443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] poorbarcode commented on pull request #17443: [fix][client]Duplicate messages when use MultiTopicsConsumerImpl

2022-09-19 Thread GitBox
poorbarcode commented on PR #17443: URL: https://github.com/apache/pulsar/pull/17443#issuecomment-1251242141 PIP-194 will fix this problem - https://github.com/apache/pulsar/issues/16757 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] merlimat commented on pull request #17515: [improve][test] Add integration test for broker interceptors

2022-09-19 Thread GitBox
merlimat commented on PR #17515: URL: https://github.com/apache/pulsar/pull/17515#issuecomment-1251240380 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] yuruguo commented on pull request #17720: [broker][admin] Support to set/get/remove autoSubscriptionCreation on topic

2022-09-19 Thread GitBox
yuruguo commented on PR #17720: URL: https://github.com/apache/pulsar/pull/17720#issuecomment-1251224794 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] poorbarcode commented on pull request #17704: [fix][metrics]wrong metrics text generated when label_cluster specified

2022-09-19 Thread GitBox
poorbarcode commented on PR #17704: URL: https://github.com/apache/pulsar/pull/17704#issuecomment-1251215921 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] yuruguo commented on pull request #17720: [broker][admin] Support to set/get/remove autoSubscriptionCreation on topic

2022-09-19 Thread GitBox
yuruguo commented on PR #17720: URL: https://github.com/apache/pulsar/pull/17720#issuecomment-1251215593 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

  1   2   >