[GitHub] [pulsar] fantapsody opened a new pull request, #18937: [fix][client] Fix the conversion from the response to string in client error handling

2022-12-15 Thread GitBox
fantapsody opened a new pull request, #18937: URL: https://github.com/apache/pulsar/pull/18937 ### Motivation The code to parse the response as a string is incorrect in the error handling of the admin client. The code `e.getResponse().getEntity().toString()` returns something like `j

svn commit: r58732 - /dev/pulsar/pulsar-2.11.0-candidate-2/

2022-12-15 Thread technoboy
Author: technoboy Date: Thu Dec 15 08:06:30 2022 New Revision: 58732 Log: delete Pulsar release 2.11.0-candidate-2 Removed: dev/pulsar/pulsar-2.11.0-candidate-2/

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18928: [fix][broker] Fix direct memory leak in RawReaderImpl

2022-12-15 Thread GitBox
congbobo184 commented on code in PR #18928: URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049324152 ## pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java: ## @@ -203,12 +232,17 @@ public CompletableFuture seekAsync(MessageId messageId)

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18937: [fix][client] Fix the conversion from the response to string in client error handling

2022-12-15 Thread GitBox
congbobo184 commented on code in PR #18937: URL: https://github.com/apache/pulsar/pull/18937#discussion_r1049327432 ## pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java: ## @@ -324,7 +324,7 @@ public static String getReasonFromServer(We

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18928: [fix][broker] Fix direct memory leak in RawReaderImpl

2022-12-15 Thread GitBox
poorbarcode commented on code in PR #18928: URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049193185 ## pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java: ## @@ -203,12 +232,17 @@ public CompletableFuture seekAsync(MessageId messageId)

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18911: [fix][client] Fix too many redelivered messages when one message acked timeout in listener

2022-12-15 Thread GitBox
congbobo184 commented on code in PR #18911: URL: https://github.com/apache/pulsar/pull/18911#discussion_r1049279897 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -364,7 +357,9 @@ protected Message internalReceive() throws Pulsa

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18911: [fix][client] Fix too many redelivered messages when one message acked timeout in listener

2022-12-15 Thread GitBox
congbobo184 commented on code in PR #18911: URL: https://github.com/apache/pulsar/pull/18911#discussion_r1049282539 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -312,7 +301,9 @@ private void messageReceived(ConsumerImpl consume

[GitHub] [pulsar] nicoloboschi closed issue #18920: [Bug] org.apache.pulsar:pulsar-io-kafka depends on io.confluent:kafka-schema-registry which has incompatible license

2022-12-15 Thread GitBox
nicoloboschi closed issue #18920: [Bug] org.apache.pulsar:pulsar-io-kafka depends on io.confluent:kafka-schema-registry which has incompatible license URL: https://github.com/apache/pulsar/issues/18920 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar] nicoloboschi merged pull request #18931: [fix][io] Only bundle kafka schema registry client

2022-12-15 Thread GitBox
nicoloboschi merged PR #18931: URL: https://github.com/apache/pulsar/pull/18931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[pulsar] branch master updated: [fix][io] Only bundle kafka schema registry client (#18931)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a95154976eb [fix][io] Only bundle kafka sc

[pulsar] branch branch-2.11 updated: [fix][io] Only bundle kafka schema registry client (#18931)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 5eedf5614bb [fix][io] Only bundl

[pulsar] branch branch-2.10 updated: [fix][io] Only bundle kafka schema registry client (#18931)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 76c5ee982b5 [fix][io] Only bundl

[pulsar] branch branch-2.9 updated (7c7ccd6bbad -> e79fd0e7d51)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a change to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 7c7ccd6bbad Revert #14829 Filter the virtual NIC with relative path add e79fd0e7d51 [fix][io] Only bund

[pulsar] branch branch-2.8 updated: [fix][io] Only bundle kafka schema registry client (#18931)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 99e11f8c1f1 [fix][io] Only bundle

svn commit: r58733 [2/2] - in /dev/pulsar/pulsar-2.11.0-candidate-3: ./ connectors/

2022-12-15 Thread technoboy
Added: dev/pulsar/pulsar-2.11.0-candidate-3/connectors/pulsar-io-jdbc-postgres-2.11.0.nar.asc == --- dev/pulsar/pulsar-2.11.0-candidate-3/connectors/pulsar-io-jdbc-postgres-2.11.0.nar.asc (added) +++ dev/pulsar/pulsar-2

svn commit: r58733 [1/2] - in /dev/pulsar/pulsar-2.11.0-candidate-3: ./ connectors/

2022-12-15 Thread technoboy
Author: technoboy Date: Thu Dec 15 08:30:41 2022 New Revision: 58733 Log: Staging artifacts and signature for Pulsar release 2.11.0 Added: dev/pulsar/pulsar-2.11.0-candidate-3/ dev/pulsar/pulsar-2.11.0-candidate-3/apache-pulsar-2.11.0-bin.tar.gz (with props) dev/pulsar/pulsar-2.11.

[GitHub] [pulsar] thetumbled commented on pull request #18936: [improve] [broker] filter system topics while shedding

2022-12-15 Thread GitBox
thetumbled commented on PR #18936: URL: https://github.com/apache/pulsar/pull/18936#issuecomment-1352718553 > A system topic can be unloaded, allowing it to be load balanced. If you filter the system topic, it may lead to uneven resource allocation. In the master branch, topics/bu

[GitHub] [pulsar] lhotari commented on a diff in pull request #18928: [fix][broker] Fix direct memory leak in RawReaderImpl

2022-12-15 Thread GitBox
lhotari commented on code in PR #18928: URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049358007 ## pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java: ## @@ -203,12 +232,17 @@ public CompletableFuture seekAsync(MessageId messageId) {

[GitHub] [pulsar] lhotari opened a new issue, #18938: [Bug][Java client] Possible race condition in closing consumer which causes a leak in memory limit controller and direct memory with pooled messag

2022-12-15 Thread GitBox
lhotari opened a new issue, #18938: URL: https://github.com/apache/pulsar/issues/18938 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master ### Minimal reproduce step

[GitHub] [pulsar] lhotari commented on a diff in pull request #18928: [fix][broker] Fix direct memory leak in RawReaderImpl

2022-12-15 Thread GitBox
lhotari commented on code in PR #18928: URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049363248 ## pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java: ## @@ -203,12 +232,17 @@ public CompletableFuture seekAsync(MessageId messageId) {

[GitHub] [pulsar] lhotari opened a new issue, #18939: [Bug][Java client] Possible race condition in consumer's clearIncomingMessages which causes a leak in memory limit controller and direct memory wi

2022-12-15 Thread GitBox
lhotari opened a new issue, #18939: URL: https://github.com/apache/pulsar/issues/18939 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master ### Minimal reproduce step

[GitHub] [pulsar] lhotari commented on a diff in pull request #18928: [fix][broker] Fix direct memory leak in RawReaderImpl

2022-12-15 Thread GitBox
lhotari commented on code in PR #18928: URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049366792 ## pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java: ## @@ -203,12 +232,17 @@ public CompletableFuture seekAsync(MessageId messageId) {

[GitHub] [pulsar] lhotari commented on a diff in pull request #18928: [fix][broker] Fix direct memory leak in RawReaderImpl

2022-12-15 Thread GitBox
lhotari commented on code in PR #18928: URL: https://github.com/apache/pulsar/pull/18928#discussion_r1049368244 ## pulsar-broker/src/main/java/org/apache/pulsar/client/impl/RawReaderImpl.java: ## @@ -203,12 +232,17 @@ public CompletableFuture seekAsync(MessageId messageId) {

[GitHub] [pulsar] tuteng merged pull request #18794: [fix][client] Fix update response body text

2022-12-15 Thread GitBox
tuteng merged PR #18794: URL: https://github.com/apache/pulsar/pull/18794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

[pulsar] branch master updated (a95154976eb -> 1107af24932)

2022-12-15 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from a95154976eb [fix][io] Only bundle kafka schema registry client (#18931) add 1107af24932 [fix][client] Fix upda

[GitHub] [pulsar] codecov-commenter commented on pull request #18021: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944

2022-12-15 Thread GitBox
codecov-commenter commented on PR #18021: URL: https://github.com/apache/pulsar/pull/18021#issuecomment-1352763048 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18021?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [pulsar] tuteng opened a new pull request, #18940: [fix][broker]Update interceptor handler exception

2022-12-15 Thread GitBox
tuteng opened a new pull request, #18940: URL: https://github.com/apache/pulsar/pull/18940 Fixes #xyz Master Issue: #xyz ### Motivation ### Modifications ### Verifying this change - [ ] Make sure that the change passes

svn commit: r58738 - /dev/pulsar/KEYS

2022-12-15 Thread xiangying
Author: xiangying Date: Thu Dec 15 09:23:09 2022 New Revision: 58738 Log: Added gpg key for xiangying Modified: dev/pulsar/KEYS Modified: dev/pulsar/KEYS == --- dev/pulsar/KEYS (original) +++ dev/pulsar/KEYS Thu Dec

[GitHub] [pulsar] marksilcox opened a new pull request, #18941: [branch-2.10] Group prometheus metrics

2022-12-15 Thread GitBox
marksilcox opened a new pull request, #18941: URL: https://github.com/apache/pulsar/pull/18941 ### Motivation Cherry picked from https://github.com/apache/pulsar/pull/15558 with reference to fixes in https://github.com/apache/pulsar/pull/17852 - [X] Make sure that the change pa

[GitHub] [pulsar] marksilcox commented on pull request #15558: [fix][broker][functions-worker] Ensure prometheus metrics are grouped by type (#8407, #13865)

2022-12-15 Thread GitBox
marksilcox commented on PR #15558: URL: https://github.com/apache/pulsar/pull/15558#issuecomment-1352778289 @liangyepianzhou I've created https://github.com/apache/pulsar/pull/18941 to merge into branch-2.10. @asafm compared these changes against that PR to ensure the memory leak fix is

[GitHub] [pulsar] elysian-gc opened a new issue, #18942: [Bug] boot broker failed with etcd

2022-12-15 Thread GitBox
elysian-gc opened a new issue, #18942: URL: https://github.com/apache/pulsar/issues/18942 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.10.2 ### Minimal reproduce ste

[GitHub] [pulsar] mattisonchao commented on pull request #18794: [fix][client] Fix update response body text

2022-12-15 Thread GitBox
mattisonchao commented on PR #18794: URL: https://github.com/apache/pulsar/pull/18794#issuecomment-1352809822 Oops. Could you help to take a look? I am not sure if it is a sensitive breaking change for users. @codelipenghui @eolivelli @Technoboy- @Jason918 -- This is an automate

[GitHub] [pulsar] congbobo184 commented on pull request #18936: [improve] [broker] filter system topics while shedding

2022-12-15 Thread GitBox
congbobo184 commented on PR #18936: URL: https://github.com/apache/pulsar/pull/18936#issuecomment-1352815064 > In the master branch, topics/bundles in `pulsar/system` will be filter. I think this logic was introduced by mistake by pr https://github.com/apache/pulsar/pull/15252

[GitHub] [pulsar] thetumbled commented on pull request #18936: [improve] [broker] filter system topics while shedding

2022-12-15 Thread GitBox
thetumbled commented on PR #18936: URL: https://github.com/apache/pulsar/pull/18936#issuecomment-1352836432 > > In the master branch, topics/bundles in `pulsar/system` will be filter. > > I think this logic was introduced by mistake by pr #15252 Should i raise a PR to revert mis

[GitHub] [pulsar-client-go] nodece merged pull request #895: Use protocolbuffers instead of gogo

2022-12-15 Thread GitBox
nodece merged PR #895: URL: https://github.com/apache/pulsar-client-go/pull/895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[GitHub] [pulsar-client-go] nodece closed issue #862: gogo/protobuf is deprecated

2022-12-15 Thread GitBox
nodece closed issue #862: gogo/protobuf is deprecated URL: https://github.com/apache/pulsar-client-go/issues/862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar-client-go] nodece commented on a diff in pull request #911: [build] update go version to 1.18

2022-12-15 Thread GitBox
nodece commented on code in PR #911: URL: https://github.com/apache/pulsar-client-go/pull/911#discussion_r1049481584 ## README.md: ## @@ -36,7 +36,9 @@ CGo based library. ## Requirements -- Go 1.15+ +- Go 1.18+ Review Comment: ```suggestion - Go 1.18+ ```

[GitHub] [pulsar] nicoloboschi merged pull request #18021: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944

2022-12-15 Thread GitBox
nicoloboschi merged PR #18021: URL: https://github.com/apache/pulsar/pull/18021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[pulsar] branch master updated: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944 (#18021)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3011946a5c3 [fix][sec] Upgrade scala-libra

[pulsar] branch branch-2.10 updated: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944 (#18021)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new e62efbd64b2 [fix][sec] Upgrade s

[pulsar] branch branch-2.11 updated: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944 (#18021)

2022-12-15 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new d8fa685a83f [fix][sec] Upgrade s

[GitHub] [pulsar] equanz commented on a diff in pull request #18807: [fix][monitor] Fix a partitioned publisher topic stat aggregation bug

2022-12-15 Thread GitBox
equanz commented on code in PR #18807: URL: https://github.com/apache/pulsar/pull/18807#discussion_r1049476590 ## pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java: ## @@ -252,19 +253,15 @@ public TopicStatsImpl add(TopicStats ts) {

[GitHub] [pulsar] thetumbled commented on pull request #18390: [fix][broker] fix bug caused by optimistic locking

2022-12-15 Thread GitBox
thetumbled commented on PR #18390: URL: https://github.com/apache/pulsar/pull/18390#issuecomment-1352984542 There are same problems with `org.apache.pulsar.common.util.collections.ConcurrentLongHashMap`, **which is referenced in many places.** we can reproduce concurrency problem using

[GitHub] [pulsar] congbobo184 commented on pull request #18936: [improve] [broker] filter system topics while shedding

2022-12-15 Thread GitBox
congbobo184 commented on PR #18936: URL: https://github.com/apache/pulsar/pull/18936#issuecomment-1353008319 > > Should i raise a PR to revert mistake in the master branch? > yes, I think we need a pr to revert this change > I think that load balancing strategy such as `

[GitHub] [pulsar] fantapsody commented on a diff in pull request #18937: [fix][client-admin] Fix the conversion from the response to string in client error handling

2022-12-15 Thread GitBox
fantapsody commented on code in PR #18937: URL: https://github.com/apache/pulsar/pull/18937#discussion_r1049659906 ## pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java: ## @@ -324,7 +324,7 @@ public static String getReasonFromServer(Web

[GitHub] [pulsar-manager] vfauth opened a new pull request, #501: Use existing database if present

2022-12-15 Thread GitBox
vfauth opened a new pull request, #501: URL: https://github.com/apache/pulsar-manager/pull/501 ### Motivation Currently the database is always initialized at startup, even if it is already present, which disables persistence. ### Modifications In order to change that, I

[GitHub] [pulsar-helm-chart] vfauth opened a new pull request, #343: Enable persistency for pulsar-manager

2022-12-15 Thread GitBox
vfauth opened a new pull request, #343: URL: https://github.com/apache/pulsar-helm-chart/pull/343 ### Motivation Currently, pulsar-manager volume is not persistent, which means that after a pod restart admin accounts must be [recreated](https://github.com/apache/pulsar-manager#access

[GitHub] [pulsar-site] tisonkun opened a new pull request, #337: Update release process

2022-12-15 Thread GitBox
tisonkun opened a new pull request, #337: URL: https://github.com/apache/pulsar-site/pull/337 This closes https://github.com/apache/pulsar/issues/18696. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] tisonkun closed issue #18696: Update the release process to document RM's responsibility and how-tos explicitly

2022-12-15 Thread GitBox
tisonkun closed issue #18696: Update the release process to document RM's responsibility and how-tos explicitly URL: https://github.com/apache/pulsar/issues/18696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pulsar-site] tisonkun merged pull request #337: Update release process for references/API docs generation

2022-12-15 Thread GitBox
tisonkun merged PR #337: URL: https://github.com/apache/pulsar-site/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar-site] branch main updated: Update release process for references/API docs generation (#337)

2022-12-15 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 54280f171b7 Update release process for reference

[GitHub] [pulsar] tisonkun closed issue #18693: [Doc] Release API docs only for major release

2022-12-15 Thread GitBox
tisonkun closed issue #18693: [Doc] Release API docs only for major release URL: https://github.com/apache/pulsar/issues/18693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pulsar] tisonkun commented on issue #18693: [Doc] Release API docs only for major release

2022-12-15 Thread GitBox
tisonkun commented on issue #18693: URL: https://github.com/apache/pulsar/issues/18693#issuecomment-1353152085 Closed as all subtasks done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar-client-cpp] tisonkun commented on issue #123: Add the release process

2022-12-15 Thread GitBox
tisonkun commented on issue #123: URL: https://github.com/apache/pulsar-client-cpp/issues/123#issuecomment-1353154082 I read we have https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide now. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] tisonkun commented on issue #17918: [Doc] Update the release process about how to release C++ and Python client

2022-12-15 Thread GitBox
tisonkun commented on issue #17918: URL: https://github.com/apache/pulsar/issues/17918#issuecomment-1353154716 @BewareMyPower @RobertIndie @shibd For the C++ client, we have https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide now. What about the Python client?

[pulsar-site] branch main updated (54280f171b7 -> 0db05b762ce)

2022-12-15 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 54280f171b7 Update release process for references/API docs generation (#337) new 476602df2c5 sort swagger out

[pulsar-site] 01/02: sort swagger output

2022-12-15 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 476602df2c5ad21606031007dbadafa7d2e5fec2 Author: tison AuthorDate: Thu Dec 15 22:21:36 2022 +0800 sort swagger ou

[GitHub] [pulsar-client-cpp] tisonkun merged pull request #145: [fix][doc] CMake is added to the Homebrew Mac Installation list

2022-12-15 Thread GitBox
tisonkun merged PR #145: URL: https://github.com/apache/pulsar-client-cpp/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

[pulsar-client-cpp] branch main updated: Add CMAKE to the Homebrew installation line (#145)

2022-12-15 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 44f3b52 Add CMAKE to the Homebrew install

[pulsar-site] branch main updated: Generate updated swagger files

2022-12-15 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 33dec165762 Generate updated swagger files 33dec

[pulsar-site] branch main updated: Regenerate swagger files

2022-12-15 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 6f796283e6b Regenerate swagger files 6f796283e6b

[GitHub] [pulsar-site] tisonkun opened a new pull request, #338: Reuse workflows

2022-12-15 Thread GitBox
tisonkun opened a new pull request, #338: URL: https://github.com/apache/pulsar-site/pull/338 Signed-off-by: tison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pulsar] codecov-commenter commented on pull request #18937: [fix][client-admin] Fix the conversion from the response to string in client error handling

2022-12-15 Thread GitBox
codecov-commenter commented on PR #18937: URL: https://github.com/apache/pulsar/pull/18937#issuecomment-1353228510 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/18937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [pulsar] tisonkun commented on pull request #18021: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944

2022-12-15 Thread GitBox
tisonkun commented on PR #18021: URL: https://github.com/apache/pulsar/pull/18021#issuecomment-1353231067 @nicoloboschi @eolivelli I'm pretty curious where we have a dependency on scala-library explicitly or transitively, lol. -- This is an automated message from the Apache Git Service. T

[GitHub] [pulsar-site] tisonkun commented on pull request #338: Reuse workflows

2022-12-15 Thread GitBox
tisonkun commented on PR #338: URL: https://github.com/apache/pulsar-site/pull/338#issuecomment-1353235579 Maven compile can meet StackOverflowError sometimes. Any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] congbobo184 opened a new pull request, #18943: [fix][txn] transaction pending ack store future not completely problem

2022-12-15 Thread GitBox
congbobo184 opened a new pull request, #18943: URL: https://github.com/apache/pulsar/pull/18943 ### Motivation when `MLPendingAckStoreProvider` init PendingAckStore gets the ManagedLedger config throw exception, we don't handle the exception. and the `pendingAckStoreFeture` can't be

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#3011946)

2022-12-15 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new b8d882cd50a Docs sync done from apache/pulsar (

[GitHub] [pulsar] nicoloboschi commented on pull request #18021: [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944

2022-12-15 Thread GitBox
nicoloboschi commented on PR #18021: URL: https://github.com/apache/pulsar/pull/18021#issuecomment-1353259325 > @nicoloboschi @eolivelli I'm pretty curious where we have a dependency on scala-library explicitly or transitively, lol. Kafka uses scala and kafka is used in the debezium c

[GitHub] [pulsar-client-cpp] erobot opened a new pull request, #146: [fix] Use authoritative argument correctly in BinaryProtoLookupService::findBroker

2022-12-15 Thread GitBox
erobot opened a new pull request, #146: URL: https://github.com/apache/pulsar-client-cpp/pull/146 ### Motivation Use authoritative argument correctly in BinaryProtoLookupService::findBroker. In the current code, authoritative field of lookup request is always false. When a bund

[GitHub] [pulsar-client-cpp] shibd commented on issue #123: Add the release process

2022-12-15 Thread GitBox
shibd commented on issue #123: URL: https://github.com/apache/pulsar-client-cpp/issues/123#issuecomment-1353282279 > I read we have https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide now. I think we should maintain it in the repository. like node js client: htt

[GitHub] [pulsar-client-cpp] erobot commented on pull request #146: [fix] Use authoritative argument correctly in BinaryProtoLookupService::findBroker

2022-12-15 Thread GitBox
erobot commented on PR #146: URL: https://github.com/apache/pulsar-client-cpp/pull/146#issuecomment-1353294015 There is a related pr #129 about lookup redirect limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar-client-cpp] shibd opened a new pull request, #147: Support table view.

2022-12-15 Thread GitBox
shibd opened a new pull request, #147: URL: https://github.com/apache/pulsar-client-cpp/pull/147 Master Issue: #89 ### Motivation #89 ### Modifications 1. When the reader call `getLastMessageId`, If `lastMessageid` of the reader is batch and batch size is 1, the

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18937: [fix][client-admin] Fix the conversion from the response to string in client error handling

2022-12-15 Thread GitBox
congbobo184 commented on code in PR #18937: URL: https://github.com/apache/pulsar/pull/18937#discussion_r1049804716 ## pulsar-client-admin/src/test/java/org/apache/pulsar/client/admin/internal/BaseResourceTest.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [pulsar-client-cpp] tisonkun commented on issue #123: Add the release process

2022-12-15 Thread GitBox
tisonkun commented on issue #123: URL: https://github.com/apache/pulsar-client-cpp/issues/123#issuecomment-1353343591 @shibd Yes. My concern can be added one here: we should still think of 2.8~2.11 until their end of life. -- This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #911: [build] update go version to 1.18

2022-12-15 Thread GitBox
pgier commented on code in PR #911: URL: https://github.com/apache/pulsar-client-go/pull/911#discussion_r1049890597 ## README.md: ## @@ -36,7 +36,9 @@ CGo based library. ## Requirements -- Go 1.15+ +- Go 1.18+ Review Comment: Why would you append spaces here? -- Thi

[GitHub] [pulsar] eolivelli closed issue #18866: pulsar-perf: improve error message for unrecognized options

2022-12-15 Thread GitBox
eolivelli closed issue #18866: pulsar-perf: improve error message for unrecognized options URL: https://github.com/apache/pulsar/issues/18866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] eolivelli merged pull request #18889: [improve][cli] pulsar-perf: check for invalid CLI options

2022-12-15 Thread GitBox
eolivelli merged PR #18889: URL: https://github.com/apache/pulsar/pull/18889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar] branch master updated (3011946a5c3 -> b1f9e351fa4)

2022-12-15 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 3011946a5c3 [fix][sec] Upgrade scala-library to get rid of CVE-2022-36944 (#18021) add b1f9e351fa4 [improve][

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#3011946)

2022-12-15 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new feb64fe6174 Docs sync done from apache/pulsar (

[GitHub] [pulsar-site] lhotari opened a new pull request, #339: Update Pulsar PMC members and committers to website

2022-12-15 Thread GitBox
lhotari opened a new pull request, #339: URL: https://github.com/apache/pulsar-site/pull/339 Synchronize team.js with https://whimsy.apache.org/roster/committee/pulsar.json . Downloading requires authentication with Apache ID and that's why it doesn't make sense to automate it further atm.

[GitHub] [pulsar-site] lhotari commented on pull request #339: Update Pulsar PMC members and committers to website

2022-12-15 Thread GitBox
lhotari commented on PR #339: URL: https://github.com/apache/pulsar-site/pull/339#issuecomment-1353506914 Preview of community page changes: ![image](https://user-images.githubusercontent.com/66864/207935334-820e67de-15c6-437d-8683-ec59274e094e.png) -- This is an automated message

[pulsar-site] branch main updated (feb64fe6174 -> ee3ae44c9ee)

2022-12-15 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from feb64fe6174 Docs sync done from apache/pulsar (#3011946) add ee3ae44c9ee Docs sync done from apache/pulsar (#b

[GitHub] [pulsar-site] lhotari commented on a diff in pull request #338: Reuse workflows

2022-12-15 Thread GitBox
lhotari commented on code in PR #338: URL: https://github.com/apache/pulsar-site/pull/338#discussion_r1049992454 ## .github/workflows/ci-precommit.yml: ## @@ -32,3 +30,17 @@ jobs: - uses: apache/skywalking-eyes/header@main with: config: tools/ci/licens

[GitHub] [pulsar-site] lhotari commented on pull request #338: Reuse workflows

2022-12-15 Thread GitBox
lhotari commented on PR #338: URL: https://github.com/apache/pulsar-site/pull/338#issuecomment-1353517465 > Maven compile can meet StackOverflowError sometimes. Any thoughts? > > For example https://github.com/apache/pulsar-site/actions/runs/3705285707/jobs/6279000910 @tisonkun

[GitHub] [pulsar-site] michaeljmarshall commented on a diff in pull request #339: Update Pulsar PMC members and committers to website

2022-12-15 Thread GitBox
michaeljmarshall commented on code in PR #339: URL: https://github.com/apache/pulsar-site/pull/339#discussion_r1050008619 ## site2/website-next/src/pages/community.js: ## @@ -521,7 +521,7 @@ export default function Community(props) { Meet the C

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18943: [fix][txn] transaction pending ack store future not completely problem

2022-12-15 Thread GitBox
poorbarcode commented on code in PR #18943: URL: https://github.com/apache/pulsar/pull/18943#discussion_r1049988089 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -975,11 +975,29 @@ public TransactionInPending

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18943: [fix][txn] transaction pending ack store future not completely problem

2022-12-15 Thread GitBox
poorbarcode commented on code in PR #18943: URL: https://github.com/apache/pulsar/pull/18943#discussion_r1050008717 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -178,7 +180,7 @@ private void initPendingAckSt

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18943: [fix][txn] transaction pending ack store future not completely problem

2022-12-15 Thread GitBox
poorbarcode commented on code in PR #18943: URL: https://github.com/apache/pulsar/pull/18943#discussion_r1050008717 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -178,7 +180,7 @@ private void initPendingAckSt

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18943: [fix][txn] transaction pending ack store future not completely problem

2022-12-15 Thread GitBox
poorbarcode commented on code in PR #18943: URL: https://github.com/apache/pulsar/pull/18943#discussion_r1050008717 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -178,7 +180,7 @@ private void initPendingAckSt

[GitHub] [pulsar] pgier opened a new issue, #18945: pulsar CLI tools should return exit code 1 instead of -1 on error

2022-12-15 Thread GitBox
pgier opened a new issue, #18945: URL: https://github.com/apache/pulsar/issues/18945 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation The pulsar CLI seems to be inconsistent w

[GitHub] [pulsar-site] lhotari merged pull request #339: Update Pulsar PMC members and committers to website

2022-12-15 Thread GitBox
lhotari merged PR #339: URL: https://github.com/apache/pulsar-site/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar-site] lhotari commented on a diff in pull request #339: Update Pulsar PMC members and committers to website

2022-12-15 Thread GitBox
lhotari commented on code in PR #339: URL: https://github.com/apache/pulsar-site/pull/339#discussion_r1050026858 ## site2/website-next/src/pages/community.js: ## @@ -521,7 +521,7 @@ export default function Community(props) { Meet the Community

[pulsar-site] branch main updated: Update Pulsar PMC members and committers to website (#339)

2022-12-15 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new d515371a5a5 Update Pulsar PMC members and comm

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#b1f9e35)

2022-12-15 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 22f11e47f8f Docs sync done from apache/pulsar (

[GitHub] [pulsar] pgier opened a new pull request, #18946: [improve][cli] pulsar cli: use return code 1 for general error

2022-12-15 Thread GitBox
pgier opened a new pull request, #18946: URL: https://github.com/apache/pulsar/pull/18946 Return code -1 is generally considered to be an invalid code. https://tldp.org/LDP/abs/html/exitcodes.html Replace return code -1 with 1 which is commonly used as a general error. Signed-off-b

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #18807: [fix][monitor] Fix a partitioned publisher topic stat aggregation bug

2022-12-15 Thread GitBox
heesung-sn commented on code in PR #18807: URL: https://github.com/apache/pulsar/pull/18807#discussion_r1050174671 ## pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java: ## @@ -252,19 +253,15 @@ public TopicStatsImpl add(TopicStats ts) {

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #338: Reuse workflows

2022-12-15 Thread GitBox
tisonkun commented on code in PR #338: URL: https://github.com/apache/pulsar-site/pull/338#discussion_r1050201936 ## .github/workflows/ci-precommit.yml: ## @@ -32,3 +30,17 @@ jobs: - uses: apache/skywalking-eyes/header@main with: config: tools/ci/licen

[GitHub] [pulsar-site] tisonkun commented on pull request #338: Reuse workflows

2022-12-15 Thread GitBox
tisonkun commented on PR #338: URL: https://github.com/apache/pulsar-site/pull/338#issuecomment-1353801193 > Add -Xss1500k to MAVEN_OPTS. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#b1f9e35)

2022-12-15 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 0908afad691 Docs sync done from apache/pulsar (

[GitHub] [pulsar] tisonkun opened a new issue, #18947: Unstable swagger output

2022-12-15 Thread GitBox
tisonkun opened a new issue, #18947: URL: https://github.com/apache/pulsar/issues/18947 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation After running: ```bash mvn -

  1   2   >