[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #493: [improve][doc] Optimize Admin API > Features > Brokers

2023-03-27 Thread via GitHub
momo-jun commented on code in PR #493: URL: https://github.com/apache/pulsar-site/pull/493#discussion_r1150112037 ## docs/admin-api-brokers.md: ## @@ -87,39 +69,53 @@ Fetch the information of the leader broker, for example, the service url. ```shell -pulsar-admin brokers l

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #493: [improve][doc] Optimize Admin API > Features > Brokers

2023-03-27 Thread via GitHub
momo-jun commented on code in PR #493: URL: https://github.com/apache/pulsar-site/pull/493#discussion_r1150109373 ## docs/admin-api-brokers.md: ## @@ -87,39 +69,53 @@ Fetch the information of the leader broker, for example, the service url. ```shell -pulsar-admin brokers l

[GitHub] [pulsar] StevenLuMT commented on pull request #19926: [fix][test] final shutdown executor in main

2023-03-27 Thread via GitHub
StevenLuMT commented on PR #19926: URL: https://github.com/apache/pulsar/pull/19926#issuecomment-1486301696 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[pulsar-site] branch main updated: [improve][doc] clarify usage for metadataStoreUrl (#492)

2023-03-27 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 61a3fc691fe [improve][doc] clarify usage for metad

[GitHub] [pulsar-site] BewareMyPower merged pull request #492: [improve][doc] clarify usage for metadataStoreUrl

2023-03-27 Thread via GitHub
BewareMyPower merged PR #492: URL: https://github.com/apache/pulsar-site/pull/492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

[GitHub] [pulsar] BewareMyPower closed issue #19920: [Doc] Deploy on bare metal doc is having wrong URL format for metadataStoreUrl and configurationMetadataStoreUrl

2023-03-27 Thread via GitHub
BewareMyPower closed issue #19920: [Doc] Deploy on bare metal doc is having wrong URL format for metadataStoreUrl and configurationMetadataStoreUrl URL: https://github.com/apache/pulsar/issues/19920 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pulsar-site] Anonymitaet commented on pull request #493: [improve][doc] Optimize Admin API > Features > Brokers

2023-03-27 Thread via GitHub
Anonymitaet commented on PR #493: URL: https://github.com/apache/pulsar-site/pull/493#issuecomment-1486285046 @BewareMyPower Could you please review this PR from a technical perspective? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar-site] Anonymitaet commented on pull request #493: [improve][doc] Optimize Admin API > Features > Brokers

2023-03-27 Thread via GitHub
Anonymitaet commented on PR #493: URL: https://github.com/apache/pulsar-site/pull/493#issuecomment-1486273567 Previews look good: https://user-images.githubusercontent.com/50226895/228142620-476c2668-5ef9-4628-a70f-5c42fdbd4f68.png";> https://user-images.githubusercontent.com/50

[GitHub] [pulsar] lhotari commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
lhotari commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1486267320 > It seems that we don't create the coverage file. It may be a workflow bug. @tisonkun that's right. there seems to be an issue in that. -- This is an automated message from

[GitHub] [pulsar] poorbarcode commented on pull request #19942: [fix] [admin] fix incorrect state replication.connected on API partitioned-topic stat

2023-03-27 Thread via GitHub
poorbarcode commented on PR #19942: URL: https://github.com/apache/pulsar/pull/19942#issuecomment-1486266304 > It seems that line-298 also needs to be changed. fixed, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #493: [improve][doc] Optimize Admin API > Features > Brokers

2023-03-27 Thread via GitHub
Anonymitaet opened a new pull request, #493: URL: https://github.com/apache/pulsar-site/pull/493 ## What issues does this PR solve? There are some issues in the current [Admin API > Features > Brokers](https://pulsar.apache.org/docs/next/admin-api-clusters/) doc. I’ve summarized them

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #487: [improve][doc] Relocate client config links and refresh client API doc links

2023-03-27 Thread via GitHub
momo-jun commented on code in PR #487: URL: https://github.com/apache/pulsar-site/pull/487#discussion_r1150060040 ## docs/client-libraries-java.md: ## @@ -29,12 +29,12 @@ The following table outlines the API packages and reference docs for Pulsar Java Package | Description |

[GitHub] [pulsar] poorbarcode commented on pull request #19942: [fix] [admin] fix incorrect state replication.connected on API partitioned-topic stat

2023-03-27 Thread via GitHub
poorbarcode commented on PR #19942: URL: https://github.com/apache/pulsar/pull/19942#issuecomment-1486246896 Hi @gaoran10 > I'm not sure why need to use the symbol &, if the metric change to false, it will always be false, maybe we can use the latest value directly. Good idea,

[GitHub] [pulsar] tisonkun commented on pull request #19926: [fix][test] final shutdown executor in main

2023-03-27 Thread via GitHub
tisonkun commented on PR #19926: URL: https://github.com/apache/pulsar/pull/19926#issuecomment-1486246086 @StevenLuMT it seems test failed steadily. Please check locally: ``` Error: Tests run: 25, Failures: 1, Errors: 0, Skipped: 21, Time elapsed: 88.413 s <<< FAILURE! - in org.

[GitHub] [pulsar] heesung-sn opened a new pull request, #19945: [improve][broker] PIP-192 updated metrics and cleanup broker selector

2023-03-27 Thread via GitHub
heesung-sn opened a new pull request, #19945: URL: https://github.com/apache/pulsar/pull/19945 Master Issue: https://github.com/apache/pulsar/issues/16691 ### Motivation Raising a PR to implement: https://github.com/apache/pulsar/issues/16691 ### M

[GitHub] [pulsar] lhotari commented on pull request #19777: [fix][broker] Fix RetentionPolicies constructor

2023-03-27 Thread via GitHub
lhotari commented on PR #19777: URL: https://github.com/apache/pulsar/pull/19777#issuecomment-1486226202 > > Was this just reverting #18112? > > Revert #18114, and change the `retentionSizeInMB` type to` long` from `int` in the constructor of `RetentionPolicies`. @nodece What's

[GitHub] [pulsar] heesung-sn commented on pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-27 Thread via GitHub
heesung-sn commented on PR #19813: URL: https://github.com/apache/pulsar/pull/19813#issuecomment-1486216393 @Demogorgon314 can we merge this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] Anonymitaet commented on issue #19920: [Doc] Deploy on bare metal doc is having wrong URL format for metadataStoreUrl and configurationMetadataStoreUrl

2023-03-27 Thread via GitHub
Anonymitaet commented on issue #19920: URL: https://github.com/apache/pulsar/issues/19920#issuecomment-1486205683 @BewareMyPower thank you! Fix in https://github.com/apache/pulsar-site/pull/492, PTAL/ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #492: [improve][doc] clarify usage for metadataStoreUrl

2023-03-27 Thread via GitHub
Anonymitaet opened a new pull request, #492: URL: https://github.com/apache/pulsar-site/pull/492 Fix https://github.com/apache/pulsar/issues/19920 - [x] `doc` cc @D-2-Ed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] jiangpengcheng commented on pull request #19895: [fix][fn] Fix function update error

2023-03-27 Thread via GitHub
jiangpengcheng commented on PR #19895: URL: https://github.com/apache/pulsar/pull/19895#issuecomment-1486202956 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #228: [fix] Consumer batch receive will cause data loss.

2023-03-27 Thread via GitHub
BewareMyPower commented on code in PR #228: URL: https://github.com/apache/pulsar-client-cpp/pull/228#discussion_r1150009935 ## lib/ConsumerImpl.cc: ## @@ -649,10 +649,11 @@ void ConsumerImpl::executeNotifyCallback(Message& msg) { void ConsumerImpl::notifyBatchPendingReceivedCa

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #487: [improve][doc] Relocate client config links and refresh client API doc links

2023-03-27 Thread via GitHub
Anonymitaet commented on code in PR #487: URL: https://github.com/apache/pulsar-site/pull/487#discussion_r1150009200 ## docs/client-libraries-java.md: ## @@ -29,12 +29,12 @@ The following table outlines the API packages and reference docs for Pulsar Java Package | Descriptio

[GitHub] [pulsar] gaoran10 commented on pull request #19942: [fix] [admin] fix incorrect state replication.connected on API partitioned-topic stat

2023-03-27 Thread via GitHub
gaoran10 commented on PR #19942: URL: https://github.com/apache/pulsar/pull/19942#issuecomment-1486193506 I'm not sure why need to use the symbol `&`, if the metric change to `false`, it will always be false. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-27 Thread via GitHub
Anonymitaet commented on code in PR #490: URL: https://github.com/apache/pulsar-site/pull/490#discussion_r1150004075 ## docs/admin-api-clusters.md: ## @@ -9,37 +9,43 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; - :::tip - This page only sh

[GitHub] [pulsar] coderzc commented on pull request #19942: [fix] [admin] fix incorrect state replication.connected on API partitioned-topic stat

2023-03-27 Thread via GitHub
coderzc commented on PR #19942: URL: https://github.com/apache/pulsar/pull/19942#issuecomment-1486175193 It seems that line-298 also needs to be changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-site] hangc0276 commented on a diff in pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-27 Thread via GitHub
hangc0276 commented on code in PR #490: URL: https://github.com/apache/pulsar-site/pull/490#discussion_r1150001244 ## docs/admin-api-clusters.md: ## @@ -9,37 +9,43 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; - :::tip - This page only show

[GitHub] [pulsar] tisonkun closed issue #19914: [Doc] A bunch of empty doc files created unexpectedly and distract the site search

2023-03-27 Thread via GitHub
tisonkun closed issue #19914: [Doc] A bunch of empty doc files created unexpectedly and distract the site search URL: https://github.com/apache/pulsar/issues/19914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] tisonkun commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
tisonkun commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1486171308 @yaalsn I guess the following steps in the current workflow is already run `always`: https://github.com/apache/pulsar/blob/d14e43ed9bd079b76301f10dc1c039cafd43e1cf/.github/w

[GitHub] [pulsar-site] tisonkun commented on pull request #491: [cleanup][doc] Remove unexpectedly created doc files

2023-03-27 Thread via GitHub
tisonkun commented on PR #491: URL: https://github.com/apache/pulsar-site/pull/491#issuecomment-1486172820 Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[pulsar-site] branch main updated (0b6b56d2c4f -> c84ead0846a)

2023-03-27 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 0b6b56d2c4f [fix] Markdown links add c84ead0846a [cleanup][doc] Remove unexpectedly created doc files (#491) N

[GitHub] [pulsar-site] tisonkun merged pull request #491: [cleanup][doc] Remove unexpectedly created doc files

2023-03-27 Thread via GitHub
tisonkun merged PR #491: URL: https://github.com/apache/pulsar-site/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar-site] tisonkun commented on pull request #491: [cleanup][doc] Remove unexpectedly created doc files

2023-03-27 Thread via GitHub
tisonkun commented on PR #491: URL: https://github.com/apache/pulsar-site/pull/491#issuecomment-1486172271 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [pulsar] yaalsn commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
yaalsn commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1486166414 Could we use `continue-on-error` for the flaky test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-27 Thread via GitHub
Anonymitaet commented on code in PR #490: URL: https://github.com/apache/pulsar-site/pull/490#discussion_r1149984734 ## docs/admin-api-clusters.md: ## @@ -9,37 +9,43 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; - :::tip - This page only sh

[GitHub] [pulsar] jiangpengcheng commented on pull request #19895: [fix][fn] Fix function update error

2023-03-27 Thread via GitHub
jiangpengcheng commented on PR #19895: URL: https://github.com/apache/pulsar/pull/19895#issuecomment-1486157458 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
tisonkun commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1486152906 It seems that we don't create the coverage file. It may be a workflow bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-27 Thread via GitHub
Anonymitaet commented on code in PR #490: URL: https://github.com/apache/pulsar-site/pull/490#discussion_r1149984734 ## docs/admin-api-clusters.md: ## @@ -9,37 +9,43 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; - :::tip - This page only sh

[GitHub] [pulsar] tisonkun commented on issue #19484: [Bug] pulsar-client-all 2.11.0 transitively bringing in log4j2 implementation

2023-03-27 Thread via GitHub
tisonkun commented on issue #19484: URL: https://github.com/apache/pulsar/issues/19484#issuecomment-1486148389 Fixed and cherry-picked to 2.11 at 2d8af31007a94c8c126b77333188b8a98a2a37cf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar] branch branch-2.11 updated: [improve][client] Exclude log4j-slf4j-impl from compile dep in pulsar-client-all (#19937)

2023-03-27 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 2d8af31007a [improve][client] Exclude l

[pulsar] branch master updated (32ad9060606 -> d14e43ed9bd)

2023-03-27 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 32ad9060606 [fix][admin] Delete tenant local policy only if exist (#19925) add d14e43ed9bd [improve][client] Excl

[GitHub] [pulsar] tisonkun closed issue #19484: [Bug] pulsar-client-all 2.11.0 transitively bringing in log4j2 implementation

2023-03-27 Thread via GitHub
tisonkun closed issue #19484: [Bug] pulsar-client-all 2.11.0 transitively bringing in log4j2 implementation URL: https://github.com/apache/pulsar/issues/19484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] tisonkun merged pull request #19937: [improve][client] Exclude log4j-slf4j-impl from compile dep in pulsar-client-all

2023-03-27 Thread via GitHub
tisonkun merged PR #19937: URL: https://github.com/apache/pulsar/pull/19937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar] tisonkun commented on pull request #19937: [improve][client] Exclude log4j-slf4j-impl from compile dep in pulsar-client-all

2023-03-27 Thread via GitHub
tisonkun commented on PR #19937: URL: https://github.com/apache/pulsar/pull/19937#issuecomment-1486147106 Merging.. After we upgrade to BK 4.16.0, we can revisit this issue and do some cleanups. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lifepuzzlefun commented on pull request #19929: [fix][client] Cache empty schema version in ProducerImpl schemaCache.

2023-03-27 Thread via GitHub
lifepuzzlefun commented on PR #19929: URL: https://github.com/apache/pulsar/pull/19929#issuecomment-1486130249 @BewareMyPower @poorbarcode @Technoboy- can you take a look ? this is a problem occur on master code and in our prod environment. -- This is an automated message from the Apache

[GitHub] [pulsar] jiangpengcheng commented on issue #19721: [Bug] Cannot update Pulsar function in Pulsar standalone

2023-03-27 Thread via GitHub
jiangpengcheng commented on issue #19721: URL: https://github.com/apache/pulsar/issues/19721#issuecomment-1486122499 > > Use file path for `--py|--go|--jar`, and set `functionsWorkerEnablePackageManagement` to true in `conf/broker.conf` > > I have tried package management and never go

[GitHub] [pulsar] jiangpengcheng commented on pull request #19896: [fix][fn] Fix JavaInstanceStarter inferring type class name error

2023-03-27 Thread via GitHub
jiangpengcheng commented on PR #19896: URL: https://github.com/apache/pulsar/pull/19896#issuecomment-1486112728 > @jiangpengcheng Could you add more details for the actual modifications you made in this PR? Sure, Updated -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] StevenLuMT commented on pull request #19926: [fix][test] final shutdown executor in main

2023-03-27 Thread via GitHub
StevenLuMT commented on PR #19926: URL: https://github.com/apache/pulsar/pull/19926#issuecomment-148641 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar-site] hangc0276 commented on a diff in pull request #490: [improve][doc] Optimize "Admin API > Features > Clusters"

2023-03-27 Thread via GitHub
hangc0276 commented on code in PR #490: URL: https://github.com/apache/pulsar-site/pull/490#discussion_r1149949982 ## docs/admin-api-clusters.md: ## @@ -9,37 +9,43 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; - :::tip - This page only show

[GitHub] [pulsar] github-actions[bot] commented on issue #19493: [Bug] topicsPattern cannot subscribe to non-persistent topics

2023-03-27 Thread via GitHub
github-actions[bot] commented on issue #19493: URL: https://github.com/apache/pulsar/issues/19493#issuecomment-1486095323 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] rdhabalia opened a new pull request, #19944: [improve][client] Pulsar client supports multi-topic messageId deserialization to ack messages

2023-03-27 Thread via GitHub
rdhabalia opened a new pull request, #19944: URL: https://github.com/apache/pulsar/pull/19944 ### Motivation Right now, when user tries to serialize messageId and deserialize messageId for a partitioned-topic and lacks the message then it fails with the below exception. ``` org

[GitHub] [pulsar-helm-chart] chrisjohnson00 opened a new pull request, #356: fix: proxy should not use priviledged port numbers

2023-03-27 Thread via GitHub
chrisjohnson00 opened a new pull request, #356: URL: https://github.com/apache/pulsar-helm-chart/pull/356 This fixes issue #335 ### Motivation Fixing the port 80 binding issue in issue #335 ### Modifications Changed from port 80 -> 8080 for HTTP and 443 -> 8443 fo

[GitHub] [pulsar-helm-chart] chrisjohnson00 commented on issue #335: Proxy fails to connect to port 80

2023-03-27 Thread via GitHub
chrisjohnson00 commented on issue #335: URL: https://github.com/apache/pulsar-helm-chart/issues/335#issuecomment-1486036408 Interesting note here... I have a 4 node cluster (home lab) 3/4 nodes are running containerd, the 4th is running docker. The proxy which scheduled to the d

[GitHub] [pulsar] dlg99 commented on a diff in pull request #19923: [improve][io] KCA: option to collapse partitioned topics

2023-03-27 Thread via GitHub
dlg99 commented on code in PR #19923: URL: https://github.com/apache/pulsar/pull/19923#discussion_r1149904332 ## pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java: ## @@ -417,8 +421,19 @@ static BatchMessageSequenceRef getMes

[GitHub] [pulsar] nlu90 commented on pull request #19895: [fix][fn] Fix function update error

2023-03-27 Thread via GitHub
nlu90 commented on PR #19895: URL: https://github.com/apache/pulsar/pull/19895#issuecomment-1486007490 Without this fix, when users update a function with the new jar, py or go binary, they will get the following error: ``` ➜ apache-pulsar-2.11.0 ./bin/pulsar-admin functions update \

[GitHub] [pulsar] nlu90 commented on pull request #19896: [fix][fn] Fix JavaInstanceStarter inferring type class name error

2023-03-27 Thread via GitHub
nlu90 commented on PR #19896: URL: https://github.com/apache/pulsar/pull/19896#issuecomment-1486005012 @jiangpengcheng Could you add more details for the actual modifications you made in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pulsar] nlu90 commented on pull request #19897: [fix][fn] Make pulsar-admin support update py/go with package url

2023-03-27 Thread via GitHub
nlu90 commented on PR #19897: URL: https://github.com/apache/pulsar/pull/19897#issuecomment-1486004248 @codelipenghui Can we backport this fix to 2.10? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] michaeljmarshall commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-27 Thread via GitHub
michaeljmarshall commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1485793683 The following works: ``` curl --cacert /run/secrets/kubernetes.io/serviceaccount/ca.crt \ -H "Authorization: Bearer $(cat /run/secrets/kubernetes.io/service

[GitHub] [pulsar] michaeljmarshall commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-27 Thread via GitHub
michaeljmarshall commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1485791233 After additional checks, looks like this call consistently fails when no authentication is provided: ``` $ curl -k https://kubernetes.default.svc/.well-known/openid-co

[GitHub] [pulsar] lhotari commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
lhotari commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1485749362 > Upstream issue - https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954 > > @lhotari @BewareMyPower @yaalsn shall we remove/disable

[GitHub] [pulsar] lhotari commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
lhotari commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1485747423 > My personal answer is to remove it. Let's discuss the resolution on the mailing list since there's better context. Moving the upload to a separate step is a better solution.

[GitHub] [pulsar-client-cpp] JTBS opened a new issue, #234: [feat][cpp-client] PIP-145: Notifications for faster topic discovery - already implemented in Java client but not yet in C++?

2023-03-27 Thread via GitHub
JTBS opened a new issue, #234: URL: https://github.com/apache/pulsar-client-cpp/issues/234 Hi, Any idea if this already implemented feature from JAVA client is implemented in C++ client also? https://github.com/apache/pulsar/issues/14505 https://github.com/apache/pulsar/pull/16062/f

[GitHub] [pulsar] vpeddada opened a new issue, #19943: TLS mutual Authentication with PEM configuration fails to establish a successful connection

2023-03-27 Thread via GitHub
vpeddada opened a new issue, #19943: URL: https://github.com/apache/pulsar/issues/19943 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version Java Client(2.10.2)-->broker(2.11.0) B

[GitHub] [pulsar] nodece commented on pull request #19777: [fix][broker] Fix RetentionPolicies constructor

2023-03-27 Thread via GitHub
nodece commented on PR #19777: URL: https://github.com/apache/pulsar/pull/19777#issuecomment-1485691610 > Was this just reverting #18112? Revert https://github.com/apache/pulsar/pull/18114, and change the `retentionSizeInMB` type to` long` from `int` in the constructor of `RetentionP

[GitHub] [pulsar] michaeljmarshall commented on pull request #19777: [fix][broker] Fix RetentionPolicies constructor

2023-03-27 Thread via GitHub
michaeljmarshall commented on PR #19777: URL: https://github.com/apache/pulsar/pull/19777#issuecomment-1485644155 Was this just reverting https://github.com/apache/pulsar/issues/18112? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pulsar] branch branch-2.10 updated: [fix] [proxy] Used in proxyConf file when configuration is missing in the command line (#15938)

2023-03-27 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 26fd7162284 [fix] [proxy] Used in prox

[GitHub] [pulsar] poorbarcode opened a new pull request, #19942: [fix] [admin] fix incorrect state replication.connected on API partitioned-topic stat

2023-03-27 Thread via GitHub
poorbarcode opened a new pull request, #19942: URL: https://github.com/apache/pulsar/pull/19942 ### Motivation Pulsar will merge the variable `PartitionedTopicStatsImpl.replication[x].connected` by the way below when we call `pulsar-admin topics partitioned-stats` ``` java

[GitHub] [pulsar] BewareMyPower opened a new issue, #19941: [Doc] Swagger generated wrong API docs because of the Jackson annotation

2023-03-27 Thread via GitHub
BewareMyPower opened a new issue, #19941: URL: https://github.com/apache/pulsar/issues/19941 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? Recen

[GitHub] [pulsar] asafm commented on issue #19912: PIP-261: Restructure Getting Started section

2023-03-27 Thread via GitHub
asafm commented on issue #19912: URL: https://github.com/apache/pulsar/issues/19912#issuecomment-1485347249 Thanks for the feedback @momo-jun. From the looks of it, the doc website allows 2 depth level, that means the left pane will have: Getting Started Guide - Consume and P

[GitHub] [pulsar] tisonkun added a comment to the discussion: [Bug] boot broker failed with etcd

2023-03-27 Thread GitBox
GitHub user tisonkun added a comment to the discussion: [Bug] boot broker failed with etcd It will be nice if you can make a minimal repro e.g. with docker-compose. Otherwise, it's more possible an env issue. GitHub link: https://github.com/apache/pulsar/discussions/19940#discussioncomment-

[GitHub] [pulsar] tisonkun added a comment to the discussion: [Bug] boot broker failed with etcd

2023-03-27 Thread GitBox
GitHub user tisonkun added a comment to the discussion: [Bug] boot broker failed with etcd @elysian-gc do you still suffer from this issue? It reads like a usage issue than a bug. The error log indicates that you configure the port as `-1`. I run a three processes etcd cluster and connect t

[GitHub] [pulsar] Shoothzj commented on pull request #19937: [improve][client] Exclude log4j-slf4j-impl from compile dep in pulsar-client-all

2023-03-27 Thread via GitHub
Shoothzj commented on PR #19937: URL: https://github.com/apache/pulsar/pull/19937#issuecomment-1485328984 sorry for my late reply. @eolivelli @tisonkun I have submit a PR for review https://github.com/apache/bookkeeper/pull/3892. I verified the module doesn't contains log4j dependency. An

[GitHub] [pulsar] github-actions[bot] added a comment to the discussion: [Bug] boot broker failed with etcd

2023-03-27 Thread GitBox
GitHub user github-actions[bot] added a comment to the discussion: [Bug] boot broker failed with etcd The issue had no activity for 30 days, mark with Stale label. GitHub link: https://github.com/apache/pulsar/discussions/19940#discussioncomment-5442774 This is an automatically sent em

[GitHub] [pulsar] tisonkun closed issue #18942: [Bug] boot broker failed with etcd

2023-03-27 Thread via GitHub
tisonkun closed issue #18942: [Bug] boot broker failed with etcd URL: https://github.com/apache/pulsar/issues/18942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [pulsar] nodece commented on issue #19921: [Bug] Deleting a tenant results in a HTTP 500 error, but deletes the tenant

2023-03-27 Thread via GitHub
nodece commented on issue #19921: URL: https://github.com/apache/pulsar/issues/19921#issuecomment-1485317650 See https://github.com/apache/pulsar/commit/8d6afbaf473a51e8651fb4106f0b426b4e563ec0 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] tisonkun commented on issue #19921: [Bug] Deleting a tenant results in a HTTP 500 error, but deletes the tenant

2023-03-27 Thread via GitHub
tisonkun commented on issue #19921: URL: https://github.com/apache/pulsar/issues/19921#issuecomment-1485310206 @nodece you will or have done? If it's the latter, could you refer to the PR or commit? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] tisonkun commented on pull request #19937: [improve][client] Exclude log4j-slf4j-impl from compile dep in pulsar-client-all

2023-03-27 Thread via GitHub
tisonkun commented on PR #19937: URL: https://github.com/apache/pulsar/pull/19937#issuecomment-1485306446 > would you fix it also in bookkeeper ? I'm glad to do so. But updating dependencies can be tricky. I have a conversation with @Shoothzj and he has some ideas to improve the overa

[GitHub] [pulsar] nodece commented on issue #19921: [Bug] Deleting a tenant results in a HTTP 500 error, but deletes the tenant

2023-03-27 Thread via GitHub
nodece commented on issue #19921: URL: https://github.com/apache/pulsar/issues/19921#issuecomment-1485294322 > @Technoboy- maybe we should backport the fix to 2.11.x. Perhaps you can take a look. I cherry-picked #19925 into `branch-2.11`. -- This is an automated message from the Ap

[pulsar] branch branch-2.11 updated: [fix][admin] Delete tenant local policy only if exist (#19925)

2023-03-27 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 8d6afbaf473 [fix][admin] Delete tenant

[GitHub] [pulsar-client-cpp] shibd commented on pull request #207: [feat] Support pattern subscribe non-persistent topic.

2023-03-27 Thread via GitHub
shibd commented on PR #207: URL: https://github.com/apache/pulsar-client-cpp/pull/207#issuecomment-1485265501 > * PIP-258: [PIP-258: Deprecation of the consumer subscribeTopicMode configuration pulsar#19798](https://github.com/apache/pulsar/issues/19798) > * Mail list discussion: https:

svn commit: r60850 [1/2] - in /dev/pulsar/pulsar-2.9.5-candidate-2: ./ connectors/

2023-03-27 Thread zhaocong
Author: zhaocong Date: Mon Mar 27 14:46:28 2023 New Revision: 60850 Log: Staging artifacts and signature for Pulsar release 2.9.5 Added: dev/pulsar/pulsar-2.9.5-candidate-2/ dev/pulsar/pulsar-2.9.5-candidate-2/apache-pulsar-2.9.5-bin.tar.gz (with props) dev/pulsar/pulsar-2.9.5-cand

svn commit: r60850 [2/2] - in /dev/pulsar/pulsar-2.9.5-candidate-2: ./ connectors/

2023-03-27 Thread zhaocong
Added: dev/pulsar/pulsar-2.9.5-candidate-2/connectors/pulsar-io-mongo-2.9.5.nar.asc == --- dev/pulsar/pulsar-2.9.5-candidate-2/connectors/pulsar-io-mongo-2.9.5.nar.asc (added) +++ dev/pulsar/pulsar-2.9.5-candidate-2/con

[GitHub] [pulsar] tisonkun opened a new pull request, #19939: [feat][client] Support configure MessageCrypto in ProducerBuilder

2023-03-27 Thread via GitHub
tisonkun opened a new pull request, #19939: URL: https://github.com/apache/pulsar/pull/19939 This closes https://github.com/apache/pulsar/issues/19139. ### Motivation It's a lightweight feature alignment. Since it somehow touches public API, I don't know if it requires a PIP. I

[GitHub] [pulsar] KamenRiderKuuga commented on issue #19770: [Bug] Topics with slashes cannot be queried

2023-03-27 Thread via GitHub
KamenRiderKuuga commented on issue #19770: URL: https://github.com/apache/pulsar/issues/19770#issuecomment-1485231337 OK, I think I will use the `-` for splitting, thank you very much! Also, the description of these restrictions will be placed in the official documentation, right? -- T

[GitHub] [pulsar] BewareMyPower commented on issue #19931: Please create a coverage file, many PRs failed because of this.

2023-03-27 Thread via GitHub
BewareMyPower commented on issue #19931: URL: https://github.com/apache/pulsar/issues/19931#issuecomment-1485230295 My personal answer is to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] lifepuzzlefun commented on issue #19918: [Bug] Current maven pulsar-client source jar empty

2023-03-27 Thread via GitHub
lifepuzzlefun commented on issue #19918: URL: https://github.com/apache/pulsar/issues/19918#issuecomment-1485230091 the intellj idea IDE default will download this jar. I tried to download many times finally find it is empty. -- This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] tisonkun closed issue #19243: PIP-243: Register Jackson Java 8 support modules by default

2023-03-27 Thread via GitHub
tisonkun closed issue #19243: PIP-243: Register Jackson Java 8 support modules by default URL: https://github.com/apache/pulsar/issues/19243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] tisonkun commented on issue #19243: PIP-243: Register Jackson Java 8 support modules by default

2023-03-27 Thread via GitHub
tisonkun commented on issue #19243: URL: https://github.com/apache/pulsar/issues/19243#issuecomment-1485229779 Closed as implemented - https://github.com/apache/pulsar/pull/19161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] tisonkun added a comment to the discussion: Facilitate Pulsar Shell download and installation

2023-03-27 Thread GitBox
GitHub user tisonkun added a comment to the discussion: Facilitate Pulsar Shell download and installation Since it's more as feature ideas, moved to open-ended discussion before we has a clear plan or volunteers want to figure out how to improve the case. GitHub link: https://github.com/apac

[GitHub] [pulsar] shy-share added a comment to the discussion: Facilitate Pulsar Shell download and installation

2023-03-27 Thread GitBox
GitHub user shy-share added a comment to the discussion: Facilitate Pulsar Shell download and installation @nicoloboschi now only the msi for windows is missing? GitHub link: https://github.com/apache/pulsar/discussions/19938#discussioncomment-5442149 This is an automatically sent emai

[GitHub] [pulsar] tisonkun closed issue #19272: Facilitate Pulsar Shell download and installation

2023-03-27 Thread via GitHub
tisonkun closed issue #19272: Facilitate Pulsar Shell download and installation URL: https://github.com/apache/pulsar/issues/19272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pulsar] github-actions[bot] added a comment to the discussion: Facilitate Pulsar Shell download and installation

2023-03-27 Thread GitBox
GitHub user github-actions[bot] added a comment to the discussion: Facilitate Pulsar Shell download and installation The issue had no activity for 30 days, mark with Stale label. GitHub link: https://github.com/apache/pulsar/discussions/19938#discussioncomment-5442150 This is an automat

[GitHub] [pulsar] BewareMyPower commented on issue #19920: [Doc] Deploy on bare metal doc is having wrong URL format for metadataStoreUrl and configurationMetadataStoreUrl

2023-03-27 Thread via GitHub
BewareMyPower commented on issue #19920: URL: https://github.com/apache/pulsar/issues/19920#issuecomment-1485227747 It was introduced in https://github.com/apache/pulsar/pull/13077 since 2.10, so the answer is YES. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] mattisonchao commented on issue #19770: [Bug] Topics with slashes cannot be queried

2023-03-27 Thread via GitHub
mattisonchao commented on issue #19770: URL: https://github.com/apache/pulsar/issues/19770#issuecomment-1485222598 It should be limited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] tisonkun commented on issue #19770: [Bug] Topics with slashes cannot be queried

2023-03-27 Thread via GitHub
tisonkun commented on issue #19770: URL: https://github.com/apache/pulsar/issues/19770#issuecomment-1485218015 @mattisonchao so do you think that prohibit slashes in topic name is by design or we should support it later? If it should be limited, this issue can be a subtask for #19239

[GitHub] [pulsar] mattisonchao commented on issue #19770: [Bug] Topics with slashes cannot be queried

2023-03-27 Thread via GitHub
mattisonchao commented on issue #19770: URL: https://github.com/apache/pulsar/issues/19770#issuecomment-1485214785 Yes, the topic name should follow the rule as follow: ```java // allowed characters for property, namespace, cluster and topic names are // alphanumeric (a-zA-Z

[GitHub] [pulsar] tisonkun commented on issue #19770: [Bug] Topics with slashes cannot be queried

2023-03-27 Thread via GitHub
tisonkun commented on issue #19770: URL: https://github.com/apache/pulsar/issues/19770#issuecomment-1485196222 > Should I avoid topic names with slashes? Yes for now. IIRC https://github.com/apache/pulsar/issues/19239 makes some topic name restrictions. @mattisonchao maybe you

[GitHub] [pulsar] momo-jun commented on issue #19912: PIP-261: Restructure Getting Started section

2023-03-27 Thread via GitHub
momo-jun commented on issue #19912: URL: https://github.com/apache/pulsar/issues/19912#issuecomment-1485194859 Hi Asaf, thanks for proposing this improvement. Generally it looks good. I support the motivation. Structure-wise, I have a couple of questions. 1. Is it the TOC inside a

[GitHub] [pulsar] tisonkun commented on issue #19921: [Bug] Deleting a tenant results in a HTTP 500 error, but deletes the tenant

2023-03-27 Thread via GitHub
tisonkun commented on issue #19921: URL: https://github.com/apache/pulsar/issues/19921#issuecomment-1485192316 @Technoboy- maybe we should backport the fix to 2.11.x. Perhaps you can take a look. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[pulsar] branch master updated (cda2827acbe -> 32ad9060606)

2023-03-27 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from cda2827acbe [fix][fn] Revert change to deprecation since it broke the master branch (#19904) add 32ad9060606 [fix

[GitHub] [pulsar] tisonkun merged pull request #19925: [fix][admin] Fix delete tenant

2023-03-27 Thread via GitHub
tisonkun merged PR #19925: URL: https://github.com/apache/pulsar/pull/19925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

  1   2   >