Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-07 Thread via GitHub
liangyepianzhou commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751941749 > > I think the main concern is that `get` might be blocking while Pulsar uses the `future.xxxAsync` everywhere and it's dangerous to call a blocking method in the callback o

[PR] [fix][broker] Fix typos in Subscription interface [pulsar]

2023-10-07 Thread via GitHub
hanmz opened a new pull request, #21321: URL: https://github.com/apache/pulsar/pull/21321 ### Motivation Fix some spelling mistakes in Subscription interface ### Modifications Modify the interface name from `isSubsciptionMigrated` to `isSubscriptionMigrated` #

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-07 Thread via GitHub
liangyepianzhou commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751940433 > > This configuration might confuse users. > > I disagree. Assume we added two options: `STRONG_CONSISTENCY_MODEL` and `EVENTUAL_CONSISTENCY_MODEL`), then we'll have: >

Re: [I] [Bug] Segmentation fault occurs at Broker shutdown. [pulsar-client-cpp]

2023-10-07 Thread via GitHub
BewareMyPower commented on issue #324: URL: https://github.com/apache/pulsar-client-cpp/issues/324#issuecomment-1751940030 @shustsud Could you try my patch [here](https://github.com/apache/pulsar-client-cpp/pull/326) to see whether it's fixed? -- This is an automated message from the Ap

[PR] [fix][bk] Fix the var name for IsolationGroups [pulsar]

2023-10-07 Thread via GitHub
AnonHxy opened a new pull request, #21320: URL: https://github.com/apache/pulsar/pull/21320 ### Motivation Fix the var name for IsolationGroups. The name `allBookies` is a little confused. ### Modifications `allBookies` -> `allGroups` ### Verifying this chan

Re: [PR] [fix] [ml] fix wrong msg backlog of non-durable cursor after trim ledgers [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on PR #21250: URL: https://github.com/apache/pulsar/pull/21250#issuecomment-1751930356 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-07 Thread via GitHub
horizonzy commented on PR #21310: URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751928637 @hangc0276 @Technoboy- @poorbarcode Please help to review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-07 Thread via GitHub
codecov-commenter commented on PR #21310: URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751924440 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-07 Thread via GitHub
horizonzy commented on PR #21310: URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751920845 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [Bug] Segmentation fault when sending messages after receiving send error [pulsar-client-cpp]

2023-10-07 Thread via GitHub
BewareMyPower commented on issue #325: URL: https://github.com/apache/pulsar-client-cpp/issues/325#issuecomment-1751914150 Here are the LLDB debug result: ``` Process 15050 stopped * thread #2, stop reason = EXC_BAD_ACCESS (code=1, address=0xbeaddccd09f0) frame #0: 0x

Re: [PR] [fix] [auto-recovery] [branch-2.11] Fix pulsar ledger auditor dead lock problem. [pulsar]

2023-10-07 Thread via GitHub
poorbarcode closed pull request #21319: [fix] [auto-recovery] [branch-2.11] Fix pulsar ledger auditor dead lock problem. URL: https://github.com/apache/pulsar/pull/21319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
poorbarcode closed pull request #21318: [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. URL: https://github.com/apache/pulsar/pull/21318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349615107 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3087,270 @@ public void testGlobalTopicPolicies() throws Excep

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349618089 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Excep

[PR] [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
horizonzy opened a new pull request, #21318: URL: https://github.com/apache/pulsar/pull/21318 ### Motivation cherry-pick #21161 ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in fo

Re: [PR] [fix][test] Move NarUnpackerTest to flaky group [pulsar]

2023-10-07 Thread via GitHub
nodece commented on PR #21316: URL: https://github.com/apache/pulsar/pull/21316#issuecomment-1751911028 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
github-actions[bot] commented on PR #21317: URL: https://github.com/apache/pulsar/pull/21317#issuecomment-1751910987 @horizonzy Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `

Re: [PR] [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
horizonzy closed pull request #21317: [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. URL: https://github.com/apache/pulsar/pull/21317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] [fix] [auto-recovery] [branch-2.11] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
horizonzy opened a new pull request, #21317: URL: https://github.com/apache/pulsar/pull/21317 ### Motivation cherry-pick #21161 ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked

[PR] [fix][test] Move NarUnpackerTest to flaky group [pulsar]

2023-10-07 Thread via GitHub
nodece opened a new pull request, #21316: URL: https://github.com/apache/pulsar/pull/21316 ### Motivation Temporarily move to the flaky group to avoid the CI being blocked. See https://github.com/apache/pulsar/issues/21291 ### Modifications - Move NarUnpackerTest t

[I] [Bug] Segmentation fault when sending messages after receiving send error [pulsar-client-cpp]

2023-10-07 Thread via GitHub
BewareMyPower opened a new issue, #325: URL: https://github.com/apache/pulsar-client-cpp/issues/325 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar-client-cpp/issues) and found nothing similar. ### Version - Pulsar 3.1.0

[pulsar] branch master updated (f85e0dc085d -> 4ee5cd78147)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from f85e0dc085d [fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager (#21213)

Re: [PR] [fix] [ml] Reader can set read-pos to a deleted ledger [pulsar]

2023-10-07 Thread via GitHub
poorbarcode merged PR #21248: URL: https://github.com/apache/pulsar/pull/21248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-07 Thread via GitHub
poorbarcode closed pull request #21315: [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor URL: https://github.com/apache/pulsar/pull/21315 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

2023-10-07 Thread via GitHub
nodece commented on PR #21309: URL: https://github.com/apache/pulsar/pull/21309#issuecomment-1751902884 I think we should add `@Test(groups = "flaky")` to `NarUnpackerTest` to avoid the CI being blocked. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
RobertIndie commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349612623 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1766,18 +1766,32 @@ private void startWorkerService(AuthenticationService authe

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-07 Thread via GitHub
BewareMyPower commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751899833 I see @merlimat's suggestion [here](https://github.com/apache/pulsar/pull/21166#issuecomment-1719694532) and you respond: https://github.com/apache/pulsar/pull/21166#issuecomment-1

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
RobertIndie commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349611897 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1766,18 +1766,32 @@ private void startWorkerService(AuthenticationService authe

[PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-07 Thread via GitHub
horizonzy opened a new pull request, #21315: URL: https://github.com/apache/pulsar/pull/21315 ### Motivation cherry-pick #21159 ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in f

[PR] [fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager (#21213) [pulsar]

2023-10-07 Thread via GitHub
Demogorgon314 opened a new pull request, #21314: URL: https://github.com/apache/pulsar/pull/21314 (cherry picked from commit f85e0dc085d47587037cbc3f7d5443745384d350) ### Motivation Currently, if the cluster has multiple brokers, and the cluster is doing rolling restart, th

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-07 Thread via GitHub
horizonzy closed pull request #21310: [fix] [metadata] Fix zookeeper related flacky test URL: https://github.com/apache/pulsar/pull/21310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Flaky-test: NarUnpackerTest.deleteSampleZipFile [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on issue #21285: URL: https://github.com/apache/pulsar/issues/21285#issuecomment-1751894183 Another one: - https://github.com/apache/pulsar/actions/runs/6441558501/job/17498261862?pr=21248 ``` Error: Tests run: 7, Failures: 3, Errors: 0, Skipped: 4, Time e

Re: [PR] [branch-3.0] [fix] [auto-recovery] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
poorbarcode closed pull request #21312: [branch-3.0] [fix] [auto-recovery] Fix PulsarLedgerUnderreplicationManager notify problem. URL: https://github.com/apache/pulsar/pull/21312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] [Bug] pulsar keep creating dead letter queue producer and exceed the maximum limit [pulsar]

2023-10-07 Thread via GitHub
github-actions[bot] commented on issue #20635: URL: https://github.com/apache/pulsar/issues/20635#issuecomment-1751889880 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] JPMS support [pulsar]

2023-10-07 Thread via GitHub
github-actions[bot] commented on issue #20853: URL: https://github.com/apache/pulsar/issues/20853#issuecomment-1751889713 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] Standalone broker does not become responsive after start. [pulsar]

2023-10-07 Thread via GitHub
github-actions[bot] commented on issue #20875: URL: https://github.com/apache/pulsar/issues/20875#issuecomment-1751889688 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] Add ElasticSearch BatchSource [pulsar]

2023-10-07 Thread via GitHub
github-actions[bot] commented on issue #20890: URL: https://github.com/apache/pulsar/issues/20890#issuecomment-1751889677 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
codelipenghui commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349607295 ## tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/StandaloneContainer.java: ## @@ -31,29 +31,37 @@ public class StandaloneContain

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
codelipenghui commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349607233 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1766,18 +1766,32 @@ private void startWorkerService(AuthenticationService aut

[PR] [branch-3.0][fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager (#21213) [pulsar]

2023-10-07 Thread via GitHub
Demogorgon314 opened a new pull request, #21313: URL: https://github.com/apache/pulsar/pull/21313 (cherry picked from commit f85e0dc085d47587037cbc3f7d5443745384d350) ### Motivation Currently, if the cluster has multiple brokers, and the cluster is doing rolling restart, th

[pulsar] branch master updated: [fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager (#21213)

2023-10-07 Thread kwang
This is an automated email from the ASF dual-hosted git repository. kwang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f85e0dc085d [fix][broker] Fix lookup heartbeat an

Re: [PR] [fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager [pulsar]

2023-10-07 Thread via GitHub
Demogorgon314 merged PR #21213: URL: https://github.com/apache/pulsar/pull/21213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [I] [Bug] one topic suddenly cannot be consumed,others is ok [pulsar]

2023-10-07 Thread via GitHub
jsatterfield commented on issue #21082: URL: https://github.com/apache/pulsar/issues/21082#issuecomment-1751843893 Just started testing with Pulsar and ran into something that sounds like this. In my case, using `inactive_topic_policies.inactiveTopicDeleteMode: delete_when_subscripti

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-07 Thread via GitHub
chenhongSZ commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349568652 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3565,10 +3566,11 @@ private CompletableFuture updateSubscri

Re: [PR] Bump postcss from 8.4.23 to 8.4.31 [pulsar-site]

2023-10-07 Thread via GitHub
github-actions[bot] commented on PR #714: URL: https://github.com/apache/pulsar-site/pull/714#issuecomment-1751797869 @dependabot[bot] Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed`

[pulsar-site] branch dependabot/npm_and_yarn/postcss-8.4.31 created (now 4f3269cb167e)

2023-10-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/postcss-8.4.31 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 4f3269cb167e Bump postcss from 8.4.23 to 8.4.31 No new revisions were added

[PR] Bump postcss from 8.4.23 to 8.4.31 [pulsar-site]

2023-10-07 Thread via GitHub
dependabot[bot] opened a new pull request, #714: URL: https://github.com/apache/pulsar-site/pull/714 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.23 to 8.4.31. Release notes Sourced from https://github.com/postcss/postcss/releases";>postcss's releases. 8.4.31

Re: [PR] [fix] [auto-recovery] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
horizonzy commented on PR #21161: URL: https://github.com/apache/pulsar/pull/21161#issuecomment-1751773270 > @horizonzy Could you create a new PR to cherry-pick this PR into `branch-3.0`? https://github.com/apache/pulsar/pull/21312 -- This is an automated message from the Apache Gi

[PR] [branch-3.0] [fix] [auto-recovery] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
horizonzy opened a new pull request, #21312: URL: https://github.com/apache/pulsar/pull/21312 ### Motivation cherry-pick #21161 ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked

Re: [PR] [fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager [pulsar]

2023-10-07 Thread via GitHub
codecov-commenter commented on PR #21213: URL: https://github.com/apache/pulsar/pull/21213#issuecomment-1751742658 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[pulsar] branch branch-3.0 updated: Revert "[fix][broker] Fix inconsistent topic policy (#21231)"

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 01dfd3e03ea Revert "[fix][broker] Fix in

Re: [PR] [improve] [pip] PIP-298 Consumer supports specifying consumption isolation level [pulsar]

2023-10-07 Thread via GitHub
hzh0425 commented on code in PR #21114: URL: https://github.com/apache/pulsar/pull/21114#discussion_r1349536243 ## pip/pip-298.md: ## @@ -0,0 +1,105 @@ +## Background + +In the implementation of the Pulsar Transaction, each topic is configured with a `Transaction Buffer` to pre

Re: [PR] [fix][broker] fix UniformLoadShedder selecet wrong overloadbroker and underloadbroker [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on PR #21025: URL: https://github.com/apache/pulsar/pull/21025#issuecomment-1751740740 @aloyszhang Could you create a new PR to cherry-pick this PR into `branch-3.0`? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [fix] [auto-recovery] Fix PulsarLedgerUnderreplicationManager notify problem. [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on PR #21161: URL: https://github.com/apache/pulsar/pull/21161#issuecomment-1751740246 @horizonzy Could you create a new PR to cherry-pick this PR into `branch-3.0`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar] branch branch-3.0 updated: [fix][broker] Fix inconsistent topic policy (#21231)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new a0e2104642c [fix][broker] Fix inconsiste

[pulsar] branch branch-3.0 updated: [fix][broker] rackaware policy is ineffective when delete zk rack info after bkclient initialize (#20944)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 3129621f894 [fix][broker] rackaware poli

[pulsar] branch branch-3.0 updated: [fix][broker] fix bug caused by optimistic locking (#18390)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new eb4f5906f10 [fix][broker] fix bug caused

[pulsar] branch branch-3.0 updated: [improve] [broker] Not close the socket if lookup failed caused by bundle unloading or metadata ex (#21211)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new eb2144e1712 [improve] [broker] Not close

[pulsar] branch branch-3.0 updated: [fix] [client] fix reader.hasMessageAvailable return false when incoming queue is not empty (#21259)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 38c3f0c019f [fix] [client] fix reader.ha

[pulsar] branch branch-3.0 updated: [improve] [broker] Print warn log if ssl handshake error & print ledger id when switch ledger (#21201)

2023-10-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new f243925dfed [improve] [broker] Print war

Re: [PR] [fix][broker] Use expireAfterAccess instead of expireAfterWrite for metadata cache [pulsar]

2023-10-07 Thread via GitHub
codelipenghui closed pull request #21095: [fix][broker] Use expireAfterAccess instead of expireAfterWrite for metadata cache URL: https://github.com/apache/pulsar/pull/21095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [fix][broker] Use expireAfterAccess instead of expireAfterWrite for metadata cache [pulsar]

2023-10-07 Thread via GitHub
codelipenghui commented on PR #21095: URL: https://github.com/apache/pulsar/pull/21095#issuecomment-1751699742 Close this PR since the expireAfterAccess method will cost more CPU resources for tracking the access. -- This is an automated message from the Apache Git Service. To respond to

[pulsar] branch master updated: [fix][broker] rackaware policy is ineffective when delete zk rack info after bkclient initialize (#20944)

2023-10-07 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d9ebaf5bf6f [fix][broker] rackaware policy is i

Re: [PR] [fix][broker] rackaware policy is ineffective when delete zk rack info after bkclient initialize [pulsar]

2023-10-07 Thread via GitHub
codelipenghui merged PR #20944: URL: https://github.com/apache/pulsar/pull/20944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [I] [Task] Fix thread safety of PendingAckHandleImpl [pulsar]

2023-10-07 Thread via GitHub
codelipenghui commented on issue #21304: URL: https://github.com/apache/pulsar/issues/21304#issuecomment-1751698122 @liangyepianzhou Could you please help take a look at this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] [Bug] The flow rate of some partitions drops to 0 during the pressure test [pulsar]

2023-10-07 Thread via GitHub
codelipenghui commented on issue #20961: URL: https://github.com/apache/pulsar/issues/20961#issuecomment-1751697317 @Technoboy- Could you please help take a look at this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] [doc] [fix] Links to Broker Load Balancing Use Cases broken [pulsar]

2023-10-07 Thread via GitHub
Technoboy- commented on issue #21306: URL: https://github.com/apache/pulsar/issues/21306#issuecomment-1751690755 https://github.com/apache/pulsar-site/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] [doc] [fix] Links to Broker Load Balancing Use Cases broken [pulsar]

2023-10-07 Thread via GitHub
Technoboy- closed issue #21306: [doc] [fix] Links to Broker Load Balancing Use Cases broken URL: https://github.com/apache/pulsar/issues/21306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] Not enough non-faulty bookies available [pulsar]

2023-10-07 Thread via GitHub
eaba commented on issue #13167: URL: https://github.com/apache/pulsar/issues/13167#issuecomment-1751677852 BROKER: webSocketServiceEnabled: "true" # Not enough non-faulty bookies available -- This is an automated message from the Apache Git Service. To respond to the message, plea

[pulsar] branch master updated: [fix][test]Fix flaky test because the too short receive time (#21273)

2023-10-07 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new dbb157793b9 [fix][test]Fix flaky test becaus

Re: [PR] [fix][test]Fix flaky test because the too short receive time [pulsar]

2023-10-07 Thread via GitHub
Technoboy- merged PR #21273: URL: https://github.com/apache/pulsar/pull/21273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
Technoboy- commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349498390 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1766,18 +1766,32 @@ private void startWorkerService(AuthenticationService authen

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
Technoboy- commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349498242 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1766,18 +1766,32 @@ private void startWorkerService(AuthenticationService authen

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
Technoboy- commented on PR #21221: URL: https://github.com/apache/pulsar/pull/21221#issuecomment-1751669676 > Users should be able to control whether or not to use TLS themselves. Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Revert "[fix][broker] Miss headersAndPayload and messageIdData in MessagePublishContext (#21245) [pulsar]

2023-10-07 Thread via GitHub
nodece commented on PR #21309: URL: https://github.com/apache/pulsar/pull/21309#issuecomment-1751665693 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [fix][test]Fix flaky test because the too short receive time [pulsar]

2023-10-07 Thread via GitHub
codecov-commenter commented on PR #21273: URL: https://github.com/apache/pulsar/pull/21273#issuecomment-1751664255 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[I] Failed to reconnect producer: ProducerBusy [pulsar-client-python]

2023-10-07 Thread via GitHub
TCGOGOGO opened a new issue, #155: URL: https://github.com/apache/pulsar-client-python/issues/155 ## Descripition The connection between client and server may be broken in some cases, for example, network fluctuations, so I was trying to have a retry logic when producer send messages, wh

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-07 Thread via GitHub
poorbarcode commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349491768 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3565,10 +3566,11 @@ private CompletableFuture updateSubscr

Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

2023-10-07 Thread via GitHub
shibd commented on code in PR #21221: URL: https://github.com/apache/pulsar/pull/21221#discussion_r1349487026 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1766,18 +1766,32 @@ private void startWorkerService(AuthenticationService authenticat

Re: [I] Error in Running Pulser in frontend side [pulsar-client-node]

2023-10-07 Thread via GitHub
its0beno commented on issue #344: URL: https://github.com/apache/pulsar-client-node/issues/344#issuecomment-1751648914 i used `npm i pulsar-client` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Bug] Thread safety issues with topic policy mutations [pulsar]

2023-10-07 Thread via GitHub
mattisonchao commented on issue #21303: URL: https://github.com/apache/pulsar/issues/21303#issuecomment-1751645054 @lhotari Yep, I am working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Bug] Segmentation fault occurs at Broker shutdown. [pulsar-client-cpp]

2023-10-07 Thread via GitHub
BewareMyPower commented on issue #324: URL: https://github.com/apache/pulsar-client-cpp/issues/324#issuecomment-1751644375 The root cause might be https://github.com/apache/pulsar-client-cpp/commit/b35ae1aa4b9834886c0889635de81834f9b2f774, I reverted this commit and then the segmentation f

Re: [I] [Bug] Segmentation fault occurs at Broker shutdown. [pulsar-client-cpp]

2023-10-07 Thread via GitHub
BewareMyPower commented on issue #324: URL: https://github.com/apache/pulsar-client-cpp/issues/324#issuecomment-1751640518 I also observed a similar segfault recently. It happened randomly. A failed case: ``` 2023-10-07 15:46:10.026 INFO [0x16f587000] ClientConnection:1340

[pulsar] branch branch-3.0 updated: [fix][ml] Fix thread safe issue with RangeCache.put and RangeCache.clear (#21302)

2023-10-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 0bfa54fd378 [fix][ml] Fix thread safe i

[pulsar] branch branch-2.11 updated: [fix][ml] Fix thread safe issue with RangeCache.put and RangeCache.clear (#21302)

2023-10-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 14a9cf7a09b [fix][ml] Fix thread safe

[pulsar] branch branch-3.1 updated: [fix][ml] Fix thread safe issue with RangeCache.put and RangeCache.clear (#21302)

2023-10-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 59006357416 [fix][ml] Fix thread safe i

[pulsar] branch branch-2.10 updated: [fix][ml] Fix thread safe issue with RangeCache.put and RangeCache.clear (#21302)

2023-10-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new a741bb62a7f [fix][ml] Fix thread safe

Re: [PR] [improve][pip] PIP-304: Make PublishContext provide the message metadata [pulsar]

2023-10-07 Thread via GitHub
kecona commented on code in PR #21311: URL: https://github.com/apache/pulsar/pull/21311#discussion_r1349478216 ## pip/pip-304.md: ## @@ -0,0 +1,54 @@ +# Motivation + +We have a scenario that uses the `org.apache.pulsar.broker.intercept.BrokerInterceptor#messageProduced`, and n

Re: [I] [Bug] Thread safety issues with topic policy mutations [pulsar]

2023-10-07 Thread via GitHub
lhotari commented on issue #21303: URL: https://github.com/apache/pulsar/issues/21303#issuecomment-1751631958 @mattisonchao Since you worked on #21231 recently, would you be interested in checking this one out? I created this issue purely from the perspective of code analysis. The topic pol