Re: [PR] [cleanup][metadatastore] cleanup deprecated method of metadata store etcd [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21253: URL: https://github.com/apache/pulsar/pull/21253#discussion_r1349891541 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java: ## @@ -109,9 +109,9 @@ public EtcdMetadataStore(String metadataURL, Met

Re: [PR] [fix][test] Move NarUnpackerTest to flaky group [pulsar]

2023-10-08 Thread via GitHub
lhotari merged PR #21316: URL: https://github.com/apache/pulsar/pull/21316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[pulsar] branch master updated: [fix][test] Move NarUnpackerTest to flaky group (#21316)

2023-10-08 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8438e43fb02 [fix][test] Move NarUnpackerTest to

[PR] [fix] [bk-client] Fix bk client MinNumRacksPerWriteQuorum and EnforceMinNumRacksPerWriteQuorum not work problem. [pulsar]

2023-10-08 Thread via GitHub
horizonzy opened a new pull request, #21327: URL: https://github.com/apache/pulsar/pull/21327 ### Motivation fixes #21326 ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matchin

[I] [Bug] Bk client MinNumRacksPerWriteQuorum and EnforceMinNumRacksPerWriteQuorum not work problem [pulsar]

2023-10-08 Thread via GitHub
horizonzy opened a new issue, #21326: URL: https://github.com/apache/pulsar/issues/21326 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master ### Minimal reproduce step

Re: [PR] [fix][doc] Fix typos in doc for Validator class [pulsar]

2023-10-08 Thread via GitHub
hanmz commented on PR #21323: URL: https://github.com/apache/pulsar/pull/21323#issuecomment-1752359787 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
chenhongSZ commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349857137 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Except

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
chenhongSZ commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349856924 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Except

[pulsar] branch master updated: [feat][sql] Support UUID for json and avro (#21267)

2023-10-08 Thread xiangying
This is an automated email from the ASF dual-hosted git repository. xiangying pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8c7094328e0 [feat][sql] Support UUID for json

Re: [PR] [feat][sql] Support UUID for json and avro [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou merged PR #21267: URL: https://github.com/apache/pulsar/pull/21267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

Re: [PR] [fix][broker] Intercept all commands [pulsar]

2023-10-08 Thread via GitHub
nodece commented on code in PR #21265: URL: https://github.com/apache/pulsar/pull/21265#discussion_r1349832948 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarDecoder.java: ## @@ -126,17 +126,12 @@ public void channelRead(ChannelHandlerContext ctx, Object

[pulsar-client-cpp] branch main updated: Fix segmentation fault when sending messages after receiving an error (#326)

2023-10-08 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 5c77648 Fix segmentation fault when sending

Re: [I] [Bug] Segmentation fault when sending messages after receiving an error [pulsar-client-cpp]

2023-10-08 Thread via GitHub
BewareMyPower closed issue #325: [Bug] Segmentation fault when sending messages after receiving an error URL: https://github.com/apache/pulsar-client-cpp/issues/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix segmentation fault when sending messages after receiving an error [pulsar-client-cpp]

2023-10-08 Thread via GitHub
BewareMyPower merged PR #326: URL: https://github.com/apache/pulsar-client-cpp/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

Re: [I] Failed to reconnect producer: ProducerBusy [pulsar-client-python]

2023-10-08 Thread via GitHub
BewareMyPower commented on issue #155: URL: https://github.com/apache/pulsar-client-python/issues/155#issuecomment-1752286266 There is a similar fix (https://github.com/apache/pulsar/pull/21144) in core repo but I didn't look into this fix currently -- This is an automated message from t

Re: [I] [feature request] Reader support seek by timestamp. [pulsar-client-python]

2023-10-08 Thread via GitHub
shibd closed issue #78: [feature request] Reader support seek by timestamp. URL: https://github.com/apache/pulsar-client-python/issues/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix][doc] Fix typos in doc for broker.conf [pulsar]

2023-10-08 Thread via GitHub
Technoboy- closed pull request #21322: [fix][doc] Fix typos in doc for broker.conf URL: https://github.com/apache/pulsar/pull/21322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[pulsar-client-python] branch main updated: Remove useless sleep on test_seek. (#154)

2023-10-08 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new 8d77f74 Remove useless sleep on test_see

Re: [PR] Remove useless sleep on test_seek. [pulsar-client-python]

2023-10-08 Thread via GitHub
BewareMyPower merged PR #154: URL: https://github.com/apache/pulsar-client-python/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[pulsar] branch branch-2.11 updated: [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor (#21315)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new c00a4a13554 [fix][auto-recovery] [bran

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
poorbarcode merged PR #21315: URL: https://github.com/apache/pulsar/pull/21315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [PR] Fix segmentation fault when sending messages after receiving an error [pulsar-client-cpp]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #326: URL: https://github.com/apache/pulsar-client-cpp/pull/326#discussion_r1349816946 ## tests/chunkdedup/docker-compose.yml: ## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

Re: [PR] [improve][pip]PIP-296: support storing brokerClient certificates in metadata store [pulsar]

2023-10-08 Thread via GitHub
github-actions[bot] commented on PR #21044: URL: https://github.com/apache/pulsar/pull/21044#issuecomment-1752247091 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [improve][broker] Add addCustomizeMetrics method for BrokerInterceptor [pulsar]

2023-10-08 Thread via GitHub
github-actions[bot] commented on PR #21102: URL: https://github.com/apache/pulsar/pull/21102#issuecomment-1752247050 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
codelipenghui commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349811240 ## pip/pip-302.md: ## @@ -0,0 +1,100 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
horizonzy commented on PR #21315: URL: https://github.com/apache/pulsar/pull/21315#issuecomment-1752225490 @hangc0276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
horizonzy commented on PR #21315: URL: https://github.com/apache/pulsar/pull/21315#issuecomment-1752211522 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [improve] [pip] PIP-299: Stop dispatch messages if the individual acks will be lost in the persistent storage [pulsar]

2023-10-08 Thread via GitHub
codelipenghui commented on code in PR #21118: URL: https://github.com/apache/pulsar/pull/21118#discussion_r1349801731 ## pip/pip-299.md: ## @@ -0,0 +1,81 @@ +# Background knowledge + +The config `managedLedgerMaxUnackedRangesToPersist` + +Indicates the number of `acknowledgment

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
horizonzy commented on PR #21315: URL: https://github.com/apache/pulsar/pull/21315#issuecomment-1752202422 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
mattisonchao commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349797813 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Exce

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
mattisonchao commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349797813 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Exce

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
mattisonchao commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349797813 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Exce

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349743690 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Excep

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349743690 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Excep

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349740167 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Excep

Re: [PR] [fix][broker][branch-3.1] Fix inconsistent topic policy [pulsar]

2023-10-08 Thread via GitHub
mattisonchao closed pull request #21255: [fix][broker][branch-3.1] Fix inconsistent topic policy URL: https://github.com/apache/pulsar/pull/21255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch master updated: [fix] [ml] fix wrong msg backlog of non-durable cursor after trim ledgers (#21250)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ca779827581 [fix] [ml] fix wrong msg backlog of

Re: [PR] [fix] [ml] fix wrong msg backlog of non-durable cursor after trim ledgers [pulsar]

2023-10-08 Thread via GitHub
poorbarcode merged PR #21250: URL: https://github.com/apache/pulsar/pull/21250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [PR] [fix] [ml] fix wrong msg backlog of non-durable cursor after trim ledgers [pulsar]

2023-10-08 Thread via GitHub
codecov-commenter commented on PR #21250: URL: https://github.com/apache/pulsar/pull/21250#issuecomment-1752035614 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [improve] [pip] PIP-298 Consumer supports specifying consumption isolation level [pulsar]

2023-10-08 Thread via GitHub
hzh0425 commented on PR #21114: URL: https://github.com/apache/pulsar/pull/21114#issuecomment-1752026722 @dave2wave hi dave, Could you pls take a look for this pip when you are free? The document is: https://github.com/apache/pulsar-site/pull/712 -- This is an automated message from t

Re: [PR] [fix][broker] Avoid block markDeletePosition forward when skip lost entries [pulsar]

2023-10-08 Thread via GitHub
hanmz commented on PR #21210: URL: https://github.com/apache/pulsar/pull/21210#issuecomment-1752025250 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [improve] [pip] PIP-298 Consumer supports specifying consumption isolation level [pulsar]

2023-10-08 Thread via GitHub
asafm commented on code in PR #21114: URL: https://github.com/apache/pulsar/pull/21114#discussion_r1349691466 ## pip/pip-298.md: ## @@ -1,28 +1,106 @@ -## Background +# Background -In the implementation of the Pulsar Transaction, each topic is configured with a `Transaction B

Re: [PR] [fix][bk] Fix the var name for IsolationGroups [pulsar]

2023-10-08 Thread via GitHub
codecov-commenter commented on PR #21320: URL: https://github.com/apache/pulsar/pull/21320#issuecomment-1752018138 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
horizonzy commented on PR #21315: URL: https://github.com/apache/pulsar/pull/21315#issuecomment-1752017139 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix segmentation fault when sending messages after receiving an error [pulsar-client-cpp]

2023-10-08 Thread via GitHub
RobertIndie commented on code in PR #326: URL: https://github.com/apache/pulsar-client-cpp/pull/326#discussion_r1349687464 ## tests/chunkdedup/docker-compose.yml: ## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] [fix][broker] release orphan replicator after replicator is closed. [pulsar]

2023-10-08 Thread via GitHub
hanmz commented on PR #21203: URL: https://github.com/apache/pulsar/pull/21203#issuecomment-1752010244 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pulsar] branch master updated: [refactor][broker] PIP-301 Part-1: Add BundleDataResources (#21119)

2023-10-08 Thread houxiaoyu
This is an automated email from the ASF dual-hosted git repository. houxiaoyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bbdc173e801 [refactor][broker] PIP-301 Part-1

Re: [PR] [refactor][broker] PIP-301 Part-1: Add BundleDataResources [pulsar]

2023-10-08 Thread via GitHub
AnonHxy merged PR #21119: URL: https://github.com/apache/pulsar/pull/21119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-08 Thread via GitHub
lhotari commented on PR #21310: URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1752001954 Great work @horizonzy! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [fix][broker] Avoid block markDeletePosition forward when skip lost entries [pulsar]

2023-10-08 Thread via GitHub
hanmz commented on PR #21210: URL: https://github.com/apache/pulsar/pull/21210#issuecomment-1752000995 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
chenhongSZ commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349673135 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3084,104 @@ public void testGlobalTopicPolicies() throws Except

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
chenhongSZ commented on code in PR #21212: URL: https://github.com/apache/pulsar/pull/21212#discussion_r1349668689 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3061,6 +3087,270 @@ public void testGlobalTopicPolicies() throws Except

Re: [PR] [fix] [ml] fix wrong msg backlog of non-durable cursor after trim ledgers [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on PR #21250: URL: https://github.com/apache/pulsar/pull/21250#issuecomment-1751978695 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[I] [Bug] Can not cleanup heartbeat data if scaling down broker [pulsar]

2023-10-08 Thread via GitHub
TakaHiR07 opened a new issue, #21324: URL: https://github.com/apache/pulsar/issues/21324 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version pulsar version: 2.10 ### Minimal

Re: [PR] [fix][broker] release orphan replicator after replicator is closed. [pulsar]

2023-10-08 Thread via GitHub
Jason918 commented on PR #21203: URL: https://github.com/apache/pulsar/pull/21203#issuecomment-1751964606 @hanmz Please check the CI failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [fix][broker] Intercept all commands [pulsar]

2023-10-08 Thread via GitHub
Jason918 commented on code in PR #21265: URL: https://github.com/apache/pulsar/pull/21265#discussion_r1349653143 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarDecoder.java: ## @@ -126,17 +126,12 @@ public void channelRead(ChannelHandlerContext ctx, Objec

[PR] [fix][doc] Fix typos in Validator class [pulsar]

2023-10-08 Thread via GitHub
hanmz opened a new pull request, #21323: URL: https://github.com/apache/pulsar/pull/21323 ### Motivation Fix typos in doc for Validator class ### Modifications `belogs` => `belongs` ### Documentation - [ ] `doc` - [ ] `doc-required` - [x]

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349651345 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by of

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on PR #21315: URL: https://github.com/apache/pulsar/pull/21315#issuecomment-1751960368 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Flaky-test: AutoRecoveryMainTest.setUp [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on issue #21289: URL: https://github.com/apache/pulsar/issues/21289#issuecomment-1751960225 Fixed by https://github.com/apache/pulsar/pull/21310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Flaky-test: AutoRecoveryMainTest.setUp [pulsar]

2023-10-08 Thread via GitHub
poorbarcode closed issue #21289: Flaky-test: AutoRecoveryMainTest.setUp URL: https://github.com/apache/pulsar/issues/21289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[pulsar] branch branch-3.0 updated: [fix] [metadata] Fix zookeeper related flacky test (#21310)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 5dc11a5d4ed [fix] [metadata] Fix zookeep

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-08 Thread via GitHub
poorbarcode commented on PR #21310: URL: https://github.com/apache/pulsar/pull/21310#issuecomment-1751958004 Since the PR https://github.com/apache/pulsar/pull/21188 will cherry-pick into `branch-3.0`, `branch-2.11` and `branch-2.10` and the test is very flaky, I added the labels `release/2

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349649112 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

[pulsar] branch master updated (4ee5cd78147 -> 9ab7417edc2)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 4ee5cd78147 [fix] [ml] Reader can set read-pos to a deleted ledger (#21248) add 9ab7417edc2 [fix] [metadata] Fix

Re: [PR] [fix][broker] Fix inconsistent topic policy [pulsar]

2023-10-08 Thread via GitHub
mattisonchao commented on PR #21231: URL: https://github.com/apache/pulsar/pull/21231#issuecomment-1751957035 > The methods before were not async? Yes, it was used backoff to implement an async-like approach. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2023-10-08 Thread via GitHub
mattisonchao commented on PR #21212: URL: https://github.com/apache/pulsar/pull/21212#issuecomment-1751957107 Plus, we didn't support the `global` policy very well. There are some issues I know so far. 1. The global topic policy and the local topic policy use the same message key, an

Re: [PR] [fix] [metadata] Fix zookeeper related flacky test [pulsar]

2023-10-08 Thread via GitHub
poorbarcode merged PR #21310: URL: https://github.com/apache/pulsar/pull/21310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [I] Flaky-test: TestReplicationWorker.setUp / BookKeeperClusterTestCase.setUp / BookieResources.createMetadataDriver / AuditorBookieTest.setUp [pulsar]

2023-10-08 Thread via GitHub
poorbarcode closed issue #21286: Flaky-test: TestReplicationWorker.setUp / BookKeeperClusterTestCase.setUp / BookieResources.createMetadataDriver / AuditorBookieTest.setUp URL: https://github.com/apache/pulsar/issues/21286 -- This is an automated message from the Apache Git Service. To respo

[pulsar] branch branch-2.10 updated: [improve] [broker] Not close the socket if lookup failed caused by bundle unloading or metadata ex (#21211)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 761490bcfed [improve] [broker] Not clo

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349646909 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by of

[PR] [fix][doc] Fix typos in broker.conf [pulsar]

2023-10-08 Thread via GitHub
hanmz opened a new pull request, #21322: URL: https://github.com/apache/pulsar/pull/21322 ### Motivation Fix typos in doc for broker.conf ### Modifications `dispathcer` => `dispatcher` ### Documentation - [ ] `doc` - [ ] `doc-required` -

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349644820 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349644106 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

Re: [PR] [fix][auto-recovery] [branch-2.11] Fix metadata store deadlock due to BookkeeperInternalCallbacks.Processor [pulsar]

2023-10-08 Thread via GitHub
horizonzy commented on PR #21315: URL: https://github.com/apache/pulsar/pull/21315#issuecomment-1751950390 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349643927 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by of

[pulsar] branch branch-2.10 updated: [fix] [client] fix reader.hasMessageAvailable return false when incoming queue is not empty (#21259)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new f7f91345ecc [fix] [client] fix reader.

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751949561 >If `refreshAsync` method is just to handle this case, you must note the limitation of `refreshAsync` that it cannot guarantee latest value is read unless there is no messages se

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349643198 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

[pulsar] branch branch-2.10 updated: [improve] [broker] Print warn log if ssl handshake error & print ledger id when switch ledger (#21201)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new f3876c12735 [improve] [broker] Print w

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349642545 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

[pulsar] branch branch-2.11 updated: [improve] [broker] Not close the socket if lookup failed caused by bundle unloading or metadata ex (#21211)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new d3ca9c743a7 [improve] [broker] Not clo

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751947747 > If we use Reader, then all topics may need to read the system topic from beginning to end when it loads. Yeah I just also thought of this point so I deleted my comment befo

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349642124 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by of

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on code in PR #21271: URL: https://github.com/apache/pulsar/pull/21271#discussion_r1349641879 ## pip/pip-302.md: ## @@ -0,0 +1,104 @@ +# Background Knowledge + +The TableView interface provides a convenient way to access data in a compacted topic by offe

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
liangyepianzhou commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751946996 >If you can control the write side, why not just use a Reader? Because there is a system topic shared by all topics in this namespace. If we use Reader, then all top

Re: [PR] [fix][test] Move NarUnpackerTest to flaky group [pulsar]

2023-10-08 Thread via GitHub
codecov-commenter commented on PR #21316: URL: https://github.com/apache/pulsar/pull/21316#issuecomment-1751946889 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[pulsar] branch branch-2.11 updated: [fix] [client] fix reader.hasMessageAvailable return false when incoming queue is not empty (#21259)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 5b42292dff4 [fix] [client] fix reader.

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751944806 > when reads and writes for a key do not occur at the same time, we can refresh the TableView next time to get the latest value of this key. If you can control the write side

Re: [PR] [improve][pip] PIP-302 Introduce refreshAsync API for TableView [pulsar]

2023-10-08 Thread via GitHub
BewareMyPower commented on PR #21271: URL: https://github.com/apache/pulsar/pull/21271#issuecomment-1751943721 > As for the getLatestSnapshotAsync method, I don't quite understand its use case. It provides a consistency view. For example, let's assume there are two keys that represen

[pulsar] branch branch-2.11 updated: [improve] [broker] Print warn log if ssl handshake error & print ledger id when switch ledger (#21201)

2023-10-08 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 8f964314e4b [improve] [broker] Print w