Re: [PR] [fix] [broker] [branch-2.11] Fix isolated group not work problem [pulsar]

shibd commented on PR #21415: URL: https://github.com/apache/pulsar/pull/21415#issuecomment-1774534838 Check-style no pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improve][doc]Add introduction of transaction isolation level in the txn-advanced-features.md [pulsar-site]

tisonkun commented on PR #712: URL: https://github.com/apache/pulsar-site/pull/712#issuecomment-1774522544 We should not merge this patch until PIP-298 is accepted and merged. Is it correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [fix][doc]Update security-encryption.md for key pairs of golang [pulsar-site]

tisonkun commented on PR #708: URL: https://github.com/apache/pulsar-site/pull/708#issuecomment-1774521240 cc @nodece May you do a technical review for this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[pulsar-site] branch dependabot/npm_and_yarn/babel/traverse-7.23.2 deleted (was e994ddc4c6ec)

This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch dependabot/npm_and_yarn/babel/traverse-7.23.2 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git was e994ddc4c6ec build(deps): Bump @babel/traverse from 7.21.5 to 7.23.2 The r

[pulsar-site] branch main updated: build(deps): Bump @babel/traverse from 7.21.5 to 7.23.2 (#718)

This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new dd5ab2b03dfb build(deps): Bump @babel/traverse f

Re: [PR] build(deps): Bump @babel/traverse from 7.21.5 to 7.23.2 [pulsar-site]

tisonkun merged PR #718: URL: https://github.com/apache/pulsar-site/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[PR] [feat][client] Introduce Refresh API in the TableView [pulsar]

liangyepianzhou opened a new pull request, #21417: URL: https://github.com/apache/pulsar/pull/21417 Master https://github.com/apache/pulsar/pull/21271 ### Motivation The proposal will introduce a new API to refresh the table view with the latest written data on the topic, ensuring that

Re: [PR] Polish version switch on desktop [pulsar-site]

tisonkun merged PR #719: URL: https://github.com/apache/pulsar-site/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar-site] branch main updated: Polish version switch on desktop (#719)

This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new ea9cd9536172 Polish version switch on desktop (#

[PR] [fix][client] Fix some typos in client module [pulsar]

hanmz opened a new pull request, #21416: URL: https://github.com/apache/pulsar/pull/21416 ### Motivation Fix some typos in client module ### Modifications 1. Modify the interface name from `getTotaBatchReceivedFailed` to `getTotalBatchReceivedFailed` 2. Modify the

Re: [PR] [fix][broker][branch-3.0] Fix inconsistent topic policy [pulsar]

mattisonchao closed pull request #21256: [fix][broker][branch-3.0] Fix inconsistent topic policy URL: https://github.com/apache/pulsar/pull/21256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [improve] [pip] PIP-298 Consumer supports specifying consumption isolation level [pulsar]

codelipenghui commented on code in PR #21114: URL: https://github.com/apache/pulsar/pull/21114#discussion_r1368131975 ## pip/pip-298.md: ## @@ -1,28 +1,106 @@ -## Background +# Background -In the implementation of the Pulsar Transaction, each topic is configured with a `Trans

Re: [PR] [fix][test] [branch-3.0] Fix AuditorLedgerCheckerTest flaky test. [pulsar]

Technoboy- merged PR #21414: URL: https://github.com/apache/pulsar/pull/21414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

[pulsar] branch branch-3.0 updated: [fix][test] Fix AuditorLedgerCheckerTest flaky test. (#21414)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new b765a02e629 [fix][test] Fix AuditorLe

Re: [PR] [fix][doc] Fix typos in TransactionBuilderImpl class [pulsar]

hanmz commented on PR #21405: URL: https://github.com/apache/pulsar/pull/21405#issuecomment-1774379656 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [fix] [broker] [branch-2.11] Fix isolated group not work problem [pulsar]

horizonzy opened a new pull request, #21415: URL: https://github.com/apache/pulsar/pull/21415 ### Motivation cherry-pick #21096 ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in f

Re: [PR] [fix] [broker] Fix isolated group not work problem. [pulsar]

horizonzy commented on PR #21096: URL: https://github.com/apache/pulsar/pull/21096#issuecomment-1774360966 > @horizonzy Can you help create a PR to cherry-pick this change to `branch-2.11`? Ok. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [fix][test] [branch-3.0] Fix AuditorLedgerCheckerTest flaky test. [pulsar]

mattisonchao closed pull request #21414: [fix][test] [branch-3.0] Fix AuditorLedgerCheckerTest flaky test. URL: https://github.com/apache/pulsar/pull/21414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [fix][test] [branch-3.0] Fix AuditorLedgerCheckerTest flaky test. [pulsar]

horizonzy opened a new pull request, #21414: URL: https://github.com/apache/pulsar/pull/21414 ### Motivation Fix AuditorLedgerCheckerTest flaky test. ### Documentation - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` ##

[pulsar] branch master updated: [refactor][broker ] PIP-301 Part-2: Add BrokerTimeAverageDataResources (#21353)

This is an automated email from the ASF dual-hosted git repository. houxiaoyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 30d59e3ff25 [refactor][broker ] PIP-301 Part-

Re: [PR] [refactor][broker ] PIP-301 Part-2: Add BrokerTimeAverageDataResources [pulsar]

AnonHxy merged PR #21353: URL: https://github.com/apache/pulsar/pull/21353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [fix][broker][branch-2.11] Fix inconsistent topic policy [pulsar]

mattisonchao commented on PR #21257: URL: https://github.com/apache/pulsar/pull/21257#issuecomment-1774322001 @shibd fixing the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

Demogorgon314 commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1368046919 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java: ## @@ -179,4 +182,57 @@ public void testCloseTransact

Re: [PR] [improve][pip] PIP-304: Make PublishContext provide the message metadata [pulsar]

kecona commented on code in PR #21311: URL: https://github.com/apache/pulsar/pull/21311#discussion_r1368045971 ## pip/pip-304.md: ## @@ -0,0 +1,85 @@ +# Motivation + +We have a scenario that uses the `org.apache.pulsar.broker.intercept.BrokerInterceptor#messageProduced`, and n

Re: [PR] [fix][broker] Fix multiple race conditions in topic unloading and loading [pulsar]

github-actions[bot] commented on PR #20540: URL: https://github.com/apache/pulsar/pull/20540#issuecomment-1774307990 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [fix][fn] Fix using the correct admin and broker urls [pulsar]

github-actions[bot] commented on PR #21013: URL: https://github.com/apache/pulsar/pull/21013#issuecomment-1774307196 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] [Bug] Brokers can't reach balanced state sometimes when using UnifromLoadShedder [pulsar]

github-actions[bot] commented on issue #21174: URL: https://github.com/apache/pulsar/issues/21174#issuecomment-1774306910 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [improve] [broker] support load placement based on different dimensions [pulsar]

github-actions[bot] commented on PR #21175: URL: https://github.com/apache/pulsar/pull/21175#issuecomment-1774306878 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [improve][broker]filter-out non traffic bundles when shedding in UniformLoadShedder [pulsar]

github-actions[bot] commented on PR #21214: URL: https://github.com/apache/pulsar/pull/21214#issuecomment-1774306794 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] Flaky-test: AutoRecoveryMainTest. testAutoRecoverySessionLoss [pulsar]

github-actions[bot] commented on issue #21235: URL: https://github.com/apache/pulsar/issues/21235#issuecomment-1774306751 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [fix][txn]Handle exceptions in the transaction pending ack init [pulsar]

liangyepianzhou commented on code in PR #21274: URL: https://github.com/apache/pulsar/pull/21274#discussion_r1368042486 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -945,12 +954,33 @@ public void completeHan

Re: [PR] [improve][pip] PIP-304: Make PublishContext provide the message metadata [pulsar]

codelipenghui commented on code in PR #21311: URL: https://github.com/apache/pulsar/pull/21311#discussion_r1368035272 ## pip/pip-304.md: ## @@ -0,0 +1,85 @@ +# Motivation + +We have a scenario that uses the `org.apache.pulsar.broker.intercept.BrokerInterceptor#messageProduced`,

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

liangyepianzhou commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1368030805 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java: ## @@ -179,4 +182,57 @@ public void testCloseTransa

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

liangyepianzhou commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1368029765 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java: ## @@ -255,6 +230,40 @@ public long getCommittedTx

Re: [PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

mattisonchao commented on PR #21409: URL: https://github.com/apache/pulsar/pull/21409#issuecomment-1774220932 Question: We calculated facts for the load balancer by NIC limit and usage. If 0 NIC limit and >0 tx and rx will mislead the load balancer? -- This is an automated message f

Re: [PR] [fix][test] Fix LocalBookkeeperEnsemble resource leak in tests [pulsar]

codecov-commenter commented on PR #21407: URL: https://github.com/apache/pulsar/pull/21407#issuecomment-1774201576 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21407?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [drafr] [fix] [client] Fix IO buffer overflow when resend msg after producer reconnect [pulsar]

merlimat commented on PR #21351: URL: https://github.com/apache/pulsar/pull/21351#issuecomment-1774174043 I'm still not sure how it gets to 2GB of accumulated data. The client memory limit backpressure should have blocked long before the 2GB. -- This is an automated message from the

Re: [PR] [improve][pip] PIP-310: Support custom publish rate limiters [pulsar]

grssam commented on code in PR #21399: URL: https://github.com/apache/pulsar/pull/21399#discussion_r1367927955 ## pip/pip-310.md: ## @@ -0,0 +1,121 @@ +# PIP-310 Support custom publish rate limiters + +# Background knowledge + +Pulsar uses rate limiters to control produce and co

Re: [PR] [improve][pip] PIP-310: Support custom publish rate limiters [pulsar]

asafm commented on code in PR #21399: URL: https://github.com/apache/pulsar/pull/21399#discussion_r1367925109 ## pip/pip-310.md: ## @@ -0,0 +1,121 @@ +# PIP-310 Support custom publish rate limiters + +# Background knowledge Review Comment: * Seems reasonable to include an ex

Re: [PR] [improve][pip] PIP-309: Adding Pulsar Client Stats Reporter [pulsar]

asafm commented on PR #21393: URL: https://github.com/apache/pulsar/pull/21393#issuecomment-1774122874 General comment: If you're already touching this, why not close the technical debt one step further, and I'm saying this especially in light of changing public API like adding an in

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

BewareMyPower commented on PR #21402: URL: https://github.com/apache/pulsar/pull/21402#issuecomment-1774120824 > If you don't load the classes twice, but only once, then you are sharing the global variables and this will lead to problems. In addition, @eolivelli's comment makes sense

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

BewareMyPower commented on code in PR #21402: URL: https://github.com/apache/pulsar/pull/21402#discussion_r1367921594 ## pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java: ## @@ -135,21 +143,34 @@ public class NarClassLoader extends URLClassLoader {

[pulsar-client-cpp] branch main updated: Avoid blocking the message listener threads (#332)

This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 6daf7a5 Avoid blocking the message listener

Re: [PR] Avoid blocking the message listener threads [pulsar-client-cpp]

BewareMyPower merged PR #332: URL: https://github.com/apache/pulsar-client-cpp/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

Re: [PR] Dispatcher blocks dispatching once unackMsgs reached max limit [pulsar]

asafm commented on code in PR #399: URL: https://github.com/apache/pulsar/pull/399#discussion_r1367902327 ## pulsar-broker/src/main/java/com/yahoo/pulsar/broker/service/Consumer.java: ## @@ -546,5 +553,15 @@ public Subscription getSubscription() { return subscription;