[PR] [imporve] add func blockIfQueueFull() to encapsulate DisableBlockIfQue… [pulsar-client-go]

2023-10-25 Thread via GitHub
gunli opened a new pull request, #1122: URL: https://github.com/apache/pulsar-client-go/pull/1122 Fixes #1088 Master Issue: #1088 ### Motivation Since `DisableBlockIfQueueFull` is difficult to understand renaming and renaming it is not acceptable, we can add

Re: [PR] [fix][client] Avert extensive time consumption during table view construction [pulsar]

2023-10-25 Thread via GitHub
liangyepianzhou commented on code in PR #21270: URL: https://github.com/apache/pulsar/pull/21270#discussion_r1372662378 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java: ## @@ -235,20 +237,36 @@ private CompletableFuture> readAllExistingMessages(R

Re: [I] Default KeepAliveInterval gets "Detected stale connection to broker" and "Failed to write on connection" errors [pulsar-client-go]

2023-10-25 Thread via GitHub
gunli closed issue #1024: Default KeepAliveInterval gets "Detected stale connection to broker" and "Failed to write on connection" errors URL: https://github.com/apache/pulsar-client-go/issues/1024 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [feat][schema] Introduce BooleanSchema [pulsar-client-go]

2023-10-25 Thread via GitHub
dao-jun commented on code in PR #1108: URL: https://github.com/apache/pulsar-client-go/pull/1108#discussion_r1372612685 ## pulsar/schema.go: ## @@ -178,7 +180,7 @@ func (js *JSONSchema) Decode(data []byte, v interface{}) error { } func (js *JSONSchema) Validate(message []by

[PR] Fix possible deadlock of Future when adding a listener after completed [pulsar-client-cpp]

2023-10-25 Thread via GitHub
BewareMyPower opened a new pull request, #334: URL: https://github.com/apache/pulsar-client-cpp/pull/334 ### Motivation There is a case that deadlock could happen for a `Future`. Assume there is a `Promise` and its `Future`. 1. Call `Future::addListener` to add a listener that

[pulsar] branch branch-2.11 updated: [fix][broker][branch-2.11] Fix inconsistent topic policy (#21257)

2023-10-25 Thread mattisonchao
This is an automated email from the ASF dual-hosted git repository. mattisonchao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new cbbf89fc402 [fix][broker][branch

Re: [PR] [fix][broker][branch-2.11] Fix inconsistent topic policy [pulsar]

2023-10-25 Thread via GitHub
mattisonchao merged PR #21257: URL: https://github.com/apache/pulsar/pull/21257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

Re: [PR] [feat][client] Introduce Refresh API in the TableView [pulsar]

2023-10-25 Thread via GitHub
liangyepianzhou commented on code in PR #21417: URL: https://github.com/apache/pulsar/pull/21417#discussion_r1372561442 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java: ## @@ -232,33 +232,33 @@ private void handleMessage(Message msg) { @Ove

Re: [PR] [feat][client] Introduce Refresh API in the TableView [pulsar]

2023-10-25 Thread via GitHub
codelipenghui commented on code in PR #21417: URL: https://github.com/apache/pulsar/pull/21417#discussion_r1372536188 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/TableView.java: ## @@ -110,4 +110,37 @@ public interface TableView extends Closeable { * @r

Re: [PR] [fix][client] Avert extensive time consumption during table view construction [pulsar]

2023-10-25 Thread via GitHub
codelipenghui commented on code in PR #21270: URL: https://github.com/apache/pulsar/pull/21270#discussion_r1372529642 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java: ## @@ -235,20 +237,36 @@ private CompletableFuture> readAllExistingMessages(Rea

Re: [PR] [improve][broker] Unload concurrency limit during graceful shutdown [pulsar]

2023-10-25 Thread via GitHub
poorbarcode commented on code in PR #20766: URL: https://github.com/apache/pulsar/pull/20766#discussion_r1372532456 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -487,6 +487,13 @@ The delayed message index time step(in seconds) i

[I] [Bug] bookie throughput is larger than broker throughput [pulsar]

2023-10-25 Thread via GitHub
chrisxrepo opened a new issue, #21446: URL: https://github.com/apache/pulsar/issues/21446 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version pulsar 2.10.4 ### Minimal reprod

Re: [PR] [fix][broker] Replicator failed to create remote producer [pulsar]

2023-10-25 Thread via GitHub
hanmz closed pull request #21247: [fix][broker] Replicator failed to create remote producer URL: https://github.com/apache/pulsar/pull/21247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [fix][broker] release orphan replicator after replicator is closed. [pulsar]

2023-10-25 Thread via GitHub
hanmz closed pull request #21203: [fix][broker] release orphan replicator after replicator is closed. URL: https://github.com/apache/pulsar/pull/21203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [improve][broker] PIP-307 Added assignedBrokerUrl to CloseProducerCmd to skip lookups upon producer reconnections during unloading [pulsar]

2023-10-25 Thread via GitHub
Demogorgon314 commented on code in PR #21408: URL: https://github.com/apache/pulsar/pull/21408#discussion_r1372503627 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java: ## @@ -484,14 +485,22 @@ private CompletableFuture delete(

Re: [PR] [feat][schema] Introduce BooleanSchema [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on code in PR #1108: URL: https://github.com/apache/pulsar-client-go/pull/1108#discussion_r1372509152 ## pulsar/schema.go: ## @@ -178,7 +180,7 @@ func (js *JSONSchema) Decode(data []byte, v interface{}) error { } func (js *JSONSchema) Validate(message []b

Re: [PR] [improve][broker] PIP-307 Added assignedBrokerUrl to CloseProducerCmd to skip lookups upon producer reconnections during unloading [pulsar]

2023-10-25 Thread via GitHub
Demogorgon314 commented on code in PR #21408: URL: https://github.com/apache/pulsar/pull/21408#discussion_r1372498930 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2190,8 +2190,10 @@ public CompletableFuture checkTopicNsOwnership(fin

[pulsar] branch master updated: [fix][broker]Create v1/namespace with Policies (#21171)

2023-10-25 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2b5c199053a [fix][broker]Create v1/namespace

Re: [PR] [fix][broker]Create v1/namespace with Policies [pulsar]

2023-10-25 Thread via GitHub
rdhabalia merged PR #21171: URL: https://github.com/apache/pulsar/pull/21171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[PR] [fix][broker] Fix bundle stuck in unloading status [pulsar]

2023-10-25 Thread via GitHub
mattisonchao opened a new pull request, #21445: URL: https://github.com/apache/pulsar/pull/21445 ### Motivation Fix the namespace bundle getting stuck while unloading the namespace bundle by admin. There's a race condition problem, (todo...) ### Modifications - to

Re: [PR] [fix][broker]Create v1/namespace with Policies [pulsar]

2023-10-25 Thread via GitHub
codecov-commenter commented on PR #21171: URL: https://github.com/apache/pulsar/pull/21171#issuecomment-1780293539 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21171?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [I] [Bug] [schema] Not a JSON Object: "string" [pulsar]

2023-10-25 Thread via GitHub
github-actions[bot] commented on issue #21241: URL: https://github.com/apache/pulsar/issues/21241#issuecomment-1780288257 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#5e16ecf)

2023-10-25 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 6f573e69224f Docs sync done from apache/pulsar

[pulsar] branch branch-3.0 updated: [fix] [build] Fix in-correct license definetion (#21435)

2023-10-25 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 153637d919d [fix] [build] Fix in-corr

Re: [PR] [fix] [build] [branch-3.0] Fix in-correct license definetion [pulsar]

2023-10-25 Thread via GitHub
Technoboy- merged PR #21435: URL: https://github.com/apache/pulsar/pull/21435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

[pulsar] branch master updated: [fix][test] Fix resource leaks in LoadBalancerTest (#21443)

2023-10-25 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5e16ecf5007 [fix][test] Fix resource leaks in Loa

Re: [PR] [fix][test] Fix resource leaks in LoadBalancerTest [pulsar]

2023-10-25 Thread via GitHub
tisonkun merged PR #21443: URL: https://github.com/apache/pulsar/pull/21443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [PR] [fix][proxy] Move status endpoint out of auth coverage [pulsar]

2023-10-25 Thread via GitHub
lhotari commented on PR #21428: URL: https://github.com/apache/pulsar/pull/21428#issuecomment-1780211660 > @compuguy We will cherry-pick it to all the active branches. :) it's done now. :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[pulsar] branch branch-3.1 updated: [fix][proxy] Move status endpoint out of auth coverage (#21428)

2023-10-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 1496925f71b [fix][proxy] Move status en

Re: [PR] [fix][proxy] Move status endpoint out of auth coverage [pulsar]

2023-10-25 Thread via GitHub
mattisonchao commented on PR #21428: URL: https://github.com/apache/pulsar/pull/21428#issuecomment-1780210820 @compuguy We will cherry-pick it to all the active branches. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[pulsar] branch branch-3.0 updated: [fix][proxy] Move status endpoint out of auth coverage (#21428)

2023-10-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new df4b0d8ff16 [fix][proxy] Move status en

[I] Allow to update application.properties for pulsar-manage [pulsar-helm-chart]

2023-10-25 Thread via GitHub
splix opened a new issue, #400: URL: https://github.com/apache/pulsar-helm-chart/issues/400 **Is your feature request related to a problem? Please describe.** `pulsar-manager` pod comes with the following `application.properties`: ``` ... # If user.management.enable is true, t

Re: [PR] [fix][sec] Upgrade snappy-java to 1.1.10.5 [pulsar]

2023-10-25 Thread via GitHub
lhotari commented on PR #21280: URL: https://github.com/apache/pulsar/pull/21280#issuecomment-1780187587 @compuguy I have backported this to branch-2.11, branch-3.0 and branch-3.1 . This will be delivered as part of the next set of releases when that happens. -- This is an automated messa

[pulsar] branch branch-3.0 updated (77d20857911 -> 0923080070e)

2023-10-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 77d20857911 [feat][meta] Upgrade to jetcd to 0.7.5 (#20339) add 0923080070e [fix][sec] Upgrade snappy-java t

[pulsar] branch branch-3.1 updated: [fix][sec] Upgrade snappy-java to 1.1.10.5 (#21280)

2023-10-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 8e5f00ecd77 [fix][sec] Upgrade snappy-j

[pulsar] branch branch-2.11 updated: [fix][sec] Upgrade snappy-java to 1.1.10.5 (#21280)

2023-10-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 476b4a02d4a [fix][sec] Upgrade snappy

Re: [PR] [fix][sec] Upgrade snappy-java to 1.1.10.5 [pulsar]

2023-10-25 Thread via GitHub
lhotari commented on PR #21280: URL: https://github.com/apache/pulsar/pull/21280#issuecomment-1780182803 > Will this PR be backported to the 3.1.x branch? This would reduce the number of high CVE's apache-pulsar currently has. @compuguy yes, this will be backported. -- This is an a

Re: [PR] [fix][sec] Upgrade snappy-java to 1.1.10.5 [pulsar]

2023-10-25 Thread via GitHub
compuguy commented on PR #21280: URL: https://github.com/apache/pulsar/pull/21280#issuecomment-1780164591 Will this PR be backported to the 3.1.x branch? This would reduce the number of high CVE's apache-pulsar currently has. -- This is an automated message from the Apache Git Service. To

Re: [PR] [fix][proxy] Move status endpoint out of auth coverage [pulsar]

2023-10-25 Thread via GitHub
compuguy commented on PR #21428: URL: https://github.com/apache/pulsar/pull/21428#issuecomment-1780128695 Is there any way for this merge request to be put into a 3.1.x release? Not having the status.html behind authentication breaks most Kubernetes helm charts that use `/status.html` for l

Re: [PR] Bump google.golang.org/grpc from 1.38.0 to 1.53.0 in /pulsar-function-go [pulsar]

2023-10-25 Thread via GitHub
dependabot[bot] closed pull request #20726: Bump google.golang.org/grpc from 1.38.0 to 1.53.0 in /pulsar-function-go URL: https://github.com/apache/pulsar/pull/20726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump google.golang.org/grpc from 1.38.0 to 1.53.0 in /pulsar-function-go [pulsar]

2023-10-25 Thread via GitHub
dependabot[bot] commented on PR #20726: URL: https://github.com/apache/pulsar/pull/20726#issuecomment-1780096853 Superseded by #21444. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump google.golang.org/grpc from 1.38.0 to 1.56.3 in /pulsar-function-go [pulsar]

2023-10-25 Thread via GitHub
dependabot[bot] opened a new pull request, #21444: URL: https://github.com/apache/pulsar/pull/21444 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.38.0 to 1.56.3. Release notes Sourced from https://github.com/grpc/grpc-go/releases";>google.golang.org/grpc's

Re: [PR] Bump google.golang.org/grpc from 1.38.0 to 1.56.3 in /pulsar-function-go [pulsar]

2023-10-25 Thread via GitHub
github-actions[bot] commented on PR #21444: URL: https://github.com/apache/pulsar/pull/21444#issuecomment-1780097442 @dependabot[bot] Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` -

[pulsar] branch dependabot/go_modules/pulsar-function-go/google.golang.org/grpc-1.53.0 deleted (was 783d2534f90)

2023-10-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/pulsar-function-go/google.golang.org/grpc-1.53.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git was 783d2534f90 Bump google.golang.org/grpc from 1.38

[pulsar] branch dependabot/go_modules/pulsar-function-go/google.golang.org/grpc-1.56.3 created (now 186be95f070)

2023-10-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/pulsar-function-go/google.golang.org/grpc-1.56.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git at 186be95f070 Bump google.golang.org/grpc from 1.38

[pulsar] branch master updated: [feat] [broker] PIP-188 Fix cluster migration state store into local namespace policies (#21363)

2023-10-25 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3a9f99f03db [feat] [broker] PIP-188 Fix clust

Re: [PR] [feat] [broker] PIP-188 Fix cluster migration state store into local namespace policies [pulsar]

2023-10-25 Thread via GitHub
rdhabalia merged PR #21363: URL: https://github.com/apache/pulsar/pull/21363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

Re: [PR] [fix][test] Fix resource leaks in LoadBalancerTest [pulsar]

2023-10-25 Thread via GitHub
codecov-commenter commented on PR #21443: URL: https://github.com/apache/pulsar/pull/21443#issuecomment-1780005965 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix][sec] Upgrade Zookeeper to 3.8.3 to address CVE-2023-44981 [pulsar]

2023-10-25 Thread via GitHub
compuguy commented on PR #21398: URL: https://github.com/apache/pulsar/pull/21398#issuecomment-1779721912 Out of curiosity, because of the severity of CVE-2023-44981, will this cherry picked to fix the recent release of 3.1.1? Or will 3.1.2 be expedited? -- This is an automated message fr

Re: [I] [Bug] CPP/Python Logger cannot be changed between different clients. First one set stays for all Pulsar Clients [pulsar-client-cpp]

2023-10-25 Thread via GitHub
BewareMyPower commented on issue #333: URL: https://github.com/apache/pulsar-client-cpp/issues/333#issuecomment-1779700758 Yeah, it's the design flaw of the logger config in this library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [improve][pip] PIP-310: Support custom publish rate limiters [pulsar]

2023-10-25 Thread via GitHub
asafm commented on PR #21399: URL: https://github.com/apache/pulsar/pull/21399#issuecomment-1779534495 Ok @grssam - ping me when you updated it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[pulsar] branch branch-2.11 updated: [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients (#21429)

2023-10-25 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 0b0d15f9d27 [fix][broker] Fix Multi

[pulsar] branch master updated: [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients (#21429)

2023-10-25 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 80569879193 [fix][broker] Fix MultiRoles toke

Re: [PR] [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients [pulsar]

2023-10-25 Thread via GitHub
Technoboy- merged PR #21429: URL: https://github.com/apache/pulsar/pull/21429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

[pulsar] branch master updated: [fix][broker] Intercept REDELIVER_UNACKNOWLEDGED_MESSAGES command (#21265)

2023-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bd3de15d8ca [fix][broker] Intercept REDELIVER_U

Re: [PR] [fix][broker] Intercept REDELIVER_UNACKNOWLEDGED_MESSAGES command [pulsar]

2023-10-25 Thread via GitHub
codelipenghui merged PR #21265: URL: https://github.com/apache/pulsar/pull/21265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients [pulsar]

2023-10-25 Thread via GitHub
Technoboy- commented on code in PR #21429: URL: https://github.com/apache/pulsar/pull/21429#discussion_r1371897473 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataSubscription.java: ## @@ -71,4 +71,8 @@ public boolean hasSubscripti

[PR] [fix][test] Fix resource leaks in LoadBalancerTest [pulsar]

2023-10-25 Thread via GitHub
lhotari opened a new pull request, #21443: URL: https://github.com/apache/pulsar/pull/21443 ### Motivation LoadBalancerTest leaks some threads. ### Modifications - remove the unused thread pool - while debugging, it revealed that testLeaderElection method caused some

Re: [PR] [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients [pulsar]

2023-10-25 Thread via GitHub
nodece commented on code in PR #21429: URL: https://github.com/apache/pulsar/pull/21429#discussion_r1371777873 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataSubscription.java: ## @@ -71,4 +71,8 @@ public boolean hasSubscription()

[pulsar] branch master updated: [fix][broker] Ignore individual acknowledgment for CompactorSubscription when an entry has been filtered. (#21434)

2023-10-25 Thread zhaocong
This is an automated email from the ASF dual-hosted git repository. zhaocong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d3216d2f391 [fix][broker] Ignore individual ac

Re: [PR] [fix][broker] Ignore individual acknowledgment for CompactorSubscription when an entry has been filtered. [pulsar]

2023-10-25 Thread via GitHub
coderzc merged PR #21434: URL: https://github.com/apache/pulsar/pull/21434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[PR] [feat] Support schema field type promotion [pulsar-client-python]

2023-10-25 Thread via GitHub
RobertIndie opened a new pull request, #159: URL: https://github.com/apache/pulsar-client-python/pull/159 ## Motivation The client is not correctly following [Avro's type promotion rules](https://avro.apache.org/docs/1.11.1/specification/#schema-resolution), leading to a potential pr

Re: [I] [Improve][Producer]Simplify the MaxPendingMessages controlling [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun closed issue #1043: [Improve][Producer]Simplify the MaxPendingMessages controlling URL: https://github.com/apache/pulsar-client-go/issues/1043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] fix: normalize all send request resource release into sr.done [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun merged PR #1121: URL: https://github.com/apache/pulsar-client-go/pull/1121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] fix: normalize all send request resource release into sr.done [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on PR #1121: URL: https://github.com/apache/pulsar-client-go/pull/1121#issuecomment-1779085359 Merging... Thanks for your review! Further improvement can be made as described above. -- This is an automated message from the Apache Git Service. To respond to

[pulsar-client-go] branch master updated: fix: normalize all send request resource release into sr.done (#1121)

2023-10-25 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 7c14fb7a fix: normalize all send reques

Re: [I] [Bug][Producer]Inaccurate transaction endSendOrAckOp for chunked message [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun closed issue #1060: [Bug][Producer]Inaccurate transaction endSendOrAckOp for chunked message URL: https://github.com/apache/pulsar-client-go/issues/1060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371565167 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

Re: [PR] [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients [pulsar]

2023-10-25 Thread via GitHub
Technoboy- commented on code in PR #21429: URL: https://github.com/apache/pulsar/pull/21429#discussion_r1371561372 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataSubscription.java: ## @@ -71,4 +71,8 @@ public boolean hasSubscripti

Re: [I] [Bug] Client with shared subscription is blocked [pulsar]

2023-10-25 Thread via GitHub
poorbarcode commented on issue #21104: URL: https://github.com/apache/pulsar/issues/21104#issuecomment-1779028476 @michalcukierman I left a comment [here](https://github.com/apache/pulsar/issues/21082#issuecomment-1778909021) -- This is an automated message from the Apache Git Ser

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
tisonkun commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371534349 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371521169 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371495133 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

Re: [I] [BUG] The capacity of dataChan is too big [pulsar-client-go]

2023-10-25 Thread via GitHub
Gleiphir2769 commented on issue #1067: URL: https://github.com/apache/pulsar-client-go/issues/1067#issuecomment-1778948276 Because we acquire publishSemaphore after the consumption of dataChan. In some cases we may need to keep twice the number of MaxPendingMessages messages in memory. And

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371495133 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371493701 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371492219 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-25 Thread via GitHub
entvex commented on code in PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#discussion_r1371491523 ## docs/release-process.md: ## @@ -0,0 +1,206 @@ + + +This guide illustrates how to perform a release for Apache DotPulsar. + +In general, you need to perform th

[I] [Bug] RateLimiter lock contention when use precise publish rate limiter [pulsar]

2023-10-25 Thread via GitHub
Shawyeok opened a new issue, #21442: URL: https://github.com/apache/pulsar/issues/21442 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version After enabled the `preciseTopicPublishRat

Re: [I] [Bug] one topic suddenly cannot be consumed,others is ok [pulsar]

2023-10-25 Thread via GitHub
poorbarcode commented on issue #21082: URL: https://github.com/apache/pulsar/issues/21082#issuecomment-1778915699 @MichalKoziorowski-TomTom Thanks for explaining [the details of the issue](https://github.com/apache/pulsar/issues/21082#issuecomment-1699184180), I will try to reproduc

Re: [I] [Bug] one topic suddenly cannot be consumed,others is ok [pulsar]

2023-10-25 Thread via GitHub
poorbarcode commented on issue #21082: URL: https://github.com/apache/pulsar/issues/21082#issuecomment-1778909021 @michalcukierman I will try this case: https://github.com/apache/pulsar/issues/21082#issuecomment-1698836870, if I could not reproduce this case, I will ask you for the

Re: [I] [Bug] one topic suddenly cannot be consumed,others is ok [pulsar]

2023-10-25 Thread via GitHub
poorbarcode commented on issue #21082: URL: https://github.com/apache/pulsar/issues/21082#issuecomment-1778903239 @kadlmt > I've removed:ackTimeout(ackTimeout, TimeUnit.SECONDS) > The consumer still can't receive the messages,must restart the broker Could it be solved by res

Re: [PR] [fix][broker] Fix MultiRoles token provider NPE when using anonymous clients [pulsar]

2023-10-25 Thread via GitHub
nodece commented on code in PR #21429: URL: https://github.com/apache/pulsar/pull/21429#discussion_r1371435671 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataSubscription.java: ## @@ -71,4 +71,8 @@ public boolean hasSubscription()

Re: [PR] fix: normalize all send request resource release into sr.done [pulsar-client-go]

2023-10-25 Thread via GitHub
gunli commented on PR #1121: URL: https://github.com/apache/pulsar-client-go/pull/1121#issuecomment-1778863094 I think it is OK, well done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [fix] [broker] [branch-2.11] Fix isolated group not work problem [pulsar]

2023-10-25 Thread via GitHub
horizonzy commented on PR #21415: URL: https://github.com/apache/pulsar/pull/21415#issuecomment-1778856115 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] fix: normalize all send request resource release into sr.done [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on code in PR #1121: URL: https://github.com/apache/pulsar-client-go/pull/1121#discussion_r1371370424 ## pulsar/message_chunking_test.go: ## @@ -531,12 +532,13 @@ func TestChunkBlockIfQueueFull(t *testing.T) { assert.NotNil(t, producer) defer p

Re: [PR] fix: normalize all send request resource release into sr.done [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on code in PR #1121: URL: https://github.com/apache/pulsar-client-go/pull/1121#discussion_r1371368896 ## pulsar/producer_partition.go: ## @@ -1257,55 +1229,40 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendReceipt)

Re: [I] [BUG] The capacity of dataChan is too big [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on issue #1067: URL: https://github.com/apache/pulsar-client-go/issues/1067#issuecomment-1778767653 > This is because we use publishSemaphore instead of capacity of dataChan to limit pending messages. The actual limit is 2X of MaxPendingMessages. What does it m

Re: [PR] [fix] [issue 1067] Fix the excessive dataChan capacity [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun closed pull request #1068: [fix] [issue 1067] Fix the excessive dataChan capacity URL: https://github.com/apache/pulsar-client-go/pull/1068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [fix] [issue 1067] Fix the excessive dataChan capacity [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on PR #1068: URL: https://github.com/apache/pulsar-client-go/pull/1068#issuecomment-1778763440 Closing... You may review #1121 and I still think that we can have a much better solution than even after #1121 merged. -- This is an automated message from the Apache

Re: [PR] [fix][broker] Intercept REDELIVER_UNACKNOWLEDGED_MESSAGES command [pulsar]

2023-10-25 Thread via GitHub
kecona commented on PR #21265: URL: https://github.com/apache/pulsar/pull/21265#issuecomment-1778750831 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [fix] [broker] [branch-2.11] Fix isolated group not work problem [pulsar]

2023-10-25 Thread via GitHub
shibd closed pull request #21415: [fix] [broker] [branch-2.11] Fix isolated group not work problem URL: https://github.com/apache/pulsar/pull/21415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[I] DeadLetterPolicy supports specifying producerName [pulsar]

2023-10-25 Thread via GitHub
crossoverJie opened a new issue, #21441: URL: https://github.com/apache/pulsar/issues/21441 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation The current `DeadLetterProducerNam

Re: [PR] refactor: prepare sendrequest and move to internalSendAsync [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun merged PR #1120: URL: https://github.com/apache/pulsar-client-go/pull/1120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] refactor: prepare sendrequest and move to internalSendAsync [pulsar-client-go]

2023-10-25 Thread via GitHub
tisonkun commented on PR #1120: URL: https://github.com/apache/pulsar-client-go/pull/1120#issuecomment-1778689777 Merging... I'm rebasing #1121 onto this patch to fix two resource management issues with a unsplittable refactor. -- This is an automated message from the Apache Git S

[pulsar-client-go] branch master updated: refactor: prepare sendrequest and move to internalSendAsync (#1120)

2023-10-25 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 793008e7 refactor: prepare sendrequest

[pulsar] branch branch-2.11 updated: [improve][broker][branch-2.11] Make read compacted entries support maxReadSizeBytes limitation (#21065) (#21430)

2023-10-25 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 505834a6ab4 [improve][broker][branch-2.

Re: [PR] [improve][broker][branch-2.11] Make read compacted entries support maxReadSizeBytes limitation (#21065) [pulsar]

2023-10-25 Thread via GitHub
shibd merged PR #21430: URL: https://github.com/apache/pulsar/pull/21430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apac