Re: [PR] Create a producerName field for DeadLetterPolicy [pulsar]

2023-10-30 Thread via GitHub
crossoverJie closed pull request #21482: Create a producerName field for DeadLetterPolicy URL: https://github.com/apache/pulsar/pull/21482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Create a producerName field for DeadLetterPolicy [pulsar]

2023-10-30 Thread via GitHub
crossoverJie opened a new pull request, #21482: URL: https://github.com/apache/pulsar/pull/21482 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] [Bug] Deadlock occurs when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
erobot commented on issue #21480: URL: https://github.com/apache/pulsar/issues/21480#issuecomment-1786528331 https://github.com/erobot/pulsar/pull/4/files#diff-8ec7d424cb86168772c78df6310c07693728cb72abd904916f1fb9f519edf131 @mattisonchao @horizonzy I have checked the master and also

Re: [I] [Bug] Deadlock occurs when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
horizonzy commented on issue #21480: URL: https://github.com/apache/pulsar/issues/21480#issuecomment-1786514215 Ok, I will check it. Thanks report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] Log flow commands before sending to broker [pulsar-client-go]

2023-10-30 Thread via GitHub
GPrabhudas opened a new issue, #1124: URL: https://github.com/apache/pulsar-client-go/issues/1124 Just we like how the [received command is logged ](https://github.com/apache/pulsar-client-go/blob/master/pulsar/internal/connection_reader.go#L59)on receiving from broker, It will be helpful

Re: [PR] [fix][broker] Fix resource_quota_zpath [pulsar]

2023-10-30 Thread via GitHub
AnonHxy commented on PR #21461: URL: https://github.com/apache/pulsar/pull/21461#issuecomment-1786482035 Hi @liudezhi2098 . This patch will not lead incompatible issue I think: 1. Resource quotas are written to `/loadbalance/resource-quota` only by `BundlesQuotas`. ht

Re: [I] [Bug] Deadlock occurs when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
mattisonchao commented on issue #21480: URL: https://github.com/apache/pulsar/issues/21480#issuecomment-1786467833 @horizonzy could you please help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Bug] Deadlock occurs when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
mattisonchao commented on issue #21480: URL: https://github.com/apache/pulsar/issues/21480#issuecomment-1786466852 Hi @erobot Have you checked the master branch version, I think this problem may fixed. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [fix][broker] Fix the deadlock when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
erobot closed pull request #21481: [fix][broker] Fix the deadlock when using BookieRackAffinityMapping with rackaware policy URL: https://github.com/apache/pulsar/pull/21481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [fix][broker] Fix the deadlock when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
github-actions[bot] commented on PR #21481: URL: https://github.com/apache/pulsar/pull/21481#issuecomment-1786431094 @erobot Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc

[PR] [fix][broker] Fix the deadlock when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
erobot opened a new pull request, #21481: URL: https://github.com/apache/pulsar/pull/21481 …ith rackaware policy Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verify

[I] [Bug] Deadlock occurs when using BookieRackAffinityMapping with rackaware policy [pulsar]

2023-10-30 Thread via GitHub
erobot opened a new issue, #21480: URL: https://github.com/apache/pulsar/issues/21480 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version OS: Linux Pulsar: 2.10.4 ### Mini

Re: [I] Flaky-test: ExtensibleLoadManagerImplTest.testMoreThenOneFilter [pulsar]

2023-10-30 Thread via GitHub
Demogorgon314 commented on issue #21476: URL: https://github.com/apache/pulsar/issues/21476#issuecomment-1786361808 https://github.com/apache/pulsar/pull/21479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Flaky-test: ExtensibleLoadManagerImplTest.testCheckOwnershipAsync [pulsar]

2023-10-30 Thread via GitHub
Demogorgon314 commented on issue #21469: URL: https://github.com/apache/pulsar/issues/21469#issuecomment-1786361755 https://github.com/apache/pulsar/pull/21479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] [fix][test] Fix ExtensibleLoadManagerImplTest flaky test [pulsar]

2023-10-30 Thread via GitHub
Demogorgon314 opened a new pull request, #21479: URL: https://github.com/apache/pulsar/pull/21479 ### Motivation The `__change_events` topic will be owned before the test method starts, so the `testMoreThenOneFilter` and `testCheckOwnershipAsync` might be flaky since the bundle is al

Re: [PR] [fix] Fixed an issue where clients were unintentionally disconnected [pulsar-client-node]

2023-10-30 Thread via GitHub
kontotto commented on PR #348: URL: https://github.com/apache/pulsar-client-node/pull/348#issuecomment-1786356282 I noticed that this change leaks memory, so I made it into a draft once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
BewareMyPower commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376992566 ## lib/ConnectionPool.cc: ## @@ -107,7 +108,7 @@ Future ConnectionPool::getConnectionAsync( LOG_INFO("Created connection for " << logicalAddress);

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
BewareMyPower commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376990807 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& con

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
RobertIndie commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376988417 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& conf,

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
BewareMyPower commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376963053 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& con

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
BewareMyPower commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376990180 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& con

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
RobertIndie commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376988417 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& conf,

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
RobertIndie commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376984314 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& conf,

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
RobertIndie commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376980677 ## lib/ClientConfiguration.cc: ## @@ -40,6 +40,13 @@ ClientConfiguration& ClientConfiguration::setMemoryLimit(uint64_t memoryLimitByt uint64_t ClientCon

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
BewareMyPower commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376964472 ## lib/ClientConfiguration.cc: ## @@ -40,6 +40,13 @@ ClientConfiguration& ClientConfiguration::setMemoryLimit(uint64_t memoryLimitByt uint64_t ClientC

Re: [PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
BewareMyPower commented on code in PR #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336#discussion_r1376963053 ## lib/ConnectionPool.cc: ## @@ -34,13 +34,13 @@ DECLARE_LOG_OBJECT() namespace pulsar { ConnectionPool::ConnectionPool(const ClientConfiguration& con

(pulsar-client-python) branch main updated: Support Python 3.12 wheels (#160)

2023-10-30 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new 99d65d3 Support Python 3.12 wheels (#160

Re: [PR] Support Python 3.12 wheels [pulsar-client-python]

2023-10-30 Thread via GitHub
BewareMyPower merged PR #160: URL: https://github.com/apache/pulsar-client-python/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

Re: [I] Not available for Python 3.12 [pulsar-client-python]

2023-10-30 Thread via GitHub
BewareMyPower closed issue #156: Not available for Python 3.12 URL: https://github.com/apache/pulsar-client-python/issues/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix][broker] Fix resource_quota_zpath [pulsar]

2023-10-30 Thread via GitHub
liudezhi2098 commented on PR #21461: URL: https://github.com/apache/pulsar/pull/21461#issuecomment-1786288287 This will lead to incompatibility between versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Flaky-test: ExtensibleLoadManagerImplTest.testCheckOwnershipAsync [pulsar]

2023-10-30 Thread via GitHub
Demogorgon314 commented on issue #21469: URL: https://github.com/apache/pulsar/issues/21469#issuecomment-1786261602 @lhotari Sure, I will check this flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Broker features [pulsar-site]

2023-10-30 Thread via GitHub
codelipenghui commented on code in PR #720: URL: https://github.com/apache/pulsar-site/pull/720#discussion_r1376923194 ## data/broker-features.js: ## @@ -0,0 +1,255 @@ +export default [ +{ +feature: "Produce / Exclusive", +stableSince: "2.2.0", Review Commen

[PR] [fix] Fixed an issue where clients were unintentionally disconnected [pulsar-client-node]

2023-10-30 Thread via GitHub
kontotto opened a new pull request, #348: URL: https://github.com/apache/pulsar-client-node/pull/348 This PR fixes an issue where client connections could be unintentionally disconnected. ### Motivation In the code below, which is a modified version of examples/con

[PR] Added support for multiple connections to each broker [pulsar-client-cpp]

2023-10-30 Thread via GitHub
merlimat opened a new pull request, #336: URL: https://github.com/apache/pulsar-client-cpp/pull/336 Fixes #221 ### Motivation Support having more than 1 connection to each broker. -- This is an automated message from the Apache Git Service. To respond to the messa

(pulsar-client-cpp) branch main updated: Fix possible deadlock of Future when adding a listener after completed (#334)

2023-10-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 77e2d63 Fix possible deadlock of Future

Re: [PR] Fix possible deadlock of Future when adding a listener after completed [pulsar-client-cpp]

2023-10-30 Thread via GitHub
merlimat merged PR #334: URL: https://github.com/apache/pulsar-client-cpp/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

[PR] Support Python 3.12 wheels [pulsar-client-python]

2023-10-30 Thread via GitHub
merlimat opened a new pull request, #160: URL: https://github.com/apache/pulsar-client-python/pull/160 Fix #156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Not available for Python 3.12 [pulsar-client-python]

2023-10-30 Thread via GitHub
rongxin-liu commented on issue #156: URL: https://github.com/apache/pulsar-client-python/issues/156#issuecomment-1786117822 We are running into the same issue with Python 3.12. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [Bug] Bookkeeper returns mac mismatch while reading [pulsar]

2023-10-30 Thread via GitHub
KannarFr commented on issue #21421: URL: https://github.com/apache/pulsar/issues/21421#issuecomment-1786115254 Looks fixed in 3.1.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(pulsar) branch master updated: [improve][ci] Ignore Testcontainers background threads in ThreadLeakDetectorListener (#21472)

2023-10-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bc84721694a [improve][ci] Ignore Testcontainers

Re: [PR] [improve][ci] Ignore Testcontainers background threads in ThreadLeakDetectorListener [pulsar]

2023-10-30 Thread via GitHub
lhotari merged PR #21472: URL: https://github.com/apache/pulsar/pull/21472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated: [fix][test] Fix multiple thread leaks in Broker Group 1 unit tests (#21475)

2023-10-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3519fa0a694 [fix][test] Fix multiple thread lea

Re: [PR] [fix][test] Fix multiple thread leaks in Broker Group 1 unit tests [pulsar]

2023-10-30 Thread via GitHub
lhotari merged PR #21475: URL: https://github.com/apache/pulsar/pull/21475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[I] Pulsar site's social media preview image is missing :( [pulsar]

2023-10-30 Thread via GitHub
visortelle opened a new issue, #21478: URL: https://github.com/apache/pulsar/issues/21478 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation There should be some eye-attracting

[PR] [fix][test] Add MockedPulsarServiceBaseTest.registerCloseable and continue fixing thread leaks [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new pull request, #21477: URL: https://github.com/apache/pulsar/pull/21477 ### Motivation There are many thread leaks in tests. ### Modifications - Continue fixing the thread leaks. - Add `registerCloseable` method to MockedPulsarServiceBaseTest which

Re: [I] Flaky-test: ExtensibleLoadManagerImplTest.initializeState [pulsar]

2023-10-30 Thread via GitHub
lhotari commented on issue #20157: URL: https://github.com/apache/pulsar/issues/20157#issuecomment-1785784246 This problem doesn't seem to be fixed. A recent failure at https://github.com/apache/pulsar/actions/runs/6695386428/job/18191579828?pr=21475#step:11:1237 ``` Error: Tes

[I] Flaky-test: ExtensibleLoadManagerImplTest.initializeState [pulsar]

2023-10-30 Thread via GitHub
lifepuzzlefun opened a new issue, #20157: URL: https://github.com/apache/pulsar/issues/20157 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pu

Re: [I] [Bug] ModularLoadManager is not shedding with UniformLoadShedder strategy [pulsar]

2023-10-30 Thread via GitHub
heesung-sn closed issue #21299: [Bug] ModularLoadManager is not shedding with UniformLoadShedder strategy URL: https://github.com/apache/pulsar/issues/21299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Bug] ModularLoadManager is not shedding with UniformLoadShedder strategy [pulsar]

2023-10-30 Thread via GitHub
ThomasTaketurns commented on issue #21299: URL: https://github.com/apache/pulsar/issues/21299#issuecomment-1785608895 Hi @heesung-sn , Thanks for the quick feedback. I applied your recommandation and it seems to do the job. Let me perform a few more tests and I will close the

Re: [PR] [improve][ci] Disable Gradle Enterprise unless GRADLE_ENTERPRISE_ACCESS_KEY is set [pulsar]

2023-10-30 Thread via GitHub
lhotari commented on PR #21474: URL: https://github.com/apache/pulsar/pull/21474#issuecomment-1785568900 > @lhotari - Thanks for the ping here. We will investigate what is going on here and let you know. I have involved our test team here to determine the cause of the issue you are seeing.

(pulsar) branch master updated: [improve][ci] Disable Gradle Enterprise unless GRADLE_ENTERPRISE_ACCESS_KEY is set (#21474)

2023-10-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5ab177d0a54 [improve][ci] Disable Gradle Enterp

Re: [PR] [improve][ci] Disable Gradle Enterprise unless GRADLE_ENTERPRISE_ACCESS_KEY is set [pulsar]

2023-10-30 Thread via GitHub
lhotari merged PR #21474: URL: https://github.com/apache/pulsar/pull/21474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [I] [Bug] ModularLoadManager is not shedding with UniformLoadShedder strategy [pulsar]

2023-10-30 Thread via GitHub
heesung-sn commented on issue #21299: URL: https://github.com/apache/pulsar/issues/21299#issuecomment-1785536827 `loadBalancerBundleUnloadMinThroughputThreshold=0` Please try to set this config to zero in broker.conf -- This is an automated message from the Apache Git Service. To re

Re: [I] [Bug] ModularLoadManager is not shedding with UniformLoadShedder strategy [pulsar]

2023-10-30 Thread via GitHub
ThomasTaketurns commented on issue #21299: URL: https://github.com/apache/pulsar/issues/21299#issuecomment-1785498101 Hi @heesung-sn , By applying your recommandations, I was able to make the UniformLoadShedder trigger bundles unloading. I still need to tune it to make it efficient

(pulsar) branch master updated (cad3c464be0 -> 5809c0327f3)

2023-10-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from cad3c464be0 [cleanup][broker] Delete methods marked Lombok @Getter (#21462) add 5809c0327f3 [fix][ci] Use corre

Re: [PR] [fix][ci] Use correct annotation to prevent resource leaks in Elastic integration tests [pulsar]

2023-10-30 Thread via GitHub
lhotari merged PR #21471: URL: https://github.com/apache/pulsar/pull/21471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [I] Flaky-test: ExtensibleLoadManagerImplTest.testCheckOwnershipAsync [pulsar]

2023-10-30 Thread via GitHub
lhotari commented on issue #21469: URL: https://github.com/apache/pulsar/issues/21469#issuecomment-1785474608 @Demogorgon314 would you mind checking this flaky test? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Flaky-test: ExtensibleLoadManagerImplTest.testMoreThenOneFilter [pulsar]

2023-10-30 Thread via GitHub
lhotari commented on issue #21476: URL: https://github.com/apache/pulsar/issues/21476#issuecomment-1785472341 @Demogorgon314 would you mind checking this flaky test? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[I] Flaky-test: ExtensibleLoadManagerImplTest.testMoreThenOneFilter [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new issue, #21476: URL: https://github.com/apache/pulsar/issues/21476 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/

Re: [PR] [fix][ci] Use correct annotation to prevent resource leaks in Elastic integration tests [pulsar]

2023-10-30 Thread via GitHub
codecov-commenter commented on PR #21471: URL: https://github.com/apache/pulsar/pull/21471#issuecomment-1785465553 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [improve][client] add custom probes for cluster auto failover [pulsar]

2023-10-30 Thread via GitHub
wojtekkedzior closed pull request #21470: [improve][client] add custom probes for cluster auto failover URL: https://github.com/apache/pulsar/pull/21470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [improve][ci] Disable Gradle Enterprise unless GRADLE_ENTERPRISE_ACCESS_KEY is set [pulsar]

2023-10-30 Thread via GitHub
clayburn commented on PR #21474: URL: https://github.com/apache/pulsar/pull/21474#issuecomment-1785441018 @lhotari - Thanks for the ping here. We will investigate what is going on here and let you know. I have involved our test team here to determine the cause of the issue you are seeing. W

Re: [I] [Bug] python function does not respect `--retain-ordering` flag [pulsar]

2023-10-30 Thread via GitHub
tisonkun closed issue #17776: [Bug] python function does not respect `--retain-ordering` flag URL: https://github.com/apache/pulsar/issues/17776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Bug] python function does not respect `--retain-ordering` flag [pulsar]

2023-10-30 Thread via GitHub
tisonkun commented on issue #17776: URL: https://github.com/apache/pulsar/issues/17776#issuecomment-1785408727 Closed as answred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] [Bug] python function does not respect `--retain-ordering` flag [pulsar]

2023-10-30 Thread via GitHub
dionjansen commented on issue #17776: URL: https://github.com/apache/pulsar/issues/17776#issuecomment-1785385001 > so the `--retain-ordering` just ensures the order of msgs that can be processed successfully @jiangpengcheng clear, then indeed I have misunderstood the description for

Re: [I] [Bug] JVM crash in unit tests: PhaseIdealLoop::build_loop_late_post_work [pulsar]

2023-10-30 Thread via GitHub
hpvd commented on issue #19307: URL: https://github.com/apache/pulsar/issues/19307#issuecomment-1785384163 this issue still has label stale, see https://github.com/apache/pulsar/issues/21458 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] [Bug] Processing of issues via bot: stale label is set but not removed [pulsar]

2023-10-30 Thread via GitHub
hpvd commented on issue #21458: URL: https://github.com/apache/pulsar/issues/21458#issuecomment-1785378521 at least in may there was an auto removal of stale label: example: https://github.com/apache/pulsar/issues/19307 ![2023-10-30_15h44_16](https://github.com/apache/pulsar

[I] [Bug] JVM crash in unit tests: PhaseIdealLoop::build_loop_late_post_work [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new issue, #19307: URL: https://github.com/apache/pulsar/issues/19307 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 9e698b62 ### Minimal reproduce step

Re: [I] [Bug] JVM crash in unit tests: PhaseIdealLoop::build_loop_late_post_work [pulsar]

2023-10-30 Thread via GitHub
lhotari commented on issue #19307: URL: https://github.com/apache/pulsar/issues/19307#issuecomment-1785353544 it happened again in pulsar-metadata tests. ``` Current thread (0x7f927808ed70): JavaThread "C2 CompilerThread0" daemon [_thread_in_native, id=4012, stack(0x7f8ff

Re: [PR] Fix possible deadlock of Future when adding a listener after completed [pulsar-client-cpp]

2023-10-30 Thread via GitHub
shibd commented on code in PR #334: URL: https://github.com/apache/pulsar-client-cpp/pull/334#discussion_r1376254895 ## lib/Future.h: ## @@ -38,71 +35,70 @@ class InternalState { using Pair = std::pair; using Lock = std::unique_lock; +enum Status : uint8_t +{

Re: [PR] [improve][ci] Disable Gradle Enterprise unless GRADLE_ENTERPRISE_ACCESS_KEY is set [pulsar]

2023-10-30 Thread via GitHub
lhotari commented on PR #21474: URL: https://github.com/apache/pulsar/pull/21474#issuecomment-1785254273 @clayburn do you have a chance to review this PR too? Any explanation for "Internal error in Gradle Enterprise Maven extension: Failed to capture test events" ? There were a few of such

Re: [PR] Fix possible deadlock of Future when adding a listener after completed [pulsar-client-cpp]

2023-10-30 Thread via GitHub
shibd commented on code in PR #334: URL: https://github.com/apache/pulsar-client-cpp/pull/334#discussion_r1376254895 ## lib/Future.h: ## @@ -38,71 +35,70 @@ class InternalState { using Pair = std::pair; using Lock = std::unique_lock; +enum Status : uint8_t +{

[PR] [fix][test] Fix multiple thread leaks in Broker Group 1 unit tests [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new pull request, #21475: URL: https://github.com/apache/pulsar/pull/21475 ### Motivation There are thread leaks in tests. ### Modifications Fix multiple thread leaks in Broker Group 1 unit tests. ### Documentation - [ ] `doc` -

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-30 Thread via GitHub
RobertIndie commented on PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#issuecomment-1785218991 @blankensteiner I'm not referring to the Git 101 "how to" doc. For this statement: > When we need to create a backporting patch, we simply create a branch for the

[PR] [improve][ci] Disable Gradle Enterprise unless GRADLE_ENTERPRISE_ACCESS_KEY is set [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new pull request, #21474: URL: https://github.com/apache/pulsar/pull/21474 ### Motivation The Gradle Enterprise Maven extension is active even when it's not needed. Some PR builds failed with this kind of exception. ``` Error: [ERROR] Internal error in Grad

Re: [PR] [improve][broker] Refactor method BrokerService#unloadServiceUnit [pulsar]

2023-10-30 Thread via GitHub
mattisonchao commented on code in PR #21463: URL: https://github.com/apache/pulsar/pull/21463#discussion_r1376119785 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2189,70 +2188,53 @@ public CompletableFuture checkTopicNsOwnership(fin

Re: [PR] [cleanup][broker] Delete methods marked Lombok @Getter [pulsar]

2023-10-30 Thread via GitHub
mattisonchao merged PR #21462: URL: https://github.com/apache/pulsar/pull/21462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

(pulsar) branch master updated: [cleanup][broker] Delete methods marked Lombok @Getter (#21462)

2023-10-30 Thread mattisonchao
This is an automated email from the ASF dual-hosted git repository. mattisonchao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cad3c464be0 [cleanup][broker] Delete metho

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-30 Thread via GitHub
blankensteiner commented on PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#issuecomment-1785067559 Hi @RobertIndie I'm not sure what you mean by making it "clearer in the release process"? Are you advocating creating the branch or are you saying that some Git 101 "how

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-30 Thread via GitHub
RobertIndie commented on PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#issuecomment-1785038565 > Hi @RobertIndie. When we need to create a backporting patch, we simply create a branch for the version that requires the backport. We can easily locate a specific version

Re: [I] The download-cpp-client.bat doesn't work on Windows [pulsar-client-node]

2023-10-30 Thread via GitHub
BewareMyPower commented on issue #256: URL: https://github.com/apache/pulsar-client-node/issues/256#issuecomment-1784974256 @milobluebell This issue should be fixed by https://github.com/apache/pulsar-client-node/pull/257 and you could try latest commit in Windows CMD. -- This is an aut

[PR] [fix][cli] Add `get-cluster-migration` cmd [pulsar]

2023-10-30 Thread via GitHub
Technoboy- opened a new pull request, #21473: URL: https://github.com/apache/pulsar/pull/21473 ### Motivation #21359 forget to add `get-cluster-migration` cmd . ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-comple

[PR] [improve][ci] Ignore Testcontainers background threads in ThreadLeakDetectorListener [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new pull request, #21472: URL: https://github.com/apache/pulsar/pull/21472 ### Motivation Testcontainers background threads get reported as leaked threads by ThreadLeakDetectorListener. These threads aren't actual leaks and should be ignored. ### Modifications

(pulsar) branch master updated: [fix] [broker] Make the new exclusive consumer instead the inactive one faster (#21183)

2023-10-30 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 29db8f84e5f [fix] [broker] Make the new exclusiv

Re: [PR] [fix] [broker] Make the new exclusive consumer instead the inactive one faster [pulsar]

2023-10-30 Thread via GitHub
poorbarcode merged PR #21183: URL: https://github.com/apache/pulsar/pull/21183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[PR] [fix][ci] Use correct annotation to prevent resource leaks in Elastic integration tests [pulsar]

2023-10-30 Thread via GitHub
lhotari opened a new pull request, #21471: URL: https://github.com/apache/pulsar/pull/21471 ### Motivation pulsar-io/elastic-search tests leak containers since the method initBeforeClass has the `@BeforeMethod` annotation when it should be `@BeforeClass`. ### Modifications

Re: [PR] [cleanup][broker] Delete methods marked Lombok @Getter [pulsar]

2023-10-30 Thread via GitHub
codecov-commenter commented on PR #21462: URL: https://github.com/apache/pulsar/pull/21462#issuecomment-1784884060 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

(pulsar-client-python) branch main updated: [feat] Support schema field type promotion (#159)

2023-10-30 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new dfd163a [feat] Support schema field typ

Re: [PR] [feat] Support schema field type promotion [pulsar-client-python]

2023-10-30 Thread via GitHub
RobertIndie merged PR #159: URL: https://github.com/apache/pulsar-client-python/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

(pulsar-client-go) branch master updated: [improve] make debug log more clearer in ReceivedSendReceipt() (#1123)

2023-10-30 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 620ecf4a [improve] make debug log more

Re: [PR] [improve] make debug log more clearer in ReceivedSendReceipt() [pulsar-client-go]

2023-10-30 Thread via GitHub
tisonkun merged PR #1123: URL: https://github.com/apache/pulsar-client-go/pull/1123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] [improve] make debug log more clearer in ReceivedSendReceipt() [pulsar-client-go]

2023-10-30 Thread via GitHub
tisonkun commented on PR #1123: URL: https://github.com/apache/pulsar-client-go/pull/1123#issuecomment-1784827163 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] send delayed message, but consume immediately [pulsar-client-node]

2023-10-30 Thread via GitHub
shibd commented on issue #345: URL: https://github.com/apache/pulsar-client-node/issues/345#issuecomment-1784820210 https://github.com/shibd/pulsar-node-delayed-test You can refer to this repository for testing. -- This is an automated message from the Apache Git Service. To respon

[PR] [improve][client] add custom probes for cluster auto failover [pulsar]

2023-10-30 Thread via GitHub
wojtekkedzior opened a new pull request, #21470: URL: https://github.com/apache/pulsar/pull/21470 Improve the default cluster auto-failvoer probe to allow for custom logic. PIP: n/a ### Motivation The default mechanism used to guage whether a cluster is up

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-30 Thread via GitHub
entvex commented on PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#issuecomment-1784799982 > Seems like we don't create a branch for the Major and Minor versions. How do we maintain the patch release for the specific version? Hi @RobertIndie. When we need to crea

Re: [I] [Security] 3.0.2 and 3.1.1 has 3 fixable security vulnerabilities [pulsar]

2023-10-30 Thread via GitHub
Technoboy- commented on issue #21457: URL: https://github.com/apache/pulsar/issues/21457#issuecomment-1784782447 I will try to upgrade and test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

(pulsar) branch master updated: [improve][ci] Detect test thread leaks in CI builds and add tooling for resource leak investigation (#21450)

2023-10-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 113d9f67105 [improve][ci] Detect test thread le

Re: [PR] [improve][ci] Detect test thread leaks in CI builds and add tooling for resource leak investigation [pulsar]

2023-10-30 Thread via GitHub
lhotari merged PR #21450: URL: https://github.com/apache/pulsar/pull/21450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated: [fix][test] Fix multiple thread leaks in tests (#21460)

2023-10-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a5d459b68e1 [fix][test] Fix multiple thread lea

Re: [PR] [fix][test] Fix multiple thread leaks in tests [pulsar]

2023-10-30 Thread via GitHub
lhotari merged PR #21460: URL: https://github.com/apache/pulsar/pull/21460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

  1   2   >