Re: [PR] [improve][broker] defer the ownership checks if the owner is inactive (ExtensibleLoadManager) [pulsar]

2024-01-05 Thread via GitHub
heesung-sn commented on PR #21857: URL: https://github.com/apache/pulsar/pull/21857#issuecomment-1879495606 Seems like this test is consistently failing, although it should not be related to this PR. ``` GitHub Actions / CI - Unit - Other ManagedLedgerTest.testNoCleanupOffload

Re: [PR] [improve][broker] PIP-307: Add monitoring metrics for graceful closure of producers/consumers [pulsar]

2024-01-05 Thread via GitHub
codecov-commenter commented on PR #21854: URL: https://github.com/apache/pulsar/pull/21854#issuecomment-1879307432 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21854?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [I] [Bug] return topic partitions were not yet created when get last messageId [pulsar]

2024-01-05 Thread via GitHub
graysonzeng commented on issue #21848: URL: https://github.com/apache/pulsar/issues/21848#issuecomment-1879135088 > does the topic has active consumers/producers? I observed that there are 3 active readers and no producers -- This is an automated message from the Apache Git Service.

Re: [PR] [improve][broker] PIP-307: Add monitoring metrics for graceful closure of producers/consumers [pulsar]

2024-01-05 Thread via GitHub
heesung-sn commented on code in PR #21854: URL: https://github.com/apache/pulsar/pull/21854#discussion_r1443185232 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/manager/UnloadManager.java: ## @@ -38,13 +41,75 @@ public class UnloadManager impleme

Re: [PR] Depend on the independent Asio instead of Boost.Asio by default [pulsar-client-cpp]

2024-01-05 Thread via GitHub
BewareMyPower closed pull request #381: Depend on the independent Asio instead of Boost.Asio by default URL: https://github.com/apache/pulsar-client-cpp/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [fix][broker] Fix potential NPE when disabling the liveness check [pulsar]

2024-01-05 Thread via GitHub
lhotari commented on PR #21840: URL: https://github.com/apache/pulsar/pull/21840#issuecomment-1879042213 I now had a chance to review the reason why I had originally used `null`. It's documented here: https://github.com/apache/pulsar/blob/c4cff0ab3dac169c0a1418ef2f63f61604f6278e/pulsar-b

(pulsar) branch master updated: [improve][pip] PIP-326: Create a BOM to ease dependency management (#21747)

2024-01-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a75dc54e9f3 [improve][pip] PIP-326: Create a BO

Re: [PR] [improve][pip] PIP-326: Create a BOM to ease dependency management [pulsar]

2024-01-05 Thread via GitHub
lhotari merged PR #21747: URL: https://github.com/apache/pulsar/pull/21747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [improve][pip] PIP-326: Create a BOM to ease dependency management [pulsar]

2024-01-05 Thread via GitHub
lhotari commented on code in PR #21747: URL: https://github.com/apache/pulsar/pull/21747#discussion_r1443151089 ## pip/pip-326.md: ## @@ -0,0 +1,209 @@ + + +# PIP-326: Create a BOM to ease dependency management + +# Background knowledge + +A `Bill of Materials` (BOM) is a specia

Re: [I] [Bug] getSchemaInfoAsync is not honoring the PulsarClient timeout [pulsar-client-cpp]

2024-01-05 Thread via GitHub
BewareMyPower commented on issue #357: URL: https://github.com/apache/pulsar-client-cpp/issues/357#issuecomment-1878855513 It needs some refactoring to add a test because the operation timeout is configured by seconds, not milliseconds. I'm going to work on this issue next week. -- This

(pulsar-dotpulsar) branch master updated: Added connectivity tests for Consumer and Reader (#199)

2024-01-05 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new b49abe6 Added connectivity te

Re: [PR] Added connectivity tests for Consumer and Reader [pulsar-dotpulsar]

2024-01-05 Thread via GitHub
blankensteiner merged PR #199: URL: https://github.com/apache/pulsar-dotpulsar/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

Re: [PR] chore(deps): bump golang.org/x/net from 0.0.0-20220225172249-27dd8689420f to 0.17.0 [pulsar-client-go]

2024-01-05 Thread via GitHub
BewareMyPower commented on PR #1101: URL: https://github.com/apache/pulsar-client-go/pull/1101#issuecomment-1878770443 Oh I just saw the release policy from https://go.dev/doc/devel/release#policy: > Each major Go release is supported until there are two newer major releases i

Re: [PR] chore(deps): bump golang.org/x/net from 0.0.0-20220225172249-27dd8689420f to 0.17.0 [pulsar-client-go]

2024-01-05 Thread via GitHub
BewareMyPower commented on PR #1101: URL: https://github.com/apache/pulsar-client-go/pull/1101#issuecomment-1878767637 I don't know well about how Golang maintains its major releases. From [here](https://go.dev/doc/devel/release#go1.16) we can see the latest release of 1.16.x is go1.16.15

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
Technoboy- commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442852281 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -50,9 +51,12 @@ public class PatternMultiTopicsConsumerImpl

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
Technoboy- commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442862672 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -50,9 +51,12 @@ public class PatternMultiTopicsConsumerImpl

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
Technoboy- commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442859884 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -105,7 +108,60 @@ public void run(Timeout timeout) throws Ex

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
Technoboy- commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442852281 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -50,9 +51,12 @@ public class PatternMultiTopicsConsumerImpl

[PR] Added connectivity tests for Consumer and Reader [pulsar-dotpulsar]

2024-01-05 Thread via GitHub
entvex opened a new pull request, #199: URL: https://github.com/apache/pulsar-dotpulsar/pull/199 # Description Added connectivity tests for Consumer and Reader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Bug] return topic partitions were not yet created when get last messageId [pulsar]

2024-01-05 Thread via GitHub
Technoboy- commented on issue #21848: URL: https://github.com/apache/pulsar/issues/21848#issuecomment-1878625526 does the topic has active consumers/producers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

(pulsar) branch branch-3.2 updated: [fix][broker] fix the wrong value of BrokerSrevice.maxUnackedMsgsPerDispatcher (#21765)

2024-01-05 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.2 by this push: new 1743cbba20e [fix][broker] fix the wro

[I] [Bug] [pulsar]

2024-01-05 Thread via GitHub
graysonzeng opened a new issue, #21860: URL: https://github.com/apache/pulsar/issues/21860 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version Pulsar 3.1.1 ### Minimal reprod

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
poorbarcode commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442706596 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -105,7 +108,62 @@ public void run(Timeout timeout) throws E

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
poorbarcode commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442706596 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -105,7 +108,62 @@ public void run(Timeout timeout) throws E

Re: [PR] [improve][doc] Improve doc for `maxTotalReceiverQueueSizeAcrossPartitions` and `receiverQueueSize` of ConsumerBuilder [pulsar]

2024-01-05 Thread via GitHub
codecov-commenter commented on PR #21841: URL: https://github.com/apache/pulsar/pull/21841#issuecomment-1878405647 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix] [client] Messages lost due to TopicListWatcher reconnect [pulsar]

2024-01-05 Thread via GitHub
RobertIndie commented on code in PR #21853: URL: https://github.com/apache/pulsar/pull/21853#discussion_r1442678052 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -105,7 +108,62 @@ public void run(Timeout timeout) throws E

Re: [PR] [fix][broker] Fix the issue of topics possibly being deleted. [pulsar]

2024-01-05 Thread via GitHub
crossoverJie commented on PR #21704: URL: https://github.com/apache/pulsar/pull/21704#issuecomment-1878388083 @poorbarcode Great job, thanks for your supplement👍. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [fix][broker] Fix the issue of topics possibly being deleted. [pulsar]

2024-01-05 Thread via GitHub
poorbarcode commented on PR #21704: URL: https://github.com/apache/pulsar/pull/21704#issuecomment-1878331213 > if the current cluster has the conditions to trigger this issue, you can refer to the https://github.com/apache/pulsar/issues/21653#issuecomment-1857548997 to upgrade; otherwise,

Re: [PR] [fix][broker] Fix the issue of topics possibly being deleted. [pulsar]

2024-01-05 Thread via GitHub
crossoverJie commented on PR #21704: URL: https://github.com/apache/pulsar/pull/21704#issuecomment-1878326528 @poorbarcode Thanks for your clarification. But based on the background of `Workaround-2`, if the current cluster has the conditions to trigger this issue, you can refer t

Re: [PR] [fix][broker] Fix the issue of topics possibly being deleted. [pulsar]

2024-01-05 Thread via GitHub
poorbarcode commented on PR #21704: URL: https://github.com/apache/pulsar/pull/21704#issuecomment-1878315926 Sorry, to clear the steps of the issue, I left a comment: --- ### Background & Summary 1. `checkCompaction` will delete the topic if the attribute `replicationCluste

Re: [PR] [improve][ml] Filter out deleted entries before read entries from ledger. [pulsar]

2024-01-05 Thread via GitHub
dao-jun commented on PR #21739: URL: https://github.com/apache/pulsar/pull/21739#issuecomment-1878278571 @codelipenghui @coderzc PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug] Thread safety issues with topic policy mutations [pulsar]

2024-01-05 Thread via GitHub
lhotari commented on issue #21303: URL: https://github.com/apache/pulsar/issues/21303#issuecomment-1878276953 You can drill down to the Namespace Policy update from [org.apache.pulsar.broker.admin.impl.NamespacesBase#updatePoliciesAsync](https://github.com/apache/pulsar/blob/15b655cfea381c63