(pulsar) branch branch-2.10 updated: [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22283)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 9b432d7151e [fix] [broker] fix mismatc

(pulsar) branch branch-2.10 updated: [fix] [broker] Close dispatchers stuck due to mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22270)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 310102f46ae [fix] [broker] Close dispa

(pulsar) branch branch-2.10 updated: [fix] [client] Unclear error message when creating a consumer with two same topics (#22255)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new dc5a73b5624 [fix] [client] Unclear err

Re: [D] 🙏 Topic data between clusters is out of sync in puslar GEO mode [pulsar]

2024-03-25 Thread via GitHub
GitHub user luky116 added a comment to the discussion: 🙏 Topic data between clusters is out of sync in puslar GEO mode 1、after step 2, the namespace exist on both clusters. 2、cluster2 donnot have permission to see topic1, because ns1 belongs to cluster1 ![image](https://github.com/apache/pulsa

[PR] [improve][broker] Optimize web interface deleteDynamicConfiguration return exception content [pulsar]

2024-03-25 Thread via GitHub
hanmz opened a new pull request, #22356: URL: https://github.com/apache/pulsar/pull/22356 ### Motivation When executing the method `internalDeleteDynamicConfigurationOnMetadataAsync`. If the `configName` is not a dynamic configuration, the returned exception information is inaccurate

(pulsar) 01/02: [fix] [broker] Close dispatchers stuck due to mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22270)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit ab88cee33cfdf4466df3ebb2f6ed99ed8156f590 Author: fengyubiao AuthorDate: Sat Mar 23 14:52:56 2024 +0800 [fix] [b

(pulsar) 02/02: [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22283)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5c3c1f115ea6cd03b7a0e232101cdc72fcd26f0e Author: fengyubiao AuthorDate: Tue Mar 26 07:41:07 2024 +0800 [fix] [b

(pulsar) branch branch-3.2 updated (35ea4712a60 -> 5c3c1f115ea)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 35ea4712a60 [fix][broker] Fix wrong double-checked locking for readOnActiveConsumerTask in dispatcher (#22279)

(pulsar) branch branch-3.0 updated: [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22283)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new bec3be20ff2 [fix] [broker] fix mismatch

(pulsar) branch branch-2.11 updated: [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22283)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 5d8cc37aa96 [fix] [broker] fix mismatc

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
nodece commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1538660637 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification notifica

(pulsar) branch master updated: [fix][broker] Fix ResourceGroup report local usage (#22340)

2024-03-25 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0b2b6d593bb [fix][broker] Fix ResourceGroup repo

Re: [PR] [fix][broker] Fix ResourceGroup report local usage [pulsar]

2024-03-25 Thread via GitHub
nodece merged PR #22340: URL: https://github.com/apache/pulsar/pull/22340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

Re: [PR] Fix PersistentSubscription duplicate implementation interface Subscri… [pulsar]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #22355: URL: https://github.com/apache/pulsar/pull/22355#issuecomment-2019497630 @sherlock-lin Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [

(pulsar) branch branch-3.0 updated: [fix] [broker] Close dispatchers stuck due to mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22270)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 94edfe4e84c [fix] [broker] Close dispatc

Re: [PR] Fix PersistentSubscription duplicate implementation interface Subscri… [pulsar]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #22355: URL: https://github.com/apache/pulsar/pull/22355#issuecomment-2019498898 @sherlock-lin Please select only one documentation label in your PR description. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[PR] Fix PersistentSubscription duplicate implementation interface Subscri… [pulsar]

2024-03-25 Thread via GitHub
sherlock-lin opened a new pull request, #22355: URL: https://github.com/apache/pulsar/pull/22355 …ption Fixes #22354 Main Issue: https://github.com/apache/pulsar/issues/22354 PIP: #xyz ### Motivation ### Modifica

(pulsar) branch branch-2.11 updated: [fix] [broker] Close dispatchers stuck due to mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22270)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new c8ee206a56c [fix] [broker] Close dispa

(pulsar) branch branch-3.0 updated: [fix] [client] Unclear error message when creating a consumer with two same topics (#22255)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 5ab0e9346b5 [fix] [client] Unclear error

Re: [PR] [fix][broker] fix the global topic policy config override the local topic policy config [pulsar]

2024-03-25 Thread via GitHub
chenhongSZ closed pull request #21212: [fix][broker] fix the global topic policy config override the local topic policy config URL: https://github.com/apache/pulsar/pull/21212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[I] [Bug] PersistentSubscription duplicate implementation interface Subscription [pulsar]

2024-03-25 Thread via GitHub
sherlock-lin opened a new issue, #22354: URL: https://github.com/apache/pulsar/issues/22354 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that u

(pulsar-helm-chart) branch master updated: making .ReleaseIsInstall optional for init jobs (#480)

2024-03-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 3dee8df making .ReleaseIsInstall op

Re: [I] Make it possible to optionally override .ReleaseIsInstall logic in init jobs [pulsar-helm-chart]

2024-03-25 Thread via GitHub
lhotari closed issue #479: Make it possible to optionally override .ReleaseIsInstall logic in init jobs URL: https://github.com/apache/pulsar-helm-chart/issues/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] making .ReleaseIsInstall optional for init jobs [pulsar-helm-chart]

2024-03-25 Thread via GitHub
lhotari merged PR #480: URL: https://github.com/apache/pulsar-helm-chart/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

Re: [PR] [improve][misc] Upgrade log4j2 to 2.23.1 [pulsar]

2024-03-25 Thread via GitHub
nodece commented on PR #22327: URL: https://github.com/apache/pulsar/pull/22327#issuecomment-2019365686 Any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

(pulsar) branch branch-2.11 updated (91ee5807d1b -> 88b8116cebe)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 91ee5807d1b Add cleanup to BaseAuthzTest used in backport of PR #22305 add 88b8116cebe [fix] [client] Unclea

Re: [PR] [improve][client] PIP-229: Add a common interface to get fields of MessageIdData [pulsar]

2024-03-25 Thread via GitHub
Shawyeok commented on PR #19414: URL: https://github.com/apache/pulsar/pull/19414#issuecomment-2019344523 > Add MessageIdAdvUtils for the most common used methods. Replace BatchMessageAcker with the BitSet for ACK. There is a race condition on acknowledge with batch message, details

[PR] [fix][client] Consumer lost message ack due to race condition in acknowledge with batch message [pulsar]

2024-03-25 Thread via GitHub
Shawyeok opened a new pull request, #22353: URL: https://github.com/apache/pulsar/pull/22353 ### Motivation Fixes #22352 ### Modifications Add synchronize protection on bitset operations acknowledge with batch message ### Verifying this change - [x

Re: [I] Flaky-test: ManagedLedgerTest.testGetNumberOfEntriesInStorage [pulsar]

2024-03-25 Thread via GitHub
nodece commented on issue #22347: URL: https://github.com/apache/pulsar/issues/22347#issuecomment-2019315709 https://github.com/apache/pulsar/pull/22034 breaks this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Flaky-test: PersistentMessageFinderTest.testMessageExpiryWithTimestampNonRecoverableException [pulsar]

2024-03-25 Thread via GitHub
nodece commented on issue #22351: URL: https://github.com/apache/pulsar/issues/22351#issuecomment-2019315582 https://github.com/apache/pulsar/pull/22034 breaks this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[I] [Bug][Client] Consumer lost message ack due to race condition in acknowledge with batch message [pulsar]

2024-03-25 Thread via GitHub
Shawyeok opened a new issue, #22352: URL: https://github.com/apache/pulsar/issues/22352 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that unsup

Re: [I] Flaky-test: ManagedLedgerTest.testGetNumberOfEntriesInStorage [pulsar]

2024-03-25 Thread via GitHub
coderzc commented on issue #22347: URL: https://github.com/apache/pulsar/issues/22347#issuecomment-2019292302 +1 https://github.com/apache/pulsar/actions/runs/8415552736/job/23084102366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] Flaky-test: PersistentMessageFinderTest.testMessageExpiryWithTimestampNonRecoverableException [pulsar]

2024-03-25 Thread via GitHub
nodece opened a new issue, #22351: URL: https://github.com/apache/pulsar/issues/22351 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/a

Re: [PR] [fix] [test] Fix flaky test ManagedLedgerTest.testGetNumberOfEntriesInStorage [pulsar]

2024-03-25 Thread via GitHub
nodece commented on code in PR #22344: URL: https://github.com/apache/pulsar/pull/22344#discussion_r1538509430 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -2642,10 +2642,10 @@ public void testGetNumberOfEntriesInStorage() thro

[PR] [improve][fn] Pass FunctionDetails to Go instance [pulsar]

2024-03-25 Thread via GitHub
jiangpengcheng opened a new pull request, #22350: URL: https://github.com/apache/pulsar/pull/22350 Fixes #22349 Main Issue: #xyz PIP: #xyz ### Motivation The Go instance doesn't get the full `FunctionDetails`, which makes i

[I] Golang instance of functions missing many fields of the `FunctionDetails` [pulsar]

2024-03-25 Thread via GitHub
jiangpengcheng opened a new issue, #22349: URL: https://github.com/apache/pulsar/issues/22349 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation the Go instance is assembling th

[I] Flaky-test: ManagedLedgerErrorsTest.recoverAfterZnodeVersionError [pulsar]

2024-03-25 Thread via GitHub
coderzc opened a new issue, #22348: URL: https://github.com/apache/pulsar/issues/22348 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/a

[I] Flaky-test: ManagedLedgerTest.testGetNumberOfEntriesInStorage [pulsar]

2024-03-25 Thread via GitHub
nodece opened a new issue, #22347: URL: https://github.com/apache/pulsar/issues/22347 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/a

Re: [D] 🙏 Topic data between clusters is out of sync in puslar GEO mode [pulsar]

2024-03-25 Thread via GitHub
GitHub user david-streamlio added a comment to the discussion: 🙏 Topic data between clusters is out of sync in puslar GEO mode After you create the namespace (ns1) in step 2, does the namespace exist on both clusters? After you create the topic (ns1/topic1) in step 3, but before you publish

Re: [PR] [fix] [broker] [branch-2.11] Fast fix infinite HTTP call getSubscriptions caused by wrong topicName [pulsar]

2024-03-25 Thread via GitHub
poorbarcode closed pull request #22346: [fix] [broker] [branch-2.11] Fast fix infinite HTTP call getSubscriptions caused by wrong topicName URL: https://github.com/apache/pulsar/pull/22346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [fix] [broker] [branch-2.11] Fast fix infinite HTTP call getSubscriptions caused by wrong topicName [pulsar]

2024-03-25 Thread via GitHub
poorbarcode opened a new pull request, #22346: URL: https://github.com/apache/pulsar/pull/22346 ### Motivation & Modifications Cherry-pick https://github.com/apache/pulsar/pull/21997 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-nee

[I] Flaky-test: ShadowManagedLedgerImplTest.testShadowWrites [pulsar]

2024-03-25 Thread via GitHub
coderzc opened a new issue, #22345: URL: https://github.com/apache/pulsar/issues/22345 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/

Re: [PR] [improve][test] Add concurrency benchmark for OpenHashMap [pulsar]

2024-03-25 Thread via GitHub
codelipenghui closed pull request #20648: [improve][test] Add concurrency benchmark for OpenHashMap URL: https://github.com/apache/pulsar/pull/20648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [improve][broker] Reduce object creation of EntryBatchIndexesAcks [pulsar]

2024-03-25 Thread via GitHub
codelipenghui closed pull request #19571: [improve][broker] Reduce object creation of EntryBatchIndexesAcks URL: https://github.com/apache/pulsar/pull/19571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
liangyepianzhou commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1538452501 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customP

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
liangyepianzhou commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1538452501 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customP

(pulsar) branch master updated: [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet (#22283)

2024-03-25 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a52945b1c51 [fix] [broker] fix mismatch between

Re: [PR] [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet [pulsar]

2024-03-25 Thread via GitHub
poorbarcode merged PR #22283: URL: https://github.com/apache/pulsar/pull/22283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [PR] [fix] [broker] fix mismatch between dispatcher.consumerList and dispatcher.consumerSet [pulsar]

2024-03-25 Thread via GitHub
poorbarcode commented on code in PR #22283: URL: https://github.com/apache/pulsar/pull/22283#discussion_r1538369872 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -190,9 +190,15 @@ public synchronized

Re: [PR] [fix][broker] Update TransferShedder underloaded broker check to consider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check [pulsar]

2024-03-25 Thread via GitHub
codecov-commenter commented on PR #22321: URL: https://github.com/apache/pulsar/pull/22321#issuecomment-2018910662 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22321?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]

2024-03-25 Thread via GitHub
lhotari commented on PR #476: URL: https://github.com/apache/pulsar-helm-chart/pull/476#issuecomment-2018723477 > @lhotari is there any chance you can also review this one? @doug-ba thanks for the great contributions! I'll provide a review tomorrow since I missed the reviews today.

Re: [D] Subscription type after the creation of the subscription using Pulsar Admin createSubscription method [pulsar]

2024-03-25 Thread via GitHub
GitHub user alexesom closed a discussion: Subscription type after the creation of the subscription using Pulsar Admin createSubscription method Hello! I found that after creating a subscription using the [createSubscription method](https://github.com/apache/pulsar/blob/567174f43528c0f7ae917bf

Re: [D] Subscription type after the creation of the subscription using Pulsar Admin createSubscription method [pulsar]

2024-03-25 Thread via GitHub
GitHub user visortelle closed the discussion with a comment: Subscription type after the creation of the subscription using Pulsar Admin createSubscription method @alexesom I think it's the correct answer to your question :) https://stackoverflow.com/a/75485553/4182882 > The subscription typ

Re: [PR] add ability to use separate disk for zookeeper tx log [pulsar-helm-chart]

2024-03-25 Thread via GitHub
doug-ba commented on PR #476: URL: https://github.com/apache/pulsar-helm-chart/pull/476#issuecomment-2018663967 @lhotari is there any chance you can also review this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] making .ReleaseIsInstall optional for init jobs [pulsar-helm-chart]

2024-03-25 Thread via GitHub
doug-ba commented on code in PR #480: URL: https://github.com/apache/pulsar-helm-chart/pull/480#discussion_r1538070179 ## charts/pulsar/templates/bookkeeper-cluster-initialize.yaml: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the Lice

Re: [PR] [fix][doc] specifies that the Node client supports schemas [pulsar-site]

2024-03-25 Thread via GitHub
jak78 commented on PR #869: URL: https://github.com/apache/pulsar-site/pull/869#issuecomment-2018647973 Thanks @visortelle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(pulsar-site) branch main updated: specifies that the Node client supports schemas (#869)

2024-03-25 Thread visortelle
This is an automated email from the ASF dual-hosted git repository. visortelle pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 8eeb8405a8ed specifies that the Node client

Re: [PR] [fix][doc] specifies that the Node client supports schemas [pulsar-site]

2024-03-25 Thread via GitHub
visortelle merged PR #869: URL: https://github.com/apache/pulsar-site/pull/869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[PR] [fix][doc] specifies that the Node client supports schemas [pulsar-site]

2024-03-25 Thread via GitHub
jak78 opened a new pull request, #869: URL: https://github.com/apache/pulsar-site/pull/869 ### ✅ Contribution Checklist - [x] I read the [contribution guide](https://pulsar.apache.org/contribute/document-contribution/) - [x] I updated the [versioned docs](https://pulsar.ap

Re: [PR] [fix] [test] Fix flaky test ManagedLedgerTest.testGetNumberOfEntriesInStorage [pulsar]

2024-03-25 Thread via GitHub
poorbarcode closed pull request #22344: [fix] [test] Fix flaky test ManagedLedgerTest.testGetNumberOfEntriesInStorage URL: https://github.com/apache/pulsar/pull/22344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] [fix] [test] Fix flaky test ManagedLedgerTest.testGetNumberOfEntriesInStorage [pulsar]

2024-03-25 Thread via GitHub
poorbarcode opened a new pull request, #22344: URL: https://github.com/apache/pulsar/pull/22344 ### Motivation **Flaky test logs** https://github.com/apache/pulsar/actions/runs/8416664128/job/23064867159?pr=22283 **Issue** - After https://github.com/apache/pulsar/pull/22034,

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
nodece commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537844198 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification notifica

Re: [PR] [fix][broker] Update TransferShedder underloaded broker check to consider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check [pulsar]

2024-03-25 Thread via GitHub
heesung-sn closed pull request #22321: [fix][broker] Update TransferShedder underloaded broker check to consider max loaded broker's msgThroughputEMA and update IsExtensibleLoadBalancerImpl check URL: https://github.com/apache/pulsar/pull/22321 -- This is an automated message from the Apache

[I] [Bug] Multi-role authorization does not work properly on granting topic level permissions based on ordering of roles in token [pulsar]

2024-03-25 Thread via GitHub
dhsy6z opened a new issue, #22343: URL: https://github.com/apache/pulsar/issues/22343 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that unsuppo

Re: [PR] [improve] [broker] Avoid repeated Read-and-discard when using Key_Shared mode [pulsar]

2024-03-25 Thread via GitHub
poorbarcode commented on PR #22245: URL: https://github.com/apache/pulsar/pull/22245#issuecomment-2018207966 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
poorbarcode commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537679188 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification not

[PR] [improve][admin] Check the auth at the first place for topic related API [pulsar]

2024-03-25 Thread via GitHub
Technoboy- opened a new pull request, #22342: URL: https://github.com/apache/pulsar/pull/22342 ### Motivation The main thing is to align the auth operation and put the auth checking operation at the first position. ### Modifications - `getPartitionedTopicMetadat`, `inter

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
nodece commented on PR #21781: URL: https://github.com/apache/pulsar/pull/21781#issuecomment-2018051169 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [fix][broker] Fix ResourceGroup report local usage [pulsar]

2024-03-25 Thread via GitHub
nodece commented on PR #22340: URL: https://github.com/apache/pulsar/pull/22340#issuecomment-2018050706 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [D] Apache Beam support for Pulsar [pulsar]

2024-03-25 Thread via GitHub
GitHub user vcastell-tibco added a comment to the discussion: Apache Beam support for Pulsar I would like to use the Beam connector for Pulsar and II see that it is still under discussion and development. Can someone provide an update on the tentative plans for releasing the connector officia

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
lhotari commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1535628889 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customPropert

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
lhotari commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1537517142 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customPropert

Re: [PR] [improve][doc] Cleanup Subscription in functions are not propely expl… [pulsar-site]

2024-03-25 Thread via GitHub
AlvaroStream commented on PR #867: URL: https://github.com/apache/pulsar-site/pull/867#issuecomment-2017891065 Sorry, I though I covered all the documents. Thanks for the commit improvement. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
liangyepianzhou commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1537418167 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customP

[PR] [fix][broker] Fix ResourceGroup report local usage [pulsar]

2024-03-25 Thread via GitHub
nodece opened a new pull request, #22340: URL: https://github.com/apache/pulsar/pull/22340 ### Motivation 1. `org.apache.pulsar.broker.resourcegroup.ResourceQuotaCalculator#needToReportLocalUsage` determine whether sending the current report of local usage can be suppressed (to redu

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
liangyepianzhou commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1537413416 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customP

Re: [PR] [improve][client] Add a warn log for calling reconsumeLater for a no-shared subscription [pulsar]

2024-03-25 Thread via GitHub
liangyepianzhou commented on code in PR #22330: URL: https://github.com/apache/pulsar/pull/22330#discussion_r1537413416 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -459,6 +459,12 @@ public void reconsumeLater(Message message, Map customP

Re: [D] Subscription type after the creation of the subscription using Pulsar Admin createSubscription method [pulsar]

2024-03-25 Thread via GitHub
GitHub user alexesom edited a discussion: Subscription type after the creation of the subscription using Pulsar Admin createSubscription method Hello! I found that after creating a subscription using the [createSubscription method](https://github.com/apache/pulsar/blob/567174f43528c0f7ae917bf

[I] [Bug] Regression of seeking by timestamp in 3.5.0 [pulsar-client-cpp]

2024-03-25 Thread via GitHub
BewareMyPower opened a new issue, #420: URL: https://github.com/apache/pulsar-client-cpp/issues/420 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar-client-cpp/issues) and found nothing similar. ### Version Client 3.5.0

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
nodece commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537303065 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification notifica

Re: [PR] [improve][doc] Cleanup Subscription in functions are not propely expl… [pulsar-site]

2024-03-25 Thread via GitHub
lhotari commented on PR #867: URL: https://github.com/apache/pulsar-site/pull/867#issuecomment-2017575675 I covered the 3.2.x docs. @AlvaroStream It seems that your base version was old and didn't contain the 3.2.x directory. -- This is an automated message from the Apache Git Service. To

(pulsar-site) branch main updated: [improve][doc] Cleanup Subscription in functions are not propely expl… (#867)

2024-03-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 9bbad55db0b2 [improve][doc] Cleanup Subscripti

Re: [I] [Doc] [pulsar]

2024-03-25 Thread via GitHub
lhotari closed issue #22333: [Doc] URL: https://github.com/apache/pulsar/issues/22333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] [improve][doc] Cleanup Subscription in functions are not propely expl… [pulsar-site]

2024-03-25 Thread via GitHub
lhotari merged PR #867: URL: https://github.com/apache/pulsar-site/pull/867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [PR] [fix][ml]Expose ledger timestamp [pulsar]

2024-03-25 Thread via GitHub
dao-jun closed pull request #22338: [fix][ml]Expose ledger timestamp URL: https://github.com/apache/pulsar/pull/22338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] [fix][ml]Expose ledger timestamp [pulsar]

2024-03-25 Thread via GitHub
dao-jun opened a new pull request, #22338: URL: https://github.com/apache/pulsar/pull/22338 Fixes https://github.com/apache/pulsar/issues/22312 ### Motivation ### Modifications see https://github.com/apache/pulsar/issues/22312 ### Verifying this cha

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
poorbarcode commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537260613 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification not

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
nodece commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537256198 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -41,52 +51,68 @@ * @see https://github.com/apache/pulsar

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
nodece commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537253453 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification notifica

Re: [PR] Remove the call to sun InetAddressCachePolicy [pulsar]

2024-03-25 Thread via GitHub
lhotari commented on code in PR #22329: URL: https://github.com/apache/pulsar/pull/22329#discussion_r1537242978 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/DnsResolverUtil.java: ## @@ -39,19 +46,35 @@ public class DnsResolverUtil { int ttl = DEFAU

Re: [PR] Remove the call to sun InetAddressCachePolicy [pulsar]

2024-03-25 Thread via GitHub
lhotari commented on code in PR #22329: URL: https://github.com/apache/pulsar/pull/22329#discussion_r1537242202 ## pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java: ## @@ -18,13 +18,42 @@ */ package org.apache.pulsar.common.util.netty; +i

Re: [PR] Remove the call to sun InetAddressCachePolicy [pulsar]

2024-03-25 Thread via GitHub
lhotari commented on code in PR #22329: URL: https://github.com/apache/pulsar/pull/22329#discussion_r1537241090 ## pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java: ## @@ -18,13 +18,52 @@ */ package org.apache.pulsar.common.util.netty; +i

Re: [PR] Remove the call to sun InetAddressCachePolicy [pulsar]

2024-03-25 Thread via GitHub
lhotari commented on code in PR #22329: URL: https://github.com/apache/pulsar/pull/22329#discussion_r1537241090 ## pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java: ## @@ -18,13 +18,52 @@ */ package org.apache.pulsar.common.util.netty; +i

Re: [I] Multi-threaded consumption issues [pulsar-dotpulsar]

2024-03-25 Thread via GitHub
entvex commented on issue #208: URL: https://github.com/apache/pulsar-dotpulsar/issues/208#issuecomment-2017494943 > Dear @entvex @blankensteiner , > > I put the demo code herehttps://github.com/gungod2000/PulsarIssueDemo_4.8 > > appreciated。 > >

Re: [PR] Remove the call to sun InetAddressCachePolicy [pulsar]

2024-03-25 Thread via GitHub
jianyun8023 commented on code in PR #22329: URL: https://github.com/apache/pulsar/pull/22329#discussion_r1537226702 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/DnsResolverUtil.java: ## @@ -19,12 +19,19 @@ package org.apache.pulsar.common.util.netty; im

Re: [PR] [fix][broker] Fix ResourceGroups loading [pulsar]

2024-03-25 Thread via GitHub
poorbarcode commented on code in PR #21781: URL: https://github.com/apache/pulsar/pull/21781#discussion_r1537215291 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java: ## @@ -140,7 +166,10 @@ public void accept(Notification not

Re: [D] How to set Aggregation replication? [pulsar]

2024-03-25 Thread via GitHub
GitHub user YanshuoH deleted a comment on the discussion: How to set Aggregation replication? cf. discussion in slack: https://github.com/apache/pulsar/assets/6973092/aa41ee37-02a0-45ed-9f0d-783c1ada1464";> GitHub link: https://github.com/apache/pulsar/discussions/22336#discussioncomment-88

Re: [D] How to set Aggregation replication? [pulsar]

2024-03-25 Thread via GitHub
GitHub user lhotari added a comment to the discussion: How to set Aggregation replication? Summarizing the answer from Slack: There is no special "aggregration replication mode". The documentation is not very clear and doesn't provide an example of such configuration. The "aggregation replic

Re: [PR] feat: added missing fields on TopicStats [pulsar-client-go]

2024-03-25 Thread via GitHub
geniusjoe commented on PR #1136: URL: https://github.com/apache/pulsar-client-go/pull/1136#issuecomment-2017475150 I think we need to add `GetPartitionedStats` and `GetPartitionedStatsWithOption` interface test cases in `topic_test.go`. Since `make test` command will automatically deploy a

Re: [D] How to set Aggregation replication? [pulsar]

2024-03-25 Thread via GitHub
GitHub user YanshuoH added a comment to the discussion: How to set Aggregation replication? cf. discussion in slack: https://github.com/apache/pulsar/assets/6973092/aa41ee37-02a0-45ed-9f0d-783c1ada1464";> GitHub link: https://github.com/apache/pulsar/discussions/22336#discussioncomment-8899

  1   2   >