Re: [PR] [improve][pip] PIP-337: SSL Factory Plugin to customize SSL Context and SSL Engine generation [pulsar]

merlimat merged PR #22016: URL: https://github.com/apache/pulsar/pull/22016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

(pulsar) branch master updated: [improve][pip] PIP-337: SSL Factory Plugin to customize SSL Context and SSL Engine generation (#22016)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2086cc46c88 [improve][pip] PIP-337: SSL Factory

(pulsar-client-cpp) branch main updated: [CI] Use macos-12 to build macOS libraries (#433)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 35bf161 [CI] Use macos-12 to build macOS

Re: [PR] [CI] Use macos-12 to build macOS libraries [pulsar-client-cpp]

merlimat merged PR #433: URL: https://github.com/apache/pulsar-client-cpp/pull/433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@p

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665275431 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208336183 > @ivan-penchev In this [PR](https://github.com/apache/pulsar-client-go/pull/1230), the Go version is upgraded to a minimum of 1.20, but the slog package is officially used

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

crossoverJie commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208412685 > Edit: @crossoverJie I decided to give the upgrade a chance, after reading go's release policy. I hope I haven't done anything bad. I have no objections to upgrading

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

codecov-commenter commented on PR #22854: URL: https://github.com/apache/pulsar/pull/22854#issuecomment-2208505903 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22854?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

(pulsar) branch master updated: [fix][ci] Fix OWASP Dependency Check download by using NVD API key (#22999)

This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8b7754f11f1 [fix][ci] Fix OWASP Dependency Chec

Re: [PR] [fix][ci] Fix OWASP Dependency Check download by using NVD API key [pulsar]

lhotari merged PR #22999: URL: https://github.com/apache/pulsar/pull/22999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665485246 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665490761 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665490761 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665491316 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20 PULSAR_VE

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665491465 ## README.md: ## @@ -38,7 +38,7 @@ CGo-based library. ## Requirements -- Go 1.20+ +- Go 1.21+ Review Comment: Revert. ## README.md:

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665495312 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

(pulsar) branch branch-3.3 updated: [fix][ci] Fix OWASP Dependency Check download by using NVD API key (#22999)

This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.3 by this push: new 589f2831aae [fix][ci] Fix OWASP Depende

(pulsar) branch branch-3.2 updated: [fix][ci] Fix OWASP Dependency Check download by using NVD API key (#22999)

This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.2 by this push: new 3a125c4169c [fix][ci] Fix OWASP Depende

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665547176 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665552093 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208723135 @ivan-penchev I noticed this PR doesn't add a test, could you add a test for the producer and consumer with this logger? -- This is an automated message from the Apache Git Ser

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665562539 ## go.mod: ## @@ -1,6 +1,6 @@ module github.com/apache/pulsar-client-go -go 1.18 +go 1.20 Review Comment: Good catch, this should be 1.20. -- Thi

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208768095 > @ivan-penchev I noticed this PR doesn't add a test, could you add a test for the producer and consumer with this logger? @nodece I appreciate the need for a test to

[PR] [improve][admin] Improve error message when attempt to delete a partitioned topic with a wrong API [pulsar]

poorbarcode opened a new pull request, #23002: URL: https://github.com/apache/pulsar/pull/23002 ### Motivation & Modifications The correct usage of deleting topics: - `non-partitioned`: `pulsar-admin topics delete ` - `partitioned`: `pulsar-admin topics delete-partitioned-topic `

[I] [Bug][broker] MessageDeduplication replay timeout would cause topic loading stuck and become unavailable [pulsar]

TakaHiR07 opened a new issue, #23003: URL: https://github.com/apache/pulsar/issues/23003 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that unsu

[PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

TakaHiR07 opened a new pull request, #23004: URL: https://github.com/apache/pulsar/pull/23004 Fixes https://github.com/apache/pulsar/issues/23003 ### Motivation As shown in the issue. fix the risk of topic loading stuck. ### Modifications 1. make takeSnapshot() as

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

BewareMyPower commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1665659571 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,89 @@ public void testDisableNamespacePo

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665785500 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java: ## @@ -108,8 +108,8 @@ public void testGetTopicsOfGetTopicsResult(boolean is

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665793987 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture> patternTopicSubscribeAsy

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665793987 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture> patternTopicSubscribeAsy

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665797519 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java: ## @@ -108,8 +108,8 @@ public void testGetTopicsOfGetTopicsResult(boolean isU

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665801286 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture> patternTopicSubscribeAsyn

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2209260330 > 1. Where should I place the test? You can write a test in the `pulsar/client_impl_with_slog_test.go`. > 2. What should I be testing? (that producer and consumer do

[PR] [feat][misc] PIP-264: Copy OpenTelemetry resource attributes to Prometheus labels [pulsar]

dragosvictor opened a new pull request, #23005: URL: https://github.com/apache/pulsar/pull/23005 [PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md) ### Motivation The OpenTelemetry collector can be configured to expose the metrics as a Prometheus server, sim

Re: [PR] [fix][broker] The topic might reference a closed ledger [pulsar]

shibd commented on PR #22860: URL: https://github.com/apache/pulsar/pull/22860#issuecomment-2209737237 > client can acquire the timeout response immediately and retry. Yes, you are right. Maybe we need improve client, when get a timoutexception, don't be so aggressive in retrying.

Re: [I] [Bug][broker] MessageDeduplication replay timeout would cause topic loading stuck and become unavailable [pulsar]

shibd commented on issue #23003: URL: https://github.com/apache/pulsar/issues/23003#issuecomment-2209762114 > The reason is if topic loading timeout, the topic would close. However, topic close and takeSnapshot is executed concurrently, so takeSnapshot may throw exception since topic has be

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

shibd commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666137904 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,88 @@ public void testDisableNamespacePolicyTake

Re: [PR] [fix][broker] The topic might reference a closed ledger [pulsar]

TakaHiR07 commented on PR #22860: URL: https://github.com/apache/pulsar/pull/22860#issuecomment-2209878165 > 1. When the broker loads a topic and times it out, it should not complete the future to the client before closing all resources. This way seems better. -- This is a

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

TakaHiR07 commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666175402 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,88 @@ public void testDisableNamespacePolicy

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

TakaHiR07 commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666176443 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,89 @@ public void testDisableNamespacePolicy

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666190182 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20 PULSAR_VE

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666194036 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666286324 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20 PUL

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666286324 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20 PUL

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666321239 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666321239 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666321239 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr