Re: [PR] [improve] [broker] Add subscription prefix for internal reader [pulsar]

2024-07-24 Thread via GitHub
hangc0276 commented on code in PR #23044: URL: https://github.com/apache/pulsar/pull/23044#discussion_r1689281963 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java: ## @@ -263,33 +273,42 @@ public void testBrokerMetrics() throws Exception {

Re: [PR] [Fix] PulsarCtl 1266 Oauth2 Client credentials flow use scopes from the keyfile as well [pulsar-client-go]

2024-07-24 Thread via GitHub
Nikolajls commented on PR #1244: URL: https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2247116184 @RobertIndie So the linting succeeded this time. Do you know what the process is when this is merged in on how the updated go package is applied to the Pulsarctl

[PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
dao-jun opened a new pull request, #23070: URL: https://github.com/apache/pulsar/pull/23070 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [ ]

Re: [PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
dao-jun closed pull request #23070: [fix] Fix compile failing URL: https://github.com/apache/pulsar/pull/23070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
github-actions[bot] commented on PR #23070: URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247188920 @dao-jun Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `do

Re: [PR] [fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) [pulsar]

2024-07-24 Thread via GitHub
Demogorgon314 commented on code in PR #23064: URL: https://github.com/apache/pulsar/pull/23064#discussion_r1689368480 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2250,6 +2250,15 @@ private CompletableFuture unloadServiceUnit(Namesp

Re: [PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
nodece commented on PR #23070: URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247325654 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] fix: producer close was blocked [pulsar-client-go]

2024-07-24 Thread via GitHub
gunli commented on PR #1249: URL: https://github.com/apache/pulsar-client-go/pull/1249#issuecomment-2247365823 This PR may be related to issue #1190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [BUG] The process will block if close client or producer when pulsar server is down. [pulsar-client-go]

2024-07-24 Thread via GitHub
nodece closed issue #1190: [BUG] The process will block if close client or producer when pulsar server is down. URL: https://github.com/apache/pulsar-client-go/issues/1190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] fix: producer close was blocked [pulsar-client-go]

2024-07-24 Thread via GitHub
nodece merged PR #1249: URL: https://github.com/apache/pulsar-client-go/pull/1249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

(pulsar-client-go) branch master updated: fix: producer close was blocked (#1249)

2024-07-24 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 28293a6b fix: producer close was block

Re: [I] `AuthenticateUsingToken(Func> tokenFactory)` is not a part of 2.3.0 [pulsar-dotpulsar]

2024-07-24 Thread via GitHub
Jeff-Tian commented on issue #101: URL: https://github.com/apache/pulsar-dotpulsar/issues/101#issuecomment-2247466922 I used 3.3.1 and still can't see that method, see: https://github.com/user-attachments/assets/4d6eae81-ecca-4f1a-b3bd-ad93b48e97d5";> -- This is an automated me

Re: [I] `AuthenticateUsingToken(Func> tokenFactory)` is not a part of 2.3.0 [pulsar-dotpulsar]

2024-07-24 Thread via GitHub
Jeff-Tian commented on issue #101: URL: https://github.com/apache/pulsar-dotpulsar/issues/101#issuecomment-2247502760 Never mind, I can use the following instead: ```csharp await using var client = PulsarClient.Builder() .Authentication(AuthenticationFactory.Token(

[PR] [improve] [test] add end to end deduplication test. [pulsar]

2024-07-24 Thread via GitHub
thetumbled opened a new pull request, #23071: URL: https://github.com/apache/pulsar/pull/23071 ### Motivation Message deduplication feature has been introduced into Pulsar long time ago, but the concrete problem it solve is vague. The info i can get from the official document is th

Re: [PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
codecov-commenter commented on PR #23070: URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247557250 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23070?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [Fix] PulsarCtl 1266 Oauth2 Client credentials flow use scopes from the keyfile as well [pulsar-client-go]

2024-07-24 Thread via GitHub
RobertIndie merged PR #1244: URL: https://github.com/apache/pulsar-client-go/pull/1244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

(pulsar-client-go) branch master updated: [Fix] Oauth2 Client credentials flow use scopes from the keyfile as well (#1244)

2024-07-24 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new c3b0633a [Fix] Oauth2 Client credentials

Re: [PR] [Fix] PulsarCtl 1266 Oauth2 Client credentials flow use scopes from the keyfile as well [pulsar-client-go]

2024-07-24 Thread via GitHub
RobertIndie commented on PR #1244: URL: https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2247617825 > @RobertIndie > > So the linting succeeded this time. > > Do you know what the process is when this is merged in on how the updated go package is applied to th

(pulsar-client-go) branch branch-0.13.0 updated: [Fix] Oauth2 Client credentials flow use scopes from the keyfile as well (#1244)

2024-07-24 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch branch-0.13.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/branch-0.13.0 by this push: new 3cbb3537 [Fix] Oauth2 Clie

Re: [PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
dao-jun commented on PR #23070: URL: https://github.com/apache/pulsar/pull/23070#issuecomment-2247627792 merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

(pulsar) branch master updated: [fix] Fix compile failing (#23070)

2024-07-24 Thread daojun
This is an automated email from the ASF dual-hosted git repository. daojun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 38a5e91de9a [fix] Fix compile failing (#23070) 3

Re: [PR] [fix] Fix compile failing [pulsar]

2024-07-24 Thread via GitHub
dao-jun merged PR #23070: URL: https://github.com/apache/pulsar/pull/23070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[I] Pulsar Helm Chart Initialization Failure When Using Existing Secret [pulsar-helm-chart]

2024-07-24 Thread via GitHub
robertdumitrescu opened a new issue, #512: URL: https://github.com/apache/pulsar-helm-chart/issues/512 **Describe the bug** The Pulsar Helm chart fails to initialize the pulsar-manager-init pod when the existingSecret feature is used. The initialization process gets stuck, preventing the

[PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-24 Thread via GitHub
shibd opened a new pull request, #23072: URL: https://github.com/apache/pulsar/pull/23072 ### Motivation If a subscription has many consumers and each consumer individually acknowledges messages from other consumers, this scenario is very CPU resource-intensive. Refer this: htt

Re: [I] [Doc] There are two pip-307s [pulsar]

2024-07-24 Thread via GitHub
hechen0 commented on issue #23067: URL: https://github.com/apache/pulsar/issues/23067#issuecomment-2248165784 solved already. check https://github.com/apache/pulsar/pull/21623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] Set `client_credentials` as the default OAuth2 grant type. [pulsar-client-go]

2024-07-24 Thread via GitHub
geniusjoe commented on issue #1238: URL: https://github.com/apache/pulsar-client-go/issues/1238#issuecomment-2248220725 > Currently, Pulsar clients only support the client_credentials authentication type. The authentication type determines how to obtain an access token through an OAuth 2.0

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-24 Thread via GitHub
codecov-commenter commented on PR #23072: URL: https://github.com/apache/pulsar/pull/23072#issuecomment-2248244409 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23072?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [I] [Doc] There are two pip-307s [pulsar]

2024-07-24 Thread via GitHub
AuroraTwinkle commented on issue #23067: URL: https://github.com/apache/pulsar/issues/23067#issuecomment-2248260663 > solved already. check https://github.com/apache/pulsar/pull/21623 This is just a readme doc comment, but do nothing about pip 307. -- This is an automated message fr

Re: [PR] [fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) [pulsar]

2024-07-24 Thread via GitHub
heesung-sn closed pull request #23064: [fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) URL: https://github.com/apache/pulsar/pull/23064 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) [pulsar]

2024-07-24 Thread via GitHub
heesung-sn commented on code in PR #23064: URL: https://github.com/apache/pulsar/pull/23064#discussion_r1690153125 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2250,6 +2250,15 @@ private CompletableFuture unloadServiceUnit(Namespace

Re: [PR] [fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) [pulsar]

2024-07-24 Thread via GitHub
heesung-sn merged PR #23064: URL: https://github.com/apache/pulsar/pull/23064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

(pulsar) branch master updated: [fix][broker] Do not try to clean owned bundles from inactive source brokers (ExtensibleLoadManagerImpl only) (#23064)

2024-07-24 Thread heesung
This is an automated email from the ASF dual-hosted git repository. heesung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 55e468ee412 [fix][broker] Do not try to clean o

Re: [D] How to enable server publish time on messages? [pulsar]

2024-07-24 Thread via GitHub
GitHub user adparts edited a discussion: How to enable server publish time on messages? Hi all, The Message class, has the following method: `Optional getBrokerPublishTime()` Get broker publish time from broker entry metadata. **Note that only if the feature is enabled in the broker then the

Re: [PR] [improve][pip] PIP-366: Support to specify different config for Configuration and Local Metadata Store [pulsar]

2024-07-24 Thread via GitHub
poorbarcode commented on code in PR #23033: URL: https://github.com/apache/pulsar/pull/23033#discussion_r1690627466 ## pip/pip-366.md: ## @@ -0,0 +1,70 @@ +# PIP-366: Support to specify different config for Configuration and Local Metadata Store + +# Background knowledge + +Pul

Re: [PR] [improve] [broker] Add subscription prefix for internal reader [pulsar]

2024-07-24 Thread via GitHub
hangc0276 merged PR #23044: URL: https://github.com/apache/pulsar/pull/23044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

(pulsar) branch master updated: [improve] [broker] Add subscription prefix for internal reader (#23044)

2024-07-24 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c7310e35d27 [improve] [broker] Add subscriptio

Re: [PR] [improve][pip] PIP-368: Support client properties for the lookup [pulsar]

2024-07-24 Thread via GitHub
github-actions[bot] commented on PR #23075: URL: https://github.com/apache/pulsar/pull/23075#issuecomment-2249273364 @RobertIndie Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[PR] [improve][pip] PIP-368: Support client properties for the lookup [pulsar]

2024-07-24 Thread via GitHub
RobertIndie opened a new pull request, #23075: URL: https://github.com/apache/pulsar/pull/23075 ### Motivation Currently, the lookup process uses only the topic name as its parameter. However, to enhance this process, it's beneficial for clients to provide additional in

Re: [PR] [improve][pip] PIP-368: Support client properties for the lookup [pulsar]

2024-07-24 Thread via GitHub
BewareMyPower commented on code in PR #23075: URL: https://github.com/apache/pulsar/pull/23075#discussion_r1690756510 ## pip/pip-368.md: ## @@ -0,0 +1,148 @@ +# PIP-368: Support client properties for the lookup + +# Background knowledge + +## How Pulsar Lookup Works + +Before pr

Re: [PR] fix: Connection use minConnMaxIdleTime [pulsar-client-go]

2024-07-24 Thread via GitHub
RobertIndie commented on code in PR #1255: URL: https://github.com/apache/pulsar-client-go/pull/1255#discussion_r1690764848 ## pulsar/client_impl.go: ## @@ -66,8 +66,10 @@ func newClient(options ClientOptions) (Client, error) { if connectionMaxIdleTime == 0 {

Re: [PR] Add support for subscription expiration time namespace settings [pulsar-client-go]

2024-07-24 Thread via GitHub
RobertIndie commented on PR #1254: URL: https://github.com/apache/pulsar-client-go/pull/1254#issuecomment-2249342477 There are still some lint issues. If you are using macos or linux, you can run [`make lint`](https://github.com/apache/pulsar-client-go/blob/c3b0633a2f5fcc5b560b504d04fdef0e

Re: [PR] [improve] [broker] Check max producers/consumers limitation first before other ops to save resources [pulsar]

2024-07-24 Thread via GitHub
gaoran10 commented on code in PR #23074: URL: https://github.com/apache/pulsar/pull/23074#discussion_r1690767523 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -1320,6 +1320,13 @@ protected void handleSubscribe(final CommandSubscribe subsc

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-24 Thread via GitHub
gaoran10 commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1690830218 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

[PR] improve: use ctx and timer instead sleep [pulsar-client-go]

2024-07-24 Thread via GitHub
nodece opened a new pull request, #1256: URL: https://github.com/apache/pulsar-client-go/pull/1256 ### Motivation We are using `time.Sleep` and `for` to execute the retry, which cannot be interrupted, this PR will use context and timer to improve this behavior. The next improve

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

2024-07-24 Thread via GitHub
BewareMyPower commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1690841326 ## pulsar-broker/pom.xml: ## @@ -507,6 +507,12 @@ pulsar-package-filesystem-storage ${project.version} + + org.powermock + powe

Re: [PR] fix: Connection use minConnMaxIdleTime [pulsar-client-go]

2024-07-24 Thread via GitHub
crossoverJie closed pull request #1255: fix: Connection use minConnMaxIdleTime URL: https://github.com/apache/pulsar-client-go/pull/1255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] fix: Connection use minConnMaxIdleTime [pulsar-client-go]

2024-07-24 Thread via GitHub
crossoverJie commented on code in PR #1255: URL: https://github.com/apache/pulsar-client-go/pull/1255#discussion_r1690889316 ## pulsar/client_impl.go: ## @@ -66,8 +66,10 @@ func newClient(options ClientOptions) (Client, error) { if connectionMaxIdleTime == 0 {

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

2024-07-24 Thread via GitHub
liangyepianzhou commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1690902221 ## pulsar-broker/pom.xml: ## @@ -507,6 +507,12 @@ pulsar-package-filesystem-storage ${project.version} + + org.powermock + po