Re: [PR] [fix][client] Fix client handle unknown exception during message-decryption and apply decryption action accordingly [pulsar]

2024-09-04 Thread via GitHub
rdhabalia commented on code in PR #23256: URL: https://github.com/apache/pulsar/pull/23256#discussion_r1744885413 ## pulsar-client-messagecrypto-bc/src/main/java/org/apache/pulsar/client/impl/crypto/MessageCryptoBc.java: ## @@ -525,6 +525,10 @@ private boolean decryptDataKey(Str

[PR] [fix][test] Fix flaky GetPartitionMetadataMultiBrokerTest.testCompatibilityDifferentBrokersForNonPersistentTopic [pulsar]

2024-09-04 Thread via GitHub
hanmz opened a new pull request, #23259: URL: https://github.com/apache/pulsar/pull/23259 ### Motivation ![image](https://github.com/user-attachments/assets/e2fe41ee-4a95-4be5-97eb-d0a12c3ec982) The root cause of this problem is that the `getBroker` method is asynchronous. When th

Re: [PR] [fix][broker] Add principal name into info log to enhance analysis and troubleshooting [pulsar]

2024-09-04 Thread via GitHub
rdhabalia merged PR #23257: URL: https://github.com/apache/pulsar/pull/23257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

(pulsar) branch master updated: [improve][misc] Upgrade Netty to 4.1.113 and netty-tcnative to 2.0.66 (#23255)

2024-09-04 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a28c0df9ba3 [improve][misc] Upgrade Netty to 4.1

Re: [PR] [improve][misc] Upgrade Netty to 4.1.113 and netty-tcnative to 2.0.66 [pulsar]

2024-09-04 Thread via GitHub
nodece merged PR #23255: URL: https://github.com/apache/pulsar/pull/23255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

Re: [PR] feat: introduce ack trackers to prevent batch message loss [pulsar-client-go]

2024-09-04 Thread via GitHub
nodece commented on PR #1277: URL: https://github.com/apache/pulsar-client-go/pull/1277#issuecomment-2330580987 Good work! I think we should fix this issue in the `ack_grouping_tracker.go`. When acknowledging a batch message, ensure that the ledger ID, entry ID, and tracker a

Re: [I] [Bug] Message loss on bookies and brokers restart [pulsar]

2024-09-04 Thread via GitHub
lhotari commented on issue #22709: URL: https://github.com/apache/pulsar/issues/22709#issuecomment-2330578021 > there are 868 messages unacknowledged. This is the last batch which should be flushed after 10 minutes. It should contain ~5000 msgs so ~4200 msgs are lost. I'll rename the

Re: [I] [Bug] Msg backlog & unack msg remains when using acknowledgeAsync [pulsar]

2024-09-04 Thread via GitHub
lhotari commented on issue #21958: URL: https://github.com/apache/pulsar/issues/21958#issuecomment-2330574160 > I made an attempt to reproduce this using Pulsar client directly. The problem didn't reproduce with https://github.com/lhotari/pulsar-playground/blob/master/src/main/java/com/gith

[PR] [fix] [broker] fix pulsar-admin topics stats-internal caused a BK client thread a deadlock [pulsar]

2024-09-04 Thread via GitHub
poorbarcode opened a new pull request, #23258: URL: https://github.com/apache/pulsar/pull/23258 ### Motivation `pulsar-admin topics stats-internal` caused a BK client, and caused other ledgers can not be open successfully. Then the topics can not be eventually loaded up. https

(pulsar) branch master updated: [improve][broker] Optimize message payload traffic for ShadowReplicator (#23236)

2024-09-04 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new de68e2511e0 [improve][broker] Optimize message payl

[PR] fix: Keep compatible with old boost versions [pulsar-client-cpp]

2024-09-04 Thread via GitHub
erobot opened a new pull request, #444: URL: https://github.com/apache/pulsar-client-cpp/pull/444 ### Motivation Keep compatible with old boost versions. ### Modifications Port boost compatible code from branch-3.4 and make minor changes for USE_ASIO. Code from br

Re: [I] [Bug] Msg backlog & unack msg remains when using acknowledgeAsync [pulsar]

2024-09-04 Thread via GitHub
lhotari commented on issue #21958: URL: https://github.com/apache/pulsar/issues/21958#issuecomment-2329835010 I'm not able to reproduce. compiling Pulsar branch with rebased flux-test patch for pulsar-perf ``` git clone --depth 1 -b lh-issue21958-flux-test https://github.com/lh

Re: [I] [Bug] Msg backlog & unack msg remains when using acknowledgeAsync [pulsar]

2024-09-04 Thread via GitHub
lhotari commented on issue #21958: URL: https://github.com/apache/pulsar/issues/21958#issuecomment-2329690822 > we published around 1m of messages, and we are able to reproduce with this code > [v3.1.2...semistone:pulsar:test/flux-test](https://github.com/apache/pulsar/compare/v3.1.2...s

Re: [I] [Bug] A large backlog of Key_Shared subscription messages will result in fullgc and OOM [pulsar]

2024-09-04 Thread via GitHub
lhotari commented on issue #21045: URL: https://github.com/apache/pulsar/issues/21045#issuecomment-2329663089 One of the root causes behind this issue is described in #23200 . It's addressed by #23231 and 23226. I believe that the OOM issue got mitigated already by #17804. -- This is a

Re: [PR] RPC framework implemented by the Pulsar client [pulsar-java-contrib]

2024-09-04 Thread via GitHub
Denovo1998 commented on code in PR #6: URL: https://github.com/apache/pulsar-java-contrib/pull/6#discussion_r1743968974 ## pulsar-rpc-contrib/src/main/java/org/apache/pulsar/rpc/contrib/common/package-info.java: ## @@ -0,0 +1,14 @@ +/* + * Licensed under the Apache License, Vers

Re: [PR] [improve][broker] Add limits for Key_Shared Subscription look ahead in dispatching [pulsar]

2024-09-04 Thread via GitHub
lhotari commented on PR #23231: URL: https://github.com/apache/pulsar/pull/23231#issuecomment-2329268594 > The remaining part is to add tests that reproduce the issues that this PR is addressing. I had the goal to add some system level tests, but that seems hard. I'll try to add some

Re: [PR] [Issue 1272][connection] Attempt to avoid deadlock during reconnection [pulsar-client-go]

2024-09-04 Thread via GitHub
Gilthoniel commented on PR #1273: URL: https://github.com/apache/pulsar-client-go/pull/1273#issuecomment-2329006780 It does not really change the issue that multiple reconnects will be attempted relentlessly until all callbacks have been processed. As mentioned in the issue, we can receive

(pulsar) branch master updated: [improve][broker] Add retry for start service unit state channel (ExtensibleLoadManagerImpl only) (#23230)

2024-09-04 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8bb30a1106e [improve][broker] Add retry for start s

Re: [PR] [improve][broker] Add retry for start service unit state channel (ExtensibleLoadManagerImpl only) [pulsar]

2024-09-04 Thread via GitHub
BewareMyPower commented on PR #23230: URL: https://github.com/apache/pulsar/pull/23230#issuecomment-2328757843 Let me merge it since there is no new response from @lhotari. Please open a new PR if you found something wrong. -- This is an automated message from the Apache Git Service. To r

Re: [PR] RPC framework implemented by the Pulsar client [pulsar-java-contrib]

2024-09-04 Thread via GitHub
Denovo1998 commented on code in PR #6: URL: https://github.com/apache/pulsar-java-contrib/pull/6#discussion_r1743625783 ## pulsar-rpc-contrib/src/main/java/org/apache/pulsar/rpc/contrib/client/package-info.java: ## @@ -0,0 +1,14 @@ +/* + * Licensed under the Apache License, Vers

[PR] [improve][admin] PIP-369 Change default value of `unload-scope` in `ns-isolation-policy set` [pulsar]

2024-09-04 Thread via GitHub
grssam opened a new pull request, #23253: URL: https://github.com/apache/pulsar/pull/23253 This PR is a followup to #23120 to make the backward incompatible change to: * Make the default value of `unload-scope` to `changed` * Change behavior of all_matching to cover both removed and add

Re: [I] [Bug] Non durable subscription backlog is wrong after topic unload [pulsar]

2024-09-04 Thread via GitHub
michalcukierman commented on issue #23239: URL: https://github.com/apache/pulsar/issues/23239#issuecomment-2328391960 I've added a PR with the failing test. The summary is at the bottom: ```java // It's OK to have a backlog, to re-consume a batch message assertEqu

(pulsar-client-go) branch master updated: [improve] stop timer when close timedAckGroupingTracker (#1279)

2024-09-04 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new be553141 [improve] stop timer when clo

Re: [PR] [fix][client] Fix broker/Client CPU reaching 100% during retriable connection failure [pulsar]

2024-09-04 Thread via GitHub
codecov-commenter commented on PR #23251: URL: https://github.com/apache/pulsar/pull/23251#issuecomment-2328099870 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments