Re: [PR] [revert][broker] Revert #24200: Cleanup OneWayReplicatorUsingGlobalPartitionedTest and OneWayReplicatorUsingGlobalZKTest [pulsar]

2025-04-24 Thread via GitHub
lhotari merged PR #24211: URL: https://github.com/apache/pulsar/pull/24211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
lhotari commented on PR #24209: URL: https://github.com/apache/pulsar/pull/24209#issuecomment-2829500677 > > @nodece I didn't review this yet, but just wondering if TenantInfo modifications contain a thread safety issue similar to #21303 which hasn't been addressed for TopicPolices. For Nam

Re: [PR] [improve] [broker ]Revert #24200: Cleanup OneWayReplicatorUsingGlobalPartitionedTest and OneWayReplicatorUsingGlobalZKTest [pulsar]

2025-04-24 Thread via GitHub
poorbarcode commented on PR #24211: URL: https://github.com/apache/pulsar/pull/24211#issuecomment-2829329398 > My intention was to allow targeted testing of global ZK behavior only when needed, by making OneWayReplicatorUsingGlobalZKTest and OneWayReplicatorUsingGlobalPartitionedTest fully

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
nodece commented on PR #24209: URL: https://github.com/apache/pulsar/pull/24209#issuecomment-2829308541 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
nodece commented on PR #24209: URL: https://github.com/apache/pulsar/pull/24209#issuecomment-2829292578 > @nodece I didn't review this yet, but just wondering if TenantInfo modifications contain a thread safety issue similar to #21303 which hasn't been addressed for TopicPolices. For Namesp

Re: [PR] [improve] [broker ]Revert #24200: Cleanup OneWayReplicatorUsingGlobalPartitionedTest and OneWayReplicatorUsingGlobalZKTest [pulsar]

2025-04-24 Thread via GitHub
nodece commented on PR #24211: URL: https://github.com/apache/pulsar/pull/24211#issuecomment-2829283336 Let me clarify the reasoning behind #24200 and why I chose to make the test classes independent. In Pulsar, we support both local ZooKeeper and global ZooKeeper modes. While cross-

(pulsar-site) branch main updated: Docs sync done from apache/pulsar (#dd58ec9)

2025-04-24 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new d787d927608 Docs sync done from apache/pulsar (

Re: [PR] [improve] [broker ]Revert #24200: Cleanup OneWayReplicatorUsingGlobalPartitionedTest and OneWayReplicatorUsingGlobalZKTest [pulsar]

2025-04-24 Thread via GitHub
poorbarcode commented on PR #24211: URL: https://github.com/apache/pulsar/pull/24211#issuecomment-2829096058 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [fix][broker] set broker healthcheck timeout correctly [pulsar]

2025-04-24 Thread via GitHub
heesung-sn merged PR #24198: URL: https://github.com/apache/pulsar/pull/24198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

(pulsar) branch master updated: [fix][broker] set broker healthcheck timeout correctly (#24198)

2025-04-24 Thread heesung
This is an automated email from the ASF dual-hosted git repository. heesung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new dd58ec9dd15 [fix][broker] set broker healthchec

(pulsar) branch master updated: [improve] Upgrade Apache Commons library versions to compatible versions (#24205)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0adc077127e [improve] Upgrade Apache Commons li

Re: [PR] [improve] Upgrade Apache Commons library versions to compatible versions [pulsar]

2025-04-24 Thread via GitHub
lhotari merged PR #24205: URL: https://github.com/apache/pulsar/pull/24205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [cleanup][test] Cleanup OneWayReplicatorUsingGlobalPartitionedTest and OneWayReplicatorUsingGlobalZKTest [pulsar]

2025-04-24 Thread via GitHub
poorbarcode commented on PR #24200: URL: https://github.com/apache/pulsar/pull/24200#issuecomment-2827963819 @nodece Sorry, I did not completely review this PR, I assumed that you added new tests in `OneWayReplicatorUsingGlobalZKTest` and `OneWayReplicatorUsingGlobalPartitionedTest`

Re: [PR] [improve] Upgrade Apache Commons library versions to compatible versions [pulsar]

2025-04-24 Thread via GitHub
codecov-commenter commented on PR #24205: URL: https://github.com/apache/pulsar/pull/24205#issuecomment-2828347469 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24205?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

(pulsar) branch branch-3.0 updated (0af42b1715a -> 6455b026a63)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 0af42b1715a [fix][test] Fix resource leaks in ProxyTest and fix invalid tests (#24204) new 2769cbeb407 [fix

(pulsar) 01/02: [fix][broker] Fix compaction service log's wrong condition (#24207)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 2769cbeb407e36ee5508c827513aaf1707fbe5da Author: fengyubiao AuthorDate: Thu Apr 24 15:23:14 2025 +0800 [fix][b

(pulsar) 02/02: [fix][broker] Fix broker shutdown delay by resolving hanging health checks (#24210)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 6455b026a6365a163bde8f683e066cdafa6df8c3 Author: Lari Hotari AuthorDate: Thu Apr 24 19:11:51 2025 +0300 [fix][

(pulsar) 01/02: [fix][broker] Fix compaction service log's wrong condition (#24207)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0c333d78688fbe6659abd1de05b29c970a01d670 Author: fengyubiao AuthorDate: Thu Apr 24 15:23:14 2025 +0800 [fix][b

(pulsar) 02/02: [fix][broker] Fix broker shutdown delay by resolving hanging health checks (#24210)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d9e5c03a995ddaff01917a3877e84a5ea30927a9 Author: Lari Hotari AuthorDate: Thu Apr 24 19:11:51 2025 +0300 [fix][

(pulsar) branch branch-3.3 updated (c0576d32741 -> d9e5c03a995)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git from c0576d32741 [fix][test] Fix resource leaks in ProxyTest and fix invalid tests (#24204) new 0c333d78688 [fix

(pulsar) 02/02: [fix][broker] Fix broker shutdown delay by resolving hanging health checks (#24210)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 606365ae8da75d2ff1b447a226151f8c283893f8 Author: Lari Hotari AuthorDate: Thu Apr 24 19:11:51 2025 +0300 [fix][

(pulsar) branch branch-4.0 updated (bacd1996507 -> 606365ae8da)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from bacd1996507 [fix][test] Fix resource leaks in ProxyTest and fix invalid tests (#24204) new 63444ed3f33 [fix

(pulsar) 01/02: [fix][broker] Fix compaction service log's wrong condition (#24207)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 63444ed3f337c305155ab8d773b633cf67d032b9 Author: fengyubiao AuthorDate: Thu Apr 24 15:23:14 2025 +0800 [fix][b

Re: [PR] [fix][broker] Fix broker shutdown delay by resolving hanging health checks [pulsar]

2025-04-24 Thread via GitHub
lhotari merged PR #24210: URL: https://github.com/apache/pulsar/pull/24210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated: [fix][broker] Fix broker shutdown delay by resolving hanging health checks (#24210)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 12961caf496 [fix][broker] Fix broker shutdown d

Re: [I] Flaky-test: BrokerRegistryMetadataStoreIntegrationTest.cleanup [pulsar]

2025-04-24 Thread via GitHub
lhotari closed issue #23413: Flaky-test: BrokerRegistryMetadataStoreIntegrationTest.cleanup URL: https://github.com/apache/pulsar/issues/23413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] [improve] [broker ]Revert #24200: Cleanup OneWayReplicatorUsingGlobalPartitionedTest and OneWayReplicatorUsingGlobalZKTest [pulsar]

2025-04-24 Thread via GitHub
poorbarcode opened a new pull request, #24211: URL: https://github.com/apache/pulsar/pull/24211 ### Motivation See also https://github.com/apache/pulsar/pull/24200#issuecomment-2827963819 > Sorry, I did not completely review #24200. I assumed that you added new tests in `OneWay

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
lhotari commented on PR #24209: URL: https://github.com/apache/pulsar/pull/24209#issuecomment-2827928250 @nodece I didn't review this yet, but just wondering if TenantInfo modifications contain a thread safety issue similar to #21303 which hasn't been addressed for TopicPolices. For Namespa

Re: [PR] [fix][broker] set broker healthcheck timeout correctly and set jetty shutdown timeout [pulsar]

2025-04-24 Thread via GitHub
lhotari commented on PR #24198: URL: https://github.com/apache/pulsar/pull/24198#issuecomment-2827908043 I made an alternative fix in #24210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [fix][broker] Fix broker shutdown delay by resolving hanging health checks [pulsar]

2025-04-24 Thread via GitHub
codecov-commenter commented on PR #24210: URL: https://github.com/apache/pulsar/pull/24210#issuecomment-2827866332 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] [fix][broker] Fix slow broker shutdown when there are on going health checks [pulsar]

2025-04-24 Thread via GitHub
lhotari opened a new pull request, #24210: URL: https://github.com/apache/pulsar/pull/24210 ### Motivation When there are on going health checks, the broker shutdown is very slow. ### Modifications - extract health check logic to HealthChecker class - implement logic t

Re: [I] Prometheus metric on publisher message compression ratio [pulsar-client-go]

2025-04-24 Thread via GitHub
arenko-be-interviews closed issue #1358: Prometheus metric on publisher message compression ratio URL: https://github.com/apache/pulsar-client-go/issues/1358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[I] Prometheus metric on publisher message compression ratio [pulsar-client-go]

2025-04-24 Thread via GitHub
jcass8695 opened a new issue, #1359: URL: https://github.com/apache/pulsar-client-go/issues/1359 Is your feature request related to a problem? Please describe. In our organisation we sink Pulsar messages for some topics directly to S3. It is useful for us to know the compression ratio tha

[I] Prometheus metric on publisher message compression ratio [pulsar-client-go]

2025-04-24 Thread via GitHub
arenko-be-interviews opened a new issue, #1358: URL: https://github.com/apache/pulsar-client-go/issues/1358 **Is your feature request related to a problem? Please describe.** In our organisation we sink Pulsar messages for some topics directly to S3. It is useful for us to know the compre

Re: [PR] [improve][io] Support Protobuf schema for Kafka source connector [pulsar]

2025-04-24 Thread via GitHub
jiangpengcheng closed pull request #23954: [improve][io] Support Protobuf schema for Kafka source connector URL: https://github.com/apache/pulsar/pull/23954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [improve][io] Support Protobuf schema for Kafka source connector [pulsar]

2025-04-24 Thread via GitHub
jiangpengcheng commented on code in PR #23954: URL: https://github.com/apache/pulsar/pull/23954#discussion_r2057994879 ## pulsar-io/kafka/pom.xml: ## @@ -104,6 +104,12 @@ ${confluent.version} + + io.confluent + kafka-protobuf-serializer Review Comme

Re: [PR] [improve][client] validate ClientConfigurationData earlier to avoid resource leaks [pulsar]

2025-04-24 Thread via GitHub
crossoverJie commented on PR #24187: URL: https://github.com/apache/pulsar/pull/24187#issuecomment-2827000532 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
nodece commented on code in PR #24209: URL: https://github.com/apache/pulsar/pull/24209#discussion_r2057949752 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java: ## @@ -272,27 +273,41 @@ protected CompletableFuture internalDeleteTenantAsyncForc

Re: [PR] [improve][client] PIP-391: Enable batch index ACK by default [pulsar]

2025-04-24 Thread via GitHub
nodece merged PR #24203: URL: https://github.com/apache/pulsar/pull/24203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

(pulsar) branch master updated: [improve][client] PIP-391: Enable batch index ACK by default (#24203)

2025-04-24 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0a9c439cd3b [improve][client] PIP-391: Enable ba

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
Copilot commented on code in PR #24209: URL: https://github.com/apache/pulsar/pull/24209#discussion_r2057945720 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java: ## @@ -272,27 +273,41 @@ protected CompletableFuture internalDeleteTenantAsyncFor

Re: [PR] [fix][broker] Fix tenant creation and update with null value [pulsar]

2025-04-24 Thread via GitHub
Copilot commented on code in PR #24209: URL: https://github.com/apache/pulsar/pull/24209#discussion_r2057935706 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java: ## @@ -172,18 +173,18 @@ public void updateTenant(@Suspended final AsyncResponse

Re: [PR] [fix][broker] set broker healthcheck timeout correctly and set jetty shutdown timeout [pulsar]

2025-04-24 Thread via GitHub
lhotari commented on code in PR #24198: URL: https://github.com/apache/pulsar/pull/24198#discussion_r2057806730 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/web/WebService.java: ## @@ -399,6 +399,7 @@ public void start() throws PulsarServerException { }

Re: [PR] [fix][broker] set broker healthcheck timeout correctly and set jetty shutdown timeout [pulsar]

2025-04-24 Thread via GitHub
lhotari commented on PR #24198: URL: https://github.com/apache/pulsar/pull/24198#issuecomment-2826737944 > Meanwhile, we better set the timeout for jetty shutdown to close the broker without too much delay. The default value for the shutdown timeout is 30 seconds. I think that it cou

Re: [D] When can we expect a new version for Pulsar Manager [pulsar]

2025-04-24 Thread via GitHub
GitHub user lhotari edited a comment on the discussion: When can we expect a new version for Pulsar Manager If you are looking for all CVEs to be addressed, it isn't realistic that it happens in the near future due to lack of volunteers contributing to https://github.com/apache/pulsar-manager

Re: [D] When can we expect a new version for Pulsar Manager [pulsar]

2025-04-24 Thread via GitHub
GitHub user lhotari added a comment to the discussion: When can we expect a new version for Pulsar Manager If you are looking for all CVEs to be addressed, it isn't realistic that it happens in the near future due to lack of volunteers contributing to https://github.com/apache/pulsar-manager

Re: [PR] [fix][broker] Fix compaction service log's wrong condition [pulsar]

2025-04-24 Thread via GitHub
lhotari merged PR #24207: URL: https://github.com/apache/pulsar/pull/24207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [fix][admin]Backlog quota's policy is null which causes a NPE [pulsar]

2025-04-24 Thread via GitHub
poorbarcode commented on code in PR #24192: URL: https://github.com/apache/pulsar/pull/24192#discussion_r2057744541 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3286,6 +3290,34 @@ public void testSetSubRateWithNoSub() throws Except

(pulsar) branch master updated: [fix][broker] Fix compaction service log's wrong condition (#24207)

2025-04-24 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bc9306f914f [fix][broker] Fix compaction servic

Re: [PR] [improve][io] Support Protobuf schema for Kafka source connector [pulsar]

2025-04-24 Thread via GitHub
lhotari commented on PR #23954: URL: https://github.com/apache/pulsar/pull/23954#issuecomment-2826624410 We cannot add a dependency on the `io.confluent:kafka-protobuf-serializer` library since it is under the Confluent Community License, as [briefly commented in an issue discussion](https

Re: [PR] [fix][broker]Fix compaction service log's wrong condition [pulsar]

2025-04-24 Thread via GitHub
poorbarcode commented on PR #24207: URL: https://github.com/apache/pulsar/pull/24207#issuecomment-2826588738 @lhotari > The impact isn't described at all. The impact seems to be that there would be invalid error logs for every compaction. Is that correct? > This change is a follow