Re: [I] Missing documentation about JWT auth [pulsar-helm-chart]

2025-08-07 Thread via GitHub
lhotari commented on issue #624: URL: https://github.com/apache/pulsar-helm-chart/issues/624#issuecomment-3166738007 @HaimKortovich It seems that it was added to a different section: https://github.com/apache/pulsar-helm-chart?tab=readme-ov-file#to-410 . Would you like to contribute improv

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on PR #24610: URL: https://github.com/apache/pulsar/pull/24610#issuecomment-3166695495 > > Btw. Not directly related to this PR, but could you check if there's any use for the PulsarClientException.InvalidMessageException that is thrown? Does it get used at all? I think th

Re: [I] [Bug] pulsar-common includes unnecessary transitive dependency on commons-configuration 2.x [pulsar]

2025-08-07 Thread via GitHub
lhotari closed issue #24611: [Bug] pulsar-common includes unnecessary transitive dependency on commons-configuration 2.x URL: https://github.com/apache/pulsar/issues/24611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
3pacc commented on code in PR #24610: URL: https://github.com/apache/pulsar/pull/24610#discussion_r2262023784 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ZeroQueueConsumerImpl.java: ## @@ -196,6 +196,29 @@ void receiveIndividualMessagesFromBatch(BrokerEntry

(pulsar) branch master updated: [fix][misc] Exclude commons-configuration2 and commons-beanutils in pulsar-common (#24612)

2025-08-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3d57c602a97 [fix][misc] Exclude commons-configu

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
3pacc commented on PR #24610: URL: https://github.com/apache/pulsar/pull/24610#issuecomment-3166691574 > Btw. Not directly related to this PR, but could you check if there's any use for the PulsarClientException.InvalidMessageException that is thrown? Does it get used at all? I think th

Re: [PR] [fix][misc] Exclude commons-configuration2 and commons-beanutils in pulsar-common [pulsar]

2025-08-07 Thread via GitHub
lhotari merged PR #24612: URL: https://github.com/apache/pulsar/pull/24612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated: [improve][broker]Remove block calling that named cursor.asyncGetNth when expiring messages (#24606)

2025-08-07 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d275bd4004a [improve][broker]Remove block cal

Re: [PR] [improve][broker]Remove block calling that named cursor.asyncGetNth when expiring messages [pulsar]

2025-08-07 Thread via GitHub
Technoboy- merged PR #24606: URL: https://github.com/apache/pulsar/pull/24606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [PR] [fix][ws] Fix WebSocket proxy originalPrincipal for HTTP admin API calls [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24613: URL: https://github.com/apache/pulsar/pull/24613#issuecomment-3166483655 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24613?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [fix][ws] Fix WebSocket proxy originalPrincipal for HTTP admin API calls [pulsar]

2025-08-07 Thread via GitHub
codelipenghui commented on PR #24613: URL: https://github.com/apache/pulsar/pull/24613#issuecomment-3165698606 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [fix][ws] Fix WebSocket proxy originalPrincipal for HTTP admin API calls [pulsar]

2025-08-07 Thread via GitHub
github-actions[bot] commented on PR #24613: URL: https://github.com/apache/pulsar/pull/24613#issuecomment-3165663846 @codelipenghui Please select only one documentation label in your PR description. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] [fix][ws] Fix WebSocket proxy originalPrincipal for HTTP admin API calls [pulsar]

2025-08-07 Thread via GitHub
codelipenghui opened a new pull request, #24613: URL: https://github.com/apache/pulsar/pull/24613 ## Motivation This is a follow-up fix to PR #24533 which addressed WebSocket authorization issues by introducing a dummy original principal for binary protocol connections, but missed th

[I] Missing documentation about JWT auth [pulsar-helm-chart]

2025-08-07 Thread via GitHub
HaimKortovich opened a new issue, #624: URL: https://github.com/apache/pulsar-helm-chart/issues/624 Jwt auth now has a new parameter needed (enabled: true) examples and documentation did not point to this values nor warned about in the upgrading documentation. -- This is an automated mes

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24610: URL: https://github.com/apache/pulsar/pull/24610#issuecomment-3165200803 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24610?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on code in PR #24610: URL: https://github.com/apache/pulsar/pull/24610#discussion_r2260877320 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ZeroQueueConsumerImpl.java: ## @@ -196,6 +196,29 @@ void receiveIndividualMessagesFromBatch(BrokerEntryMe

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on PR #24610: URL: https://github.com/apache/pulsar/pull/24610#issuecomment-3164963537 Btw. Not directly related to this PR, but could you check if there's any use for the PulsarClientException.InvalidMessageException that is thrown? Does it get used at all? I think that w

Re: [I] [Enhancement] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]

2025-08-07 Thread via GitHub
lhotari closed issue #24585: [Enhancement] Add dependency file name information to error message when .nar file validation fails with ZipException URL: https://github.com/apache/pulsar/issues/24585 -- This is an automated message from the Apache Git Service. To respond to the message, please

(pulsar) branch master updated: [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException (#24604)

2025-08-07 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2d5b0d6810a [improve][io] Add dependency file n

Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]

2025-08-07 Thread via GitHub
lhotari merged PR #24604: URL: https://github.com/apache/pulsar/pull/24604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [I] [Bug] pulsar-common includes unnecessary transitive dependency on commons-configuration 2.x [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on issue #24611: URL: https://github.com/apache/pulsar/issues/24611#issuecomment-3164930647 Fix in #24612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix][misc] Exclude commons-configuration2 and commons-beanutils in pulsar-common [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24612: URL: https://github.com/apache/pulsar/pull/24612#issuecomment-3164921005 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24612?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [I] [Bug] Unable to set bookie rack awareness using metadataServiceUri [pulsar]

2025-08-07 Thread via GitHub
saniyakadam230120 commented on issue #24455: URL: https://github.com/apache/pulsar/issues/24455#issuecomment-3164831142 This was solved by setting `metadataServiceUri=metadata-store:zk:pulsar-mini-zookeeper:2181`. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Bug] Unable to set bookie rack awareness using metadataServiceUri [pulsar]

2025-08-07 Thread via GitHub
saniyakadam230120 closed issue #24455: [Bug] Unable to set bookie rack awareness using metadataServiceUri URL: https://github.com/apache/pulsar/issues/24455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [improve][pip] PIP-434: Expose Netty channel configuration WRITE_BUFFER_WATER_MARK to pulsar conf and pause receive requests when channel is unwritable [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24510: URL: https://github.com/apache/pulsar/pull/24510#discussion_r2260734763 ## pip/pip-434.md: ## @@ -0,0 +1,76 @@ +# PIP-434: Expose Netty channel configuration WRITE_BUFFER_WATER_MARK to pulsar conf and pause receive requests when chann

Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24604: URL: https://github.com/apache/pulsar/pull/24604#issuecomment-3164799186 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24604?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] [fix][misc] Exclude commons-configuration2 and commons-beanutils in pulsar-common [pulsar]

2025-08-07 Thread via GitHub
lhotari opened a new pull request, #24612: URL: https://github.com/apache/pulsar/pull/24612 Fixes #24611 ### Motivation See #24611 and https://github.com/apache/bookkeeper/issues/4647 ### Modifications Exclude commons-configuration2 and commons-beanutils in pulsar-

Re: [PR] [improve][pip] PIP-434: Expose Netty channel configuration WRITE_BUFFER_WATER_MARK to pulsar conf and pause receive requests when channel is unwritable [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24510: URL: https://github.com/apache/pulsar/pull/24510#discussion_r2260605554 ## pip/pip-434.md: ## @@ -0,0 +1,76 @@ +# PIP-434: Expose Netty channel configuration WRITE_BUFFER_WATER_MARK to pulsar conf and pause receive requests when chann

Re: [I] [Bug] pulsar-common includes unnecessary transitive dependency on commons-configuration 2.x [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on issue #24611: URL: https://github.com/apache/pulsar/issues/24611#issuecomment-3164537702 BookKeeper issue is https://github.com/apache/bookkeeper/issues/4647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [fix][client]Prevent ZeroQueueConsumer from receiving batch messages when using MessagePayloadProcessor [pulsar]

2025-08-07 Thread via GitHub
3pacc commented on PR #24610: URL: https://github.com/apache/pulsar/pull/24610#issuecomment-3164502520 @lhotari I've added javadoc, please take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [Bug] pulsar-common includes unnecessary transitive dependency on commons-configuration 2.x [pulsar]

2025-08-07 Thread via GitHub
lhotari opened a new issue, #24611: URL: https://github.com/apache/pulsar/issues/24611 > Is it intended that upgrading to commons-configuration 2.x "leaks" commons-logging to the classpath? It did not before so it comes as a surprise in a patch release. Thanks for the feedback @snico

Re: [PR] [fix][sec] Remove dependency on out-dated commons-configuration 1.x [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on PR #24562: URL: https://github.com/apache/pulsar/pull/24562#issuecomment-3164446858 > Is it intended that upgrading to commons-configuration 2.x "leaks" commons-logging to the classpath? It did not before so it comes as a surprise in a patch release. Thanks for t

Re: [PR] [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on PR #24604: URL: https://github.com/apache/pulsar/pull/24604#issuecomment-3164415249 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [fix][sec] Remove dependency on out-dated commons-configuration 1.x [pulsar]

2025-08-07 Thread via GitHub
snicoll commented on PR #24562: URL: https://github.com/apache/pulsar/pull/24562#issuecomment-3164037541 Is it intended that upgrading to commons-configuration 2.x "leaks" commons-logging to the classpath? It did not before so it comes as a surprise in a patch release. -- This is an auto

(pulsar) branch master updated (7ab68b15c8c -> 66b512c4a5b)

2025-08-07 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 7ab68b15c8c [fix][test] Fix flaky EntryCacheManagerTest.simple (#24609) add 66b512c4a5b [improve][broker]Improve

Re: [PR] [improve][broker]Improve the anti-concurrency mechanism expirationCheckInProgress [pulsar]

2025-08-07 Thread via GitHub
poorbarcode merged PR #24607: URL: https://github.com/apache/pulsar/pull/24607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [PR] [improve][build]enable FindPublicAttributes check of SpotBugs [pulsar]

2025-08-07 Thread via GitHub
3pacc closed pull request #24285: [improve][build]enable FindPublicAttributes check of SpotBugs URL: https://github.com/apache/pulsar/pull/24285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [improve][broker]Improve the anti-concurrency mechanism expirationCheckInProgress [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24607: URL: https://github.com/apache/pulsar/pull/24607#issuecomment-3163607532 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24607?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259899284 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259899284 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259899284 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259899284 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259876043 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Softwar

Re: [I] Missing REAL_TOPIC in DLQ message when max deliveries exceeeds [pulsar-client-go]

2025-08-07 Thread via GitHub
RobertIndie closed issue #1388: Missing REAL_TOPIC in DLQ message when max deliveries exceeeds URL: https://github.com/apache/pulsar-client-go/issues/1388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24596: URL: https://github.com/apache/pulsar/pull/24596#issuecomment-3163394269 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24596?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

(pulsar-client-go) branch master updated: [Fix] DLQ Messages will lose system properties when sent from reconsumeLater() (#1392)

2025-08-07 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new b12eccc2 [Fix] DLQ Messages will lose sy

Re: [PR] [Fix] DLQ Messages will lose system properties when sent from reconsumeLater() [pulsar-client-go]

2025-08-07 Thread via GitHub
RobertIndie merged PR #1392: URL: https://github.com/apache/pulsar-client-go/pull/1392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] [improve][broker]Remove block calling that named cursor.asyncGetNth when expiring messages [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24606: URL: https://github.com/apache/pulsar/pull/24606#issuecomment-3163316130 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24606?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [improve][broker]Part-2 Add Admin API to delete topic policies [pulsar]

2025-08-07 Thread via GitHub
codecov-commenter commented on PR #24602: URL: https://github.com/apache/pulsar/pull/24602#issuecomment-3163304609 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24602?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259529184 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
poorbarcode commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259537163 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [improve][broker]Call scheduleWithFixedDelay instead of scheduleAtFixedRate [pulsar]

2025-08-07 Thread via GitHub
lhotari commented on code in PR #24596: URL: https://github.com/apache/pulsar/pull/24596#discussion_r2259484449 ## pulsar-common/src/main/java/org/apache/pulsar/common/util/SingleThreadSafeScheduledExecutorService.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the Apache Softwar

(pulsar) branch master updated: [fix][test] Fix flaky EntryCacheManagerTest.simple (#24609)

2025-08-07 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7ab68b15c8c [fix][test] Fix flaky EntryCacheM

Re: [I] Flaky-test: EntryCacheManagerTest.simple [pulsar]

2025-08-07 Thread via GitHub
Technoboy- closed issue #24608: Flaky-test: EntryCacheManagerTest.simple URL: https://github.com/apache/pulsar/issues/24608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix][test] Fix flaky EntryCacheManagerTest.simple [pulsar]

2025-08-07 Thread via GitHub
Technoboy- merged PR #24609: URL: https://github.com/apache/pulsar/pull/24609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar