[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-22 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865080247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For quer

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865476822 @codelipenghui https://github.com/apache/pulsar/pull/11009 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865472594 > ``` > Error: Tests run: 19, Failures: 5, Errors: 0, Skipped: 11, Time elapsed: 19.023 s <<< FAILURE! - in Master branch also has this problem -- This is an au

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865468882 I will fix this flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865080247 What if we set TTL? Compression may not be triggered in the future, because the threshold `brokerServiceCompactionThresholdInBytes` is not reached -- This is an automated m