[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-04-26 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-826773874 @zymap ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-04-20 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-823689937 Rebased to support 889b9b8e5efc62d2d0cbc761205fba5759c97af0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-04-15 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-820561514 @zymap @315157973 @hangc0276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-23 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-804719349 @codelipenghui Can you review too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-22 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-803940121 @sijie @zymap this is ready to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-21 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-803657557 @zymap @sijie can you rerun with more time before autocancel? And review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-18 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-802244383 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-18 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-801891017 rebased This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-14 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-798988339 @zymap @sijie can you trigger with more that 45min of run? This is an automated message from the Apache Git Serv

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-11 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-796800293 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-03-03 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-789869881 @sijie @zymap rebased This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-24 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-785085889 @zymap this PR is painful to maintain with multiple rebases, can you have a look quickly? This is an automated

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-24 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-784914049 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-12 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-778362011 @sijie @zymap are you ok? This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-10 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-777172053 @zymap @sijie can you review? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-10 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-777159446 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-10 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-776611079 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-10 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-776606883 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-09 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-776020646 In AuthorizationProducerConsumerTest.testSubscriberPermission, ```java // grant namespace-level authorization to the subscriptionRole tenantAdmin.namespaces().grantPe

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-02-09 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-776014685 @zymap can you run the pulsar-broker test for this branch and resolve the issue between allowTopicOperation and checkPermission for subscriptions. Can't make it work. I think yo

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2021-01-14 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-760280345 https://github.com/apache/pulsar/issues/9179 This is an automated message from the Apache Git Service. To respon

[GitHub] [pulsar] KannarFr commented on pull request #7523: [Issue 5720][authz] - add topics authz granularity

2020-08-12 Thread GitBox
KannarFr commented on pull request #7523: URL: https://github.com/apache/pulsar/pull/7523#issuecomment-672866523 @sijie A lot of conflicts due to 48f5a2f62c148b3df617be060fefed51f3145979 :o, anyway can you review this? This