RobertIndie commented on a change in pull request #12871:
URL: https://github.com/apache/pulsar/pull/12871#discussion_r752159272
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1989,7 +1989,7 @@ protected void
handleTcClientConnectRequest(CommandTcClientConnectRequest comman
});
}
- private boolean checkTransactionEnableAndSenError(long requestId) {
+ private boolean checkTransactionEnabled(long requestId) {
Review comment:
It would be confusing for developers if we removed the `SendError` here.
Because this method does have the send error process in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
