Shoothzj commented on a change in pull request #13502:
URL: https://github.com/apache/pulsar/pull/13502#discussion_r783663070



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java
##########
@@ -100,8 +100,7 @@ protected void doGet(HttpServletRequest request, 
HttpServletResponse response)
                     // this happens when metricsServletTimeoutMs expires
                     // java.lang.IllegalStateException: AsyncContext completed 
and/or Request lifecycle recycled
                     log.error("Failed to generate prometheus stats, "
-                                    + "this is likely due to 
metricsServletTimeoutMs: {} ms elapsed",
-                            time, e + "");
+                                    + "this is likely due to 
metricsServletTimeoutMs: {} ms elapsed", time);

Review comment:
       @eolivelli Does you mean 
   ```
                       log.error("Failed to generate prometheus stats, "
                                       + "this is likely due to 
metricsServletTimeoutMs: {} ms elapsed {}", time, e+"");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to