[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-908821889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-908852676 > Please add a test to check the final prometheus metric output result in `PrometheusMetricsTest` Yes, done. Thanks for reviewing. -- This is an automated message f

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-908821889 > LGTM. Thanks for addressing all of my feedback. Many thanks for your kind review. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-907157638 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-907098798 > @Technoboy- it could also be convenient to allow users to aggregate these metrics at a namespace level, but not a topic level. This would especially be helpful for users w

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-906196986 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-906013201 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-905577181 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Technoboy- commented on pull request #11739: Expose compaction metrics to Prometheus

Technoboy- commented on pull request #11739: URL: https://github.com/apache/pulsar/pull/11739#issuecomment-905498946 > very good. > > I left one comment about exposing an "Impl" class in PersistentTopic. > > PTAL Thanks for reviewing. -- This is an automated message f