[GitHub] [pulsar] Vanlightly commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-23 Thread GitBox
Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-903919478 @codelipenghui I've made those updates, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pulsar] Vanlightly commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-23 Thread GitBox
Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-903719592 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Vanlightly commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-19 Thread GitBox
Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-902025047 @315157973 @codelipenghui @lhotari I have pushed the change of ensuring all poll() calls go through the pinnedInternalExecutor to avoid threading issues. I didn't have to ma

[GitHub] [pulsar] Vanlightly commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-19 Thread GitBox
Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-901879130 @315157973 @codelipenghui I have an implementation based on the suggestion, there was just one complication: `failingPendingReceive()`. On `connectionOpened`, `closeAs

[GitHub] [pulsar] Vanlightly commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-18 Thread GitBox
Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-901139152 @315157973 we could look at something like that. The ConsumerImpl has its `internalPinnedExecutor` so could be leveraged to avoid multi-threaded calls by submitting some par

[GitHub] [pulsar] Vanlightly commented on pull request #11691: [Issue 11689][Client] Fixed block forever bug in Consumer.batchReceive

2021-08-18 Thread GitBox
Vanlightly commented on pull request #11691: URL: https://github.com/apache/pulsar/pull/11691#issuecomment-901139152 @315157973 we could look at something like that. The ConsumerImpl has its `internalPinnedExecutor` so could be leveraged to avoid multi-threaded calls by submitting some par