[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-26 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-619529110 That would be great. Otherwise I think we would have to do something like this: ```C++ const void *pulsar_message_id_set_topic(pulsar_message_id_t *messageId, const c

[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-26 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-619525256 Take a look at the internals of the `MessageId` class. It keeps a reference to a `std::string`. That means that to set a topic name, a `std::string` has to exist somewhere in memor

[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-26 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-619516449 Yes. I tried adding those functions to the C wrapper but I got stuck because `MessageId` takes a `std::string&` and there's no `std::string` in C, so nothing to take a reference of

[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-23 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-618379476 These are not quite the same bug. The problem with the go/C client is that there is no way to set the topic name in a message ID, whereas the problem with the Java library is that

[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-22 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-617676825 @codelipenghui I'm familiar with go, C and C++ and could fix the go API and/or the C code under `pulsar-client-cpp/lib/c`. The thing I don't understand is _how_ you want this fixed

[GitHub] [pulsar] bschofield commented on issue #6785: go client: message ID serialization / deserialization does not work with multi-topic consumers

2020-04-21 Thread GitBox
bschofield commented on issue #6785: URL: https://github.com/apache/pulsar/issues/6785#issuecomment-617285319 I rescind the last paragraph -- that was a bug in my code :sob:. So this bug still exists, but it is (probably) less critical.