codelipenghui commented on a change in pull request #10319:
URL: https://github.com/apache/pulsar/pull/10319#discussion_r622786325



##########
File path: 
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##########
@@ -331,11 +331,21 @@ public String getPersistenceNamingEncoding() {
      * @return
      */
     public String getLookupName() {
+        return getLookupName(null);
+    }
+
+    public String getLookupName(String listenerName) {

Review comment:
       It's better to build the url in the pulsar-admin, it's not suitable to 
use the TopicName to generate the request URL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to