[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-28 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r780097534 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -127,11 +130,15 @@ private final String client

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-19 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r787441104 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -643,6 +670,7 @@ String getHandlerName(

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-19 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r787417655 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -760,75 +785,86 @@ public void connectionOpened(fi

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-18 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r787353171 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -643,6 +670,7 @@ String getHandlerName(

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-08 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r780077192 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java ## @@ -546,15 +547,15 @@ public static ByteBuf newSubscr

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-07 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r780123526 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -86,6 +90,13 @@ protected final Lock reentran

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-07 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r780122613 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -387,6 +387,9 @@ message CommandSubscribe { optional KeySharedMeta keySharedM

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2022-01-07 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r780077192 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java ## @@ -546,15 +547,15 @@ public static ByteBuf newSubscr

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2021-12-30 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r776647452 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -217,7 +224,7 @@ public boolean readCompacted() {

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2021-12-29 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r776394773 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -1114,11 +1114,13 @@ publi

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2021-12-29 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r776373051 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -127,6 +129,11 @@ private final String clientA

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2021-09-30 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r719464344 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ReadOnlyCursor.java ## @@ -46,10 +46,11 @@ * @param callback

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2021-09-29 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r718509808 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -604,6 +605,8 @@ message CommandCloseConsumer { message CommandRedeliverUnacknowl

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10478: [Broker] PIP:84 Redeliver command add epoch.

2021-09-29 Thread GitBox
codelipenghui commented on a change in pull request #10478: URL: https://github.com/apache/pulsar/pull/10478#discussion_r718509808 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -604,6 +605,8 @@ message CommandCloseConsumer { message CommandRedeliverUnacknowl