codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-486222801
@merlimat I'm already create a PR https://github.com/apache/pulsar/pull/4120
to add a flag control enable or disable Key_Shared
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-486203058
@merlimat
> We have added feature flags on all major features. I think the downsides
of not having it greater exceed the bo
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-486046336
@merlimat
> This feature is not well tested as the rest of the code. Administrators
must be able to decide whether they wan
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-486020472
@merlimat
Do you mean add a flag in broker level to enable/disable the Key_Shared
subscription? What you are worried about
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-485333461
run java8 tests
This is an automated message from the Apache G
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-485206863
run java8 tests
run cpp tests
This is an automated message
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core
implementation.
URL: https://github.com/apache/pulsar/pull/4079#issuecomment-485042787
run java8 tests
run cpp tests
run Integration Tests
This
